Project

General

Profile

Actions

feature request #4908

closed

adding convert Team to Person and Person to Team to the bulk editor

Added by Katja Luther about 7 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Priority12
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

the functionality convert team to person and person to team should be available in the agent bulk editor.

related tickets: #4769, #4770

Open issues (see comments):

  • German translation for both converters is still missing.

  • Error messages should be more specific

  • Shorten menu item label

  • Correct title for error dialog

  • Give more specific information why person can not be converted to team (new ticket ?) => #9361


Related issues

Related to EDIT - feature request #4769: Allow convert team to personClosedAndreas Müller

Actions
Related to EDIT - feature request #4770: Allow convert person to teamClosedAndreas Müller

Actions
Related to EDIT - bug #5163: Converting persons to team members may result in "-empty team-"ClosedAndreas Müller

Actions
Related to EDIT - bug #9362: Convert Team to Person and vice versa saves immediatelyNewKatja Luther

Actions
Copied to EDIT - feature request #9361: Give more specific information why person can not be converted to teamNewKatja Luther

Actions
Actions #1

Updated by Katja Luther about 7 years ago

  • Status changed from New to Resolved
  • Assignee changed from k.luther - to Andreas Müller

implemented in r23831

Actions #2

Updated by Andreas Müller about 7 years ago

  • Assignee changed from Andreas Müller to k.luther -

German translation for both converters is still missing.

Actions #3

Updated by Andreas Müller almost 7 years ago

If an error occurs during convert only a popup appears saying that there was an error but even no stacktrace. We should at least use standard MessageUtil error handling or even better specific error handling.

This problem was easy to reproduce while saving of new authors did not work correctly (#4907). As this is fixed now I can't easily reproduce. However, correct error handling should be easy to implement.

Actions #4

Updated by Andreas Müller almost 7 years ago

I think it is enough to label the menu items "Convert to team" and "Convert to person". As we show the type in grey it should be clear what the current type is.

Actions #5

Updated by Andreas Müller almost 7 years ago

If a person is to be transformed into a team but this is not possible the error dialog title says "Can not convert Team to Person" but should say "Can not convert person to team".

Also we may think about more specific information why transformation is not possible

Actions #6

Updated by Katja Luther almost 7 years ago

  • Status changed from Resolved to Closed
  • Resolution set to fixed
  • % Done set to 100
  • Target version changed from TaxEditor RELEASE 3.6.0 to Release 3.7

the pop up is now a MessagingUtils.errorDialog(...), the german translation is added, the exception handling is improved.

e984ad30adf923b8ad5b8b8e991d7d5aea1305ee (hash git)

Actions #7

Updated by Andreas Müller almost 7 years ago

  • Status changed from Closed to Feedback
  • Resolution deleted (fixed)
  • % Done changed from 100 to 0
Actions #8

Updated by Andreas Müller almost 7 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from k.luther - to Andreas Müller
Actions #9

Updated by Andreas Müller over 1 year ago

Actions #10

Updated by Andreas Müller over 1 year ago

Actions #11

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • % Done changed from 0 to 80
  • Private changed from Yes to No
Actions #12

Updated by Andreas Müller over 1 year ago

  • Description updated (diff)
  • Status changed from Resolved to Closed

Open issues fixed or moved to new ticket.

Actions #13

Updated by Andreas Müller over 1 year ago

  • % Done changed from 80 to 100
Actions #14

Updated by Andreas Müller over 1 year ago

  • Copied to feature request #9361: Give more specific information why person can not be converted to team added
Actions #15

Updated by Andreas Müller over 1 year ago

  • Related to bug #5163: Converting persons to team members may result in "-empty team-" added
Actions #16

Updated by Andreas Müller over 1 year ago

  • Related to bug #9362: Convert Team to Person and vice versa saves immediately added
Actions

Also available in: Atom PDF