Project

General

Profile

bug #9467

AssertionFailedException when opening DefaultFeatureTreePreference and preference should not allow multi-select

Added by Katja Luther 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
02/12/2021
Due date:
% Done:

70%

Severity:
normal
Found in Version:

Description

The label provider for DefaultFeatureTreePreferences implements IBaseLabelProvider but should ILabelProvider.

last remote method : http://api.cybertaxonomy.org:80/flora-greece/remoting/preference.service
last remote request client time : 2021-02-11T09:02:47.979
last remote request response header time : Thu, 11 Feb 2021 09:02:48 GMT
client error time : 2021-02-11T09:02:50.12
login : admin
editor version : 5.19.0
server : api.cybertaxonomy.org (cybertaxonomy.org) / flora-greece
schema version : 5.18.6.0.20201124
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
                at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
                at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
                at org.eclipse.jface.viewers.AbstractListViewer.setLabelProvider(AbstractListViewer.java:470)
                at eu.etaxonomy.taxeditor.preference.DefaultFeatureTreePreferenecs.createTextTreeSelection(DefaultFeatureTreePreferenecs.java:74)
                at eu.etaxonomy.taxeditor.preference.DefaultFeatureTreePreferenecs.createContents(DefaultFeatureTreePreferenecs.java:59)
                at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:241)
                at eu.etaxonomy.taxeditor.preference.menu.CdmPreferencePage.createControl(CdmPreferencePage.java:63)
                at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1430)
                at org.eclipse.jface.preference.PreferenceDialog$9.run(PreferenceDialog.java:1197)
                at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
                at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
                at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
                at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1189)
                at org.eclipse.jface.preference.PreferenceDialog$5.lambda$0(PreferenceDialog.java:656)
                at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
                at org.eclipse.jface.preference.PreferenceDialog$5.selectionChanged(PreferenceDialog.java:653)
                at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:878)
                at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
                at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
                at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
                at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:875)
                at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:1244)
                at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:1270)
                at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:265)
                at org.eclipse.jface.util.OpenStrategy.access$5(OpenStrategy.java:259)
                at org.eclipse.jface.util.OpenStrategy$1.lambda$1(OpenStrategy.java:431)
                at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
                at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182)
                at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4211)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3827)
                at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
                at org.eclipse.jface.window.Window.open(Window.java:794)
                at eu.etaxonomy.taxeditor.workbench.handler.OpenPreferencesHandler.execute(OpenPreferencesHandler.java:124)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                at java.lang.reflect.Method.invoke(Method.java:498)
                at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:55)
                at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:282)
                at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:264)
                at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
                at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:152)
                at org.eclipse.core.commands.Command.executeWithChecks(Command.java:494)
                at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:488)
                at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:210)
                at org.eclipse.e4.ui.workbench.renderers.swt.HandledContributionItem.executeItem(HandledContributionItem.java:433)
                at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem.handleWidgetSelection(AbstractContributionItem.java:454)
                at org.eclipse.e4.ui.workbench.renderers.swt.AbstractContributionItem$3.handleEvent(AbstractContributionItem.java:482)
                at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
                at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
                at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4236)
                at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3824)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022)
                at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150)
                at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:693)
                at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
                at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:610)
                at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148)
                at eu.etaxonomy.taxeditor.Application.start(Application.java:20)
                at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
                at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
                at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                at java.lang.reflect.Method.invoke(Method.java:498)
                at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673)
                at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610)
                at org.eclipse.equinox.launcher.Main.run(Main.java:1519)

picture658-1.png View (7.35 KB) Andreas Müller, 02/25/2021 08:56 AM

Associated revisions

Revision 4a2263a6 (diff)
Added by Katja Luther 8 months ago

ref #9467: TermTreeLabelProvider should implement ILabelProvider

Revision db56c41b (diff)
Added by Katja Luther 8 months ago

ref #9467: do not allow multi select

Revision 4a39cb5e (diff)
Added by Katja Luther 8 months ago

ref #9467: do not allow multiselect and order of elements

History

#1 Updated by Katja Luther 8 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 0 to 50

This should be fixed, please review.

#2 Updated by Andreas Müller 8 months ago

  • Subject changed from AssertionFailedException when opening DefaultFeatureTreePreference to AssertionFailedException when opening DefaultFeatureTreePreference and preference should not allow multi-select
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 60

This is fixed and can be closed.

By the way the default feature tree preference page allows multi-select (but stores only 1 default feature tree). This should be fixed. Multi-select does not make sense here. Can we fix this witin this ticket as it is probably a no-brainer.

#3 Updated by Katja Luther 8 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 60 to 70

Andreas Müller wrote:

This is fixed and can be closed.

By the way the default feature tree preference page allows multi-select (but stores only 1 default feature tree). This should be fixed. Multi-select does not make sense here. Can we fix this witin this ticket as it is probably a no-brainer.

fixed

#4 Updated by Andreas Müller 8 months ago

  • File picture658-1.png View added
  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Multi-select is still possible:

#5 Updated by Andreas Müller 8 months ago

Wir sollten auch das Label noch anpassen für beide Fenster.

Im Deutschen: Default Merkmalsbaum => Standard Merkmalsbaum

... für textuelle Faktendaten => was ist da gemeint? Wo wird der benutzt? Ist das für die natural language description Darstellung? Dann sollte es so ähnlich heißen, also z.B. für natürlichsprachige Beschreibungen (wir können hier Beschreibungen lassen, da es in dem Fall ja eigentlich immer um Beschreibungen im engeren Sinne geht). Im Englischen dann ... for natural language descriptions

... für strukturelle Faktendaten: wo wird der benutzt? Nur im Factual Data View? Dann würde ich es auch so nennen, also ... für die Faktendaten Sicht (oder wie das im deutschen übersetzt ist). Wobei wir da ja leider die Baumdarstellung noch gar nicht wirklich benutzen

#6 Updated by Andreas Müller 8 months ago

Außerdem sollten wir die Reihenfolge ändern, die nat. lang. descriptions sind unwichtig, und sollten daher nach unten

#7 Updated by Katja Luther 8 months ago

Andreas Müller wrote:

Wir sollten auch das Label noch anpassen für beide Fenster.

Im Deutschen: Default Merkmalsbaum => Standard Merkmalsbaum

... für textuelle Faktendaten => was ist da gemeint? Wo wird der benutzt? Ist das für die natural language description Darstellung? Dann sollte es so ähnlich heißen, also z.B. für natürlichsprachige Beschreibungen (wir können hier Beschreibungen lassen, da es in dem Fall ja eigentlich immer um Beschreibungen im engeren Sinne geht). Im Englischen dann ... for natural language descriptions

... für strukturelle Faktendaten: wo wird der benutzt? Nur im Factual Data View? Dann würde ich es auch so nennen, also ... für die Faktendaten Sicht (oder wie das im deutschen übersetzt ist). Wobei wir da ja leider die Baumdarstellung noch gar nicht wirklich benutzen

they both are used in factual data view, it depends on the elements, if they contain quantitative or categorical data, the feature tree for structured factual data is used otherwise the default feature tree for textual factual data.

#8 Updated by Andreas Müller 8 months ago

Katja Luther wrote:

Andreas Müller wrote:

Im Deutschen: Default Merkmalsbaum => Standard Merkmalsbaum

Is this fixed?

#9 Updated by Katja Luther 8 months ago

Andreas Müller wrote:

Katja Luther wrote:

Andreas Müller wrote:

Im Deutschen: Default Merkmalsbaum => Standard Merkmalsbaum

Is this fixed?

yes.

#10 Updated by Andreas Müller 8 months ago

Katja Luther wrote:

Andreas Müller wrote:

Wir sollten auch das Label noch anpassen für beide Fenster.

Im Deutschen: Default Merkmalsbaum => Standard Merkmalsbaum

... für textuelle Faktendaten => was ist da gemeint? Wo wird der benutzt? Ist das für die natural language description Darstellung? Dann sollte es so ähnlich heißen, also z.B. für natürlichsprachige Beschreibungen (wir können hier Beschreibungen lassen, da es in dem Fall ja eigentlich immer um Beschreibungen im engeren Sinne geht). Im Englischen dann ... for natural language descriptions

... für strukturelle Faktendaten: wo wird der benutzt? Nur im Factual Data View? Dann würde ich es auch so nennen, also ... für die Faktendaten Sicht (oder wie das im deutschen übersetzt ist). Wobei wir da ja leider die Baumdarstellung noch gar nicht wirklich benutzen

they both are used in factual data view, it depends on the elements, if they contain quantitative or categorical data, the feature tree for structured factual data is used otherwise the default feature tree for textual factual data.

Ok, so it is somehow correct but not clear how this should work. Generally the "tree" handling does not work yet in Factual Data View but this is an other ticket. We can handle the handling of the 2 different trees there.

#11 Updated by Katja Luther 8 months ago

  • Assignee changed from Katja Luther to Andreas Müller

so we can close this ticket?

#12 Updated by Andreas Müller 8 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

Multi-select is still possible:

If this is fixed, yes.

#13 Updated by Katja Luther 8 months ago

  • Status changed from Feedback to Closed

Andreas Müller wrote:

Andreas Müller wrote:

Multi-select is still possible:

If this is fixed, yes.

this is fixed.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)