Project

General

Profile

Actions
Copy link

bug #9384

closed

DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members

Added by Andreas Kohlbecker over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Andreas Müller
Category:
cdmlib
Target version:
Release 5.19
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
critical
Found in Version:
Tags:
phycobank

Description

see https://api.phycobank.org/phycobank/registrationDTO.json?identifier=http://phycobank.org/102662

The Team "Molinari Novoa, E.A. & Guiry, M.D.R." is truncated to "Molinari Novoa & al. 2020",

Related issues

Related to EDIT - feature request #9279: Improve type designation formatting and TypeDesignationSetManagerClosedAndreas Müller

Actions
Actions
Copy link
 #1

Updated by Andreas Kohlbecker over 3 years ago

  • Tags set to phycobank
  • Description updated (diff)
  • Category set to cdmlib
  • Assignee set to Andreas Kohlbecker
  • Priority changed from New to Highest
  • Target version changed from Unassigned CDM tickets to Release 5.19
  • Severity changed from normal to critical
Actions
Copy link
 #2

Updated by Andreas Kohlbecker over 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #3

Updated by Andreas Kohlbecker over 3 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

please review

Tests for this method are missing and should be implemented asap. Please could you open a new ticket for that.

Actions
Copy link
 #4

Updated by Andreas Müller over 3 years ago

  • Related to feature request #9279: Improve type designation formatting and TypeDesignationSetManager added
Actions
Copy link
 #5

Updated by Andreas Müller over 3 years ago

  • Assignee changed from Andreas Müller to Andreas Kohlbecker

The fix was not fully correct as it created teams like Name1, Name2 & al. but there should be always a maximum number of 2 names only. So only Name1 or Name1 & Name2 or Name1 et al. is allowed.

I fixed it and added tests (by the way there were some indirect tests in TypeDesignationSetManagerTest, but they were not enough, but at least the reason why I found that the new implementation was not correct either).

Please review.

Actions
Copy link
 #6

Updated by Andreas Kohlbecker over 3 years ago

  • Subject changed from DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with twi members to DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
Actions
Copy link
 #7

Updated by Andreas Kohlbecker over 3 years ago

  • Assignee changed from Andreas Kohlbecker to Andreas Müller

The implementation is correct as far as the the implemented formatting rule for more than two authors is holding true.
Is this rule embodied in the ICN and also the same in other codes? The ticket can be closed if the answer to this question is yes.

Actions
Copy link
 #8

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

as we talk about bibliographic references here the ICN (or any other code) is not relevant here. It is the rule I have seen at many places and also shortly discussed with RH for cyprus.
In general the formatting should be project specific. But this requires project specific cache strategies which currently does not yet exist.

I close the ticket. Please reopen if you think more discussion is needed.

Actions
Copy link

Also available in: Atom PDF