Project

General

Profile

bug #9351

Include new locations for cdmlib-print and cdmlib-remote in jenkins release script

Added by Andreas Müller 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Highest
Category:
taxeditor
Target version:
Start date:
08/26/2020
Due date:
% Done:

100%

Severity:
blocker
Found in Version:

Description

cdmlib-print and cdmlib-remote are now only available in taxeditor.printpublisher.

Therefore the according links to the libraries are now located in the printpublisher Manifest.MF and build.properties, not in taxeditor.cdmlib anymore.

The release scripts need to be adapted accordingly.

This is critical because the provision job for taxeditor does not work otherwise.


Related issues

Related to Edit - feature request #9204: Update cdmlib and taxeditor dependencies Closed 08/20/2020
Follows Edit - task #9208: Move cdmlib-print and cdmib-remote to taxeditor.printpublisher Closed 08/25/2020
Copied from Edit - task #9359: Update cdmlib and taxeditor dependencies In Progress 12/18/2020

Associated revisions

Revision 76af2015 (diff)
Added by Andreas Müller 5 months ago

ref #9351 fix cdmlib-print and -remote version in TaxEditor master

Revision bb3bba46 (diff)
Added by Andreas Müller 5 months ago

ref #9351 fix cdmlib-print and -remote version in TaxEditor develop

History

#1 Updated by Andreas Müller 6 months ago

#2 Updated by Andreas Müller 6 months ago

  • Due date set to 08/26/2020
  • Start date changed from 12/08/2020 to 08/26/2020
  • Follows task #9208: Move cdmlib-print and cdmib-remote to taxeditor.printpublisher added

#3 Updated by Andreas Müller 6 months ago

  • Due date deleted (08/26/2020)

#4 Updated by Andreas Müller 6 months ago

  • Copied from task #9359: Update cdmlib and taxeditor dependencies added

#5 Updated by Andreas Kohlbecker 5 months ago

  • Target version changed from Release 5.19 to Release 5.21

#6 Updated by Andreas Kohlbecker 5 months ago

  • Status changed from New to Feedback
  • Assignee changed from Andreas Kohlbecker to Andreas Müller

This ticket is unclear to me what is meant with "jenkins release script"?

I checked server-scripts/jenkins-ci/taxeditor/ and could not find anything related.

So this must refer to the jenkins jobs directly but none of these configfiles contains any line with "SNAPSHOT" or "print":

./taxeditor-SA-JRE-INTEGRATION/config.xml
./taxeditor-SITE-DEPLOY/config.xml
./taxeditor-INTEGRATION/config.xml
./taxeditor-SA-INTEGRATION/config.xml
./taxeditor-PROVISION/config.xml
./taxeditor-SNAPSHOT/config.xml
./taxeditor-JRE-INTEGRATION/config.xml
./taxeditor-RLS-FINISH/config.xml
./taxeditor-HFX-START/config.xml
./taxeditor-JRE-SNAPSHOT/config.xml
./taxeditor-RLS-START/config.xml
./taxeditor-parent-SITE-DEPLOY/config.xml
./taxeditor-HFX-FINISH/config.xml

Are you 100% sure that there is anything that need to be changed in jenkins?

#7 Updated by Andreas Müller 5 months ago

  • Status changed from Feedback to In Progress
  • Assignee changed from Andreas Müller to Andreas Kohlbecker

Please refer to my commits above. This changing of the version in eu.etaxonomy.taxeditor.printpublisher/META-INF/MANIFEST.MF and eu.etaxonomy.taxeditor.printpublisher/build.properties similar to what we do in poms.

#8 Updated by Andreas Müller 5 months ago

Änderung ist: cdmlib-remote und cdmlib-print waren bislang dependencies von taxeditor.cdmlib. Jetzt sind es nur noch dependencies von taxeditor.printpublisher. Daher müssen jetzt die ManifestMF und die build.properties von taxeditor.printpublisher geupdated werden, genauso wie auch die ManifestMF und build.properties in taxeditor.cdmlib geupdated werden. Letzteres funktioniert auch weiterhin, aber eben nicht für remote und print da diese jetzt eben nur in der ManifestMF und build.properties von printpublisher stehen.

#9 Updated by Andreas Kohlbecker 5 months ago

the following lines in server-scripts/jenkins-ci/taxeditor/repo-update-git.sh need to be adapted, so that the "ManifestMF und die build.properties von taxeditor.printpublisher geupdated werden":

#update the cdmlib.version (and taxeditor.version) values in the parent pom.xml to $cdmlib_version
if [ -n "${cdmlib_version}" ]; then
    $_my_path/taxedUpdateConfig.pl $cdmlib_version
    #update cdmlib jars 
    cd $WORKSPACE/eu.etaxonomy.taxeditor.cdmlib
    #update MANIFEST.MF, classpath and build files to keep eclipse environment consistent
    sed -i "s/\(lib\/cdmlib\-.*-\)[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+\(-SNAPSHOT\)\?\(\(-sources\)\?\.jar\)/\1$cdmlib_version\3/g" ./META-INF/MANIFEST.MF
    # no longer needed since #4227 is completed:
    # sed -i "s/\(lib\/cdmlib\-.*-\)[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+\(-SNAPSHOT\)\?\(\.jar\)/\1$cdmlib_version\3/g;s/\(lib\/cdmlib\-.*-\)[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+\(-SNAPSHOT\)\?\(-sources\.jar\)/\1$cdmlib_version\3/g" ./.classpath
    sed -i "s/\(lib\/cdmlib\-.*-\)[[:digit:]]\+\.[[:digit:]]\+\.[[:digit:]]\+\(-SNAPSHOT\)\?\(\(-sources\)\?\.jar\)/\1$cdmlib_version\3/g" ./build.properties
fi
  1. create a function for that!
  2. make a dry run to test the script

#10 Updated by Andreas Kohlbecker 4 months ago

  • Target version changed from Release 5.21 to Release 5.20

#11 Updated by Andreas Kohlbecker 4 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

fixed in server-scripts:

 svn ci -m "ref #9351 support for setting version in multiple projects & fixing some problems"                                                                                 ─╯
Sending        repo-update-git.sh
Transmitting file data .done
Committing transaction...
Committed revision 29014.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)