Deduplication does not work in new taxon dialog
When creating a new taxon including nomenclatural reference via new taxon dialog the data is saved but it seems not to be deduplicated.
It was tested in caryo_spp where deduplication did not take place in new taxon dialog while it took place in name editor.
An example was probably something like "Dianthus fruticosus subsp. amorginus Runemark in Bot. Not. 133(4): 485. 1980" where "Bot. Not. 133(4). 1980" was already in the database (with many duplicates).
#1 Updated by Katja Luther over 1 year ago
- Status changed from New to Resolved
- % Done changed from 0 to 50
Applied in changeset taxeditor|2e5addbf1470b86b929e7e4ca4fc0f0eebb291f6.
#4 Updated by Andreas Müller over 1 year ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 0 to 90
It seems to work as expected. Only I wonder why parseAndResolveDuplicates is not a static function while parseReferencedName is static in the ParserHandler. Deduplication does not seem to be instance specific (e.g. link to duplication resolver is stored in the instance) therefore it could be static which simplifies the code. (but a very minor issue).
Feel free to close ticket.