Project

General

Profile

bug #7941

Deduplication does not work in new taxon dialog

Added by Andreas Müller 5 months ago. Updated 4 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
12/06/2018
Due date:
% Done:

90%

Severity:
normal
Found in Version:

Description

When creating a new taxon including nomenclatural reference via new taxon dialog the data is saved but it seems not to be deduplicated.

It was tested in caryo_spp where deduplication did not take place in new taxon dialog while it took place in name editor.

An example was probably something like "Dianthus fruticosus subsp. amorginus Runemark in Bot. Not. 133(4): 485. 1980" where "Bot. Not. 133(4). 1980" was already in the database (with many duplicates).

Associated revisions

Revision 2e5addbf (diff)
Added by Katja Luther 5 months ago

fix #7941: use the same parser method in new taxonnode wizard as in name editor

History

#1 Updated by Katja Luther 5 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Katja Luther 5 months ago

  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 0

this should be fixed with the changing the parsing method to the same as in name editor. please review.

#3 Updated by Andreas Müller 4 months ago

  • Description updated (diff)

#4 Updated by Andreas Müller 4 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 90

It seems to work as expected. Only I wonder why parseAndResolveDuplicates is not a static function while parseReferencedName is static in the ParserHandler. Deduplication does not seem to be instance specific (e.g. link to duplication resolver is stored in the instance) therefore it could be static which simplifies the code. (but a very minor issue).

Feel free to close ticket.

#5 Updated by Katja Luther 4 months ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)