Project

General

Profile

Actions
Copy link

bug #7941

closed

Deduplication does not work in new taxon dialog

Added by Andreas Müller over 5 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
New
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.5
Start date:
Due date:
% Done:

90%

Estimated time:
Severity:
normal
Found in Version:

Description

When creating a new taxon including nomenclatural reference via new taxon dialog the data is saved but it seems not to be deduplicated.

It was tested in caryo_spp where deduplication did not take place in new taxon dialog while it took place in name editor.

An example was probably something like "Dianthus fruticosus subsp. amorginus Runemark in Bot. Not. 133(4): 485. 1980" where "Bot. Not. 133(4). 1980" was already in the database (with many duplicates).

Actions
Copy link
 #1

Updated by Katja Luther over 5 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50
Actions
Copy link
 #2

Updated by Katja Luther over 5 years ago

  • Assignee changed from Katja Luther to Andreas Müller
  • % Done changed from 50 to 0

this should be fixed with the changing the parsing method to the same as in name editor. please review.

Actions
Copy link
 #3

Updated by Andreas Müller about 5 years ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Andreas Müller about 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 90

It seems to work as expected. Only I wonder why parseAndResolveDuplicates is not a static function while parseReferencedName is static in the ParserHandler. Deduplication does not seem to be instance specific (e.g. link to duplication resolver is stored in the instance) therefore it could be static which simplifies the code. (but a very minor issue).

Feel free to close ticket.

Actions
Copy link
 #5

Updated by Katja Luther about 5 years ago

  • Status changed from Feedback to Closed
Actions
Copy link

Also available in: Atom PDF