Project

General

Profile

bug #6526

Show types in correct order

Added by Patrick Plitzner over 1 year ago. Updated 7 months ago.

Status:
Closed
Priority:
New
Category:
taxeditor
Target version:
Start date:
03/20/2017
Due date:
% Done:

100%

Severity:
normal
Found in Version:

Description

Correct order starts with Holotype –> Lectotype –> Iso(lecto)type and ends with the rest

picture246-1.png View (8.93 KB) Andreas Müller, 05/14/2018 04:35 PM


Related issues

Related to Edit - feature request #6718: Constistent TypeDesignation representation creation New 06/12/2017
Related to Edit - feature request #7384: Order SpecimenTypeDesignationStatus according to new order in vocabulary Closed 04/27/2018

Associated revisions

Revision acd1721b (diff)
Added by Patrick Plitzner 10 months ago

ref #6526 Added comparator for type designations

Revision a120b5f6 (diff)
Added by Patrick Plitzner 8 months ago

ref #6526 extract comparator and add another for TypeDesignationBase

Revision 5f727043 (diff)
Added by Patrick Plitzner 8 months ago

ref #6526 Use type designation comparator from cdmlib

Revision 4ce7e0da (diff)
Added by Patrick Plitzner 7 months ago

ref #6526 Fix generics of comparator

Revision b5f145fd (diff)
Added by Patrick Plitzner 7 months ago

ref #6526 Use comparator for type designation status combo

History

#3 Updated by Patrick Plitzner over 1 year ago

  • Target version changed from Unassigned CDM tickets to Release 4.7

#4 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 4.7 to Release 4.8

#5 Updated by Andreas Kohlbecker over 1 year ago

#6 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 4.8 to Release 4.9

#7 Updated by Andreas Müller over 1 year ago

  • Target version changed from Release 4.9 to Release 4.10

#8 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.10 to Release 4.11

#9 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.11 to Release 4.12

#10 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.12 to Release 4.13

#11 Updated by Andreas Müller 11 months ago

  • Target version changed from Release 4.13 to Release 4.14

#12 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 4.14 to Release 5.0

#13 Updated by Patrick Plitzner 10 months ago

  • Status changed from New to Feedback
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 30

I added a comparator which sorts according to the designation status defined by the ordered terms. But this order does not confirm with the order proposed in this ticket. Should we change the order in of the ordered terms rather than changing the comparator?

#14 Updated by Andreas Müller 8 months ago

  • Related to feature request #7384: Order SpecimenTypeDesignationStatus according to new order in vocabulary added

#15 Updated by Andreas Müller 8 months ago

  • Assignee changed from Andreas Müller to Patrick Plitzner

Yes this is a good idea. I created a related ticket: #7384

Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)

@AK: do you have a defined order for type designations status in phycobank?

#16 Updated by Andreas Kohlbecker 8 months ago

Andreas Müller wrote:

Yes this is a good idea. I created a related ticket: #7384

Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)

@AK: do you have a defined order for type designations status in phycobank?

Yes I do!

The order logic is implemented in LinkedHashMap<TypedEntityReference, TypeDesignationWorkingSet> eu.etaxonomy.cdm.api.service.name.TypeDesignationSetManager.orderByTypeByBaseEntity(Map<TypedEntityReference, TypeDesignationWorkingSet> stringsByTypeByBaseEntity)

If you move the second anonymous Comparator class into its own class file you can use it for to solve this issue here.

Andreas

#17 Updated by Patrick Plitzner 8 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 30 to 50

Andreas Kohlbecker wrote:

Andreas Müller wrote:

Yes this is a good idea. I created a related ticket: #7384

Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)

@AK: do you have a defined order for type designations status in phycobank?

Yes I do!

The order logic is implemented in LinkedHashMap<TypedEntityReference, TypeDesignationWorkingSet> eu.etaxonomy.cdm.api.service.name.TypeDesignationSetManager.orderByTypeByBaseEntity(Map<TypedEntityReference, TypeDesignationWorkingSet> stringsByTypeByBaseEntity)

If you move the second anonymous Comparator class into its own class file you can use it for to solve this issue here.

Andreas

I extracted the comparator and added another comparator for TypeDesignationBase.

Andreas K.: Could you also take a quick look?

#18 Updated by Andreas Kohlbecker 8 months ago

Looks good and the test in source:cdm-vaadin|src/test/java/eu/etaxonomy/cdm/service/SpecimenTypeDesignationWorkingSetServiceImplTest.java are runig successful.

From this point of view the ticket could be closed.

Andreas

#19 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner

Seems to work and can be closed.

#20 Updated by Andreas Müller 7 months ago

Still does not work. After model update (updating orderIndex) I still get the old order in UI, see attachement.

Tested on rem_conf_am.

#21 Updated by Patrick Plitzner 7 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 50 to 80

Added comparator to combo

#22 Updated by Andreas Müller 7 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Patrick Plitzner
  • % Done changed from 80 to 100

OK, the sorting of the designations worked before already. Misunderstanding from my side.

Also the dropdown has the same order now. Great. We can close the tickt.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)