bug #6526
closedShow types in correct order
100%
Description
Correct order starts with Holotype –> Lectotype –> Iso(lecto)type and ends with the rest
Files
Related issues
Updated by Patrick Plitzner almost 7 years ago
- Related to feature request #461: Improve / compact display of types added
Updated by Patrick Plitzner almost 7 years ago
- Target version changed from Unassigned CDM tickets to Release 4.7
Updated by Andreas Müller almost 7 years ago
- Target version changed from Release 4.7 to Release 4.8
Updated by Andreas Kohlbecker almost 7 years ago
- Related to feature request #6718: Constistent TypeDesignation representation creation added
Updated by Andreas Müller over 6 years ago
- Target version changed from Release 4.8 to Release 4.9
Updated by Andreas Müller over 6 years ago
- Target version changed from Release 4.9 to Release 4.10
Updated by Andreas Müller over 6 years ago
- Target version changed from Release 4.10 to Release 4.11
Updated by Andreas Müller over 6 years ago
- Target version changed from Release 4.11 to Release 4.12
Updated by Andreas Müller over 6 years ago
- Target version changed from Release 4.12 to Release 4.13
Updated by Andreas Müller about 6 years ago
- Target version changed from Release 4.13 to Release 4.14
Updated by Andreas Müller about 6 years ago
- Target version changed from Release 4.14 to Release 5.0
Updated by Patrick Plitzner about 6 years ago
- Status changed from New to Feedback
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 0 to 30
I added a comparator which sorts according to the designation status defined by the ordered terms. But this order does not confirm with the order proposed in this ticket. Should we change the order in of the ordered terms rather than changing the comparator?
Updated by Andreas Müller almost 6 years ago
- Related to feature request #7384: Order SpecimenTypeDesignationStatus according to new order in vocabulary added
Updated by Andreas Müller almost 6 years ago
- Assignee changed from Andreas Müller to Patrick Plitzner
Yes this is a good idea. I created a related ticket: #7384
Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)
@AK: do you have a defined order for type designations status in phycobank?
Updated by Andreas Kohlbecker almost 6 years ago
Andreas Müller wrote:
Yes this is a good idea. I created a related ticket: #7384
Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)
@AK: do you have a defined order for type designations status in phycobank?
Yes I do!
The order logic is implemented in LinkedHashMap<TypedEntityReference, TypeDesignationWorkingSet> eu.etaxonomy.cdm.api.service.name.TypeDesignationSetManager.orderByTypeByBaseEntity(Map<TypedEntityReference, TypeDesignationWorkingSet> stringsByTypeByBaseEntity)
If you move the second anonymous Comparator
class into its own class file you can use it for to solve this issue here.
Andreas
Updated by Patrick Plitzner almost 6 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 30 to 50
Andreas Kohlbecker wrote:
Andreas Müller wrote:
Yes this is a good idea. I created a related ticket: #7384
Can we anyway switch to the comparator already now as the existing order is already not so bad (with holotype at the beginning, followed by lectotype)
@AK: do you have a defined order for type designations status in phycobank?
Yes I do!
The order logic is implemented in
LinkedHashMap<TypedEntityReference, TypeDesignationWorkingSet> eu.etaxonomy.cdm.api.service.name.TypeDesignationSetManager.orderByTypeByBaseEntity(Map<TypedEntityReference, TypeDesignationWorkingSet> stringsByTypeByBaseEntity)
If you move the second anonymous
Comparator
class into its own class file you can use it for to solve this issue here.Andreas
I extracted the comparator and added another comparator for TypeDesignationBase.
Andreas K.: Could you also take a quick look?
Updated by Andreas Kohlbecker almost 6 years ago
Looks good and the test in source:cdm-vaadin|src/test/java/eu/etaxonomy/cdm/service/SpecimenTypeDesignationWorkingSetServiceImplTest.java are runig successful.
From this point of view the ticket could be closed.
Andreas
Updated by Andreas Müller almost 6 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Patrick Plitzner
Seems to work and can be closed.
Updated by Andreas Müller almost 6 years ago
- File picture246-1.png picture246-1.png added
- Status changed from Closed to Feedback
Still does not work. After model update (updating orderIndex) I still get the old order in UI, see attachement.
Tested on rem_conf_am.
Updated by Patrick Plitzner almost 6 years ago
- Status changed from Feedback to Resolved
- Assignee changed from Patrick Plitzner to Andreas Müller
- % Done changed from 50 to 80
Added comparator to combo
Updated by Andreas Müller almost 6 years ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Patrick Plitzner
- % Done changed from 80 to 100
OK, the sorting of the designations worked before already. Misunderstanding from my side.
Also the dropdown has the same order now. Great. We can close the tickt.