Project

General

Profile

feature request #4101

Default value for publish bit of new taxa must be configurable via DB preferences

Added by Andreas Kohlbecker almost 5 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
03/07/2014
Due date:
% Done:

0%

Estimated time:
3.00 h
Severity:
critical

Description

in the Euro+Med project it is important that the publish bit is not set by default for new taxa. In other use cases setting the publish bit by default will be a requirement though. So we need a mechnism to configure this. Only user with the ROLE_PROJECT_MANAGER must be allowed to change the default behaviour of regarding the publish flag. So it is not a valid solution to implement this into a client like the tax editor, this must be a library functionality

We probably need 3 states. True, false and inherit from parent. Inherit from parent was mentioned in duplicating ticket #4133.

related to #1780 (Publish bit instead of marker)


Related issues

Related to Edit - feature request #3709: [E+M][Editor] sufficient rights management for E+M workflow In Progress 09/09/2013
Duplicated by Edit - feature request #4133: publish flag inheritance for new taxa [DISCUSS] Duplicate 08/18/2014

Associated revisions

Revision 62a46745 (diff)
Added by Katja Luther 8 months ago

ref #6429: add publish flag preference to admin menu

Revision 4d210ea8 (diff)
Added by Katja Luther 8 months ago

new PreferencePredicate for publish flag preference

Revision 2bd924ce (diff)
Added by Katja Luther 8 months ago

ref #6429: namedetails view configuration in admin preferences

Revision eef2730e (diff)
Added by Andreas Müller 6 months ago

ref #4101 label for publish flag preferences

Revision d7983c72 (diff)
Added by Andreas Müller 6 months ago

ref #4101 adapt labels for set publish flag options

Revision 816e822f (diff)
Added by Andreas Müller 6 months ago

ref #4101 change ICNB and ICNAFP in order of enum to get a more alphabetically oriented order.

Revision 8360c0ff (diff)
Added by Katja Luther 6 months ago

fix #4101: getValue() was missing

Revision c66e6cf5 (diff)
Added by Katja Luther 6 months ago

ref #4101: correct setting of values in publish flag wizard

History

#1 Updated by Andreas Müller almost 5 years ago

  • Subject changed from publish bit must not set by default for new taxa to [DISCUSS] publish bit must not set by default for new taxa

I think we first need to discuss what the best behaviour is. This is also related to the Versionining or Non-Versioning strategy in E+M.

We could also have a strategy where the publish flag is inherited from the parent.

#2 Updated by Andreas Kohlbecker over 4 years ago

  • Keywords set to Euro+Med,Migration

#3 Updated by Andreas Müller over 3 years ago

  • Target version changed from Euro+Med Migration to Euro+Med Portal Release

#4 Updated by Andreas Müller over 2 years ago

  • Target version changed from Euro+Med Portal Release to Euro+Med Migration
  • Priority changed from New to Highest

#5 Updated by Andreas Müller over 2 years ago

  • Subject changed from [DISCUSS] publish bit must not set by default for new taxa to [DISCUSS] publish bit must not be set by default for new taxa

#6 Updated by Andreas Kohlbecker over 1 year ago

#7 Updated by Andreas Müller over 1 year ago

  • Subject changed from [DISCUSS] publish bit must not be set by default for new taxa to Default value for publish bit of new taxa must be configurable via DB preferences
  • Description updated (diff)
  • Assignee changed from Andreas Müller to Katja Luther
  • Target version changed from Euro+Med Migration to Release 4.10

#8 Updated by Andreas Müller over 1 year ago

  • Private changed from Yes to No

#9 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#10 Updated by Andreas Müller over 1 year ago

#11 Updated by Andreas Müller over 1 year ago

  • Description updated (diff)

#12 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.10 to Release 4.11

#13 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.11 to Release 4.12

#14 Updated by Andreas Müller about 1 year ago

  • Target version changed from Release 4.12 to Release 4.13

#16 Updated by Andreas Müller 11 months ago

  • Target version changed from Release 4.13 to Release 4.14

#17 Updated by Andreas Müller 10 months ago

  • Target version changed from Release 4.14 to Release 5.0

#18 Updated by Andreas Müller 7 months ago

  • Target version changed from Release 5.0 to Release 5.1

#19 Updated by Andreas Müller 7 months ago

  • Status changed from New to In Progress

#20 Updated by Andreas Müller 7 months ago

  • Estimated time set to 3.00 h

#21 Updated by Katja Luther 7 months ago

  • Status changed from In Progress to Resolved

this should be fixed now. please review.

#22 Updated by Katja Luther 7 months ago

  • Assignee changed from Katja Luther to Andreas Müller

#23 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

When trying to save I got:

login : admin
editor version : 5.1.0.201806191452
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.0.0.0.20180514
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.cdm.io.specimen.abcd206.in.Abcd206ImportConfigurator.toString(Abcd206ImportConfigurator.java:235)
    at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:237)
    at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
    at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:889)
    at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:230)
    at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618)
    ...

#24 Updated by Andreas Müller 6 months ago

When I set to "Don't set publish flag" the new child taxon still has publish flag = true. Also inheriting from parent still does not work.

#25 Updated by Andreas Müller 6 months ago

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

#26 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50

#27 Updated by Katja Luther 6 months ago

  • Status changed from Resolved to Feedback
  • % Done changed from 50 to 0

Andreas Müller wrote:

When trying to save I got:

login : admin
editor version : 5.1.0.201806191452
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.0.0.0.20180514
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
  at eu.etaxonomy.cdm.io.specimen.abcd206.in.Abcd206ImportConfigurator.toString(Abcd206ImportConfigurator.java:235)
  at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:237)
  at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
      ...

this was not related to this issue, but the NPE in Abcd206ImportConfigurator is fixed now.

#28 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#29 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The preference is not stored in the DB. After reopening the preference view the publish flag option is still not set.

#30 Updated by Andreas Müller 6 months ago

Andreas Müller wrote:

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

Please implement or create new ticket.

#31 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#32 Updated by Katja Luther 6 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

The preference is not stored in the DB. After reopening the preference view the publish flag option is still not set.

this was a problem of the wizard and is fixed.

Andreas Müller wrote:

Andreas Müller wrote:

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

Please implement or create new ticket.

is implemented.

#33 Updated by Katja Luther 6 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#34 Updated by Andreas Müller 6 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

Seems to work now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)