Project

General

Profile

Actions

feature request #4101

closed

Default value for publish bit of new taxa must be configurable via DB preferences

Added by Andreas Kohlbecker over 8 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmlib
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
3:00 h
Severity:
critical

Description

in the Euro+Med project it is important that the publish bit is not set by default for new taxa. In other use cases setting the publish bit by default will be a requirement though. So we need a mechnism to configure this. Only user with the ROLE_PROJECT_MANAGER must be allowed to change the default behaviour of regarding the publish flag. So it is not a valid solution to implement this into a client like the tax editor, this must be a library functionality

We probably need 3 states. True, false and inherit from parent. Inherit from parent was mentioned in duplicating ticket #4133.

related to #1780 (Publish bit instead of marker)


Related issues

Related to EDIT - feature request #3709: [E+M][Editor] sufficient rights management for E+M workflowResolvedAndreas Müller

Actions
Has duplicate EDIT - feature request #4133: publish flag inheritance for new taxa [DISCUSS]DuplicateAndreas Müller

Actions
Actions #1

Updated by Andreas Müller over 8 years ago

  • Subject changed from publish bit must not set by default for new taxa to [DISCUSS] publish bit must not set by default for new taxa

I think we first need to discuss what the best behaviour is. This is also related to the Versionining or Non-Versioning strategy in E+M.

We could also have a strategy where the publish flag is inherited from the parent.

Actions #2

Updated by Andreas Kohlbecker over 8 years ago

  • Keywords set to Euro+Med,Migration
Actions #3

Updated by Andreas Müller over 7 years ago

  • Target version changed from Euro+Med Migration to Euro+Med Portal Release
Actions #4

Updated by Andreas Müller over 6 years ago

  • Target version changed from Euro+Med Portal Release to Euro+Med Migration
  • Priority changed from New to Highest
Actions #5

Updated by Andreas Müller over 6 years ago

  • Subject changed from [DISCUSS] publish bit must not set by default for new taxa to [DISCUSS] publish bit must not be set by default for new taxa
Actions #6

Updated by Andreas Kohlbecker over 5 years ago

Actions #7

Updated by Andreas Müller about 5 years ago

  • Subject changed from [DISCUSS] publish bit must not be set by default for new taxa to Default value for publish bit of new taxa must be configurable via DB preferences
  • Description updated (diff)
  • Assignee changed from Andreas Müller to Katja Luther
  • Target version changed from Euro+Med Migration to Release 4.10
Actions #8

Updated by Andreas Müller about 5 years ago

  • Private changed from Yes to No
Actions #9

Updated by Andreas Müller about 5 years ago

  • Description updated (diff)
Actions #10

Updated by Andreas Müller about 5 years ago

Actions #11

Updated by Andreas Müller about 5 years ago

  • Description updated (diff)
Actions #12

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.10 to Release 4.11
Actions #13

Updated by Andreas Müller about 5 years ago

  • Target version changed from Release 4.11 to Release 4.12
Actions #14

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.12 to Release 4.13
Actions #16

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.13 to Release 4.14
Actions #17

Updated by Andreas Müller almost 5 years ago

  • Target version changed from Release 4.14 to Release 5.0
Actions #18

Updated by Andreas Müller over 4 years ago

  • Target version changed from Release 5.0 to Release 5.1
Actions #19

Updated by Andreas Müller over 4 years ago

  • Status changed from New to In Progress
Actions #20

Updated by Andreas Müller over 4 years ago

  • Estimated time set to 3:00 h
Actions #21

Updated by Katja Luther over 4 years ago

  • Status changed from In Progress to Resolved

this should be fixed now. please review.

Actions #22

Updated by Katja Luther over 4 years ago

  • Assignee changed from Katja Luther to Andreas Müller
Actions #23

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

When trying to save I got:

login : admin
editor version : 5.1.0.201806191452
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.0.0.0.20180514
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
    at eu.etaxonomy.cdm.io.specimen.abcd206.in.Abcd206ImportConfigurator.toString(Abcd206ImportConfigurator.java:235)
    at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:237)
    at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
    at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
    at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
    at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
    at org.eclipse.jface.preference.PreferenceDialog.okPressed(PreferenceDialog.java:889)
    at org.eclipse.jface.preference.PreferenceDialog.buttonPressed(PreferenceDialog.java:230)
    at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:618)
    ...
Actions #24

Updated by Andreas Müller over 4 years ago

When I set to "Don't set publish flag" the new child taxon still has publish flag = true. Also inheriting from parent still does not work.

Actions #25

Updated by Andreas Müller over 4 years ago

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

Actions #26

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50
Actions #27

Updated by Katja Luther over 4 years ago

  • Status changed from Resolved to Feedback
  • % Done changed from 50 to 0

Andreas Müller wrote:

When trying to save I got:

login : admin
editor version : 5.1.0.201806191452
server : test.e-taxonomy.eu (edit-test) / rem_conf_am
schema version : 5.0.0.0.20180514
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
  at eu.etaxonomy.cdm.io.specimen.abcd206.in.Abcd206ImportConfigurator.toString(Abcd206ImportConfigurator.java:235)
  at eu.etaxonomy.taxeditor.databaseAdmin.preferencePage.AbcdImportPreference.performOk(AbcdImportPreference.java:237)
  at org.eclipse.jface.preference.PreferenceDialog$8.run(PreferenceDialog.java:905)
  at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
      ...

this was not related to this issue, but the NPE in Abcd206ImportConfigurator is fixed now.

Actions #28

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #29

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

The preference is not stored in the DB. After reopening the preference view the publish flag option is still not set.

Actions #30

Updated by Andreas Müller over 4 years ago

Andreas Müller wrote:

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

Please implement or create new ticket.

Actions #31

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #32

Updated by Katja Luther over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote:

The preference is not stored in the DB. After reopening the preference view the publish flag option is still not set.

this was a problem of the wizard and is fixed.

Andreas Müller wrote:

Andreas Müller wrote:

We may also want to show the new publish flag value in the "new taxon" dialog. But this might be another ticket.

Please implement or create new ticket.

is implemented.

Actions #33

Updated by Katja Luther over 4 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #34

Updated by Andreas Müller over 4 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther

Seems to work now.

Actions

Also available in: Atom PDF