Project

General

Profile

Actions

feature request #10331

closed

Allow editing maxPerDataset and evaluate for menu

Added by Andreas Müller 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
taxeditor
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

.. in taxeditor. Use Label "max per dataset"

And implement in FactsView that the menu shows only those features that are used less then "max" times per dataset.

Split ticket if necessary.

see #10328 for discussion on maxPerDataset

Similar issue: #10332


Related issues

Related to EDIT - feature request #10328: Add "max records per dataset"ClosedAndreas Müller

Actions
Related to EDIT - feature request #10332: Allow editing maxStates and evaluate in StateData ViewsClosedKatja Luther

Actions
Related to EDIT - bug #10342: After changing max per dataset and max states the editor needs to be restartedNewKatja Luther

Actions
Copied to EDIT - bug #10344: Change listener order for menu and view creationNewKatja Luther

Actions
Copied to EDIT - bug #10345: Avoid unnecessary webservice calls in TaxEditor facts view (and others)NewKatja Luther

Actions
Actions #1

Updated by Andreas Müller 11 months ago

Actions #2

Updated by Andreas Müller 11 months ago

  • Priority changed from New to Highest
Actions #3

Updated by Andreas Müller 11 months ago

  • Tags changed from mexico to mexico, fast
Actions #4

Updated by Andreas Müller 11 months ago

  • Subject changed from Allow editing maxPerDataset to Allow editing maxPerDataset and evaluate for menu
Actions #5

Updated by Andreas Müller 11 months ago

Actions #6

Updated by Andreas Müller 11 months ago

  • Description updated (diff)
Actions #7

Updated by Andreas Müller 11 months ago

  • Target version changed from Release 5.44 to Release 5.38
Actions #8

Updated by Katja Luther 11 months ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed, please review.

Actions #9

Updated by Andreas Müller 11 months ago

  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 70

It works and can be closed. However, as the code had a lot of redundancy and unnecessary redundant casting, etc. I tried to simplify it a bit.

Can you please have a look if you think it is still correct. I left the old code for easy comparison. Please remove after successful review.

I also left 2 notes in the code in the FeatureNodeContainer part where the children are computed. Do you understand what it is for and if it works? Especially the 2 rows defining the feature tree 2x I think can't be correct. Maybe we need to split this issue in a separate ticket as this is not covered by the current ticket.

Can you please also have a look on my comment on isCloneForSource()? Also this should be moved to another ticket if there is an open issue.

Actions #10

Updated by Andreas Müller 11 months ago

If you have not done yet can you also please verify that the menu creation will never create a service call? I first thought so but then closed the details view and the supplemental data view and no call was send anymore. Unfortunately I could not debug in my IDE as it is broken.

But it looks like the only critical code part is getElementCounts() which loads the description elements. But as they are loaded during fact view loading already this should not result in a service call, correct?

However, during the first usage with open details/suppl.data view I had to wait relatively long for the menu. I guess the reason is that both the views are first loaded before the menu is created. Is there any possibility to change this order? Usually a context menu call even does not expect a xx views loading at all. Is it possible to show the menu without setting the focus and loading the views? Ofcourse also this is a another ticket and not covered by this ticket.

A final issue I found. Even when clicking a second time on a fact view tree item I observed at least 1 service call (I tested in rem_conf_am/Testklass/Test me factual data) when clicking on either the Fact Dataset or some single facts (but not on the feature node). This happens only with open details view, so it is caused by the det view. Can you check if these calls are really necessary? Also here it might be a new ticket.

Actions #11

Updated by Andreas Müller 11 months ago

Can you still move the "max per dataset" in details view deeper. Below the Available for information and above "Max states". And can you still rename "Max per dataset" to "Max n per dataset" and "Max states" to "Max n states"? This is maybe easier to understand.

Actions #12

Updated by Andreas Müller 11 months ago

For another minor open issue see #10332#note-12

Actions #13

Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Feedback
Actions #14

Updated by Katja Luther 11 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-11:

Can you still move the "max per dataset" in details view deeper. Below the Available for information and above "Max states". And can you still rename "Max per dataset" to "Max n per dataset" and "Max states" to "Max n states"? This is maybe easier to understand.

Relabeling and moving done, the other issue should be handled in a separate ticket.

Actions #15

Updated by Katja Luther 11 months ago

  • Related to bug #10342: After changing max per dataset and max states the editor needs to be restarted added
Actions #16

Updated by Andreas Müller 11 months ago

  • Assignee changed from Andreas Müller to Katja Luther

Andreas Müller wrote in #note-9:

Can you please also have a look on my comment on isCloneForSource()? Also this should be moved to another ticket if there is an open issue.

Did you check if you think the current implementation is still correct?

Actions #17

Updated by Andreas Müller 11 months ago

  • Copied to bug #10344: Change listener order for menu and view creation added
Actions #18

Updated by Andreas Müller 11 months ago

  • Copied to bug #10345: Avoid unnecessary webservice calls in TaxEditor facts view (and others) added
Actions #19

Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 70 to 100

There is still a minor related issue that when switching Categorical Data on and off the order of Available for and the recommendedXXX part switches. However, this is not critical in any way so we can ignore it for now.

Actions

Also available in: Atom PDF