Project

General

Profile

bug #9059

Cancel taxon save does not clean the (factual data) cache

Added by Andreas Müller 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
06/10/2020
Due date:
% Done:

100%

Severity:
blocker
Found in Version:

Description

What I did:

  • open a taxon in name editor
  • change an existing fact
  • close name editor without saving
  • reopen name editor for same taxon => new data still exists, but shouldn't
  • restart TaxEditor
  • reopen name editor for same taxon => new data does not exist anymore, so it was not persisted (as expected)

Looks like the data is somehow cached.
Interesting is that neither changing name related data nor changing supplemental data has the same effect.

Associated revisions

Revision be22ce7d (diff)
Added by Katja Luther 2 months ago

fix #9059: clear featureNodeContainerCache when closing NameEditor

History

#1 Updated by Katja Luther 2 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Katja Luther 2 months ago

  • Assignee changed from Katja Luther to Andreas Müller
  • Severity changed from critical to blocker

this should be fixed, please review.

#3 Updated by Andreas Müller 2 months ago

I got an NPE when testing this ticket together with #9038

last remote method : http://localhost:50405/remoting/common.service
last remote request client time : 2020-06-12T16:51:58.119
last remote request response header time : Fri, 12 Jun 2020 16:51:58 +0200
client error time : 2020-06-12T16:52:07.31
login : admin
editor version : 5.15.0.202006121348
server : localhost (localhost mgd.) / cdm-test2
schema version : 5.15.1.0.20200610
os : Windows Server 2012 R2 6.3 amd64
java : 1.8.0_121
java.lang.NullPointerException
                at eu.etaxonomy.taxeditor.editor.view.descriptive.e4.FactualDataPartE4.changed(FactualDataPartE4.java:208)
                at eu.etaxonomy.taxeditor.view.e4.AbstractCdmEditorPartE4.changed(AbstractCdmEditorPartE4.java:188)
                at eu.etaxonomy.taxeditor.view.e4.AbstractCdmDataViewerE4.markViewPartDirty(AbstractCdmDataViewerE4.java:110)
                at eu.etaxonomy.taxeditor.view.e4.details.DetailsViewerE4.markViewPartDirty(DetailsViewerE4.java:222)
                at eu.etaxonomy.taxeditor.view.e4.AbstractCdmDataViewerE4$1.dirtyStateChanged(AbstractCdmDataViewerE4.java:80)
                at org.eclipse.ui.forms.AbstractFormPart.markDirty(AbstractFormPart.java:93)
                at eu.etaxonomy.taxeditor.view.detail.CdmSectionPart.propertyChange(CdmSectionPart.java:209)
                at eu.etaxonomy.taxeditor.ui.element.AbstractCdmFormElement.firePropertyChangeEvent(AbstractCdmFormElement.java:256)
                at eu.etaxonomy.taxeditor.ui.element.TextWithLabelElement.modifyText(TextWithLabelElement.java:178)
                at eu.etaxonomy.taxeditor.ui.element.BigDecimalWithLabelElement.modifyText(BigDecimalWithLabelElement.java:38)
                at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
                at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
                at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4418)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103)
                at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1084)
                at org.eclipse.swt.widgets.Text.wmCommandChild(Text.java:3122)

#4 Updated by Andreas Müller 2 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther

#5 Updated by Katja Luther about 2 months ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote:

I got an NPE when testing this ticket together with #9038

the NPE is fixed.

#6 Updated by Andreas Müller about 2 months ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 100

Seems to work now

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)