Project

General

Profile

Actions
Copy link

feature request #8475

closed

Adapt applicable state detail view elements to FeatureState

Added by Patrick Plitzner over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
New
Assignee:
Patrick Plitzner
Category:
taxeditor
Target version:
Release 5.9
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Related issues

Related to EDIT - feature request #8441: Add FeatureState classClosedAndreas Müller

Actions
Actions
Copy link
 #1

Updated by Patrick Plitzner over 3 years ago

Actions
Copy link
 #2

Updated by Patrick Plitzner over 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller
  • % Done changed from 0 to 50
Actions
Copy link
 #3

Updated by Patrick Plitzner over 3 years ago

Added applicable detail elements to TermNode details view. Available features are filtered to only contain parent feature i.e. features of the parent nodes. After selecting a feature the state combo box is filled with its states. Not yet tested on nightly.

Actions
Copy link
 #4

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

In this case we do not need an "empty" choice for the dropdowns. A FeatureState always needs to have both, feature and state. If not it needs to be completely deleted, which can be done in Details view.

Also, if there is only 1 parent feature we could prefill the "Parent feature" field.

And we could filter out those features which do not support categorical data and/or which do not have supported states/state vocabularies.

All this is advanced handling so we can move it to new ticket if not straight forward to implement.

Actions
Copy link
 #5

Updated by Andreas Müller over 3 years ago

I wonder if we could reduce the availability of "InapplicableIf" and "OnlyApplicableIF" to term nodes of term type "Feature" and subtypes (Character" only.
To me it looks like it does not make sence to have them elsewhere.
We could try to handle this on model level by having a sub type FeatureNode which inherits from TermNode, by maybe it is easier to handle this via UI and maybe also via strict validations (model level).

Is it possible to implement this check still for this release? Not 100% necessary but very nice to have because it prevents from having incorrect data afterwards. I also could write the validators but probably don't have time today anymore.

Actions
Copy link
 #6

Updated by Andreas Müller over 3 years ago

  • % Done changed from 50 to 80

In general this ticket can be closed as it works as expected.

Actions
Copy link
 #7

Updated by Patrick Plitzner over 3 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 80 to 100

Andreas Müller wrote:

In this case we do not need an "empty" choice for the dropdowns. A FeatureState always needs to have both, feature and state. If not it needs to be completely deleted, which can be done in Details view.

Fixed all the issues mentioned except the above, which I do not understand. @Andreas: Can you clarify what the problem is?

Actions
Copy link
 #8

Updated by Andreas Müller over 3 years ago

  • Status changed from Closed to Feedback

Patrick Plitzner wrote:

Andreas Müller wrote:

In this case we do not need an "empty" choice for the dropdowns. A FeatureState always needs to have both, feature and state. If not it needs to be completely deleted, which can be done in Details view.

Fixed all the issues mentioned except the above, which I do not understand. @Andreas: Can you clarify what the problem is?

The dropdowns in the dialog do show the list of features/states + an empty entry. This empty entry is not necessary. We do not allow an empty entry for a FeatureState therefore the empty entry should be removed as it only creates problems when selecting the wanted feature/state.
Did you implement the other issues from note 4? If not please create a new ticket.

Actions
Copy link
 #9

Updated by Andreas Müller over 3 years ago

  • % Done changed from 100 to 90
Actions
Copy link
 #10

Updated by Patrick Plitzner over 3 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Patrick Plitzner to Andreas Müller

Removed empty element after first selection.

All issues should be fixed now.

Actions
Copy link
 #11

Updated by Andreas Müller over 3 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Patrick Plitzner

For future a real freetext search might be preferable for the states in case there are >>10 states, but for now it is ok.

Please still adapt the feature search such that it does not show an empty record from the very beginning. Currently it does it only after a first selection took place.

You may close the ticket then.

Actions
Copy link
 #12

Updated by Patrick Plitzner over 3 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF