feature request #7761
Invalid designations should be displayed like misapplied names in name editor
70%
Description
The taxon relationship invalid designation should be displayed like MAN and pro parte synonyms in editor.
Related issues
Associated revisions
ref #7761: add isInvalidDeisgnation() method to taxon
ref #7761: invalid designations are displayed in name editor and details view like MAN
ref #7761: fragment.xmi and plugin.properties file for invalid designation changes
ref #7761: adapt property tester
ref #7761 add isInvalidDesignation to TaxonRelationshipType
ref #7761 add isInvalidDesignation to TaxonRelationshipType
Revert "ref #7761: invalid designations are displayed in name editor and details view like MAN"
This reverts commit 8e0e024c985ffbbe2ce2421270927059c9abf0cc.
ref #7761: add invalid designation and adapt right click menu for name editor
ref #7761: don't allow editing type of relationship for InvalidTypeDesignations in details view
ref #7761: add icon for invalid designation
History
#1 Updated by Andreas Müller about 1 year ago
- Category set to taxeditor
#2 Updated by Andreas Müller about 1 year ago
- Target version changed from Release 5.3 to Release 5.4
#3 Updated by Andreas Müller about 1 year ago
- Target version changed from Release 5.4 to Release 5.5
#4 Updated by Katja Luther 11 months ago
- Status changed from New to Resolved
- Assignee changed from Katja Luther to Andreas Müller
please review
#5 Updated by Andreas Müller 10 months ago
- Priority changed from New to Highest
#6 Updated by Andreas Müller 10 months ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Relationship type in details view allows all relationship types now in dropdown. As long as we do not allow other concept relationships explicitly we can probably completely remove this field as there are no alternative types (like pro parte MAN for MAN).
#7 Updated by Andreas Müller 10 months ago
- Tags set to euro+med
#8 Updated by Andreas Müller 10 months ago
- % Done changed from 0 to 30
#9 Updated by Andreas Müller 10 months ago
- Related to feature request #7215: Implement pro parte misapplied names in TaxEditor added
#10 Updated by Andreas Müller 10 months ago
- Related to feature request #7427: Implement pro parte synonyms in TaxEditor added
#11 Updated by Andreas Müller 10 months ago
- Tags deleted (
euro+med) - Subject changed from invalid designations should be displayed like MAN in name editor to Invalid designations should be displayed like misapplied names in name editor
- % Done changed from 30 to 0
It would be nice to have a separate icon. MA stands for Misapplication. Can we have something like ID or IN. ID sounds like identifier so maybe IN is better.
#12 Updated by Andreas Müller 10 months ago
The formatting is according to MAN now, with name author being "NON" author in the second row. Is this taken from the TaxonRelationshipFormatter or is it just c&p from MAN handling.
I am personally not sure about the correct formatting of invDesigs, but I think I would prefer same formatting as for ppSyns prior to MAN formatting.
Anyway we need to check correct formatting (#8055).
#13 Updated by Andreas Müller 10 months ago
- Related to task #8055: Correct formatting for invalid designations added
#14 Updated by Katja Luther 10 months ago
Andreas Müller wrote:
Relationship type in details view allows all relationship types now in dropdown. As long as we do not allow other concept relationships explicitly we can probably completely remove this field as there are no alternative types (like pro parte MAN for MAN).
fixed
#15 Updated by Katja Luther 10 months ago
Andreas Müller wrote:
The formatting is according to MAN now, with name author being "NON" author in the second row. Is this taken from the TaxonRelationshipFormatter or is it just c&p from MAN handling.
this is taken from the formatter
I am personally not sure about the correct formatting of invDesigs, but I think I would prefer same formatting as for ppSyns prior to MAN formatting.
Anyway we need to check correct formatting (#8055).
#16 Updated by Katja Luther 10 months ago
- Assignee changed from Katja Luther to Andreas Müller
Andreas Müller wrote:
It would be nice to have a separate icon. MA stands for Misapplication. Can we have something like ID or IN. ID sounds like identifier so maybe IN is better.
a new icon is added. as we have do check the correct formatting in #8055 we can close this ticket?
#17 Updated by Andreas Müller 10 months ago
- Status changed from Feedback to Resolved
#18 Updated by Andreas Müller 10 months ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
yes, probably we can close this. Correct formatting will be done in #8055
#19 Updated by Andreas Müller 10 months ago
- % Done changed from 0 to 70
Katja Luther wrote:
Andreas Müller wrote:
It would be nice to have a separate icon. MA stands for Misapplication. Can we have something like ID or IN. ID sounds like identifier so maybe IN is better.
a new icon is added. as we have do check the correct formatting in #8055 we can close this ticket?
Maybe dark blue is very similar to the basionym icon. Maybe some red is a better. With red also indicating the "invalid" a bit more.
#20 Updated by Katja Luther 10 months ago
Andreas Müller wrote:
Katja Luther wrote:
Andreas Müller wrote:
It would be nice to have a separate icon. MA stands for Misapplication. Can we have something like ID or IN. ID sounds like identifier so maybe IN is better.
a new icon is added. as we have do check the correct formatting in #8055 we can close this ticket?
Maybe dark blue is very similar to the basionym icon. Maybe some red is a better. With red also indicating the "invalid" a bit more.
Now the icon is red.
#21 Updated by Andreas Müller 10 months ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
#22 Updated by Andreas Müller 10 months ago
- Status changed from Resolved to Closed
- Assignee changed from Andreas Müller to Katja Luther
There are still some related issues open (discussed via email). However, they are not inval. desig. specific and therefore we can close this ticket.
#23 Updated by Andreas Müller 10 months ago
- Related to feature request #6394: Allow additional taxon relationships in TaxEditor to be handled similar to misapplications added
