feature request #7180
closedcdm light export optionally filters by published flag
100%
Related issues
Updated by Katja Luther over 6 years ago
- Description updated (diff)
- Status changed from New to Resolved
- Assignee changed from Katja Luther to Andreas Müller
Updated by Andreas Müller over 6 years ago
- Related to bug #7175: DwC-A export optionally filters by published flag added
Updated by Andreas Müller over 6 years ago
- Status changed from Resolved to Feedback
The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.
Updated by Katja Luther over 6 years ago
Andreas Müller wrote:
The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.
But the check for synonyms needs to be done in the export, therefore we need to keep the attribute in the configuration.
Updated by Andreas Müller over 6 years ago
- Status changed from Feedback to Resolved
- % Done changed from 0 to 50
Applied in changeset cdmlib|8f006e1e7dd176b5249aee378757f573fb22f887.
Updated by Andreas Müller over 6 years ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
- % Done changed from 50 to 0
I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.
Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.
From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.
Updated by Katja Luther over 6 years ago
Andreas Müller wrote:
I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.
Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.
From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.
now there are tests for the cdm light export.
Updated by Katja Luther over 6 years ago
- Status changed from Feedback to Closed
- % Done changed from 0 to 100