Project

General

Profile

Actions

feature request #7180

closed

cdm light export optionally filters by published flag

Added by Katja Luther over 5 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmadapter
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal

Description

cdm light export needs the possibility to export only published data (see #7175)


Related issues

Related to EDIT - bug #7175: DwC-A export optionally filters by published flagClosedKatja Luther

Actions
Actions #1

Updated by Katja Luther over 5 years ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
Actions #2

Updated by Andreas Müller over 5 years ago

  • Related to bug #7175: DwC-A export optionally filters by published flag added
Actions #3

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback

The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.

Actions #4

Updated by Katja Luther over 5 years ago

Andreas Müller wrote:

The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.

But the check for synonyms needs to be done in the export, therefore we need to keep the attribute in the configuration.

Actions #5

Updated by Andreas Müller over 5 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50
Actions #6

Updated by Andreas Müller over 5 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 0

I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.

Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.

From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.

Actions #7

Updated by Katja Luther over 5 years ago

Andreas Müller wrote:

I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.

Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.

From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.

now there are tests for the cdm light export.

Actions #8

Updated by Andreas Müller over 5 years ago

I think we can close this ticket now

Actions #9

Updated by Katja Luther over 5 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF