Project

General

Profile

feature request #7180

cdm light export optionally filters by published flag

Added by Katja Luther 11 months ago. Updated 11 months ago.

Status:
Closed
Priority:
Highest
Assignee:
Category:
cdmadapter
Target version:
Start date:
01/15/2018
Due date:
% Done:

100%

Severity:
normal

Description

cdm light export needs the possibility to export only published data (see #7175)


Related issues

Related to Edit - bug #7175: DwC-A export optionally filters by published flag Closed 01/15/2018

Associated revisions

Revision a4433228 (diff)
Added by Katja Luther 11 months ago

add attr. onlyPublishedTaxa to exportConfigurator and CdmLightExport

Revision 19c6f3d6 (diff)
Added by Andreas Müller 11 months ago

ref #7175, ref #7180, ref #7165, ref #7166 Adapting TaxonNodeFilter for unpublished, minMaxRank and areas

Revision 8f006e1e (diff)
Added by Andreas Müller 11 months ago

fix #7180 fix #7175 refactor (CdmLight) and implementd (DwC-A) publish flag filtering

History

#1 Updated by Katja Luther 11 months ago

  • Description updated (diff)
  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

#2 Updated by Andreas Müller 11 months ago

  • Related to bug #7175: DwC-A export optionally filters by published flag added

#3 Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Feedback

The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.

#4 Updated by Katja Luther 11 months ago

Andreas Müller wrote:

The publish flag evaluation should be part of the TaxonNodeFilter filtering mechanism in TaxonNodeFilterDaoImpl to be generic. Adding it to the export configuration is less performant and not generic.

But the check for synonyms needs to be done in the export, therefore we need to keep the attribute in the configuration.

#5 Updated by Andreas Müller 11 months ago

  • Status changed from Feedback to Resolved
  • % Done changed from 0 to 50

#6 Updated by Andreas Müller 11 months ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 0

I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.

Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.

From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.

#7 Updated by Katja Luther 11 months ago

Andreas Müller wrote:

I removed the parameter from the configurator but added it to the TaxonNodeFilter which is also part of the configurator. For synonym filtering it can be taken from there. Also I renamed the parameter from onlyPublishedTaxa to includeUnpublished which better expresses that the default should be not to include unpulished data.

Generally this should work. Do we have tests for CdmLight? If yes we should add a test for correct handling of unpublished. Otherwise we should urgently start writing tests as CdmLight is frequently used.

From my side we can close this ticket, but we still need to include this in TaxEditor if not yet done. As the new version of the configurator does not include the boolean value directly anymore, this does not happen automatically anymore.

now there are tests for the cdm light export.

#8 Updated by Andreas Müller 11 months ago

I think we can close this ticket now

#9 Updated by Katja Luther 11 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)