feature request #4896: Bulkeditor: deduplication of objects of different type - EDIT - EDIT Project Management

Actions

Copy link

feature request #4896

closed

Bulkeditor: deduplication of objects of different type

Added by Katja Luther almost 9 years ago. Updated over 3 years ago.

Status:

Closed

Priority:

Priority13

Assignee:

Katja Luther

Category:

taxeditor

Target version:

TaxEditor RELEASE 3.6.0

Start date:

Due date:

% Done:

100%

Estimated time:

Severity:

normal

Description

it should be possible to merge objects of different type, for example team and person. The functionality already exist in the library but has to be implemented in the editor.

#4768, #3286, #4769, #4770

Related issues

Actions

Copy link

Updated by Katja Luther almost 9 years ago

Status changed from New to Resolved
Assignee changed from k.luther - to Andreas Müller

is implemented in r23831

Actions

Copy link

Updated by Andreas Müller almost 9 years ago

Assignee changed from Andreas Müller to k.luther -

Mail Walter:

java.lang.IllegalArgumentException: Object can not be merged into new object as it is referenced in a way that does not allow merging
                at eu.etaxonomy.cdm.persistence.dao.hibernate.common.DeduplicationHelper.merge(DeduplicationHelper.java:147)
                at eu.etaxonomy.cdm.persistence.dao.hibernate.common.CdmGenericDaoImpl.merge(CdmGenericDaoImpl.java:406)
                at eu.etaxonomy.cdm.api.service.CommonServiceImpl.merge(CommonServiceImpl.java:218)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
                at

This should not happen. We do have the ICommonService.isMergeable(T cdmBase1, T cdmBase2, IMergeStrategy mergeStrategy) method which allows catching these cases before the merge and handling them in a more appropriate user dialog. We should explain the user in human readable way why the merging is not possible.

DISCUSS: Should isMergeable return more information about the cause why certain cases are not mergeable?

Actions

Copy link

Updated by Katja Luther over 8 years ago

Assignee changed from k.luther - to Andreas Müller

the merge of team and person are now possible with r25416 and isMergeable is called before.

Actions

Copy link

Updated by Katja Luther over 8 years ago

r25423 for more information why the convertion was aborted, but I think this is only a workaround. the ismergeable Method should return the exception so the Handler can handle the different exceptions differently.

Actions

Copy link