bug #10394
closedDetails page for derived unit only shows categorical data
100%
Description
The details page for derived units shows the character data entered for the specimen, but the value for the quantitative data is empty and therefore not shown.
The value is created by DefaultCategoricalDescriptionBuilder.
Files
Related issues
Updated by Andreas Müller 12 months ago
- Tags changed from additivity to additivity, specimen
Is this a dataportal issue?
Updated by Andreas Müller 12 months ago
- Category changed from cdmlib to cdm-dataportal
Updated by Katja Luther 11 months ago
Andreas Müller wrote in #note-1:
Is this a dataportal issue?
Maybe more a cdmlib issue because the data collection is done in DefaultCategoricalDescriptionBuilder, but currently it is only used in data portal.
Updated by Katja Luther 11 months ago
- Status changed from New to Resolved
- Assignee changed from Katja Luther to Andreas Müller
I adapted the QuantitativeDataDescriptionBuilder, an example for review can be find here:
https://test.e-taxonomy.eu/dataportal/preview/caryophyllales_spp/cdm_dataportal/occurrence/c46a81e6-ec01-465a-a00d-7bf88fcec32d
Updated by Andreas Müller 11 months ago
A null check is not needed if calling HibernateProxyHelper.deproxy(). I removed it in code.
Updated by Andreas Müller 11 months ago
There is an explicit unlikely argument warning in the code:
Can you please adapt the code accordingly!
Updated by Andreas Müller 11 months ago
- Status changed from Resolved to Feedback
- Assignee changed from Andreas Müller to Katja Luther
Updated by Andreas Müller 11 months ago
... or add a test showing that the result is correct for integer values.
Updated by Andreas Müller 11 months ago
OK, for the above link it seems to work as there are also int values. However, to me it is unclear if the if statement is needed at all and if needs to be implemented such. But I see it is old code so it is not related to this ticket.
Updated by Andreas Müller 11 months ago
Also the parameter naming is strange. The List is called "float values". Maybe we can correct this, too.
Updated by Andreas Müller 11 months ago
- % Done changed from 50 to 90
Done. Please review code adaptation. If correct we can close the ticket as functionality works as expected.
Updated by Katja Luther 11 months ago
- File Screenshot 2023-10-19 143531.png Screenshot 2023-10-19 143531.png added
- File Screenshot 2023-10-19 143444.png Screenshot 2023-10-19 143444.png added
I think this does not work as it should:
The prior implementation was:
Updated by Andreas Müller 11 months ago
By the way, is there a reason, why the values are not ordered? I would expect it to be wanted behaviour to order them.
Updated by Andreas Müller 11 months ago
Is the above test publicly available with a link?
Updated by Katja Luther 11 months ago
- Status changed from Feedback to Resolved
- Assignee changed from Katja Luther to Andreas Müller
This looks fine now. I added sorting to the list of values.
Updated by Katja Luther 11 months ago
Andreas Müller wrote in #note-17:
Is the above test publicly available with a link?
This is my local installation of the centaurea/flora of greece portal.
Updated by Andreas Müller 11 months ago
- Status changed from Resolved to Closed
- % Done changed from 90 to 100
I tested again with the above link (and adapted data). Works as expected and we can close this ticket.
Updated by Andreas Müller 11 months ago
- Assignee changed from Andreas Müller to Katja Luther
Updated by Andreas Müller 11 months ago
- Related to feature request #10420: Order exact values in QuantitativeDataFormatter added