Project

General

Profile

Actions

feature request #7082

closed

Implement integration test for the SpecimenTypeDesignationWorkingsetEditorPresenter

Added by Andreas Kohlbecker over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
New
Category:
cdm-vaadin
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Tags:

Description

The SpecimenTypeDesignationWorkingsetEditorPresenter needs to perform business logic tasks and needs to configure the deletion of specimens correctly, see methods saveBean(SpecimenTypeDesignationWorkingSetDTO dto) and deleteTypeDesignation(SpecimenTypeDesignationDTO element) , this functionality should be covered with an integration test.


NOTE: The SpecimenTypeDesignationWorkingsetEditorPresenterTest.java has been renamed to SpecimenTypeDesignationWorkingSetServiceImplTest

Actions #1

Updated by Andreas Kohlbecker over 6 years ago

  • Tracker changed from bug to feature request
  • Category set to cdm-vaadin
  • Status changed from New to In Progress
  • Assignee set to Andreas Kohlbecker

I started with the implementation but faced a couple of problems with this. In order to test the presenter properly it is required to test it against a database, otherwise the delete and save operations can not be reliably tested. So using service mocks is not an option in this case.

For now I stopped this development since i am running out of time solving the remaining problems:

  • The data inserted by spring-test-dbunit via the @DatabaseSetup(value="SpecimenTypeDesignationWorkingsetEditorPresenterTest.xml") caused foreign key constraint conflicts with the data already existing in h2/cdmTest.db.

All development is now in a feature branch: feature/presenter-integration-tests

This branch contains the following developments:

  • support for scoped presnter beans by using vaadin-spring-ext-test
  • using spring-test-dbunit to replace unitils.dbunit which is not working well with vaadin-spring-ext-test
  • h2/cdmTest.db with data required by the registration ui procuced by the RegistrationRequiredDataInserter
  • new test applicationContext.xml
Actions #2

Updated by Andreas Kohlbecker over 6 years ago

  • Tags set to test, phycobank
Actions #3

Updated by Andreas Kohlbecker over 6 years ago

  • Target version changed from Unassigned CDM tickets to Reviewed Next Major Release
Actions #4

Updated by Andreas Kohlbecker over 6 years ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved
Actions #5

Updated by Andreas Kohlbecker about 6 years ago

  • Status changed from Resolved to Closed
  • Target version changed from Reviewed Next Major Release to Release 4.13
  • % Done changed from 0 to 100

completed and released in version 4.13

Actions

Also available in: Atom PDF