Project

General

Profile

feature request #7082

Implement integration test for the SpecimenTypeDesignationWorkingsetEditorPresenter

Added by Andreas Kohlbecker about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
New
Category:
cdm-vaadin
Target version:
Start date:
11/22/2017
Due date:
% Done:

100%

Severity:
normal
Tags:

Description

The SpecimenTypeDesignationWorkingsetEditorPresenter needs to perform business logic tasks and needs to configure the deletion of specimens correctly, see methods saveBean(SpecimenTypeDesignationWorkingSetDTO dto) and deleteTypeDesignation(SpecimenTypeDesignationDTO element) , this functionality should be covered with an integration test.


NOTE: The SpecimenTypeDesignationWorkingsetEditorPresenterTest.java has been renamed to SpecimenTypeDesignationWorkingSetServiceImplTest

Associated revisions

Revision 0bc9e6f9 (diff)
Added by Andreas Kohlbecker about 1 year ago

attempt to implement integration tests for the new mvp architecture:
- support for scoped presenter beans by using vaadin-spring-ext-test
- using spring-test-dbunit to replace unitils.dbunit which is not working well with vaadin-spring-ext-test
- h2/cdmTest.db with data required by the registration ui procuced by the RegistrationRequiredDataInserter
- new test applicationContext.xml

Revision 0453b64d (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #7103 fixing test setup and data for SpecimenTypeDesignationWorkingSetServiceImplTest

Revision 9a56a56f (diff)
Added by Andreas Kohlbecker about 1 year ago

ref #7103 completeting assertions for SpecimenTypeDesignationWorkingSetServiceImplTest

History

#1 Updated by Andreas Kohlbecker about 1 year ago

  • Tracker changed from bug to feature request
  • Category set to cdm-vaadin
  • Status changed from New to In Progress
  • Assignee set to Andreas Kohlbecker

I started with the implementation but faced a couple of problems with this. In order to test the presenter properly it is required to test it against a database, otherwise the delete and save operations can not be reliably tested. So using service mocks is not an option in this case.

For now I stopped this development since i am running out of time solving the remaining problems:

  • The data inserted by spring-test-dbunit via the @DatabaseSetup(value="SpecimenTypeDesignationWorkingsetEditorPresenterTest.xml") caused foreign key constraint conflicts with the data already existing in h2/cdmTest.db.

All development is now in a feature branch: feature/presenter-integration-tests

This branch contains the following developments:

  • support for scoped presnter beans by using vaadin-spring-ext-test
  • using spring-test-dbunit to replace unitils.dbunit which is not working well with vaadin-spring-ext-test
  • h2/cdmTest.db with data required by the registration ui procuced by the RegistrationRequiredDataInserter
  • new test applicationContext.xml

#2 Updated by Andreas Kohlbecker about 1 year ago

  • Tags set to test, phycobank

#3 Updated by Andreas Kohlbecker about 1 year ago

  • Target version changed from Unassigned CDM tickets to Reviewed Next Major Release

#4 Updated by Andreas Kohlbecker 12 months ago

  • Description updated (diff)
  • Status changed from In Progress to Resolved

#5 Updated by Andreas Kohlbecker 9 months ago

  • Status changed from Resolved to Closed
  • Target version changed from Reviewed Next Major Release to Release 4.13
  • % Done changed from 0 to 100

completed and released in version 4.13

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)