Activity
From 08/03/2024 to 09/01/2024
08/19/2024
- 06:30 PM EDIT Revision afe6751c (cdmlib): ref #10525: clean up
- 12:17 PM EDIT Revision 0503b841 (cdmlib): ref #10525: Change maxDistance output parameter to matchingScore
08/17/2024
08/14/2024
- 10:58 AM EDIT Revision 704dcbe2 (cdmlib): ref #10582 add comment for thrown exception
- 10:57 AM EDIT Revision ad539205 (cdmlib): cleanup
- 10:46 AM EDIT bug #10582 (New): Lazy loaded Media throw exception when MediaRepresentationPart is missing
- This happens in MediaDto2Loader due to "type(p) as clazz, " in hql select. Do we need the clazz type at all?
- 10:22 AM EDIT bug #10581 (New): Media for facts not shown in portal
- this was observered for Hymenonema laconicum in Cichorieae: https://cichorieae.e-taxonomy.net/portal/cdm_dataportal/t...
08/12/2024
- 06:14 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- ~~~
String pattern = "#.###";
DecimalFormatSymbols otherSymbols = new DecimalFormatSymbols();
...
08/11/2024
- 12:32 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Minor note: tests are easier to read if in something like
~~~
matchResults = nameMatchingService.findMatchingName... - 12:28 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Your tests ofen do something like
~~~
assertEquals("0.969", formmattedDouble);
~~~
This is difficult to revi... - 12:25 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In the tests you do something like
~~~
matchResults = nameMatchingService.findMatchingNames(inputName, true, true... - 12:21 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- The NameMatchingResult has exactResult and bestResults. This is confusing as bestResult is actually not the best (exa...
- 12:16 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Andreas Müller wrote in #note-25:
> You do not seem to compare exBasionymAuthors
I have to correct myself. Now I ... - 12:15 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- You generally seem to compare all authors together. E.g. in
~~~
String combinedAuthorCacheDB = exCombinationAutho... - 12:07 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- You do not seem to compare exBasionymAuthors
- 12:03 AM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- You handle the case
~~~
if (excludeBasionymAuthors == false && excludeExAuthors == false) {
~~~
I guess this...
08/10/2024
- 11:52 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- in code like
~~~
if (excludeExAuthors) {
for (int i = 0 ; i < results.size(); i++) {
... - 11:45 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Why is there a step result shaping in code "findMatchingNamesUnshaped()"? This sounds contradictory.
- 11:43 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In findMatchingNamesUnshaped() you repeat the same code
~~~
// 7. Result shaping
Collect... - 11:37 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Why is there a comparison
~~~
if (distanceAuthorComparison <= 0) {
~~~
Is it really possible that the distan... - 10:46 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- modifiedDamerauLevenshteinDistance() starts with
~~~
if (str1 == str2) {
~~~
I guess you mean
~~~
if (str1.equals... - 10:28 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In authorMatch you use
~~~
distanceAuthorComparison/3
~~~
3 seems to be a hardcoded weight for the final dis... - 10:24 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In authorMatch() better use
~~~
for (SingleNameMatchingResult singleResult : results){
...
}
~~~
or
~~~
result... - 06:58 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
In postfilterEpithet() I do not understand why a list is returned. It looks like the laist can be filled only 1x so...- 06:45 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Minor issue:
Instead of using string comparison with null, e.g.
~~~
} else if (specificEpithetQuery != null &... - 06:38 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In compareGenus why do you pass the empty parameter postFilteredGenusOrUninominalWithDis? It seems to be a simple ret...
- 06:16 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- Minor issue: please remove all documentation that has no content like:
~~~
/**
* @param config
* @para... - 06:13 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- In NameMatchingService there is often code like
~~~
try {
combinationAuthor = name.getCombin... - 06:08 PM EDIT feature request #10525: Implementation of name matching search and remaining issues for fuzzy search
- It is inconsistent that the input parameter maxDistance is integer and by default >1 while the resulting distance is ...
- 06:07 PM EDIT feature request #10525 (In Progress): Implementation of name matching search and remaining issues for fuzzy search
- Why is the title of this ticket "Implementation of name matching search and remaining issues for fuzzy search"? What ...
- 06:05 PM EDIT feature request #10178 (Closed): Implement fuzzy name matching
- 02:57 PM EDIT Revision 42e06f73 (cdmlib-apps): minor
- 02:56 PM EDIT Revision 4cfb1c4e (cdmlib-apps): ref #10235 add cdmlight command line export for E+M
- 02:50 PM EDIT Revision c378088c (cdmlib): cleanup and minor issues
08/08/2024
- 08:14 PM EDIT bug #10579 (Resolved): Protected titleCaches for empty teams not handled correctly in TaxonNameFormatter
- Please review.
- 05:14 PM EDIT bug #10579 (Resolved): Protected titleCaches for empty teams not handled correctly in TaxonNameFormatter
- ... (or TaxonNameDefaultCacheStrategy). This is relevant in taxonPageDto as this is created from cacheStrategy only, ...
- 07:59 PM EDIT Revision 938b250a (cdmlib): ref #10579 handle protected titleCache in Team formatter correctly
08/07/2024
- 10:42 AM EDIT Revision af1c59c9 (cdmlib-apps): ref #10235 add EuroMedWfoIdentifierActivator
- 10:36 AM EDIT Revision 892eebc1 (cdmlib-apps): cleanup
08/06/2024
- 01:17 PM EDIT bug #10578: Type specimen source comparator in cdmlight throws NPE
- please review
- 01:16 PM EDIT bug #10578 (Resolved): Type specimen source comparator in cdmlight throws NPE
- Applied in changeset commit:cdmlib|1dbdf638883e99441b5de1927d41c07efa428632.
- 11:51 AM EDIT bug #10578 (Resolved): Type specimen source comparator in cdmlight throws NPE
- ... if both citations or both date published are null.
- 01:16 PM EDIT Revision 1dbdf638 (cdmlib): fix #10578 fix NPE in source comparator and extract to model.compare
Also available in: Atom