ref #10101 add some javadoc
authorAndreas Müller <a.mueller@bgbm.org>
Thu, 28 Jul 2022 12:05:38 +0000 (14:05 +0200)
committerAndreas Müller <a.mueller@bgbm.org>
Thu, 28 Jul 2022 12:05:38 +0000 (14:05 +0200)
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/taxon/TaxonNode.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/TermNode.java

index bcc706df005c041d498ad82dd07f5f362eb747a8..69ce8679c028f0e8f8e836181944ef0523220279 100644 (file)
@@ -121,9 +121,10 @@ public class TaxonNode
     //see https://dev.e-taxonomy.eu/redmine/issues/3722
     //see https://dev.e-taxonomy.eu/redmine/issues/4200
     //see https://dev.e-taxonomy.eu/redmine/issues/8127
-    //see https://dev.e-taxonomy.eu/redmine/issues/10067
+    //see https://dev.e-taxonomy.eu/redmine/issues/5211
+    //see https://dev.e-taxonomy.eu/redmine/issues/5536
     @OrderColumn(name="sortIndex", nullable=true)
-    @OneToMany(mappedBy="parent", fetch=FetchType.LAZY) // , orphanRemoval=true
+    @OneToMany(mappedBy="parent", fetch=FetchType.LAZY) //no orphanRemoval (#10101)
     //do not cascade
     private List<TaxonNode> childNodes = new ArrayList<>();
 
index c9b204db0c81d9ff7538dcf37c07dd7b1210d771..1d4970ce8926da81afbb1a70b1d65b37eabc5522 100644 (file)
@@ -93,7 +93,7 @@ public class TermNode <T extends DefinedTermBase>
     @XmlElement(name = "Child")
     //see https://dev.e-taxonomy.eu/redmine/issues/3722
     @OrderColumn(name="sortIndex", nullable=true)
-       @OneToMany(fetch = FetchType.LAZY, mappedBy="parent", targetEntity=TermNode.class) //orphanRemoval=true,
+       @OneToMany(fetch = FetchType.LAZY, mappedBy="parent", targetEntity=TermNode.class) //no orphanRemoval (#10101)
        @Cascade({CascadeType.SAVE_UPDATE, CascadeType.MERGE})  //TODO , CascadeType.DELETE makes sense but needs testing in TaxEditor first
        private List<TermNode<T>> children = new ArrayList<>();