From: Andreas Müller <a.mueller@bgbm.org>
Date: Thu, 28 Jul 2022 12:05:38 +0000 (+0200)
Subject: ref #10101  add some javadoc
X-Git-Tag: 5.32.0^2~60
X-Git-Url: https://dev.e-taxonomy.eu/gitweb/cdmlib.git/commitdiff_plain/8b07f256d2ba9f6851a3ba6b31d2b1bf4266ba1f

ref #10101  add some javadoc
---

diff --git a/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/taxon/TaxonNode.java b/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/taxon/TaxonNode.java
index bcc706df00..69ce8679c0 100644
--- a/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/taxon/TaxonNode.java
+++ b/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/taxon/TaxonNode.java
@@ -121,9 +121,10 @@ public class TaxonNode
     //see https://dev.e-taxonomy.eu/redmine/issues/3722
     //see https://dev.e-taxonomy.eu/redmine/issues/4200
     //see https://dev.e-taxonomy.eu/redmine/issues/8127
-    //see https://dev.e-taxonomy.eu/redmine/issues/10067
+    //see https://dev.e-taxonomy.eu/redmine/issues/5211
+    //see https://dev.e-taxonomy.eu/redmine/issues/5536
     @OrderColumn(name="sortIndex", nullable=true)
-    @OneToMany(mappedBy="parent", fetch=FetchType.LAZY) // , orphanRemoval=true
+    @OneToMany(mappedBy="parent", fetch=FetchType.LAZY) //no orphanRemoval (#10101)
     //do not cascade
     private List<TaxonNode> childNodes = new ArrayList<>();
 
diff --git a/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/TermNode.java b/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/TermNode.java
index c9b204db0c..1d4970ce89 100644
--- a/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/TermNode.java
+++ b/cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/TermNode.java
@@ -93,7 +93,7 @@ public class TermNode <T extends DefinedTermBase>
     @XmlElement(name = "Child")
     //see https://dev.e-taxonomy.eu/redmine/issues/3722
     @OrderColumn(name="sortIndex", nullable=true)
-	@OneToMany(fetch = FetchType.LAZY, mappedBy="parent", targetEntity=TermNode.class) //orphanRemoval=true,
+	@OneToMany(fetch = FetchType.LAZY, mappedBy="parent", targetEntity=TermNode.class) //no orphanRemoval (#10101)
 	@Cascade({CascadeType.SAVE_UPDATE, CascadeType.MERGE})  //TODO , CascadeType.DELETE makes sense but needs testing in TaxEditor first
 	private List<TermNode<T>> children = new ArrayList<>();