ref #6925 Pull up selection handler and service
authorPatrick Plitzner <p.plitzner@bgbm.org>
Fri, 22 Sep 2017 09:05:02 +0000 (11:05 +0200)
committerPatrick Plitzner <p.plitzner@bgbm.org>
Fri, 22 Sep 2017 11:38:23 +0000 (13:38 +0200)
eu.etaxonomy.taxeditor.bulkeditor/src/main/java/eu/etaxonomy/taxeditor/bulkeditor/referencingobjects/e4/ReferencingObjectsViewE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/concept/e4/ConceptViewPartE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/descriptive/e4/FactualDataPartE4.java
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/view/media/e4/MediaViewPartE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/AbstractCdmEditorPartE4.java
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/view/e4/details/DetailsPartE4.java

index c2f69d91497fda27a7619046d4276d3fcb62dbe0..81e2c0ca6993e785a83d4b6215a7816dcbcd9ebf 100644 (file)
@@ -18,7 +18,6 @@ import java.util.UUID;
 
 import javax.annotation.PostConstruct;
 import javax.annotation.PreDestroy;
-import javax.inject.Inject;
 
 import org.apache.log4j.Logger;
 import org.eclipse.core.runtime.IProgressMonitor;
@@ -27,10 +26,8 @@ import org.eclipse.core.runtime.Status;
 import org.eclipse.core.runtime.jobs.Job;
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
 import org.eclipse.e4.ui.services.EMenuService;
-import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
 import org.eclipse.jface.viewers.CellEditor;
 import org.eclipse.jface.viewers.ICellModifier;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.ITableLabelProvider;
 import org.eclipse.jface.viewers.TableViewer;
@@ -110,11 +107,6 @@ public class ReferencingObjectsViewE4 extends AbstractCdmEditorPartE4 {
        IProgressMonitor actualMonitor = null;
        private Job currentJob = null;
 
-    private ISelectionChangedListener selectionChangedListener;
-
-    @Inject
-    private ESelectionService selService;
-
     @PostConstruct
     public void create(Composite parent, EMenuService menuService) {
         if (CdmStore.isActive()){
index 8f9acc976f2b3e85843929590b9cc63fafb66533..8c81285146baf787ff1f5e3b088e1d52aa6700d9 100644 (file)
@@ -12,13 +12,10 @@ package eu.etaxonomy.taxeditor.editor.view.concept.e4;
 import java.util.Map.Entry;
 
 import javax.annotation.PostConstruct;
-import javax.inject.Inject;
 
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
 import org.eclipse.e4.ui.services.EMenuService;
-import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
 import org.eclipse.jface.viewers.ISelection;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.ListViewer;
 import org.eclipse.jface.viewers.StructuredSelection;
@@ -54,11 +51,6 @@ import eu.etaxonomy.taxeditor.view.e4.supplementaldata.SupplementalDataPartE4;
 public class ConceptViewPartE4 extends AbstractCdmEditorPartE4
 implements IPartContentHasDetails, IPartContentHasSupplementalData{
 
-    private ISelectionChangedListener selectionChangedListener;
-
-    @Inject
-    private ESelectionService selService;
-
     @Override
     public void selectionChanged_internal(Object selection, MPart activePart, MPart thisPart) {
         if(activePart==thisPart){
index 62fe4ede1976c0949bd5dd5ad8ec8380802284d2..2279cdd54f09060b22fd8ef2b74948d461db61b5 100644 (file)
@@ -15,16 +15,13 @@ import java.util.List;
 import java.util.Map;
 
 import javax.annotation.PostConstruct;
-import javax.inject.Inject;
 
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
 import org.eclipse.e4.ui.services.EMenuService;
-import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
 import org.eclipse.jface.action.Action;
 import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.resource.ImageDescriptor;
 import org.eclipse.jface.viewers.AbstractTreeViewer;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.ITreeContentProvider;
 import org.eclipse.jface.viewers.StructuredSelection;
@@ -90,11 +87,6 @@ public class FactualDataPartE4 extends AbstractCdmEditorPartE4
 
     private DescriptiveContentProvider provider;
 
-    private ISelectionChangedListener selectionChangedListener;
-
-    @Inject
-    private ESelectionService selService;
-
     @PostConstruct
     public void create(Composite parent, EMenuService menuService) {
         TreeViewer treeViewer = new TreeViewer(new Tree(parent, SWT.H_SCROLL
index 690f998e574b31a5824758f7644241ab37327e59..653a02ae307ce6c8fc7713194b924eb15d8d9944 100644 (file)
 package eu.etaxonomy.taxeditor.editor.view.media.e4;
 
 import javax.annotation.PostConstruct;
-import javax.inject.Inject;
 
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
 import org.eclipse.e4.ui.services.EMenuService;
-import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
 import org.eclipse.jface.viewers.AbstractTreeViewer;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.jface.viewers.TreeNode;
@@ -49,12 +46,7 @@ import eu.etaxonomy.taxeditor.view.e4.supplementaldata.SupplementalDataPartE4;
 public class MediaViewPartE4 extends AbstractCdmEditorPartE4
         implements IPartContentHasDetails, IPartContentHasSupplementalData {
 
-    private ISelectionChangedListener selectionChangedListener;
-
-       @Inject
-       private ESelectionService selService;
-
-       @PostConstruct
+    @PostConstruct
        public void create(Composite parent, EMenuService menuService) {
 
                TreeViewer treeViewer = new TreeViewer(new Tree(parent, SWT.H_SCROLL
index f86f4612c4cfa4ac4406e8e326105ac2f7651d9f..39ce64f01b41d577a6da82feb84ee960c0617b94 100644 (file)
@@ -18,6 +18,8 @@ import org.eclipse.e4.core.di.annotations.Optional;
 import org.eclipse.e4.ui.di.PersistState;
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
 import org.eclipse.e4.ui.services.IServiceConstants;
+import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
+import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.jface.viewers.StructuredSelection;
 import org.eclipse.jface.viewers.Viewer;
@@ -123,6 +125,11 @@ public abstract class AbstractCdmEditorPartE4
 
     protected MPart selectionProvidingPart;
 
+    protected ISelectionChangedListener selectionChangedListener;
+
+    @Inject
+    protected ESelectionService selService;
+
     /** {@inheritDoc} */
     @Override
     public void changed(Object object) {
index 36724567123f17d409cece0846511c62a0ae2809..4663a6bd4de955ba659e74930e8cf228413fb372 100644 (file)
@@ -13,8 +13,6 @@ import javax.annotation.PostConstruct;
 import javax.inject.Inject;
 
 import org.eclipse.e4.ui.model.application.ui.basic.MPart;
-import org.eclipse.e4.ui.workbench.modeling.ESelectionService;
-import org.eclipse.jface.viewers.ISelectionChangedListener;
 import org.eclipse.jface.viewers.IStructuredSelection;
 import org.eclipse.swt.widgets.Composite;
 
@@ -35,11 +33,6 @@ import eu.etaxonomy.taxeditor.workbench.part.ISelectionElementEditingPart;
  */
 public class DetailsPartE4 extends AbstractCdmEditorPartE4 implements IPartContentHasSupplementalData {
 
-    private ISelectionChangedListener selectionChangedListener;
-
-    @Inject
-    private ESelectionService selService;
-
     @Inject
     public DetailsPartE4() {
     }