fix #6489: add the actually selected object as parameter to the selection dialog...
authorKatja Luther <k.luther@bgbm.org>
Tue, 4 Apr 2017 09:42:17 +0000 (11:42 +0200)
committerKatja Luther <k.luther@bgbm.org>
Tue, 4 Apr 2017 09:42:45 +0000 (11:42 +0200)
eu.etaxonomy.taxeditor.editor/src/main/java/eu/etaxonomy/taxeditor/editor/name/handler/MoveSynonymToAnotherAcceptedTaxonHandler.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/handler/RemotingChangeAcceptedTaxonToSynonymHandler.java
eu.etaxonomy.taxeditor.navigation/src/main/java/eu/etaxonomy/taxeditor/navigation/navigator/handler/RemotingMoveTaxonNodeHandler.java

index 0a56c3cc8797a50cfb9749a387942b89a1171a6e..e81437b8dd93875b8a5e1de58945800cf2c285d8 100644 (file)
@@ -61,8 +61,8 @@ public class MoveSynonymToAnotherAcceptedTaxonHandler extends AbstractHandler im
                List<UUID> excludeTaxa = new ArrayList<UUID>();
                excludeTaxa.add(oldParent.getUuid());
 
-                               
-               TaxonNode newParentNode = TaxonNodeSelectionDialog.select(HandlerUtil.getActiveShell(event), editor.getConversationHolder(), Messages.MoveSynonymToAnotherAcceptedTaxonHandler_SELECT_ACC_TAXON, excludeTaxa, null, ((TaxonEditorInput)input).getTaxonNode().getClassification());
+
+               TaxonNode newParentNode = TaxonNodeSelectionDialog.select(HandlerUtil.getActiveShell(event), editor.getConversationHolder(), Messages.MoveSynonymToAnotherAcceptedTaxonHandler_SELECT_ACC_TAXON, excludeTaxa,  ((TaxonEditorInput)input).getTaxonNode(), ((TaxonEditorInput)input).getTaxonNode().getClassification());
 
                if(newParentNode!=null){
                   MoveSynonymToAnotherAcceptedTaxonOperation operation = new MoveSynonymToAnotherAcceptedTaxonOperation(Messages.MoveSynonymToAnotherAcceptedTaxonHandler_CHANGE_ACC_TAXON, EditorUtil.getUndoContext(),
index b480b103f1564128015411c35ea9ed1a8cbc9811..a23f4786d1a3c122362ac3e2acd3b36a23593857 100644 (file)
@@ -16,7 +16,6 @@ import org.eclipse.jface.viewers.TreeSelection;
 import org.eclipse.ui.handlers.HandlerUtil;
 
 import eu.etaxonomy.cdm.api.conversation.ConversationHolderMock;
-import eu.etaxonomy.cdm.model.taxon.ITaxonTreeNode;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
 import eu.etaxonomy.taxeditor.navigation.l10n.Messages;
 import eu.etaxonomy.taxeditor.navigation.navigator.TaxonNavigatorLabels;
@@ -37,7 +36,7 @@ public class RemotingChangeAcceptedTaxonToSynonymHandler extends RemotingCdmHand
             .getLogger(RemotingChangeAcceptedTaxonToSynonymHandler.class);
 
 
-    private ITaxonTreeNode oldTaxonNode;
+    private TaxonNode oldTaxonNode;
 
        /**
      * @param label
@@ -67,15 +66,15 @@ public class RemotingChangeAcceptedTaxonToSynonymHandler extends RemotingCdmHand
 
         // check that selected object is a taxon node
         Object obj = selection.iterator().next();
-        if(obj instanceof ITaxonTreeNode) {
-            oldTaxonNode = (ITaxonTreeNode)obj;
+        if(obj instanceof TaxonNode) {
+            oldTaxonNode = (TaxonNode)obj;
         } else {
             return new Status(IStatus.ERROR,
                     "unknown", //$NON-NLS-1$
                     TaxonNavigatorLabels.SELECTED_OBJECT_NOT_TREE_NODE_MESSAGE);
         }
         // check that the source taxon node does not have children
-        if(((TaxonNode)oldTaxonNode).getCountChildren() > 0) {
+        if(oldTaxonNode.getCountChildren() > 0) {
             return new Status(IStatus.ERROR,
                     "unknown", //$NON-NLS-1$
                     TaxonNavigatorLabels.SOURCE_TAXON_HAS_CHILDREN_MESSAGE);
@@ -83,7 +82,7 @@ public class RemotingChangeAcceptedTaxonToSynonymHandler extends RemotingCdmHand
         }
 
         // check if corresponding name editor is closed
-        boolean editorClosed = NavigatorHandlerUtils.closeObsoleteEditor(event, (TaxonNode) oldTaxonNode);
+        boolean editorClosed = NavigatorHandlerUtils.closeObsoleteEditor(event, oldTaxonNode);
         if(editorClosed != true) {
             return new Status(IStatus.ERROR,
                     "unknown", //$NON-NLS-1$
@@ -98,13 +97,13 @@ public class RemotingChangeAcceptedTaxonToSynonymHandler extends RemotingCdmHand
     @Override
     public AbstractOperation prepareOperation(ExecutionEvent event) {
         List<UUID> excludeTaxa = new ArrayList<UUID>();
-        excludeTaxa.add(((TaxonNode)oldTaxonNode).getTaxon().getUuid());
+        excludeTaxa.add(oldTaxonNode.getTaxon().getUuid());
         TaxonNode newAcceptedTaxonNode = TaxonNodeSelectionDialog.select(HandlerUtil.getActiveShell(event),
                 new ConversationHolderMock(),
                 Messages.RemotingChangeAcceptedTaxonToSynonymHandler_CHOOSE_TAXON,
                 excludeTaxa,
-                null,
-                ((TaxonNode)oldTaxonNode).getClassification());
+                oldTaxonNode,
+                oldTaxonNode.getClassification());
 
         if (newAcceptedTaxonNode == null) {
             return null;
index bbedbc1242fdf6aabee0372c3e3bff1be3e7b8d5..2f98ab90ffe2cbf1797f048c698c8c00ff0a75ee 100644 (file)
@@ -113,7 +113,7 @@ public class RemotingMoveTaxonNodeHandler extends RemotingCdmHandler {
                     new ConversationHolderMock(),
                     Messages.RemotingMoveTaxonNodeHandler_CHOOSE_PARENT,
                     excludeTaxa,
-                    null,
+                    oldTaxonNode,
                     oldTaxonNode.getClassification());
         }