cleanup
authorAndreas Müller <a.mueller@bgbm.org>
Wed, 13 Jul 2022 21:27:19 +0000 (23:27 +0200)
committerAndreas Müller <a.mueller@bgbm.org>
Wed, 13 Jul 2022 21:27:19 +0000 (23:27 +0200)
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/agent/Team.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/persistence/dao/hibernate/common/CdmEntityDaoBase.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/bean/AbstractBeanProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/bean/RegistrationDtoBeanProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/value/DateTimeJSONValueProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/value/HibernateJSONValueProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/value/MapJSONValueProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/value/PartialJSONValueProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/json/processor/value/UUIDJSONValueProcessor.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/view/JsonView.java
cdmlib-services/src/main/java/eu/etaxonomy/cdm/api/service/registration/RegistrationWorkingSetService.java

index c548a2b0c2f724b6e3ae88d11a842370df4c5184..da0d2f4a66fc30c1f32aacd860ba9b0f8c805395 100644 (file)
@@ -27,7 +27,8 @@ import javax.xml.bind.annotation.XmlRootElement;
 import javax.xml.bind.annotation.XmlSchemaType;
 import javax.xml.bind.annotation.XmlType;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.hibernate.annotations.Cascade;
 import org.hibernate.annotations.CascadeType;
 import org.hibernate.annotations.ListIndexBase;
index 8c243d8436b752cdf502f879c09f8554d3042120..b4bb988eee88b371fe3d5c30225ec0b518014dba 100644 (file)
@@ -21,7 +21,8 @@ import java.util.Map;
 import java.util.Set;
 import java.util.UUID;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.hibernate.Criteria;
 import org.hibernate.FlushMode;
 import org.hibernate.HibernateException;
@@ -1152,7 +1153,7 @@ public abstract class CdmEntityDaoBase<T extends CdmBase>
             List<OrderHint> orderHints, List<String> propertyPaths) {
 
         List<Restriction<?>> allRestrictions = new ArrayList<>();
-        allRestrictions.add(new Restriction<String>(param, matchmode, queryString));
+        allRestrictions.add(new Restriction<>(param, matchmode, queryString));
         if(restrictions != null){
             allRestrictions.addAll(restrictions);
         }
@@ -1174,7 +1175,7 @@ public abstract class CdmEntityDaoBase<T extends CdmBase>
             MatchMode matchmode, List<Restriction<?>> restrictions) {
 
         List<Restriction<?>> allRestrictions = new ArrayList<>();
-        allRestrictions.add(new Restriction<String>(param, matchmode, queryString));
+        allRestrictions.add(new Restriction<>(param, matchmode, queryString));
         if(restrictions != null){
             allRestrictions.addAll(restrictions);
         }
index d9d77920eef976dda692a0d18f8042dfba3987b3..9e21ad8d4e2beb1c217bbebe3391d1833e855821 100644 (file)
@@ -17,7 +17,8 @@ import java.util.Map;
 import java.util.Set;
 
 import org.apache.commons.beanutils.PropertyUtils;
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.hibernate.Hibernate;
 
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -114,7 +115,7 @@ public abstract class AbstractBeanProcessor<T extends Object> implements JsonBea
             }
 
             try {
-                // ------ reusing snippet from JSONOnbject._fromBean()
+                // ------ reusing snippet from JSONObject._fromBean()
                 Class<?> type = prop.getPropertyType();
                 Object value = PropertyUtils.getProperty( bean, key );
 
index cbaec3eb4a6ccd9f816b58f955e41b6da4012763..edd8e00ae478b2bb197763bb83cef92bc56d497e 100644 (file)
@@ -27,7 +27,7 @@ public class RegistrationDtoBeanProcessor extends AbstractBeanProcessor<Registra
                 "blockedBy",
                 "blocked",
                 "submitterUserName"
-                );
+            );
     }
 
     @Override
@@ -35,5 +35,4 @@ public class RegistrationDtoBeanProcessor extends AbstractBeanProcessor<Registra
         // nothing to do here
         return json;
     }
-
-}
+}
\ No newline at end of file
index 01be3f28d0bb26e56b68ad4199566d4d2597c19a..b90cf5f359bd431ed7cc1f94efbe97da17a3b047 100644 (file)
@@ -31,18 +31,18 @@ public class DateTimeJSONValueProcessor implements JsonValueProcessor {
        @Override
     public Object processArrayValue(Object object, JsonConfig jsonConfig) {
                DateTime dateTime = (DateTime) object;
-        return formatDateTime(object);
+        return formatDateTime(dateTime);
        }
 
        @Override
     public Object processObjectValue(String key, Object object,
                        JsonConfig jsonConfig) {
-           return formatDateTime(object);
+           return formatDateTime((DateTime)object);
        }
 
-    public Object formatDateTime(Object object) {
+    Object formatDateTime(DateTime object) {
         if(object != null){
-               DateTime dateTime = (DateTime) object;
+               DateTime dateTime = object;
                // WARNING! null means now!
                return DateTimeJSONValueProcessor.iso8601Format.print(dateTime);
            } else {
index 5c8acd1b40c0f979d4d08f6095d8a6b891536a6f..37463d7f32a3662aa122ced48aef605f0451c37d 100644 (file)
@@ -1,34 +1,34 @@
 /**
  * Copyright (C) 2009 EDIT European Distributed Institute of Taxonomy
  * http://www.e-taxonomy.eu
- * 
+ *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 See LICENSE.TXT at the top of this package for the full license terms.
  */
 
 package eu.etaxonomy.cdm.remote.json.processor.value;
 
-import net.sf.json.JSONArray;
-import net.sf.json.JsonConfig;
-import net.sf.json.processors.JsonValueProcessor;
-
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import eu.etaxonomy.cdm.hibernate.HibernateProxyHelper;
 import eu.etaxonomy.cdm.remote.json.processor.matcher.HibernateJSONValueProcessorMatcher;
+import net.sf.json.JSONArray;
+import net.sf.json.JsonConfig;
+import net.sf.json.processors.JsonValueProcessor;
 
 /**
  * Used in conjunction with the {@link HibernateJSONValueProcessorMatcher} to unwrap
  * beans from hibernate proxies. Using this Value processor is essential for
  * properly detecting @Transient annotations which are not inherited by subclasses
  * like the proxies
- * 
+ *
  * @author a.kohlbecker
  */
 public class HibernateJSONValueProcessor implements JsonValueProcessor {
-       
+
        public static final Logger logger = LogManager.getLogger(HibernateJSONValueProcessor.class);
-       
+
 //     public Object processArrayValue(Object object, JsonConfig jsonConfig) {
 //             if(Hibernate.isInitialized(object)) {
 //                     log.debug("Processing array value " + object);
@@ -38,22 +38,22 @@ public class HibernateJSONValueProcessor implements JsonValueProcessor {
 //                 return JSONNull.getInstance();
 //             }
 //     }
-       
-       public Object processArrayValue(Object object, JsonConfig jsonConfig) {
+
+       @Override
+    public Object processArrayValue(Object object, JsonConfig jsonConfig) {
                // usage of the InitializedHibernatePropertyFiler is expected !!!
                // retain default processing
                return JSONArray.fromObject(object,jsonConfig);
        }
-               
 
-       public Object processObjectValue(String propertyName, Object object, JsonConfig jsonConfig) {
+       @Override
+    public Object processObjectValue(String propertyName, Object object, JsonConfig jsonConfig) {
                // deproxy
                Object target = HibernateProxyHelper.deproxy(object, Object.class);
                if(logger.isDebugEnabled()){
                        logger.debug("deproxying object " + target);
                }
                return target;
-                
-       }
 
-}
+       }
+}
\ No newline at end of file
index 49b535fc7380c952d74e2b7dccbd2a778ede15ef..88aaaee4ea795c6463e390c9c12f1b5f66d6531e 100644 (file)
@@ -23,7 +23,6 @@ import net.sf.json.processors.JsonValueProcessor;
 /**
  * @author a.kohlbecker
  * @since 23.06.2010
- *
  */
 public class MapJSONValueProcessor implements JsonValueProcessor {
 
@@ -63,13 +62,9 @@ public class MapJSONValueProcessor implements JsonValueProcessor {
                return JSONObject.fromObject(value, jsonConfig);
        }
 
-       /* (non-Javadoc)
-        * @see net.sf.json.processors.JsonValueProcessor#processObjectValue(java.lang.String, java.lang.Object, net.sf.json.JsonConfig)
-        */
        @Override
        public Object processObjectValue(String key, Object value,
                        JsonConfig jsonConfig) {
                return processArrayValue(value, jsonConfig);
        }
-
-}
+}
\ No newline at end of file
index a728bc30a2f82b4bba6a31d6be0dcc99fb80704b..0a7f60c777549e3a87c8b3589331e58c05ad3bfa 100644 (file)
@@ -1,37 +1,34 @@
 /**
 * Copyright (C) 2007 EDIT
-* European Distributed Institute of Taxonomy 
+* European Distributed Institute of Taxonomy
 * http://www.e-taxonomy.eu
-* 
+*
 * The contents of this file are subject to the Mozilla Public License Version 1.1
 * See LICENSE.TXT at the top of this package for the full license terms.
 */
-
 package eu.etaxonomy.cdm.remote.json.processor.value;
 
-import net.sf.json.JsonConfig;
-import net.sf.json.processors.JsonValueProcessor;
-
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.joda.time.Partial;
 import org.joda.time.format.ISODateTimeFormat;
 
 import eu.etaxonomy.cdm.hibernate.PartialUserType;
+import net.sf.json.JsonConfig;
+import net.sf.json.processors.JsonValueProcessor;
 
 /**
  * Partial time as four digit year, two digit month of year, and two digit day of month (yyyy-MM-dd).
+ *
  * @author a.kohlbecker
  * @since 20.01.2008
- * @version 1.0
  */
 public class PartialJSONValueProcessor implements JsonValueProcessor {
-       private static Logger logger = LogManager.getLogger(PartialJSONValueProcessor.class);
 
-       
-       /* (non-Javadoc)
-        * @see net.sf.json.processors.JsonValueProcessor#processArrayValue(java.lang.Object, net.sf.json.JsonConfig)
-        */
-       public Object processArrayValue(Object object, JsonConfig jsonConfig) {
+    private static Logger logger = LogManager.getLogger(PartialJSONValueProcessor.class);
+
+       @Override
+    public Object processArrayValue(Object object, JsonConfig jsonConfig) {
                if(object == null){
                        return "";
                }
@@ -42,10 +39,8 @@ public class PartialJSONValueProcessor implements JsonValueProcessor {
         return partial.toString(ISODateTimeFormat.date());
        }
 
-       /* (non-Javadoc)
-        * @see net.sf.json.processors.JsonValueProcessor#processObjectValue(java.lang.String, java.lang.Object, net.sf.json.JsonConfig)
-        */
-       public Object processObjectValue(String key, Object object, JsonConfig jsonConfig) {
+       @Override
+    public Object processObjectValue(String key, Object object, JsonConfig jsonConfig) {
                if(object == null){
                        return "";
                }
index 6e8b20364d2e43f5078e2d1404f4eb10db990268..660ffdf7d81d7bbf1f1f3d26fc7355d1a294c34e 100644 (file)
@@ -5,12 +5,12 @@
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 See LICENSE.TXT at the top of this package for the full license terms.
  */
-
 package eu.etaxonomy.cdm.remote.json.processor.value;
 
 import java.util.UUID;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import net.sf.json.JsonConfig;
 import net.sf.json.processors.JsonValueProcessor;
@@ -38,6 +38,5 @@ public class UUIDJSONValueProcessor implements JsonValueProcessor {
                }
                UUID uuid = (UUID) obj;
                return uuid.toString();
-       };
-
-}
+       }
+}
\ No newline at end of file
index e9433b2b0718249cba0a77ba72c240066f40a1de..b3d01b2c007055bcf24ec6bb571728fbcb689538 100644 (file)
@@ -17,7 +17,8 @@ import javax.servlet.http.HttpServletResponse;
 
 import org.apache.commons.beanutils.BeanUtilsBean;
 import org.apache.commons.beanutils.SuppressPropertiesBeanIntrospector;
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.springframework.web.servlet.View;
 
 import eu.etaxonomy.cdm.opt.config.DataSourceProperties;
@@ -114,10 +115,9 @@ public class JsonView extends BaseView implements View {
 
         String contextPath = null;
 
-        if (request != null)
-               {
+        if (request != null) {
                contextPath = request.getContextPath();
-               }
+        }
 
         if(jsonConfig == null){
             logger.error("The jsonConfig must not be null. It must be set in the applicationContext.");
@@ -132,7 +132,7 @@ public class JsonView extends BaseView implements View {
         boolean isCollectionType = false;
         JSON jsonObj;
         if (entity == null){
-          jsonObj = JSONObject.fromObject("{}");
+            jsonObj = JSONObject.fromObject("{}");
         } else if(Collection.class.isAssignableFrom(entity.getClass())){
             isCollectionType = true;
             jsonObj = JSONArray.fromObject(entity, jsonConfig);
@@ -151,8 +151,8 @@ public class JsonView extends BaseView implements View {
             XMLSerializer xmlSerializer = new XMLSerializer();
             if(isCollectionType){
                 xmlSerializer.setArrayName(entity.getClass().getSimpleName());
-                Class elementType = Object.class;
-                Collection c = (Collection)entity;
+                Class<?> elementType = Object.class;
+                Collection<?> c = (Collection<?>)entity;
                 if(c.size() > 0){
                     elementType = c.iterator().next().getClass();
                 }
@@ -205,6 +205,4 @@ public class JsonView extends BaseView implements View {
         // render
         render(entity, writer, jsonpCallback, request, response);
     }
-
-
-}
+}
\ No newline at end of file
index 21d0374ec7cbb48a62430dd0d7e049589bc5fec0..25ef8844c3398f1061a0c5cb38b2cda0febc1ade 100644 (file)
@@ -18,7 +18,8 @@ import java.util.Optional;
 import java.util.Set;
 import java.util.UUID;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.hibernate.Hibernate;
 import org.joda.time.DateTime;
 import org.joda.time.Partial;
@@ -466,10 +467,4 @@ public class RegistrationWorkingSetService implements IRegistrationWorkingSetSer
             }
         }
     }
-
-
-
-
-
-
-}
+}
\ No newline at end of file