code cosmetics
authorAndreas Kohlbecker <a.kohlbecker@bgbm.org>
Tue, 26 Jun 2012 14:55:27 +0000 (14:55 +0000)
committerAndreas Kohlbecker <a.kohlbecker@bgbm.org>
Tue, 26 Jun 2012 14:55:27 +0000 (14:55 +0000)
cdmlib-model/src/main/java/eu/etaxonomy/cdm/hibernate/search/DescriptionBaseClassBridge.java
cdmlib-services/src/test/java/eu/etaxonomy/cdm/api/service/TaxonServiceSearchTest.java

index ca570f53b315a16930e80c3a3e42238fd91fd497..7e3ed38ac949f564c1deef5256d2166ebd721e1d 100644 (file)
@@ -25,15 +25,15 @@ import eu.etaxonomy.cdm.model.taxon.Taxon;
 import eu.etaxonomy.cdm.model.taxon.TaxonNode;
 
 /**
- * needed to overcome limitations in hibernate search see:
- * "Support runtime polymorphism on associations (instead of defining the indexed properties based on the returned type"
- * (https://hibernate.onjira.com/browse/HSEARCH-438) and see:
- * https://forum.hibernate
- * .org/search.php?keywords=indexembedded+subclass&terms=all
- * &author=&sc=1&sf=all&sk=t&sd=d&sr=posts&st=0&ch=300&t=0&submit=Search
- *
- * DEVELOPER NOTE: the problem: void org.hibernate.search.engine.DocumentBuilderContainedEntity.initializeClass(XClass clazz, PropertiesMetadata propertiesMetadata, boolean isRoot, String prefix, Set<XClass> processedClasses, InitContext context)
- * is not taking sublasses into account so the taxon field defined in taxonBase is not registered in the propertiesMetdata
+ * This class bridge is needed to overcome limitations in hibernate search with polymorphism on associations. See:
+ * <ol>
+ * <li>"Support runtime polymorphism on associations (instead of defining the indexed properties based on the returned type"
+ * (https://hibernate.onjira.com/browse/HSEARCH-438)</li>
+ * <li>https://forum.hibernate.org/search.php?keywords=indexembedded+subclass&terms=all
+ * &author=&sc=1&sf=all&sk=t&sd=d&sr=posts&st=0&ch=300&t=0&submit=Search</li>
+ *</ol>
+ * DEVELOPER NOTE: the problem is in {@link org.hibernate.search.engine.DocumentBuilderContainedEntity#initializeClass()} which
+ * is not taking subclasses into account, so the <code>taxon</code> field defined in {@link TaxonDescription} is not registered in the <code>propertiesMetdata</code>
  *
  * @author Andreas Kohlbecker
  * @date Dec 19, 2011
index 1069934b8ef8720a1f6c46bf6656fa09793ebe96..d40ea2177ae175516762f172949aaf987f08d675 100644 (file)
@@ -324,7 +324,6 @@ public class TaxonServiceSearchTest extends CdmTransactionalIntegrationTest {
 \r
     @SuppressWarnings("rawtypes")\r
     @Test\r
-//    @Ignore //FIXME index is not updated after commit !!! (see below)\r
     @DataSet\r
     public final void testFindByDescriptionElementFullText_modify_Classification() throws CorruptIndexException, IOException, ParseException {\r
 \r