cleanup
authorAndreas Müller <a.mueller@bgbm.org>
Tue, 13 Dec 2022 08:44:49 +0000 (09:44 +0100)
committerAndreas Müller <a.mueller@bgbm.org>
Tue, 13 Dec 2022 10:43:12 +0000 (11:43 +0100)
15 files changed:
cdmlib-io/src/main/java/eu/etaxonomy/cdm/io/cdm2cdm/Cdm2CdmImportBase.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/common/RelationshipTermBase.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/location/NamedAreaLevel.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/name/NameTypeDesignationStatus.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/OrderedTerm.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/VocabularyEnum.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/init/ITermLoader.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/model/term/init/TermLoader.java
cdmlib-model/src/test/java/eu/etaxonomy/cdm/model/name/TaxonNameTest.java
cdmlib-model/src/test/java/eu/etaxonomy/cdm/model/term/OrderedTermBaseTest.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/database/update/v30_40/ReferencedObjTypeUpdater.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/persistence/dao/hibernate/term/OrderedTermVocabularyDaoImpl.java
cdmlib-services/src/main/java/eu/etaxonomy/cdm/api/service/ITermService.java
cdmlib-services/src/main/java/eu/etaxonomy/cdm/api/util/DescriptionUtility.java
cdmlib-services/src/test/java/eu/etaxonomy/cdm/api/service/description/DistributionAggregationTest.java

index 204562a10c7262d45d3cb4656c89931e59342397..7ed53542f7d3689612e4044b89973abba11523a9 100644 (file)
@@ -138,9 +138,6 @@ public abstract class Cdm2CdmImportBase
     private static final long serialVersionUID = 1344722304369624443L;
     private static final Logger logger = LogManager.getLogger();
 
-    //quick and dirty
-    private Cdm2CdmImportState stateX;
-
     protected ICdmApplication sourceRepo(Cdm2CdmImportState state){
         ICdmApplication repo = state.getSourceRepository();
         if (repo == null){
index 8f87d2828301bc230026d6841e62e1e0a9c0b348..469a86a7c256f6cc44c596942848d0a8e6ab1ee0 100644 (file)
@@ -71,7 +71,7 @@ public abstract class RelationshipTermBase<T extends RelationshipTermBase<T>>
           extends OrderedTermBase<T> {
        private static final long serialVersionUID = 5497187985269083971L;
        @SuppressWarnings("unused")
-       private static final Logger logger = LogManager.getLogger(RelationshipTermBase.class);
+       private static final Logger logger = LogManager.getLogger();
 
        @XmlElement(name = "Symmetrical")
        @Field(analyze = Analyze.NO)
index 566ad868a121c160a6baa4910fe10c260a537c1c..de90dc994cd636525e8b7d9e7df5a379032fd901 100644 (file)
@@ -44,7 +44,7 @@ public class NamedAreaLevel extends OrderedTermBase<NamedAreaLevel> {
 
        private static final long serialVersionUID = -7977901140330659208L;
        @SuppressWarnings("unused")
-       private static final Logger logger = LogManager.getLogger(NamedAreaLevel.class);
+       private static final Logger logger = LogManager.getLogger();
 
        protected static Map<UUID, NamedAreaLevel> termMap = null;
 
index 597e024be5e9690d259ab3d49b98bb11305c772d..0e80ffac1c43a899fecb864c11e0575f7a217e47 100644 (file)
@@ -6,7 +6,6 @@
 * The contents of this file are subject to the Mozilla Public License Version 1.1
 * See LICENSE.TXT at the top of this package for the full license terms.
 */
-
 package eu.etaxonomy.cdm.model.name;
 
 import java.util.HashMap;
index 5ec1a21750488c418ef0a827858ef7fc856adf18..7df6e81022418039407377d59f44b7eaf7ecff0d 100644 (file)
@@ -43,7 +43,6 @@ public class OrderedTerm extends OrderedTermBase<OrderedTerm>  {
 
        protected static Map<UUID, OrderedTerm> termMap = null;
 
-
        protected static OrderedTerm getTermByUuid(UUID uuid){
         if (termMap == null || termMap.isEmpty()){
             return getTermByClassAndUUID(OrderedTerm.class, uuid);
@@ -52,17 +51,14 @@ public class OrderedTerm extends OrderedTermBase<OrderedTerm>  {
                }
        }
 
-
        public static OrderedTerm NewInstance(TermType termType, String description, String label, String labelAbbrev){
                return new OrderedTerm(termType, description, label, labelAbbrev);
        }
 
-
        public static OrderedTerm NewDnaQualityInstance(String description, String label, String labelAbbrev){
                return new OrderedTerm(TermType.DnaQualityType, description, label, labelAbbrev);
        }
 
-
 //******************* CONSTRUCTOR ***********************************/
 
        //for hibernate use only, *packet* private required by bytebuddy
index 815cd7985a8a1ade9722beed1cfaf157c85ab00c..544f5c2180c5b7465418b1e2a9a5bd4085cdfe61 100644 (file)
@@ -6,7 +6,6 @@
 * The contents of this file are subject to the Mozilla Public License Version 1.1
 * See LICENSE.TXT at the top of this package for the full license terms.
 */
-
 package eu.etaxonomy.cdm.model.term;
 
 import java.util.UUID;
index d1758d7697722691a50dcc3de90bf6164e521808..694dae2bb2af8327b7624736a2cc938ddaf97b14 100644 (file)
@@ -51,12 +51,8 @@ public interface ITermLoader {
         * @param vocType VocabularyEnum
         * @param voc vocabulary
         * @param missingTerms Set of UUIDs for terms to be loaded.
-        * @return
         */
        public <T extends DefinedTermBase<T>, S extends OrderedTermBase<S>> Set<T> loadSingleTerms(VocabularyEnum vocType, TermVocabulary<T> voc,
                                Set<UUID> missingTerms);
 
-
-
-
 }
index 09ddcb70716add924e3bdc10599b7f72181c1b24..8fb1732121952f079e5ee0c76d798c14756c0b46 100644 (file)
@@ -139,6 +139,7 @@ public class TermLoader implements ITermLoader {
                    String[] csvLine, Map<UUID,DefinedTermBase> terms, Class<T> termClass,
                        TermVocabulary<T> voc, boolean abbrevAsId, S lastTerm,
                        T classDefiningTermInstance) {
+
                T term = classDefiningTermInstance.readCsvLine(termClass, arrayedLine(csvLine), voc.getTermType(), terms, abbrevAsId);
                terms.put(term.getUuid(), term);
                if (voc.isInstanceOf(OrderedTermVocabulary.class) && term.isInstanceOf(OrderedTermBase.class)){
@@ -158,7 +159,6 @@ public class TermLoader implements ITermLoader {
                }
        }
 
-
        @Override
        public <T extends DefinedTermBase<T>,S extends OrderedTermBase<S>> Set<T> loadSingleTerms(VocabularyEnum vocType,
                        TermVocabulary<T> voc, Set<UUID> missingTerms) {
index c8873e2b71043e22a97821ed1a06f97402ebe722..7fec24de1be62fc44f9bc10fb4040057c7764e4a 100644 (file)
@@ -17,7 +17,8 @@ import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -42,7 +43,7 @@ import eu.etaxonomy.cdm.test.unit.EntityTestBase;
  */
 public class TaxonNameTest extends EntityTestBase {
 
-       private static final Logger logger = LogManager.getLogger(TaxonNameTest.class);
+       private static final Logger logger = LogManager.getLogger();
 
        private TaxonName nameBase1;
        private TaxonName nameBase2;
index ff9a0d96e79cdb63feb584ea539d5b71a72f57b2..b749541401b486d85bc78a221d6b13631a28311f 100644 (file)
@@ -24,7 +24,7 @@ import eu.etaxonomy.cdm.test.unit.EntityTestBase;
 public class OrderedTermBaseTest extends EntityTestBase {
 
        @SuppressWarnings("unused")
-       private static final Logger logger = LogManager.getLogger(OrderedTermBaseTest.class);
+       private static final Logger logger = LogManager.getLogger();
 
        private OrderedTermBase otb1;
        private OrderedTermBase otb2;
index 1cbf016be2b07597f3a2249b46fe01c1ae22192a..a02549735378e8a544168e959afaabd8349fb061 100644 (file)
@@ -14,7 +14,8 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import eu.etaxonomy.cdm.common.monitor.IProgressMonitor;
 import eu.etaxonomy.cdm.database.ICdmDataSource;
index 9d29d4b3d9394239406261c7e8ce3f6e9190a03f..7c0703469be8f0a8fe357cd5b395866b1c2215c3 100644 (file)
@@ -6,7 +6,6 @@
 * The contents of this file are subject to the Mozilla Public License Version 1.1
 * See LICENSE.TXT at the top of this package for the full license terms.
 */
-
 package eu.etaxonomy.cdm.persistence.dao.hibernate.term;
 
 import org.springframework.stereotype.Repository;
@@ -28,10 +27,7 @@ public class OrderedTermVocabularyDaoImpl
         extends CdmEntityDaoBase<OrderedTermVocabulary<OrderedTermBase<?>>>
         implements IOrderedTermVocabularyDao {
 
-       /**
-        * @param type
-        */
        public OrderedTermVocabularyDaoImpl() {
                super((Class)OrderedTermVocabulary.class);
        }
-}
+}
\ No newline at end of file
index 827d89203c9304128cfc82024b82cf1147b65063..76a532d442abf25eb3831773a7cc7682f853581e 100644 (file)
@@ -30,7 +30,6 @@ import eu.etaxonomy.cdm.model.location.NamedAreaType;
 import eu.etaxonomy.cdm.model.media.Media;
 import eu.etaxonomy.cdm.model.metadata.TermSearchField;
 import eu.etaxonomy.cdm.model.term.DefinedTermBase;
-import eu.etaxonomy.cdm.model.term.OrderedTermBase;
 import eu.etaxonomy.cdm.model.term.OrderedTermVocabulary;
 import eu.etaxonomy.cdm.model.term.Representation;
 import eu.etaxonomy.cdm.model.term.TermType;
@@ -44,8 +43,6 @@ public interface ITermService extends IIdentifiableEntityService<DefinedTermBase
 
     /**
      * Returns a term according to it's uri
-     * @param uri
-     * @return
      */
     public DefinedTermBase getByUri(URI uri);
 
index 8817d70cbd50c3f488fbb170c7e8784cf748b4d2..3e42d874bafb3ec59237554aaa3fc8e6082b9435 100644 (file)
@@ -12,7 +12,8 @@ import java.util.Collection;
 import java.util.HashSet;
 import java.util.Set;
 
-import org.apache.logging.log4j.LogManager;import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 
 import eu.etaxonomy.cdm.common.SetMap;
 import eu.etaxonomy.cdm.model.common.CdmBase;
@@ -25,7 +26,6 @@ import eu.etaxonomy.cdm.model.description.PresenceAbsenceTerm;
 import eu.etaxonomy.cdm.model.location.NamedArea;
 import eu.etaxonomy.cdm.model.location.NamedAreaLevel;
 import eu.etaxonomy.cdm.model.term.DefinedTermBase;
-import eu.etaxonomy.cdm.model.term.OrderedTermBase;
 import eu.etaxonomy.cdm.persistence.dao.term.IDefinedTermDao;
 
 /**
index c3c77cfa40fd31a5b73ba466141f3b1b8e2eaecf..487737f39a222120c46803c565529f8370c475d5 100644 (file)
@@ -78,7 +78,7 @@ import eu.etaxonomy.cdm.test.unitils.CleanSweepInsertLoadStrategy;
  */
 public class DistributionAggregationTest extends CdmTransactionalIntegrationTest {
 
-    private static Logger logger = LogManager.getLogger(DistributionAggregationTest.class);
+    private static Logger logger = LogManager.getLogger();
 
     private static final UUID T_LAPSANA_UUID = UUID.fromString("f65d47bd-4f49-4ab1-bc4a-bc4551eaa1a8");