#5859 avoiding pollution of the log file with stack traces
authorAndreas Kohlbecker <a.kohlbecker@bgbm.org>
Thu, 2 Jun 2016 15:25:52 +0000 (17:25 +0200)
committerAndreas Kohlbecker <a.kohlbecker@bgbm.org>
Thu, 2 Jun 2016 15:25:52 +0000 (17:25 +0200)
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/controller/BaseController.java
cdmlib-remote/src/main/java/eu/etaxonomy/cdm/remote/controller/HttpStatusMessage.java

index 6878abfc0e50a2251dd66ec8044910273106eeaa..cdda4b30dbb9e238052d71e8c0d237defb94b99d 100644 (file)
@@ -45,7 +45,6 @@ import eu.etaxonomy.cdm.model.common.CdmBase;
 import eu.etaxonomy.cdm.model.reference.INomenclaturalReference;
 import eu.etaxonomy.cdm.remote.controller.util.PagerParameters;
 import eu.etaxonomy.cdm.remote.editor.UUIDPropertyEditor;
-import eu.etaxonomy.cdm.remote.exception.NoRecordsMatchException;
 
 /**
  * based on org.cateproject.controller.common
@@ -285,7 +284,6 @@ public abstract class BaseController<T extends CdmBase, SERVICE extends IService
         CDM_BASE cdmBaseObject = service.load(uuid, pathProperties);
         if (cdmBaseObject == null) {
             HttpStatusMessage.UUID_NOT_FOUND.send(response);
-            throw new NoRecordsMatchException("No instance found for UUID " + uuid.toString());
         }
         return cdmBaseObject;
         }
index f69dd022271ae772f68433752a39c274ba11e520..a1184109f1dca3eef80fc7de5ef833596d4d0a97 100644 (file)
@@ -14,6 +14,7 @@ import java.io.IOException;
 import javax.servlet.http.HttpServletResponse;\r
 \r
 import org.apache.commons.lang.StringUtils;\r
+import org.apache.log4j.Logger;\r
 \r
 \r
 /**\r
@@ -23,6 +24,8 @@ import org.apache.commons.lang.StringUtils;
  */\r
 public class HttpStatusMessage {\r
 \r
+    public static final Logger logger = Logger.getLogger(HttpStatusMessage.class);\r
+\r
     public final static HttpStatusMessage UUID_MISSING = new HttpStatusMessage(HttpServletResponse.SC_BAD_REQUEST, "missing uuid parameter");\r
     public final static HttpStatusMessage UUID_INVALID = new HttpStatusMessage(HttpServletResponse.SC_BAD_REQUEST, "invalid uuid");\r
     public final static HttpStatusMessage UUID_NOT_FOUND = new HttpStatusMessage(HttpServletResponse.SC_NOT_FOUND, "uuid not found");\r
@@ -74,6 +77,7 @@ public class HttpStatusMessage {
 \r
 \r
     public void send(HttpServletResponse response) throws IOException{\r
+        logger.info("HTTP " + getStatusCode() + " : " +  getMessage());\r
         response.sendError(getStatusCode(), getMessage());\r
     }\r
 \r