ref #6405 tests for the CdmPermissionVoter

diff --git a/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/AbstractCdmPermissionVoterTest.java b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/AbstractCdmPermissionVoterTest.java
new file mode 100644 (file)
index 0000000..0a4dcab
--- /dev/null
+++ b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/AbstractCdmPermissionVoterTest.java
@@ -0,0 +1,48 @@
+/**
+* Copyright (C) 2017 EDIT
+* European Distributed Institute of Taxonomy
+* http://www.e-taxonomy.eu
+*
+* The contents of this file are subject to the Mozilla Public License Version 1.1
+* See LICENSE.TXT at the top of this package for the full license terms.
+*/
+package eu.etaxonomy.cdm.persistence.hibenate.permission;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import org.junit.Assert;
+import org.springframework.security.authentication.TestingAuthenticationToken;
+import org.springframework.security.core.Authentication;
+import org.springframework.security.core.GrantedAuthority;
+
+import eu.etaxonomy.cdm.model.common.User;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CdmAuthority;
+
+/**
+ * @author a.kohlbecker
+ * @date Feb 2, 2017
+ *
+ */
+abstract public class AbstractCdmPermissionVoterTest extends Assert {
+
+    /**
+     * @param e
+     * @return
+     */
+    protected Authentication authentication(CdmAuthority ... authorities) {
+
+        List<GrantedAuthority> ga = new ArrayList<>();
+
+        for(CdmAuthority a : authorities){
+            ga.add(a);
+        }
+
+        Authentication auth = new TestingAuthenticationToken(
+                User.NewInstance("Tester", "secret"),
+                null,
+                ga);
+        return auth;
+    }
+
+}

diff --git a/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionBaseVoterTest.java b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionBaseVoterTest.java
new file mode 100644 (file)
index 0000000..525cb93
--- /dev/null
+++ b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionBaseVoterTest.java
@@ -0,0 +1,136 @@
+/**
+* Copyright (C) 2017 EDIT
+* European Distributed Institute of Taxonomy
+* http://www.e-taxonomy.eu
+*
+* The contents of this file are subject to the Mozilla Public License Version 1.1
+* See LICENSE.TXT at the top of this package for the full license terms.
+*/
+package eu.etaxonomy.cdm.persistence.hibenate.permission;
+
+import java.util.Arrays;
+import java.util.EnumSet;
+
+import org.junit.Test;
+import org.springframework.security.access.AccessDecisionVoter;
+
+import eu.etaxonomy.cdm.model.description.TaxonDescription;
+import eu.etaxonomy.cdm.model.taxon.Taxon;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CRUD;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CdmAuthority;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CdmPermissionClass;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.voter.DescriptionBaseVoter;
+
+/**
+ * @author a.kohlbecker
+ * @date Feb 2, 2017
+ *
+ */
+public class DescriptionBaseVoterTest extends AbstractCdmPermissionVoterTest {
+
+    private DescriptionBaseVoter voter = new DescriptionBaseVoter();
+
+    @Test
+    public void test_U_C(){
+
+        int vote = voter.vote(
+                authentication(
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null),
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.CREATE), null)
+                        ),
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+    @Test
+    public void test_C_U(){
+        int vote = voter.vote(
+                authentication(
+                        // reverse order
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.CREATE), null),
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null)
+                        ),
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+
+    }
+
+    @Test
+    public void test_CU(){
+        int vote = voter.vote(
+                authentication(
+                        // combined
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+
+    }
+
+    @Test
+    public void test_UC(){
+        int vote = voter.vote(
+                authentication(
+                        // combined reverse
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE, CRUD.CREATE), null)
+                        ),
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.UPDATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+
+    }
+
+    /**
+     * For a not orphan TaxonDescription the voter must evaluate the CRUD properties
+     */
+    @Test
+    public void test_CU_DENIED(){
+
+        int vote = voter.vote(
+                authentication(
+                        // insufficient grants
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                // an not orphan TaxonDescription since it is associated with a taxon
+                TaxonDescription.NewInstance(Taxon.NewInstance(null, null)),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.DELETE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_DENIED, vote);
+    }
+
+    /**
+     * Deletion of orphan objects is always allowed and insufficient CRUD properties will not
+     * influence the result.
+     */
+    @Test
+    public void test_CU_ALLOW_orphaned(){
+        int vote = voter.vote(
+                authentication(
+                        // insufficient grants
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                // an orphan TaxonDescription which has no taxon
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.DELETE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+    /**
+     * If the classes do not match the voter will return the fallthrough vote which is ACCESS_DENIED.
+     */
+    @Test
+    public void test_CU_DENIED_nonMatchingClass(){
+        int vote = voter.vote(
+                authentication(
+                        // insufficient grants
+                        new CdmAuthority(CdmPermissionClass.TAXONBASE, null, EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                TaxonDescription.NewInstance(),
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONBASE, null, EnumSet.of(CRUD.DELETE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_DENIED, vote);
+    }
+
+
+}

diff --git a/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionElementVoterTest.java b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionElementVoterTest.java
new file mode 100644 (file)
index 0000000..92e3086
--- /dev/null
+++ b/cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibenate/permission/DescriptionElementVoterTest.java
@@ -0,0 +1,97 @@
+/**
+* Copyright (C) 2017 EDIT
+* European Distributed Institute of Taxonomy
+* http://www.e-taxonomy.eu
+*
+* The contents of this file are subject to the Mozilla Public License Version 1.1
+* See LICENSE.TXT at the top of this package for the full license terms.
+*/
+package eu.etaxonomy.cdm.persistence.hibenate.permission;
+
+import java.util.Arrays;
+import java.util.EnumSet;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.springframework.security.access.AccessDecisionVoter;
+
+import eu.etaxonomy.cdm.model.description.DescriptionElementBase;
+import eu.etaxonomy.cdm.model.description.Feature;
+import eu.etaxonomy.cdm.model.description.TextData;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CRUD;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CdmAuthority;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.CdmPermissionClass;
+import eu.etaxonomy.cdm.persistence.hibernate.permission.voter.DescriptionElementVoter;
+
+/**
+ * Most basic permission votes are tested via the {@link DescriptionBaseVoterTest}. The
+ * test in here are mainly focused on testing the {@link DescriptionElementVoter#furtherVotingDescisions}
+ * implementation.
+ *
+ * @author a.kohlbecker
+ * @since Feb 2, 2017
+ *
+ */
+public class DescriptionElementVoterTest extends AbstractCdmPermissionVoterTest {
+
+    private DescriptionElementVoter voter = new DescriptionElementVoter();
+
+    private DescriptionElementBase textDataEco = null;
+    private Feature ecology = Feature.NewInstance(null, "ecology", null);
+
+    @Before
+    public void setup() {
+        textDataEco = new TextData(ecology);
+    }
+
+    @Test
+    public void test_U_C_ecology(){
+
+        int vote = voter.vote(
+                authentication(
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.UPDATE), null),
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.CREATE), null)
+                        ),
+                textDataEco,
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, null, EnumSet.of(CRUD.CREATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+    @Test
+    public void test_C_U_ecology(){
+        int vote = voter.vote(
+                authentication(
+                        // reverse order
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.CREATE), null),
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.UPDATE), null)
+                        ),
+                textDataEco,
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, null, EnumSet.of(CRUD.CREATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+    @Test
+    public void test_CU_ecology(){
+        int vote = voter.vote(
+                authentication(
+                        // combined
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                textDataEco,
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, null, EnumSet.of(CRUD.CREATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+    @Test
+    public void test_UC_ecology(){
+        int vote = voter.vote(
+                authentication(
+                        // combined
+                        new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, ecology.getLabel(), EnumSet.of(CRUD.CREATE, CRUD.UPDATE), null)
+                        ),
+                textDataEco,
+                Arrays.asList(new CdmAuthority(CdmPermissionClass.DESCRIPTIONELEMENTBASE, null, EnumSet.of(CRUD.CREATE), null)));
+        assertEquals(AccessDecisionVoter.ACCESS_GRANTED, vote);
+    }
+
+}