cleanup
authorAndreas Müller <a.mueller@bgbm.org>
Sat, 21 May 2022 12:34:20 +0000 (14:34 +0200)
committerAndreas Müller <a.mueller@bgbm.org>
Sat, 21 May 2022 12:34:20 +0000 (14:34 +0200)
17 files changed:
cdmlib-commons/src/main/java/eu/etaxonomy/cdm/common/CdmUtils.java
cdmlib-model/src/main/java/eu/etaxonomy/cdm/compare/taxon/TaxonNodeNaturalComparator.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/database/update/v30_40/SchemaUpdater_31_33.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/persistence/dao/hibernate/taxon/TaxonNodeFilterDaoHibernateImpl.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/persistence/dto/MergeResult.java
cdmlib-persistence/src/main/java/eu/etaxonomy/cdm/persistence/hibernate/replace/impl/ReferringObjectMetadataFactoryImpl.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/common/AnnotationDaoTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/name/ConfigurableNameCacheStrategyGeneratorsTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/occurrence/OccurrenceDaoHibernateImplTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/statistics/StatisticsDaoHibernateImplTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/taxon/TaxonNodeFilterDaoHibernateImplTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/dao/hibernate/taxonGraph/TaxonGraphTest.java
cdmlib-persistence/src/test/java/eu/etaxonomy/cdm/persistence/hibernate/CdmPreDataChangeListenerTest.java
cdmlib-services/src/main/java/eu/etaxonomy/cdm/api/service/TaxonServiceImpl.java
cdmlib-services/src/test/java/eu/etaxonomy/cdm/api/service/EmailSendTest.java
cdmlib-services/src/test/java/eu/etaxonomy/cdm/api/service/HandlingCdmEntitiesTest.java
cdmlib-test/src/main/java/eu/etaxonomy/cdm/test/integration/CdmIntegrationTest.java

index d40cc29bbef20fad228b99ef7b927f61d80659b3..0e5dbb7d415c69f86cfdddc1cb23e983b6d11c8c 100644 (file)
@@ -369,16 +369,13 @@ public class CdmUtils {
     }
 
     /**
-     * Tests if two objects are equal or both null. Otherwise returns false
-     * @param obj1
-     * @param obj2
-     * @return
+     * Tests if two objects are equal or both null. Otherwise returns <code>false</code>.
      */
     public static boolean nullSafeEqual(Object obj1, Object obj2) {
         if (obj1 == null){
             return obj2 == null;
         }
-        return (obj1.equals(obj2));
+        return (obj1 == obj2) || (obj1.equals(obj2));
     }
 
     /**
index 0bdc85bf5ea4b3dc3b42a6ef4e91cedccb496319..1b6e2897eb7a490573aa180e6466d1622a02e649 100644 (file)
@@ -21,10 +21,6 @@ import eu.etaxonomy.cdm.model.taxon.TaxonNode;
  */
 public class TaxonNodeNaturalComparator implements Comparator<TaxonNode> {
 
-    public TaxonNodeNaturalComparator(){
-               super();
-       }
-
        @SuppressWarnings("null")
     @Override
        public int compare(TaxonNode node1, TaxonNode node2) {
@@ -56,10 +52,10 @@ public class TaxonNodeNaturalComparator implements Comparator<TaxonNode> {
                        return node1.getSortIndex().compareTo(node2.getSortIndex());
                }
                String lastEqualAncestorTreeIndex = "";
-               List<TaxonNode> ancestorAndNode= new ArrayList<>();
-               ancestorAndNode.add(node1);
-               ancestorAndNode.addAll(node1.getAncestorList());
-               java.util.Collections.sort(ancestorAndNode, new TreeIndexComparator());
+               List<TaxonNode> ancestorAndNode1= new ArrayList<>();
+               ancestorAndNode1.add(node1);
+               ancestorAndNode1.addAll(node1.getAncestorList());
+               java.util.Collections.sort(ancestorAndNode1, new TreeIndexComparator());
 
 
                List<TaxonNode> ancestorAndNode2= new ArrayList<>();
@@ -73,7 +69,7 @@ public class TaxonNodeNaturalComparator implements Comparator<TaxonNode> {
                                if (lastEqualAncestorTreeIndex != null){
                                        TaxonNode lastEqualTreeIndexAncestorNode1 = null;
                                        TaxonNode lastEqualTreeIndexAncestorNode2 = null;
-                                       for (TaxonNode next1 :ancestorAndNode){
+                                       for (TaxonNode next1 :ancestorAndNode1){
                                                if (next1.treeIndex().equals(lastEqualAncestorTreeIndex+"#"+splitNode1[i]+ "#") ){
                                                    lastEqualTreeIndexAncestorNode1 = next1;
                                                }
index 3acdb6d4d867a6bd67c1876545b5865553c3e92d..9f49bf8207e05705ec7c023a9dd49fa7057be0db 100644 (file)
@@ -107,7 +107,7 @@ public class SchemaUpdater_31_33 extends SchemaUpdaterBase {
                        throw new RuntimeException(
                                        "Required check for SpecimenOrObservationBase_Media");
                } else {
-                       logger.warn("CHECKS for inconsistent data not running !!!!");
+                       logger.info("CHECKS for inconsistent data not running !!!!");
                }
 
                List<ISchemaUpdaterStep> stepList = new ArrayList<>();
index 2d32d5a2421ae472b540810a50ddf6788688611c..33201c8e303938df47045610865df9de86e3ed36 100644 (file)
@@ -289,7 +289,6 @@ public class TaxonNodeFilterDaoHibernateImpl extends CdmEntityDaoBase<TaxonNode>
             String uuid = singleFilter.getUuid().toString();
             String op = isFirst ? "" : op2Hql(singleFilter.getOperator());
             result = String.format("(%s%s(tn.classification.uuid = '%s'))", result, op, uuid);
-            System.out.println(result);
             isFirst = false;
         }
         return result;
index 926c9ace72f292fd0f4c25bc2d447f23d5756018..4ef06deceececf7e0ae545f85497df877fba3cd4 100644 (file)
@@ -25,20 +25,15 @@ public class MergeResult<T extends ICdmBase> implements Serializable {
     private Set<T> newEntities;
 
 
+
     public MergeResult(T mergedEntity, Set<T> newEntities) {
         this.mergedEntity = mergedEntity;
         this.newEntities = newEntities;
     }
 
-    /**
-     * @return the mergedEntity
-     */
     public T getMergedEntity() {
         return mergedEntity;
     }
-    /**
-     * @param mergedEntity the mergedEntity to set
-     */
     public void setMergedEntity(T mergedEntity) {
         this.mergedEntity = mergedEntity;
     }
index e8fb7c9e2173cb9d311b6da1cdea25e303455d65..9e965ebbf21c7769762462f2d73751f3321435a1 100644 (file)
@@ -138,7 +138,7 @@ public class ReferringObjectMetadataFactoryImpl implements  ReferringObjectMetada
                                                                        }
                                                                }
                                                        }
-                                               }
+                        }
 
                                        } catch (ClassNotFoundException e) {
 
index 562e2fedd13de06469ca90c65c99107914c04b09..63e5d5581c74e0544925b8ceb9dba201c02fd251 100644 (file)
@@ -6,7 +6,6 @@
 * The contents of this file are subject to the Mozilla Public License Version 1.1
 * See LICENSE.TXT at the top of this package for the full license terms.
 */
-
 package eu.etaxonomy.cdm.persistence.dao.hibernate.common;
 
 import static org.junit.Assert.assertEquals;
@@ -116,8 +115,5 @@ public class AnnotationDaoTest extends CdmIntegrationTest {
        }
 
     @Override
-    public void createTestDataSet() throws FileNotFoundException {
-        // TODO Auto-generated method stub
-
-    }
+    public void createTestDataSet() throws FileNotFoundException {}
 }
index e6b913911a2882a3b7d3a78a87d247c27d86d963..6f2641798c6e951cf9e6ed5c6d3c2526249c391a 100644 (file)
@@ -6,7 +6,6 @@
 * The contents of this file are subject to the Mozilla Public License Version 1.1\r
 * See LICENSE.TXT at the top of this package for the full license terms.\r
 */\r
-\r
 package eu.etaxonomy.cdm.persistence.dao.hibernate.name;\r
 \r
 import static org.junit.Assert.assertEquals;\r
index d1f6095e0cc9d36c56e044778d96bf7e023e51ff..ecbf0e4ef56d9e21642a2c0958d4dcb6377f6da6 100644 (file)
@@ -1,3 +1,11 @@
+/**
+* Copyright (C) 2009 EDIT
+* European Distributed Institute of Taxonomy
+* http://www.e-taxonomy.eu
+*
+* The contents of this file are subject to the Mozilla Public License Version 1.1
+* See LICENSE.TXT at the top of this package for the full license terms.
+*/
 package eu.etaxonomy.cdm.persistence.dao.hibernate.occurrence;
 
 import java.io.FileNotFoundException;
@@ -5,10 +13,9 @@ import java.util.Collections;
 import java.util.List;
 import java.util.stream.Collectors;
 
+import org.apache.log4j.Logger;
 import org.h2.util.StringUtils;
 import org.junit.Assert;
-import org.junit.Before;
-import org.junit.BeforeClass;
 import org.junit.Test;
 import org.unitils.spring.annotation.SpringBeanByType;
 
@@ -25,17 +32,10 @@ import eu.etaxonomy.cdm.test.integration.CdmIntegrationTest;
 
 public class OccurrenceDaoHibernateImplTest  extends CdmIntegrationTest {
 
-       @SpringBeanByType
-       private IOccurrenceDao dao;
-
-
-       @BeforeClass
-       public static void setUpBeforeClass() throws Exception {
-       }
+    private static final Logger logger = Logger.getLogger(OccurrenceDaoHibernateImplTest.class);
 
-       @Before
-       public void setUp() throws Exception {
-       }
+    @SpringBeanByType
+       private IOccurrenceDao dao;
 
 //**************** TESTS ************************************************
 
@@ -44,21 +44,6 @@ public class OccurrenceDaoHibernateImplTest  extends CdmIntegrationTest {
                logger.warn("Not yet implemented");
        }
 
-       @Test
-       public void testOccurrenceDaoHibernateImpl() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testCountDerivationEvents() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testCountDeterminations() {
-               logger.warn("Not yet implemented");
-       }
-
     @Test
     public void testCountMedia() {
         MediaSpecimen unit = MediaSpecimen.NewInstance(SpecimenOrObservationType.Media);
@@ -113,41 +98,6 @@ public class OccurrenceDaoHibernateImplTest  extends CdmIntegrationTest {
         Assert.assertEquals(2, dao.countMedia(unit));
     }
 
-       @Test
-       public void testGetDerivationEvents() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testGetDeterminations() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testCountClassOfQextendsSpecimenOrObservationBaseTaxonBase() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testListClassOfQextendsSpecimenOrObservationBaseTaxonBaseIntegerIntegerListOfOrderHintListOfString() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testGetDerivedUnitUuidAndTitleCache() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testGetFieldUnitUuidAndTitleCache() {
-               logger.warn("Not yet implemented");
-       }
-
-       @Test
-       public void testListByAnyAssociation() {
-               logger.warn("Not yet implemented");
-       }
-
        @Test
        public void testSaveOriginalLabelData(){
                DerivedUnit unit = DerivedUnit.NewInstance(SpecimenOrObservationType.DerivedUnit);
index c8e683afa6bc4d4e273d07c129ce7e9f631dc984..ff36298f24f99866ccf451a34add276d36a2c6de 100644 (file)
@@ -560,15 +560,8 @@ public class StatisticsDaoHibernateImplTest
                }
                System.out.println();
                System.out.println("end!");
-
        }
 
-    /* (non-Javadoc)
-     * @see eu.etaxonomy.cdm.test.integration.CdmIntegrationTest#createTestData()
-     */
     @Override
-    public void createTestDataSet() throws FileNotFoundException {
-        // TODO Auto-generated method stub
-
-    }
+    public void createTestDataSet() throws FileNotFoundException {}
 }
index 2e20f80f2f2ef748fe09ed2ba90f9d23353c7f42..15285081f2c6ce0c4250e8e482acfc0e14073657 100644 (file)
@@ -1,6 +1,11 @@
 /**
- *
- */
+* Copyright (C) 2009 EDIT
+* European Distributed Institute of Taxonomy
+* http://www.e-taxonomy.eu
+*
+* The contents of this file are subject to the Mozilla Public License Version 1.1
+* See LICENSE.TXT at the top of this package for the full license terms.
+*/
 package eu.etaxonomy.cdm.persistence.dao.hibernate.taxon;
 
 import static org.junit.Assert.assertEquals;
@@ -40,7 +45,6 @@ import eu.etaxonomy.cdm.test.unitils.CleanSweepInsertLoadStrategy;
 /**
  * @author a.mueller
  * @since 2014/06/13
- *
  */
 public class TaxonNodeFilterDaoHibernateImplTest extends CdmTransactionalIntegrationTest {
 
@@ -56,7 +60,6 @@ public class TaxonNodeFilterDaoHibernateImplTest extends CdmTransactionalIntegra
     @SpringBeanByType
     private IDefinedTermDao termDao;
 
-
     private final UUID europeUuid = UUID.fromString("e860871c-3a14-4ef2-9367-bbd92586c95b");
     private final UUID germanyUuid = UUID.fromString("7b7c2db5-aa44-4302-bdec-6556fd74b0b9");
     private final UUID denmarkUuid = UUID.fromString("f818c97e-fd61-42fe-9d75-d433f8cb349c");
@@ -72,7 +75,6 @@ public class TaxonNodeFilterDaoHibernateImplTest extends CdmTransactionalIntegra
     private final UUID uuidNode5 = UUID.fromString("e01f56c7-0315-450b-a05b-881d21adf02b");
     private final UUID uuidNodeUnpublished = UUID.fromString("96888466-f40e-43ed-a17d-cdc62bdf0ff0");
 
-
     private Classification classification1;
     private TaxonNode node1;
     private TaxonNode node2;
@@ -141,8 +143,6 @@ public class TaxonNodeFilterDaoHibernateImplTest extends CdmTransactionalIntegra
         nodeUnpublished.setUuid(uuidNodeUnpublished);
         nodeUnpublished = taxonNodeDao.save(nodeUnpublished);
 
-
-
         //MergeResult result = taxonNodeDao.merge(node5, true);
         //node5 = (TaxonNode) result.getMergedEntity();
 
@@ -328,7 +328,6 @@ public class TaxonNodeFilterDaoHibernateImplTest extends CdmTransactionalIntegra
         listUuid = filterDao.listUuids(filter);
         Assert.assertEquals("All 3 children should be returned", 3, listUuid.size());
 
-
         filter = TaxonNodeFilter.NewSubtreeInstance(taxon1.getUuid());
         listUuid = filterDao.listUuids(filter);
         Assert.assertEquals("A NON subtree uuid should not return a result", 0, listUuid.size());
index a21b877f770c2a17df6229ef6763aef18ccf68cc..d4126d652120a075d5b275203812aafa540115b5 100644 (file)
@@ -88,13 +88,11 @@ public class TaxonGraphTest extends CdmTransactionalIntegrationTest {
 
     public AbstractHibernateTaxonGraphProcessor taxonGraphProcessor(){
         AbstractHibernateTaxonGraphProcessor processor = new AbstractHibernateTaxonGraphProcessor() {
-
             @Override
             public Session getSession() {
                 return nameDao.getSession();
             }
         };
-
         return processor;
     }
 
index 997997cd3e4ec5950c30e64041ddf537c5cc7a00..3debca0f0045e8850bb8a8361a84ae9e4033137c 100644 (file)
@@ -9,31 +9,17 @@
 package eu.etaxonomy.cdm.persistence.hibernate;
 
 import org.junit.Before;
-import org.junit.BeforeClass;
 import org.junit.Test;
 
 import eu.etaxonomy.cdm.model.occurrence.DerivedUnit;
 import eu.etaxonomy.cdm.model.occurrence.SpecimenOrObservationType;
 
-
 /**
  * @author a.mueller
  * @since 04.10.2016
- *
  */
 public class CdmPreDataChangeListenerTest /*extends CdmIntegrationTest*/ {
 
-
-    /**
-     * @throws java.lang.Exception
-     */
-    @BeforeClass
-    public static void setUpBeforeClass() throws Exception {
-    }
-
-    /**
-     * @throws java.lang.Exception
-     */
     @Before
     public void setUp() throws Exception {
     }
@@ -47,9 +33,6 @@ public class CdmPreDataChangeListenerTest /*extends CdmIntegrationTest*/ {
         System.out.println(cache);
     }
 
-//    /**
-//     * {@inheritDoc}
-//     */
 //    @Override
 //    public void createTestDataSet() throws FileNotFoundException {}
 
index 861a67d14c76c6a74de62eb564bbeea31ef2c488..09ea57c2642a491ad89657ffad6c62ddf2425b4a 100644 (file)
@@ -280,29 +280,29 @@ public class TaxonServiceImpl
                return result;
     }
 
-    private UpdateResult swapSynonymAndAcceptedTaxonNewUuid(Synonym synonym, Taxon acceptedTaxon, boolean setNameInSource, SecReferenceHandlingSwapEnum secHandling, Reference newSecAcc, Reference newSecSyn){
+    private UpdateResult swapSynonymAndAcceptedTaxonNewUuid(Synonym oldSynonym, Taxon oldAcceptedTaxon, boolean setNameInSource, SecReferenceHandlingSwapEnum secHandling, Reference newSecAcc, Reference newSecSyn){
         UpdateResult result = new UpdateResult();
-        acceptedTaxon.removeSynonym(synonym);
-        TaxonName synonymName = synonym.getName();
-        TaxonName taxonName = HibernateProxyHelper.deproxy(acceptedTaxon.getName());
-        String oldTaxonTitleCache = acceptedTaxon.getTitleCache();
+        oldAcceptedTaxon.removeSynonym(oldSynonym);
+        TaxonName synonymName = oldSynonym.getName();
+        TaxonName taxonName = HibernateProxyHelper.deproxy(oldAcceptedTaxon.getName());
+        String oldTaxonTitleCache = oldAcceptedTaxon.getTitleCache();
 
         boolean sameHomotypicGroup = synonymName.getHomotypicalGroup().equals(taxonName.getHomotypicalGroup());
-        synonymName.removeTaxonBase(synonym);
+        synonymName.removeTaxonBase(oldSynonym);
 
         List<Synonym> synonyms = new ArrayList<>();
-        for (Synonym syn: acceptedTaxon.getSynonyms()){
+        for (Synonym syn: oldAcceptedTaxon.getSynonyms()){
             syn = HibernateProxyHelper.deproxy(syn, Synonym.class);
             synonyms.add(syn);
         }
         for (Synonym syn: synonyms){
-            acceptedTaxon.removeSynonym(syn);
+            oldAcceptedTaxon.removeSynonym(syn);
         }
-        Taxon newTaxon = acceptedTaxon.clone(true, true, false, true);
+        Taxon newTaxon = oldAcceptedTaxon.clone(true, true, false, true);
         newTaxon.setSec(newSecAcc);
 
         //move descriptions
-        Set<TaxonDescription> descriptionsToCopy = new HashSet<>(acceptedTaxon.getDescriptions());
+        Set<TaxonDescription> descriptionsToCopy = new HashSet<>(oldAcceptedTaxon.getDescriptions());
         for (TaxonDescription description: descriptionsToCopy){
             newTaxon.addDescription(description);
         }
@@ -311,7 +311,7 @@ public class TaxonServiceImpl
 
         newTaxon.setName(synonymName);
 
-        newTaxon.setPublish(synonym.isPublish());
+        newTaxon.setPublish(oldSynonym.isPublish());
         for (Synonym syn: synonyms){
             if (!syn.getName().equals(newTaxon.getName())){
                 newTaxon.addSynonym(syn, syn.getType());
@@ -324,14 +324,14 @@ public class TaxonServiceImpl
             newTaxon.removeTaxonRelation(taxonRelationship);
         }
 
-        for(TaxonRelationship taxonRelationship : acceptedTaxon.getTaxonRelations()){
+        for(TaxonRelationship taxonRelationship : oldAcceptedTaxon.getTaxonRelations()){
             Taxon fromTaxon = HibernateProxyHelper.deproxy(taxonRelationship.getFromTaxon());
             Taxon toTaxon = HibernateProxyHelper.deproxy(taxonRelationship.getToTaxon());
-            if (fromTaxon == acceptedTaxon){
+            if (fromTaxon == oldAcceptedTaxon){
                 newTaxon.addTaxonRelation(taxonRelationship.getToTaxon(), taxonRelationship.getType(),
                         taxonRelationship.getCitation(), taxonRelationship.getCitationMicroReference());
 
-            }else if(toTaxon == acceptedTaxon){
+            }else if(toTaxon == oldAcceptedTaxon){
                fromTaxon.addTaxonRelation(newTaxon, taxonRelationship.getType(),
                         taxonRelationship.getCitation(), taxonRelationship.getCitationMicroReference());
                saveOrUpdate(fromTaxon);
@@ -348,11 +348,11 @@ public class TaxonServiceImpl
         }
 
         //taxon nodes
-        List<TaxonNode> nodes = new ArrayList<>(acceptedTaxon.getTaxonNodes());
+        List<TaxonNode> nodes = new ArrayList<>(oldAcceptedTaxon.getTaxonNodes());
         for (TaxonNode node: nodes){
             node = HibernateProxyHelper.deproxy(node);
             TaxonNode parent = node.getParent();
-            acceptedTaxon.removeTaxonNode(node);
+            oldAcceptedTaxon.removeTaxonNode(node);
             node.setTaxon(newTaxon);
             if (parent != null){
                 parent.addChildNode(node, null, null);
@@ -360,9 +360,9 @@ public class TaxonServiceImpl
         }
 
         //synonym
-        Synonym newSynonym = synonym.clone();
+        Synonym newSynonym = oldSynonym.clone();
         newSynonym.setName(taxonName);
-        newSynonym.setPublish(acceptedTaxon.isPublish());
+        newSynonym.setPublish(oldAcceptedTaxon.isPublish());
         newSynonym.setSec(newSecSyn);
         if (sameHomotypicGroup){
             newTaxon.addSynonym(newSynonym, SynonymType.HOMOTYPIC_SYNONYM_OF());
@@ -377,10 +377,10 @@ public class TaxonServiceImpl
         confSyn.setDeleteNameIfPossible(false);
         result.setCdmEntity(newTaxon);
 
-        DeleteResult deleteResult = deleteTaxon(acceptedTaxon.getUuid(), conf, null);
-        if (synonym.isPersited()){
-            synonym.setSecSource(null);
-            deleteResult.includeResult(deleteSynonym(synonym.getUuid(), confSyn));
+        DeleteResult deleteResult = deleteTaxon(oldAcceptedTaxon.getUuid(), conf, null);
+        if (oldSynonym.isPersited()){
+            oldSynonym.setSecSource(null);
+            deleteResult.includeResult(deleteSynonym(oldSynonym.getUuid(), confSyn));
         }
         result.includeResult(deleteResult);
 
index dd2f8e0e603a2a9f40dc3fc3444200e0c14cba0a..5327a69ed73697cb259219a7c0b2198b55a03405 100644 (file)
@@ -18,6 +18,7 @@ import java.util.Objects;
 import javax.mail.MessagingException;
 import javax.mail.internet.MimeMessage;
 
+import org.apache.log4j.Logger;
 import org.junit.Test;
 import org.springframework.core.env.Environment;
 import org.springframework.mail.SimpleMailMessage;
@@ -32,6 +33,7 @@ import eu.etaxonomy.cdm.test.integration.CdmIntegrationTest;
 
 public class EmailSendTest extends CdmIntegrationTest {
 
+    private static final Logger logger = Logger.getLogger(EmailSendTest.class);
 
     private static final String SUBJECT = "eu.etaxonomy.cdm.test.function.EmailSendTest";
 
@@ -104,8 +106,6 @@ public class EmailSendTest extends CdmIntegrationTest {
     }
 
     @Override
-    public void createTestDataSet() throws FileNotFoundException {
-        // no data needed
-    }
+    public void createTestDataSet() throws FileNotFoundException {}
 
 }
index df4d6051fad28fbcba77fed3a2eec4b8935bc746..3f997666fad3c3973bbf02bacca6340fbe2c24c6 100644 (file)
@@ -15,7 +15,6 @@ import java.util.UUID;
 import org.apache.log4j.Logger;
 import org.hibernate.LazyInitializationException;
 import org.junit.Assert;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.unitils.database.annotations.Transactional;
 import org.unitils.database.util.TransactionMode;
@@ -80,8 +79,6 @@ public class HandlingCdmEntitiesTest extends CdmIntegrationTest {
     };
 
     @Override
-    @Ignore
-    @Test
     @Transactional(TransactionMode.DISABLED)
     public final void createTestDataSet() {
         Team combAuthor = Team.NewTitledInstance("Avengers", "Avengers");
index bdc1fa3b57419ec7664310036092e83576eec953..2d7c6c276f4fc1c6e58b05528566d03d7f2dc134 100644 (file)
@@ -75,7 +75,7 @@ import eu.etaxonomy.cdm.test.unitils.FlatFullXmlWriter;
 @HibernateSessionFactory({"/eu/etaxonomy/cdm/hibernate.cfg.xml", "/eu/etaxonomy/cdm/hibernate-test.cfg.xml"})
 public abstract class CdmIntegrationTest extends UnitilsJUnit4 {
 
-    protected static final Logger logger = Logger.getLogger(CdmIntegrationTest.class);
+    private static final Logger logger = Logger.getLogger(CdmIntegrationTest.class);
 
     private static final String PROPERTY_H2_SERVER = "h2Server";
     private static final String H2_SERVER_RUNNING = "h2ServerIsRunning";