Project

General

Profile

« Previous | Next » 

Revision e3ec8207

Added by Patrick Plitzner about 6 years ago

ref #7268 Fix potential NPE

View differences:

eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/menu/AbstractMenuPreferences.java
233 233
		tableViewer.setAllChecked(true);
234 234
	}
235 235

  
236
	public CheckboxTableViewer getTableViewer() {
237
		return tableViewer;
238
	}
239

  
240 236
	/** {@inheritDoc} */
241 237
	@Override
242 238
	public boolean performOk() {
......
250 246

  
251 247
		getConversationHolder().commit(true);
252 248

  
253
		List<T> preferredTerms = new ArrayList<T>();
254
		for (Object element : getTableViewer().getCheckedElements()){
255
			preferredTerms.add((T) element);
256
		}
257

  
258
		CdmStore.getTermManager().setPreferredTerms(preferredTerms, getTerms());
249
		if(tableViewer!=null){
250
		    List<T> preferredTerms = new ArrayList<T>();
251
		    for (Object element : tableViewer.getCheckedElements()){
252
		        preferredTerms.add((T) element);
253
		    }
259 254

  
260
		refresh(getTerms());
255
		    CdmStore.getTermManager().setPreferredTerms(preferredTerms, getTerms());
261 256

  
262
		PreferencesUtil.firePreferencesChanged(this.getClass());
257
		    refresh(getTerms());
263 258

  
259
		    PreferencesUtil.firePreferencesChanged(this.getClass());
260
		}
264 261

  
265 262
		return super.performOk();
266 263
	}
eu.etaxonomy.taxeditor.store/src/main/java/eu/etaxonomy/taxeditor/preference/menu/NameRelationshipTypeMenuPreferences.java
46 46
	@Override
47 47
	public Control createContents(Composite parent) {
48 48
		Control container = super.createContents(parent);
49
		getTableViewer().setLabelProvider(new NameRelationLabelProvider());
49
		tableViewer.setLabelProvider(new NameRelationLabelProvider());
50 50
		return container;
51 51
	}
52 52

  

Also available in: Unified diff