1
|
/**
|
2
|
* Copyright (C) 2007 EDIT
|
3
|
* European Distributed Institute of Taxonomy
|
4
|
* http://www.e-taxonomy.eu
|
5
|
*
|
6
|
* The contents of this file are subject to the Mozilla Public License Version 1.1
|
7
|
* See LICENSE.TXT at the top of this package for the full license terms.
|
8
|
*/
|
9
|
package eu.etaxonomy.cdm.model.taxon;
|
10
|
|
11
|
import java.util.ArrayList;
|
12
|
import java.util.Calendar;
|
13
|
import java.util.Collections;
|
14
|
import java.util.List;
|
15
|
import java.util.UUID;
|
16
|
|
17
|
import org.apache.log4j.Logger;
|
18
|
import org.junit.Assert;
|
19
|
import org.junit.Before;
|
20
|
import org.junit.Test;
|
21
|
|
22
|
import eu.etaxonomy.cdm.model.common.VerbatimTimePeriod;
|
23
|
import eu.etaxonomy.cdm.model.name.HomotypicalGroup;
|
24
|
import eu.etaxonomy.cdm.model.name.INonViralName;
|
25
|
import eu.etaxonomy.cdm.model.name.NomenclaturalStatus;
|
26
|
import eu.etaxonomy.cdm.model.name.NomenclaturalStatusType;
|
27
|
import eu.etaxonomy.cdm.model.name.Rank;
|
28
|
import eu.etaxonomy.cdm.model.name.TaxonName;
|
29
|
import eu.etaxonomy.cdm.model.name.TaxonNameFactory;
|
30
|
//import eu.etaxonomy.cdm.model.reference.Book;
|
31
|
import eu.etaxonomy.cdm.model.reference.Reference;
|
32
|
import eu.etaxonomy.cdm.model.reference.ReferenceFactory;
|
33
|
import eu.etaxonomy.cdm.test.unit.EntityTestBase;
|
34
|
|
35
|
/**
|
36
|
* @author a.mueller
|
37
|
* @since 04.03.2016
|
38
|
*/
|
39
|
public class HomotypicGroupTaxonComparatorTest extends EntityTestBase {
|
40
|
|
41
|
@SuppressWarnings("unused")
|
42
|
private static final Logger logger = Logger.getLogger(HomotypicGroupTaxonComparatorTest.class);
|
43
|
|
44
|
private Reference sec;
|
45
|
private Reference ref1;
|
46
|
private Reference ref2;
|
47
|
private Reference ref3;
|
48
|
private Calendar cal1;
|
49
|
private Calendar cal2;
|
50
|
private Calendar cal3;
|
51
|
private TaxonName botName1;
|
52
|
private TaxonName botName2;
|
53
|
private TaxonName botName3;
|
54
|
private TaxonName botName4;
|
55
|
private TaxonName botName5;
|
56
|
|
57
|
private List<TaxonBase<?>> list;
|
58
|
|
59
|
private Taxon taxon1;
|
60
|
private Synonym synonym2;
|
61
|
private Synonym synonym3;
|
62
|
|
63
|
@Before
|
64
|
public void setUp() throws Exception {
|
65
|
sec = ReferenceFactory.newBook();
|
66
|
|
67
|
ref1 = ReferenceFactory.newBook();
|
68
|
ref2 = ReferenceFactory.newBook();
|
69
|
ref3 = ReferenceFactory.newBook();
|
70
|
cal1 = Calendar.getInstance();
|
71
|
cal2 = Calendar.getInstance();
|
72
|
cal3 = Calendar.getInstance();
|
73
|
cal1.set(1856, 3, 2);
|
74
|
cal2.set(1943, 3, 2);
|
75
|
cal3.set(1945, 3, 2);
|
76
|
|
77
|
ref1.setDatePublished(VerbatimTimePeriod.NewVerbatimInstance(cal1));
|
78
|
ref2.setDatePublished(VerbatimTimePeriod.NewVerbatimInstance(cal2));
|
79
|
ref3.setDatePublished(VerbatimTimePeriod.NewVerbatimInstance(cal3));
|
80
|
|
81
|
botName1 = TaxonNameFactory.NewBotanicalInstance(Rank.SPECIES());
|
82
|
botName2 = TaxonNameFactory.NewBotanicalInstance(Rank.SPECIES());
|
83
|
botName3 = TaxonNameFactory.NewBotanicalInstance(Rank.SPECIES());
|
84
|
botName4 = TaxonNameFactory.NewBotanicalInstance(Rank.SPECIES());
|
85
|
botName5 = TaxonNameFactory.NewBotanicalInstance(Rank.SPECIES());
|
86
|
|
87
|
setNameParts(botName1, "Aaa", "aaa");
|
88
|
setNameParts(botName2, "Bbb", "bbb");
|
89
|
setNameParts(botName3, "Ccc", "ccc");
|
90
|
setNameParts(botName4, "Ddd", "ddd");
|
91
|
setNameParts(botName5, "Eee", "eee");
|
92
|
|
93
|
// zooName1.setPublicationYear(1823);
|
94
|
|
95
|
list = new ArrayList<>();
|
96
|
|
97
|
taxon1 = Taxon.NewInstance(botName1, sec);
|
98
|
}
|
99
|
|
100
|
private void setNameParts(INonViralName name, String genus, String speciesEpi) {
|
101
|
name.setGenusOrUninomial(genus);
|
102
|
name.setSpecificEpithet(speciesEpi);
|
103
|
name.getTitleCache();
|
104
|
}
|
105
|
|
106
|
/******************** TESTS *****************************************************/
|
107
|
|
108
|
@Test
|
109
|
public void testCompare_BasionymGroupsTogether() {
|
110
|
//2 basionym groups
|
111
|
|
112
|
HomotypicalGroup homotypicalGroup = botName2.getHomotypicalGroup();
|
113
|
taxon1.addHeterotypicSynonymName(botName3);
|
114
|
taxon1.addHeterotypicSynonymName(botName5, null, null, homotypicalGroup);
|
115
|
botName3.addBasionym(botName5);
|
116
|
|
117
|
synonym2 = taxon1.addHeterotypicSynonymName(botName2);
|
118
|
taxon1.addHeterotypicSynonymName(botName4, null, null, homotypicalGroup);
|
119
|
botName2.addBasionym(botName4);
|
120
|
|
121
|
|
122
|
list.addAll(taxon1.getSynonyms());
|
123
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
124
|
|
125
|
Assert.assertEquals("basionym for first group should come first", botName4, list.get(0).getName());
|
126
|
Assert.assertEquals(botName2, list.get(1).getName());
|
127
|
Assert.assertEquals(botName5, list.get(2).getName());
|
128
|
Assert.assertEquals(botName3, list.get(3).getName());
|
129
|
|
130
|
//add replaced synonym relation between basionyms
|
131
|
botName4.addReplacedSynonym(botName5, null, null, null, null);
|
132
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
133
|
Assert.assertEquals("basionym of second group should come first now as it is the replaced synonym",
|
134
|
botName5, list.get(0).getName());
|
135
|
Assert.assertEquals(botName3, list.get(1).getName());
|
136
|
Assert.assertEquals("replacement name should come after replaced synonym but first in basionym group",
|
137
|
botName4, list.get(2).getName());
|
138
|
Assert.assertEquals(botName2, list.get(3).getName());
|
139
|
|
140
|
//set a name as first name
|
141
|
Collections.sort(list, new HomotypicGroupTaxonComparator(synonym2));
|
142
|
|
143
|
Assert.assertEquals("name2 should come first now",
|
144
|
botName2, list.get(0).getName());
|
145
|
Assert.assertEquals("name2 should be followed by its basionym", botName4, list.get(1).getName());
|
146
|
Assert.assertEquals("other basionym group should come later but with basionym first",
|
147
|
botName5, list.get(2).getName());
|
148
|
Assert.assertEquals(botName3, list.get(3).getName());
|
149
|
}
|
150
|
|
151
|
@Test
|
152
|
public void testCompare_BasionymGroupsSeparated() {
|
153
|
|
154
|
//2 basionym groups in 2 homotypic groups
|
155
|
synonym3 = taxon1.addHeterotypicSynonymName(botName3);
|
156
|
taxon1.addHeterotypicSynonymName(botName5);
|
157
|
botName3.addBasionym(botName5); //also merges homotypic groups
|
158
|
|
159
|
taxon1.addHeterotypicSynonymName(botName2);
|
160
|
taxon1.addHeterotypicSynonymName(botName4);
|
161
|
botName2.addBasionym(botName4);
|
162
|
|
163
|
list.addAll(taxon1.getSynonyms());
|
164
|
|
165
|
UUID uuidFirst = UUID.fromString("000000972-d164-4cb5-9a1e-d6216cc858f6");
|
166
|
UUID uuidSecond = UUID.fromString("ffffff972-d164-4cb5-9a1e-d6216cc858f6");
|
167
|
Assert.assertTrue(uuidFirst.toString().compareTo(uuidSecond.toString())<-1);
|
168
|
|
169
|
botName4.getHomotypicalGroup().setUuid(uuidFirst);
|
170
|
botName5.getHomotypicalGroup().setUuid(uuidSecond);
|
171
|
|
172
|
//start test
|
173
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
174
|
|
175
|
Assert.assertEquals("basionym for first group should come first", botName4, list.get(0).getName());
|
176
|
Assert.assertEquals(botName2, list.get(1).getName());
|
177
|
Assert.assertEquals(botName5, list.get(2).getName());
|
178
|
Assert.assertEquals(botName3, list.get(3).getName());
|
179
|
|
180
|
//set a name as first name
|
181
|
//TODO
|
182
|
//first taxon in group should have an impact only for the homotypic group to which it belongs
|
183
|
//but this is still under discussion and may change in future
|
184
|
Collections.sort(list, new HomotypicGroupTaxonComparator(synonym3));
|
185
|
|
186
|
Assert.assertEquals(botName4, list.get(0).getName());
|
187
|
Assert.assertEquals(botName2, list.get(1).getName());
|
188
|
Assert.assertEquals(botName3, list.get(2).getName());
|
189
|
Assert.assertEquals(botName5, list.get(3).getName());
|
190
|
}
|
191
|
|
192
|
@Test
|
193
|
public void testCompare_BasionymGroupsSomeWithYears() {
|
194
|
|
195
|
//2 basionym groups, 1 new combination with year (botName2) and 1 basionym with year (botName5)
|
196
|
//The later should come first according to the rules, though alphabetically being
|
197
|
//basionym botName4
|
198
|
|
199
|
botName2.setNomenclaturalReference(ref2);
|
200
|
botName5.setNomenclaturalReference(ref3);
|
201
|
|
202
|
HomotypicalGroup homotypicalGroup = botName2.getHomotypicalGroup();
|
203
|
taxon1.addHeterotypicSynonymName(botName3);
|
204
|
taxon1.addHeterotypicSynonymName(botName5, null, null, homotypicalGroup);
|
205
|
botName3.addBasionym(botName5);
|
206
|
|
207
|
synonym2 = taxon1.addHeterotypicSynonymName(botName2);
|
208
|
taxon1.addHeterotypicSynonymName(botName4, null, null, homotypicalGroup);
|
209
|
botName2.addBasionym(botName4);
|
210
|
|
211
|
list.addAll(taxon1.getSynonyms());
|
212
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
213
|
|
214
|
Assert.assertEquals("basionym with date should comes first", botName5, list.get(0).getName());
|
215
|
Assert.assertEquals(botName3, list.get(1).getName());
|
216
|
Assert.assertEquals(botName4, list.get(2).getName());
|
217
|
Assert.assertEquals(botName2, list.get(3).getName());
|
218
|
|
219
|
//even with nom. illeg. the name with date should come first
|
220
|
NomenclaturalStatus illegStatus = NomenclaturalStatus.NewInstance(NomenclaturalStatusType.ILLEGITIMATE());
|
221
|
botName5.addStatus(illegStatus);
|
222
|
|
223
|
Assert.assertEquals("basionym with date should comes first", botName5, list.get(0).getName());
|
224
|
Assert.assertEquals(botName3, list.get(1).getName());
|
225
|
Assert.assertEquals(botName4, list.get(2).getName());
|
226
|
Assert.assertEquals(botName2, list.get(3).getName());
|
227
|
|
228
|
//add replaced synonym relation between basionyms
|
229
|
botName5.addReplacedSynonym(botName4, null, null, null, null);
|
230
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
231
|
Assert.assertEquals("basionym of second group should come first now as it is the replaced synonym",
|
232
|
botName4, list.get(0).getName());
|
233
|
Assert.assertEquals(botName2, list.get(1).getName());
|
234
|
Assert.assertEquals("replacement name should come after replaced synonym but first in basionym group",
|
235
|
botName5, list.get(2).getName());
|
236
|
Assert.assertEquals(botName3, list.get(3).getName());
|
237
|
}
|
238
|
|
239
|
@Test
|
240
|
public void testCompare_BasionymGroupsWithRanks1() {
|
241
|
|
242
|
botName2.setRank(Rank.VARIETY());
|
243
|
botName2.setInfraSpecificEpithet("varbbbb");
|
244
|
|
245
|
botName3.setRank(Rank.VARIETY());
|
246
|
botName3.setInfraSpecificEpithet("subspccc");
|
247
|
|
248
|
botName4.setRank(Rank.SUBSPECIES());
|
249
|
botName4.setInfraSpecificEpithet("subspddd");
|
250
|
|
251
|
|
252
|
HomotypicalGroup homotypicalGroup = botName2.getHomotypicalGroup();
|
253
|
taxon1.addHeterotypicSynonymName(botName3);
|
254
|
taxon1.addHeterotypicSynonymName(botName5, null, null, homotypicalGroup);
|
255
|
botName3.addBasionym(botName5);
|
256
|
|
257
|
synonym2 = taxon1.addHeterotypicSynonymName(botName2);
|
258
|
taxon1.addHeterotypicSynonymName(botName4, null, null, homotypicalGroup);
|
259
|
botName2.addBasionym(botName4);
|
260
|
|
261
|
list.addAll(taxon1.getSynonyms());
|
262
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
263
|
|
264
|
Assert.assertEquals("basionym with rank species should comes first", botName5, list.get(0).getName());
|
265
|
Assert.assertEquals(botName3, list.get(1).getName());
|
266
|
Assert.assertEquals(botName4, list.get(2).getName());
|
267
|
Assert.assertEquals(botName2, list.get(3).getName());
|
268
|
|
269
|
//add replaced synonym relation between basionyms
|
270
|
botName5.addReplacedSynonym(botName4, null, null, null, null);
|
271
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
272
|
Assert.assertEquals("basionym of second group should come first now as it is the replaced synonym",
|
273
|
botName4, list.get(0).getName());
|
274
|
Assert.assertEquals(botName2, list.get(1).getName());
|
275
|
Assert.assertEquals("replacement name should come after replaced synonym but first in basionym group",
|
276
|
botName5, list.get(2).getName());
|
277
|
Assert.assertEquals(botName3, list.get(3).getName());
|
278
|
}
|
279
|
|
280
|
@Test
|
281
|
public void testCompare_BasionymGroupsWithRanks2() {
|
282
|
|
283
|
botName2.setRank(Rank.VARIETY());
|
284
|
botName2.setInfraSpecificEpithet("varbbbb");
|
285
|
|
286
|
botName3.setRank(Rank.VARIETY());
|
287
|
botName3.setInfraSpecificEpithet("subspccc");
|
288
|
|
289
|
botName4.setRank(Rank.SUBSPECIES());
|
290
|
botName4.setInfraSpecificEpithet("subspddd");
|
291
|
|
292
|
botName5.setRank(Rank.VARIETY());
|
293
|
botName5.setInfraSpecificEpithet("vareee");
|
294
|
|
295
|
HomotypicalGroup homotypicalGroup = botName2.getHomotypicalGroup();
|
296
|
taxon1.addHeterotypicSynonymName(botName3);
|
297
|
taxon1.addHeterotypicSynonymName(botName5, null, null, homotypicalGroup);
|
298
|
botName3.addBasionym(botName5);
|
299
|
|
300
|
synonym2 = taxon1.addHeterotypicSynonymName(botName2);
|
301
|
taxon1.addHeterotypicSynonymName(botName4, null, null, homotypicalGroup);
|
302
|
botName2.addBasionym(botName5);
|
303
|
botName4.addBasionym(botName5);
|
304
|
|
305
|
list.addAll(taxon1.getSynonyms());
|
306
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
307
|
|
308
|
Assert.assertEquals("basionym should comes first", botName5, list.get(0).getName());
|
309
|
Assert.assertEquals("subspecies should come next", botName4, list.get(1).getName());
|
310
|
Assert.assertEquals("variety with b should come next", botName2, list.get(2).getName());
|
311
|
Assert.assertEquals("variety with c should come last", botName3, list.get(3).getName());
|
312
|
}
|
313
|
|
314
|
@Test
|
315
|
public void testCompare_BasionymGroupsWithNomIlleg() {
|
316
|
NomenclaturalStatus illegStatus = NomenclaturalStatus.NewInstance(NomenclaturalStatusType.ILLEGITIMATE());
|
317
|
botName4.addStatus(illegStatus);
|
318
|
|
319
|
//2 basionym groups
|
320
|
|
321
|
HomotypicalGroup homotypicalGroup = botName2.getHomotypicalGroup();
|
322
|
taxon1.addHeterotypicSynonymName(botName3);
|
323
|
taxon1.addHeterotypicSynonymName(botName5, null, null, homotypicalGroup);
|
324
|
botName3.addBasionym(botName5);
|
325
|
|
326
|
synonym2 = taxon1.addHeterotypicSynonymName(botName2);
|
327
|
taxon1.addHeterotypicSynonymName(botName4, null, null, homotypicalGroup);
|
328
|
// botName2.addBasionym(botName4);
|
329
|
|
330
|
list.addAll(taxon1.getSynonyms());
|
331
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
332
|
|
333
|
Assert.assertEquals("basionym for non nom. illeg. group should come first", botName2, list.get(0).getName());
|
334
|
Assert.assertEquals(botName5, list.get(1).getName());
|
335
|
Assert.assertEquals(botName3, list.get(2).getName());
|
336
|
Assert.assertEquals("Nom illeg should come last", botName4, list.get(3).getName());
|
337
|
|
338
|
//name having a nom. illeg. as basionym should stay in its basionym group
|
339
|
//NOTE: this is dirty data as nom. illeg. is not allowed as basionym by the code
|
340
|
botName2.addBasionym(botName4);
|
341
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
342
|
|
343
|
Assert.assertEquals("basionym for non nom. illeg. group should come first", botName5, list.get(0).getName());
|
344
|
Assert.assertEquals(botName3, list.get(1).getName());
|
345
|
Assert.assertEquals("Nom illeg basionym group should come last", botName4, list.get(2).getName());
|
346
|
Assert.assertEquals("Names with nom. illeg. as basionym should stay in basionym group", botName2, list.get(3).getName());
|
347
|
|
348
|
//non basionym nom. illeg. should not change the order
|
349
|
botName4.removeStatus(illegStatus);
|
350
|
botName2.addStatus(illegStatus);
|
351
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
352
|
|
353
|
Assert.assertEquals("basionym for non nom. illeg. group should come first", botName4, list.get(0).getName());
|
354
|
Assert.assertEquals(botName2, list.get(1).getName());
|
355
|
Assert.assertEquals("Nom illeg basionym group should come last", botName5, list.get(2).getName());
|
356
|
Assert.assertEquals("Names with nom. illeg. as basionym should stay in basionym group", botName3, list.get(3).getName());
|
357
|
}
|
358
|
|
359
|
@Test //failing selenium test
|
360
|
public void testCompare_NomIllegWithDate() {
|
361
|
NomenclaturalStatus illegStatus = NomenclaturalStatus.NewInstance(NomenclaturalStatusType.ILLEGITIMATE());
|
362
|
botName3.addStatus(illegStatus);
|
363
|
botName3.setNomenclaturalReference(ref1);
|
364
|
botName2.setNomenclaturalReference(ref2);
|
365
|
|
366
|
taxon1.addHomotypicSynonymName(botName3);
|
367
|
taxon1.addHomotypicSynonymName(botName2);
|
368
|
|
369
|
list.addAll(taxon1.getSynonyms());
|
370
|
Collections.sort(list, new HomotypicGroupTaxonComparator(taxon1));
|
371
|
|
372
|
Assert.assertEquals("Earlier nom. illeg. should come next", botName3, list.get(0).getName());
|
373
|
Assert.assertEquals("Later name should come last", botName2, list.get(1).getName());
|
374
|
}
|
375
|
|
376
|
@Test
|
377
|
public void testCompare_NoCircularProblemsWithBasionyms() {
|
378
|
|
379
|
taxon1.addHomotypicSynonymName(botName3);
|
380
|
taxon1.addHomotypicSynonymName(botName5);
|
381
|
botName3.addBasionym(botName5);
|
382
|
|
383
|
Assert.assertEquals(botName1.getHomotypicalGroup(), botName5.getHomotypicalGroup());
|
384
|
botName5.addBasionym(botName1);
|
385
|
botName1.addBasionym(botName3);
|
386
|
|
387
|
list.addAll(taxon1.getSynonyms());
|
388
|
list.add(taxon1);
|
389
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
390
|
|
391
|
Assert.assertEquals(botName1, list.get(0).getName());
|
392
|
Assert.assertEquals(botName3, list.get(1).getName());
|
393
|
Assert.assertEquals(botName5, list.get(2).getName());
|
394
|
|
395
|
//additional basionym for botName3
|
396
|
taxon1.addHomotypicSynonymName(botName2);
|
397
|
Assert.assertEquals(botName1.getHomotypicalGroup(), botName2.getHomotypicalGroup());
|
398
|
botName3.addBasionym(botName2);
|
399
|
list.clear();
|
400
|
list.addAll(taxon1.getSynonyms());
|
401
|
list.add(taxon1);
|
402
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
403
|
|
404
|
Assert.assertEquals(botName1, list.get(0).getName());
|
405
|
Assert.assertEquals(botName2, list.get(1).getName());
|
406
|
Assert.assertEquals(botName3, list.get(2).getName());
|
407
|
Assert.assertEquals(botName5, list.get(3).getName());
|
408
|
}
|
409
|
|
410
|
@Test
|
411
|
public void testCompare_NoCircularProblemsWithReplacedSynonyms() {
|
412
|
|
413
|
taxon1.addHomotypicSynonymName(botName3);
|
414
|
taxon1.addHomotypicSynonymName(botName5);
|
415
|
botName3.addReplacedSynonym(botName5, null, null, null, null);
|
416
|
|
417
|
Assert.assertEquals(botName1.getHomotypicalGroup(), botName5.getHomotypicalGroup());
|
418
|
botName5.addReplacedSynonym(botName1, null, null, null, null);
|
419
|
botName1.addReplacedSynonym(botName3, null, null, null, null);
|
420
|
|
421
|
list.addAll(taxon1.getSynonyms());
|
422
|
list.add(taxon1);
|
423
|
Collections.sort(list, new HomotypicGroupTaxonComparator(null));
|
424
|
|
425
|
Assert.assertEquals(botName1, list.get(0).getName());
|
426
|
Assert.assertEquals(botName3, list.get(1).getName());
|
427
|
Assert.assertEquals(botName5, list.get(2).getName());
|
428
|
}
|
429
|
}
|