Project

General

Profile

« Previous | Next » 

Revision 592b9851

Added by Andreas Kohlbecker about 5 years ago

ref #8107 getFieldGroup() returns Optional to avoid NPEs and logging errors before rethrowing as PopupEditorException

View differences:

src/main/java/eu/etaxonomy/cdm/vaadin/component/common/FilterableAnnotationsField.java
12 12
import java.util.Arrays;
13 13
import java.util.Collection;
14 14
import java.util.List;
15
import java.util.Optional;
15 16

  
16 17
import org.vaadin.viritin.FilterableListContainer;
17 18

  
......
140 141
     * {@inheritDoc}
141 142
     */
142 143
    @Override
143
    public FieldGroup getFieldGroup() {
144
        // holds a Container instead // TODO can this cause a NPE?
145
        return null;
144
    public Optional<FieldGroup> getFieldGroup() {
145
        // holds a Container instead
146
        return Optional.empty();
146 147
    }
147 148

  
148 149
    @Override

Also available in: Unified diff