EDIT: Issueshttps://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852019-01-31T14:51:03ZEDIT Project Management
Redmine bug #8051 (Closed): improve display of registration items listshttps://dev.e-taxonomy.eu/redmine/issues/80512019-01-31T14:51:03ZAndreas Kohlbecker
<p>lists of registration items are being used in</p>
<ul>
<li>registration search results</li>
<li>reference page nomenclatural acts section </li>
</ul>
<p>Requirements:</p>
<ol>
<li>in the search results the registration id, date and institute is to be shown above the summary, date and institute will be greyed out</li>
<li>in all other lists the registration id, date and institute should come after the summary without line break.</li>
<li>the name and typification types (Holotype, Lectotype, ...) which belong to the nomeclatural act will be shown in bold letters</li>
<li>A name which is in the summary but not part of the actual nomenclatural act will be greyed out. </li>
</ol>
feature request #8048 (Closed): Selenium test for Registration page https://dev.e-taxonomy.eu/redmine/issues/80482019-01-31T12:49:04ZAndreas Kohlbecker
<p>implement a selenium test for the registration page </p>
<p>Thew test should cover <a class="issue tracker-5 status-5 priority-10 priority-lowest closed" title="feature request: Registration page layout improved (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/7977">#7977</a>, <a class="issue tracker-5 status-5 priority-10 priority-lowest closed" title="feature request: registration page shows name relations (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/7947">#7947</a>, <a class="issue tracker-4 status-5 priority-10 priority-lowest closed" title="bug: reference page: show name types (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/7616">#7616</a>, <a class="issue tracker-4 status-5 priority-10 priority-lowest closed" title="bug: Annotations in Reference page do not respect the annotation settings (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/7907">#7907</a></p>
feature request #8030 (Closed): Cache updater service methods externalized and base class specifichttps://dev.e-taxonomy.eu/redmine/issues/80302019-01-29T10:48:29ZAndreas Kohlbecker
<p>copied from <a class="issue tracker-4 status-5 priority-10 priority-lowest closed" title="bug: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/7874">#7874</a></p>
<p>Generally at the moment I do not fully understand how far we need the lines after line 439. The call </p>
<pre>entitiesToUpdate.add(entity);
</pre>
<p>is not really required I think as the entities all belong to the session already. If not, are the .getTitleCache or .getAbbrevTitleCace calls important here? Or can we completely delete this part. If not I wonder why the calls are alternative, e.g. if olcTitleCache <> newTitleCache the entity instanceof Team part is not called anymore. Is this on purpose? </p>
<p>Also the whole method is only called if entity.isProtectedTitleCache() == false which might be unwanted e.g. for Teams. If the titleCache is protected but nomenclaturalTitleCache is not protected we may still want to update it.</p>
<p>Generally we need to refactor this part and move away the specific class handling from IdentifiableServiceBase (e.g. we could move the update routines to the model classes as the knowledge about the model classes is best here)</p>
feature request #7977 (Closed): Registration page layout improvedhttps://dev.e-taxonomy.eu/redmine/issues/79772019-01-11T14:04:28ZAndreas Kohlbecker
<p>The layout of the registration needs to be rendered according to the following scheme:</p>
<pre>if reg has name
print name
print name relations
line break
if reg has typedesignations
print type designations each in a separate line
print specimen table
if reference is a section & has inReference
print inReference
else
print reference
line break
print registration date and office
</pre>
<ul>
<li>WGB: statt „Registration:“ besser „Registration identifier:“ [http-identifier] DONE</li>
</ul>
<hr>
<p>Taxon names in the reference citation string should be displayed in italics, see <a class="issue tracker-4 status-8 priority-10 priority-lowest closed" title="bug: Registration page: scientific names in the citation to be shown in italics (Worksforme)" href="https://dev.e-taxonomy.eu/redmine/issues/8018">#8018</a></p>
<p>Registration for testing the implementation: </p>
<ul>
<li><a href="http://phycobank.org/100499">http://phycobank.org/100499</a> (name type and specimen type designations)</li>
<li><a href="http://phycobank.org/100014">http://phycobank.org/100014</a></li>
</ul>
bug #7974 (Closed): Layout for Registration datehttps://dev.e-taxonomy.eu/redmine/issues/79742019-01-09T14:06:30ZWolf-Henning Kusber
<p><a href="https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25">https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25</a></p>
<p>Layout for Registration date should be changed:<br>
"Registration at 2019-01-09 14:36:39 in"</p>
<p>should read:<br>
Registration on 2019-01-09 14:36:39</p>
<p>delete "in" <br>
change "at" to "on"<br>
Comment:date format is fine!</p>
<p><img src="https://dev.e-taxonomy.eu/redmine/attachments/download/1475/picture993-1.png" alt="" /></p>
feature request #7947 (Closed): registration page shows name relationshttps://dev.e-taxonomy.eu/redmine/issues/79472018-12-11T13:08:59ZAndreas Kohlbecker
<p>Display of name relations in the reference page is urgently required</p>
bug #7930 (Closed): Remove DOI from journals, print series and person communicationshttps://dev.e-taxonomy.eu/redmine/issues/79302018-11-28T12:02:16ZAndreas Müller
<p>Talking with WHK about DOIs we decided that journals and print series do not have DOIs. Therefore these should be removed from the according interfaces.</p>
<p>Also IPersonalCommunication should not have a DOI.</p>
feature request #7927 (Closed): Registration not found, Portal handling registrations in preparat...https://dev.e-taxonomy.eu/redmine/issues/79272018-11-26T18:57:58ZWolf-Henning Kusber
<p>Problem: When http-Identifier are inserted in a manuscript, authors or editors or copy editors are checking the link.</p>
<p>Example <a href="http://phycobank.org/100518">http://phycobank.org/100518</a></p>
<p>The registration will not be shown in (i)Vaadin and (ii) in the Phycobank user interface (Portal):<br>
The display is:<br>
Registration not found<br>
A registration with the identifier <a href="http://phycobank.org/100518">http://phycobank.org/100518</a> does not exist. </p>
<p>It would be great, to have an information about the status of the requested Id (exist - does not exist, in preparation, is rejected)</p>
<p>Suggestion for the Portal:</p>
<p>Registration not found<br>
A registration with the identifier <a href="http://phycobank.org/100518">http://phycobank.org/100518</a> does not exist.<br>
[only displayed if there is no unpublished record, in this case the record is prepared]</p>
<p>Registration not published<br>
A registration with the identifier <a href="http://phycobank.org/100518">http://phycobank.org/100518</a> is in preparation.</p>
<p>Registration not published<br>
A registration with the identifier <a href="http://phycobank.org/100518">http://phycobank.org/100518</a> is rejected.</p>
<p>The question is, if "curation" is needed as information, because it is a subtask of "preparation".</p>
<p>Furthermore it might be interesting to have a respective note in Vaadin (nice to have).</p>
<p>[Currently, I have to explain authors and editors, why the Links to PhycoBank are "broken"].</p>
task #7918 (Closed): Revision of reference type specific propertieshttps://dev.e-taxonomy.eu/redmine/issues/79182018-11-21T10:27:39ZAndreas Kohlbecker
<p>Reference Editor of Vaadin (2018-11-02) in square brackets: Differences in the TaxEditor</p>
<p><em>Article</em><br>
Date published: ok<br>
Title: ok [TaxEditor: also a nomencl. Title is given, in a few cases in TL2 there is an abbreviated title is given]<br>
Authors: ok<br>
In-reference: ok<br>
Series: not sure if needed. Is there a use case? [TaxEditor: also available, ask other projects if needed]<br>
Volume: ok<br>
Uri: ok<br>
MISSING IN VAADIN: DOI [also missing in TaxEditor, this seems to be an issue]</p>
<p><em>Journal</em><br>
Date published: needed for the runtime of a journal? E.g. 1945-1990??<br>
Title: ok<br>
Nomenclatural title: ok<br>
Authors: NOT NEEDED [also available in TaxEditor]<br>
In-reference: NOT NEEDED [not in TaxEditor]<br>
Place published: ok (but changes often in the runtime)<br>
Publisher: ok (but changes often in the runtime)<br>
ISSN: ok (nice to have: two fields for print and e-journal, respective)<br>
DOI: In VAADIN NOT NEEDED [not in TaxEditor]<br>
Uri: ok</p>
<p><em>Book section</em> (Layout in Vaadin narrow)<br>
Date published: just needed, if parts of a book are printed independently<br>
MISSING: Title [available in TaxEditor]<br>
Authors: ok<br>
In-reference: ok<br>
Pages: ok<br>
URI: ok<br>
MISSING: DOI [also missing in TaxEditor, this seems to be an issue]</p>
<p><em>Book</em><br>
Date published: ok<br>
Title: okay<br>
Nomenclatural title: ok<br>
Authors: ok<br>
In-reference: ok [in TaxEditor “In Series”]<br>
Series: (Discuss: isn’t In-reference the right place to store and select a series, rather than in a string?) [also available in TaxEditor]<br>
Volume: ok<br>
Pages: ok<br>
Edition: ok<br>
Place published: ok <br>
Publisher: ok<br>
Editor: ok (discuss: person/team atomized?) [same in TaxEditor]<br>
ISBN: ok (nice to have: two fields for print and e-journal, respective) <br>
DOI: ok [MISSING in TaxEditor, this might be an issue in future]<br>
Uri: ok</p>
<p>Inproceedings (might be renamed as Proceedings section)<br>
Date published: just needed, if parts of a book are printed independently<br>
Title: ok<br>
Authors: ok<br>
In-reference: ok<br>
Series: NOT NEEDED [also available in TaxEditor ]<br>
Pages: ok<br>
DOI: ok<br>
URI: ok [MISSING in TaxEditor, this might be an issue in future]</p>
<p><em>Proceedings</em><br>
See Book, except for “Edition” but two editions of proceedings cannot be excluded…<br>
ISBN: [MISSING in TaxEditor]</p>
<p><em>Printseries</em><br>
Date published: needed for the runtime of a print series? E.g. 1945-1990??<br>
Title: ok<br>
MISSING: Nomenclatural title<br>
Authors: needed? Maybe in a special case<br>
In-reference: Maybe for a print series within a print series?<br>
MISSING Edition: Discuss: this might be useful, if there are editions of print series, such as Adolf Engler’s Syllabus, do not know if we really need this.<br>
Place published: ok <br>
Publisher: ok<br>
Editor: ok (discuss: person/team atomized?)<br>
ISBN: ok (nice to have: two fields for print and e-journal, respective) [MISSING in TaxEditor]<br>
DOI: NEEDED? [not in TaxEditor]<br>
Uri: ok (but changes often in the runtime)</p>
<p><em>Thesis</em><br>
Okay, except of MISSING: School [see TaxEditor]<br>
Discuss: A thesis is an effectively published book (see book) or a not effectively published book, an Internet resource, or a microfiche. How to deal with this? Should the Reference type called “Thesis (not effectively published)? If not, we need a “not published” flag, if applicable a text field for the reason. The thing is, that any thesis has a date, a place, sometimes a publisher, even it is not published effectively. This is important, because a lot of novelties have been printed in not effectively published theses. Alternatively we could leave “Thesis” as is, and flag each nomenclatural act as invalid with reference to the respective provisions of the ICN, that this was not effectively published. In Vaadin “School” might be stored under Publisher.</p>
bug #7915 (Closed): Remove date published from journals and print serieshttps://dev.e-taxonomy.eu/redmine/issues/79152018-11-20T16:09:00ZAndreas Müller
<p>Journals (and also print series) do not have a single publication date but only a period in which single volumes have been published. Therefore the current possibility to add date published to a journal or a print series should be removed in the according interfaces.</p>
feature request #7914 (Closed): Add ISBN to IProceedingshttps://dev.e-taxonomy.eu/redmine/issues/79142018-11-20T14:26:18ZAndreas Müller
<p>Proceedings are books though they do not implement the IBook interface as they do not have editions.</p>
<p>ISBN needs to be added to IProceedings explicitly</p>
bug #7913 (Closed): Remove authorship from IJournal and IPrintSerieshttps://dev.e-taxonomy.eu/redmine/issues/79132018-11-20T14:19:18ZAndreas Müller
<p>Authorship should be removed from journals and print series. Even if they share a common author the authorship should be stored in the underlying article, book, ... to avoid confusion and inconsistency.<br>
Existing authorship may create problems when finding duplicates via matching algorithms.</p>
bug #7907 (Closed): Annotations in Reference page do not respect the annotation settingshttps://dev.e-taxonomy.eu/redmine/issues/79072018-11-14T10:13:54ZAndreas Kohlbecker
<p>... habe gerade gesehen, dass im Production Portal unsere internal notes angezeigt werden. </p>
<p><a href="https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25">https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25</a></p>
<p>Das kommt aus den internal notes: "Olszyński new, Żelazna-Wieczorek new"</p>
<p>Die editorial notes können zwar hier deaktiviert werden: <a href="https://www.phycobank.org/admin/config/cdm_dataportal/settings/layout">https://www.phycobank.org/admin/config/cdm_dataportal/settings/layout</a></p>
<p>aber offen bar funktioniert hier was nicht. Deaktivieren der editorial Annotations hat keinen Einfluss auf die Reference seite</p>
<p><strong>TODO</strong></p>
<ol>
<li>fix this bug</li>
<li>remove from user defined styles:<br></li>
</ol>
<pre>#content .annotations {
display :none;
}
</pre> bug #7616 (Closed): reference page: show name typeshttps://dev.e-taxonomy.eu/redmine/issues/76162018-08-01T16:23:20ZAndreas Kohlbecker
<p>The specimen table header is shown even when only name types are available. The name types should be displayed correctly instead. </p>
bug #7564 (Closed): remove Phycobank - Registration data - block and other outdated registration ...https://dev.e-taxonomy.eu/redmine/issues/75642018-07-19T12:58:02ZAndreas Kohlbecker
<p><del>also remove <code>render_registrations()</code> in name.inc?</del> need to keep this method since it is used in reder_taxon_or_name() and theme_cdm_typedesignations()</p>