Project

General

Profile

Activity

From 10/12/2023 to 11/10/2023

11/10/2023

02:47 PM Revision f9d210ec (taxeditor): ref #10424: show create new fact also if no factual data set is selected
Katja Luther
11:02 AM Revision d7270748 (cdmlib): add getDefaultDescription to Taxon
Katja Luther
10:33 AM Revision aadb3b73 (taxeditor): ref #10409: set default language for jre version
Katja Luther
10:08 AM Revision 8d9c3a25 (taxeditor): Revert "add english as default language also for jre version"
This reverts commit 1a729a1299a36410bc3f87b4d8b41aa9a4656930. Katja Luther
10:07 AM Revision 1a729a12 (taxeditor): add english as default language also for jre version
Katja Luther
09:43 AM bug #10428 (Resolved): Distribution Selection in Distribution Editor throws NPE
PLease review. You have to delete the line with "distribution.area.terms_cybertaxonomy.org/[cdm instance]" from the p... Katja Luther

11/09/2023

05:19 PM Revision 53313b7b (taxeditor): Merge branch 'hotfix/5.41.2'
root
03:50 PM Revision a10203d1 (taxeditor): ref #10428: fix problems with checkboxTreeViewer
Katja Luther
03:46 PM Revision 96811072 (taxeditor): Updated version in pom / project files to taxeditor version : 5.41.2 and cdmlib version : 5.41.0
jenkins
03:03 PM Revision b9b8a2cc (taxeditor): ref #10428: fix problems with checkboxTreeViewer
Katja Luther

11/07/2023

03:53 PM Revision d7b43238 (taxeditor): Merge branch 'hotfix/5.41.1'
root
01:13 PM Revision 80a9e69d (taxeditor): ref #10428: avoid NPE for missing checkedElements
Katja Luther
01:03 PM Revision 30cdff3e (taxeditor): ref #10428: avoid NPE for missing checkedElements
Katja Luther
12:47 PM bug #10428 (Closed): Distribution Selection in Distribution Editor throws NPE
If there is no preference for the areas of the distribution editor it throws a NullPointerException because it checks... Katja Luther
12:33 PM Revision 4b88ed6b (taxeditor): Updated version in pom / project files to taxeditor version : 5.41.1 and cdmlib version : 5.41.0
jenkins
12:30 PM Revision e10777d7 (cdmlib-apps): Move wp6 activators and imports to project specific folder and remove deprecated CdmUtils.isEmpty
Andreas Müller
12:18 PM Revision 463be2b7 (cdmlib): remove CdmUtils.isEmpty and some cleanup
Andreas Müller
10:43 AM Revision 72b94d89 (taxeditor): ref #10427: code cleaning
Katja Luther
10:42 AM bug #10427 (Resolved): Exception in NodeSelection Dialog when no classification is selected
Now the ok button only can be pressed if a selection is available otherwise it is disabled. Please review. Katja Luther
10:41 AM bug #10427 (Closed): Exception in NodeSelection Dialog when no classification is selected
mail AM:
Beim Versuch in E+M das Taxon Hieracium multicaule zu öffnen. Choose classification Dialog kam und bereit...
Katja Luther
10:41 AM Revision c0d03e75 (taxeditor): ref #10427: ok button is disabled as long as nothing selected
Katja Luther

11/06/2023

11:17 AM Revision eb4986fc (taxeditor): avoid NPE
Katja Luther
07:32 AM bug #10426: MediaSpecimen as typedesignation not shown correctly in dataportal
mail NaK:
mir ist eben aufgefallen, dass auch die Publikation des Media Specimen im Portal gar nicht angezeigt wir...
Katja Luther

11/02/2023

04:01 PM feature request #5973 (Closed): Implement DescriptionBase.isDefault in TaxEditor
Works as expected now. Andreas Müller

10/31/2023

02:04 PM bug #10426 (New): MediaSpecimen as typedesignation not shown correctly in dataportal
mail NaK:
1) Die Media URI wird im Portal nicht angezeigt.
2) „Prepared by“ wird im Portal auch nicht angezeigt...
Katja Luther
01:58 PM bug #10425 (New): MediaSpecimen as Typespecimen should be opened in corresponding details dialog
mail NaK:
4) Im Details View öffnet sich nicht der Dialog wie unten, sondern der „normale“ Specimen-Dialog, der is...
Katja Luther

10/30/2023

03:37 PM feature request #5973 (Resolved): Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-24:
> Andreas Müller wrote in #note-23:
> > Katja Luther wrote in #note-22:
> > > An...
Katja Luther
03:37 PM Revision 111a48bb (taxeditor): ref #5973: correct handling of useDefaultDescription
Katja Luther
07:52 AM Revision 5895e346 (taxeditor): fix NPE
Katja Luther

10/28/2023

09:00 PM feature request #10424 (Closed): Add menu for new single fact to avoid creating dataset explicitly
From #5973:
We could also offer to show the "New (Fact)" menu immediately now if no dataset exists yet. Selecting ...
Andreas Müller
08:56 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-23:
> Katja Luther wrote in #note-22:
> > Andreas Müller wrote in #note-14:
> > > An...
Andreas Müller
08:52 PM feature request #5973 (Feedback): Implement DescriptionBase.isDefault in TaxEditor
Katja Luther wrote in #note-22:
> Andreas Müller wrote in #note-14:
> > Andreas Müller wrote in #note-13:
> > > Wh...
Andreas Müller

10/27/2023

11:31 PM feature request #7922 (New): Add other possibilities to save distributions created with the distribution editor
First issue implemented. Remaining possible implementations can be implemented when there is need for it. Therefore r... Andreas Müller
07:42 PM Revision 9916a3f6 (cdm-server): Merge branch 'release/5.41.0' into develop
jenkins
07:42 PM Revision 4fc32c97 (cdm-server): jenkins merging release branch into master (strategy: theirs)
jenkins
07:41 PM Revision 6355629c (cdm-server): updating poms for branch'release/5.41.0' with non-snapshot versions
jenkins
07:30 PM Revision 7a18053d (cdm-webapp): Merge branch 'release/5.41.0' into develop
jenkins
07:30 PM Revision 20374991 (cdm-webapp): jenkins merging release branch into master (strategy: theirs)
jenkins
07:29 PM Revision f7712c66 (cdm-webapp): updating poms for branch'release/5.41.0' with non-snapshot versions
jenkins
07:29 PM Revision e35cee1b (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.41.0
jenkins
07:29 PM Revision ae97cae4 (cdm-vaadin): Merge branch 'release/5.41.0' into develop
jenkins
07:29 PM Revision 7cc9d14c (cdm-vaadin): jenkins merging release branch into master (strategy: theirs)
jenkins
07:28 PM Revision 167690e9 (cdm-dataportal): Merge branch 'release/5.41.0' into develop
jenkins
07:28 PM Revision 37eb31dc (cdm-dataportal): updating poms for branch'release/5.41.0' with non-snapshot versions
jenkins
07:27 PM Revision db680768 (cdm-dataportal): release-preparation: production level css
jenkins
07:27 PM Revision 12864ceb (taxeditor): Merge branch 'release/5.41.0' into develop
jenkins
07:27 PM Revision e8a26b1f (taxeditor): Merge branch 'release/5.41.0'
jenkins
07:25 PM Revision 1610cde4 (cdm-vaadin): updating poms for branch'release/5.41.0' with non-snapshot versions
jenkins
07:25 PM Revision c3be90be (cdm-vaadin): jenkins bumping cdmlib.version to 5.41.0
jenkins
07:25 PM Revision fbbad3bb (cdmlib): Updating develop poms back to pre merge state
jenkins
07:25 PM Revision 9382ebda (cdmlib): Merge branch 'master' into develop
jenkins
07:24 PM Revision 0590556c (cdmlib): updating develop poms to master versions to avoid merge conflicts
jenkins
07:24 PM Revision c8e7d9ed (cdmlib): Merge branch 'release/5.41.0'
jenkins
07:11 PM Revision 0429723b (cdmlib): updating poms for branch'release/5.41.0' with non-snapshot versions
jenkins
06:15 PM Revision 1782add6 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.41.0-SNAPSHOT
jenkins
06:15 PM Revision d63bf741 (cdm-webapp): updating poms for 5.42.0-SNAPSHOT development
jenkins
06:15 PM Revision e7f420dc (cdm-webapp): updating poms for 5.41.0 branch with snapshot versions
jenkins
06:15 PM Revision 2888ab80 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.42.0-SNAPSHOT
jenkins
06:14 PM Revision ded73c8b (taxeditor): Updated version in pom / project files to taxeditor version : 5.42.0-SNAPSHOT and cdmlib version : 5.42.0-SNAPSHOT
jenkins
06:14 PM Revision 5bb62a41 (taxeditor): Updated version in pom / project files to taxeditor version : 5.41.0 and cdmlib version : 5.41.0
jenkins
06:13 PM Revision aca8f664 (cdm-vaadin): jenkins bumping cdmlib.version to 5.41.0-SNAPSHOT
jenkins
06:13 PM Revision 835aa6a2 (cdm-vaadin): updating poms for 5.42.0-SNAPSHOT development
jenkins
06:13 PM Revision de0bf9a2 (cdm-vaadin): updating poms for 5.41.0 branch with snapshot versions
jenkins
06:13 PM Revision f4617731 (cdm-vaadin): jenkins bumping cdmlib.version to 5.42.0-SNAPSHOT
jenkins
06:13 PM Revision 76b36011 (cdm-server): updating poms for 5.42.0-SNAPSHOT development
jenkins
06:12 PM Revision 4a93448b (cdm-dataportal): updating poms for 5.42.0-SNAPSHOT development
jenkins
06:09 PM Revision b579c2e0 (cdmlib): updating poms for 5.42.0-SNAPSHOT development
jenkins
04:47 PM feature request #5973 (Resolved): Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-14:
> Andreas Müller wrote in #note-13:
> > When moving single facts a new descriptio...
Katja Luther
04:46 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-16:
> We could also offer to show the "New (Fact)" menu immediately now if no dataset ...
Katja Luther
04:09 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-13:
> When moving single facts a new description is created but without checking if it...
Katja Luther
04:18 PM Revision 14b0dbd3 (taxeditor): ref #5973: l10n labels in selection dialog
Katja Luther
04:01 PM Revision 46ac0597 (taxeditor): ref #5973: adapt to changes in service for default desc - continue
Katja Luther
03:56 PM Revision 503ba37b (taxeditor): ref #5973: adapt to changes in service for default desc - continue
Katja Luther
03:39 PM Revision abf47708 (taxeditor): ref #5973: adapt to changes in service for default desc
Katja Luther
03:38 PM Revision 34ea02e8 (cdmlib): ref #5973: param to define whether moved descEl goes to default descr
Katja Luther
02:19 PM Revision 97614ba0 (cdmlib): ref #5973: add hasDefaultDes to Taxon, handle default for moved desElem
Katja Luther
01:22 PM Revision 55fa0553 (cdm-dataportal): fix problem in classification check
Katja Luther
12:01 PM feature request #10364: Implement state modifiers for matrix
Now it works as expected. Great! Andreas Müller
12:00 PM feature request #10364 (Closed): Implement state modifiers for matrix
Andreas Müller
11:54 AM bug #10411 (Closed): Show subareas of area trees in area selection dialogue for distribution editor
Now it works as expected. Andreas Müller
11:22 AM bug #10411 (Resolved): Show subareas of area trees in area selection dialogue for distribution editor
And the size is adapted, too. Please review. Katja Luther
11:14 AM bug #10411 (In Progress): Show subareas of area trees in area selection dialogue for distribution editor
Andreas Müller wrote in #note-7:
> Now when pressing the finish button a warning is shown "please check at least one...
Katja Luther
10:49 AM bug #10411 (Feedback): Show subareas of area trees in area selection dialogue for distribution editor
Now when pressing the finish button a warning is shown "please check at least one item". Though these are checked - b... Andreas Müller
11:19 AM Revision 7d931601 (taxeditor): ref #10411: open with defined height
Katja Luther
11:04 AM Revision a8724b07 (taxeditor): ref #10411: check checkedElements from composite.
Katja Luther

10/26/2023

09:51 PM Revision c5ec2ffc (cdmlib): ref #10271 some improvements to COL-DP Export (fix export type test in CDM light)
Andreas Müller
09:34 PM Revision 7ecd7baf (cdmlib-apps): ref #10398 adapt app-import to ABCD config
Andreas Müller
09:30 PM Revision b081275e (cdmlib): cleanup
Andreas Müller
09:30 PM Revision e80c6b90 (cdmlib): ref #10271 some improvements to COL-DP Export
Andreas Müller
03:52 PM Revision c9df266f (taxeditor): fix label of specimen facts view
Katja Luther
03:49 PM feature request #10398 (Closed): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
Code cleaning done, so we can close this ticket. Katja Luther
11:58 AM feature request #10398 (Feedback): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
The above changes are as expected.
I did not test functionality of the new configuration as it takes much time for m...
Andreas Müller
03:49 PM Revision 4832c9a5 (cdmlib): ref #10398: code cleaning
Katja Luther
03:47 PM bug #10411 (Resolved): Show subareas of area trees in area selection dialogue for distribution editor
Andreas Müller wrote in #note-4:
> In most cases it works as expected. But loading the subareas does not work correc...
Katja Luther
03:46 PM Revision d01cb37b (taxeditor): ref #10411: fix getChecked elements
Katja Luther
03:16 PM feature request #10362 (Closed): Implement noDataStatus in matrix and details view
Andreas Müller wrote in #note-29:
> In details view the no data combo is not yet ordered. Ticket can be closed again...
Katja Luther
03:14 PM feature request #10364 (Resolved): Implement state modifiers for matrix
I could find a way to open the drop down. Please review. Katja Luther
02:32 PM Revision 76b91cb1 (taxeditor): ref #10364: fix CdmContentProposalAdapter - continue
Katja Luther
02:07 PM Revision 42f850c4 (taxeditor): ref #10364: fix CdmContentProposalAdapter
Katja Luther
01:45 PM Revision 94eb5ccd (taxeditor): ref #10362: sort noDataStatus in details view
Katja Luther
01:44 PM Revision f645ecfe (taxeditor): ref #10364: add adapted contentProposalAdapter to open programmatically
Katja Luther
01:41 PM Revision 6b3dc3a9 (taxeditor): ref #10364: add adapted contentProposalAdapter to open programmatically
Katja Luther
12:07 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Katja Luther wrote in #note-18:
> For me it does not look unsaved because the unsaved '*' is behind the label and at...
Andreas Müller
10:23 AM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-15:
> I wonder if using "*" as an indicator was such a good idea. It looks like "unsav...
Katja Luther
07:47 AM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-12:
> Andreas Müller wrote in #note-11:
> > when trying to add a new first descriptio...
Katja Luther

10/25/2023

08:32 PM bug #10402 (Closed): The header of character matrix shows titlecache instead of the label
Andreas Müller
11:34 AM bug #10402 (Resolved): The header of character matrix shows titlecache instead of the label
The header label is now the l10n label of the term for the term language. Please review. Katja Luther
08:16 PM feature request #10364: Implement state modifiers for matrix
Katja Luther wrote in #note-23:
> This is possible but the drop down does not open, so you still have to enter anoth...
Andreas Müller
08:12 PM feature request #10364: Implement state modifiers for matrix
Katja Luther wrote in #note-23:
> Andreas Müller wrote in #note-21:
> > Is there a possibility that if I enter e.g....
Andreas Müller
08:07 PM feature request #10362 (Feedback): Implement noDataStatus in matrix and details view
In details view the no data combo is not yet ordered. Ticket can be closed again when this is fixed. Andreas Müller
08:03 PM feature request #10362 (Closed): Implement noDataStatus in matrix and details view
Works as expected. Andreas Müller
07:53 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
We could also offer to show the "New (Fact)" menu immediately now if no dataset exists yet. Selecting it and a featur... Andreas Müller
07:39 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
I wonder if using "*" as an indicator was such a good idea. It looks like "unsaved". Maybe we should use another sign... Andreas Müller
07:34 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-13:
> When moving single facts a new description is created but without checking if it...
Andreas Müller
07:32 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
When moving single facts a new description is created but without checking if it should be a default description. Andreas Müller
07:15 PM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-11:
> when trying to add a new first description to a taxon I got:
>
> ~~~
> last ...
Andreas Müller
07:07 PM feature request #5973 (Feedback): Implement DescriptionBase.isDefault in TaxEditor
when trying to add a new first description to a taxon I got:
~~~
last remote service : http://localhost:55734/rem...
Andreas Müller
02:51 PM feature request #5973 (Resolved): Implement DescriptionBase.isDefault in TaxEditor
Adapted move operations in a way that moved descriptions never be default descriptions. I think now everything should... Katja Luther
11:38 AM feature request #5973: Implement DescriptionBase.isDefault in TaxEditor
Andreas Müller wrote in #note-8:
> >adding isDefault to the first description created
>
> This should be changed ...
Katja Luther
06:55 PM bug #10410 (Closed): Newly created distributions are added to computed description
Works as expected. We can implement some of the other 3 options later in case there is a request for it. Andreas Müller
06:51 PM Revision b64f825a (taxeditor): cleanup
Andreas Müller
06:51 PM Revision 0237b2e7 (taxeditor): fix typo
Andreas Müller
06:34 PM bug #10411 (Feedback): Show subareas of area trees in area selection dialogue for distribution editor
In most cases it works as expected. But loading the subareas does not work correctl. If I seclect e.g. Georgia and a ... Andreas Müller
10:46 AM bug #10411 (Resolved): Show subareas of area trees in area selection dialogue for distribution editor
This is implemented. If a term is checked, which is also available in a tree, this node is checked as well and the ot... Katja Luther
03:33 PM bug #10423: Distribution Editor: Make it possible to remember name in source
mail KL:
Meine erste Idee, wäre es ähnlich wie bei der Quelle zu machen, allerdings würde ich eine Art Warnung (entw...
Katja Luther
01:44 PM bug #10423 (New): Distribution Editor: Make it possible to remember name in source
Mail ERS:
ich habe gerade den Fall, dass ich für ein Taxon einen name in source angeben muss, der von dem akzeptie...
Katja Luther
02:49 PM Revision c0031f82 (cdmlib): ref #5973: handle default descriptions when moving
Katja Luther
11:35 AM feature request #10398 (Resolved): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
Katja Luther
11:33 AM Revision 62309dc5 (taxeditor): ref #10402: labels in header with l10n
Katja Luther
11:27 AM feature request #10422 (New): Allow different base layers for distribution and occurrence maps
This is overlapping with #10343 (having separate maps for speparate features).
We could e.g. define a list of map ...
Andreas Müller
10:44 AM Revision b386e9de (taxeditor): ref #10411: check for term/node correlation
Katja Luther

10/24/2023

03:24 PM bug #10393: ABCD Import of specimen added to a taxon included in second classification is not the one of the chosen classification
Andreas Müller wrote in #note-10:
> Andreas Müller wrote in #note-8:
> > As KK already reviewed functionality I onl...
Katja Luther
03:07 PM bug #10393: ABCD Import of specimen added to a taxon included in second classification is not the one of the chosen classification
Andreas Müller wrote in #note-8:
> As KK already reviewed functionality I only reviewed code. It looks ok, but is th...
Andreas Müller
02:01 PM bug #10393 (Closed): ABCD Import of specimen added to a taxon included in second classification is not the one of the chosen classification
I don't know anymore why one collection is a set and one is a list. Katja Luther
03:24 PM Revision 9e2520e7 (cdmlib): ref #10393: code cleaning
Katja Luther
02:48 PM Revision b4e190bf (taxeditor): remove doFactualData from second page - continue
Katja Luther
02:36 PM bug #10419 (Closed): Collector title not handled correctly if collector titleCache is protected
This works as expected. Katja Luther
02:30 PM feature request #10420 (Closed): Order exact values in QuantitativeDataFormatter
Works as expected. Katja Luther
02:07 PM feature request #10362 (Resolved): Implement noDataStatus in matrix and details view
if noDataStatus is selected, the status fields are not visible anymore and the noData Status are sorted now. Katja Luther
02:03 PM Revision 394ed648 (taxeditor): fix if classification from abcd config does not exist
Katja Luther
01:59 PM Revision 6b1d642f (taxeditor): remove doFactualData from second page of Cdm-L export wizard
Katja Luther
01:20 PM Revision 8feecded (cdm-dataportal): show statistical values with modifiers
Katja Luther
11:53 AM feature request #10421 (New): Make it impossible to store objects with obligatory fields not set in TaxEditor (or general)
As an example we found StatisticalMeasumentValue without type set, but there are many others.
We need to
* set ...
Andreas Müller
11:49 AM feature request #10364: Implement state modifiers for matrix
I implemented all issues except the open drop down when the dialog opens up, we have to decide whether this is ok for... Katja Luther
11:36 AM feature request #10398 (In Progress): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
Katja Luther
11:30 AM feature request #10398 (Resolved): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
Andreas Müller wrote in #note-7:
> Is there a reason why the selection drop box is now beside the label "Link to Tax...
Katja Luther
11:25 AM Revision 07145de7 (taxeditor): ref #10398: layout
Katja Luther
11:12 AM Revision 2698fe00 (taxeditor): ref #10398: layout and labeling - continue
Katja Luther
11:07 AM Revision 2fc2e877 (taxeditor): ref #10398: layout and labeling
Katja Luther
10:51 AM bug #10410 (Resolved): Newly created distributions are added to computed description
Please review. Katja Luther
10:44 AM bug #10415 (Closed): WS to get polytomous keys and specimen called independend of portal configuration
Yes, you are right. The reported WS calls are for mediakey and multi access key. But I would close this ticket becaus... Katja Luther

10/23/2023

03:50 PM Revision 4fbc03f6 (cdmlib): minor
Katja Luther
03:09 PM Revision b9f64884 (cdmlib): ref #10411: add method to get node for term
Katja Luther
02:48 PM Revision 2857f72b (taxeditor): ref #10411: add new composite for area trees
Katja Luther
02:46 PM Revision 1a11364d (cdmlib): add comparator for determinations
Katja Luther
02:07 PM feature request #10364: Implement state modifiers for matrix
Andreas Müller wrote in #note-22:
> Can we enlarge the dialogue such that the English title is always completely vis...
Katja Luther
01:58 PM Revision f1c54035 (taxeditor): ref #10411: terms checked in tree be checked in voc and other way round
Katja Luther
01:12 PM Revision 46c5bb8d (cdmlib): fix that term node d&d
Katja Luther
12:43 PM Revision e66b8855 (cdm-dataportal): adapt test
Katja Luther
12:26 PM Revision 3760fcc8 (cdm-dataportal): fix derivation label and adapt test
Katja Luther
11:38 AM Revision f404ee45 (cdm-dataportal): adapt test to reenabled specimen -continue
Katja Luther
11:05 AM Revision 87bca936 (cdm-dataportal): adapt test to reenabled specimen -continue
Katja Luther
11:01 AM Revision 7240e6c6 (cdm-dataportal): adapt test to collector handling in fieldunit formatter - continue
Katja Luther
10:59 AM Revision 9ff1b091 (cdm-dataportal): adapt test to reenabled specimen
Katja Luther
10:33 AM Revision d513cca4 (cdm-dataportal): adapt test to collector handling in fieldunit formatter
Katja Luther

10/21/2023

12:39 PM Revision 864e7761 (cdm-dataportal): cleanup
Andreas Müller
12:39 PM Revision f8930811 (cdm-dataportal): ref #10419 adapt portal tests to new collector handling in field unit formatter
Andreas Müller
12:32 PM Revision 58f35d36 (cdmlib): ref #10419 adapt DerivedUnitFacadeFieldUnitCacheStrategy collector formatting to FieldUnitDefaultCacheStrategy
Andreas Müller

10/20/2023

04:18 PM task #10414 (Closed): Remove Georgian subdivisions from Euro+Med
Data for Georgian subdivision have been removed. Map issues (remove borders from map) will be handled in #9367 Andreas Müller
02:59 PM feature request #10420: Order exact values in QuantitativeDataFormatter
Should be fixed. Please review. Andreas Müller
02:58 PM feature request #10420 (Resolved): Order exact values in QuantitativeDataFormatter
Applied in changeset commit:cdmlib|a31d48f6f795b96c38e8c233016cf6040199a127. Andreas Müller
02:51 PM feature request #10420 (Closed): Order exact values in QuantitativeDataFormatter
AM:
... auch im Facts View sollte die Reihenfolge angepasst werden.

![](clipboard-202310201450-ncv5y.png)
Andreas Müller
02:58 PM Revision 374285ad (cdmlib): cleanup
Andreas Müller
02:58 PM Revision a31d48f6 (cdmlib): fix #10420 order exact values in QuantitativeDataFormatter
Andreas Müller
02:23 PM Revision ffd0f988 (taxeditor): ref #10364: increase size and other layout issues - continue
Katja Luther
02:19 PM Revision e32a3655 (taxeditor): ref #10364: increase size and other layout issues
Katja Luther
01:43 PM feature request #10364: Implement state modifiers for matrix
Andreas Müller wrote in #note-21:
> Is there a possibility that if I enter e.g. a "b" in the matrix field (which ope...
Katja Luther
12:51 PM bug #10419: Collector title not handled correctly if collector titleCache is protected
This should be fixed. Please review. Andreas Müller
12:48 PM bug #10419 (Resolved): Collector title not handled correctly if collector titleCache is protected
Applied in changeset commit:cdmlib|e00d6685461dce078048b0817c17fb6d955e4f55. Andreas Müller
12:44 PM bug #10419 (Closed): Collector title not handled correctly if collector titleCache is protected
AM:
Grundsätzlich stimmt diese Implementierung nämlich nicht. Wenn wie hier auch der collector title offensichtlic...
Andreas Müller
12:47 PM Revision e00d6685 (cdmlib): fix #10419 fix collector title handling for protected titleCache collectors
Andreas Müller
11:58 AM Revision d8d184a9 (taxeditor): ref #10362: order items in drop down
Katja Luther
11:39 AM Revision cfee2e0f (cdm-dataportal): code cleaning
Katja Luther
11:31 AM bug #10418 (New): Thumbnail loading takes very long in taxon search
AM:
ich bin gerade zufällig über folgendes gestolpert:
Wenn ich bei Cichorieae nach Crepis bungei suche, egal o...
Andreas Müller
11:19 AM Revision 5dbe62c5 (cdmlib): cleanup
Andreas Müller
10:34 AM Revision 1d8a2b4d (cdmlib): code cleaning and add test for nomenclatural code
Katja Luther
10:02 AM Revision 406f4866 (cdmlib): cleanup
Andreas Müller

10/19/2023

05:47 PM feature request #10362: Implement noDataStatus in matrix and details view
The list in "No data available" should be ordered alphabetically. Andreas Müller
05:06 PM feature request #10362 (Feedback): Implement noDataStatus in matrix and details view
If I open a field which has already "not applicable" selected, the status is not disabled:
![](clipboard-202310191...
Andreas Müller
02:05 PM feature request #10362 (Resolved): Implement noDataStatus in matrix and details view
The last two topics are implemented, so I think we can set it to resolved. Please review. Katja Luther
02:04 PM feature request #10362: Implement noDataStatus in matrix and details view
Andreas Müller wrote in #note-20:
> When a no-data-available value is selected, the Status label and the delete butt...
Katja Luther
02:01 PM feature request #10362: Implement noDataStatus in matrix and details view
This is implemented
Andreas Müller wrote in #note-21:
> "No Data available" => either do Data->data or available...
Katja Luther
05:45 PM feature request #10398: Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
Is there a reason why the selection drop box is now beside the label "Link to Taxon"? As the label is bold it seems t... Andreas Müller
05:35 PM feature request #10398 (Feedback): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
I don't kow if all users know what an individuals association is.
Maybe we better use "As Taxon Fact", "As Specimen ...
Andreas Müller
05:20 PM feature request #10364: Implement state modifiers for matrix
Can we enlarge the dialogue such that the English title is always completely visible:
![](clipboard-202310191720-e...
Andreas Müller
05:00 PM feature request #10364: Implement state modifiers for matrix
Is there a possibility that if I enter e.g. a "b" in the matrix field (which opens the dialogue) this b is also enter... Andreas Müller
04:57 PM feature request #10364 (Feedback): Implement state modifiers for matrix
"Modifier and Status" is incorrect -> "Modifier and State".
Also I wonder if we can't put the labels on top of eac...
Andreas Müller
02:06 PM feature request #10364 (Resolved): Implement state modifiers for matrix
The last not working thing is the open drop down when the dialog opens, maybe we should create a new ticket for this ... Katja Luther
05:17 PM bug #10409 (Closed): Default application language should be English
I moved the open issue to #10417. Andreas Müller
01:05 PM bug #10409 (Resolved): Default application language should be English
I set this ticket to resolved because there is no quick solution for the problem of removed config.ini. Therefore we ... Katja Luther
05:16 PM bug #10417: Remember selected application language after TaxEditor update
Maybe this is easier after upgrading TaxEditor to java 11+ (#10046) Andreas Müller
05:14 PM bug #10417 (New): Remember selected application language after TaxEditor update
for details see #10409 Andreas Müller
04:44 PM bug #10394 (Closed): Details page for derived unit only shows categorical data
I tested again with the above link (and adapted data). Works as expected and we can close this ticket. Andreas Müller
03:20 PM bug #10394: Details page for derived unit only shows categorical data
Andreas Müller wrote in #note-17:
> Is the above test publicly available with a link?
This is my local installati...
Katja Luther
03:16 PM bug #10394 (Resolved): Details page for derived unit only shows categorical data
This looks fine now. I added sorting to the list of values. Katja Luther
03:01 PM bug #10394: Details page for derived unit only shows categorical data
Is the above test publicly available with a link? Andreas Müller
03:00 PM bug #10394: Details page for derived unit only shows categorical data
By the way, is there a reason, why the values are not ordered? I would expect it to be wanted behaviour to order them. Andreas Müller
02:59 PM bug #10394: Details page for derived unit only shows categorical data
Should be fixed. Can you test again? Andreas Müller
02:36 PM bug #10394: Details page for derived unit only shows categorical data
I think this does not work as it should:
![](Screenshot 2023-10-19 143531.png)
The prior implementation was:
![](S...
Katja Luther
02:14 PM bug #10394: Details page for derived unit only shows categorical data
Done. Please review code adaptation. If correct we can close the ticket as functionality works as expected. Andreas Müller
02:07 PM bug #10394: Details page for derived unit only shows categorical data
I will adapt the code Andreas Müller
01:24 PM bug #10394: Details page for derived unit only shows categorical data
Also the parameter naming is strange. The List<BigDecimal> is called "float values". Maybe we can correct this, too. Andreas Müller
01:22 PM bug #10394: Details page for derived unit only shows categorical data
OK, for the above link it seems to work as there are also int values. However, to me it is unclear if the if statemen... Andreas Müller
01:19 PM bug #10394: Details page for derived unit only shows categorical data
... or add a test showing that the result is correct for integer values. Andreas Müller
01:16 PM bug #10394 (Feedback): Details page for derived unit only shows categorical data
Andreas Müller
01:15 PM bug #10394: Details page for derived unit only shows categorical data
There is an *explicit* unlikely argument warning in the code:
![](clipboard-202310191315-haqx8.png)
Can you ple...
Andreas Müller
01:12 PM bug #10394: Details page for derived unit only shows categorical data
A null check is not needed if calling HibernateProxyHelper.deproxy(). I removed it in code. Andreas Müller
03:49 PM bug #10393 (Feedback): ABCD Import of specimen added to a taxon included in second classification is not the one of the chosen classification
As KK already reviewed functionality I only reviewed code. It looks ok, but is there a reason why there is still comm... Andreas Müller
03:49 PM Revision 69a964a3 (cdmlib): minor
Andreas Müller
03:45 PM Revision 49922fca (cdmlib): ref #10393 code cleanup
Andreas Müller
03:32 PM Revision afbdbb45 (cdmlib): cleanup
Andreas Müller
03:22 PM Revision 50614802 (cdmlib): cleanup indentation
Andreas Müller
03:22 PM Revision 001b9d78 (cdmlib): cleanup
Andreas Müller
03:15 PM Revision e4b9fbcd (cdmlib): ref #10394: order the quantitative data
Katja Luther
02:58 PM Revision f1753aed (cdmlib): ref #10394 cleanup code after fix (cont.)
Andreas Müller
02:13 PM Revision bac6de6e (cdmlib): cleanup
Andreas Müller
02:13 PM Revision 93ff1cd3 (cdmlib): ref #10394 cleanup code after fix
Andreas Müller
01:16 PM bug #10410: Newly created distributions are added to computed description
New descriptions are set to default if no default description exists and if distribution editor creates new descripti... Katja Luther
01:11 PM Revision d5cf212e (cdmlib): ref #10394 remove null check for HibernateProxyHelper.deproxy
Andreas Müller
01:01 PM bug #10415: WS to get polytomous keys and specimen called independend of portal configuration
Apart from the above issue the implementation seems to be correct and the 2 WS calls for keys and specimen are remove... Andreas Müller
12:36 PM bug #10415: WS to get polytomous keys and specimen called independend of portal configuration
I could not find any /mediaKey or /multiAccessKey entry in the edit-production todays apache logfiles. So I do not kn... Andreas Müller
12:02 PM bug #10415 (Feedback): WS to get polytomous keys and specimen called independend of portal configuration
The original trigger for this ticket was flora of mexico reporting many many calls of /cdmserver/cdm_flora_mexico/med... Andreas Müller
08:43 AM feature request #10387 (Closed): Show transliteration of common name in dataportal
This works now as expected. Andreas Müller

10/18/2023

10:44 PM feature request #10387: Show transliteration of common name in dataportal
NaK:
was haltet Ihr davon:
Αλλο όνομα [Allo ónoma], Greek
Мя́тлик одноле́тний [Myátlik odnolétniy], Russia...
Andreas Müller
03:59 PM feature request #10387: Show transliteration of common name in dataportal
Andreas Müller wrote in #note-4:
> It does not yet work for E+M which uses CommonNameDto. I added transliteration to...
Andreas Müller
03:38 PM feature request #10387: Show transliteration of common name in dataportal
AM:
... Eine erste Implementierung haben wir gerade gemacht, z.B. https://test.e-taxonomy.eu/dataportal/preview/cy...
Andreas Müller
03:31 PM feature request #10387: Show transliteration of common name in dataportal
Example for non-dto: https://test.e-taxonomy.eu/dataportal/preview/cyprus/cdm_dataportal/taxon/336a8807-05e1-4922-b5c... Andreas Müller
03:19 PM feature request #10387: Show transliteration of common name in dataportal
It does not yet work for E+M which uses CommonNameDto. I added transliteration to the DTO and the loader. Waiting for... Andreas Müller
10:42 PM Revision 4677e296 (cdm-dataportal): ref #10387 adapt formatting for transliteration to user comments
Andreas Müller
03:55 PM bug #10416 (Closed): In dto taxon page title for autonyms missing subsp. part
Works as expected. Tested on new taxon with https://test.e-taxonomy.eu/dataportal/preview/euromed/cdm_dataportal/taxo... Andreas Müller
03:17 PM Revision 9d37d3f4 (cdmlib): ref #10385, ref #10387 add transliteration to CommonNameDto
Andreas Müller
01:45 PM bug #10394 (Resolved): Details page for derived unit only shows categorical data
I adapted the QuantitativeDataDescriptionBuilder, an example for review can be find here:
https://test.e-taxonomy.eu...
Katja Luther
01:17 PM task #10414: Remove Georgian subdivisions from Euro+Med
More general deduplication: (also exchange "IS NULL" by " = "
~~~
SELECT dist_id, nameCache, source_id1, source...
Andreas Müller
11:48 AM Revision a5177b9f (cdmlib): ref #10394: fix QuantitativeDataDescriptionBuilder
Katja Luther
10:22 AM bug #10415: WS to get polytomous keys and specimen called independend of portal configuration
Katja Luther wrote in #note-1:
> This is implemented for specimen and polytomous keys, maybe there are other WS, but ...
Andreas Müller
09:06 AM bug #10415 (Resolved): WS to get polytomous keys and specimen called independend of portal configuration
This is implemented for specimen and polytomous keys, maybe there are other WS, but in the course of the new dto impl... Katja Luther
08:46 AM Revision 30dbf308 (cdm-dataportal): fix non-object exception
Katja Luther
08:43 AM Revision 913a4b80 (cdm-dataportal): fix non-object exception
Katja Luther

10/17/2023

06:34 PM Revision 52cf965e (cdmlib): ref #10410: adapt test
Katja Luther
06:06 PM task #10414 (Resolved): Remove Georgian subdivisions from Euro+Med
The automated part of this ticket should be fixed. The remaining issues with multiple distributions with differing st... Andreas Müller
04:59 PM task #10414: Remove Georgian subdivisions from Euro+Med
Deduplicating Euro+Med Import sources:
~~~sql
-- source_id, dist_id, dist_id2 , --, nameCache, taxon, st
-- d...
Andreas Müller
03:07 PM bug #10416 (Resolved): In dto taxon page title for autonyms missing subsp. part
This should be fixed, please review. Katja Luther
03:06 PM bug #10416 (Closed): In dto taxon page title for autonyms missing subsp. part
Katja Luther
03:03 PM Revision e5ec62f0 (taxeditor): ref #10410: add preference and adapt checklist editor
Katja Luther
03:01 PM Revision f1be303f (cdmlib): ref #10410: adapt dto creation
Katja Luther
12:56 PM Revision ca929e29 (taxeditor): ref #5973: newly created desc are default if no other default exists
Katja Luther
12:25 PM Revision 305ec296 (cdmlib): ref #10397: check also for typespecimen
Katja Luther
11:28 AM Revision 8c18567f (cdm-dataportal): ref #10415: do not call PK WS everytime
Katja Luther
10:53 AM bug #10415 (Closed): WS to get polytomous keys and specimen called independend of portal configuration
To know whether the polytomous key tab should be shown, the WS to get the polytomous keys is called and if no PK are ... Katja Luther

10/16/2023

04:21 PM feature request #10398 (Resolved): Make it configurable in ABCD import if identifications should be imported as determinations or individualAssociations or both
please review Katja Luther
03:15 PM bug #10409: Default application language should be English
Andreas Müller wrote in #note-9:
> There is still commented code in PreferenceUtil in checkDefaultLanguage() and get...
Katja Luther
03:11 PM feature request #10387 (Resolved): Show transliteration of common name in dataportal
There is a first implementation with {common name}/{transliteration available}. Please review. Katja Luther
03:09 PM Revision caf5c45a (cdm-dataportal): ref #10387: add transliteration to common name in data portal
Katja Luther
12:59 PM Revision 19c32a0c (cdmlib): ref #10397: add check for IndividualsAssociation
Katja Luther
12:48 PM Revision 99373e2e (cdm-dataportal): fix display of autonyms
Katja Luther

10/13/2023

10:51 PM task #10414: Remove Georgian subdivisions from Euro+Med
Excel update statement
~~~
="UPDATE OriginalSourceBase SET sourcedElement_id = " & distId2 & " WHERE id = " & sou...
Andreas Müller
09:53 PM task #10414: Remove Georgian subdivisions from Euro+Med
exact duplicate sources
~~~sql
SELECT source_id FROM (
SELECT osb.id source_id, deb.id dist_id, n.nameCache, de...
Andreas Müller
12:29 PM feature request #10364: Implement state modifiers for matrix
Andreas Müller wrote in #note-15:
> Ahh, ok, so the modifiers work now (and hiding them if not available is also a g...
Katja Luther
12:04 PM Revision 8eca5e6a (taxeditor): ref #10364: set focus to newly created status dropdown
Katja Luther
11:27 AM Revision b2aac79d (taxeditor): ref #10364: label of noData and handling of empty modifier selection
Katja Luther
10:22 AM Revision af62e445 (taxeditor): ref #10364: move add button to the right and refresh after remove line
Katja Luther
09:18 AM Revision ba233e15 (taxeditor): code cleanup
Katja Luther
08:09 AM bug #10409: Default application language should be English
Andreas Müller wrote in #note-10:
> It generally works. After restart the language stays as selected before. After ne...
Katja Luther
07:53 AM Revision 4a2d61fe (cdmlib): ref #10397: revert continue
Katja Luther
07:53 AM Revision 5b289f85 (cdmlib): ref #10397: revert last changes - continue
Katja Luther

10/12/2023

06:14 PM bug #10409: Default application language should be English
It generally works. After restart the language stays as selected before. After new installation the language is Engli... Andreas Müller
06:10 PM bug #10409 (Feedback): Default application language should be English
There is still commented code in PreferenceUtil in checkDefaultLanguage() and getPreferredDefaultLanguage(). Is this ... Andreas Müller
05:56 PM feature request #10364: Implement state modifiers for matrix
Andreas Müller wrote in #note-16:
> >Generally I guess as we need the possibility for multiple lines and for 2 field...
Katja Luther
01:53 PM feature request #10364: Implement state modifiers for matrix
>Generally I guess as we need the possibility for multiple lines and for 2 fields it might be better to put the label... Andreas Müller
01:45 PM feature request #10364: Implement state modifiers for matrix
Ahh, ok, so the modifiers work now (and hiding them if not available is also a good idea).
So it is no regression,...
Andreas Müller
12:42 PM feature request #10364: Implement state modifiers for matrix
Andreas Müller wrote in #note-12:
> I don't understand how to enter a second status with this implementation. As this...
Katja Luther
12:34 PM feature request #10364: Implement state modifiers for matrix
Minor issue: label of the dialogue should be "Enter new value(s)" Andreas Müller
12:32 PM feature request #10364: Implement state modifiers for matrix
I don't understand how to enter a second status with this implementation. As this is a regression compared to the cur... Andreas Müller
05:53 PM Revision 7919b6d3 (taxeditor): ref #10364: add + button to add more than one status
Katja Luther
05:21 PM task #10414: Remove Georgian subdivisions from Euro+Med
Differing status
~~~sql
SELECT deb.id, n.nameCache, deb.area_id, t.titleCache, st.titleCache
FROM DescriptionEle...
Andreas Müller
12:12 PM task #10414 (In Progress): Remove Georgian subdivisions from Euro+Med
Andreas Müller
04:26 PM Revision 29c0da4b (taxeditor): ref #10364: set status row invisible if data unavailable status is
chosen Katja Luther
03:53 PM Revision e53dd7fa (taxeditor): ref #10364: change order of modifier and status in dialogue
Katja Luther
03:48 PM Revision 17447324 (taxeditor): ref #10364: move the label above status and modifier combos
Katja Luther
03:11 PM Revision b7d17f42 (taxeditor): remove termDtocombo from formFactory
Katja Luther
02:57 PM Revision ad9bd5eb (taxeditor): using kindOf for checking of subtype
Katja Luther
02:30 PM Revision fc6f5583 (taxeditor): allow also term vocs of modifier hierarchy
Katja Luther
12:49 PM Revision fec775ec (taxeditor): avoid NPE
Katja Luther
12:29 PM feature request #10362: Implement noDataStatus in matrix and details view
"No Data available" => either do Data->data or available->Available, depending what is more consistent with TaxEditor... Andreas Müller
12:22 PM feature request #10362 (Feedback): Implement noDataStatus in matrix and details view
When a no-data-available value is selected, the Status label and the delete button (and all other components like mod... Andreas Müller
12:24 PM Revision 68af0673 (cdmlib): ref #2975 for label for not interpretable
Andreas Müller
10:39 AM Revision a5431e1c (cdmlib): ref #10397: revert last changes
Katja Luther
08:48 AM Revision 30dc81c7 (cdmlib): ref #10398: adapt test to new configurator attribute
Katja Luther
 

Also available in: Atom