Project

General

Profile

Activity

From 11/27/2022 to 12/26/2022

12/26/2022

11:58 PM Revision 6745191b (cdmlib): cleanup
Andreas Müller
10:17 PM Revision 6f2fdbed (cdmlib): cleanup
Andreas Müller
10:00 PM Revision 106be861 (cdmlib): cleanup
Andreas Müller
09:54 PM Revision d895f2bb (cdmlib): cleanup
Andreas Müller
08:17 PM Revision 848a0d7d (cdmlib): cleanup
Andreas Müller
08:11 PM Revision 9c90cb9c (taxeditor): fix logging in service proxy
Andreas Müller
08:00 PM Revision 052b7a05 (cdmlib-apps): adapt app-import and pesi to latest changes in cdmlib
Andreas Müller
07:59 PM Revision 6bbb9326 (cdmlib-apps): cleanup
Andreas Müller
07:43 PM Revision 71477484 (taxeditor): cleanup
Andreas Müller
07:42 PM Revision b01f9126 (cdm-vaadin): cleanup
Andreas Müller
07:34 PM Revision 2f3aa2b9 (cdmlib): cleanup
Andreas Müller
04:21 PM Revision a6261600 (cdmlib): cleanup
Andreas Müller
02:00 PM Revision 51a4c26c (cdmlib): cleanup
Andreas Müller
01:09 PM Revision d74319f1 (cdmlib): cleanup and javadoc
Andreas Müller
01:06 PM task #10215 (New): Updates, upgrades and cleanup 2024
All tasks that should be considered during the 2024 updates, upgrades and cleanup sprint.
Upgrades to latest versi...
Andreas Müller

12/23/2022

12:27 AM Revision 6f08293c (cdmlib): cleanup
Andreas Müller

12/22/2022

11:02 AM bug #10138: Details view is not updated after freetext change
Katja Luther wrote in #note-18:
> Andreas Müller wrote in #note-16:
> > As far as I can see the event throwing not ...
Andreas Müller

12/21/2022

02:27 PM Revision fef39755 (taxeditor): ref #10138: handle selection of empty media or factual data view
Katja Luther
02:21 PM bug #8381 (Closed): Closing the details view throws widget is disposed exception
This exception is thrown by our own code, so I remove the try catch because then the WidgetIsDisposedExcpetion will b... Katja Luther
01:19 PM bug #10214: Cache configuration for term cache not correctly initialized in taxeditor
Also it is unclear why single instances of CdmServiceCachingProxy to all use the static DEFAULT_CACHE_NAME from the b... Andreas Müller
01:13 PM bug #10214 (Closed): Cache configuration for term cache not correctly initialized in taxeditor
This results in short time-to-live and time-to-idle values (and maybe others) as values are taken from default ehCach... Andreas Müller
11:43 AM Revision 14473bb6 (taxeditor): cleanup and renaming for caching
Andreas Müller
11:19 AM Revision 4a718660 (cdm-vaadin): cleanup and renaming for caching
Andreas Müller
11:18 AM Revision 7035cc5a (cdmlib): cleanup and renaming for caching
Andreas Müller
10:42 AM bug #10211 (Closed): Add categorical and quantitative data to cdm light export
export looks ok. Katja Luther
10:41 AM Revision cf3f15d3 (cdmlib): ref #10211: remove new FormatKey[] {}
Katja Luther
10:35 AM bug #8591 (In Progress): Multiple representations problem on setting synonym as basionym
Katja Luther
10:32 AM bug #10138 (In Progress): Details view is not updated after freetext change
Andreas Müller wrote in #note-16:
> As far as I can see the event throwing not happens additionally to the event thr...
Katja Luther
10:09 AM feature request #10202 (Resolved): Allow entering specimen in fact sources in taxeditor
Andreas Müller wrote in #note-11:
> When recreating details view the state is not yet evaluated. So if a reference e...
Katja Luther
10:08 AM Revision 57204e91 (taxeditor): ref #10202: disable reference or specimen selection
Katja Luther
09:47 AM Revision 114109ef (cdmlib): ref #10211: minor
Katja Luther
12:03 AM Revision 20cbb1bf (taxeditor): cleanup
Andreas Müller
12:01 AM Revision fbd332d3 (cdmlib): cleanup
Andreas Müller

12/20/2022

10:50 PM bug #10204 (Closed): GBIF search does not work due to missing json-lib
According to KL this works now. Reverting 4 dependencies is handled in #10205 so we can close this ticket. Andreas Müller
10:45 PM feature request #10199 (Closed): Implement multi-select for terms in term vocabulary editor
Seems to work now as expected Andreas Müller
03:23 PM Revision ec4e915f (taxeditor): ref #10186 fix incorrect isInDelay handling in SelectionDelay
Andreas Müller
02:10 PM bug #10138 (Feedback): Details view is not updated after freetext change
Can you please check this in detail. Andreas Müller
02:08 PM bug #10138: Details view is not updated after freetext change
As far as I can see the event throwing not happens additionally to the event thrown by selection change. We need to c... Andreas Müller
02:02 PM Revision 94fccb8a (taxeditor): ref #10138 disable REFRESH_DETAILS
Andreas Müller
02:02 PM Revision 253231ca (taxeditor): cleanup
Andreas Müller
01:31 PM feature request #10202 (Feedback): Allow entering specimen in fact sources in taxeditor
When recreating details view the state is not yet evaluated. So if a reference exists already it is still possible to... Andreas Müller
11:07 AM feature request #10202 (Resolved): Allow entering specimen in fact sources in taxeditor
Andreas Müller wrote in #note-9:
> Katja Luther wrote in #note-8:
> > Andreas Müller wrote in #note-7:
> > > This ...
Katja Luther
10:47 AM feature request #10202: Allow entering specimen in fact sources in taxeditor
Katja Luther wrote in #note-8:
> Andreas Müller wrote in #note-7:
> > This generally works. During review I only wo...
Andreas Müller
09:39 AM feature request #10202: Allow entering specimen in fact sources in taxeditor
Andreas Müller wrote in #note-7:
> This generally works. During review I only wonder where to put it and how to hand...
Katja Luther
01:13 PM Revision c042e8ee (cdmlib): ref #10182, ref #2506 add notNull to OccurrenceStatus.type to avoid meaningless status
Andreas Müller
12:44 PM bug #10211 (Resolved): Add categorical and quantitative data to cdm light export
Andreas Müller
12:19 PM Revision 40ee2212 (taxeditor): ref #10204, ref #9359 add beanutils and commons-collections to taxeditor buildproperties again -continue
Katja Luther
11:48 AM Revision 387a5e68 (taxeditor): ref #10204, ref #9359 add beanutils and commons-collections to taxeditor buildproperties again
Katja Luther
10:58 AM Revision beab159a (taxeditor): ref #10204, ref #9359 add beanutils and commons-collections to taxeditor pom again
Katja Luther
10:23 AM Revision 55d0a6a4 (cdmlib): Add referencing object formatter for term nodes
Andreas Müller
09:45 AM Revision 446b26b9 (taxeditor): ref #10202: disable specimen selection or reference selection if the other possibility is already used
Katja Luther
09:25 AM feature request #10212 (Closed): Add usePlural to StateData
adapted formatters in cdmlib. I guess this can be closed. Andreas Müller
09:24 AM Revision 49ab0cec (cdmlib): ref #10201 remove SynonymType.csv
Andreas Müller
09:24 AM Revision aa1e840e (cdmlib): ref #10212 adapt formatters to usePlural
Andreas Müller
09:02 AM feature request #10213 (New): Adapt taxeditor to use StateData.usePlural
see #10212
In TaxEditor we may show both normal and plural label in combobox as 2 entries if a plural form exists....
Andreas Müller
08:54 AM Revision d6f98023 (cdmlib): ref #10201 add vocabulary removal for synonym types
Andreas Müller
08:49 AM Revision df6f5a8b (taxeditor): ref #10204, ref #9359 add ezmorph to taxeditor pom again
Katja Luther
06:30 AM Revision 4633b33a (cdmlib): cleanup
Andreas Müller
06:22 AM Revision 6d38d5c2 (cdmlib): cleanup
Andreas Müller

12/19/2022

09:33 PM Revision 611f5f1f (taxeditor): ref #10204, ref #9359 add json-lib to taxeditor pom again
Andreas Müller
04:52 PM Revision 35a9827b (cdm-vaadin): ref #10212 update test H2 for vaadin
Andreas Müller
04:51 PM Revision d33badd8 (taxeditor): ref #10212 update test H2 for taxeditor
Andreas Müller
04:50 PM feature request #10212 (Resolved): Add usePlural to StateData
Applied in changeset commit:cdmlib|3a935f11615fe5bb21d9e1bd00858d057cb1ba77. Andreas Müller
04:03 PM feature request #10212 (In Progress): Add usePlural to StateData
Andreas Müller
04:03 PM feature request #10212 (Closed): Add usePlural to StateData
To allow having only 1 state/structure for the same thing. But only distinguish correct representation in StateData b... Andreas Müller
04:50 PM Revision 3a935f11 (cdmlib): fix #10212 add usePlural to StateData
Andreas Müller
03:54 PM Revision 9db3e365 (cdmlib): ref #10194 fix FullCoverageDataGenerator for new constraint
Andreas Müller
03:39 PM bug #10198: Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Moving in TaxEditor now works as expected.
There is still an issue that orderindex misses some numbers in between ...
Andreas Müller
01:55 PM bug #10198 (Resolved): Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
I debugged now in TaxEditor with rem_conf_am NamedArea voc "Test sorting". Moving "Europe2" below Land3 (eclipse View... Andreas Müller
01:32 PM bug #10198 (Feedback): Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Katja Luther wrote in #note-7:
> Also tested move and delete in TaxEditor.
> @AM: Please review the move with posit...
Andreas Müller
03:31 PM bug #10191: Error message on taxon specimen page for non-atomized specimens
Looks fine.
We should do a final review on production after release.
Andreas Müller
01:21 PM bug #10191 (Resolved): Error message on taxon specimen page for non-atomized specimens
For unatomized field unit informations the label covers only the rows of field unit information, please review. Katja Luther
03:27 PM feature request #10194: Allow specimens as source for factual data
Added constraint that either reference or specimen can have a value but not both. Andreas Müller
03:26 PM Revision df718639 (cdmlib): ref #10194 add either reference or specimen constraint
Andreas Müller
03:24 PM Revision a17b3f58 (cdmlib): cleanup
Andreas Müller
02:32 PM feature request #10202 (Feedback): Allow entering specimen in fact sources in taxeditor
This generally works. During review I only wonder where to put it and how to handle it best.
My suggestion is to m...
Andreas Müller
02:22 PM feature request #10202: Allow entering specimen in fact sources in taxeditor
Katja Luther wrote in #note-3:
> Added the field, the preference is still missing.
This seems to be implemented i...
Andreas Müller
02:04 PM Revision 2e748910 (cdmlib): ref #10198 revert 6b68bfb9 (before and after handling in moveTerm)
Andreas Müller
02:03 PM Revision 4356940e (cdmlib): ref #10198 use more intuitive parameter names and cleanup
Andreas Müller
01:46 PM bug #10211 (Feedback): Add categorical and quantitative data to cdm light export
Code looks ok though using "new FormatKey[] {}" is not necessary I think. Better use null (this is all work-in-progre... Andreas Müller
12:18 PM bug #10211: Add categorical and quantitative data to cdm light export
Andreas Müller wrote in #note-1:
> For review?
Yes, please review.
Katja Luther
11:48 AM bug #10211 (Resolved): Add categorical and quantitative data to cdm light export
For review? Andreas Müller
11:43 AM bug #10211 (Closed): Add categorical and quantitative data to cdm light export
Categorical and quantitative data are still missing in cdmLight export, this should be implemented. Katja Luther
01:41 PM Revision 8369bf53 (taxeditor): ref #10204: minor
Katja Luther
01:27 PM bug #10204: GBIF search does not work due to missing json-lib
There is still this error message:
net.sf.ezmorph.Morpher cannot be found by eu.etaxonomy.taxeditor.cdmlib_5.35.0....
Katja Luther
01:07 PM Revision 8a2d7112 (cdm-dataportal): ref #10191: for not atomized field unit data, label should cover only the fieldunit rows - continue
Katja Luther
12:37 PM Revision cfc50709 (cdm-dataportal): ref #10191: for not atomized field unit data, label should cover only the fieldunit rows
Katja Luther
12:17 PM Revision 2c701369 (cdmlib): cleanup
Andreas Müller
12:12 PM Revision 73afc4bc (cdmlib): cleanup
Andreas Müller
11:58 AM bug #10192 (Closed): External Links do not work in E+M
The answers of the users were all that the new solution is ok or even better, so we can close this ticket. Katja Luther
11:44 AM Revision afdf0ae6 (cdmlib): ref #10211: add categorical and quantitative data to cdmlight export
Katja Luther
11:19 AM feature request #10133: Improve ontology state vocabularies
For moving states to structures I used:
~~~
UPDATE DefinedTermBase
SET vocabulary_id = 216, titleCache = REPLACE (ti...
Andreas Müller
11:17 AM feature request #10133: Improve ontology state vocabularies
State vocabularies are currently not correctly ordered because the vocs are not OrderedTermVocs:
~~~
SELECT *
FR...
Andreas Müller
11:09 AM feature request #10210 (New): UI for configuring condensed distribution string via separate parameters
Currently one can only choose from the 2 recipies (E+M, Cuba) but cdmlib allows already detailed configuration (see C... Andreas Müller
11:05 AM bug #9987: Handle areas of different vocabularies in comparator
Additionally we should offer to use term trees instead of vocabularies. Andreas Müller
10:56 AM Revision 7b092ee8 (taxeditor): minor
Katja Luther
10:33 AM Revision cf8302dc (taxeditor): add warning that taxa will be deleted with all factual data
Katja Luther
10:24 AM bug #6163: can't add media to observation/specimen anymore
Is this still an open issue?
Andreas Müller

12/17/2022

12:13 PM task #10208 (New): only use cacher for static terms
In DefinedTermBase we have cacher and termMap for static access to terms. We should unify this.
The TermLoader sho...
Andreas Müller
01:31 AM feature request #10194 (Closed): Allow specimens as source for factual data
Andreas Müller
12:49 AM bug #10207 (New): Out-Of-Memory error when working with vocabularies
NoK:
nach einer Weile des Arbeitens im Vokabular geht die Anwendung out-of-memory; die meisten Änderungen werden a...
Andreas Müller

12/16/2022

08:47 PM feature request #10206 (Closed): Add publish flag to description base
WGB:
wir haben den Fall von Rovaeanthus strigosus (Benth.) Borhidi
Dort gibt es jetzt 3 factual datasets:

![]...
Andreas Müller
06:30 PM bug #10197 (In Progress): Show empty page for delay while updating
Andreas Müller
06:28 PM feature request #9584 (Closed): specimen page: character data displayed in details section
Andreas Müller
05:32 PM feature request #9584: specimen page: character data displayed in details section
demo2 portals using the develop branch now, so you can test here: https://ws2.cybertaxonomy.org/dataportal/greece_bup... Katja Luther
04:54 PM Revision fee81e58 (taxeditor): temporary revert the removal of json library
Katja Luther
04:44 PM bug #10138 (Resolved): Details view is not updated after freetext change
this should be fixed, please review. Katja Luther
02:37 PM bug #10138 (Feedback): Details view is not updated after freetext change
This is probably fixed but not yet commited. Andreas Müller
04:33 PM Revision e751faa2 (taxeditor): ref #10138: after parsing send event to update the details view - continue
Katja Luther
04:23 PM Revision 0b449ec9 (taxeditor): code cleaning
Katja Luther
04:21 PM Revision e5c1cf57 (taxeditor): more information and better about specimen in gbif search view
Katja Luther
04:19 PM Revision 76d3226c (taxeditor): ref #10138: after parsing send event to update the details view
Katja Luther
02:55 PM bug #8591 (Feedback): Multiple representations problem on setting synonym as basionym
If we don't manage for 5.35 please set back to new or inProgress. Andreas Müller
02:52 PM bug #8381 (Resolved): Closing the details view throws widget is disposed exception
Andreas Müller
02:47 PM bug #10053 (In Progress): Problems with saving of secundum references
KL could not reproduce anymore. I will test if I can reproduce. Andreas Müller
02:44 PM feature request #10199 (Resolved): Implement multi-select for terms in term vocabulary editor
Katja Luther
02:44 PM feature request #10199 (In Progress): Implement multi-select for terms in term vocabulary editor
Katja Luther
02:42 PM bug #10162: Problems when deleting names involved in a namerelationship
We need to check the delete name function but it is not clear if this happened really during name delete or due to in... Andreas Müller
02:33 PM bug #10111 (Resolved): Data loss e.g. when entering type information
I will try to reproduce Andreas Müller
02:27 PM bug #10054 (In Progress): Changes on secundum reference are lost after changing status to basionym
KL could not reproduce anymore. I will test if I can reproduce. Andreas Müller
02:25 PM bug #10186: Problems with session handling in taxeditor
Katja Luther wrote in #note-5:
> SetSelection in setFocus of TaxonNameEditorE4 is not necessary and yields to a seco...
Andreas Müller
02:21 PM task #10189 (Closed): Split CdmApplicationController into repository and application part
Andreas Müller
02:19 PM task #9975 (Resolved): Create new UML diagramms for the CDM
please review Andreas Müller
02:17 PM bug #10190 (Closed): Invalid argument supplied for foreach() in order_fieldUnitDtos_by_date_and_type()
Andreas Müller
02:15 PM feature request #10202 (Resolved): Allow entering specimen in fact sources in taxeditor
Andreas Müller
09:50 AM feature request #10202 (In Progress): Allow entering specimen in fact sources in taxeditor
Andreas Müller
09:03 AM feature request #10202: Allow entering specimen in fact sources in taxeditor
Added the field, the preference is still missing. Katja Luther
02:06 PM feature request #10196: Hybrid structure-state terms
Can you please review. When done we can create a ticket for the remaining open issue. Andreas Müller
01:54 PM bug #10192: External Links do not work in E+M
It works now, but it changed from using popups to opening a new tab which is maybe not wanted (there might be a reaso... Andreas Müller
01:14 PM bug #10192: External Links do not work in E+M
Andreas Müller wrote in #note-5:
> How can I test this? It is not yet pushed to production, or? And on test the upda...
Katja Luther
01:43 PM Revision f49c0c13 (taxeditor): ref #10202: add preference handling
Katja Luther
01:42 PM Revision f04331a1 (cdmlib): ref #10202: add preference predicate
Katja Luther
01:42 PM bug #10204 (Resolved): GBIF search does not work due to missing json-lib
Should be fixed. Please review finally on nightly.
Json update moved to #10205
Andreas Müller
01:34 PM bug #10204 (In Progress): GBIF search does not work due to missing json-lib
probably fixed by adding missing dependencies, but we should upgrade to a more modern json framework Andreas Müller
01:37 PM task #10205 (Closed): Update GBIF import to modern json library.
... after fixing do not forget to remove 4 dependencies again. See commit:taxeditor|f60a1e5ffb4425d1f Andreas Müller
01:34 PM Revision 59ae0b13 (taxeditor): cleanup
Andreas Müller
10:11 AM Revision 3b530403 (cdmlib): adapt test to using https for gbif webservice
Katja Luther
09:02 AM Revision 3fe61023 (taxeditor): ref #10202: add field for specimen in description element source
Katja Luther
08:11 AM bug #10198: Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Also tested move and delete in TaxEditor.
@AM: Please review the move with position method.
Katja Luther

12/15/2022

03:34 PM Revision f60a1e5f (taxeditor): ref #10204: revert remove of json and other libraries
Katja Luther
03:27 PM Revision 4ea78047 (cdmlib): ref #10204: code cleaning
Katja Luther
03:27 PM Revision acbded93 (cdmlib): ref #10204: catch media parsing exceptions and code cleaning
Katja Luther
03:25 PM bug #10204 (Closed): GBIF search does not work due to missing json-lib
The Gbif search does not work in editor because some of the removed libraries are needed.
Katja Luther
09:58 AM Revision 988163c8 (cdmlib): fix missing treeIndex in TaxonNodeDto
Katja Luther

12/14/2022

10:54 PM feature request #10196: Hybrid structure-state terms
This is more or less fixed now and tested in Character editor and in matrix.
Not yet tested in PolytomousKeys(need...
Andreas Müller
11:30 AM feature request #10196 (Resolved): Hybrid structure-state terms
This should be mostly ready. Still need to handle open issues and test in TaxEditor (add voc to characters and in mat... Andreas Müller
09:48 PM Revision ad098825 (cdmlib): ref #10196 remove fixmes and replace by todos where minor open issues are
Andreas Müller
08:42 PM bug #10191: Error message on taxon specimen page for non-atomized specimens
NoK:
https://test.e-taxonomy.eu/dataportal/preview/cichorieae/cdm_dataportal/taxon/b335ceee-d6c1-4c93-841d-3b4bd27...
Andreas Müller
11:28 AM bug #10191 (Feedback): Error message on taxon specimen page for non-atomized specimens
This is definetely much better than before as the error messages are not shown anymore and the fields are filled with... Andreas Müller
08:32 PM Revision 070e2256 (cdmlib): ref #10196 further adapt IOs and service layer to hybrid states
Andreas Müller
08:16 PM Revision 17b5d25f (cdmlib): cleanup
Andreas Müller
08:02 PM Revision a183be96 (cdmlib): ref #10196 fix state and character/feature handling in RowWrapperDTO and description save
* by casting not filtering for term class Andreas Müller
07:59 PM Revision 3ccbd660 (cdmlib): cleanup
Andreas Müller
06:15 PM Revision 2bf2296c (taxeditor): ref #10196 allow Structures for StateVocabularyDtoCollectionElement
Andreas Müller
04:27 PM Revision b07fb70b (cdmlib): ref #10196 fix by findVocabulary by termtype list
Andreas Müller
03:24 PM Revision 7e47e3ba (cdmlib): cleanup
Andreas Müller
03:12 PM Revision 7205d591 (cdmlib): cleanup
Andreas Müller
03:00 PM Revision e4d54229 (cdmlib): cleanup
Andreas Müller
01:49 PM bug #10198: Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Katja Luther wrote in #note-5:
> Andreas Müller wrote in #note-4:
> > Can you please review?
> >
> > This should...
Katja Luther
01:34 PM Revision 6b68bfb9 (cdmlib): ref #10198: implement test for moveTerm and fix move with position
Katja Luther
11:47 AM Revision da1315f1 (cdmlib): ref #6794 add deprecation and javadoc to OrderedTermVocabulary methods
Andreas Müller
11:45 AM bug #10190 (Feedback): Invalid argument supplied for foreach() in order_fieldUnitDtos_by_date_and_type()
Generally this is fixed. The result can be seen on test e.g. at https://test.e-taxonomy.eu/dataportal/preview/cichori... Andreas Müller
11:42 AM Revision 40d3f39f (cdmlib): ref #10190 cleanup null check a bit
Andreas Müller
11:42 AM Revision b4f3c9fb (cdmlib): cleanup
Andreas Müller
11:04 AM bug #10192 (Feedback): External Links do not work in E+M
How can I test this? It is not yet pushed to production, or? And on test the updates are not yet installed as far as ... Andreas Müller
10:41 AM feature request #10194: Allow specimens as source for factual data
I guess we can close this ticket. Can you please do final review. Please also consider implementation in TaxEditor (#... Andreas Müller
10:39 AM feature request #10203 (New): Show specimen sources in publications
... (dataportal and print publication)
for details see #10194
Andreas Müller
10:36 AM feature request #10202 (Closed): Allow entering specimen in fact sources in taxeditor
... as an alternative to references. This was implemented in the model in #10194.
Maybe we should have a preferenc...
Andreas Müller
10:05 AM Revision 9e2e5157 (taxeditor): use TermTree.newFeatureInstance instead of newInstance
Katja Luther
09:22 AM Revision d59a2277 (cdmlib): cleaup and remove deprecated methods from TermTree
Andreas Müller
01:33 AM task #10201 (Resolved): Make synonym type an enum
still need to test taxeditor and fix dozer test Andreas Müller
12:40 AM Revision 1a16c318 (taxeditor): ref #10201 make synonym type an enum in taxeditor (adapt combo element)
Andreas Müller
12:33 AM Revision 73e75270 (cdmlib): ref #10201 make synonym type an enum in cdmlib (adapt dataset.dtd)
Andreas Müller
12:32 AM Revision 9451f4aa (cdm-vaadin): ref #10201 make synonym type an enum in vaadin (cont.)
Andreas Müller
12:09 AM Revision 1126d2a5 (cdm-vaadin): ref #10201, ref #10194 adapt testH2 in vaadin
Andreas Müller
12:09 AM Revision 4f3bf065 (taxeditor): ref #10201, ref #10194 adapt testH2 in taxeditor
Andreas Müller
12:07 AM Revision f0fda4e4 (cdmlib): ref #10201, ref #10194 adapt testH2 to cdmlib
Andreas Müller
12:00 AM Revision 88be1bfd (cdm-vaadin): ref #10201 make synonym type an enum in vaadin
Andreas Müller

12/13/2022

11:36 PM Revision 0905498c (cdmlib): ref #10194 fix missing specimen_id in test data
Andreas Müller
11:33 PM task #10201 (In Progress): Make synonym type an enum
Andreas Müller
04:40 PM task #10201 (Closed): Make synonym type an enum
.. as it is very stable and the representations are not really needed
Open issues:
* ~~vaadin~~
* ~~taxeditor~...
Andreas Müller
11:17 PM Revision 4821942d (taxeditor): ref #10201 Make synonym type an enum in taxeditor
Andreas Müller
11:17 PM Revision 64a6a386 (taxeditor): cleanup
Andreas Müller
11:12 PM Revision a777f3a7 (cdmlib): ref #10201 update script for synonym type change to enum
Andreas Müller
11:10 PM Revision 41e54b6e (cdmlib): cleanup
Andreas Müller
09:26 PM Revision 61d2eae8 (cdmlib): cleanup FreeTextSearchIntegrationTest incl. data
Andreas Müller
08:56 PM Revision 6029884c (cdmlib): cleanup
Andreas Müller
08:54 PM Revision 158aea27 (cdmlib): ref #10201 make synonym type an enum in cdmlib
Andreas Müller
08:54 PM Revision 1e26229c (cdmlib): cleanup
Andreas Müller
08:54 PM Revision c6365af5 (cdmlib): ref #10194 Add specimen to DescriptionElementSource (adapt test script and FullCoverageDataGenerator)
Andreas Müller
08:54 PM Revision 861b3cdc (cdmlib): ref #10194 Add specimen to DescriptionElementSource
Andreas Müller
08:54 PM Revision 67c36b25 (cdmlib): cleanup
Andreas Müller
08:53 PM Revision fbc590be (cdmlib): cleanup
Andreas Müller
01:46 PM Revision 7cf326ec (cdmlib): cleanup
Andreas Müller
12:58 PM Revision e0bcf884 (cdmlib): cleanup
Andreas Müller
12:57 PM Revision c1e0f30f (cdmlib): ref #6794 fix return type for orderindex
Andreas Müller
12:05 PM Revision 06f30d52 (taxeditor): ref #10199: adapt delete handler and operation to multi select deletion of terms
Katja Luther
12:01 PM Revision a86c1d74 (cdmlib): ref #10199: implement delete for a set of term uuids
Katja Luther
11:50 AM Revision cd05a561 (cdmlib-apps): ref #6794 remove OrderedTermBase in app-import
Andreas Müller
11:49 AM Revision c9fd74db (taxeditor): cleanup
Andreas Müller
11:49 AM Revision c10067d5 (taxeditor): ref #6794 remove OrderedTermBase from taxeditor
Andreas Müller
11:44 AM Revision 3fa6ded6 (cdmlib): cleanup
Andreas Müller
11:44 AM Revision 9c6f2a51 (cdmlib): ref #6794 remove OrderedTermBase in cdmlib
Andreas Müller
11:43 AM Revision b5bd681f (cdmlib): cleanup
Andreas Müller
11:42 AM Revision d60cb364 (cdmlib): ref #6794 helper for commit issue in OrderedTermBase removal
Andreas Müller
11:19 AM Revision b2a4c3c7 (cdm-vaadin): cleanup
Andreas Müller
10:40 AM Revision 0c6c3108 (taxeditor): ref #10199: allow multi-select for moving terms
Katja Luther
10:24 AM feature request #10199: Implement multi-select for terms in term vocabulary editor
Delete and the menu entry for moving is available only for a single term, but moving by drag & drop is already availa... Katja Luther

12/12/2022

10:42 PM Revision a7069102 (cdmlib): cleanup
Andreas Müller
05:58 PM feature request #10200 (New): Allow second vocabulary editor/view to compare vocabularies
NoK:
hilfreich wäre es auch, wenn sich ein Vokabular in 2 Fenstern öffnen ließe, damit das Vergleichen leichter is...
Andreas Müller
05:55 PM feature request #10199: Implement multi-select for terms in term vocabulary editor
Is this easy to implement? If yes, please implement in this milestone, otherwise move. Andreas Müller
05:54 PM feature request #10199 (Closed): Implement multi-select for terms in term vocabulary editor
... to move or delete terms
NoK:
was wir auf jeden Fall in Zukunft noch brauchen, ist die Verschiebung (und Lös...
Andreas Müller
04:48 PM Revision 993ef082 (cdmlib): ref #6794 Change OrderedTermBase to DefinedTermBase in CondensedDistributionComposer
Andreas Müller
04:47 PM Revision b96dcdf4 (cdmlib): cleanup
Andreas Müller
04:41 PM Revision 5a9b2f38 (taxeditor): cleanup
Andreas Müller

12/11/2022

11:20 PM Revision 81aaccdd (cdm-vaadin): cleanup
Andreas Müller
11:18 PM Revision 595fec37 (cdmlib-apps): adapt e-flora, pesi and app-import to latest changes
Andreas Müller
01:49 AM Revision d70fff5c (cdm-vaadin): ref #6794 reduce calls to isLower and isHigher in Rank class in vaadin
Andreas Müller
01:48 AM Revision 49520df1 (cdmlib-apps): ref #6794 reduce calls to isLower and isHigher in Rank class in app-import
Andreas Müller
01:45 AM Revision e19abe68 (cdmlib): cleanup
Andreas Müller
01:34 AM Revision fc422f9b (cdmlib): ref #6794 reduce calls to isLower and isHigher in Rank class (cont.)
Andreas Müller
01:31 AM Revision ad199dcf (cdmlib): cleanup and javadoc
Andreas Müller
01:30 AM Revision 6d7382df (cdmlib): ref #6794 reduce calls to isLower and isHigher in Rank class
Andreas Müller
01:07 AM Revision 9f27f852 (cdmlib): cleanup
Andreas Müller
01:01 AM Revision 0ded1664 (cdmlib-apps): Cleanup
Andreas Müller

12/09/2022

02:48 PM bug #10198: Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Andreas Müller wrote in #note-4:
> Can you please review?
>
> This should include checking if term handling (espe...
Katja Luther
02:00 PM bug #10198: Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Can you please review?
This should include checking if term handling (especially removal) in vocabularies still wo...
Andreas Müller
12:31 PM bug #10198 (Resolved): Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
Applied in changeset commit:cdmlib|d65295b4a60c6f5ce745eb3c07fc4cda88b8c418. Andreas Müller
12:29 PM bug #10198 (Closed): Termremoval for OrderedTermVocabularies does not work correctly due to incorrect compareTo and orderIndex decrement
The termTree in OrderedTermVocabulary identifies entries via compareTo. The compareTo for OrderedTerms in the same vo... Andreas Müller
01:14 PM task #9008: Add chapter "Taxonomic concepts and source citations in the EDIT Platform" to documentation "Manual-EDIT-Platform"
WGB:
dieses Ticket ist erledigt – der Text war schon längere Zeit in Doku 4; ich habe mir nochmal die Ergänzungen ...
Andreas Müller
01:12 PM task #9008 (Closed): Add chapter "Taxonomic concepts and source citations in the EDIT Platform" to documentation "Manual-EDIT-Platform"
Andreas Müller
01:08 PM Revision 67a52da6 (taxeditor): ref #10196 adapt TaxEditor to hybrid structure states
Andreas Müller
12:35 PM Revision 880fb701 (cdmlib): minor and cleanup
Andreas Müller
12:30 PM Revision d65295b4 (cdmlib): fix #10198 fix term removal
Andreas Müller
10:55 AM Revision 427c9b3b (cdmlib): ref #10196 add methods to allow to search for vocabularies for >1 term types
Andreas Müller
10:46 AM Revision b869700f (taxeditor): cleanup
Andreas Müller
03:50 AM Revision df45fc99 (cdmlib): cleanup
Andreas Müller
03:41 AM Revision 94365b1b (cdmlib): ref #6794, ref #3327 remove *equal* methods from OrderedTermBase and -Vocabulary
Andreas Müller
03:33 AM Revision 11177ee7 (cdmlib): cleanup
Andreas Müller
03:14 AM Revision abaa6c56 (cdmlib): ref #10196 user DefinedTermBase<?> for hybrid states in cdmlib
Andreas Müller
02:03 AM Revision 131d91a0 (cdmlib): ref #10196 adapt supportedCategoricalEnumerations to hybrid states in cdmlib
Andreas Müller
02:01 AM Revision 0ebe3b3e (cdmlib): ref #10196 implement hybrid states with interface
Andreas Müller

12/08/2022

11:46 PM Revision d58b8e3f (taxeditor): cleanup
Andreas Müller
10:07 PM Revision 0f1e36bd (cdmlib): cleanup and maybe some issues related to ref #10196
Andreas Müller
06:36 PM Revision 3cdcfd06 (taxeditor): cleanup
Andreas Müller
01:43 PM Revision 574e585a (cdmlib): cleanup
Andreas Müller
11:34 AM bug #10197: Show empty page for delay while updating
One suggestion would be to clear the view until the update starts and then set the label to "Updating ... " while the... Katja Luther
11:22 AM feature request #10133: Improve ontology state vocabularies
AM:
als nächstes sollten wir uns mal die Duplikate anschauen.
Ich habe mal 2 Excel-Tabelle erstellt mit Duplika...
Andreas Müller

12/07/2022

04:42 PM feature request #10133: Improve ontology state vocabularies
AM:
Ich habe mir gerade mal angeschaut, wieviele Strukturen in dem Strukturbaum „structures 1.0“ verwendet werden (z...
Andreas Müller
01:45 PM feature request #10133: Improve ontology state vocabularies
AM:
Außerdem habe ich mir die Vokabulare nochmal angeschaut. In „structure in adjective form“ scheinen mire her Ad...
Andreas Müller
01:05 PM feature request #10133 (In Progress): Improve ontology state vocabularies
Andreas Müller
01:05 PM feature request #10133: Improve ontology state vocabularies
NoK:
* 00 Temporal Modifiers“: Die stehen nur unter structures, weil die modifiers nicht implementiert waren, könn...
Andreas Müller
03:17 PM bug #10197 (In Progress): Show empty page for delay while updating
When updating the details views the different parts should show an empty page with an explaining message. Also for ot... Katja Luther

12/06/2022

11:30 PM feature request #10133: Improve ontology state vocabularies
Analyzing the structure tree "structures 1.0" and the structure vocabularies shows that many of the structures in the... Andreas Müller
09:12 PM feature request #10196: Hybrid structure-state terms
AM:
Erstmal würde ich mir gerne nochmal ins Gedächtnis zurückrufen, inwiefern Terme beide Eigenschaften (State/Struk...
Andreas Müller
05:48 PM feature request #10196 (Closed): Hybrid structure-state terms
copied from #10133#note-1
some structures can also be used as states in a character matrix. We need to decide how ...
Andreas Müller
06:08 PM Revision 4e8bd680 (cdmlib): ref #2934, ref #4670 add moose-extensions
Andreas Müller
06:04 PM Revision 7eeaa9dc (cdmlib): cleanup
Andreas Müller
03:24 PM bug #10195: Character data should be ordered by character tree
Andreas Müller wrote in #note-7:
> Can you please check how far this is kind of a duplicate for #8657 or any other of...
Katja Luther
02:33 PM bug #10195: Character data should be ordered by character tree
Can you please check how far this is kind of a duplicate for #8657 or any other of the related tickets or how far the... Andreas Müller
02:47 PM Revision e5c6153b (taxeditor): cleanup
Andreas Müller
02:47 PM Revision 80271249 (taxeditor): javadoc
Andreas Müller
10:33 AM Revision d29a17c1 (cdm-dataportal): ref #10191: revert changes in method signature
Katja Luther
10:13 AM Revision 19255dc5 (cdm-dataportal): ref #10191: show label of fieldunit if not atmoised -continue
Katja Luther
09:05 AM bug #9629 (In Progress): Better handling of OptionalDataException
Reopen the ticket because it appeared again:
Hallo,
Caryophyllales_spp, beim Aufruf eines Synonyms aus der Suche:...
Katja Luther

12/05/2022

02:36 PM feature request #9584 (Resolved): specimen page: character data displayed in details section
Simple display of the character data added, new ticket created (#10195).
Please review this first implementation.
Katja Luther
02:28 PM feature request #9584: specimen page: character data displayed in details section
Actually to have the basic information about the existing character data in the portal I would commit the simple impl... Katja Luther
02:15 PM feature request #9584: specimen page: character data displayed in details section
There are implementations of the aggregated descriptions for the taxon page, but both representations missing informa... Katja Luther
01:22 PM feature request #9584: specimen page: character data displayed in details section
NoK:
ja, im Screenshot erscheinen die Characters in alphabetischer Reihenfolge des Character label. Die gewünschte...
Andreas Müller
12:20 PM feature request #9584: specimen page: character data displayed in details section
Actually I use the order used in the dto, need to check how this is created.
Andreas Müller wrote in #note-11:
> Nor...
Katja Luther
12:11 PM feature request #9584: specimen page: character data displayed in details section
Norbert, can you have a look on the last commit and give a comment if this is an acceptable layout?
Question from ...
Andreas Müller
11:07 AM feature request #9584 (In Progress): specimen page: character data displayed in details section
Displaying the character data in its own table would look like this:
![](Screenshot 2022-12-05 110556.png)
Katja Luther
02:35 PM bug #10195 (New): Character data should be ordered by character tree
The display of the character data in specimen details page and taxon page missing the information about the character... Katja Luther
02:30 PM Revision 52645dd4 (cdm-dataportal): ref #9584: show character data in specimen details page
Katja Luther
01:18 PM bug #10054: Changes on secundum reference are lost after changing status to basionym
Older mail from Maryam (2022-08-26) which is maybe related:
I received this email while saving the changes on sec....
Andreas Müller

12/02/2022

09:11 PM feature request #10194 (Resolved): Allow specimens as source for factual data
Andreas Müller
08:49 PM Revision f93763da (cdmlib): cleanup
Andreas Müller
02:47 PM bug #8132 (Worksforme): phycobank cdm-server instance problems with db connections
Andreas Müller
09:02 AM Revision bfffa47e (taxeditor): fix #4456: code cleaning
Katja Luther

12/01/2022

06:53 PM bug #8132 (Resolved): phycobank cdm-server instance problems with db connections
To me it seems that this problem did not occur anymore in the last years and we can close the ticket as worksforme.
...
Andreas Müller
06:42 PM bug #8170 (New): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
Andreas Müller
06:31 PM feature request #10194: Allow specimens as source for factual data
WGB:
gibt es eigentlich eine Möglichkeit, Specimen sozusagen als Referenz (Voucher) für Faktendaten zu benutzen?
Da...
Andreas Müller
06:29 PM feature request #10194 (Closed): Allow specimens as source for factual data
... and maybe others.
Think can be handled model side with existing CdmLinkSource or as explicit attribute in Desc...
Andreas Müller
01:49 PM Revision 7fc954fe (taxeditor): revert unwanted changes
Katja Luther
12:21 PM Revision 60cfeb3d (taxeditor): remove unused initialize method to make it compile
Andreas Müller
11:58 AM Revision e1dddccc (taxeditor): cleanup
Andreas Müller
11:56 AM Revision b663b23c (taxeditor): adapt to new DescriptionElementFormatter package
Andreas Müller
11:20 AM Revision 89a92d2d (cdmlib-apps): cleanup
Andreas Müller
11:18 AM Revision d86c767b (cdm-vaadin): cleanup
Andreas Müller
11:17 AM Revision 361ca821 (cdm-vaadin): rename EllypsisFormatter interface in vaadin
Andreas Müller
11:14 AM Revision 1fabfba5 (cdmlib): rename EllypsisFormatter interface
Andreas Müller
11:12 AM Revision cb9fcd29 (cdmlib): rename abstract classes and some other cleanup
Andreas Müller
09:54 AM bug #10191 (Resolved): Error message on taxon specimen page for non-atomized specimens
Please review, as test you could use the same taxon on test: https://test.e-taxonomy.eu/dataportal/preview/cichorieae... Katja Luther
09:02 AM Revision 723cf0c5 (cdm-dataportal): ref #10191: show label of fieldunit if not atmoised
Katja Luther
12:19 AM bug #10193: OutOfMemory exception when exporting mexico flora
KL, I assigend the ticket to you as you may implement the workaround solution.
If this works we may discuss how to...
Andreas Müller
12:17 AM bug #10193 (New): OutOfMemory exception when exporting mexico flora
When running CDM-l export the OOME occurred after about 85% (see logfile at about line 39.467).
A bit earlier (li...
Andreas Müller

11/30/2022

08:25 PM Revision 058c22aa (cdmlib): cleanup
Andreas Müller
08:23 PM Revision e89c358b (cdmlib): cleanup
Andreas Müller
04:15 PM bug #10191: Error message on taxon specimen page for non-atomized specimens
This is caused by not atomised specimen, so the fields of the dto are not filled. We could use the summarylabel of th... Katja Luther
03:21 PM bug #10190 (Resolved): Invalid argument supplied for foreach() in order_fieldUnitDtos_by_date_and_type()
please review Katja Luther
03:21 PM bug #10190: Invalid argument supplied for foreach() in order_fieldUnitDtos_by_date_and_type()
The problem was caused by a NPE when the taxon/name of a determination was not set. Katja Luther
03:19 PM Revision 00d2d5ef (cdmlib): ref #10190: null check for taxonname and taxon in determination
Katja Luther
02:59 PM bug #10182: Portal does not show typespecimen for duplicated typedesignation
The Editor must guarantee that OcccurenceStatus.type is never null.
Additionally, we should add NotNull to Occurre...
Andreas Müller
10:52 AM Revision 604e7242 (taxeditor): add viewer generics to AbstractCdmEditorPart, remove deprecated ViewerSorter and some other cleanup
Andreas Müller
10:02 AM bug #10192 (Resolved): External Links do not work in E+M
I removed the javascript call and add the attribute to open the link in a new tab. Please review. Katja Luther
10:01 AM Revision 1ffd7502 (taxeditor): cleanup
Andreas Müller
09:55 AM bug #7699: NPE in CdmTransientEntityCacher.getCacheElement()
Now an explicit error is thrown with message "No cache available for cacheId = xxx" and some debug information.
For n...
Andreas Müller
08:51 AM bug #7699 (In Progress): NPE in CdmTransientEntityCacher.getCacheElement()
Andreas Müller
09:53 AM Revision 38db2a51 (cdm-dataportal): ref #10192: remove javascript call and add attribute to open external link in new tab
Katja Luther
09:48 AM Revision f1c74cff (cdmlib): ref #7699 add debugging to CdmTransientEntityCacher.getCache() (cont. II)
Andreas Müller
09:24 AM Revision b4aa8a57 (cdmlib): ref #7699 add debugging to CdmTransientEntityCacher.getCache() (cont.)
Andreas Müller
08:38 AM bug #9174 (Duplicate): After longer inactivity NPE for cache
This seems to be a duplicate for #7699 Andreas Müller
01:31 AM Revision 2014062e (cdmlib): ref #7699 add debugging to CdmTransientEntityCacher.getCache()
Andreas Müller
12:51 AM Revision 674b745b (taxeditor): ref #10186, ref #9174 add method logging to CachingHttpInvokerProxyFactoryBean
Andreas Müller
12:47 AM Revision 89374cca (taxeditor): cleanup
Andreas Müller

11/29/2022

07:04 PM feature request #10156: Show field unit media in taxon image galleries
I guess this can not be handled in the current milestone, but maybe in the next one. Andreas Müller
12:48 PM bug #10192 (In Progress): External Links do not work in E+M
The problem comes from the call of "drupal_strip_dangerous_protocols("JavaScript:popupExternalLinks('url'))" inside l... Katja Luther

11/28/2022

01:23 PM task #10183 (Closed): Import Buxales via Cdm2Cdm
Andreas Müller
12:10 PM bug #10182 (In Progress): Portal does not show typespecimen for duplicated typedesignation
Andreas Müller
12:07 PM bug #10192 (Closed): External Links do not work in E+M
NaK:
die Externen Such-Links aus E+M funktionieren teilweise nicht, hinter dem Taxon-Namen bleibt immer ein Anführ...
Andreas Müller
12:04 PM bug #10186: Problems with session handling in taxeditor
Andreas Müller wrote in #note-7:
> A critical issue: In AbstractCdmEditorPartE4 line 182 it is checked if (new) sele...
Andreas Müller

11/27/2022

10:59 PM Revision 20d52c89 (taxeditor): ref #10186 fix incorrect delaySelection handling for multiselect and no active Editor
Andreas Müller
10:54 PM Revision df44f597 (taxeditor): cleanup
Andreas Müller
12:18 AM Revision dad85080 (taxeditor): ref #10186 fix incorrect delaySelection handling for equal previous selection (and remove some debugging)
Andreas Müller
 

Also available in: Atom