Project

General

Profile

Activity

From 03/22/2021 to 04/20/2021

04/20/2021

05:17 PM task #9268 (New): Check cdm for GC G1 humongous objects problem
Andreas Müller
05:14 PM feature request #9541: Improve referencing objects handling
Can you please review?
Open issues should be moved to new ticket.
Andreas Müller
05:12 PM feature request #9541: Improve referencing objects handling
open issues might be:
* improved formatting for all CdmBase classes (some formatting also seems to have regression...
Andreas Müller
05:05 PM feature request #9541: Improve referencing objects handling
What I did:
* moved all referencing objects formatting to cdmlib (ReferencingObjectFormatter) to allow server side...
Andreas Müller
01:33 PM feature request #9114: Handle malformed URIs in user type
I only moved the original algorithm to the user type. The remaining issues are about the algorithm. As you implemente... Andreas Müller
12:43 PM feature request #9114: Handle malformed URIs in user type
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > In #9111#note-1 AK suggests to also en...
Katja Luther
01:06 PM bug #9469 (Resolved): Searching for a UUID in bulkeditor which does not belong to a record throws an exception
This should be fixed. Please review. Andreas Müller
01:03 PM bug #6469 (New): Types longer than 1 line should have an indentation
revert to original status, caused by wrong ticket number in commit Andreas Müller
01:02 PM bug #6469 (Resolved): Types longer than 1 line should have an indentation
Applied in changeset commit:taxeditor|567bec6355c7624e6fac32e6523453a8c3aceb2a. Andreas Müller
12:46 PM feature request #9090: Implement external links for identifiable entities in TaxEditor
For references this is urgent (and probably easy to implement).
Can we try to implement it in 5.23?
Andreas Müller
12:44 PM bug #9156: Searching for a taxon in the PolytomousKey perspective results in AssertionFailure
This to me seems fast to implement. The problem only occurs if no search has been run in Taxonomic Perspective before... Andreas Müller
12:15 PM feature request #7305: [Dicuss] searching for authorteam with more than three members is incomplete
This is related to the max number of authors handled in this milestone. Andreas Müller
12:04 PM bug #9028: Endless loop when opening the context menu of name facts
I can't reproduce this.
Katja, can you test if you can reproduce?
Walter, did you encounter the problem again?...
Andreas Müller
11:35 AM bug #9075: Exact values in descriptive matrix label provider should be ordered
I guess this is fast to implement? If yes, should we move it to 5.23? Andreas Müller
11:32 AM bug #8882: adapt search to handle protected or not protected titleCaches
To me this looks like a bug, not a feature request. Andreas Müller
11:31 AM bug #7699: NPE in CdmTransientEntityCacher.getCacheElement()
As this problem (see also duplicates) appears again and again from time to time I increase severity. Andreas Müller
11:18 AM bug #5907: Advanced Search for taxa: search results seem to be unordered
By the way, also the feature list in "by content category" is unordered but should be ordered. Andreas Müller
11:17 AM bug #5907: Advanced Search for taxa: search results seem to be unordered
Note: Also for Cichorium it is unordered: http://cichorieae.e-taxonomy.net/portal/cdm_dataportal/search/results/taxon... Andreas Müller
10:55 AM bug #5907 (New): Advanced Search for taxa: search results seem to be unordered
I tested on the cichorieae portal to reproduce the problem reported by Eckhard in comment 3. For a query searching "C... Andreas Kohlbecker
09:45 AM bug #5907 (Feedback): Advanced Search for taxa: search results seem to be unordered
Why do you think this is fixed? The order of the example page seems to be completely unordered. Andreas Müller
08:44 AM bug #5907 (Worksforme): Advanced Search for taxa: search results seem to be unordered
this is fixed already and should be closed.
@Eckhard: please can you double check?
The target version assignme...
Andreas Kohlbecker
08:40 AM feature request #8884 (Rejected): iiif manifest service: enrich metadata with information provided by other iiif image servers
The digilib does not provide any media metadata, so this ticket is obsolete. Andreas Kohlbecker

04/19/2021

11:43 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor
A final issue is that removing the "ratio to" with titleCache not being protected does not set back the titleCache to... Andreas Müller
11:35 PM feature request #9114: Handle malformed URIs in user type
Katja Luther wrote:
> Andreas Müller wrote:
> > In #9111#note-1 AK suggests to also encode fragment and query parts...
Andreas Müller
02:40 PM feature request #9114 (Feedback): Handle malformed URIs in user type
Andreas Müller wrote:
> In #9111#note-1 AK suggests to also encode fragment and query parts. This has **not** been i...
Katja Luther
05:48 PM feature request #8708 (Feedback): Sort taxa in distribution editor same as in navigator
This to me looks like a duplicate. Katja, can you check and link to the according ticket and close ticket as duplicat... Andreas Müller
04:32 PM feature request #6598 (Closed): Migrate commands and handlers
Andreas Müller wrote:
> target version is missing!
>
> Can we assess in current milestone what still needs to be ...
Katja Luther
04:05 PM bug #8431: missing status bar for cdm light export

>
> ---
>
> Also we need to find out how to switch of that progress is only shown in status bar but not in dia...
Katja Luther
02:35 PM feature request #9111 (Rejected): Handle Malformed URIs
this is handled in cdmlib now, therefore I close this ticket as rejected. Katja Luther
02:31 PM bug #9390 (Feedback): Remaining issues for set secundum dialog
we should discuss if we want to remove the line break for all dialogs, then I create a new ticket for adaption of dia... Katja Luther

04/16/2021

10:46 PM bug #9583 (Closed): Fix formatting of parent area in condensed distributions string if subareas have various status but at least 1 area has status native
To me the result looks like expected. Reopen if not yet fully fixe. Andreas Müller
07:45 PM bug #9583 (Resolved): Fix formatting of parent area in condensed distributions string if subareas have various status but at least 1 area has status native
Applied in changeset commit:cdmlib|e2fafd15b80ee6fc8dc2cec59f0d74389ea48fe6. Andreas Müller
07:42 PM bug #9583 (Closed): Fix formatting of parent area in condensed distributions string if subareas have various status but at least 1 area has status native
This issue is described in #8297#note-15 and has not yet been handled there.
Examples are **Tu(A** -E) or **Ca**(?C ...
Andreas Müller
10:13 PM feature request #5573 (Resolved): Cache Strategy for Media Specimen required
Andreas Müller
09:49 PM feature request #9541 (Resolved): Improve referencing objects handling
Andreas Müller
09:20 PM feature request #9537 (Resolved): Implement ratioToStructure in TaxEditor
I guess this is for review. Andreas Müller
09:19 PM bug #9526 (Closed): Sort order in E+M distribution string should be strictly alphabetic
I guess this is fixed. We may reopen if new issues arise. Andreas Müller

04/15/2021

05:58 PM task #9582 (New): provide runnable dataportal installation bundled with composer
[Composer](https://getcomposer.org) is the de-facto standard for managing php dependencies.
Use composer to create...
Andreas Kohlbecker
03:05 PM task #9579 (Worksforme): restore css3pie if needed
It is working again with compass 0.12.7 on the integration server as well as locally.
The error documented in the ...
Andreas Kohlbecker
12:29 PM feature request #9570 (Closed): Use tagged text for NameTypeDesginations name part
I did not encounter any problems in phycobank which are due to these changes.
Ticket can be closed
Andreas Kohlbecker
12:27 PM task #9490 (Closed): avoid rank entity in TaxonNameParts
done Andreas Kohlbecker
12:19 PM bug #9504 (Closed): Changing term tree title is not persisted
works as expected now Andreas Müller
10:38 AM bug #9468 (Worksforme): specimen type of existing name cannot be saved
has been solved meanwhile in another context Andreas Kohlbecker
08:37 AM bug #9578 (Closed): Multiselect for input of distribution editor creates duplicates
looks fine and works as expected Katja Luther

04/14/2021

10:51 PM bug #9578: Multiselect for input of distribution editor creates duplicates
I tested now and it seems to work as expected. Please also review. Andreas Müller
06:21 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Katja Luther wrote:
> Sorry it is the method listChildrenOfRecursive, there the node is added to the result:
>
> ...
Andreas Müller
04:50 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Andreas Müller wrote:
> Katja Luther wrote:
> > The criteria for getting the children is
> >
> > ~~~ java
> > ...
Katja Luther
04:43 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Katja Luther wrote:
> The criteria for getting the children is
>
> ~~~ java
> crit.add( Restrictions.lik...
Andreas Müller
02:22 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Katja Luther wrote:
> > > > please re...
Katja Luther
02:04 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > please review my changes.
> >
> > Hav...
Andreas Müller
01:57 PM bug #9578: Multiselect for input of distribution editor creates duplicates
Andreas Müller wrote:
> Katja Luther wrote:
> > please review my changes.
>
> Have you tested this? It does not ...
Katja Luther
12:16 PM bug #9578 (Feedback): Multiselect for input of distribution editor creates duplicates
Katja Luther wrote:
> please review my changes.
Have you tested this? It does not work. And it can't work as pare...
Andreas Müller
09:53 AM bug #9578: Multiselect for input of distribution editor creates duplicates
Katja Luther wrote:
> Andreas Müller wrote:
> > This works now for taxon nodes not sharing duplicates (e.g. for sib...
Andreas Müller
09:52 AM bug #9578: Multiselect for input of distribution editor creates duplicates
please review my changes. Katja Luther
09:48 AM bug #9578: Multiselect for input of distribution editor creates duplicates
Andreas Müller wrote:
> This works now for taxon nodes not sharing duplicates (e.g. for sibblings). It still shows d...
Katja Luther
10:48 PM bug #9581 (New): Strange focus behavior in taxon navigator after right mouse click
How to reproduce:
* Open referencing objects view
* Select 2 taxa in navigator and open in distribution editor vi...
Andreas Müller
06:38 PM bug #9468: specimen type of existing name cannot be saved
Checked it in the Test system. The described error does not occur anymore. The ticket can be closed.
(Maybe it occur...
Wolf-Henning Kusber
05:33 PM bug #9468 (Feedback): specimen type of existing name cannot be saved
seems to be fixed already, please can you verify? Andreas Kohlbecker
05:28 PM bug #7943: TypeDesignationsEditor Select Reference for figure
still an open issue Andreas Kohlbecker
05:19 PM bug #9568 (Closed): TypeSpecimenEditor: Selection of a reference of an typified image
Andreas Kohlbecker
05:18 PM feature request #7599 (Closed): treeView for specimen data in dataportal
appart from the questions discussed in #9579 this ticket is now complete. Andreas Kohlbecker
05:16 PM bug #9555 (Closed): symbols for record basis (and kind of unit) in derivation tree
new ticket for further symbols #9580 Andreas Kohlbecker
05:15 PM bug #9580 (New): more symbols for record basis (and kind of unit) in derivation tree - coninuation
this is a continuation ticket for #9555
show symbols with the units-header per record basis and kind of unit if ne...
Andreas Kohlbecker
04:01 PM bug #9504 (Resolved): Changing term tree title is not persisted
This should be fixed now. Please review. Katja Luther
12:53 PM bug #9504: Changing term tree title is not persisted
Maybe we can have a look to this again, now, as there is still some time for the release. If not possible to solve be... Andreas Müller
02:10 PM task #9579: restore css3pie if needed
before doing the release we need to decide for how important this is.
The compass installlation on the integration...
Andreas Kohlbecker
12:47 PM bug #8233 (In Progress): [Follow up] Creating type duplicates
The persistent identifier issue works now. I set the ticket back to "In progress" as there are other remaining issues. Andreas Müller
12:38 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor
Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > Andreas Müller wrote:
> > > > Also the ...
Andreas Müller
09:07 AM feature request #9537: Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Also the button checks if a vocabulary...
Katja Luther
09:06 AM feature request #9537 (Resolved): Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Also the formatting (label) for the ch...
Katja Luther

04/13/2021

10:22 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image
Selection of a reference of an typified image in the TypeSpecimenEditor works now as expected, thanks. The ticket can... Wolf-Henning Kusber
04:18 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image
please test once the server is updated (~1h from now on) Andreas Kohlbecker
03:05 PM bug #9568 (Resolved): TypeSpecimenEditor: Selection of a reference of an typified image
Applied in changeset commit:cdm-vaadin|e8dcb430eb56a577c61ef744ce689094e2093d90. Andreas Kohlbecker
03:03 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image
This is an regression introduced in the context of #9480 Andreas Kohlbecker
04:48 PM feature request #9537: Implement ratioToStructure in TaxEditor
Katja Luther wrote:
> Andreas Müller wrote:
> > Also the formatting (label) for the character does not change yet e...
Andreas Müller
04:45 PM feature request #9537: Implement ratioToStructure in TaxEditor
Katja Luther wrote:
> Andreas Müller wrote:
> > Also the button checks if a vocabulary is chosen. This is not neces...
Andreas Müller
03:10 PM feature request #9537: Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> Also the formatting (label) for the character does not change yet even if it has no protecte...
Katja Luther
03:05 PM feature request #9537: Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> Also the button checks if a vocabulary is chosen. This is not necessary as the character alr...
Katja Luther
03:04 PM feature request #9537: Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> Finally, if possible, the new button should only be enabeled if a structure and a character ...
Katja Luther
03:04 PM feature request #9537: Implement ratioToStructure in TaxEditor
Andreas Müller wrote:
> The ratio to is currently only shown after the character editor was saved. It should be show...
Katja Luther
01:51 PM feature request #9537: Implement ratioToStructure in TaxEditor
Finally, if possible, the new button should only be enabeled if a structure and a character node is selected. Andreas Müller
12:24 PM feature request #9537: Implement ratioToStructure in TaxEditor
Also the formatting (label) for the character does not change yet even if it has no protected titleCache. Andreas Müller
12:22 PM feature request #9537: Implement ratioToStructure in TaxEditor
Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is u... Andreas Müller
12:22 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor
The ratio to is currently only shown after the character editor was saved. It should be shown immediately after press... Andreas Müller
04:31 PM bug #9556 (Closed): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
can be closed now Andreas Kohlbecker
04:23 PM bug #9556 (Resolved): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
after the commit:6d3c3fa9 which is rather related to `listRootUnitDTOsByAssociatedTaxon()` the web services should no... Andreas Kohlbecker
04:16 PM feature request #9332 (Closed): Rename TypeDesignationBase.source to .designationSource
should be fixed now Andreas Kohlbecker
03:40 PM feature request #9332 (Resolved): Rename TypeDesignationBase.source to .designationSource
the renamed field is causing LIEs in cdm-vaadin, so this ticket is not fully solved.
e.g.
http://test.e-taxonom...
Andreas Kohlbecker
02:26 PM bug #8233: [Follow up] Creating type duplicates
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> >>...
> > > This is how it was meant. The...
Katja Luther
02:08 PM bug #8233 (Feedback): [Follow up] Creating type duplicates
Katja Luther wrote:
> Andreas Müller wrote:
>>...
> > This is how it was meant. Therefore I removed the first "NK"...
Andreas Müller
02:07 PM bug #8233: [Follow up] Creating type duplicates
Sorry I missed to push some files, please review now. Katja Luther
09:25 AM bug #8233: [Follow up] Creating type duplicates
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > I add the "fast" tag for the last issu...
Katja Luther
12:04 PM bug #9578: Multiselect for input of distribution editor creates duplicates
This works now for taxon nodes not sharing duplicates (e.g. for sibblings). It still shows duplicates if e.g. one sel... Andreas Müller

04/12/2021

08:35 PM bug #8233: [Follow up] Creating type duplicates
Katja Luther wrote:
> Andreas Müller wrote:
> > I add the "fast" tag for the last issue ("Add "Preferred Stable Ide...
Andreas Müller
03:35 PM bug #8233: [Follow up] Creating type duplicates
Andreas Müller wrote:
> I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of a...
Katja Luther

04/06/2021

10:43 PM bug #9555 (In Progress): symbols for record basis (and kind of unit) in derivation tree
only some symbols are missing Andreas Kohlbecker
10:43 PM bug #9555 (Resolved): symbols for record basis (and kind of unit) in derivation tree
Andreas Kohlbecker
10:35 PM task #9579 (Worksforme): restore css3pie if needed
during the implemetation of the derivation tree view for #7599 and #6866 it was necessary to upgrade `compass` interm... Andreas Kohlbecker

04/02/2021

08:27 AM bug #9504: Changing term tree title is not persisted
Actually I could not find why the newly created tree can not be edited before saving. When the tree is persisted you ... Katja Luther
01:08 AM bug #9578 (Resolved): Multiselect for input of distribution editor creates duplicates
Applied in changeset commit:cdmlib|ba87a40e9a4066100dff6e13c5aebb2b1782e4b6. Andreas Müller
01:00 AM bug #9578 (Closed): Multiselect for input of distribution editor creates duplicates
if 1 record select only this record is returned
if 2 records are selected 1 record is duplicated
if 3 records a...
Andreas Müller

04/01/2021

03:51 PM bug #9577 (New): Enable copy for multiple cell selection in bulk editor
see #9544 Katja Luther
03:49 PM feature request #9544 (Closed): In bulkeditor the strings should be copyable
To have this issue in the actual release I close this ticket and create a new ticket for the multiselect, because I c... Katja Luther
02:37 PM feature request #9537 (Resolved): Implement ratioToStructure in TaxEditor
This should be fixed.
The ratio to structure can be added in character editor by using the button in character edi...
Katja Luther
11:57 AM task #9576 (Rejected): Add tests for homotypic group name comparator
from #9567:
Maybe you can still add some tests for HomotypicGroupNameComparator which explicitly handle specific i...
Katja Luther
11:56 AM task #9567 (Closed): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
this issue seems to be fixed. add a new ticket for the tests. Katja Luther
11:55 AM feature request #9571 (Closed): Improve sec-formatting for taxa with webpage secundum
this works as expected. Katja Luther

03/31/2021

06:50 PM feature request #9537 (In Progress): Implement ratioToStructure in TaxEditor
Implemented a button to add ratio to structure to character.
Still needed is a button in details view to remove th...
Katja Luther
12:17 PM feature request #9575 (Closed): Allow flag to include authors in taxon and name search in TaxEditor
In #6128 the possibility to include authors were added to the according service. We should also allow in TaxEditor de... Andreas Müller
12:15 PM feature request #9574 (Closed): Add html tags for names in NameTypeDesignation in CdmLightExport
this is fixed.
Walter checked it.
Katja Luther
12:12 PM feature request #9574 (Closed): Add html tags for names in NameTypeDesignation in CdmLightExport
mail:
noch eine Fragen, die man eventuell schnell lösen könnte (für mich recht kompliziert): Kannst Du die als Typ...
Katja Luther
11:26 AM feature request #9544 (Feedback): In bulkeditor the strings should be copyable
This works as expected. Only multiple cell selection still has the old behavior. If this is very easy to fix, please ... Andreas Müller
11:18 AM bug #9504: Changing term tree title is not persisted
Katja Luther wrote:
> Andreas Müller wrote:
> > This still does not work
>
> I tested on nightly and it works? D...
Andreas Müller
10:06 AM bug #9504: Changing term tree title is not persisted
Andreas Müller wrote:
> By the way, it would good to use an underscore before the default title like "_New feature t...
Katja Luther
09:32 AM bug #9504: Changing term tree title is not persisted
Andreas Müller wrote:
> This still does not work
I tested on nightly and it works? Did you update?
Katja Luther
11:00 AM feature request #9331 (Closed): Distinguish DescriptionElementSource and NamedSource
The adaptions in editor work and the class structure looks good. Katja Luther
10:55 AM feature request #9561 (Closed): In name and taxon search if titleCache is protected the search should run on titleCache also
works now as expected. Katja Luther
10:46 AM feature request #9570: Use tagged text for NameTypeDesginations name part
for the cdmLight usecase it works as expected. Maybe Ak should have a look whether the implementation works for phyco... Katja Luther
10:34 AM feature request #9515 (Closed): Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import
adapted the code, tested and worked as expected. Katja Luther
10:33 AM bug #9531 (Closed): Add Names in OriginalSpelling to the delete configuration
adapt the error message. Katja Luther
10:16 AM bug #9573 (New): Space between collection sections and elements above and behind are too large
see #9549 and others Katja Luther
10:15 AM feature request #9549 (Closed): Reduce visible fields for nomenclatural source and secundum source in TaxEditor
Andreas Müller wrote:
> This works. Only there is much space between "detail" and "Links" (for secundum reference) a...
Katja Luther
10:06 AM feature request #9572 (Closed): After creating a new term tree set the focus to the new tree
... and in details view in title cache field Katja Luther

03/30/2021

11:02 PM feature request #9571: Improve sec-formatting for taxa with webpage secundum
this should be fixed, can you please review Andreas Müller
11:01 PM feature request #9571 (Resolved): Improve sec-formatting for taxa with webpage secundum
Applied in changeset commit:cdmlib|6202dea80501881fb388073b428c15c4c0fc255b. Andreas Müller
10:48 PM feature request #9571 (Closed): Improve sec-formatting for taxa with webpage secundum
WGB:
mir ist gerade aufgefallen, dass es wohl keine solche Short-Citation (anlaog zu Autor-Nachname oder Teamnachn...
Andreas Müller
09:06 PM feature request #9570: Use tagged text for NameTypeDesginations name part
Please review. If anything doesn't work as expected please add test to newly created test class. Andreas Müller
09:02 PM feature request #9570 (Resolved): Use tagged text for NameTypeDesginations name part
Applied in changeset commit:cdmlib|fe3e32ab2e841cc1ca2fbec4734e32e0ee8c52f4. Andreas Müller
09:01 PM feature request #9570 (Closed): Use tagged text for NameTypeDesginations name part
... and prepare for tagged text for other type designation categories Andreas Müller
03:00 PM feature request #9544 (Resolved): In bulkeditor the strings should be copyable
Andreas Müller
02:27 PM task #9569 (New): Delete taxon and delete name should use the same UI and same semantics for deleting names
Currently the delete name configurator for deleting taxa and names differ currently. E.g. the delete type designation... Andreas Müller
02:13 PM bug #9531 (Feedback): Add Names in OriginalSpelling to the delete configuration
In the error message we should use "... original spelling" , not camel case.
Except for this the ticket can be clo...
Andreas Müller
01:45 PM bug #9562 (Closed): Publish flag of field units and derived units are not handled correctly
This seems to work Andreas Müller
01:40 PM bug #9533 (Closed): NPE when reusing name for new taxon
This seems to work now Andreas Müller
01:32 PM feature request #9540: Handle classification source as source in TaxEditor
I guess this is fast as it is mostly c&p from other single sources Andreas Müller
01:29 PM feature request #9328 (Closed): Adapt Editor to switch to originalSource for taxon secundum
Works as expected. Andreas Müller
01:26 PM bug #9504: Changing term tree title is not persisted
By the way, it would good to use an underscore before the default title like "_New feature tree". Also having the foc... Andreas Müller
01:25 PM bug #9504 (Feedback): Changing term tree title is not persisted
This still does not work Andreas Müller
01:18 PM feature request #9545 (Closed): Remove "External Link type" completely
Andreas Müller
01:03 PM feature request #9549 (Feedback): Reduce visible fields for nomenclatural source and secundum source in TaxEditor
This works. Only there is much space between "detail" and "Links" (for secundum reference) and between "details" and ... Andreas Müller
12:37 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
The mentioned issues should be fixed.
Maybe you can still add some tests for HomotypicGroupNameComparator which ex...
Andreas Müller
12:27 PM task #9567 (Feedback): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
I fixed the potetial NPE and adapted the compare to include hybrid sign if names do not differ in any other part. Andreas Müller
12:23 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Applied in changeset commit:cdmlib|e0c610f10302b0c755f509a33bd3df645077ea69. Andreas Müller
11:42 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
I would add another comparison if the first two comparisons return 0 to compare the not normalized titleCache, do you... Katja Luther
11:24 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > In handleSameBasionym a return was missi...
Katja Luther
10:36 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Andreas Müller wrote:
> Katja Luther wrote:
> > In handleSameBasionym a return was missing. After fixing that the r...
Katja Luther
10:11 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Katja Luther wrote:
> In handleSameBasionym a return was missing. After fixing that the result is correct.
> But ma...
Andreas Müller
08:46 AM task #9567 (Feedback): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
In handleSameBasionym a return was missing. After fixing that the result is correct.
But maybe the NPE should be avo...
Katja Luther
11:53 AM bug #9566 (Closed): Handle nomenclatural standing correctly in cdmlight / sorting algorithms
this works now as expected, also for the homotypic groups in editor. Katja Luther
11:53 AM bug #9441 (Closed): Move names with invalid designation name relationships to the end in taxon comparator
this works now as expected, also for the homotypic groups in editor. Katja Luther
10:28 AM bug #9568 (Closed): TypeSpecimenEditor: Selection of a reference of an typified image
Vaadin TypeSpecimenEditor (Test as well as production):
With change of the typification reference with preselected...
Wolf-Henning Kusber

03/29/2021

09:15 PM bug #9566 (Resolved): Handle nomenclatural standing correctly in cdmlight / sorting algorithms
Please review. Andreas Müller
06:58 PM bug #9566 (Closed): Handle nomenclatural standing correctly in cdmlight / sorting algorithms
This includes using the correct symbol whenenver a "name" is a designation only.
And sorting designations to the e...
Andreas Müller
09:13 PM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
please review Andreas Müller
08:46 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Applied in changeset commit:cdmlib|8432293fbc9496c0b4c50bda3516ef9e0ac3b984. Andreas Müller
08:46 PM task #9567 (Closed): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator
Both classes have mostly the same code so they are very redundant. HGNameComparator seems to be an adapted copy of HG... Andreas Müller
06:49 PM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also
I adapted the search. Can you please test again. I havn't tested yet in TaxEditor, only in test class (see code). Andreas Müller
06:45 PM feature request #9561 (Resolved): In name and taxon search if titleCache is protected the search should run on titleCache also
Applied in changeset commit:cdmlib|571eb9f1582883152db414442c0f878d7925280b. Andreas Müller
10:50 AM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also
Yes, I also thought about this but did not implement it such as I did not want to have all the subspecies in the resu... Andreas Müller
10:39 AM feature request #9561 (Feedback): In name and taxon search if titleCache is protected the search should run on titleCache also
It works as expected, but searching without authors for a titlecache with authors does not match. Maybe we should add... Katja Luther
11:06 AM feature request #8968 (Closed): filter Bulk editor for created by
created by moved, close this ticket. Katja Luther
10:53 AM bug #9533 (Resolved): NPE when reusing name for new taxon
Andreas Müller wrote:
> Andreas Müller wrote:
> > When deleting the selected name again I now get another NPE:
>
...
Katja Luther
10:46 AM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
I removed that the derivatives are added to the fieldUnitDto in loadFieldUnitDto(). Katja Luther
10:42 AM task #9558 (Closed): General tests for cdmlight export
Looks fine. Katja Luther
08:38 AM bug #9565 (New): Revise name render templates selection strategy
In the flora of cuba the syn-sec. references are expected to be shown:
http://portal.cybertaxonomy.org/flora-cuba/...
Andreas Kohlbecker

03/26/2021

04:23 PM task #9564 (New): synonymy: suppress output of sec references if it is equal with the accepted taxon sec ref
"Da wäre die Möglichkeit interessant, nur die sec.Refs. anzuzeigen, die NICHT die gleiche sec.-Ref. haben, die also d... Andreas Kohlbecker
04:19 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
so we should modify this service method so that it no longer add the derivatives or is there an alternative service m... Andreas Kohlbecker
04:07 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
Andreas Kohlbecker wrote:
> reopening this issue since `loadFieldUnitDTO()` is being used in the Taxeditor
>
> @K...
Katja Luther
03:57 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
DerivedUnitFacadeController.doGetFieldObjectMediaDTO() is no longer using loadFieldUnitDTO see commit:3309605f
there...
Andreas Kohlbecker
02:32 PM bug #9556 (Feedback): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
reopening this issue since `loadFieldUnitDTO()` is being used in the Taxeditor
@Katja: are the derivatives of the ...
Andreas Kohlbecker
02:26 PM bug #9556 (Rejected): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
since the intermediate units are not used at all by consuming methods, they should be skipped completely.
Andreas Kohlbecker
12:16 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
This method is kind of misused: After solving #9557 it is only being used by `.DerivedUnitFacadeController.doGetField... Andreas Kohlbecker
04:13 PM task #6208 (New): Implement synonymy service responding with DTO
Andreas Müller
04:07 PM task #6208: Implement synonymy service responding with DTO
I think we should reopen this ticket since we will be working on this this year Andreas Kohlbecker
04:10 PM bug #9562: Publish flag of field units and derived units are not handled correctly
this should be fixed. The problem was that the value for the publish checkbox was taken from DerivedUnitFace.isPublis... Katja Luther
04:07 PM bug #9562 (Resolved): Publish flag of field units and derived units are not handled correctly
Applied in changeset commit:taxeditor|6dd14e6fb067f81fb1deba7377d5bf81312a5991. Katja Luther
03:59 PM bug #9562 (Closed): Publish flag of field units and derived units are not handled correctly
when editing the field unit publish flag the publish flag of the derivate units are changed, too and/or not saved cor... Katja Luther
04:03 PM bug #9563 (New): MediaDTO factory method supports media representation preferences
see comment in code:
~~~java
/**
* Creates a list of DTOs from the Media entity.
* For each Medi...
Andreas Kohlbecker
02:00 PM bug #9559: OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units
Andreas Kohlbecker wrote:
> The priority of this ticket depends on the question if there are projects with units whi...
Andreas Müller
01:57 PM bug #9559 (New): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units
I think this ticket should be checked against #8424 and #4484 if they are duplicates of each other Andreas Müller
11:12 AM bug #9559 (Feedback): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units

The priority of this ticket depends on the question if there are projects with units which must be undisclosed and ...
Andreas Kohlbecker
11:09 AM bug #9559 (New): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units
All methods in OccurrenceServiceImpl which deliver units for the data portal via web services need to filter out unpu... Andreas Kohlbecker
01:54 PM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also
Please review Andreas Müller
12:08 PM feature request #9561 (Resolved): In name and taxon search if titleCache is protected the search should run on titleCache also
Applied in changeset commit:cdmlib|9bf89673c622c6823cefe921429b1f2438dc3c0a. Andreas Müller
12:06 PM feature request #9561 (Closed): In name and taxon search if titleCache is protected the search should run on titleCache also
... otherwise users may think the name does not exist yet if the nameCache is not filled correctly.
Currently name...
Andreas Müller
12:38 PM bug #9504 (Resolved): Changing term tree title is not persisted
this is fixed Katja Luther
12:00 PM bug #9557 (Closed): implement occurrence/{uuid}/rootUnitDTOs
Andreas Kohlbecker
10:39 AM bug #9557: implement occurrence/{uuid}/rootUnitDTOs
the web service `occurrence/{uuid}/rootUnitDTOs` and service method `OccurrenceServiceImpl.findRootUnitDTOs()` are mi... Andreas Kohlbecker
11:48 AM feature request #9544: In bulkeditor the strings should be copyable
this is implemented, please review. Katja Luther
10:08 AM feature request #9545: Remove "External Link type" completely
please review Katja Luther
10:08 AM feature request #9545 (Resolved): Remove "External Link type" completely
Applied in changeset commit:taxeditor|3470949e9aa012a03d23c1b0e44603ed698ee056. Katja Luther
10:00 AM feature request #9328 (Resolved): Adapt Editor to switch to originalSource for taxon secundum
this is implemented, please review. Katja Luther
09:59 AM feature request #9549 (Resolved): Reduce visible fields for nomenclatural source and secundum source in TaxEditor
this is fixed, please review. Katja Luther

03/25/2021

11:32 PM task #9558 (Resolved): General tests for cdmlight export
This is fixed. Please review. Andreas Müller
11:31 PM task #9558 (Closed): General tests for cdmlight export
all tests for cdmlight export should include an exception, error and warning test.
Also a fullDataSample (FullCove...
Andreas Müller
05:54 PM bug #9557 (Closed): implement occurrence/{uuid}/rootUnitDTOs
see http://int.e-taxonomy.eu/cdmserver/integration_reference/occurrence/8259122c-7140-44f3-980e-1a6506ce8f50/fieldUni... Andreas Kohlbecker
05:52 PM bug #9556 (Closed): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response
see http://localhost:8080/occurrence/8585081c-b73b-440b-b349-582845cf3fb4/fieldUnitDTOs.json
the response data ma...
Andreas Kohlbecker
05:22 PM bug #9555 (Closed): symbols for record basis (and kind of unit) in derivation tree
show symbols with the units-header per record basis and kind of unit if needed
A quickly assembled list:
**reco...
Andreas Kohlbecker
04:03 PM feature request #9554 (New): option to suppress type designations in portal
in the http://portal.cybertaxonomy.org/flora-cuba/ typedesignations are just hidden per css. The related footnotes ar... Andreas Kohlbecker
04:01 PM bug #9553: Synonymy is missing in table of content
The same is true for Polyt. Keys Walter Berendsohn
03:50 PM bug #9553 (New): Synonymy is missing in table of content
Configuration:
* Tabless Taxon page
* Synonym as separate tab
==> the synonymy is missing in the TOC
htt...
Andreas Kohlbecker
01:09 PM bug #9550 (Closed): Recognize PhytoKeys and PLoS ONE in name parser
Test run as expected. Andreas Müller
12:48 PM feature request #9552: Add e-article number to Reference
ERS:
... und so etwas ist auch nicht parsable (fascicle > 4 Zeichen): Lepyrodiclis alinihatii Menemen & al. in Nor...
Andreas Müller
09:38 AM feature request #9552 (New): Add e-article number to Reference
Journals publishing online have started giving numbers for there electronically published articles which seem to have... Andreas Müller

03/24/2021

09:58 PM task #9014 (In Progress): Unparsable name strings
Andreas Müller
04:45 PM bug #9551 (Resolved): Recognize "series" in article parsing
Applied in changeset commit:cdmlib|d9aa603aade3ded73eedd57d346e478e820073a4. Andreas Müller
04:16 PM bug #9551 (Resolved): Recognize "series" in article parsing
... maybe also books etc. Andreas Müller
02:20 PM bug #9550 (Resolved): Recognize PhytoKeys and PLoS ONE in name parser
Applied in changeset commit:cdmlib|a119dab72f372797dc5e8afd8f34c53baa3e7440. Andreas Müller
02:19 PM bug #9550 (Closed): Recognize PhytoKeys and PLoS ONE in name parser
e.g. Pseudopodospermum baeticum (DC.) Zaika & al. in PhytoKeys 137: 68. 2020 Andreas Müller
11:25 AM feature request #8920: Make reference URL available in details view
WGB:
Erstmal zum Direktlink zur Literatur-URL aus dem Details-VIew – fände ich wirklich toll (siehe ganz unten), d...
Andreas Müller
11:19 AM feature request #9549: Reduce visible fields for nomenclatural source and secundum source in TaxEditor
WGB:
Wenn Ihr an dieser Stelle schon am Arbeiten seid: Nochmal zum neuen Dialog, mit dem ich gar nicht glücklich b...
Andreas Müller
11:15 AM feature request #9549 (Closed): Reduce visible fields for nomenclatural source and secundum source in TaxEditor
Currently it shows the fields "type" and "description" for links and "original information", "idNamespace" and "idInS... Andreas Müller
11:03 AM feature request #9548 (New): Handle links to websites, webapps or similar in image galleries (simple and UV)
Sometimes users use links to websites within an image gallery. These usually are identified by mime type "text/html",... Andreas Müller
10:59 AM feature request #9547 (New): Show warning in TaxEditor if a MediaRepresentation can not be shown in a Viewer
Sometimes users use links to websites within an image gallery. These usually are identified mime type "text/html" or ... Andreas Müller
10:51 AM feature request #9067 (Closed): [DISCUSS] Allow media to support external links not being files
Andreas Kohlbecker wrote:
> I actually see no benefit of the "solutions" 2 - 4 over 1.
>
> Adding additional fiel...
Andreas Müller
10:43 AM feature request #9546 (New): [DISCUSS] Merge ExternalLink and MediaRepresentation
... once MediaRepresentation has been merged with MediaRepresentationPart
Both classes store common information li...
Andreas Müller
10:24 AM feature request #9296: Preference to show/not show infrageneric epithet for species
NK:
zufällig bin ich nun wieder auf den Hintergrund in der Botanik gestoßen:
Code, https://www.iapt-taxon.org/n...
Andreas Müller
10:01 AM feature request #9545 (Closed): Remove "External Link type" completely
There is no real need for the ExternalLink.type attribute as today browsers all know how to open e.g. pdf. This was a... Andreas Müller
09:52 AM bug #9538 (Closed): Changing accepted to synonym closes name editor tab even if canceled
I also can't reproduce anymore. So I close and reopen if it appears again. Andreas Müller
08:36 AM bug #9538 (Resolved): Changing accepted to synonym closes name editor tab even if canceled
I can't reproduce this exception, also on nightly version. Maybe there was a state where the exception appeared. Katja Luther
09:20 AM bug #9542 (Closed): Bulk Editor search does not work after opening a name out of the bulk editor
Works as expected and code looks reasonable. Andreas Müller

03/23/2021

01:43 PM feature request #9544: In bulkeditor the strings should be copyable
I guess this is fast to implement. If not, remove the tag. Andreas Müller
11:54 AM feature request #9544 (Closed): In bulkeditor the strings should be copyable
The user should be able to copy out of all columns in bulkeditor. Katja Luther

03/22/2021

02:38 PM bug #9543 (New): Revise, harmonize media list in SpecimenOrObservationBaseDTO vs. DerivedUnitFacade.getMediaTextData()
`DerivedUnitFacade.getMediaTextData()` is being used to provide the media lists for the `DerivedUnit` and `FieldUnit`... Andreas Kohlbecker
11:31 AM bug #9504: Changing term tree title is not persisted
Not sure if this is fast but I could imagine that it is. Andreas Müller
10:46 AM bug #9542: Bulk Editor search does not work after opening a name out of the bulk editor
I guess this is for reveiew Andreas Müller
10:40 AM bug #9542 (Resolved): Bulk Editor search does not work after opening a name out of the bulk editor
Applied in changeset commit:taxeditor|e2d8b4196539aeb0c3e1a587026ca46ce1f1034a. Katja Luther
08:19 AM bug #9542 (Closed): Bulk Editor search does not work after opening a name out of the bulk editor
mail WHB:
Noch eine Auffälligkeit. Neoporteria planiceps ist (als Name) vorhanden.

Im Bulk Editor wird er abe...
Katja Luther
10:40 AM feature request #8968 (Resolved): filter Bulk editor for created by
Applied in changeset commit:taxeditor|3767457b3f1509b425d264ef930d384d9126a0d8. Katja Luther
 

Also available in: Atom