EDIT

04/14/2021

10:51 PM bug #9578: Multiselect for input of distribution editor creates duplicates

I tested now and it seems to work as expected. Please also review. Andreas Müller

06:21 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Katja Luther wrote:
> Sorry it is the method listChildrenOfRecursive, there the node is added to the result:
>
> ... Andreas Müller

04:50 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Andreas Müller wrote:
> Katja Luther wrote:
> > The criteria for getting the children is
> >
> > ~~~ java
> > ... Katja Luther

04:43 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Katja Luther wrote:
> The criteria for getting the children is
>
> ~~~ java
> crit.add( Restrictions.lik... Andreas Müller

02:22 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Katja Luther wrote:
> > > > please re... Katja Luther

02:04 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > please review my changes.
> >
> > Hav... Andreas Müller

01:57 PM bug #9578: Multiselect for input of distribution editor creates duplicates

Andreas Müller wrote:
> Katja Luther wrote:
> > please review my changes.
>
> Have you tested this? It does not ... Katja Luther

12:16 PM bug #9578 (Feedback): Multiselect for input of distribution editor creates duplicates

Katja Luther wrote:
> please review my changes.
Have you tested this? It does not work. And it can't work as pare... Andreas Müller

09:53 AM bug #9578: Multiselect for input of distribution editor creates duplicates

Katja Luther wrote:
> Andreas Müller wrote:
> > This works now for taxon nodes not sharing duplicates (e.g. for sib... Andreas Müller

09:52 AM bug #9578: Multiselect for input of distribution editor creates duplicates

please review my changes. Katja Luther

09:48 AM bug #9578: Multiselect for input of distribution editor creates duplicates

Andreas Müller wrote:
> This works now for taxon nodes not sharing duplicates (e.g. for sibblings). It still shows d... Katja Luther

10:48 PM bug #9581 (New): Strange focus behavior in taxon navigator after right mouse click

How to reproduce:
* Open referencing objects view
* Select 2 taxa in navigator and open in distribution editor vi... Andreas Müller

06:38 PM bug #9468: specimen type of existing name cannot be saved

Checked it in the Test system. The described error does not occur anymore. The ticket can be closed.
(Maybe it occur... Wolf-Henning Kusber

05:33 PM bug #9468 (Feedback): specimen type of existing name cannot be saved

seems to be fixed already, please can you verify? Andreas Kohlbecker

05:28 PM bug #7943: TypeDesignationsEditor Select Reference for figure

still an open issue Andreas Kohlbecker

05:19 PM bug #9568 (Closed): TypeSpecimenEditor: Selection of a reference of an typified image

Andreas Kohlbecker

05:18 PM feature request #7599 (Closed): treeView for specimen data in dataportal

appart from the questions discussed in #9579 this ticket is now complete. Andreas Kohlbecker

05:16 PM bug #9555 (Closed): symbols for record basis (and kind of unit) in derivation tree

new ticket for further symbols #9580 Andreas Kohlbecker

05:15 PM bug #9580 (New): more symbols for record basis (and kind of unit) in derivation tree - coninuation

this is a continuation ticket for #9555
show symbols with the units-header per record basis and kind of unit if ne... Andreas Kohlbecker

04:01 PM bug #9504 (Resolved): Changing term tree title is not persisted

This should be fixed now. Please review. Katja Luther

12:53 PM bug #9504: Changing term tree title is not persisted

Maybe we can have a look to this again, now, as there is still some time for the release. If not possible to solve be... Andreas Müller

02:10 PM task #9579: restore css3pie if needed

before doing the release we need to decide for how important this is.
The compass installlation on the integration... Andreas Kohlbecker

12:47 PM bug #8233 (In Progress): [Follow up] Creating type duplicates

The persistent identifier issue works now. I set the ticket back to "In progress" as there are other remaining issues. Andreas Müller

12:38 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor

Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > Andreas Müller wrote:
> > > > Also the ... Andreas Müller

09:07 AM feature request #9537: Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Also the button checks if a vocabulary... Katja Luther

09:06 AM feature request #9537 (Resolved): Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > Also the formatting (label) for the ch... Katja Luther

04/13/2021

10:22 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image

Selection of a reference of an typified image in the TypeSpecimenEditor works now as expected, thanks. The ticket can... Wolf-Henning Kusber

04:18 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image

please test once the server is updated (~1h from now on) Andreas Kohlbecker

03:05 PM bug #9568 (Resolved): TypeSpecimenEditor: Selection of a reference of an typified image

Applied in changeset commit:cdm-vaadin|e8dcb430eb56a577c61ef744ce689094e2093d90. Andreas Kohlbecker

03:03 PM bug #9568: TypeSpecimenEditor: Selection of a reference of an typified image

This is an regression introduced in the context of #9480 Andreas Kohlbecker

04:48 PM feature request #9537: Implement ratioToStructure in TaxEditor

Katja Luther wrote:
> Andreas Müller wrote:
> > Also the formatting (label) for the character does not change yet e... Andreas Müller

04:45 PM feature request #9537: Implement ratioToStructure in TaxEditor

Katja Luther wrote:
> Andreas Müller wrote:
> > Also the button checks if a vocabulary is chosen. This is not neces... Andreas Müller

03:10 PM feature request #9537: Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> Also the formatting (label) for the character does not change yet even if it has no protecte... Katja Luther

03:05 PM feature request #9537: Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> Also the button checks if a vocabulary is chosen. This is not necessary as the character alr... Katja Luther

03:04 PM feature request #9537: Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> Finally, if possible, the new button should only be enabeled if a structure and a character ... Katja Luther

03:04 PM feature request #9537: Implement ratioToStructure in TaxEditor

Andreas Müller wrote:
> The ratio to is currently only shown after the character editor was saved. It should be show... Katja Luther

01:51 PM feature request #9537: Implement ratioToStructure in TaxEditor

Finally, if possible, the new button should only be enabeled if a structure and a character node is selected. Andreas Müller

12:24 PM feature request #9537: Implement ratioToStructure in TaxEditor

Also the formatting (label) for the character does not change yet even if it has no protected titleCache. Andreas Müller

12:22 PM feature request #9537: Implement ratioToStructure in TaxEditor

Also the button checks if a vocabulary is chosen. This is not necessary as the character already exists and only is u... Andreas Müller

12:22 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor

The ratio to is currently only shown after the character editor was saved. It should be shown immediately after press... Andreas Müller

04:31 PM bug #9556 (Closed): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

can be closed now Andreas Kohlbecker

04:23 PM bug #9556 (Resolved): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

after the commit:6d3c3fa9 which is rather related to `listRootUnitDTOsByAssociatedTaxon()` the web services should no... Andreas Kohlbecker

04:16 PM feature request #9332 (Closed): Rename TypeDesignationBase.source to .designationSource

should be fixed now Andreas Kohlbecker

03:40 PM feature request #9332 (Resolved): Rename TypeDesignationBase.source to .designationSource

the renamed field is causing LIEs in cdm-vaadin, so this ticket is not fully solved.
e.g.
http://test.e-taxonom... Andreas Kohlbecker

02:26 PM bug #8233: [Follow up] Creating type duplicates

Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> >>...
> > > This is how it was meant. The... Katja Luther

02:08 PM bug #8233 (Feedback): [Follow up] Creating type duplicates

Katja Luther wrote:
> Andreas Müller wrote:
>>...
> > This is how it was meant. Therefore I removed the first "NK"... Andreas Müller

02:07 PM bug #8233: [Follow up] Creating type duplicates

Sorry I missed to push some files, please review now. Katja Luther

09:25 AM bug #8233: [Follow up] Creating type duplicates

Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > I add the "fast" tag for the last issu... Katja Luther

12:04 PM bug #9578: Multiselect for input of distribution editor creates duplicates

This works now for taxon nodes not sharing duplicates (e.g. for sibblings). It still shows duplicates if e.g. one sel... Andreas Müller

04/12/2021

08:35 PM bug #8233: [Follow up] Creating type duplicates

Katja Luther wrote:
> Andreas Müller wrote:
> > I add the "fast" tag for the last issue ("Add "Preferred Stable Ide... Andreas Müller

03:35 PM bug #8233: [Follow up] Creating type duplicates

Andreas Müller wrote:
> I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of a... Katja Luther

04/06/2021

10:43 PM bug #9555 (In Progress): symbols for record basis (and kind of unit) in derivation tree

only some symbols are missing Andreas Kohlbecker

10:43 PM bug #9555 (Resolved): symbols for record basis (and kind of unit) in derivation tree

Andreas Kohlbecker

10:35 PM task #9579 (Worksforme): restore css3pie if needed

during the implemetation of the derivation tree view for #7599 and #6866 it was necessary to upgrade `compass` interm... Andreas Kohlbecker

04/02/2021

08:27 AM bug #9504: Changing term tree title is not persisted

Actually I could not find why the newly created tree can not be edited before saving. When the tree is persisted you ... Katja Luther

01:08 AM bug #9578 (Resolved): Multiselect for input of distribution editor creates duplicates

Applied in changeset commit:cdmlib|ba87a40e9a4066100dff6e13c5aebb2b1782e4b6. Andreas Müller

01:00 AM bug #9578 (Closed): Multiselect for input of distribution editor creates duplicates

if 1 record select only this record is returned
if 2 records are selected 1 record is duplicated
if 3 records a... Andreas Müller

04/01/2021

03:51 PM bug #9577 (New): Enable copy for multiple cell selection in bulk editor

see #9544 Katja Luther

03:49 PM feature request #9544 (Closed): In bulkeditor the strings should be copyable

To have this issue in the actual release I close this ticket and create a new ticket for the multiselect, because I c... Katja Luther

02:37 PM feature request #9537 (Resolved): Implement ratioToStructure in TaxEditor

This should be fixed.
The ratio to structure can be added in character editor by using the button in character edi... Katja Luther

11:57 AM task #9576 (Rejected): Add tests for homotypic group name comparator

from #9567:
Maybe you can still add some tests for HomotypicGroupNameComparator which explicitly handle specific i... Katja Luther

11:56 AM task #9567 (Closed): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

this issue seems to be fixed. add a new ticket for the tests. Katja Luther

11:55 AM feature request #9571 (Closed): Improve sec-formatting for taxa with webpage secundum

this works as expected. Katja Luther

03/31/2021

06:50 PM feature request #9537 (In Progress): Implement ratioToStructure in TaxEditor

Implemented a button to add ratio to structure to character.
Still needed is a button in details view to remove th... Katja Luther

12:17 PM feature request #9575 (Closed): Allow flag to include authors in taxon and name search in TaxEditor

In #6128 the possibility to include authors were added to the according service. We should also allow in TaxEditor de... Andreas Müller

12:15 PM feature request #9574 (Closed): Add html tags for names in NameTypeDesignation in CdmLightExport

this is fixed.
Walter checked it. Katja Luther

12:12 PM feature request #9574 (Closed): Add html tags for names in NameTypeDesignation in CdmLightExport

mail:
noch eine Fragen, die man eventuell schnell lösen könnte (für mich recht kompliziert): Kannst Du die als Typ... Katja Luther

11:26 AM feature request #9544 (Feedback): In bulkeditor the strings should be copyable

This works as expected. Only multiple cell selection still has the old behavior. If this is very easy to fix, please ... Andreas Müller

11:18 AM bug #9504: Changing term tree title is not persisted

Katja Luther wrote:
> Andreas Müller wrote:
> > This still does not work
>
> I tested on nightly and it works? D... Andreas Müller

10:06 AM bug #9504: Changing term tree title is not persisted

Andreas Müller wrote:
> By the way, it would good to use an underscore before the default title like "_New feature t... Katja Luther

09:32 AM bug #9504: Changing term tree title is not persisted

Andreas Müller wrote:
> This still does not work
I tested on nightly and it works? Did you update? Katja Luther

11:00 AM feature request #9331 (Closed): Distinguish DescriptionElementSource and NamedSource

The adaptions in editor work and the class structure looks good. Katja Luther

10:55 AM feature request #9561 (Closed): In name and taxon search if titleCache is protected the search should run on titleCache also

works now as expected. Katja Luther

10:46 AM feature request #9570: Use tagged text for NameTypeDesginations name part

for the cdmLight usecase it works as expected. Maybe Ak should have a look whether the implementation works for phyco... Katja Luther

10:34 AM feature request #9515 (Closed): Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

adapted the code, tested and worked as expected. Katja Luther

10:33 AM bug #9531 (Closed): Add Names in OriginalSpelling to the delete configuration

adapt the error message. Katja Luther

10:16 AM bug #9573 (New): Space between collection sections and elements above and behind are too large

see #9549 and others Katja Luther

10:15 AM feature request #9549 (Closed): Reduce visible fields for nomenclatural source and secundum source in TaxEditor

Andreas Müller wrote:
> This works. Only there is much space between "detail" and "Links" (for secundum reference) a... Katja Luther

10:06 AM feature request #9572 (Closed): After creating a new term tree set the focus to the new tree

... and in details view in title cache field Katja Luther

03/30/2021

11:02 PM feature request #9571: Improve sec-formatting for taxa with webpage secundum

this should be fixed, can you please review Andreas Müller

11:01 PM feature request #9571 (Resolved): Improve sec-formatting for taxa with webpage secundum

Applied in changeset commit:cdmlib|6202dea80501881fb388073b428c15c4c0fc255b. Andreas Müller

10:48 PM feature request #9571 (Closed): Improve sec-formatting for taxa with webpage secundum

WGB:
mir ist gerade aufgefallen, dass es wohl keine solche Short-Citation (anlaog zu Autor-Nachname oder Teamnachn... Andreas Müller

09:06 PM feature request #9570: Use tagged text for NameTypeDesginations name part

Please review. If anything doesn't work as expected please add test to newly created test class. Andreas Müller

09:02 PM feature request #9570 (Resolved): Use tagged text for NameTypeDesginations name part

Applied in changeset commit:cdmlib|fe3e32ab2e841cc1ca2fbec4734e32e0ee8c52f4. Andreas Müller

09:01 PM feature request #9570 (Closed): Use tagged text for NameTypeDesginations name part

... and prepare for tagged text for other type designation categories Andreas Müller

03:00 PM feature request #9544 (Resolved): In bulkeditor the strings should be copyable

Andreas Müller

02:27 PM task #9569 (New): Delete taxon and delete name should use the same UI and same semantics for deleting names

Currently the delete name configurator for deleting taxa and names differ currently. E.g. the delete type designation... Andreas Müller

02:13 PM bug #9531 (Feedback): Add Names in OriginalSpelling to the delete configuration

In the error message we should use "... original spelling" , not camel case.
Except for this the ticket can be clo... Andreas Müller

01:45 PM bug #9562 (Closed): Publish flag of field units and derived units are not handled correctly

This seems to work Andreas Müller

01:40 PM bug #9533 (Closed): NPE when reusing name for new taxon

This seems to work now Andreas Müller

01:32 PM feature request #9540: Handle classification source as source in TaxEditor

I guess this is fast as it is mostly c&p from other single sources Andreas Müller

01:29 PM feature request #9328 (Closed): Adapt Editor to switch to originalSource for taxon secundum

Works as expected. Andreas Müller

01:26 PM bug #9504: Changing term tree title is not persisted

By the way, it would good to use an underscore before the default title like "_New feature tree". Also having the foc... Andreas Müller

01:25 PM bug #9504 (Feedback): Changing term tree title is not persisted

This still does not work Andreas Müller

01:18 PM feature request #9545 (Closed): Remove "External Link type" completely

Andreas Müller

01:03 PM feature request #9549 (Feedback): Reduce visible fields for nomenclatural source and secundum source in TaxEditor

This works. Only there is much space between "detail" and "Links" (for secundum reference) and between "details" and ... Andreas Müller

12:37 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

The mentioned issues should be fixed.
Maybe you can still add some tests for HomotypicGroupNameComparator which ex... Andreas Müller

12:27 PM task #9567 (Feedback): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

I fixed the potetial NPE and adapted the compare to include hybrid sign if names do not differ in any other part. Andreas Müller

12:23 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Applied in changeset commit:cdmlib|e0c610f10302b0c755f509a33bd3df645077ea69. Andreas Müller

11:42 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

I would add another comparison if the first two comparisons return 0 to compare the not normalized titleCache, do you... Katja Luther

11:24 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > In handleSameBasionym a return was missi... Katja Luther

10:36 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Andreas Müller wrote:
> Katja Luther wrote:
> > In handleSameBasionym a return was missing. After fixing that the r... Katja Luther

10:11 AM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Katja Luther wrote:
> In handleSameBasionym a return was missing. After fixing that the result is correct.
> But ma... Andreas Müller

08:46 AM task #9567 (Feedback): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

In handleSameBasionym a return was missing. After fixing that the result is correct.
But maybe the NPE should be avo... Katja Luther

11:53 AM bug #9566 (Closed): Handle nomenclatural standing correctly in cdmlight / sorting algorithms

this works now as expected, also for the homotypic groups in editor. Katja Luther

11:53 AM bug #9441 (Closed): Move names with invalid designation name relationships to the end in taxon comparator

this works now as expected, also for the homotypic groups in editor. Katja Luther

10:28 AM bug #9568 (Closed): TypeSpecimenEditor: Selection of a reference of an typified image

Vaadin TypeSpecimenEditor (Test as well as production):
With change of the typification reference with preselected... Wolf-Henning Kusber

03/29/2021

09:15 PM bug #9566 (Resolved): Handle nomenclatural standing correctly in cdmlight / sorting algorithms

Please review. Andreas Müller

06:58 PM bug #9566 (Closed): Handle nomenclatural standing correctly in cdmlight / sorting algorithms

This includes using the correct symbol whenenver a "name" is a designation only.
And sorting designations to the e... Andreas Müller

09:13 PM task #9567: Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

please review Andreas Müller

08:46 PM task #9567 (Resolved): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Applied in changeset commit:cdmlib|8432293fbc9496c0b4c50bda3516ef9e0ac3b984. Andreas Müller

08:46 PM task #9567 (Closed): Unify HomotypicGroupTaxonComparator and HomotypicGroupNameComparator

Both classes have mostly the same code so they are very redundant. HGNameComparator seems to be an adapted copy of HG... Andreas Müller

06:49 PM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also

I adapted the search. Can you please test again. I havn't tested yet in TaxEditor, only in test class (see code). Andreas Müller

06:45 PM feature request #9561 (Resolved): In name and taxon search if titleCache is protected the search should run on titleCache also

Applied in changeset commit:cdmlib|571eb9f1582883152db414442c0f878d7925280b. Andreas Müller

10:50 AM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also

Yes, I also thought about this but did not implement it such as I did not want to have all the subspecies in the resu... Andreas Müller

10:39 AM feature request #9561 (Feedback): In name and taxon search if titleCache is protected the search should run on titleCache also

It works as expected, but searching without authors for a titlecache with authors does not match. Maybe we should add... Katja Luther

11:06 AM feature request #8968 (Closed): filter Bulk editor for created by

created by moved, close this ticket. Katja Luther

10:53 AM bug #9533 (Resolved): NPE when reusing name for new taxon

Andreas Müller wrote:
> Andreas Müller wrote:
> > When deleting the selected name again I now get another NPE:
>
... Katja Luther

10:46 AM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

I removed that the derivatives are added to the fieldUnitDto in loadFieldUnitDto(). Katja Luther

10:42 AM task #9558 (Closed): General tests for cdmlight export

Looks fine. Katja Luther

08:38 AM bug #9565 (New): Revise name render templates selection strategy

In the flora of cuba the syn-sec. references are expected to be shown:
http://portal.cybertaxonomy.org/flora-cuba/... Andreas Kohlbecker

03/26/2021

04:23 PM task #9564 (New): synonymy: suppress output of sec references if it is equal with the accepted taxon sec ref

"Da wäre die Möglichkeit interessant, nur die sec.Refs. anzuzeigen, die NICHT die gleiche sec.-Ref. haben, die also d... Andreas Kohlbecker

04:19 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

so we should modify this service method so that it no longer add the derivatives or is there an alternative service m... Andreas Kohlbecker

04:07 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

Andreas Kohlbecker wrote:
> reopening this issue since `loadFieldUnitDTO()` is being used in the Taxeditor
>
> @K... Katja Luther

03:57 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

DerivedUnitFacadeController.doGetFieldObjectMediaDTO() is no longer using loadFieldUnitDTO see commit:3309605f
there... Andreas Kohlbecker

02:32 PM bug #9556 (Feedback): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

reopening this issue since `loadFieldUnitDTO()` is being used in the Taxeditor
@Katja: are the derivatives of the ... Andreas Kohlbecker

02:26 PM bug #9556 (Rejected): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

since the intermediate units are not used at all by consuming methods, they should be skipped completely.
Andreas Kohlbecker

12:16 PM bug #9556: occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

This method is kind of misused: After solving #9557 it is only being used by `.DerivedUnitFacadeController.doGetField... Andreas Kohlbecker

04:13 PM task #6208 (New): Implement synonymy service responding with DTO

Andreas Müller

04:07 PM task #6208: Implement synonymy service responding with DTO

I think we should reopen this ticket since we will be working on this this year Andreas Kohlbecker

04:10 PM bug #9562: Publish flag of field units and derived units are not handled correctly

this should be fixed. The problem was that the value for the publish checkbox was taken from DerivedUnitFace.isPublis... Katja Luther

04:07 PM bug #9562 (Resolved): Publish flag of field units and derived units are not handled correctly

Applied in changeset commit:taxeditor|6dd14e6fb067f81fb1deba7377d5bf81312a5991. Katja Luther

03:59 PM bug #9562 (Closed): Publish flag of field units and derived units are not handled correctly

when editing the field unit publish flag the publish flag of the derivate units are changed, too and/or not saved cor... Katja Luther

04:03 PM bug #9563 (New): MediaDTO factory method supports media representation preferences

see comment in code:
~~~java
/**
* Creates a list of DTOs from the Media entity.
* For each Medi... Andreas Kohlbecker

02:00 PM bug #9559: OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units

Andreas Kohlbecker wrote:
> The priority of this ticket depends on the question if there are projects with units whi... Andreas Müller

01:57 PM bug #9559 (New): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units

I think this ticket should be checked against #8424 and #4484 if they are duplicates of each other Andreas Müller

11:12 AM bug #9559 (Feedback): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units

The priority of this ticket depends on the question if there are projects with units which must be undisclosed and ... Andreas Kohlbecker

11:09 AM bug #9559 (New): OccurrenceServiceImpl.findRootUnitDTOs() and related methods suppress unpublished units

All methods in OccurrenceServiceImpl which deliver units for the data portal via web services need to filter out unpu... Andreas Kohlbecker

01:54 PM feature request #9561: In name and taxon search if titleCache is protected the search should run on titleCache also

Please review Andreas Müller

12:08 PM feature request #9561 (Resolved): In name and taxon search if titleCache is protected the search should run on titleCache also

Applied in changeset commit:cdmlib|9bf89673c622c6823cefe921429b1f2438dc3c0a. Andreas Müller

12:06 PM feature request #9561 (Closed): In name and taxon search if titleCache is protected the search should run on titleCache also

... otherwise users may think the name does not exist yet if the nameCache is not filled correctly.
Currently name... Andreas Müller

12:38 PM bug #9504 (Resolved): Changing term tree title is not persisted

this is fixed Katja Luther

12:00 PM bug #9557 (Closed): implement occurrence/{uuid}/rootUnitDTOs

Andreas Kohlbecker

10:39 AM bug #9557: implement occurrence/{uuid}/rootUnitDTOs

the web service `occurrence/{uuid}/rootUnitDTOs` and service method `OccurrenceServiceImpl.findRootUnitDTOs()` are mi... Andreas Kohlbecker

11:48 AM feature request #9544: In bulkeditor the strings should be copyable

this is implemented, please review. Katja Luther

10:08 AM feature request #9545: Remove "External Link type" completely

please review Katja Luther

10:08 AM feature request #9545 (Resolved): Remove "External Link type" completely

Applied in changeset commit:taxeditor|3470949e9aa012a03d23c1b0e44603ed698ee056. Katja Luther

10:00 AM feature request #9328 (Resolved): Adapt Editor to switch to originalSource for taxon secundum

this is implemented, please review. Katja Luther

09:59 AM feature request #9549 (Resolved): Reduce visible fields for nomenclatural source and secundum source in TaxEditor

this is fixed, please review. Katja Luther

03/25/2021

11:32 PM task #9558 (Resolved): General tests for cdmlight export

This is fixed. Please review. Andreas Müller

11:31 PM task #9558 (Closed): General tests for cdmlight export

all tests for cdmlight export should include an exception, error and warning test.
Also a fullDataSample (FullCove... Andreas Müller

05:54 PM bug #9557 (Closed): implement occurrence/{uuid}/rootUnitDTOs

see http://int.e-taxonomy.eu/cdmserver/integration_reference/occurrence/8259122c-7140-44f3-980e-1a6506ce8f50/fieldUni... Andreas Kohlbecker

05:52 PM bug #9556 (Closed): occurrence/{uuid}/fieldUnitDTOs web service adds duplicate units to response

see http://localhost:8080/occurrence/8585081c-b73b-440b-b349-582845cf3fb4/fieldUnitDTOs.json
the response data ma... Andreas Kohlbecker

05:22 PM bug #9555 (Closed): symbols for record basis (and kind of unit) in derivation tree

show symbols with the units-header per record basis and kind of unit if needed
A quickly assembled list:
**reco... Andreas Kohlbecker

04:03 PM feature request #9554 (New): option to suppress type designations in portal

in the http://portal.cybertaxonomy.org/flora-cuba/ typedesignations are just hidden per css. The related footnotes ar... Andreas Kohlbecker

04:01 PM bug #9553: Synonymy is missing in table of content

The same is true for Polyt. Keys Walter Berendsohn

03:50 PM bug #9553 (New): Synonymy is missing in table of content

Configuration:
* Tabless Taxon page
* Synonym as separate tab
==> the synonymy is missing in the TOC
htt... Andreas Kohlbecker

01:09 PM bug #9550 (Closed): Recognize PhytoKeys and PLoS ONE in name parser

Test run as expected. Andreas Müller

12:48 PM feature request #9552: Add e-article number to Reference

ERS:
... und so etwas ist auch nicht parsable (fascicle > 4 Zeichen): Lepyrodiclis alinihatii Menemen & al. in Nor... Andreas Müller

09:38 AM feature request #9552 (New): Add e-article number to Reference

Journals publishing online have started giving numbers for there electronically published articles which seem to have... Andreas Müller

03/24/2021

09:58 PM task #9014 (In Progress): Unparsable name strings

Andreas Müller

04:45 PM bug #9551 (Resolved): Recognize "series" in article parsing

Applied in changeset commit:cdmlib|d9aa603aade3ded73eedd57d346e478e820073a4. Andreas Müller

04:16 PM bug #9551 (Resolved): Recognize "series" in article parsing

... maybe also books etc. Andreas Müller

02:20 PM bug #9550 (Resolved): Recognize PhytoKeys and PLoS ONE in name parser

Applied in changeset commit:cdmlib|a119dab72f372797dc5e8afd8f34c53baa3e7440. Andreas Müller

02:19 PM bug #9550 (Closed): Recognize PhytoKeys and PLoS ONE in name parser

e.g. Pseudopodospermum baeticum (DC.) Zaika & al. in PhytoKeys 137: 68. 2020 Andreas Müller

11:25 AM feature request #8920: Make reference URL available in details view

WGB:
Erstmal zum Direktlink zur Literatur-URL aus dem Details-VIew – fände ich wirklich toll (siehe ganz unten), d... Andreas Müller

11:19 AM feature request #9549: Reduce visible fields for nomenclatural source and secundum source in TaxEditor

WGB:
Wenn Ihr an dieser Stelle schon am Arbeiten seid: Nochmal zum neuen Dialog, mit dem ich gar nicht glücklich b... Andreas Müller

11:15 AM feature request #9549 (Closed): Reduce visible fields for nomenclatural source and secundum source in TaxEditor

Currently it shows the fields "type" and "description" for links and "original information", "idNamespace" and "idInS... Andreas Müller

11:03 AM feature request #9548 (New): Handle links to websites, webapps or similar in image galleries (simple and UV)

Sometimes users use links to websites within an image gallery. These usually are identified by mime type "text/html",... Andreas Müller

10:59 AM feature request #9547 (New): Show warning in TaxEditor if a MediaRepresentation can not be shown in a Viewer

Sometimes users use links to websites within an image gallery. These usually are identified mime type "text/html" or ... Andreas Müller

10:51 AM feature request #9067 (Closed): [DISCUSS] Allow media to support external links not being files

Andreas Kohlbecker wrote:
> I actually see no benefit of the "solutions" 2 - 4 over 1.
>
> Adding additional fiel... Andreas Müller

10:43 AM feature request #9546 (New): [DISCUSS] Merge ExternalLink and MediaRepresentation

... once MediaRepresentation has been merged with MediaRepresentationPart
Both classes store common information li... Andreas Müller

10:24 AM feature request #9296: Preference to show/not show infrageneric epithet for species

NK:
zufällig bin ich nun wieder auf den Hintergrund in der Botanik gestoßen:
Code, https://www.iapt-taxon.org/n... Andreas Müller

10:01 AM feature request #9545 (Closed): Remove "External Link type" completely

There is no real need for the ExternalLink.type attribute as today browsers all know how to open e.g. pdf. This was a... Andreas Müller

09:52 AM bug #9538 (Closed): Changing accepted to synonym closes name editor tab even if canceled

I also can't reproduce anymore. So I close and reopen if it appears again. Andreas Müller

08:36 AM bug #9538 (Resolved): Changing accepted to synonym closes name editor tab even if canceled

I can't reproduce this exception, also on nightly version. Maybe there was a state where the exception appeared. Katja Luther

09:20 AM bug #9542 (Closed): Bulk Editor search does not work after opening a name out of the bulk editor

Works as expected and code looks reasonable. Andreas Müller

03/23/2021

01:43 PM feature request #9544: In bulkeditor the strings should be copyable

I guess this is fast to implement. If not, remove the tag. Andreas Müller

11:54 AM feature request #9544 (Closed): In bulkeditor the strings should be copyable

The user should be able to copy out of all columns in bulkeditor. Katja Luther

03/22/2021

02:38 PM bug #9543 (New): Revise, harmonize media list in SpecimenOrObservationBaseDTO vs. DerivedUnitFacade.getMediaTextData()

`DerivedUnitFacade.getMediaTextData()` is being used to provide the media lists for the `DerivedUnit` and `FieldUnit`... Andreas Kohlbecker

11:31 AM bug #9504: Changing term tree title is not persisted

Not sure if this is fast but I could imagine that it is. Andreas Müller

10:46 AM bug #9542: Bulk Editor search does not work after opening a name out of the bulk editor

I guess this is for reveiew Andreas Müller

10:40 AM bug #9542 (Resolved): Bulk Editor search does not work after opening a name out of the bulk editor

Applied in changeset commit:taxeditor|e2d8b4196539aeb0c3e1a587026ca46ce1f1034a. Katja Luther

08:19 AM bug #9542 (Closed): Bulk Editor search does not work after opening a name out of the bulk editor

mail WHB:
Noch eine Auffälligkeit. Neoporteria planiceps ist (als Name) vorhanden.

Im Bulk Editor wird er abe... Katja Luther

10:40 AM feature request #8968 (Resolved): filter Bulk editor for created by

Applied in changeset commit:taxeditor|3767457b3f1509b425d264ef930d384d9126a0d8. Katja Luther

03/19/2021

09:02 PM feature request #9541 (Closed): Improve referencing objects handling

* DescriptionElementSource, SecundumSource and NomenclaturalStatus do now have a backlink to their referencing main o... Andreas Müller

06:15 PM feature request #9331: Distinguish DescriptionElementSource and NamedSource

This is generally solved and update script works now. The new class structure is now
~~~
OriginalSorceBase
|- Na... Andreas Müller

06:10 PM feature request #8761 (Closed): Remove TaxonName_NomenclaturalStatus MN table

This works. The MN table is not touched anymore when data is edited. Andreas Müller

04:13 PM feature request #9211 (Closed): Handle source(s) for Classification

Update script worked correctly. I close this ticket. Followup ticket for TaxEditor exists. For dataportal probably no... Andreas Müller

04:07 PM feature request #9540 (New): Handle classification source as source in TaxEditor

WIth #9211 the reference for classification became a single source. The classification wizard should be adapted accor... Andreas Müller

04:02 PM task #9315 (Closed): Remove old single source citation and microCitation columns

All columns were correctly removed on test Andreas Müller

03:55 PM feature request #9327 (Closed): Make taxon secundum reference an original source

Closing this ticket as update script worked successfully on test server. Followup tickets for dataportal and taxedito... Andreas Müller

03:46 PM feature request #9332 (Closed): Rename TypeDesignationBase.source to .designationSource

Andreas Müller

03:39 PM feature request #9507: Add ratioTo structure to Character

AM:
ratioTo ist modellseitig jetzt implementiert und muss nur noch im TaxEditor zur Verfügung gestellt werden.
... Andreas Müller

03:32 PM feature request #9507 (Closed): Add ratioTo structure to Character

Andreas Müller

03:25 PM task #9330 (Closed): Remove "NomenclaturalSource" from OriginalSourceType

Andreas Müller

03:20 PM feature request #8876 (Rejected): nom. & gen. cons.

AM:
Allerdings frage ich mich gerade, ob der neue Status wirklich „nom. & gen. cons.“ oder nur „gen. cons.“ heißen... Andreas Müller

02:21 PM bug #9538 (Feedback): Changing accepted to synonym closes name editor tab even if canceled

I do now get:
~~~
last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/classification... Andreas Müller

12:23 PM bug #9538: Changing accepted to synonym closes name editor tab even if canceled

Moved the close right before the creation of the operation, so also cancel of sec handling wizard does not close the ... Katja Luther

12:21 PM bug #9538 (Resolved): Changing accepted to synonym closes name editor tab even if canceled

Applied in changeset commit:taxeditor|1103c727e0bcd2b58e88cfb536340490655d1429. Katja Luther

11:27 AM bug #9538 (Closed): Changing accepted to synonym closes name editor tab even if canceled

When calling accepted to synonym on a taxon opened in name editor the tab is closed before the dialogue to select the... Andreas Müller

01:07 PM feature request #8968 (Feedback): filter Bulk editor for created by

Works as expected. I suggest to move the column before ID and UUID. But I am not sure. Generally the ticket can be cl... Andreas Müller

01:02 PM feature request #9515: Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

I have renamed the method to set the description to the import state to get/setIndividualsAssociationDescriptionPerTa... Andreas Müller

12:56 PM feature request #9515 (Feedback): Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

Have you tested with a real import that it works? Andreas Müller

12:42 PM feature request #9518 (Closed): Add symbol to descriptions having status individual association in facts view

Works as expected Andreas Müller

12:23 PM feature request #9079: Move supported and available for parts of feature detail element to sections

A similar availableFor section we will also have for Types like ExtensionType, AnnotationType, MarkerType and Identif... Andreas Müller

12:22 PM feature request #9539 (In Progress): Implement availableFor for ExtensionType, MarkerType, AnnotationType and IdentifierType

Similar to Features #9027
We may need to decide for all existing Types what they should support by default. Also w... Andreas Müller

12:09 PM bug #6182 (Rejected): Emptying protolog URI does not work

As protologues are now handled as nomenclatural source external links this problem does not exist anymore. For extern... Andreas Müller

12:05 PM bug #6686: Correct handling for chromatograms in dataportal

This is somehow related to specimen handling and to media handling Andreas Müller

12:02 PM feature request #8920: Make reference URL available in details view

So I guess the button should be at one of the following positions:
Whenever there is a DO... Andreas Müller

11:44 AM bug #8837 (Worksforme): Name editor is not updated after change accepted to synonym

For me this seems to be fixed. The name editor of the old accepted taxon is closed and the new synonym appears in the... Andreas Müller

11:17 AM bug #8831 (Worksforme): saving name editor throws NPE

This appeared before parsing and deduplication was handled serverside (#9078). Since then it was not observed anymore... Andreas Müller

09:18 AM bug #8955: After saving a taxon the taxon navigator scrolls the taxon to the bottom

AM:
ist eigentlich schon implementiert, dass der Navigator bei NameEditor-Save nur aktualisieren muss, wenn der Kn... Andreas Müller

07:55 AM bug #8421 (Rejected): icons in compose_specimen_table_top_down() are not visible

with the new implementation of the derivation tree view this has become obsolete, see #7599 & #6866 Andreas Kohlbecker

07:26 AM feature request #8463: Make DeterminationEvent.references sources

Currently this is not yet available in TaxEditor at all and it is questionable if we need multiple sources at all. I ... Andreas Müller

03/18/2021

11:51 PM feature request #9211 (Resolved): Handle source(s) for Classification

Andreas Müller

09:56 PM feature request #8761 (Resolved): Remove TaxonName_NomenclaturalStatus MN table

Andreas Müller

06:46 PM feature request #9114: Handle malformed URIs in user type

This ticket seems to be done or needs to be splitted into an open issues ticket. It can be moved back to 5.19(?) afte... Andreas Müller

06:41 PM bug #8233: [Follow up] Creating type duplicates

I add the "fast" tag for the last issue ("Add "Preferred Stable Identifier" to the list of available identifiers"). I... Andreas Müller

06:37 PM bug #8421: icons in compose_specimen_table_top_down() are not visible

I think this should be assigned to AK Andreas Müller

06:36 PM bug #8659: Taxon navigator: not refreshed after ABCD file import

Is this still an open issue? I think refresh now runs after all imports.
If fixed please close as duplicate or wor... Andreas Müller

06:24 PM feature request #8922: Make setting of sec-Reference configurable when moving synonyms.

I flag this as fast as it is problably fixed already. Andreas Müller

06:22 PM feature request #8930: Publishable objects should show icon if they are unpublished

Katja Luther wrote:
> mail WB:
>
> In diesem Zusammenhang wollte ich auch anregen, die als doubtful markierten Ta... Andreas Müller

05:54 PM bug #8971: Long running tasks in taxon navigator should disable the navigator

Andreas Müller wrote:
> WGB:
>
> hier nur nochmal die Bestätigung, dass das ein an verschiedenen Stellen auftrete... Andreas Müller

05:40 PM feature request #9089: Show descriptive datasets in description details view

The read only version maybe is fast to implement? Andreas Müller

05:37 PM feature request #9139: When deleting a taxon with images the configuration should also handle the image

is this fast? Andreas Müller

05:32 PM feature request #9298: Preference for IDinSource, IdNamespace and original information in nomenclatural reference details view

I guess this is fast? Andreas Müller

05:31 PM feature request #9321: Make availability of pro-parte synonyms configurable

I guess this is fast to implement? Andreas Müller

05:30 PM feature request #9328 (In Progress): Adapt Editor to switch to originalSource for taxon secundum

This needs to be implemented as soon as the model changes are committed. Andreas Müller

05:29 PM feature request #9333: Preference for display of protologue section in nomenclatural source section

I think the second part of the description "Additionally we should ..." is already implemented. Is that true? If yes,... Andreas Müller

05:28 PM feature request #9333: Preference for display of protologue section in nomenclatural source section

Hi Katja, what do you think should we reuse the preference? Is it difficult to hide the external link part in the nom... Andreas Müller

05:21 PM feature request #9370: Search in media bulk editor should include search on URI

Maybe a like search is not possible here as it is a CLOB field. We had something similar for Rights search recently (... Andreas Müller

05:00 PM bug #9532 (In Progress): Check whether all data are loaded for NameEditor

Andreas Müller

03:21 PM feature request #9332 (Resolved): Rename TypeDesignationBase.source to .designationSource

This is solved in cdmlib but we need to check if it works in TaxEditor and vaadin Andreas Müller

12:40 PM task #9330 (Resolved): Remove "NomenclaturalSource" from OriginalSourceType

NomenclaturalSource does not make sense as source type anymore (same as potential new source type secundum source). T... Andreas Müller

11:47 AM feature request #9331 (Resolved): Distinguish DescriptionElementSource and NamedSource

Andreas Müller

10:53 AM bug #8723 (Worksforme): Distribution detailsview: changing the area removes the state

This seems to be fixed in the meanwhile. The status is only removed if the status selection does not match to the pos... Katja Luther

10:21 AM feature request #8968 (Resolved): filter Bulk editor for created by

please review Katja Luther

10:20 AM feature request #8968 (New): filter Bulk editor for created by

Added a new column 'created by' which is sortable. Katja Luther

10:20 AM feature request #8968 (Resolved): filter Bulk editor for created by

Applied in changeset commit:taxeditor|57fd518bd253736b63310ea0fde64d96df21569d. Katja Luther

10:14 AM feature request #9518: Add symbol to descriptions having status individual association in facts view

I guess this is for review Andreas Müller

10:12 AM feature request #9518 (Resolved): Add symbol to descriptions having status individual association in facts view

Applied in changeset commit:taxeditor|76156fc08bc63b480d62d46c945be2897bd65f98. Katja Luther

10:04 AM feature request #9515: Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

please review Katja Luther

10:02 AM feature request #9515 (Resolved): Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

Applied in changeset commit:cdmlib|25935ad5dc1e7e1ef297198e5ca0148e36f25230. Katja Luther

10:00 AM feature request #9515: Add DescriptionType to TaxonDescription of TaxonAssociations in ABCD import

Now a description with type IndivialsAssociation is created or if already existing used to add the individual associa... Katja Luther

03/17/2021

11:08 PM feature request #9331 (In Progress): Distinguish DescriptionElementSource and NamedSource

Andreas Müller

10:15 PM feature request #9537 (Feedback): Implement ratioToStructure in TaxEditor

for details see #9507.
We also need an according default formatting for the new character. Andreas Müller

10:14 PM feature request #9507 (Resolved): Add ratioTo structure to Character

ratioToStructure added.
If ratioTo modifier is also needed open new ticket. Andreas Müller

10:04 PM feature request #9327 (Resolved): Make taxon secundum reference an original source

Andreas Müller

07:28 PM task #9536 (Closed): Remove old single source citation and microCitation columns for secundum and DescriptionElementBase_OriginalSourceBase and TaxonName_NomenclaturalStatus

and Classification.source (#9211)
Secundum: #9327
follow up for #9315
~~~

//#9536
... Andreas Müller

07:24 PM task #9315 (Resolved): Remove old single source citation and microCitation columns

Andreas Müller

07:16 PM bug #9007: Enable i18n support for media description UI

This seems to be partly fixed. I18n support exists for media description and for media title.
@Katja, can you please... Andreas Müller

06:58 PM feature request #8922: Make setting of sec-Reference configurable when moving synonyms.

Katja, can you have a look if this is a real duplicate for #9340 and, if it is, close it as duplicate? Andreas Müller

05:48 PM bug #9535 (Closed): harmonize DefinedTermBase and KeyTerm serializations

Andreas Kohlbecker

05:41 PM bug #9535 (Closed): harmonize DefinedTermBase and KeyTerm serializations

DefinedTermBase and KeyTerms are serialized differently:
DefinedTermBase:
~~~json
{
'representation_L10n': ... Andreas Kohlbecker

02:19 PM feature request #9329: Implement sec reference as original source in dataportal

AK:
diese Werte stehen werden an eu.etaxonomy.cdm.remote.json.util.CardinalityPropertyFilter.setExceptions() überg... Andreas Müller

01:35 PM bug #9533: NPE when reusing name for new taxon

Andreas Müller wrote:
> When deleting the selected name again I now get another NPE:
Also the free text name is n... Andreas Müller

01:32 PM bug #9533 (Feedback): NPE when reusing name for new taxon

When deleting the selected name again I now get another NPE:
~~~
last remote method : http://api.cybertaxonomy.or... Andreas Müller

09:18 AM bug #9533 (Resolved): NPE when reusing name for new taxon

This is fixed, but should be released with an hotifx release.
Please review. Katja Luther

08:00 AM bug #9533 (Closed): NPE when reusing name for new taxon

Using an existing name for a new taxon results in a NPE because of a missing text in textfield for the name. Katja Luther

09:22 AM bug #9534 (New): Filtering of reference type does not work correctly

When enter an 'a' into the drop down for the referencetype and clicking on 'Article' does not work. Katja Luther

12:20 AM bug #8857: NonUniqueObjectException when creating new taxon

I fully removed saveNewTaxonNode now as it is not in use and is not really save. The createTaxonNode method can be us... Andreas Müller

03/16/2021

01:51 PM bug #9527: Consensus Sequence Details: Consensus Sequence 5' -> 3' limit characters to [aAcCgGTtUu\s]

the regex is now complete according to the notation found on https://en.wikipedia.org/wiki/Consensus_sequence Andreas Kohlbecker

12:14 PM bug #9531 (Resolved): Add Names in OriginalSpelling to the delete configuration

this should be fixed, please review. Katja Luther

09:40 AM bug #9532 (In Progress): Check whether all data are loaded for NameEditor

The loading of a taxon takes a lot of time, especially the supplemental data view needs several database calls. The p... Katja Luther