Project

General

Profile

Activity

From 01/12/2021 to 02/10/2021

02/10/2021

10:51 PM Revision 6eee71ca (cdm-vaadin): cleanup
Andreas Müller
04:58 PM bug #9465 (Closed): Open in ... NameEditor for orphan taxa results in CCE
For orphan taxa "open in... " presents the possibility NameEditor but this results in a ClassCastException:
~~~ te...
Katja Luther
11:57 AM bug #9461: Filter in vaadin distribution editor does not work
Andreas Müller wrote:
> The last commit seems to fix this issue. Can you please review.
Code changes look good. A...
Andreas Kohlbecker
10:21 AM bug #6383 (In Progress): fatal error on git push: The remote end hung up unexpectedly
bothered and thus "motivated" by the severe problems during the last two releases I returned to this issue.
For th...
Andreas Kohlbecker
10:07 AM Revision c3aec859 (taxeditor): removing .classpath file from merge strategy configuration - file is no longer in git
Andreas Kohlbecker
10:04 AM Revision 266a4ad3 (taxeditor): configuring eu.etaxonomy.taxeditor.printpublisher/build.properties with merge=ours
Andreas Kohlbecker
09:58 AM feature request #9464 (Duplicate): Show all team members in agent selection dialog
This is very much related to #9326. Generelly we should store all authors in titleCache, not only the first3 or 4. On... Andreas Müller
09:05 AM feature request #9464 (Duplicate): Show all team members in agent selection dialog
TitleCache of teams does not contain all team members therefore it is difficult to differ teams with same first team ... Katja Luther
09:58 AM feature request #9326: Show all authors in bibliographic references
Generally all authors should be stored in Agent.titleCache as mentioned in #9464. So we need to implement it there fi... Andreas Müller
09:56 AM Revision e7ac6a0e (taxeditor): fixing wrongly merged version numbers (AK)
jenkins
09:50 AM Revision 12749d66 (taxeditor): Merge branch 'release/5.20.0' into develop
Conflicts:
eu.etaxonomy.taxeditor.printpublisher/build.properties
jenkins
09:40 AM Revision 13277946 (cdm-server): Merge branch 'release/5.20.0' into develop
jenkins
09:39 AM Revision 2b90c630 (cdm-server): updating poms for branch'release/5.20.0' with non-snapshot versions
jenkins
09:38 AM Revision 8431c272 (cdm-webapp): Merge branch 'release/5.20.0' into develop
jenkins
09:38 AM Revision 6ab62982 (cdm-webapp): jenkins merging release branch into master (strategy: theirs)
jenkins
09:38 AM Revision f1fdc36e (cdm-webapp): updating poms for branch'release/5.20.0' with non-snapshot versions
jenkins
09:38 AM Revision 9970e989 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.20.0
jenkins
09:38 AM Revision 91002240 (cdm-vaadin): Merge branch 'release/5.20.0' into develop
jenkins
09:38 AM Revision f3bbf62c (cdm-vaadin): jenkins merging release branch into master (strategy: theirs)
jenkins
09:36 AM Revision 02724e26 (taxeditor): Merge branch 'release/5.20.0'
jenkins
09:34 AM Revision eacbd577 (cdm-dataportal): updating poms for branch'release/5.20.0' with non-snapshot versions
jenkins
09:34 AM Revision 090aecb0 (cdm-vaadin): updating poms for branch'release/5.20.0' with non-snapshot versions
jenkins
09:34 AM Revision a85f6615 (cdm-dataportal): release-preparation: production level css
jenkins
09:34 AM Revision f7a2f252 (cdm-vaadin): jenkins bumping cdmlib.version to 5.20.0
jenkins
09:34 AM Revision f1f7cac5 (cdmlib): Updating develop poms back to pre merge state
jenkins
09:34 AM Revision c717d03a (cdmlib): Merge branch 'master' into develop
jenkins
09:34 AM Revision a6cd7091 (cdmlib): updating develop poms to master versions to avoid merge conflicts
jenkins
09:33 AM Revision 1afea7af (cdmlib): Merge branch 'release/5.20.0'
jenkins
09:18 AM Revision 61eb8f33 (cdmlib): updating poms for branch'release/5.20.0' with non-snapshot versions
jenkins
09:14 AM Revision 5d6e7996 (taxeditor): Updated version in pom / project files to taxeditor version : 5.21.0-SNAPSHOT and cdmlib version : 5.21.0-SNAPSHOT
jenkins
09:14 AM Revision 3ff4bb64 (taxeditor): Updated version in pom / project files to taxeditor version : 5.20.0 and cdmlib version : 5.20.0
jenkins
08:58 AM Revision d5cbb74e (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.20.0-SNAPSHOT
jenkins
08:58 AM Revision ce822a40 (cdm-webapp): updating poms for 5.21.0-SNAPSHOT development
jenkins
08:58 AM Revision b31071bc (cdm-webapp): updating poms for 5.20.0 branch with snapshot versions
jenkins
08:58 AM Revision 3d3ae548 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.21.0-SNAPSHOT
jenkins
08:56 AM Revision 2345a6b8 (cdm-vaadin): jenkins bumping cdmlib.version to 5.20.0-SNAPSHOT
jenkins
08:56 AM Revision 3f36a33a (cdm-vaadin): updating poms for 5.21.0-SNAPSHOT development
jenkins
08:56 AM Revision bcb95b6c (cdm-vaadin): updating poms for 5.20.0 branch with snapshot versions
jenkins
08:56 AM Revision a2533843 (cdm-vaadin): jenkins bumping cdmlib.version to 5.21.0-SNAPSHOT
jenkins

02/09/2021

04:18 PM bug #9461 (Resolved): Filter in vaadin distribution editor does not work
The last commit seems to fix this issue. Can you please review. Andreas Müller
10:53 AM bug #9461 (Resolved): Filter in vaadin distribution editor does not work
Previously the filter in the distribution editor did throw an exception (see #7254 and #9457). This is not the case a... Andreas Müller
04:16 PM bug #9457 (Closed): Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
I created a new ticket for the non-working filter: #9461 . So I think we can close this ticket. Andreas Müller
03:43 PM Revision 8716ab07 (cdm-vaadin): updating poms for 5.21.0-SNAPSHOT development
jenkins
03:43 PM Revision 8bdb22c3 (cdm-vaadin): updating poms for 5.20.0 branch with snapshot versions
jenkins
03:42 PM Revision 5d7f85d9 (cdm-vaadin): jenkins bumping cdmlib.version to 5.21.0-SNAPSHOT
jenkins
03:42 PM Revision 2a7584b5 (cdm-dataportal): updating poms for 5.21.0-SNAPSHOT development
jenkins
03:42 PM Revision 22c02b72 (cdm-server): updating poms for 5.21.0-SNAPSHOT development
jenkins
03:39 PM Revision 1e333422 (cdmlib): updating poms for 5.21.0-SNAPSHOT development
jenkins
02:12 PM Revision 4672fa5f (cdm-vaadin): ref #9461 try to fix not working filter by using dto not dtos
Andreas Müller
02:12 PM Revision 4ad518e4 (cdm-vaadin): cleanup
Andreas Müller
01:43 PM bug #9463 (In Progress): UniversalViewer causes jQuery version conflict and breaks maps
Andreas Kohlbecker
11:46 AM bug #9463 (In Progress): UniversalViewer causes jQuery version conflict and breaks maps
When taxon pages are configured tab-less the image-viwer (Universalviewer - UV) is shown together with maps on the sa... Andreas Kohlbecker
12:01 PM Revision 5027d200 (cdmlib): Revert "ref #7529 adding PUBLISH group to FirstDataInserter - handing case when group with same name exists"
This reverts commit 5b133131725616c83c01e16e8bb5acca008ed33e. Andreas Kohlbecker
12:01 PM Revision e74a407f (cdmlib): Revert "ref #7529 adding PUBLISH group to FirstDataInserter - handing case when group with same name exists"
This reverts commit c5893c96fc9ee990944ec5f5f75bf0ba29bce428. Andreas Kohlbecker
11:36 AM bug #9462 (New): polytomous key generated from structured descriptions supported
Example:
https://test.e-taxonomy.eu/dataportal/preview/caryophyllales_spp/cdm_dataportal/polytomousKey/f36b96a1-92...
Andreas Kohlbecker
11:19 AM bug #7254 (Worksforme): Filter in vaadin distribution editor throws exception
An exception is not thrown anymore. However, the filter still does not work, therefore a new ticket was opened: #9461. Andreas Müller
11:07 AM Revision e6d5c3e2 (cdmlib): ref #9457 , ref #9461 fix incorrect handling of AND/OR logic in doubtfulPattern handling in TaxonNodeDaoHibernateImpl.getUuidAndTitleCache
Andreas Müller
11:00 AM Revision c5893c96 (cdmlib): ref #7529 adding PUBLISH group to FirstDataInserter - handing case when group with same name exists
Andreas Kohlbecker
10:55 AM bug #9143: Distribution data sources are missing if multiple distributions exist
ERS: Hi, this looks good now on the test portal for the mentioned areas. Andreas Müller
10:02 AM bug #9143 (Closed): Distribution data sources are missing if multiple distributions exist
I tested on test https://test.e-taxonomy.eu/dataportal/preview/euromed/cdm_dataportal/taxon/229a548c-fec8-4f15-9058-8... Andreas Müller
10:37 AM Revision 5b133131 (cdmlib): ref #7529 adding PUBLISH group to FirstDataInserter - handing case when group with same name exists
Andreas Kohlbecker
09:57 AM bug #7529 (Closed): Wrong UUID after creating a GrantedAuthority for a Role like ROLE_PUBLISH
verified at some test databases: works as expected. Andreas Kohlbecker
09:39 AM bug #6324 (Closed): fix dozer mapping after removal of synonym relations and after using TaxonNode
Andreas Müller
09:29 AM bug #6324: fix dozer mapping after removal of synonym relations and after using TaxonNode
Andreas Müller wrote:
> No there is no custom converter in use yet for field taxonNodes. But ofcourse we use it else...
Andreas Kohlbecker
08:36 AM task #9460 (New): REST API tests
see #9459 for general considerations which also apply to this task, at least to a significant extend. Andreas Kohlbecker
08:17 AM task #9459 (New): REST API tests for UTIS
There is already a test suite http://int.e-taxonomy.eu/jenkins/job/utis-jmeter-tests/ which could be repaired.
Oth...
Andreas Kohlbecker
12:50 AM Revision 7ceaa4ea (cdmlib): cleanup
Andreas Müller
12:48 AM Revision 99cb169f (cdmlib): unignore FloraCubaCondensedDistributionComposerTest
Andreas Müller

02/08/2021

11:14 PM Revision 9697d9fc (cdmlib): add missing cultivated presence questionable term to test terms (to fix failing CubaCondensedDistributionTest)
Andreas Müller
10:48 PM Revision f6e4b1b3 (cdmlib): fix duplicated uuid and remove all created information from test terms
Andreas Müller
10:18 PM Revision 53b5dc9b (cdmlib): add missing reported in error term to test terms (to fix failing CubaCondensedDistributionTest
Andreas Müller
09:13 PM Revision 262288e1 (cdmlib): revert removing UTF-8 from EuroPlusMedCondensedDistributionComposer
Andreas Müller
07:07 PM bug #9443 (Closed): Improve handling of TissueSamples and others in SpecimenTreeEditor
looks fine and works as expected. Katja Luther
10:57 AM bug #9443: Improve handling of TissueSamples and others in SpecimenTreeEditor
Katja, can you check the commits of this ticket again if they look ok? Generally this ticket was reverted, however th... Andreas Müller
10:55 AM bug #9443: Improve handling of TissueSamples and others in SpecimenTreeEditor
The commit message of the last commit "handling tissue samples as DerivedUnit" was incorrect. Should be "**revert** h... Andreas Müller
07:01 PM bug #5670 (In Progress): Refresh of Taxon Navigator
First issues:
- add a parameter whether the navigator should be updated or not.
- do not refresh the navigator ...
Katja Luther
05:04 PM Revision a76f9136 (cdmlib): simplify grouping in EuroPlusMedCondensedDistributionComposer
Andreas Müller
05:03 PM Revision 20e0055b (cdmlib): cleanup
Andreas Müller
04:54 PM Revision 6b579e4a (cdmlib): ref #7287 unignore tests on CondensedDistributionComposerBase subclasses
Andreas Müller
04:54 PM Revision 2dae2fcc (cdmlib): cleanup
Andreas Müller
04:49 PM bug #7287: Unit tests using the DefaultTermInitializer break subsequent integration tests in the suite
Andreas Kohlbecker wrote:
> After using the new unit test base class TermTest for all test which need the terms to b...
Andreas Müller
04:27 PM bug #9457 (Feedback): Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
I aimed in testing the fix in the vaadin distribution editor itself ... the exception no longer occurs but no taxon r... Andreas Kohlbecker
11:15 AM bug #9457: Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
By the way, please do not use the "cdmlib - Next Major Release" anymore. It is deprecated and will be closed soon, af... Andreas Müller
11:13 AM bug #9457: Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
Can you please review. I only fixed in theory, did not test. Andreas Müller
10:47 AM bug #9457 (Resolved): Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
Applied in changeset commit:cdmlib|e0e956a86c917a9f70f0acbbd03eaebc2a7535cc. Andreas Müller
10:29 AM bug #9457 (Closed): Distribution editor: Taxon filter broken due to invalid HQL in TaxonNodeServiceImpl.getUuidAndTitleCache()
to reproduce:
* http://api.cybertaxonomy.org/flora-cuba/app/distribution
* Enter any string into the Taxon filter...
Andreas Kohlbecker
03:22 PM bug #7529 (Resolved): Wrong UUID after creating a GrantedAuthority for a Role like ROLE_PUBLISH
Applied in changeset commit:cdmlib|b8dd2aa39122e68351a1591e11a4dc12751fdc2e. Andreas Kohlbecker
03:21 PM Revision b8dd2aa3 (cdmlib): fix #7529 adding PUBLISH group to FirstDataInserter
Andreas Kohlbecker
02:59 PM bug #9351 (Closed): Include new locations for cdmlib-print and cdmlib-remote in jenkins release script
fixed in server-scripts:
~~~
svn ci -m "ref #9351 support for setting version in multiple projects & fixing some...
Andreas Kohlbecker
12:04 PM task #9448 (In Progress): Remove all not e4 classes and rename "Remoting..." classes
KL:
soweit ich es sehe, betraf das vor allem das io package, ich habe das aufgeräumt. An anderer Stelle habe ich n...
Andreas Müller
11:48 AM bug #6324: fix dozer mapping after removal of synonym relations and after using TaxonNode
No there is no custom converter in use yet for field taxonNodes. But ofcourse we use it elsewhere e.g. here
~~~
...
Andreas Müller
10:14 AM bug #6324: fix dozer mapping after removal of synonym relations and after using TaxonNode
I could not inspect all code changes in depth as this would require more time to dive into the whole topic of relatio... Andreas Kohlbecker
11:15 AM bug #6450 (Resolved): New reference with only the protected titleCache set is not found in reference select dialog
The problem was that if no abbrevTitle exists the titleCache was used, now the abbrevTitleCache. Katja Luther
11:15 AM Revision 9c32f328 (taxeditor): ref #6450: show abbrev titlecache in nomenclatural ref selection dialog for new reference
Katja Luther
11:11 AM Revision 6ca6c48f (cdmlib): cleanup
Andreas Müller
11:11 AM Revision 1606ebde (cdmlib): ref #9457 fix missing space in HQL (cont.)
Andreas Müller
10:47 AM Revision e0e956a8 (cdmlib): fix #9457 fix missing space in HQL
Andreas Müller
10:45 AM task #9458 (Closed): Consider lower zoom level as default
currently the default zoom level for maps is `15`
This causes two problems with occurrence maps
* some maps onl...
Andreas Kohlbecker
09:02 AM bug #9456: Sources of Descriptive Datasets visible
This is more or less a duplicate for #7716. We should think about closing it as a duplicate. This is not true if we r... Andreas Müller
08:54 AM bug #9456 (New): Sources of Descriptive Datasets visible
Sources of Descriptive Datasets are not yet shown in the Dataportal.
"Derzeit werden alle Datasets gemerged und di...
Andreas Kohlbecker

02/06/2021

10:10 PM feature request #9427: Code cleaning in CdmPreferenceCache
I did some further reduncancy removal. Please check the code and test once if loading still works as expected. Then w... Andreas Müller
10:09 PM Revision 543d3926 (taxeditor): ref #9427 further remove redundant code by parameterized method call
Andreas Müller
10:07 PM Revision 3395c0c6 (taxeditor): cleanup
Andreas Müller
09:54 PM bug #9143 (Resolved): Distribution data sources are missing if multiple distributions exist
Andreas Müller
09:33 PM Revision 4681378d (cdmlib): rename method
Andreas Müller
09:32 PM Revision 8b352348 (cdmlib): fix compilation issue in SetMap
Andreas Müller
09:11 PM Revision 6c6272d1 (cdmlib): cleanup
Andreas Müller
09:03 PM Revision a8de3c3c (cdmlib): ref #9143 rename variable name for preferComputed->preferAggregated and update javadocs
Andreas Müller
08:45 PM Revision f20e21fb (cdmlib): ref #9143 remove preferComputed rule as default from calling DefilterDistributions.filterDistributions(...) methods
Andreas Müller
08:38 PM Revision 990da774 (cdmlib): use SetMap in DescriptionUtility
Andreas Müller
06:44 PM feature request #5575 (Resolved): DNA Sample requires CacheStrategy
Andreas Müller

02/05/2021

06:47 PM feature request #9434 (Closed): Add pollen, leaf and trichomes to tissue sample kind-of-unit vocabulary
New terms are available on test server instances. So it sees to work and I close the ticket. Andreas Müller
06:45 PM bug #9426 (Closed): Set publish flag for Synonyms in accordance with accepted taxon publish flag
Works as expected Andreas Müller
06:39 PM bug #5095 (Closed): Fix failing dozer related tests
I fixed the variable name.
http://memory.loc.gov testing is not part of this ticket therefore I close this ticket....
Andreas Müller
10:35 AM bug #5095: Fix failing dozer related tests
code changes look good, test are all successful so the ticket is solved and can be closed.
I am a bit concerned th...
Andreas Kohlbecker
06:36 PM Revision ded02d5b (cdmlib): ref #5095 fixing variable name for oahServerURI
Andreas Müller
06:04 PM feature request #5575: DNA Sample requires CacheStrategy
As TissueSample are currently still handled as DnaSample modellwise (to allow adding of sequences directly without Dn... Andreas Müller
06:02 PM task #9455 (New): Merge DnaSample and DerivedUnit
In general we do not want to have too many classes to avoid transformation problems and for other reasons (see TaxonN... Andreas Müller
05:56 PM bug #9443: Improve handling of TissueSamples and others in SpecimenTreeEditor
Still need to check if AddXXX handlers now work as expected and as before. Andreas Müller
05:55 PM bug #9443 (Resolved): Improve handling of TissueSamples and others in SpecimenTreeEditor
Saving as DerivedUnit needs to be reverted as we want to allow also TissueSample to have DNA Sequences attached direc... Andreas Müller
05:51 PM Revision 4fc7f502 (taxeditor): ref #9443 handling tissue samples as DerivedUnit
Andreas Müller
05:50 PM task #9451 (Resolved): Cache strategy for classifications is missing
Please review Andreas Müller
05:49 PM task #9451 (New): Cache strategy for classifications is missing
Andreas Müller
05:24 PM task #9454 (New): [DISCUSS] Decide on using dozer or similar frameworks for mapping DTOs
Dozer or similar frameworks (https://stackoverflow.com/questions/1432764/any-tool-for-java-object-to-object-mapping) ... Andreas Müller
05:13 PM Revision e141acff (cdmlib): fix #6324 fix taxon node dozer mapping for TDWG Ontology (cont.) - add missing mappings-deep.xml changes
Andreas Müller
04:57 PM bug #6324: fix dozer mapping after removal of synonym relations and after using TaxonNode
The mapping was not only corrupt for synonyms but also for TaxonNodes as they were not mapped as taxon relations yet.... Andreas Müller
01:26 PM bug #6324 (Resolved): fix dozer mapping after removal of synonym relations and after using TaxonNode
Applied in changeset commit:cdmlib|f278f0365262de31e73b9f4bf7e442e60e3a60db. Andreas Müller
04:54 PM Revision 0f6bc0c7 (cdmlib): fix #6324 fix taxon node dozer mapping for TDWG Ontology
Andreas Müller
02:03 PM Revision 3a519edd (taxeditor): fix compile error
Andreas Müller
01:26 PM Revision f278f036 (cdmlib): fix #6324 fix synonym dozer mapping for TDWG Ontology
Andreas Müller
01:22 PM Revision 8ed8ec11 (cdmlib): ref #6324 add toString() methods to TDWG classes for debugging
Andreas Müller
01:21 PM Revision bed99e76 (cdmlib): cleanup
Andreas Müller
11:36 AM feature request #8975 (Closed): Name Status filtered in UI
Andreas Kohlbecker
11:31 AM feature request #8975: Name Status filtered in UI
Yes Wolf-Henning Kusber
11:20 AM feature request #8975 (Feedback): Name Status filtered in UI
Order changed to
~~~
NomenclaturalStatusType.CONSERVED(),
NomenclaturalStatusType.CON...
Andreas Kohlbecker
11:19 AM Revision 0e53752c (cdm-vaadin): ref #8975 changing order of name status
Andreas Kohlbecker
11:11 AM bug #9452: Name Type Editor: allowed combination of fields
put in version:"Phycobank ready for submitters" when not solved in version:"Release 5.20" Andreas Kohlbecker
11:06 AM bug #9452: Name Type Editor: allowed combination of fields
solution:
1. radiobuttons for "rejected", "conserved", "Not typified"
2. hide TypeName field when "Not typified" ...
Andreas Kohlbecker
11:00 AM feature request #9324 (Closed): Enable designation reference editing in name type designation
> Note 3: proposed types for rejection/conservation with references are missing.
we (Henning & Andreas) decided t...
Andreas Kohlbecker
10:45 AM feature request #9324: Enable designation reference editing in name type designation
example for Note 3: proposed types for rejection/conservation with references are missing.
species
Achnanthes...
Wolf-Henning Kusber
10:14 AM feature request #9324 (Feedback): Enable designation reference editing in name type designation
Wolf-Henning Kusber wrote:
> Allowing null selection for type status in name type designation editor implemented.
>...
Andreas Kohlbecker
10:00 AM bug #9453 (New): Implement NameDesignationBase.hasDesignationSource() which takes isRejected and isConserved into account
`TypeDesignationBase.hasDesignationSource()`currently directly delegates to TypeDesignationStatusBase.hasDesignationS... Andreas Kohlbecker
09:47 AM Revision 752dcdec (cdmlib): ref #6714 remove commented hibernate3-maven-plugin from pom
Andreas Müller
08:54 AM bug #8522 (Closed): Make type status mandatory in Name type designation editor
Andreas Kohlbecker
08:52 AM feature request #8981 (Feedback): Improve NameStatus in UI
I see that there are remaining requests like "Reference is restricted to a given list of Codes
Code edition was adde...
Andreas Kohlbecker
08:45 AM bug #8140 (Feedback): Update list of type designation status which allow an explicit source
in #9301 Henning
pointed out that: "paralectotype (enabled)-> reference should be disabled like the other paraty...
Andreas Kohlbecker
08:43 AM feature request #9301 (Closed): SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
Wolf-Henning Kusber wrote:
> Works as expected.
>
>
> paralectotype (enabled)-> reference should be disabled li...
Andreas Kohlbecker
08:13 AM bug #9290 (Closed): stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Andreas Kohlbecker

02/04/2021

11:56 PM Revision 432b5684 (taxeditor): cleanup
Andreas Müller
11:55 PM Revision 88ff4560 (taxeditor): ref #9359 remove objenesis from TaxEditor
Andreas Müller
11:23 PM Revision af8e4aa7 (cdmlib): ref #9359 remove test scope from objenesis
Andreas Müller
11:05 PM Revision 658ad631 (taxeditor): ref #9359 try to fix compile error in TaxEditor due to missing objenesis class (cont.) - move objenesis from printpublisher to cdmlib
Andreas Müller
10:46 PM Revision 9e42bfa8 (taxeditor): ref #9359 try to fix compile error in TaxEditor due to missing objenesis class
Andreas Müller
10:18 PM feature request #4716 (Closed): Other dependencies to be updated
Andreas Müller
08:51 PM Revision 5db155c8 (cdmlib): ref #9359, ref #5095 upgrade dozer form 5.5.1 to 6.5.0 and use dozer-spring
Andreas Müller
08:46 PM Revision 5b2db12a (cdmlib): cleanup
Andreas Müller
07:36 PM bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Reference is now selectable in relevant cases, but not anymore a default. Wolf-Henning Kusber
07:32 PM feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail

Works as expected.
paralectotype (enabled)-> reference should be disabled like the other paratypes (see above)
Wolf-Henning Kusber
07:15 PM feature request #8981: Improve NameStatus in UI
The functionality shown in the second screen is implemented and works. Wolf-Henning Kusber
07:05 PM feature request #8975: Name Status filtered in UI
The filtering is fine.
I could live with this order of the filtered terms.
But I would like also:
First the b...
Wolf-Henning Kusber
06:53 PM bug #9452 (Closed): Name Type Editor: allowed combination of fields
The Name type editor needs some fine tuning:
"not typified" (only) must not combined with a scientific name for lo...
Wolf-Henning Kusber
06:46 PM bug #8522: Make type status mandatory in Name type designation editor
works as expected, ticket can be closed Wolf-Henning Kusber
06:38 PM Revision 45e5e41d (cdmlib): ref #3403 , ref #4716, ref #3332, ref #9359 update dozer to version 5.5.1
Andreas Müller
06:32 PM feature request #9324: Enable designation reference editing in name type designation
Allowing null selection for type status in name type designation editor implemented.
Is functioning as expected.
...
Wolf-Henning Kusber
06:32 PM bug #5095: Fix failing dozer related tests
please review Andreas Müller
06:30 PM bug #5095 (Resolved): Fix failing dozer related tests
Applied in changeset commit:cdmlib|523a6c95979f449c49f9723f7d080d3cf6013cf8. Andreas Müller
06:29 PM Revision 3355e574 (cdmlib): cleanup
Andreas Müller
06:29 PM Revision 523a6c95 (cdmlib): fix #5095 unignore tests (remaining 2 tests in AssemblerTest are caused by changes in #6324)
Andreas Müller
06:26 PM Revision 0b5641a3 (cdmlib): ref #5095 avoid running dozer tests when dozer.sourceforge.net is not available
Andreas Müller
06:22 PM Revision ffc8547f (cdmlib): fixing incorrect test
Andreas Müller
06:21 PM Revision da9e578e (cdmlib): cleanup
Andreas Müller
05:56 PM Revision ad89c499 (cdmlib): ref #5095 change dozer mapping from .dtd to .xsd
Andreas Müller
05:30 PM Revision a2bbcf8a (cdmlib): cleanup
Andreas Müller
05:28 PM Revision 9e63c4cf (taxeditor): ref #9448: cleanup io package - continue
Katja Luther
05:16 PM Revision b172c7ce (taxeditor): translate specimen correctly
Katja Luther
05:08 PM Revision 87baedee (taxeditor): ref #9448: cleanup io package
Katja Luther
04:53 PM Revision ac58825c (cdmlib): ref #9114 fix dozer mapping by reverting URI mappings to java.net.URI
Andreas Müller
04:51 PM Revision fc70bf22 (cdmlib): cleanup
Andreas Müller
04:24 PM Revision ca097629 (taxeditor): do not refresh navigator if it is not needed - continue
Katja Luther
02:59 PM bug #9247 (Duplicate): Link with taxon does not work correctly
this is an exact duplicate of #9264 (even the same description text) Andreas Müller
02:22 PM bug #9247 (Worksforme): Link with taxon does not work correctly
This works now. Also if synonyms are selected. Katja Luther
01:43 PM bug #8767 (Feedback): Workflow support for publish flag
Katja Luther wrote:
> I also adapted the changeSynonymToAcceptedTaxon, the newly created taxon has the same publish ...
Andreas Müller
09:10 AM bug #8767 (Resolved): Workflow support for publish flag
Katja Luther
08:47 AM bug #8767: Workflow support for publish flag
This is fixed, also for pp synonyms.
I also adapted the changeSynonymToAcceptedTaxon, the newly created taxon has ...
Katja Luther
12:31 PM bug #8824 (Worksforme): No dirty flag when adding new factual data set
Seems to be fixed in the meanwhile. Katja Luther
11:58 AM Revision 1eeaa942 (taxeditor): do not refresh navigator if it is not needed - continue
Katja Luther
11:29 AM Revision 12cdcf1f (taxeditor): do not refresh navigator if it is not needed
Katja Luther
11:09 AM Revision 66c95313 (taxeditor): do not refresh navigator when node wizard was canceled
Katja Luther
10:54 AM Revision a5c094d3 (taxeditor): fix #9427: code cleaning
Katja Luther
10:54 AM feature request #9427: Code cleaning in CdmPreferenceCache
Please have a look. Katja Luther
10:53 AM feature request #9427 (Resolved): Code cleaning in CdmPreferenceCache
Applied in changeset commit:taxeditor|a5c094d3aeed06649e96b33d5779d86c3e92b5a3. Katja Luther
10:47 AM Revision 61cc290b (taxeditor): save should not open navigator subtree if linkWithTaxon is disabled
Katja Luther
10:12 AM Revision 1f7f3f09 (cdmlib): missed to add the new enum
Katja Luther
09:58 AM Revision 8b233e12 (cdmlib): revert setting publish in clone
Katja Luther
09:39 AM Revision 0f6a011b (cdmlib): add tests for different sec handling
Katja Luther
09:31 AM bug #8653: NullPointerException (NPE) when focusing Taxon Name Editor
I moved it to 5.11 Andreas Müller
08:55 AM bug #8653: NullPointerException (NPE) when focusing Taxon Name Editor
this ticket should still be in Release 5.11 but this MS has been closed, so it will be without until closed
Review i...
Andreas Kohlbecker
09:10 AM Revision db73ee9a (cdmlib): publish also should be cloned in TaxonBase.clone
Katja Luther
09:03 AM bug #9426 (Resolved): Set publish flag for Synonyms in accordance with accepted taxon publish flag
please review Katja Luther
08:32 AM Revision 2005ad49 (taxeditor): adapt changeSynonymToAcceptedTaxonOperation to new method parameters
Katja Luther
08:28 AM Revision 037a20f8 (cdmlib): fix publish handling for synonyms and misapplied names and add sec handling for switch syn to accepted
Katja Luther

02/03/2021

04:48 PM feature request #8611: [DISCUSS] how to handle editor teams
This is a model issue therefore I did change category and target version. Andreas Müller
03:44 PM bug #9386: orthographic variants should not be symmetrical
AM:
nein, nur die bisherige Beziehung umdeuten ist natürlich nicht geplant.
Eher sollte es so aussehen:
• Es...
Andreas Müller
03:39 PM bug #9386: orthographic variants should not be symmetrical
WGB:
ich bin nur nicht damit einverstanden, dass man das existierende Label einfach asymmetrisch macht. Das klang ...
Andreas Müller
01:13 PM task #9451 (Resolved): Cache strategy for classifications is missing
Applied in changeset commit:cdmlib|1d67f2ce2878bb557d58827fa3d7f4047715c54c. Andreas Müller
01:12 PM task #9451 (Closed): Cache strategy for classifications is missing
Currently generateTitle() is implemented within the Classification class itself. Andreas Müller
01:13 PM Revision 1d67f2ce (cdmlib): fix #9451 add ClassificationDefaultCacheStrategy
Andreas Müller
01:10 PM Revision 05f06f64 (cdmlib): ref #9443, ref #5575 tissue sample as DnaSample generation and initialization of DNA sample cache strategies
Andreas Müller
01:02 PM Revision 493cdee0 (cdmlib): ref #5575 refactor initialization of cache strategy (initialize when needed, not in constructor)
Andreas Müller
10:54 AM Revision 48b8ebbb (cdmlib): cleanup
Andreas Müller
10:36 AM Revision 35a741a0 (taxeditor): minor update variable name -continue
Katja Luther
10:09 AM bug #9450: Save reverts previous changes in NameEditor
Could not reproduce this problem.
I tried it started the editor out of my workspace but could not reproduce this is...
Katja Luther
09:54 AM bug #9450 (New): Save reverts previous changes in NameEditor
mail WGB:
Hallo, wir haben bei Polygala leptocuaulis erst die Secundum Referenz des Taxon geändert, dann den Autor...
Katja Luther
10:01 AM Revision 025f40a8 (taxeditor): minor update variable name
Katja Luther
08:45 AM Revision f349859b (taxeditor): avoid NPE
Katja Luther
08:40 AM bug #7633: MySQLIntegrityConstraintViolationException - Duplicate entry during fact editing
same exception for changing err. sec and sensu (sec.) reference:
~~~ text
last remote method : http://api.cyber...
Katja Luther
07:59 AM feature request #6016 (Rejected): ICN rules in cdm validation framework implemented
rejecting this ticket since #6015 has also been rejected, see comments there Andreas Kohlbecker
07:37 AM bug #9449 (New): Classes handling Dtos should not enherit from ICdmEntitySessionEnabled
mail AM:
beim Ticketreview bin ich gerade darauf gestoßen, dass ICdmEntitySessionEnabled die Methode
public Co...
Katja Luther
07:33 AM task #9448 (In Progress): Remove all not e4 classes and rename "Remoting..." classes
For a lot of classes there are e4 and not e4 versions, the not e4 versions are not needed anymore therefore we can re... Katja Luther
12:36 AM Revision af086d52 (cdmlib): cleanup
Andreas Müller

02/02/2021

10:40 PM Revision 828441bf (cdmlib): cleanup
Andreas Müller
06:50 PM feature request #9447 (New): Allow editing derivation events with multiple originals in specimen tree editor
Currently the specimen tree editor only allows derivation hierarchies with derivation events having only 1 "original"... Andreas Müller
06:27 PM feature request #9446 (New): Define possible derivation paths in SpecimenOrObservationType
Even in theory, not all specimenOrObservation types can be derived from all specimenOrObservation types.
We may wa...
Andreas Müller
06:06 PM task #9445 (New): [DISCUSS] Should GatheringEvent have descriptive data
Currently descriptive data on the gathering site such as ecology data, site images or water quality parameters for wa... Andreas Müller
05:54 PM feature request #9444 (New): Allow showing, editing and reusing GatheringEvent in specimen tree editor
Currently the highes level of units in the derivative tree editor is the field unit. However, in the model and in rea... Andreas Müller
04:12 PM Revision 7a03ad62 (taxeditor): ref #9443 broaden the usecases when dnasample can be added to field or derived unit
Andreas Müller
04:11 PM Revision b350a37e (taxeditor): cleanup
Andreas Müller
03:29 PM Revision aaf285ef (taxeditor): ref #9443 broaden the usecases when media can be added to field or derived unit
Andreas Müller
03:15 PM Revision bf23ce59 (taxeditor): ref #9443 fix tissue sample handling in DerivateLabelProvider
Andreas Müller
03:15 PM Revision ee4252e0 (taxeditor): ref #9443 fix tissue sample handling in SampleDesignationDetailElement
Andreas Müller
03:14 PM Revision 57cb15dd (taxeditor): cleanup
Andreas Müller
02:50 PM bug #9443 (In Progress): Improve handling of TissueSamples and others in SpecimenTreeEditor
The saving as Derived unit has been implemented in 5.19 already (a3b7c1e7f7b79) so it is now high priority to also re... Andreas Müller
02:48 PM bug #9443 (Closed): Improve handling of TissueSamples and others in SpecimenTreeEditor
Tissue Samples are handled stored as DnaSample in specimen tree editor which is not correct as they never can have an... Andreas Müller
02:26 PM feature request #9442 (New): Show warning for non conformant letter case in scientific names
Rule:
First letter in a mononomial starts with a capital letter
Exceptions: none
First letter of an epithet sta...
Wolf-Henning Kusber
01:26 PM Revision 298f5d6d (taxeditor): cleanup
Andreas Müller
01:26 PM Revision 381249d5 (taxeditor): fix CCE for TissueSample in TissueSampleGeneralDetailElement
Andreas Müller
01:26 PM Revision a37746cc (taxeditor): cleanup
Andreas Müller
11:02 AM Revision 96983561 (cdmlib): remove System.exit(-1) from CdmPersistentDataSource
Andreas Müller
11:01 AM Revision 095aad96 (cdmlib): cleanup
Andreas Müller
10:23 AM bug #9386: orthographic variants should not be symmetrical
So I think we can summerize that we agree that according to the code orthographic variants are a cluster of "names" w... Andreas Müller

02/01/2021

10:46 PM feature request #9272 (Closed): Add missing nomenclatural status
The above terms were added. A new framework for handling the status/nomenclatural standing was added in #9282. Some i... Andreas Müller
10:22 PM feature request #5794 (Closed): Move other invalid names to the end
Open issues moved to new tickets. Andreas Müller
10:20 PM feature request #5794: Move other invalid names to the end
missing handling of invalid designation name relationships moved to #9441 Andreas Müller
10:13 PM feature request #5794: Move other invalid names to the end
missing invalid designation sign (dash) in data portal moved to #9440 Andreas Müller
08:05 PM feature request #5794: Move other invalid names to the end
AM:
derzeit versuchen wir (also v.a. Walter und ich) die nomenklatorischen Status und v.a. die Namen, die lediglic...
Andreas Müller
10:19 PM bug #9441 (Closed): Move names with invalid designation name relationships to the end in taxon comparator
copied from #5794 and #9272
Names with relationship
* is later isonym of
* is later citation of
are not ye...
Andreas Müller
09:42 PM bug #9440 (New): Invalid designation sign missing for some invalid designations in data portal
The following status are missing the invalid designation symbol (dash)
* op. utique oppr.
* pro syn.
* nom. rej....
Andreas Müller
05:43 PM bug #9245: Creating derived units from existing derived unit is not possible in specimen tree editor
Andreas Müller wrote:
> This to me seems to be fixed. Katja can you check, and if true add commit and correct target...
Andreas Müller
04:06 PM feature request #7345 (Closed): [E+M] Common name references selectable in TaxEditor
I think this works and can be closed. Andreas Müller
04:05 PM feature request #7440 (Closed): E+M mark common name reference with according marker
I checked the final import result and it looks ok.
~~~
SELECT r.id, r.uuid, r.titleCache, m.flag, mt.titleCache,...
Andreas Müller
03:44 PM bug #7849 (Closed): Improve DB Preferences handling and saving in TaxEditor
Andreas Müller
03:43 PM feature request #7902 (Closed): Allow default values for PreferencePredicates
As open issues are handled in separate tickets now, we can close this one. Andreas Müller
03:42 PM feature request #7902: Allow default values for PreferencePredicates
Andreas Müller wrote:
> For boolean and/or UUIDs /UUID Lists and maybe others we may think about separate enums to e...
Andreas Müller
03:42 PM feature request #7902: Allow default values for PreferencePredicates
Andreas Müller wrote:
> Generally implemented but for existing predicates we still need to define default values.
...
Andreas Müller
03:37 PM feature request #9439 (New): Split PreferencePredicates depending on their type
copied from #7902
"For boolean and/or UUIDs /UUID Lists and maybe others we may think about separate enums to expl...
Andreas Müller
03:09 PM feature request #6016: ICN rules in cdm validation framework implemented
To me it is very unclear if we will ever work on this ticket. So for there is only one rule in a sub-issue of yet in ... Andreas Kohlbecker
02:45 PM feature request #6016: ICN rules in cdm validation framework implemented
Can you add some more information on what is required here?
And also we should set assignee, category and target ver...
Andreas Müller
02:37 PM feature request #6238 (Closed): add name of sec reference to display of concept relations in portal and a little header
I think we can close this ticket. If there is still an open issue, please reopen a new ticket. Andreas Müller
02:35 PM feature request #6043: Name export for JACQ
Is this still required? If yes, can we add a milestone? Can we close otherwise? Andreas Müller
10:53 AM bug #9290 (Resolved): stop setting Registration.citation as citation for TypeDesignations in all type editors by default
this ticket is fully solved now, please review Andreas Kohlbecker
10:51 AM feature request #9324 (Resolved): Enable designation reference editing in name type designation
allowing null selection for type status in name type designation editor implemented.
so this ticket can be reviewed
Andreas Kohlbecker
10:39 AM feature request #9324: Enable designation reference editing in name type designation
**7: no idea if we need the editon of references here (I would say: no).**
editing of references is enabled be def...
Andreas Kohlbecker
10:50 AM Revision 10f4a16e (cdm-vaadin): ref #9324 allowing null selection for type status in name type designation editor
Andreas Kohlbecker
10:34 AM feature request #9301 (Resolved): SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
can be reviewed Andreas Kohlbecker
10:33 AM feature request #9325 (Duplicate): Enable section in specimen type designation
closing as duplicate of #9301 Andreas Kohlbecker
10:22 AM Revision f756340a (cdm-vaadin): ref #9290 limiting available designation status types for nom acts without a name - NameTypeDesignationEditor & improving previous code
Andreas Kohlbecker
09:52 AM bug #7529: Wrong UUID after creating a GrantedAuthority for a Role like ROLE_PUBLISH
I seem to remember that I created this ticket in turn to an email conversation that the both of us had.
However, I d...
Andreas Kohlbecker
09:36 AM bug #7529: Wrong UUID after creating a GrantedAuthority for a Role like ROLE_PUBLISH
AK, do you still remember the context for this ticket. What did not work, what did you test, which DB was involved? Andreas Müller
09:22 AM bug #9390 (In Progress): Remaining issues for set secundum dialog
the space between the checkbox area and the text is reduced, the line break in the description part I was not able to... Katja Luther
09:07 AM Revision f85472ea (taxeditor): ref #9390: reduce the space between checkboxes and text
Katja Luther
08:15 AM Revision cb9686b7 (taxeditor): ref #9483: check publish flag permission for subtree operation
Katja Luther
08:12 AM Revision 92745e3b (taxeditor): ref #9483: check publish flag permission for synonyms
Katja Luther
08:05 AM bug #9438 (New): User without rights on publish flag can update publish flag of synonyms and subtree operations
In the details view of a taxon the publish flag is disabled for users with unsufficent rights but in the details view... Katja Luther
07:18 AM feature request #9437 (New): Show user friendly text for permission denied exception
If a user has not sufficient rights a permission denied exception is thrwon, this needs to be catched and a user frie... Katja Luther
07:13 AM bug #6273 (Duplicate): Drag&Drop a classification on the rights editing form throws NPE
Katja Luther
07:10 AM feature request #9436 (New): Save dialog should have three options
The Dialog inidcating saving is necessary should have three options:
1. Continue with saving
2. Continue without ...
Katja Luther
07:02 AM bug #9435 (New): Error when deleting without saving
mail WGB:
Hallo,
beim Löschen ist u.a. Fehler aufgetreten (ich hatte nicht vorher gespeichert, das funktionierte ...
Katja Luther

01/30/2021

12:15 AM feature request #9434 (Resolved): Add pollen, leaf and trichomes to tissue sample kind-of-unit vocabulary
Applied in changeset commit:cdmlib|6acdd1e48e6eb255265fb139ba69310ef33f9f0c. Andreas Müller
12:03 AM feature request #9434 (Closed): Add pollen, leaf and trichomes to tissue sample kind-of-unit vocabulary
NK:
Erweiterung des Vokabulars über Kind-of-Unit finde ich erstmal eine gute Idee: ja, pollen, leaf, trichomes fal...
Andreas Müller
12:13 AM Revision 6acdd1e4 (cdmlib): fix #9434 add pollen, leaf and trichomes to the PlantKindOfUnit.csv
Andreas Müller

01/29/2021

01:08 PM feature request #9433 (Closed): Improve titleCache generation for misapplications
AM: "Eine andere Alternative, die evtl. auch Sinn macht, wäre, den titleCache in Abhängigkeit davon zu berechnen, ob ... Andreas Müller
01:05 PM feature request #9432 (New): Add context menu "Add additional source" to misapplied names in TaxEditor
This will be a shortcut for creating a new misapplication using the same name as for the given misapplication.
Not...
Andreas Müller
12:43 PM bug #9351: Include new locations for cdmlib-print and cdmlib-remote in jenkins release script
the following lines in `server-scripts/jenkins-ci/taxeditor/repo-update-git.sh` need to be adapted, so that the "Mani... Andreas Kohlbecker
12:22 PM bug #9351: Include new locations for cdmlib-print and cdmlib-remote in jenkins release script
Änderung ist: cdmlib-remote und cdmlib-print waren bislang dependencies von taxeditor.cdmlib. Jetzt sind es nur noch ... Andreas Müller
11:47 AM bug #9351 (In Progress): Include new locations for cdmlib-print and cdmlib-remote in jenkins release script
Please refer to my commits above. This changing of the version in eu.etaxonomy.taxeditor.printpublisher/META-INF/MANI... Andreas Müller
11:43 AM bug #9351 (Feedback): Include new locations for cdmlib-print and cdmlib-remote in jenkins release script
This ticket is unclear to me what is meant with "jenkins release script"?
I checked `server-scripts/jenkins-ci/tax...
Andreas Kohlbecker
12:12 PM Revision 8822b122 (cdm-vaadin): ref #9290 limiting available designation status types for nom acts without a name - SpecimenTypeDesignationEditor
Andreas Kohlbecker
11:22 AM bug #8751 (Duplicate): Replace saveOrUpdate() in AbstractTermTreeEditor
For me this is a duplicate for #8774. The main reason for switching to dtos was that save did not really work. So thi... Andreas Müller
11:21 AM task #9389 (Closed): further improvement and revision of derivative filtering by type and DerivedUnitDTO
Andreas Kohlbecker
11:21 AM Revision bedede0b (cdmlib): ref #9389 removing TODO comment as the situation is clarified now
Andreas Kohlbecker
11:10 AM bug #9395 (Closed): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
Andreas Kohlbecker
11:09 AM task #9253 (Closed): revise OccurrenceServiceImpl.findFieldUnitDTO(..)
Andreas Kohlbecker
11:07 AM task #9430 (New): revise OccurrenceServiceImpl._findRootUnitDTO(..) supports multiple origin paths
Andreas Kohlbecker
11:03 AM task #9430 (New): revise OccurrenceServiceImpl._findRootUnitDTO(..) supports multiple origin paths
copied from #9253
* allow for walking multiple origin paths (second FIXME in code)
Andreas Kohlbecker
11:07 AM task #9431 (New): OccurrenceServiceImpl._findRootUnitDTO(..)
copied from #9253
* The methods `OccurrenceServiceImpl._findRootUnitDTO` and `OccurrenceServiceImpl.findRootUnitDT...
Andreas Kohlbecker
11:06 AM Revision bb3bba46 (taxeditor): ref #9351 fix cdmlib-print and -remote version in TaxEditor develop
Andreas Müller
11:05 AM Revision aa1fe054 (cdmlib): ref #9253 removing useless init strategy from within @Transactional method
Andreas Kohlbecker
10:02 AM feature request #3030: Jenkins php jobs: setup for code analysis, mess detection etc..
Andreas Müller wrote:
> Assigned and prioritized issues go to "Reviewed Next Major Release" according to out ticket ...
Andreas Kohlbecker
09:55 AM feature request #3030: Jenkins php jobs: setup for code analysis, mess detection etc..
Assigned and prioritized issues go to "Reviewed Next Major Release" according to out ticket strategy. Andreas Müller
09:30 AM feature request #3030: Jenkins php jobs: setup for code analysis, mess detection etc..
this has not yet been sovled, so it is still open.
Target Version? Unassigned? Since it is assigned and since it has...
Andreas Kohlbecker
09:35 AM bug #7579: Set up pipelines in Jenkins to replace the build pipelines
Due to the repeated problems during the last relases it has become more important to switch to the "[Jenkins Pipeline... Andreas Kohlbecker
08:52 AM bug #9429 (Closed): Taxon cache strategy handles sec details 2x in some cases
looks fine and works as expected. Katja Luther

01/28/2021

11:34 PM bug #9429: Taxon cache strategy handles sec details 2x in some cases
please review Andreas Müller
11:34 PM bug #9429 (Resolved): Taxon cache strategy handles sec details 2x in some cases
Applied in changeset commit:cdmlib|b240a635d7826790ba39aed8c110edd1253a4d80. Andreas Müller
11:32 PM bug #9429 (Closed): Taxon cache strategy handles sec details 2x in some cases
If the secundum reference is atomized (no protected titleCache, authorships exists, datePublished exists) the sec det... Andreas Müller
11:33 PM Revision b240a635 (cdmlib): fix #9429 fix duplicated sec-detail in taxon cachestrategy
Andreas Müller
11:33 PM Revision 3dd931cb (cdmlib): cleanup
Andreas Müller
10:07 PM Revision 76af2015 (taxeditor): ref #9351 fix cdmlib-print and -remote version in TaxEditor master
Andreas Müller
04:51 PM Revision 36c5a39d (taxeditor): remove duplicated result variable (from incorrect merge)
Andreas Müller
02:19 PM Revision 0e690fc1 (cdm-server): Merge branch 'release/5.19.0' into develop
jenkins
02:18 PM Revision 84ac3ea0 (cdm-server): updating poms for branch'release/5.19.0' with non-snapshot versions
jenkins
02:18 PM Revision 0f1d9fa9 (cdm-webapp): Merge branch 'release/5.19.0' into develop
jenkins
02:17 PM Revision 5cad30aa (cdm-webapp): updating poms for branch'release/5.19.0' with non-snapshot versions
jenkins
02:17 PM Revision f43b2c71 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.19.0
jenkins
01:56 PM Revision b8d65652 (taxeditor): Merge branch 'release/5.19.0' into develop
jenkins
01:56 PM Revision 0e8e733e (taxeditor): Merge branch 'release/5.19.0'
jenkins
01:54 PM Revision b37d89b9 (cdm-vaadin): Merge branch 'release/5.19.0' into develop
jenkins
01:54 PM Revision 11723a18 (cdm-vaadin): jenkins merging release branch into master (strategy: theirs)
jenkins
01:50 PM Revision 11aa3ae6 (cdm-vaadin): updating poms for branch'release/5.19.0' with non-snapshot versions
jenkins
01:50 PM Revision eacc0936 (cdm-vaadin): jenkins bumping cdmlib.version to 5.19.0
jenkins
01:50 PM Revision 5ecb0d84 (cdm-dataportal): Merge branch 'release/5.19.0' into develop
jenkins
01:50 PM Revision 9f68f082 (cdm-dataportal): updating poms for branch'release/5.19.0' with non-snapshot versions
jenkins
01:49 PM Revision 6c6615a3 (cdm-dataportal): release-preparation: production level css
jenkins
01:43 PM Revision af911bff (cdmlib): Updating develop poms back to pre merge state
jenkins
01:43 PM Revision f504641d (cdmlib): Merge branch 'master' into develop
jenkins
01:43 PM Revision 655339ef (cdmlib): updating develop poms to master versions to avoid merge conflicts
jenkins
01:43 PM Revision fcb1fc89 (cdmlib): Merge branch 'release/5.19.0'
jenkins
01:22 PM Revision da6cb609 (cdmlib): updating poms for branch'release/5.19.0' with non-snapshot versions
jenkins
01:14 PM Revision aca878a2 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.19.0-SNAPSHOT
jenkins
01:14 PM Revision f2ec937e (cdm-webapp): updating poms for 5.20.0-SNAPSHOT development
jenkins
01:14 PM Revision 001ffcb1 (cdm-webapp): updating poms for 5.19.0 branch with snapshot versions
jenkins
01:14 PM Revision cac5e963 (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.20.0-SNAPSHOT
jenkins
01:12 PM Revision 08681bf7 (cdm-vaadin): jenkins bumping cdmlib.version to 5.19.0-SNAPSHOT
jenkins
01:12 PM Revision a8bc1677 (cdm-vaadin): updating poms for 5.20.0-SNAPSHOT development
jenkins
01:12 PM Revision 1f3e51f7 (cdm-vaadin): updating poms for 5.19.0 branch with snapshot versions
jenkins
01:12 PM Revision 969c79c4 (cdm-vaadin): jenkins bumping cdmlib.version to 5.20.0-SNAPSHOT
jenkins
01:07 PM Revision 5c22df91 (cdm-vaadin): jenkins bumping cdmlib.version to 5.19.0-SNAPSHOT
jenkins
01:06 PM Revision 1fcc52c5 (cdm-vaadin): updating poms for 5.20.0-SNAPSHOT development
jenkins
01:06 PM Revision 2b50690d (cdm-vaadin): updating poms for 5.19.0 branch with snapshot versions
jenkins
01:06 PM Revision 329b8e35 (cdm-vaadin): jenkins bumping cdmlib.version to 5.20.0-SNAPSHOT
jenkins
01:04 PM Revision 0cb31f28 (taxeditor): Updated version in pom / project files to taxeditor version : 5.20.0-SNAPSHOT and cdmlib version : 5.20.0-SNAPSHOT
jenkins
01:04 PM Revision c5eccbb4 (taxeditor): Updated version in pom / project files to taxeditor version : 5.19.0 and cdmlib version : 5.19.0
jenkins
12:59 PM Revision c5df7948 (cdmlib): updating poms for 5.20.0-SNAPSHOT development
jenkins
12:16 PM feature request #9428 (New): Asynchronous loading of terms
copied from #9422, see there for more details:
An even better solution (maybe for the future/another ticket) could...
Katja Luther
12:11 PM feature request #9427 (Closed): Code cleaning in CdmPreferenceCache
copied from #9422:
for CdmPreferenceCache.getAllTaxEditorDBPreferences() the code
~~~ java
PrefKey k...
Katja Luther
11:55 AM bug #9422 (Closed): Improve performance during Preferences startup
yes, the first fix (term loading at start) is fixed for 5.19. So I create a new ticket for the remaining issues and c... Katja Luther
11:51 AM bug #9422 (Feedback): Improve performance during Preferences startup
The first fix went into 5.19, correct?
So I think we should split the ticket and set this one to resolved?
Andreas Müller
11:40 AM bug #9426 (Closed): Set publish flag for Synonyms in accordance with accepted taxon publish flag
If a new synonym is added to an accepted taxon the publish flag should get the same value as the accepted taxon to av... Andreas Müller
11:26 AM bug #9425: Common Names handling in CdmLight
By the way the same should be done for distributions. Andreas Müller
11:25 AM bug #9425: Common Names handling in CdmLight
As I guess that this is a no brainer I put it to the current milestone. Andreas Müller
11:06 AM bug #9425 (New): Common Names handling in CdmLight
The feature CommonName allows descriptionElements of type TextData this is not handled in cdmLight.
We need to di...
Katja Luther

01/27/2021

04:52 PM feature request #9338 (Closed): Restructure term menus
I did not check again but I guess we can close this ticket. Andreas Müller
04:51 PM bug #5710 (In Progress): Changing the database connection must reset all caches
Andreas Müller
03:25 PM Revision 05d3d1a8 (cdmlib): Updating develop poms back to pre merge state
jenkins
03:25 PM Revision 6c128ca6 (cdmlib): Merge branch 'master' into develop
jenkins
03:25 PM Revision e18bdb59 (cdmlib): updating develop poms to master versions to avoid merge conflicts
jenkins
03:25 PM Revision c9a0ff54 (cdmlib): Merge branch 'release/5.18.0'
jenkins
03:21 PM feature request #7704 (Closed): Dataportal specimen table should be able to show DerivedUnits without a FieldUnit
Andreas Kohlbecker
03:21 PM bug #9397 (Closed): Derivate tree view must show DerivedUnits even if the FieldUnit is missing
Andreas Kohlbecker
03:04 PM Revision 5f9032c7 (cdmlib): updating poms for branch'release/5.18.0' with non-snapshot versions
jenkins
02:44 PM Revision 4e6fc4ae (cdm-webapp): jenkins bumping cdmlib.version and cdm.vaadin.version to 5.20.0-SNAPSHOT
jenkins
02:40 PM Revision 4abafde1 (taxeditor): Updated version in pom / project files to taxeditor version : 5.18.0 and cdmlib version : 5.18.0
jenkins
02:40 PM Revision 4d3c9273 (cdm-vaadin): jenkins bumping cdmlib.version to 5.19.0-SNAPSHOT
jenkins
02:40 PM Revision 0d5ac911 (cdm-vaadin): jenkins bumping cdmlib.version to 5.20.0-SNAPSHOT
jenkins
02:34 PM Revision de4be7b3 (cdm-dataportal): updating poms for 5.20.0-SNAPSHOT development
jenkins
02:34 PM Revision 0d05d17e (cdm-server): updating poms for 5.20.0-SNAPSHOT development
jenkins
01:10 PM bug #9360: Parsed hybrids can not be persisted
Katja Luther wrote:
> Concepts with hybrid names are already handled correctly, because the list toSaveNewConcepts c...
Andreas Müller
12:12 PM bug #9360: Parsed hybrids can not be persisted
Concepts with hybrid names are already handled correctly, because the list toSaveNewConcepts contains all concepts, I... Katja Luther
01:03 PM Revision b2217f44 (cdm-dataportal): ref #9395 adapting test to modified service method
Andreas Kohlbecker
01:02 PM Revision 021cc0fe (cdmlib): ref #9395 solving problem in derivation-dto-graph assembly (replaced field units)
Andreas Kohlbecker
11:52 AM bug #7141 (Worksforme): Navigator does not update after swap synonym and accepted
This is fixed in the meantime. Katja Luther
11:31 AM bug #9140 (Resolved): Deleting an image forgets moving operation
this seems to be fixed with #7711 Katja Luther
11:28 AM bug #9012 (Worksforme): Taxon Navigator does not refresh after moving a taxon between classifications
This seems to be fixed in the meantime, therefore set to works for me. Katja Luther
11:20 AM Revision 5e0162fb (cdmlib): ref #7599 ref #9395 documenting requirements
Andreas Kohlbecker
09:28 AM bug #9346 (Resolved): Adding specimen to character matrix fails sometimes
This is fixed. Katja Luther
09:16 AM Revision 7361927a (taxeditor): ref #9360: code cleaning
Katja Luther
09:15 AM feature request #7975 (Closed): Implement a block to display name relations
Andreas Kohlbecker
09:14 AM task #9165: Eroneous registrations, published
Wolf-Henning Kusber wrote:
> Das grundsätzliche Problem bleibt, dass sich registrierte Namen und Typen nach Publikat...
Andreas Kohlbecker
12:04 AM Revision c1f1372f (taxeditor): fix #9360: fix saving of synonyms being hybrid formulas, some potential NPEs and some cleanup of commented code
Andreas Müller

01/26/2021

11:08 PM Revision 2085813d (taxeditor): cleanup
Andreas Müller
04:36 PM Revision f8decba5 (taxeditor): fix #9360: add parsed hybrid names to newly created names while merge taxonnameEditorInput
Katja Luther
04:35 PM bug #9360 (Resolved): Parsed hybrids can not be persisted
Applied in changeset commit:taxeditor|f8decba5d7a4bc8ec562b380190b1534a31c069a. Katja Luther
12:24 PM bug #9360: Parsed hybrids can not be persisted
Probably the reason is that in TaxEditorInputE4.merge() only the hybrid parents for *new* parents are pre-saved. But ... Andreas Müller
09:10 AM bug #9360: Parsed hybrids can not be persisted
A similar issue in test DB
~~~
last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/t...
Andreas Müller
02:51 PM Revision 303a8ebc (cdm-vaadin): ref #9290 limiting designation sources to the publication unit and sub sections in NameTypeDesignationEditor
Andreas Kohlbecker
02:51 PM bug #9290 (In Progress): stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Andreas Kohlbecker
02:25 PM bug #9405 (Closed): Fields set to irrelevant for cache should be set by state only
This seems to work correctly (also for references), I only added the colouring of the date field for references to #9... Katja Luther
02:16 PM Revision 7e1a46e1 (cdm-vaadin): ref #9301 limiting designation sources to the publication unit and sub sections
Andreas Kohlbecker
02:15 PM Revision ff00d7e8 (cdmlib): ref #9301 static helper method to find the nom. act of a registration
Andreas Kohlbecker
02:13 PM feature request #9301 (In Progress): SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
Andreas Kohlbecker
01:58 PM feature request #9338 (Resolved): Restructure term menus
Andreas Müller wrote:
> I found some further issues:
>
> * Namerelationshiptype tree editor opens taxon relations...
Katja Luther
01:12 PM feature request #9338: Restructure term menus
translation works now as expected Andreas Müller
12:57 PM feature request #9338 (Feedback): Restructure term menus
I found some further issues:
* Namerelationshiptype tree editor opens taxon relationship trees and the other way r...
Andreas Müller
01:58 PM Revision da31b745 (taxeditor): check all termeditors and termtree editors to be connected to the correct term type
Katja Luther
01:22 PM bug #9369 (Closed): Reference Detail is missing in MediaSpecimen details view
Andreas Müller
01:05 PM Revision b8182374 (cdm-dataportal): ref #9397 supressing derivationTreeSummary in derivate tree
Andreas Kohlbecker
12:48 PM bug #7711: Bugs in media gallery
This should be finally closed only when #9360 is also fixed as the code seems to be related and it needs to be tested... Andreas Müller
11:12 AM bug #7711 (Resolved): Bugs in media gallery
Katja Luther
11:09 AM bug #7711: Bugs in media gallery
Andreas Müller wrote:
> The image issue seems to be fixed.
>
> There is still one new commented line:
>
> // ...
Katja Luther
10:08 AM bug #7711 (Feedback): Bugs in media gallery
The image issue seems to be fixed.
There is still one new commented line:
// descriptio...
Andreas Müller
12:43 PM bug #9149 (Duplicate): NPE when saving hybrid formula
Andreas Müller
12:40 PM bug #9422 (In Progress): Improve performance during Preferences startup
Now the method to get dtos from serverside is used instead of getting the terms and create dtos on editor side. Katja Luther
12:39 PM Revision f8326308 (taxeditor): ref #9422: get termDtos from server
Katja Luther
12:38 PM Revision c5c00803 (cdmlib): ref #9395 simplifying findByGeneticAccessionNumber() as extra code has no imact on performance
Andreas Kohlbecker
12:34 PM Revision 8195f008 (cdmlib): ref #9395 findByAccessionNumber() -> findByGeneticAccessionNumber(), preserving old method as deprecated
Andreas Kohlbecker
12:33 PM Revision e793ebfb (cdmlib): cleanup
Andreas Müller
12:31 PM task #9165: Eroneous registrations, published
Das grundsätzliche Problem bleibt, dass sich registrierte Namen und Typen nach Publikation online/in Print Medien und... Wolf-Henning Kusber
12:18 PM bug #9395 (Resolved): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
Andreas Kohlbecker
12:12 PM bug #9395 (In Progress): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
Andreas Kohlbecker
12:16 PM Revision 2edb5aa1 (cdmlib): ref #9395 fully implementing maxDepth for derivative assembly and fixing OccurrenceServiceImpl._findRootUnitDTO()
Andreas Kohlbecker
11:52 AM feature request #7975 (Worksforme): Implement a block to display name relations
can be closed Wolf-Henning Kusber
11:43 AM Revision f5792d50 (cdmlib): cleanup
Andreas Müller
11:30 AM Revision 39816367 (taxeditor): add taxon relations to propertypath of taxonbase
Katja Luther
11:28 AM bug #9419: Typespecimen display in Vaadin when two designations having different field units are related to one name in one publication
display in the dataportal is correct:
* http://test.e-taxonomy.eu/dataportal/preview/phycobank/cdm_dataportal/name...
Andreas Kohlbecker
11:13 AM Revision d5b342dc (taxeditor): ref #7711: adapt merge in TaxonEditorInputE4 to avoid exceptions for namerelations
Katja Luther
10:54 AM Revision 2d263962 (taxeditor): avoid widgetIsDisposed exception
Katja Luther
10:30 AM Revision a3b7c1e7 (taxeditor): create DerivedUnit of type TissueSample for tissueSamples instead of DNASample
Katja Luther
09:59 AM Revision 13754873 (cdmlib): ref #9360 preliminary exception for debugging NPE
Andreas Müller
09:16 AM Revision ec8279f2 (taxeditor): cleanup
Andreas Müller
08:18 AM Revision f047dbf9 (cdm-dataportal): ref #9397 supressing summaryLabel in derivate tree
Andreas Kohlbecker
06:02 AM bug #9424: CdmImageInfo connection timeout implemented
the missing timeout currently causes problems that let the dataportal tests fail Andreas Kohlbecker
06:01 AM bug #9424 (New): CdmImageInfo connection timeout implemented
the time out passed to the method `.CdmImageInfo.readMetaData(Integer timeOut) ` is never being used.
the timeout ...
Andreas Kohlbecker

01/25/2021

08:44 PM Revision 9280750d (taxeditor): cleaning up eclipse editor mess
Andreas Kohlbecker
08:32 PM Revision 18d0f149 (taxeditor): adapting editor to modified DTO property
Andreas Kohlbecker
08:17 PM Revision 2c559f97 (cdm-dataportal): fix #7704 fix #9397 adapting specimen tree and table view to cdmlib improvements for complete root unit display - adapting tests
Andreas Kohlbecker
07:49 PM Revision f6740b16 (cdmlib): ref #9389 ref #9415 improving information assembly in derivation bouquet by recursion - adapting test
Andreas Kohlbecker
07:26 PM bug #9397 (Resolved): Derivate tree view must show DerivedUnits even if the FieldUnit is missing
Applied in changeset commit:cdm-dataportal|9783f0849a4b549f3b1513211011f4eb16c01eac. Andreas Kohlbecker
07:26 PM feature request #7704 (Resolved): Dataportal specimen table should be able to show DerivedUnits without a FieldUnit
Applied in changeset commit:cdm-dataportal|9783f0849a4b549f3b1513211011f4eb16c01eac. Andreas Kohlbecker
07:26 PM Revision 9783f084 (cdm-dataportal): fix #7704 fix #9397 adapting specimen tree and table view to cdmlib improvements for complete root unit display
Andreas Kohlbecker
07:23 PM task #9253 (Resolved): revise OccurrenceServiceImpl.findFieldUnitDTO(..)
possibly solved now Andreas Kohlbecker
07:22 PM bug #8423 (Closed): OccurrenceServiceImpl.findFieldUnitDTO() fails to merge derivation paths when a FieldUnit has two derivatives
works as expected Andreas Kohlbecker
07:15 PM bug #9415 (Closed): DNA and other Derivatives missing in DerivedUnitDTO
Andreas Kohlbecker
07:12 PM bug #9415 (Resolved): DNA and other Derivatives missing in DerivedUnitDTO
Andreas Kohlbecker
07:15 PM bug #9395 (Closed): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
completed Andreas Kohlbecker
07:13 PM task #9389 (In Progress): further improvement and revision of derivative filtering by type and DerivedUnitDTO
problem 2.) solved Andreas Kohlbecker
07:12 PM Revision 1d8a4f7e (cdmlib): ref #9389 ref #9415 improving information assembly in derivation bouquet by recursion, fixing multiple problems
Andreas Kohlbecker
06:00 PM bug #9423 (New): Improve language handling for TermType.getMessage() and others
TermType.getMessage() is often used when creating menus but also in other context. It internally calls TermType.getMe... Andreas Müller
05:26 PM bug #9422 (Closed): Improve performance during Preferences startup
During startup the following function is called
CdmPreferenceCache.getAllTaxEditorDBPreferences by PreferenceUtil...
Andreas Müller
04:48 PM Revision 4e1d9174 (taxeditor): ref #9369: add space between several fields in mediaspecimen details
Katja Luther
04:47 PM bug #9369 (Resolved): Reference Detail is missing in MediaSpecimen details view
Spaces are added, please have a look Katja Luther
04:20 PM bug #9369 (Feedback): Reference Detail is missing in MediaSpecimen details view
Katja Luther wrote:
> move this ticket to 5.20 because moving the uri needs some more implementation.
Moving URI ...
Andreas Müller
04:10 PM bug #9369 (In Progress): Reference Detail is missing in MediaSpecimen details view
move this ticket to 5.20 because moving the uri needs some more implementation. Katja Luther
04:19 PM bug #9350 (Closed): Create new taxonnode ignores the publish flag
Katja Luther
04:18 PM bug #9350: Create new taxonnode ignores the publish flag
Andreas Müller wrote:
> Works as expeccted.
>
> Should we check after the release that the code merge worked corr...
Katja Luther
04:17 PM task #9421 (New): [Discuss] Move URI to top in MediaSpecimen
copied from #9369
Andreas Müller
04:03 PM feature request #9420 (New): Harmonize Update- and ImportResult
Actually the import result only contains counts of imported and updated objects, for better updating mechanisms it wo... Katja Luther
04:03 PM bug #8874 (Resolved): move taxon is reverted when taxon is edited afterwards
I want to check again what I meant therefore I put it back to review to remind myself to do so. Andreas Müller
04:01 PM bug #8874: move taxon is reverted when taxon is edited afterwards
Andreas Müller wrote:
> Katja Luther wrote:
> > Maybe we should think about a more detailed ImportResult, but there...
Katja Luther
03:59 PM bug #8874 (Closed): move taxon is reverted when taxon is edited afterwards
Katja Luther
03:47 PM bug #8874: move taxon is reverted when taxon is edited afterwards
Andreas Müller wrote:
> It seems to work. However, I do not fully understand, why. Don't the changes try to guarante...
Katja Luther
10:29 AM bug #8874: move taxon is reverted when taxon is edited afterwards
Katja Luther wrote:
> Maybe we should think about a more detailed ImportResult, but therefore we need to implement i...
Andreas Müller
10:28 AM bug #8874: move taxon is reverted when taxon is edited afterwards
Andreas Müller wrote:
> Katja Luther wrote:
> > Andreas Müller wrote:
> > > I also wonder, why in the code only th...
Katja Luther
10:22 AM bug #8874: move taxon is reverted when taxon is edited afterwards
Katja Luther wrote:
> Andreas Müller wrote:
> > I also wonder, why in the code only the UpdateResult part was adapt...
Andreas Müller
09:43 AM bug #8874: move taxon is reverted when taxon is edited afterwards
Andreas Müller wrote:
> I also wonder, why in the code only the UpdateResult part was adapted, but not the ImportRes...
Katja Luther
09:39 AM bug #8874: move taxon is reverted when taxon is edited afterwards
Andreas Müller wrote:
> Another more critical issue related to the code reviewed:
>
> The following code:
>
> ...
Katja Luther
03:40 PM Revision d9837e21 (taxeditor): fix #7711: fix delete of media if another not persisted media exist
Katja Luther
03:39 PM bug #7711: Bugs in media gallery
Andreas Müller wrote:
> >if a transient (id>0) media is removed all volatile (id=0) media are also removed automatic...
Katja Luther
03:39 PM bug #7711 (Resolved): Bugs in media gallery
Applied in changeset commit:taxeditor|d9837e213c6caef559688ebaaac5a86f3fe31cb0. Katja Luther
02:25 PM Revision c3b6d097 (taxeditor): ref #9405 , ref #4944 fix NPE in CacheRelevanceHelper
Andreas Müller
01:23 PM Revision 6fd05c62 (taxeditor): ref #9338: adapt translations in term menues - Status -> Kategorie
Katja Luther
11:31 AM Revision 3c8dd48a (taxeditor): ref #9338: adapt translations in term menues - fix typo
Katja Luther
11:28 AM feature request #9338 (Resolved): Restructure term menus
The german labels are adapted, please have a look whether everything is ok now. Katja Luther
11:26 AM Revision c83d1ee7 (cdmlib): avoid NotSerializableException for SourceDto
Katja Luther
11:22 AM Revision 2c763ca6 (taxeditor): ref #9338: adapt translations in term menues
Katja Luther
11:19 AM Revision b1a9da41 (taxeditor): code cleaning
Katja Luther
11:18 AM bug #9419 (New): Typespecimen display in Vaadin when two designations having different field units are related to one name in one publication
Test System as of 25 JAn 2021:
Typespecimen display in Vaadin is not correct when two designations are related to on...
Wolf-Henning Kusber
11:03 AM Revision fa5e785a (taxeditor): avoid NPE for newly created TermTree
Katja Luther
09:29 AM bug #9353: Copy & Paste creates dirty data in term trees
Andreas Müller wrote:
> Andreas Müller wrote:
> > Paste requires save first. Is this really needed? Most task are n...
Katja Luther
09:28 AM bug #9353 (Closed): Copy & Paste creates dirty data in term trees
Katja Luther
09:27 AM bug #9354 (Closed): Sorting in distribution editor is broken
The code looks fine. Close the ticket. Katja Luther
09:25 AM bug #9365 (Closed): Reuse taxon does not work in new Taxon dialogue
the looks fine, close the ticket. Katja Luther
09:11 AM feature request #9418 (New): Improve entering of date published
Normally the date element is collapsed in the editor and the users forget to enter the publishing date of a reference... Katja Luther
08:20 AM feature request #8756: Refresh button for structure tree and property tree in Character Editor
is it planned that the refresh also can be triggered by pressing the `F5` key? Andreas Kohlbecker

01/24/2021

03:42 PM feature request #9404: Open issues for Tropicos Import
Chuck;
Here’s the answer from Paul. We don’t plan to change the output. Web service will come later on after we ha...
Andreas Müller

01/23/2021

02:46 AM bug #9360: Parsed hybrids can not be persisted
maybe a duplicate for #9149 Andreas Müller
02:45 AM bug #9360 (In Progress): Parsed hybrids can not be persisted
Andreas Müller
02:39 AM bug #9405: Fields set to irrelevant for cache should be set by state only
The general idea of the refactoring is:
* in a first step all elements which are relevant for a cache get do regis...
Andreas Müller
02:23 AM bug #9405 (Resolved): Fields set to irrelevant for cache should be set by state only
This should be fixed. I moved advanced issues to new ticket #9417. Please review.
This is also related to #4944. P...
Andreas Müller
02:19 AM bug #9405: Fields set to irrelevant for cache should be set by state only
This is mostly fixed. Some advanced features stay:
* trigger updateCacheRelevance() with ToggledText state change ...
Andreas Müller
02:29 AM bug #4915: Abbrev title for person should never be orange
This should also be fully fixed with #9405 being implemented. Please review again as the frameworks has been fully re... Andreas Müller
02:25 AM bug #4944: "Protected" indication for references needs to be improved
with implementation of #9405 this should be fully fixed now. Please review with new implementation.
>The following...
Andreas Müller
02:21 AM feature request #9417 (New): Advanced issues for cache relevance handling
This is mostly fixed. Some advanced features stay:
* trigger updateCacheRelevance() with ToggledText state change ...
Andreas Müller
02:08 AM Revision 202edbff (taxeditor): ref #9405 , ref #4944 refactor the cache protection indication handling in TaxEditor details view elements
Andreas Müller
02:00 AM Revision 2a4c2da5 (taxeditor): handle inReferences genericly with ReferenceType.inReferenceContraints
Andreas Müller
01:55 AM Revision aeb80bf1 (taxeditor): cleanup
Andreas Müller

01/22/2021

08:24 PM Revision afb8223a (taxeditor): cleanup
Andreas Müller
07:38 PM bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Published Specimen Types which are holotypes are displayed as "designated by" in Vaadin. For new names this is now im... Wolf-Henning Kusber
07:23 PM bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Selection disabled/enabled in SpecimenTypeDesignationEditor see #9301
Selection disabled/enabled in NameTypeDesignat...
Wolf-Henning Kusber
07:10 PM bug #9290: stop setting Registration.citation as citation for TypeDesignations in all type editors by default
re-labeled to "Designation reference": perfect
function is there but not user-friendly
Only the references in u...
Wolf-Henning Kusber
07:18 PM feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
The fields are shown, if needed.
The selection of type status (all checked) in SpecimenTypDesignationEditor is fin...
Wolf-Henning Kusber
05:07 PM Revision d09b9168 (taxeditor): ref #9338: adapt term menu
Katja Luther
04:32 PM Revision 6fa29b1d (cdmlib): cleanup
Andreas Müller
04:32 PM Revision 0b2155a2 (cdmlib): ref #9365 update code for reuse taxon (change order for check name and check taxon and throw exceptions if not exists)
Andreas Müller
04:31 PM feature request #8554 (Duplicate): Allow drag&drop from character into FeatureTrees
Katja Luther
04:26 PM bug #9365 (Feedback): Reuse taxon does not work in new Taxon dialogue
I changed it a bit the way that first it is checked if a taxon is reused, if not a new taxon is created (with accordi... Andreas Müller
09:12 AM bug #9365 (Resolved): Reuse taxon does not work in new Taxon dialogue
Andreas Müller wrote:
> Andreas Müller wrote:
> > As you are now using a different method for createNewTaxonNode al...
Katja Luther
04:08 PM Revision fb33c0e3 (cdmlib): cleanup
Andreas Müller
03:52 PM bug #9372 (Closed): in media details view unprotected title cache is not updated when underlying data is changed
Andreas Müller
11:25 AM bug #9372: in media details view unprotected title cache is not updated when underlying data is changed
this is fixed now, please review. Katja Luther
03:47 PM bug #9412 (Closed): Fix reuse existing name in NewTaxonWizard
Andreas Müller
09:40 AM bug #9412 (Resolved): Fix reuse existing name in NewTaxonWizard
please review. Katja Luther
09:33 AM bug #9412 (Closed): Fix reuse existing name in NewTaxonWizard
I got a very similar NPE when deleting the "reuse existing name":
~~~
last remote method : http://test.e-taxono...
Katja Luther
03:45 PM bug #9353 (Feedback): Copy & Paste creates dirty data in term trees
Andreas Müller wrote:
> Paste requires save first. Is this really needed? Most task are now handled without save-req...
Andreas Müller
09:50 AM bug #9353 (Resolved): Copy & Paste creates dirty data in term trees
Duplicates can be copied now (for trees allowing duplicates)
The problem of two error dialogs I could not reproduce.
Katja Luther
03:35 PM feature request #9338: Restructure term menus
Some translations are missing.
Easy: Language, Extension-Type
Maybe also possible: Stage, Nametypedesignation S...
Andreas Müller
03:28 PM feature request #9338 (Feedback): Restructure term menus
There is another issue for trees:
![](picture753-1.png)
Dna Marker is duplicated, the first is wrong. At the s...
Andreas Müller
11:59 AM feature request #9338 (Resolved): Restructure term menus
Adapted the menues, please have a look. Katja Luther
03:10 PM bug #9354 (Feedback): Sorting in distribution editor is broken
Works as expected. We only could do some further improvements which I put in a new ticket #9416.
Please review my ...
Andreas Müller
02:10 PM bug #9354: Sorting in distribution editor is broken
I unified the 2 TaxonNodeDao.listChildrenOf(...) methods as I don't think it is good to have recursion input paramete... Andreas Müller
11:37 AM bug #9354: Sorting in distribution editor is broken
Andreas Müller wrote:
> There is an NPE issue in TaxonNodeByRankAndNameComparator if name or rank does not exist in ...
Katja Luther
11:36 AM bug #9354: Sorting in distribution editor is broken
There is an NPE issue in TaxonNodeByRankAndNameComparator if name or rank does not exist in taxon. I fixed it. Andreas Müller
03:10 PM feature request #4298 (New): refresh views after changing rights
As the description is hopefully clear now we can put this back to "New" to avoid having it in the feedback tickets al... Andreas Müller
03:03 PM task #9416 (New): Improve distribution editor sort methods
Currently in TaxonNode.listChildrenOfRecursive 2 different implementations are used to compute the result (first is u... Andreas Müller
02:53 PM Revision 89ce56b3 (cdmlib): make comparators of TaxonNodeXxxSortMode singletons
Andreas Müller
02:47 PM Revision 1ed16f10 (cdmlib): cleanup
Andreas Müller
02:15 PM Revision aa8a8f74 (taxeditor): adapt Editor to moved TaxonNodeSortMode
Andreas Müller
01:52 PM Revision 49e5a25a (cdmlib): ref #9354 unify TaxonNodeDao.listChildrenOf(...) methods (fix test)
Andreas Müller
01:27 PM Revision 1c63b6c5 (cdmlib): ref #9354 unify TaxonNodeDao.listChildrenOf(...) methods
Andreas Müller
01:27 PM Revision 65112c51 (cdmlib): move TaxonNodeSortMode to model.compare
Andreas Müller
01:27 PM Revision 97118446 (cdmlib): cleanup
Andreas Müller
12:20 PM bug #9413 (Closed): DNA details lable "Ratio of absorbance ..." corrected
Fixed.
By the way, such label adaptations should always go into the current milestone (as they are extremely easy ...
Andreas Müller
12:17 PM bug #9413 (Resolved): DNA details lable "Ratio of absorbance ..." corrected
Applied in changeset commit:taxeditor|ad2d549777a2629b3ff79f663792dcc644df9f55. Andreas Müller
09:38 AM bug #9413 (Closed): DNA details lable "Ratio of absorbance ..." corrected
these two labels denote the ratio of two wavelengths therefore the numbers must be concatenated with a slash
* "R...
Andreas Kohlbecker
12:19 PM feature request #4867 (In Progress): Add menu item for subtree cloning
Katja Luther
12:17 PM Revision ad2d5497 (taxeditor): fix #9413 fix separator for absorbance ratio
Andreas Müller
12:16 PM Revision c955d553 (taxeditor): ref #9142: code cleaning
Katja Luther
12:16 PM bug #9142 (Closed): The Agent search dialog shows duplicated entries
cleaned the code and close ticket. Katja Luther
12:00 PM Revision 0b1cfd87 (taxeditor): ref #9338: some adaptions in menues
Katja Luther
12:00 PM feature request #9192 (Closed): Layout issues for source in taxonnode details
Katja Luther
11:58 AM Revision f5d64be9 (taxeditor): ref #9264: rename linkWithTaxon parameter
Katja Luther
11:56 AM bug #9264 (Closed): Flag for toggle button for linking taxon with navigator looses/switch value without clicking the button
Renamed parameter and close this ticket. Katja Luther
11:56 AM Revision d7a609e3 (cdmlib): ref #9276 renaming DerivationTreeSummaryDTO fields in SpecimenOrObservationBaseDTO
Andreas Kohlbecker
11:56 AM Revision 1e436a0b (cdmlib): ref #9276 documenting DerivateDataDTO and renaming to DerivationTreeSummaryDTO
Andreas Kohlbecker
11:56 AM Revision 408979d3 (taxeditor): ref #9395 adapting services and web-services to return all root units - adapting taxeditor - generic type fix
Andreas Kohlbecker
11:53 AM Revision a7dcea2c (cdm-dataportal): ref #9276 adapting portal to renamed DerivationTreeSummaryDTO fields in SpecimenOrObservationBaseDTO
Andreas Kohlbecker
11:46 AM Revision 25b933c4 (cdm-dataportal): ref #7704, ref #9395 using web-services now returning all root units
Andreas Kohlbecker
11:33 AM Revision 3f7808ea (cdmlib): try to fix TaxoNodeByNameComparator issue in application context files.
Andreas Müller
11:25 AM Revision cf3b8a2b (taxeditor): adapt comparators to new model.compare structure (cont.)
Andreas Müller
11:25 AM Revision 5dbff5a2 (taxeditor): ref #9372: adapt title after changing uri of media
Katja Luther
11:16 AM Revision b26f84c2 (cdmlib): fix compile error and rename TaxonNodeNaturalComparator
Andreas Müller
11:07 AM Revision eb1471a5 (cdmlib): moving further Comparators to model.compare
Andreas Müller
11:07 AM Revision 9bae7299 (cdmlib): cleanup
Andreas Müller
11:07 AM Revision 6502eaa6 (cdmlib): ref #9354 fix NPE in TaxonNodeByRankAndNameComparator
Andreas Müller
10:53 AM Revision 70e9fc0d (taxeditor): ref #9395 adapting services and web-services to return all root units - adapting taxeditor
Andreas Kohlbecker
10:52 AM Revision 9fcfd180 (cdmlib): ref #9395 adapting services and web-services to return all root units
Andreas Kohlbecker
10:27 AM Revision 35fb70b7 (taxeditor): fix compile error and cleanup
Andreas Müller
10:19 AM Revision 5330bd70 (cdm-vaadin): adapt comparators to new model.compare structure
Andreas Müller
10:05 AM Revision af95d1c1 (taxeditor): adapt comparators to new model.compare structure and some cleanup
Andreas Müller
10:02 AM Revision bc39bc21 (cdmlib): move some comparators to model.compare package, add subpackages to model.compare and some cleanup
Andreas Müller
10:00 AM bug #9415 (Closed): DNA and other Derivatives missing in DerivedUnitDTO
example:
http://int.e-taxonomy.eu/cdmserver/integration_reference/portal/occurrence/8259122c-7140-44f3-980e-1a65...
Andreas Kohlbecker
09:47 AM Revision e12ba935 (taxeditor): ref #9353: fix check for duplicates when duplicates allowed
Katja Luther
09:42 AM bug #9414 (New): DNA details lable "Concentration" with unit
these labels "Concentration" should include the unit:
"Concentration [ng/μl]"
Andreas Kohlbecker
09:37 AM bug #9393: NPE when removing parent from TaxonNode editor
splitted the ticket: ticket #9412 handles the exception when reusing a name and this ticket the NPE when removing a p... Katja Luther
09:14 AM bug #9356 (Closed): Comparison method violates its general contract for SourceComparator and TypeDesignationComparator
Andreas Müller wrote:
> For TypeDesignationComparator the line
>
> ~~~
> return o1.getUuid().compareTo(o2.getUui...
Katja Luther
08:39 AM Revision fc69fc31 (cdmlib): implement Comparator contract for TypedEntityComparator.java correctly
Andreas Müller

01/21/2021

08:42 PM Revision a3fe9a5a (taxeditor): cleanup
Andreas Müller
08:35 PM Revision 56613858 (taxeditor): ref #9356 clean up SourceComparator
Andreas Müller
08:35 PM Revision 35fb8b4d (taxeditor): cleanup
Andreas Müller
08:16 PM bug #9356: Comparison method violates its general contract for SourceComparator and TypeDesignationComparator
The SourceComparator looks fine. I only cleaned it up a bit. Andreas Müller
07:34 PM bug #9356 (Feedback): Comparison method violates its general contract for SourceComparator and TypeDesignationComparator
For TypeDesignationComparator the line
~~~
return o1.getUuid().compareTo(o2.getUuid());
~~~
will never be rea...
Andreas Müller
07:41 PM Revision 0287cfe2 (cdmlib): fix compile error
Andreas Müller
07:26 PM Revision a407a44c (cdmlib): improve generics for AgentService.getUuidAndAbbrevTitleCache
Andreas Müller
07:25 PM Revision a5502a9b (cdmlib): cleanup
Andreas Müller
07:23 PM Revision 9c187406 (cdmlib): ref #9356 adapt TypeDesignationComparator to fix case when both type status are null ; and cleanup null compare part above
Andreas Müller
06:44 PM bug #9353: Copy & Paste creates dirty data in term trees
In general the copy&past works now. Andreas Müller
06:43 PM bug #9353 (Feedback): Copy & Paste creates dirty data in term trees
Paste requires save first. Is this really needed? Most task are now handled without save-requirement so it breaks a b... Andreas Müller
06:36 PM bug #9353: Copy & Paste creates dirty data in term trees
Andreas Müller wrote:
> There is a duplicate error message when c%p a duplicate term to a non-duplicate allowing tre...
Andreas Müller
06:35 PM bug #9353: Copy & Paste creates dirty data in term trees
The error message on duplicate also appears if the tree allows duplicates:
![](picture752-1.png)
Andreas Müller
06:31 PM bug #9353: Copy & Paste creates dirty data in term trees
There is a duplicate error message when c%p a duplicate term to a non-duplicate allowing tree.
![](picture135-1.pn...
Andreas Müller
06:06 PM feature request #8756: Refresh button for structure tree and property tree in Character Editor
sorry, I forgot to re-assign this to you Andreas Müller
06:04 PM bug #9142: The Agent search dialog shows duplicated entries
Andreas Müller wrote:
> By the way can't we remove the commented line?
I deleted the line and also cleaned up the...
Andreas Müller
04:37 PM bug #9142: The Agent search dialog shows duplicated entries
Katja Luther wrote:
> Andreas Müller wrote:
> > Thats what I thought. It is actually not really a wrong implementat...
Andreas Müller
05:53 PM Revision 23210238 (taxeditor): call merged createTaxon method
Katja Luther
05:40 PM Revision b09fb3b9 (cdmlib): cleanup and improve generics
Andreas Müller
05:33 PM Revision 94241b1b (taxeditor): fix create taxon with reused taxon
Katja Luther
05:31 PM Revision ca23ea19 (cdmlib): fix delete taxon/name and merge createTaxon methods - continue
Katja Luther
04:13 PM Revision 29d1e817 (cdmlib): cleanup
Andreas Müller
04:13 PM Revision 3133b77d (cdmlib): ref #9142 code simplification
Andreas Müller
04:02 PM feature request #8289 (Closed): Add "Open in RefObj view" to term editor context menu
Looks good now. Andreas Müller
02:34 PM feature request #8289 (Resolved): Add "Open in RefObj view" to term editor context menu
Applied in changeset commit:taxeditor|9d09fe70f4a9159120f70754988dad2cf500365e. Katja Luther
02:04 PM feature request #8289 (Feedback): Add "Open in RefObj view" to term editor context menu
Works as expected. Only issue: in other places we have the open in menu just below the New menu and also it is separa... Andreas Müller
04:00 PM bug #8874 (Feedback): move taxon is reverted when taxon is edited afterwards
Another more critical issue related to the code reviewed:
The following code:
~~~
for (Map.Entry<String, Integ...
Andreas Müller
03:58 PM bug #8874: move taxon is reverted when taxon is edited afterwards
I also wonder, why in the code only the UpdateResult part was adapted, but not the ImportResult. Is this specific to ... Andreas Müller
03:55 PM bug #8874: move taxon is reverted when taxon is edited afterwards
It seems to work. However, I do not fully understand, why. Don't the changes try to guarantee that all open taxa rela... Andreas Müller
03:35 PM bug #8874: move taxon is reverted when taxon is edited afterwards
I think I remember the mail discussion about this issue. There, we discussed that this happens only if the taxon was ... Andreas Müller
03:48 PM Revision 3e89c139 (taxeditor): cleanup
Andreas Müller
03:31 PM Revision 5f44e659 (cdmlib): ref #9301 extending init-strategy to include typeDesignation.source.*
Andreas Kohlbecker
03:28 PM task #9411 (New): use termtrees for user defined limited term lists
this accounts for:
* nomenclatural status type terms
* ...
see `RegistrationTermLists` & an attempt to rep...
Andreas Kohlbecker
03:22 PM bug #9344 (Closed): Datasets in Descriptive Dataset Navigator should be ordered
looks fine Andreas Müller
03:20 PM bug #7711: Bugs in media gallery
>if a transient (id>0) media is removed all volatile (id=0) media are also removed automatically
this still happen...
Andreas Müller
03:16 PM bug #7711 (Feedback): Bugs in media gallery
When removing the last image of the image gallery I got:
~~~
last remote method : http://test.e-taxonomy.eu:80/cd...
Andreas Müller
03:14 PM feature request #8981: Improve NameStatus in UI
please review Andreas Kohlbecker
03:14 PM feature request #8981 (Resolved): Improve NameStatus in UI
Applied in changeset commit:cdm-vaadin|86550c96c1fc9e574e8dc8a9c4ae6289a47f2bd5. Andreas Kohlbecker
03:14 PM Revision 86550c96 (cdm-vaadin): fix #8981 checkbox to toggle the name status tabel in-/visible
Andreas Kohlbecker
02:40 PM Revision c113bc55 (cdmlib): merge the two create taxon methods
Katja Luther
02:39 PM Revision 6730fb60 (cdmlib): fix isDeletable for taxon with name used only once
Katja Luther
02:34 PM Revision 9d09fe70 (taxeditor): fix #8289: add sep and move command
Katja Luther
02:29 PM feature request #8975: Name Status filtered in UI
ready for review Andreas Kohlbecker
02:27 PM feature request #8975 (Resolved): Name Status filtered in UI
Applied in changeset commit:cdm-vaadin|d8791ff266ee1c66cdb6a0d20a57844107435294. Andreas Kohlbecker
02:27 PM Revision d8791ff2 (cdm-vaadin): fix #8975 limiting available nom status types
Andreas Kohlbecker
02:05 PM bug #8522: Make type status mandatory in Name type designation editor
please review Andreas Kohlbecker
02:04 PM bug #8522 (Resolved): Make type status mandatory in Name type designation editor
Applied in changeset commit:cdm-vaadin|b892b7623a4a49d8a4e7669405b3dbe6e2dcca11. Andreas Kohlbecker
02:04 PM Revision b892b762 (cdm-vaadin): fix #8522 type status mandatory in Name type designation editor
Andreas Kohlbecker
01:58 PM bug #9372: in media details view unprotected title cache is not updated when underlying data is changed
It still does not seem to work. Now, even the title in the bulk editor table does not change anymore.
Do we talk a...
Andreas Müller
01:43 PM bug #9264 (Feedback): Flag for toggle button for linking taxon with navigator looses/switch value without clicking the button
seems to work.
Is the parameter boolean isLinkWithTaxon really needed? it is not used. Is it only to have any para...
Andreas Müller
01:07 PM bug #9410 (New): DNA Marker is not shown correctly on specimen page
instead it shows only "Object":
![](picture342-1.png)
Example: http://portal.cybertaxonomy.org/algaterra-new/cd...
Andreas Müller
01:02 PM bug #9365 (Feedback): Reuse taxon does not work in new Taxon dialogue
Andreas Müller wrote:
> As you are now using a different method for createNewTaxonNode all the TaxonNode data like s...
Andreas Müller
12:22 PM bug #9365 (Resolved): Reuse taxon does not work in new Taxon dialogue
please review. Katja Luther
11:53 AM bug #9365: Reuse taxon does not work in new Taxon dialogue
This is fixed with the last commit for #9393 Katja Luther
11:49 AM bug #9365: Reuse taxon does not work in new Taxon dialogue
As you are now using a different method for createNewTaxonNode all the TaxonNode data like source and status are not ... Andreas Müller
11:38 AM bug #9365 (Feedback): Reuse taxon does not work in new Taxon dialogue
The disabling of the secundum is still missing. Andreas Müller
12:58 PM feature request #9338: Restructure term menus
I moved questions on unhandled term types to new ticket #9409 Andreas Müller
12:52 PM feature request #9338 (Feedback): Restructure term menus
Andreas Müller
12:51 PM feature request #9338: Restructure term menus
The new menu looks much better now (also mentioned by AK recently). Good we changed this. Andreas Müller
12:49 PM feature request #9338: Restructure term menus
And a small change to my above description: can we put Modifier and Scope into 1 section followed by another section ... Andreas Müller
12:47 PM feature request #9338: Restructure term menus
TaxonNodeAgentRelationType should be also editable for vocabularies (sorry, my comment was maybe not clear)
Langua...
Andreas Müller
12:57 PM feature request #9409 (New): [Decision] Which terms should be editable in term tree editor (and vocabulary editor)
copied from #9338
Open term types:
DerivationEventType (not in use yet?) => if to use last section
DnaQualityT...
Andreas Müller
12:52 PM feature request #9301: SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
improvements to the layout will be done in #9408
The requested fields are now added and can be tested.
Andreas Kohlbecker
12:45 PM feature request #9301 (Resolved): SpecimenTypeDesignationEditor: Add fields for citation and citationDetail
Applied in changeset commit:cdm-vaadin|06db1b37a7f659fb7e18079700103f41b16bfd10. Andreas Kohlbecker
12:51 PM feature request #9408 (New): SpecimenTypeDesignation collection editor with grid-form per item instead of looong rows
The SpecimenTypeDesignation collection editor the SpecimenTypeDesgnationEditor shows all fields in a very long row.
...
Andreas Kohlbecker
12:45 PM Revision 06db1b37 (cdm-vaadin): fix #9301 adding designationReference and detail to specimen type designation editor
Andreas Kohlbecker
12:30 PM bug #9393: NPE when removing parent from TaxonNode editor
Shouldn't we split the ticket? This ticket is mostly on NPEs not on general problems with parent handling. Andreas Müller
12:20 PM bug #9393 (In Progress): NPE when removing parent from TaxonNode editor
The NPE when removing reused name is fixed. The problem when removing parent is a little more difficult, therefore th... Katja Luther
10:23 AM bug #9393: NPE when removing parent from TaxonNode editor
These are different issues but very related to the given issue therefore I mention it here. If difficult to fix feel ... Andreas Müller
10:17 AM bug #9393: NPE when removing parent from TaxonNode editor
When opening the NodeEditor from classification the parent field is still empty. When selecting a parent the Labels a... Andreas Müller
10:15 AM bug #9393 (Feedback): NPE when removing parent from TaxonNode editor
I got a very similar NPE when deleting the "reuse existing name":
~~~
last remote method : http://test.e-taxono...
Andreas Müller
12:24 PM bug #9350 (Feedback): Create new taxonnode ignores the publish flag
Works as expeccted.
Should we check after the release that the code merge worked correctly? Or should we close tic...
Andreas Müller
12:03 PM task #9407 (New): Reuse taxon should check classification before save
Reusing a taxon is not allowed in the same classification. If doing so anyway in the taxon node dialogue an error is ... Andreas Müller
12:03 PM Revision f82805a7 (taxeditor): ref #9393: avoid NPE
Katja Luther
11:56 AM Revision 39973b73 (taxeditor): ref #9393: disable sec selection if reused taxon is used
Katja Luther
11:37 AM bug #9369: Reference Detail is missing in MediaSpecimen details view
Andreas Müller wrote:
> The missing reference detail is fixed.
>
> The spaces between some fields are still missi...
Katja Luther
11:06 AM bug #9369 (Feedback): Reference Detail is missing in MediaSpecimen details view
The missing reference detail is fixed.
The spaces between some fields are still missing.
Moving the URI to top ...
Andreas Müller
11:05 AM Revision 46f38420 (taxeditor): ref #9393: fix problems when removing reused name - code cleaning
Katja Luther
11:05 AM Revision 6d284e79 (taxeditor): ref #9393: fix problems when removing reused name
Katja Luther
10:53 AM bug #9371 (Closed): Media bulk does not persist data anymore
No it saves as expected Andreas Müller
10:50 AM bug #9382 (Closed): For nomenclatural source show taxonname in referencing objects view
Looks fine. Katja Luther
10:38 AM bug #9382: For nomenclatural source show taxonname in referencing objects view
I dis some further changes and NPE prevention. Please have a look and close if you think it is ok. Andreas Müller
10:37 AM bug #9382: For nomenclatural source show taxonname in referencing objects view
Applied in changeset commit:taxeditor|db226011dbf5f1c7de1060d15dce17f7faaed67f. Andreas Müller
10:48 AM feature request #9375 (Closed): Alphabetical order for reference type drop down
Works as expected. Andreas Müller
10:43 AM bug #9391 (Closed): If named area level does not exist remove the level information
Looks fine Andreas Müller
10:37 AM Revision db226011 (taxeditor): fix #9382 handle potential NPE and adapt label to make clear that it is not the name itself but the source that is referencing
Andreas Müller
10:26 AM Revision 36fdf767 (taxeditor): cleanup
Andreas Müller
09:43 AM feature request #9404: Open issues for Tropicos Import
Maybe the format will change in future:
WGB to Chuck Miller:
I see that the Tropicos Name Matching is working aga...
Andreas Müller
09:06 AM bug #9403 (Closed): cleanup function cdm_related_taxon() from used paramerters and css class attributes
Andreas Kohlbecker
09:06 AM bug #9403 (Resolved): cleanup function cdm_related_taxon() from used paramerters and css class attributes
Applied in changeset commit:cdm-dataportal|846f21e18654a33f2027824599149834c0aff88a. Andreas Kohlbecker
09:05 AM Revision 846f21e1 (cdm-dataportal): fix #9403 cleanup function cdm_related_taxon() from used paramerters
Andreas Kohlbecker

01/20/2021

08:06 PM bug #6164: cyprus: invalid data causing crash in modifier editor
test if this is still an open issue. Andreas Müller
07:55 PM feature request #3502: extensions not yet handled in compose_cdm_specimenOrObservation()
target version is missing! Put on current milestone like other specimen related issues? Andreas Müller
07:49 PM task #3485: object graph returned by REST services can be specified by initstrategy
target version is missing! Is this still an open issue? Andreas Müller
07:48 PM bug #3480: tagged text with square bracket confuses json
target version is missing. I put it to same milestone as related ticket. Please change if this is wrong. Andreas Müller
07:40 PM feature request #3030: Jenkins php jobs: setup for code analysis, mess detection etc..
target version is missing! Is it still an open issue? Andreas Müller
07:37 PM feature request #6016: ICN rules in cdm validation framework implemented
target version is missing! Is it still an open issue? Andreas Müller
07:35 PM feature request #6598: Migrate commands and handlers
target version is missing!
Can we assess in current milestone what still needs to be done to close this ticket. Th...
Andreas Müller
07:30 PM task #9377: Update of other platform user documentation
target version is missing! Andreas Müller
07:27 PM feature request #8182: show blast search result
is this still an open issue? Should it be reviewed? Should open issues be moved to new ticket?
Is there an example...
Andreas Müller
07:25 PM bug #7829 (Closed): Improve deduplication of parsed names and references
This has been finished (with few exceptions) in #9085. Andreas Müller
07:10 PM feature request #6133 (Closed): Improve Rank Webservice
Created follow up #9406 for open issue, close this ticket Andreas Müller
07:09 PM feature request #9406: Open issue for Edaphobase rank web service
put to low priority as edaphobase is currently not active Andreas Müller
07:08 PM feature request #9406 (Rejected): Open issue for Edaphobase rank web service
follow up for #6133
Open issue:
* representations are not mapped to a language
Andreas Müller
06:49 PM task #5085: Aggregate Distributions
This is a duplicate for some other tickets: #5176, #8679, #8677 and maybe someother.
Should be tested on FauEu Data ...
Andreas Müller
06:33 PM bug #7665 (Closed): ConcurrentModificationException when closing Editor
If at all it happens very seldom. We should open a new ticket with a new stacktrace if it happens again. Andreas Müller
06:23 PM bug #1119 (Duplicate): [PARSER] Duplicate inreferences created during parsing are NOT merged when data gets saved
This has been fully fixed in #9085 so close this ticket as duplicate Andreas Müller
06:04 PM bug #3737 (Closed): Protected caches for taxa and names behave inconsistent
The first issue is solved. The second was improved, however, it still sometimes works inconsistent meaning that the s... Andreas Müller
06:04 PM bug #9405 (In Progress): Fields set to irrelevant for cache should be set by state only
Andreas Müller
06:02 PM bug #9405 (Closed): Fields set to irrelevant for cache should be set by state only
follow up from #3737
Currently this is not yet the case as they are set during UI update by calling refresh only o...
Andreas Müller
05:52 PM feature request #6965 (Closed): Tropicos Import
open issues copied to #9404, close this Andreas Müller
05:51 PM feature request #9404 (New): Open issues for Tropicos Import
copied from #6965
* Tests genauer
* Progressmonitor
* "Analyse" vor Import
* Klären, welche Funktionen von ...
Andreas Müller
04:25 PM Revision d016b62b (cdmlib): ref 6308: result should be ok, if taxon can be deleted but not the name
Katja Luther
04:16 PM Revision 931ee538 (taxeditor): typo
Katja Luther
03:13 PM bug #7223 (Closed): ReferenceEditor: disable fields depending on the Reference type
Andreas Müller wrote:
> Personal Communication has no DOI neither in the interfaces nor in TaxEditor. If this is ava...
Andreas Kohlbecker
03:12 PM Revision 46f7b66d (cdmlib): ref #7223 proper definition of IPersonalCommunication in ReferencePropertyDefinitions
Andreas Kohlbecker
02:53 PM bug #7764 (Closed): Fix classification and synonym bug in taxon name freetext search
works as expected, see for example the http://caucasusflora.org/ where subtree limitation, classification and `doSyno... Andreas Kohlbecker
02:46 PM bug #7108 (Closed): supress unwanted sourcetypes in handle_annotations_and_sources()
Andreas Müller wrote:
> Works fine now and ticket can be closed.
>
> I only wonder if only a citation micro refer...
Andreas Kohlbecker
02:40 PM feature request #7720 (Closed): use new taxonRelationshipsDTO webservice for all taxon relations
cleanup TODO copied to #9403 and now closing this ticket Andreas Kohlbecker
02:38 PM bug #9403 (Closed): cleanup function cdm_related_taxon() from used paramerters and css class attributes
1.) remove unused parameters:
`$relsign = NULL, $reltype_representation = NULL, $doubtful=false, $doLinkTaxon = FA...
Andreas Kohlbecker
02:11 PM Revision c27b3a19 (cdmlib): ref #9290 castTo method for TypedEntityReference
Andreas Kohlbecker
02:03 PM feature request #7417 (Closed): Make pro parte and partial synonym relationships always visible in data portals
this is fully implemented and also covered by the tests on the synonymy of *Miconia cubacinerea* in the reference dat... Andreas Kohlbecker
01:53 PM bug #7745 (Closed): Subtree filter for dataportal services
Andreas Kohlbecker
01:51 PM bug #7745: Subtree filter for dataportal services
Andreas Kohlbecker wrote:
> For the polytomous keys the following webservices need to be filtered by the subTree to ...
Andreas Kohlbecker
01:51 PM task #9402 (New): Subtree filter for polytomousKey and polytomousKeyNode services
For the polytomous keys the following webservices need to be filtered by the subTree to avoid unpublished taxa showin... Andreas Kohlbecker
01:49 PM bug #7386 (Closed): TaxonNamePopEditor: com.vaadin.data.Property$ReadOnlyException on saving a basionym
Andreas Kohlbecker
01:44 PM bug #9401 (New): Name bulk editor: focus gets lost when list loading is going on
Allerdings habe ich ein Problem damit den Fokus im Bulkeditor dauerhaft auf einen Namen zu setzten. Solange der Bulke... Andreas Kohlbecker
01:39 PM Revision d7d6bc83 (cdm-vaadin): ref #9290 making TypeDesignationWorkingsetEditorIdSet --> TypeDesignationWorkingsetIds more clear
Andreas Kohlbecker
01:38 PM bug #9290 (Resolved): stop setting Registration.citation as citation for TypeDesignations in all type editors by default
Hi Henning, could you please make some tests in the test-server to make sure the changes are not causing problems wit... Andreas Kohlbecker
01:32 PM Revision 0b71a670 (cdm-vaadin): ref #9290 making TypeDesignationWorkingsetEditorIdSet --> TypeDesignationWorkingsetIds more clear
Andreas Kohlbecker
12:43 PM Revision c63cad99 (cdmlib): fix #9391: fix test
Katja Luther
12:39 PM bug #9373: In specimen details view used within specimen tree editor titleCache field is not enabled when it is protected
I can't reproduce this. When the titlecache is protected, the field is enabled and the button shows the open lock.
!...
Katja Luther
11:55 AM Revision eb2005b8 (cdmlib): ref 6308: check for namedeletion in taxonbase isDeletable and add warning if not deletable
Katja Luther
11:54 AM feature request #6308 (Closed): Add configuration dialog for the deletion of synonyms in name editor
Andreas Müller wrote:
> The 2 warnings do not show up anymore so we can close this ticket.
> However, I am a bit as...
Katja Luther
11:34 AM bug #9398 (In Progress): ObjectNotFoundException when removing a synonym that is used as NameInSource
Katja Luther
11:33 AM bug #9398: ObjectNotFoundException when removing a synonym that is used as NameInSource
I think the problem is that the name used as "name used in source" still have the information to be the name of the d... Katja Luther
11:03 AM Revision 4f7744bd (cdmlib): fix #9391: fix test
Katja Luther
10:46 AM Revision c530ad2e (taxeditor): ref #9393: remove possibility to delete parent in newTaxon wizard
Katja Luther
10:41 AM bug #9393 (Resolved): NPE when removing parent from TaxonNode editor
The newTaxon wizard does not allow deleting the parent taxon anymore. To create a orphan taxon the user should use th... Katja Luther
10:25 AM Revision cc9c04a4 (cdm-vaadin): ref #9290 cleaning up
Andreas Kohlbecker
09:43 AM Revision 91e53109 (cdm-vaadin): ref #9290 SpecimenTypeDesignationEditor now using designation reference correctly
Andreas Kohlbecker
09:38 AM bug #9391: If named area level does not exist remove the level information
please review Katja Luther
09:38 AM bug #9391 (Resolved): If named area level does not exist remove the level information
Applied in changeset commit:cdmlib|6d7fe5d574d1264196441524f674c24732b248a0. Katja Luther
09:38 AM Revision 6d7fe5d5 (cdmlib): fix #9391: if no level exist remove class name in label with level in namedArea
Katja Luther
08:39 AM task #9400 (New): Check whether it is possible to set rights to reduce the work to descriptive datasets
mail NK:
Deshalb schon mal die Frage: Gibt es separate Rechte ausschließlich für Arbeit mit Descriptive Data Sets,...
Katja Luther

01/19/2021

07:18 PM Revision 888558ae (taxeditor): simplify rank handling
Andreas Müller
06:56 PM Revision 68b29e1f (taxeditor): make getCollection method final and remove deprecated annotation
Andreas Müller
06:54 PM Revision 688220c6 (taxeditor): cleanup
Andreas Müller
04:18 PM Revision 508b8f01 (cdm-vaadin): ref #9290 NameTypeDesignationEditor now using designation reference correctly
Andreas Kohlbecker
04:01 PM feature request #6076 (Closed): Specimen biocase search should work on observations
this ticket was about the filter on preservedSpecimen in the biocase search, now all records can be found. Comparing ... Katja Luther
03:32 PM feature request #7345 (Resolved): [E+M] Common name references selectable in TaxEditor
this seems to be fixed, the preference is available and activate and deactivate the filtering for common name referen... Katja Luther
03:09 PM feature request #7810 (Closed): DB preference to make Specimen editors visible
Changed the title of this ticket because only the editor availability was implemented in 5.4, for the other issues a ... Katja Luther
03:09 PM feature request #9399 (New): DB preference to make all Specimen functionality/menu items invisible
the preference to hide all specimen related parts of the editor already exist (see #7810), but the implementation of ... Katja Luther
02:58 PM bug #9354: Sorting in distribution editor is broken
please review. Katja Luther
02:57 PM bug #9354 (Resolved): Sorting in distribution editor is broken
this is fixed now by sorting the list on server side. The sortMode is a method parameter. Katja Luther
09:08 AM bug #9354: Sorting in distribution editor is broken
Andreas Müller wrote:
> Generally the comparator should work the same way as the taxon navigator compartor. But th...
Katja Luther
02:56 PM feature request #8889 (In Progress): Remaining issues for distribution editor - continue
Katja Luther
02:55 PM Revision 5594bd68 (taxeditor): ref #8889: the dto list is already ordered for distribution editor, add sortMode to method call
Katja Luther
02:41 PM Revision bed37770 (cdmlib): ref #8889: sort taxonnodes for distribution editor on server side
Katja Luther
01:03 PM Revision b66bc2e5 (taxeditor): cleanup
Andreas Müller
12:47 PM bug #7386: TaxonNamePopEditor: com.vaadin.data.Property$ReadOnlyException on saving a basionym
can be set to closed Wolf-Henning Kusber
12:11 PM task #9300: Name Page: harmonize media specimen lectotype representations
Andreas Müller wrote:
> so should we change status to "in progress" as questions are solved?
the conclusion is only ...
Andreas Kohlbecker
11:55 AM task #9300: Name Page: harmonize media specimen lectotype representations
so should we change status to "in progress" as questions are solved? Andreas Müller
11:49 AM task #9300: Name Page: harmonize media specimen lectotype representations
Wolf-Henning Kusber wrote:
> Nein, stimme nicht zu
after an extensive discussion we concluded the following inter...
Andreas Kohlbecker
10:42 AM task #9300: Name Page: harmonize media specimen lectotype representations
Nein, stimme nicht zu Wolf-Henning Kusber

01/18/2021

10:38 PM Revision 780809e8 (taxeditor): remove unused parent
Andreas Müller
10:38 PM Revision bc137806 (taxeditor): cleanup
Andreas Müller
07:11 PM Revision 17337b4f (taxeditor): fix generics compile error
Andreas Müller
05:27 PM Revision 17eaac4f (taxeditor): cleanup
Andreas Müller
05:24 PM Revision 9f1bb997 (taxeditor): ref #9354: improve sorting in distribution editor
Katja Luther
05:21 PM Revision 87855850 (cdmlib): ref #9354: add nodeDto to TaxonDistributionDTO
Katja Luther
04:11 PM Revision ad7201d3 (taxeditor): cleanup and generics for ICdmEntitySessionEnabled
Andreas Müller
03:54 PM bug #9354: Sorting in distribution editor is broken
Andreas Müller wrote:
> There are still open issues as the comparator does not follow the comparator contract and ha...
Katja Luther
09:35 AM bug #9354: Sorting in distribution editor is broken
I put this to critical as it is a requirement the E+M Bratislava team to edit disttribution data for CZ and SK which ... Andreas Müller
03:03 PM Revision 28ead5fc (taxeditor): cleanup
Andreas Müller
02:21 PM bug #9398 (Closed): ObjectNotFoundException when removing a synonym that is used as NameInSource
Either this is a problem on the order of operations during save. Or it is a general issue with merge where it could b... Andreas Müller
02:18 PM bug #9397 (Closed): Derivate tree view must show DerivedUnits even if the FieldUnit is missing
see also #7704 for the same problem in the specimen table Andreas Kohlbecker
02:05 PM Revision 26f72855 (cdmlib): fix #9395 DerivedUnit.collectFieldUnits() as DerivedUnit.collectRootUnits() to return all types of root units - removig debug code
Andreas Kohlbecker
01:41 PM bug #9396 (In Progress): nomenclatural status missing in typedesignations shown in synonymy
Example:
http://portal.cybertaxonomy.org/flora-cuba/cdm_dataportal/taxon/64e9f775-79fc-41cf-b154-225e8a4bc7d1
T...
Andreas Kohlbecker
01:08 PM feature request #6308 (Feedback): Add configuration dialog for the deletion of synonyms in name editor
The 2 warnings do not show up anymore so we can close this ticket.
However, I am a bit astonished that no warning ex...
Andreas Müller
12:31 PM Revision 1e863be8 (cdmlib): cleanup
Andreas Müller
12:21 PM bug #9395: DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
Hi, for your information:
to solve this ticket I renamed and extended DerivedUnit.collectFieldUnits() as DerivedUn...
Andreas Kohlbecker
12:17 PM bug #9395 (Resolved): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
Applied in changeset commit:cdmlib|485da8a92ae3a4c4c51e5631561d368de0915206. Andreas Kohlbecker
11:57 AM bug #9395 (Closed): DerivedUnit.collectFieldUnits() and findFieldUnitDTOByAssociatedTaxon() and findByAccessionNumber() in OccurrenceService to return all root units
DerivedUnit.collectFieldUnits() needs to returns also DerivedUnits as root unit which do not have a FieldUnit. This i... Andreas Kohlbecker
12:17 PM Revision 485da8a9 (cdmlib): fix #9395 DerivedUnit.collectFieldUnits() as DerivedUnit.collectRootUnits() to return all types of root units
Andreas Kohlbecker
11:37 AM feature request #7886 (Closed): Divide local preferences to db dependend local preferences
The open issue was moved to new ticket #9394.
This ticket can be closed.
Andreas Müller
11:36 AM bug #9394 (New): Local preferences can not be edited if no database connection exists
All database dependend preferences should be disabled in this case Andreas Müller
11:31 AM bug #7236 (Closed): Make available distribution status a database preference for TaxEditor distribution editor
This seems to be fixed. Open a new ticket if something does not work yet as expected. Andreas Müller
11:15 AM feature request #4363 (Resolved): Show more informative message for unsupported specimen structures in specimen bulk editor
Andreas Müller
11:11 AM bug #4362 (Closed): Some File->New dialogs do not work
Andreas Müller
11:10 AM bug #4362: Some File->New dialogs do not work
>Name cache fields behave strange as even with protected title cache they are not completely disabled.
This seems...
Andreas Müller
11:05 AM bug #9393 (In Progress): NPE when removing parent from TaxonNode editor
~~~
last remote method : http://test.e-taxonomy.eu:80/cdmserver/rem_conf_am/remoting/taxonnode.service
last remote ...
Andreas Müller
11:05 AM feature request #9392 (New): File -> new for specimen and taxa should be available again
With fixing #4362 specimen and taxa were removed, this should be reverted.
The creation of empty specimen should n...
Katja Luther
10:50 AM bug #6955 (Closed): NamedAreaSelection Dialog needs to be adapted to filtered getUuidAndTitleCache loading
This is fixed. The open issue is moved to a follow up ticket: #9391 Andreas Müller
10:50 AM bug #9391 (Closed): If named area level does not exist remove the level information
from #6955:
in NamedArea selection dialog:
As #7144 is solved now, we should remove the showing of the class name...
Katja Luther
10:45 AM feature request #7121 (Closed): adapt remaining UuidAndTitleCache methods to use filter
As this is too long ago we close the ticket without linking to the revert. Andreas Müller
10:43 AM bug #7124 (Closed): Avoiding multiple repesentation exceptions by removing the conversation from selection dialogs
This seems to be fixed. Andreas Müller
10:38 AM feature request #6076 (Feedback): Specimen biocase search should work on observations
Katja Luther
10:37 AM feature request #6076 (Resolved): Specimen biocase search should work on observations
Katja Luther
10:34 AM feature request #6076 (Feedback): Specimen biocase search should work on observations
Andreas Müller
10:26 AM feature request #6315 (Closed): Implement setSecundumForSubtree in TaxEditor
Andreas Müller
10:25 AM feature request #6315: Implement setSecundumForSubtree in TaxEditor
Andreas Müller wrote:
> There is also a lot of space between label "New secundum reference" and the text box for the...
Andreas Müller
10:23 AM bug #9390 (In Progress): Remaining issues for set secundum dialog
follow up from #6315
1. ~~there is too much space between label "If no reference is chosen ... " and the checkboxe...
Andreas Müller
08:47 AM bug #9245: Creating derived units from existing derived unit is not possible in specimen tree editor
Keep it in 5.18 for check whether it is already fixed. Katja Luther

01/15/2021

04:00 PM bug #9379 (Closed): exclude disabled classifications from advanced taxon search form
Andreas Kohlbecker
03:59 PM bug #9379 (Resolved): exclude disabled classifications from advanced taxon search form
Applied in changeset commit:cdm-dataportal|5f5db6555726b52d86587db4c3834f8130d75011. Andreas Kohlbecker
03:59 PM Revision 5f5db655 (cdm-dataportal): fix #9379 excluding unselected classifications from search form and harmonizing fitering code
Andreas Kohlbecker
02:00 PM feature request #7599: treeView for specimen data in dataportal
Ahh, ich sehe gerade, dass in #9216 schon die finale Lösung hinterlegt ist. Andreas Kohlbecker
01:58 PM feature request #7599: treeView for specimen data in dataportal
Andreas Kohlbecker wrote:
> [Andreas Müller wrote:]
>
> wenn ich es richtig verstehe bezieht sich das auf die De...
Andreas Kohlbecker
01:34 PM Revision 20b503f3 (cdm-dataportal): ref #7599 showing link for present character data
Andreas Kohlbecker
01:31 PM bug #9386: orthographic variants should not be symmetrical
Hallo,
ich denke mittlerweile, dass wir zwei Beziehungen brauche wie schon von Andreas Müller vorgeschlagen:
>...
Andreas Kohlbecker
01:21 PM bug #9386: orthographic variants should not be symmetrical
[Eckhard wrote]
Hallo,
nach neuerlichem Lesen des At. 61 gebe ich dir recht, Walter: die gültige orthographisch...
Andreas Kohlbecker
12:29 PM bug #9386: orthographic variants should not be symmetrical
Ich möchte nochmal explizit auf die Probleme hinweisen, die sich datenverabeitungsseitig aus symmetrischen Beziehunge... Andreas Müller
12:17 PM bug #9386: orthographic variants should not be symmetrical
Wolf-Henning Kusber wrote:
> What is about data exports? Isn't it maybe more problematic if the relation symetrical ...
Andreas Müller
12:10 PM bug #9386: orthographic variants should not be symmetrical
Andreas Kohlbecker wrote:
> auch wenn diese Beziehung zwischen zwei Namen im Modell als ungerichtet definiert ist, b...
Andreas Müller
12:07 PM bug #9386: orthographic variants should not be symmetrical
Andreas Kohlbecker wrote:
> Ich würde dafür plädieren die Benennung der Relation beizubehalten, sie aber im Modell a...
Andreas Müller
11:54 AM bug #9386: orthographic variants should not be symmetrical
Andreas Kohlbecker wrote:
> auch wenn diese Beziehung zwischen zwei Namen im Modell als ungerichtet definiert ist, b...
Andreas Müller
11:23 AM bug #9386: orthographic variants should not be symmetrical
Das Datum sollte die meisten Fälle korrekt einsammeln. Wie Andreas sagt, sollte eine Richtung erkennbar sein. Ausnahm... Wolf-Henning Kusber
11:00 AM bug #9386: orthographic variants should not be symmetrical
Hallo,
auch wenn diese Beziehung zwischen zwei Namen im Modell als ungerichtet definiert ist, besteht dennoch eige...
Andreas Kohlbecker
10:46 AM bug #9386: orthographic variants should not be symmetrical
What is about data exports? Isn't it maybe more problematic if the relation symetrical in EDIT? Wolf-Henning Kusber
10:36 AM bug #9386: orthographic variants should not be symmetrical
> WGB:
>
> richtig, Art. 61.1 sagt, dass es nur eine gültige („valid“, nicht „correct“) Variante gibt, aber er spr...
Andreas Müller
09:50 AM bug #9386: orthographic variants should not be symmetrical
ERS:
ja, es kann nur eine korrekte orthographische Variante geben, und daher ist die Richtung nicht symmetrisch: s...
Andreas Müller
12:11 PM bug #9257 (Closed): revise filtering in OccurrenceServiceImpl.assembleFieldUnitDTO(FieldUnit fieldUnit) by SpecimenOrObservationType.PreservedSpecimen
can be closed as open taks are copied to #9389 Andreas Kohlbecker
12:11 PM task #9389 (Closed): further improvement and revision of derivative filtering by type and DerivedUnitDTO
this is a follow-up ticket of #9257
see the comments in commit:aa52b6f0 for more details.
FieldUnitDTO.java:
...
Andreas Kohlbecker
11:07 AM Revision 4d95ead5 (cdm-dataportal): fixing deprecated use of join()
Andreas Kohlbecker
10:26 AM Revision 69a9dd7b (cdm-dataportal): fixing composition of invalid URLs for specific cases
Andreas Kohlbecker
10:25 AM bug #8874 (Resolved): move taxon is reverted when taxon is edited afterwards
this ticket was solved and assigned to you for review, sorry forgot to set to resolved. Katja Luther
10:12 AM bug #9356 (Resolved): Comparison method violates its general contract for SourceComparator and TypeDesignationComparator
adapted the comparator in cdmlib and removed hotfix workaround, please review. Katja Luther
10:11 AM Revision c018f269 (taxeditor): ref #9356: remove hotfix workaround
Katja Luther
10:00 AM Revision 8e507020 (cdmlib): ref #9356: adapt TypeDesignationComparator
Katja Luther
09:44 AM bug #9365: Reuse taxon does not work in new Taxon dialogue
please review Katja Luther
09:43 AM bug #9365 (Resolved): Reuse taxon does not work in new Taxon dialogue
Applied in changeset commit:taxeditor|de6b6edbe71e3f03039fbc6436ad7edba7651e3b. Katja Luther
09:43 AM Revision de6b6edb (taxeditor): fix #9365: fix reuse taxon in newTaxonNodeWizard
Katja Luther

01/14/2021

03:14 PM Revision c5c25011 (cdmlib): ref #9332 re-organizing source(es) in TypeDesignation init-strategy
Andreas Kohlbecker
03:06 PM Revision 600742ea (cdm-dataportal): whitespace
Andreas Kohlbecker
03:05 PM Revision f4c60bdf (cdm-dataportal): ref #9384 adapting test to modified createShortCitation method
Andreas Kohlbecker
01:27 PM feature request #9388 (New): show media specimen source in all pages
By now the `MediaSpecimen.media.souces.citation` is only shown in the registration page:
Registration page for
...
Andreas Kohlbecker
12:11 PM bug #7699: NPE in CdmTransientEntityCacher.getCacheElement()
There was the same issue while working with character matrix:
mail NK:
hm, es scheint aber doch noch ein Proble...
Katja Luther
11:55 AM bug #7699: NPE in CdmTransientEntityCacher.getCacheElement()
This way is would be more concise:
~~~java
boolean isCanceled = false;
while (true){
...
Andreas Kohlbecker
11:41 AM bug #7699: NPE in CdmTransientEntityCacher.getCacheElement()
Andreas Kohlbecker wrote:
> As far as I am understanding this problem it is the bulk editors which can be saves or c...
Katja Luther
11:43 AM Revision 6ce970f7 (taxeditor): ref #7699: wait for the thread to stop
Katja Luther
11:12 AM bug #7711 (Resolved): Bugs in media gallery
The issues mentioned above are solved except that deleting takes extremely long, I could not reproduce it anymore.
...
Katja Luther
11:07 AM Revision 0291fd25 (taxeditor): fix NPE in TextWithLabelElement
Katja Luther
10:16 AM bug #9386: orthographic variants should not be symmetrical
Wolf-Henning Kusber wrote:
> It is correct that there is only one correct spelling. In PhycoBank, we need to registe...
Andreas Müller
10:12 AM bug #9386: orthographic variants should not be symmetrical
WGB:
richtig, Art. 61.1 sagt, dass es nur eine gültige („valid“, nicht „correct“) Variante gibt, aber er spricht a...
Andreas Müller
10:10 AM Revision 5aa8ceb0 (cdmlib): ref #7711: delete last media in galery should not delete description
Katja Luther
08:50 AM bug #9387 (Closed): LazyInitializationException (LIE) in NameController.doGetTypeDesignationsInHomotypicalGroup()
Andreas Kohlbecker
08:49 AM bug #9387 (Resolved): LazyInitializationException (LIE) in NameController.doGetTypeDesignationsInHomotypicalGroup()
Applied in changeset commit:cdmlib|f836859b0030a90cd789ea4e4fd1d24440293bcb. Andreas Kohlbecker
08:31 AM bug #9387 (Closed): LazyInitializationException (LIE) in NameController.doGetTypeDesignationsInHomotypicalGroup()
doGetTypeDesignationsInHomotypicalGroup()GET: /cdmserver/greece_bupleurum_01_with_onthology/name/b0372cc9-cc9e-46c8-a... Andreas Kohlbecker
08:49 AM Revision f836859b (cdmlib): fix #9387 extending init strategy
Andreas Kohlbecker

01/13/2021

06:29 PM bug #9386: orthographic variants should not be symmetrical
It is correct that there is only one correct spelling. In PhycoBank, we need to register the published name "as is" =... Wolf-Henning Kusber
06:12 PM bug #9386 (New): orthographic variants should not be symmetrical
According to the nomenclatural code there is always only 1 valid orthographic variant so the name relationship should... Andreas Müller
05:29 PM task #8455: Show specimen preferredStableURL as external link icon?
Screenshot for long URI in typification:
![](picture429-1.png)
Andreas Müller
05:16 PM task #8455: Show specimen preferredStableURL as external link icon?
Detail screenshot from the Derivate tree view (the derivate path view looks quite the same):
![](picture859-1.pn...
Andreas Kohlbecker
04:26 PM task #8455: Show specimen preferredStableURL as external link icon?
example for ugly linking: http://ws2.cybertaxonomy.org/dataportal/greece_bupleurum_01_with_onthology/?q=cdm_dataporta... Andreas Müller
05:26 PM bug #9384 (Closed): DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
as we talk about bibliographic references here the ICN (or any other code) is not relevant here. It is the rule I hav... Andreas Müller
04:44 PM bug #9384: DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
The implementation is correct as far as the the implemented formatting rule for more than two authors is holding true... Andreas Kohlbecker
04:18 PM bug #9384: DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
The fix was not fully correct as it created teams like Name1, Name2 & al. but there should be always a maximum number... Andreas Müller
04:20 PM Revision 22b89169 (cdmlib): add javadoc comment
Andreas Müller
04:14 PM Revision 619db306 (cdmlib): fix #9384, ref #9279 fixed incorrect implementation of createShortCitation and added tests
Andreas Müller
04:12 PM Revision 8b822608 (cdmlib): cleanup
Andreas Müller
02:51 PM Revision 02879fb5 (taxeditor): fix state vocabulary menu parameter
Katja Luther
02:47 PM bug #7711 (In Progress): Bugs in media gallery
Katja Luther
12:08 PM bug #9369 (Resolved): Reference Detail is missing in MediaSpecimen details view
please review Katja Luther
12:07 PM Revision 66e893c0 (taxeditor): published in details more detailed label
Katja Luther
12:07 PM bug #9372 (Resolved): in media details view unprotected title cache is not updated when underlying data is changed
this ios fixed, please review Katja Luther
12:06 PM Revision 527b4867 (taxeditor): fix update of media details header and add published in details
Katja Luther
11:41 AM bug #9371: Media bulk does not persist data anymore
please review Katja Luther
11:36 AM bug #9371 (Resolved): Media bulk does not persist data anymore
Applied in changeset commit:taxeditor|0ef0103a664888c0e398b9ab5f83b0c170c5a599. Katja Luther
11:36 AM Revision 0ef0103a (taxeditor): fix #9371: fix save in media bulk editor
Katja Luther
09:58 AM task #9385 (New): Simplyfy boundingbox setting for user fixed map clipping
Problem:
The settings in `admin/config/cdm_dataportal/settings/geo` for the **Bounding box** needs to be complian...
Andreas Kohlbecker

01/12/2021

04:57 PM Revision 2a28e5d2 (cdmlib): TypedEntityReference: factory method with option to supress the label & using this in TypeDesignationSetFormatter
Andreas Kohlbecker
04:50 PM Revision bf3b398f (cdmlib): fixing inappropriate use of TypedEntityReference for creating tagged text in TypeDesignationSetFormatter
Andreas Kohlbecker
04:33 PM bug #9384: DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
please review
Tests for this method are missing and should be implemented asap. Please could you open a new ticke...
Andreas Kohlbecker
04:32 PM bug #9384 (Resolved): DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
Applied in changeset commit:cdmlib|854244ff90c5ff67a0b30a3cee7f1d49e7623cc5. Andreas Kohlbecker
04:30 PM bug #9384: DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members

Andreas Kohlbecker
04:29 PM bug #9384 (Closed): DefaultReferenceCacheStrategy.createShortCitation() working not correctly for Teams with two members
see https://api.phycobank.org/phycobank/registrationDTO.json?identifier=http://phycobank.org/102662
The Team "Mo...
Andreas Kohlbecker
04:32 PM Revision 5abafe6a (cdmlib): fixing NPE in RegistrationDTOController when identifier is not found
Andreas Kohlbecker
04:32 PM Revision 854244ff (cdmlib): fix #9384 fixing author team truncation
Andreas Kohlbecker
03:19 PM bug #9383 (Closed): Adapt apache configuration to modified dataportal registration page URL pattern
Andreas Kohlbecker
02:57 PM bug #9383 (Closed): Adapt apache configuration to modified dataportal registration page URL pattern
the apache configuration of edit-community needs to be adapted to the changes made for #9220 Andreas Kohlbecker
02:42 PM Revision 72a0a6e9 (taxeditor): fix link for webapp war
Katja Luther
11:55 AM bug #9174: After longer inactivity NPE for cache
Andreas Müller wrote:
> This is maybe the same as #7699
??
Andreas Müller
11:16 AM bug #9382 (Resolved): For nomenclatural source show taxonname in referencing objects view
Katja Luther
11:15 AM bug #9382 (Closed): For nomenclatural source show taxonname in referencing objects view
In referencing objects view the taxon name of a nomenclatural source is not shown, only 'sourced object not available' Katja Luther
09:34 AM feature request #9381 (New): Refresh button for character matrix
After adding new characters the matrix needs to be closed and reopened to get the changes. To optimize the workflow a... Katja Luther
 

Also available in: Atom