Project

General

Profile

Activity

From 08/14/2019 to 09/12/2019

09/12/2019

01:09 PM feature request #8544 (New): check for number of synonyms entered in name editor by copy paste and warn if it is a long list
mail WB:

ich habe gerade aus Versehen die Fehlermeldung in den Name-Editor kopiert. Das gibt eine SEHR lange Sy...
Katja Luther
11:44 AM feature request #8350 (In Progress): Search dialog for named areas should work with abbreviations
Katja Luther

09/11/2019

07:25 PM feature request #8134: Implement verbatim type information in dataportal
Andreas Kohlbecker wrote:
> The textual type designation are now at least shown in the taxon synonymy and in the nam...
Andreas Müller
04:53 PM feature request #8134: Implement verbatim type information in dataportal
test data dumped and stored in _testdata/edit-int/testdb/5.10/cdm_integration_reference-2019-09-11-001.sql.bz2 Andreas Kohlbecker
04:41 PM feature request #8134: Implement verbatim type information in dataportal
The textual type designation are now at least shown in the taxon synonymy and in the name page.
Open issues are:
...
Andreas Kohlbecker
11:50 AM feature request #8134 (In Progress): Implement verbatim type information in dataportal
Andreas Kohlbecker
11:50 AM feature request #8134: Implement verbatim type information in dataportal
[Feedback from Walter]
Hallo,
mit Bezug auf das Portal folgender Vorschlag meinerseits:
Wenn nach dem Ausgabet...
Andreas Kohlbecker
10:19 AM feature request #8134 (New): Implement verbatim type information in dataportal
Andreas Müller
10:18 AM feature request #8134: Implement verbatim type information in dataportal
Andreas Kohlbecker wrote:
> Hi Andreas,
>
> the verbatim type information is represented by the class `TextualTyp...
Andreas Müller
08:34 AM feature request #8134 (Feedback): Implement verbatim type information in dataportal
Hi Andreas,
the verbatim type information is represented by the class `TextualTypeDesignation`. This class has a b...
Andreas Kohlbecker
07:18 PM bug #4964: footnotes for taxonRelationship sources and annotations should be rendered together
The other milestone should not be used anymore Andreas Müller
04:30 PM feature request #8538 (Closed): add text_l10n for TextualTypeDesignation.text to web service respones
Andreas Kohlbecker
12:53 PM feature request #8538 (Resolved): add text_l10n for TextualTypeDesignation.text to web service respones
Applied in changeset commit:cdmlib|c4942e5e5d1cc2acc566cf357a22a90a140ca5e0. Andreas Kohlbecker
08:49 AM feature request #8538 (Closed): add text_l10n for TextualTypeDesignation.text to web service respones
The free text in `TextualTypeDesignation` needs to be localized for web service responses. See `DescriptionElementBea... Andreas Kohlbecker
03:19 PM task #8543 (Closed): overcome distinction of annotation and other foonotes
The distinction of annotation and other foonotes is causing problems as reported in #2602 and in #4964
Moreover it...
Andreas Kohlbecker
01:05 PM feature request #8542 (New): TaxEditor only remembers the last db and credentials not last db for server
mail AM:
derzeit scheint es so zu sein, dass sich der TaxEditor nur die allgemein zuletzt verwendete DB + credenti...
Katja Luther
01:04 PM bug #8541 (New): Unify Phylum and Division
According to ICNAFP (https://www.iapt-taxon.org/nomen/pages/main/art_3.html) phylum and division are the same. Also i... Andreas Müller
01:03 PM feature request #8540 (New): for localhost mgd the name of the db is not shown in title
mail AM:
bei Verwendung von Localhost Mgd. Wird derzeit die DB nicht im Titel angezeigt. Das ist gerade etwas st...
Katja Luther
12:51 PM task #8513 (Closed): CdmUtils: remove MUST_EXIST_FILE and getResourceFolderSeperator()
everything works as expected Andreas Kohlbecker
12:50 PM task #8505 (Closed): ConfigFileUtil: turn all spring bean methods into not statical methods.
fully solved and working as expected since there are no longer any problems in the dependent products Andreas Kohlbecker
11:48 AM feature request #8539 (Closed): Add IndividualsAssociation when adding specimens to the character matrix
Patrick Plitzner
09:21 AM bug #8535: Connect Dialog: Connect failure warning unreadable
Thank you for this screenshot. This clarifies the situation. There are a couple of eclipse bugs due to which eclipse ... Andreas Kohlbecker
08:28 AM bug #8535: Connect Dialog: Connect failure warning unreadable
This is how it looks on Windows:
![](picture342-2.png)
Should look similar after changing for linux. But open ...
Andreas Müller
06:57 AM bug #8535: Connect Dialog: Connect failure warning unreadable
Andreas Kohlbecker wrote:
> Andreas Müller wrote:
> > This is only an issue on linux.
>
> Maybe only for KDE. @P...
Patrick Plitzner
09:05 AM feature request #7695: web service providing compact TypeDesignation representation for homotypic groups and individual taxa
moving to release 5.10 as this is prerequisite for #7696 Andreas Kohlbecker
09:00 AM feature request #7695: web service providing compact TypeDesignation representation for homotypic groups and individual taxa
The `TextualTypeDesignation` also need to be handled by the `TypeDesignationSetManager` currently the controller meth... Andreas Kohlbecker

09/10/2019

05:45 PM bug #8537 (New): Connect Dialog: Connect failure warning can be missleading
When attempting to connect with invalid credentials the "Connect Dialog" reports this incident with an in-appropriate... Andreas Kohlbecker
05:33 PM bug #8535: Connect Dialog: Connect failure warning unreadable
Andreas Müller wrote:
> This is only an issue on linux.
Maybe only for KDE. @Patrick: Do you have similar experie...
Andreas Kohlbecker
05:20 PM bug #8535: Connect Dialog: Connect failure warning unreadable
This is only an issue on linux. Andreas Müller
05:15 PM bug #8535 (New): Connect Dialog: Connect failure warning unreadable
The relative luminance of font color and background are too close. Enhance the contrast for better readability.
![...
Andreas Kohlbecker
05:20 PM bug #8536 (Duplicate): Connect Dialog: UI elements exceed the available space
Depending on the system font dpi settings and "Widget style" parts of the Connect Dialog can become unreadable (see s... Andreas Kohlbecker
05:06 PM task #8534 (New): Usability/UX ticket overview
This ticket gives an overview on Usability/UX issues in the Taxeditor.
*Although user experience design (UX Desi...
Andreas Kohlbecker
11:28 AM bug #8533 (Closed): missing collector and fieldnumber in abcd import
when importing specimen/dna as associated units where the gathering event information is not complete in one of the d... Katja Luther
11:23 AM feature request #8014: Label wording im UI Name Editor
yes, perfectly implemented, thanks Wolf-Henning Kusber
11:17 AM feature request #8014 (Closed): Label wording im UI Name Editor
Andreas Kohlbecker
11:16 AM feature request #8014: Label wording im UI Name Editor
I implemented it exactly as suggested in the screenshot which is attached to the decription of this ticket:
Sugg...
Andreas Kohlbecker
10:57 AM feature request #8014: Label wording im UI Name Editor
"Replaced synonym" as decided, fine.
"Validation of": the idea was "Validation of designation" this would be the cor...
Wolf-Henning Kusber
11:03 AM bug #8462 (Closed): NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
agreed. Andreas Kohlbecker
09:25 AM bug #8462 (Resolved): NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
New species name with new genus with new replaced synonym with new orthographic variant successfully tested. I think ... Wolf-Henning Kusber
08:39 AM bug #8462 (Feedback): NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
the orthographic variant could also be tested, but I think your tests have sufficient coverage if you have started a ... Andreas Kohlbecker
10:14 AM bug #8532 (Resolved): common name language selection is not selected
Applied in changeset commit:taxeditor|c2a852f6e6b376780709a8da2ac614b1baf64bef. Katja Luther
10:13 AM bug #8532 (Closed): common name language selection is not selected
Hallo Katja,
in nightly und jetzt auch auf Prduction getestet (mit Cichorieen – Cichorium endivia – Common Name „B...
Katja Luther

09/09/2019

06:50 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
Tested: new genus with new reference: no problems
Tested: new basionym or replaced synonym with new reference: no pr...
Wolf-Henning Kusber
03:34 PM bug #8374 (Duplicate): Save genus generated for a species with a different reference
duplicates #8462 Andreas Kohlbecker
03:10 PM feature request #8014: Label wording im UI Name Editor
done, please review. Andreas Kohlbecker
03:09 PM feature request #8014 (Resolved): Label wording im UI Name Editor
Applied in changeset commit:cdm-vaadin|218b286e1ebf5a962c239f2bd726df714652257e. Andreas Kohlbecker
01:21 PM bug #8531 (In Progress): factual data and media view always opened when opening taxon
Katja Luther
01:20 PM bug #8531 (Resolved): factual data and media view always opened when opening taxon
Katja Luther
01:02 PM bug #8531 (Closed): factual data and media view always opened when opening taxon
the factual data and media view should stay closed when opening a new taxon.
when opening the distribution editor th...
Katja Luther
11:54 AM feature request #8528: new author should be entered atomized
If possible we should make this configurable. I guess there is a reason why we currently have it as it is. Andreas Müller
09:28 AM feature request #8528 (New): new author should be entered atomized
mail of ERS:
wenn man einen neuen Autoren einer bibliographischen Referenz eingeben will, ist der Cache default-m...
Katja Luther
11:05 AM bug #8530: Multiple Representation Exceptions when editing Textual Type Designations
Alles war vorher abgespeichert. Nur existierenden Type-Text aufgemacht, Text hinzugefügt, gespeichert.
~~~
login ...
Katja Luther
11:04 AM bug #8530: Multiple Representation Exceptions when editing Textual Type Designations
Hallo,
der Fehler scheint bei einfachen nom. details nicht aufzutauchen, also wenn nur eine Seitenangabe vorliegt.
...
Katja Luther
11:04 AM bug #8530: Multiple Representation Exceptions when editing Textual Type Designations
Hallo,
und jetzt einfach nach Anfügen der nom. Referenz des Synonyms und speichern – der Name war offenbar noch nich...
Katja Luther
11:04 AM bug #8530 (New): Multiple Representation Exceptions when editing Textual Type Designations
there is again a multiple representation exception when editing nomenclatural reference and textual type designation.... Katja Luther
10:02 AM feature request #8529 (New): [DISCUSS]Display of aggregated descriptions
NK:
~~Für die Ausgabe der Daten im Portal sind sicher noch darstellungstechnische Anpassungen nötig, ich stelle mi...
Patrick Plitzner

09/06/2019

10:59 PM bug #8527: TaxonNameEdior: 'Validations' and 'Orthographocal corrections' are lost when editor is saved a second time
fixed! Please review once the server is updated. Andreas Kohlbecker
10:58 PM bug #8527 (Resolved): TaxonNameEdior: 'Validations' and 'Orthographocal corrections' are lost when editor is saved a second time
Applied in changeset commit:cdm-vaadin|81472d534399543096e4e64d32b0026f5a8a6023. Andreas Kohlbecker
09:58 PM bug #8527 (Closed): TaxonNameEdior: 'Validations' and 'Orthographocal corrections' are lost when editor is saved a second time
# THIS BUG IS CRITICAL SINCE IT CAN CAUSE UN-NOTICED DATA LOSS!!!!!!!!
This bug affects the widgets for 'Validati...
Andreas Kohlbecker
10:04 PM feature request #8408: add nomenclatural code select to NomenclaturalStatusRow
please review once the server is up to date Andreas Kohlbecker
07:38 PM feature request #8408 (Resolved): add nomenclatural code select to NomenclaturalStatusRow
Applied in changeset commit:cdm-vaadin|ee2bbfeb4aaffddede5d2788b9e3db733282e591. Andreas Kohlbecker
10:04 PM feature request #8409: add nomenclatural code select to NameRelationField
please review once the server is up to date Andreas Kohlbecker
10:02 PM feature request #8409 (Resolved): add nomenclatural code select to NameRelationField
Applied in changeset commit:cdm-vaadin|7ee1c79ac0fd622d7a7e7d8acf3963aaae2cf109. Andreas Kohlbecker
09:34 PM feature request #8398: Add nomenclatural code edition to ruleConsidered
excellently implemented, thanks a lot!
I extended the protected constructors in `NameRelationship` and the related...
Andreas Kohlbecker
07:35 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
... once the server is updated ;-) Andreas Kohlbecker
06:38 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
please review Andreas Kohlbecker
06:35 PM bug #8462 (Resolved): NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
Applied in changeset commit:cdm-vaadin|c80e35c14a41f15fc00f6bfa0cd5c46eadf5b37a. Andreas Kohlbecker
02:19 PM bug #8516: Specimen editor (list) can not find FieldUnits with data only in protected titleCache
correct the `*` at the beginning of the search term helps.
I suggest renaming this issue to "improve and harmonize...
Andreas Kohlbecker
02:13 PM bug #8526 (Resolved): Swap synonym with accepted taxon does not work
Applied in changeset commit:taxeditor|cd9c544a43ceb69db7609d422f5c68abc1ccc115. Katja Luther
02:08 PM bug #8526 (Closed): Swap synonym with accepted taxon does not work
the swap synonym with accepted taxon handler/operation calls the service but saves the old taxon afterwards and the n... Katja Luther
11:48 AM bug #8525 (Duplicate): search for infraspecific name not working as expected
Example: https://cybertaxonomy.eu/eu-bon/utis/1.3/search?query=Corvus%20corone%20subsp.%20corone&providers=bgbm-cdm-s... Gabriele Dröge
11:46 AM bug #8523: add taxonuuid to name webservice for cdm providers
Gabriele Dröge wrote:
>
> Higher Taxa klappt irgendwie nicht. Habe folgende uuid probiert: http://caryophyllales...
Andreas Kohlbecker
11:43 AM bug #8523 (Closed): add taxonuuid to name webservice for cdm providers
Andreas Kohlbecker
11:19 AM bug #8523: add taxonuuid to name webservice for cdm providers
https://cybertaxonomy.eu/eu-bon/utis/1.3/search?query=Hylocereus%20setaceus&providers=bgbm-cdm-server%5Bcaryophyllale... Gabriele Dröge
11:15 AM bug #8523: add taxonuuid to name webservice for cdm providers
hallo Gabi, hast du noch den Beispiel URL? Andreas Kohlbecker
10:54 AM bug #8523 (Closed): add taxonuuid to name webservice for cdm providers
search results in UTIS without taxonuuid. This uuid is needed to get higher taxa.
Tried with bgbm-cdm-server[caryo...
Gabriele Dröge
11:45 AM bug #8524: Classification service not working with AbstractCdmServerClient
das kann ich mir eventuell nächste Woche ansehen. Andreas Kohlbecker
11:45 AM bug #8524 (New): Classification service not working with AbstractCdmServerClient
Higher Taxa klappt irgendwie nicht. Habe folgende uuid probiert: http://caryophyllales.org/cactaceae/cdm_dataportal/t... Andreas Kohlbecker
11:01 AM bug #8520 (Rejected): Adding new user Group fails
Ticket rejected. Andreas Kohlbecker
10:57 AM bug #8521: User details view: Change password button accessible for ROLE_USER_MANAGER
according to what I wrote in https://dev.e-taxonomy.eu/redmine/projects/edit/wiki/CdmAuthorisationAndAccessControl th... Andreas Kohlbecker

09/05/2019

10:20 PM bug #8521: User details view: Change password button accessible for ROLE_USER_MANAGER
I think not only the change password button but generally all User related issues need to be accessible. Can you plea... Andreas Müller
05:08 PM bug #8521 (Duplicate): User details view: Change password button accessible for ROLE_USER_MANAGER
The "Change password button" must also be accessible for the Role `ROLE_USER_MANAGER` not only for `Admin` Andreas Kohlbecker
10:16 PM bug #8520 (Feedback): Adding new user Group fails
Isn't it self-explaining: "must match "[A-Za-z0-9_\.\-]+"?
As discussed we have a rule since 5.9 that usernames an...
Andreas Müller
03:47 PM bug #8520 (Rejected): Adding new user Group fails
I attempted to created the Group "User Manager", this failed with the following exception:
~~~
login : admin
...
Andreas Kohlbecker
10:02 PM bug #8516: Specimen editor (list) can not find FieldUnits with data only in protected titleCache
Andreas Kohlbecker wrote:
> Andreas Müller wrote:
> > Have you tried with Asterisk search. The specimen bulk editor...
Andreas Müller
06:15 PM bug #8522 (Closed): Make type status mandatory in Name type designation editor
Make "type status" mandatory in "Name type designation editor"
Record can be saved without entering a name status.
Wolf-Henning Kusber
05:48 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
The solution to this problems is tightly related to #7843.
Since I am assuming that we will decide for strategy 3....
Andreas Kohlbecker
05:23 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
this seems to happen, when the first name editor has been opened for a new name to be registered and has not jet been... Andreas Kohlbecker
05:45 PM task #7843: blocking registrations can get lost when first TaxonNamePopupEditor with new name is not saved
I consider strategy 3 from above the most user friendly and robust solution Andreas Kohlbecker
04:03 PM bug #8519 (Closed): ROLE_USER_MANAGER missing in FirstDataInserter
done Andreas Kohlbecker
04:01 PM bug #8519 (Resolved): ROLE_USER_MANAGER missing in FirstDataInserter
Applied in changeset commit:cdmlib|06e3b3f860d1e1813e97118ead71807ca7ee6414. Andreas Kohlbecker
03:42 PM bug #8519 (Closed): ROLE_USER_MANAGER missing in FirstDataInserter
The role `ROLE_USER_MANAGER` is missing in data bases and can not be created via the Taxeditor, see Andreas Kohlbecker
03:34 PM bug #7991: GrantedAuthority selection dialog extremly slow
this is a massive problem for me. This dialog is completely unusable. Andreas Kohlbecker
03:26 PM bug #8377: TypeDesignationsEditors: Delete must not be allowe before the workingset is saved
please review Andreas Kohlbecker
03:25 PM bug #8377 (Resolved): TypeDesignationsEditors: Delete must not be allowe before the workingset is saved
Applied in changeset commit:cdm-vaadin|66af3161e72892bc06cb3ca9d9eb6e292f87c2fa. Andreas Kohlbecker
12:01 PM task #8518 (New): [PESI][DW] PESI export rules documented
Source:
Taxon:
* Displayname: seems not to be used in PESI portal; creation unclear, in ERMS SQL export only t...
Andreas Müller

09/04/2019

07:00 PM bug #8377 (In Progress): TypeDesignationsEditors: Delete must not be allowe before the workingset is saved
Andreas Kohlbecker
06:58 PM bug #8376: RegistrationWorkingsetEditor: prevent clicking any futher buttons after the openting of a popup editor has been triggered
please review Andreas Kohlbecker
06:57 PM bug #8376 (Resolved): RegistrationWorkingsetEditor: prevent clicking any futher buttons after the openting of a popup editor has been triggered
Applied in changeset commit:cdm-vaadin|4e9b68d2176a076bf7bd07ee6680f752f2223e2d. Andreas Kohlbecker
04:27 PM bug #8516: Specimen editor (list) can not find FieldUnits with data only in protected titleCache
Andreas Müller wrote:
> Have you tried with Asterisk search. The specimen bulk editor like all bulk editor do only a...
Andreas Kohlbecker
03:21 PM bug #8516 (Feedback): Specimen editor (list) can not find FieldUnits with data only in protected titleCache
Have you tried with Asterisk search. The specimen bulk editor like all bulk editor do only an exact search. The speci... Andreas Müller
04:01 PM feature request #8342: shift field Field number
please review Andreas Kohlbecker
04:01 PM feature request #8342 (Resolved): shift field Field number
Applied in changeset commit:cdm-vaadin|764269a10375767ce378c5e51a81639543a53eae. Andreas Kohlbecker
11:57 AM bug #8517 (Resolved): SpecimenOrObservation: data from protected titleCache missig in portal pages
please review Andreas Kohlbecker
11:55 AM bug #8517: SpecimenOrObservation: data from protected titleCache missig in portal pages
this is actually a problem in the `DerivedUnitFacadeCacheStrategy` which misses to respect protected `FieldUnit` titl... Andreas Kohlbecker

09/03/2019

06:51 PM bug #8517 (Closed): SpecimenOrObservation: data from protected titleCache missig in portal pages
The following portal pages are missing to show data from protected SpecimenOrObservation.titleCaches:
* Registrati...
Andreas Kohlbecker
06:49 PM bug #8516 (Feedback): Specimen editor (list) can not find FieldUnits with data only in protected titleCache
while the *Specimen editor (list)* misses finding the below shown FielUnits the *Specimen editor (tree)* finds them ... Andreas Kohlbecker
06:06 PM bug #6523: Correct display of misspellings in synonymy
Andreas Kohlbecker wrote:
> Guten Morgen,
>
> ich bin hinsichtlich einer endgültigen Lösung leidenschaftslos und...
Andreas Kohlbecker
05:04 PM task #8512: Consider making Registration a subclass of IdentifiableEntity
As far as I understood will PhycoBank repeat the same registration that has been done in another registration.
Thi...
Andreas Kohlbecker
04:54 PM task #8512: Consider making Registration a subclass of IdentifiableEntity
We first need more information about the semantic of the additional registration. Should it be a pure clone like in G... Andreas Müller
12:59 PM task #8512 (New): Consider making Registration a subclass of IdentifiableEntity
For Phycobank it is needed to refer to external registration identifiers.
E.g.: A registration made in mycobank, z...
Andreas Kohlbecker
04:21 PM task #8514 (Closed): remove all PhycoBank redmine instances
copied from #7265 Andreas Kohlbecker
04:12 PM bug #8189: Allow configuration of 'user.home' via the spring environment
Andreas Müller wrote:
> Andreas Müller wrote:
> > The test ConfigFileUtilTest.testGetFolderSeperator does not work ...
Andreas Kohlbecker
04:11 PM task #8513: CdmUtils: remove MUST_EXIST_FILE and getResourceFolderSeperator()
if there are no problems in the products a review by another person will not be needed and the ticket can be closed. Andreas Kohlbecker
04:09 PM task #8513 (Resolved): CdmUtils: remove MUST_EXIST_FILE and getResourceFolderSeperator()
Applied in changeset commit:cdmlib|c3fca4bd9b4120f48b605f36f5efc59dd8e4bba8. Andreas Kohlbecker
04:08 PM task #8513 (Closed): CdmUtils: remove MUST_EXIST_FILE and getResourceFolderSeperator()
follow up to #8189
The getResourceFolderSeperator() method is not needed at all. The separator character is only u...
Andreas Kohlbecker
03:12 PM task #8505 (Resolved): ConfigFileUtil: turn all spring bean methods into not statical methods.
Applied in changeset commit:cdmlib|68ea5e65a8f844fef8efbf698f53f4fbfa6367b3. Andreas Kohlbecker
03:11 PM task #8505 (In Progress): ConfigFileUtil: turn all spring bean methods into not statical methods.
Andreas Kohlbecker
10:00 AM bug #8511 (Closed): The structure path in the character details view should have a line break
As seen in the screen shot, a large structure path expands the width of the details view so that the user has to scro... Patrick Plitzner
09:51 AM bug #8510 (New): Non unique object exception when creating FeatureStates
I could reproduce this by creating about 4-5 FeatureStates for a character tree, then save, and then create another 3... Patrick Plitzner

09/02/2019

08:59 AM bug #8488 (In Progress): Characters can not be added to feature trees
It is now possible to add characters to a feature tree via the context menu. Patrick Plitzner

09/01/2019

06:15 PM task #8509 (In Progress): [PESI][ERMS] Export ERMS data to PESI
Andreas Müller
05:52 PM bug #8508 (In Progress): [PESI][ERMS] ERMS import pipeline validation
Add validation for the correctnes of the ERMS->CDM->PESI pipeline Andreas Müller

08/30/2019

09:40 PM bug #8189: Allow configuration of 'user.home' via the spring environment
Andreas Müller wrote:
> The test ConfigFileUtilTest.testGetFolderSeperator does not work anymore on windows systems ...
Andreas Müller
04:50 PM bug #8189 (Closed): Allow configuration of 'user.home' via the spring environment
all remaining tasks copied to #8505
and closing this ticket
Andreas Kohlbecker
08:59 PM feature request #8507 (New): Handle common names with same name and language but different area better in data portal
As an example see: https://www.europlusmed.org/cdm_dataportal/taxon/eaa22491-9bf2-44f6-ba13-3eb3af6134a9
We could...
Andreas Müller
08:04 PM task #8391: Name page shows complete name information (II)
If you create subtasks you should put all tasks to subtasks. Otherwise ticket handling doesn't work well.
Preferred ...
Andreas Müller
05:17 PM task #8506 (New): Remove the UpdatableRoutingDataSource, related classes and configuration
The UpdatableRoutingDataSource has not been used for years and will never be reactivated since this concept would cau... Andreas Kohlbecker
04:45 PM task #8505 (Closed): ConfigFileUtil: turn all spring bean methods into not statical methods.
follow up to #8189
in ConfigFileUtil
**1.** turn all spring bean methods into not statically methods.
**2.*...
Andreas Kohlbecker
04:30 PM task #8504 (Closed): Name page: allow hiding the Taxon section via settings
works as expected Andreas Kohlbecker
03:22 PM task #8504 (Resolved): Name page: allow hiding the Taxon section via settings
Applied in changeset commit:cdm-dataportal|c05ac190012f0f56d4d2b8d47d6e227eabe353ed. Andreas Kohlbecker
03:05 PM task #8504 (Closed): Name page: allow hiding the Taxon section via settings
Andreas Kohlbecker
02:37 PM feature request #8344 (Feedback): Cdm light export: add dummy line in simple facts table
I have no time to review this. But I remember a discussion with WGB where he complaint that the line endings are linu... Andreas Müller
01:08 PM feature request #8178 (Rejected): Auto-create absence/presence character for every structure
Rejecting ticket -> It does not always make sense to auto-create the "presence" character e.g. "Tepal Tip" is a struc... Patrick Plitzner
08:56 AM feature request #8299: add typification column to scientific name and homotypical group in cdm light
move to 5.10 for feedback of WB Katja Luther

08/29/2019

10:17 PM bug #8385: Open issues in DB preferences
can you move open issues to #8489? Andreas Müller
04:25 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> In local preferences Publish Flag for "Use Default" the Camel Case is used, not the current ...
Katja Luther
03:30 PM bug #8385: Open issues in DB preferences
In local preferences Publish Flag for "Use Default" the Camel Case is used, not the current correct label. E.g. (NotP... Andreas Müller
02:37 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Distribution editor: Restore default removes the entry "distribution.status.term" from the a...
Katja Luther
02:37 PM bug #8385: Open issues in DB preferences
Katja Luther wrote:
> Andreas Müller wrote:
> > Distribution editor status and area selection: restore default dele...
Andreas Müller
02:32 PM bug #8385: Open issues in DB preferences
Distribution editor: Restore default removes the entry "distribution.status.term" from the above table (and completel... Andreas Müller
02:30 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Distribution editor status and area selection: restore default deletes the values correctly ...
Katja Luther
02:28 PM bug #8385: Open issues in DB preferences
Distribution editor status and area selection: restore default deletes the values correctly but when opening the sele... Andreas Müller
02:21 PM bug #8385: Open issues in DB preferences
Names.NomenclaturalStatus restores default only after clicking 2x "Restore Default". Or more exact, clicking the firs... Andreas Müller
01:58 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Andreas Müller wrote:
> > Generally values recovered by "Restore default" often seem not to...
Katja Luther
01:22 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Generally values recovered by "Restore default" often seem not to be persisted but old value...
Andreas Müller
01:16 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Andreas Müller wrote:
> > Saving of "Publish Flag" does not always work. You may try differ...
Katja Luther
01:15 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Andreas Müller wrote:
> > General: When choosing "No - allow override" for all 3 entries th...
Katja Luther
01:12 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Saving of "Publish Flag" does not always work. You may try different states including allow ...
Andreas Müller
12:53 PM bug #8385: Open issues in DB preferences
Katja Luther wrote:
> Andreas Müller wrote:
> > Is there a reason why allow override is always disabled for "Enable...
Katja Luther
12:48 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> General: When choosing "No - allow override" for all 3 entries the values shown in local pre...
Andreas Müller
12:45 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Is there a reason why allow override is always disabled for "Enable Distribution Editor"?
...
Katja Luther
12:34 PM bug #8385 (Feedback): Open issues in DB preferences
Is there a reason why allow override is always disabled for "Enable Distribution Editor"? Andreas Müller
11:58 AM bug #8385 (Resolved): Open issues in DB preferences
abcd preferences are moved to a new ticket, please review the rest. Katja Luther
03:40 PM feature request #8503: Create abstract base UI from RegistrationUI and use it for all UIs
> Especially it needs to be available for the distribution editor
agreed! This means it need to be done for the Di...
Andreas Kohlbecker
03:10 PM feature request #8503: Create abstract base UI from RegistrationUI and use it for all UIs
Especially it needs to be available for the distribution editor Andreas Müller
03:08 PM feature request #8503 (Closed): Create abstract base UI from RegistrationUI and use it for all UIs
The code which configures the error hanlder should also go into the abstract base class:
~~~java
Delegati...
Andreas Kohlbecker
03:32 PM feature request #8304: Name page redirects to according taxon depending on query parameter
the result of our call was the following:
The global switch which overrides the redirect behavior is not causing p...
Andreas Kohlbecker
02:49 PM bug #8462: NoSuchElementException accessing Optional<RegistrationDTO> in RegistrationWorkingsetPresenter.findRegistrationInContext()
the same issue was reported once again:
Test New name entered (not saved) new Basionym, new reference or selected ...
Andreas Kohlbecker
02:36 PM bug #8502: taxa with doubtful flag lack proper formatting
Eckhard please can you test in http://test.e-taxonomy.eu/dataportal/preview/euromed/ if this issue is solved now? Andreas Kohlbecker
02:35 PM bug #8502 (Resolved): taxa with doubtful flag lack proper formatting
Applied in changeset commit:cdm-dataportal|61fc6c9311b1053b08ebb32085842f231edb3746. Andreas Kohlbecker
02:15 PM bug #8502 (Closed): taxa with doubtful flag lack proper formatting
taxa with doubtful flag lack proper formatting. The dataportal uses the titleCache instead of the taggedTitle. Andreas Kohlbecker
12:10 PM task #8501 (New): setup OWASP vulnerability checker for projects

The (jenkins plugin](https://wiki.jenkins.io/display/JENKINS/OWASP+Dependency-Check+Plugin) seems not to be worki...
Andreas Kohlbecker
11:38 AM bug #8500: DistributionStatusUI: Error while detaching UI from session
back to unassigned .... Andreas Kohlbecker
10:54 AM bug #8500 (New): DistributionStatusUI: Error while detaching UI from session

~~~
[flora-cuba] 2019-08-29 10:12:43,276 WARN [org.eclipse.jetty.server.session.HashSessionManager@5330da99Timer...
Andreas Kohlbecker
09:20 AM task #8499 (New): Decide how to handle additional parameters like refAuthorString and originalNomenclaturalTitle for Berlin Model/E+M
They have been additionally imported to CDM from BM, as the information may be needed in future.
For Person it has...
Andreas Müller
05:14 AM feature request #8282 (Closed): Implement placementDoubtful in TaxEditor
We could still add symbols with the current state of the flag to the "Set Flags" submenu. I created a new ticket for ... Andreas Müller
05:12 AM bug #8498 (In Progress): Set Flags should show the current status of the flags
Currently when setting the flag one does not know if the flag is set before or not. Especially for doubtful this is t... Andreas Müller

08/28/2019

05:00 PM bug #8497 (Closed): NullPointerException (NPE) in AbstractCdmServerClient.generateTaxon()
Andreas Kohlbecker
03:47 PM bug #8497 (Resolved): NullPointerException (NPE) in AbstractCdmServerClient.generateTaxon()
Applied in changeset commit:utis-core|8aacc65061a59b7e3efac378d7348d075e2dc0f9. Andreas Kohlbecker
03:39 PM bug #8497 (Closed): NullPointerException (NPE) in AbstractCdmServerClient.generateTaxon()
this bug breaks all Phycobank requsts:
~~~
Exception in thread "Thread-8191" java.lang.NullPointerException
...
Andreas Kohlbecker
04:51 PM feature request #8180 (Closed): Add property term "Presence/Absence" to CDM default terms
Terms and vocabulary are available in the taxeditor and replace possible existing presence/absence terms. Patrick Plitzner
04:50 PM feature request #8475 (Closed): Adapt applicable state detail view elements to FeatureState
Patrick Plitzner
01:27 PM feature request #8475 (Feedback): Adapt applicable state detail view elements to FeatureState
For future a real freetext search might be preferable for the states in case there are >>10 states, but for now it is... Andreas Müller
10:00 AM feature request #8475 (Resolved): Adapt applicable state detail view elements to FeatureState
Removed empty element after first selection.
All issues should be fixed now.
Patrick Plitzner
03:45 PM bug #8389 (Resolved): Correct handling of default values with allowOverride=false
now the allow override selection is now handled seperatly and the preference is only removed when default + allow ove... Katja Luther
10:28 AM bug #8389: Correct handling of default values with allowOverride=false
But this is what this ticket is all about.
I can't remember that we decided to delete if "default" was selected AND ...
Andreas Müller
10:12 AM bug #8389: Correct handling of default values with allowOverride=false
Andreas Müller wrote:
> Katja Luther wrote:
> > The actual implementation is that if the default value is chosen al...
Katja Luther
10:03 AM bug #8389 (Feedback): Correct handling of default values with allowOverride=false
Katja Luther wrote:
> The actual implementation is that if the default value is chosen allowOverride is set to true ...
Andreas Müller
09:58 AM bug #8389 (Resolved): Correct handling of default values with allowOverride=false
Katja Luther
09:37 AM bug #8389: Correct handling of default values with allowOverride=false
The actual implementation is that if the default value is chosen allowOverride is set to true and the checkbox is dis... Katja Luther
03:41 PM feature request #8282 (Resolved): Implement placementDoubtful in TaxEditor
the labels are moved Katja Luther
03:09 PM bug #8496 (New): Improve public setters for entity collections
I had a problem when writing the CDM2CDM import. Here I wanted to call the setter and replace the old collection (whi... Andreas Müller
02:35 PM bug #8496 (Feedback): Improve public setters for entity collections
Does this implementation cause any real problems or is it only semantically problem?
As far as I remember the culp...
Andreas Kohlbecker
02:20 PM bug #8496 (New): Improve public setters for entity collections
These were implemented in #7600.
Unfortunately the current semantics is that e.g. AnnotatableEntity.setAnnotations...
Andreas Müller
02:23 PM feature request #8495 (Closed): classification tree horizontally scrolls to active entrty
done! Andreas Kohlbecker
02:16 PM feature request #8495 (Closed): classification tree horizontally scrolls to active entrty
Wenn man sich durch die Classification klickt, verschwindet ab einer gewissen Ebene das, was man eigentlich sehen wil... Andreas Kohlbecker
02:21 PM feature request #7600: public setters for entity collections
There is an open issue with the current implementation. I created a new ticket: #8496 Andreas Müller
02:13 PM task #8479 (In Progress): [PESI][FE] Cdm-2-Cdm import for FauEu
Andreas Müller
02:05 PM bug #8494 (In Progress): Better ABCD Preferences Page
to be done
see also #8489
also #8385#note-51,
#8385#note-52
~~Why does the nomenclatural code not provid...
Katja Luther
02:04 PM bug #8493: hide taxon page general tab TOC block if empty
adding work in progress as patch file: attachment:issue-8493.patch Andreas Kohlbecker
02:00 PM bug #8493 (In Progress): hide taxon page general tab TOC block if empty
I tried solving this issue and found that the table of contents is not empty. For Euro+Med the synonymy has been hidd... Andreas Kohlbecker
01:16 PM bug #8493 (In Progress): hide taxon page general tab TOC block if empty
reported by Anton:
Hallo,

da ist so ein verrutschtes “Content” (s.u.).
https://www.europlusmed.org/?q=cdm_d...
Andreas Kohlbecker
11:58 AM bug #8492: Adapt CsvNameExport to rollback only and generally review where and how it should be used
These 2 tests failed:
~~~
Tests in error:
IOServiceExportTest.exportCSVNameTest:99 ? UnexpectedRollback Trans...
Andreas Müller
11:57 AM bug #8492 (New): Adapt CsvNameExport to rollback only and generally review where and how it should be used
To make the 2 CsvNameExport tests in TaxEditor test environment not fail, read only was set to false in CsvNameExport... Andreas Müller
11:16 AM feature request #8491 (New): show higher taxon graph in name and taxon pages optionally
Step 1: discuss the concept of showing the higher graph paths Andreas Kohlbecker
09:40 AM feature request #8490 (New): Sitemap implemented
This feature has been requested since the early days of the dataportal.
A "sitemap" for the following data types i...
Andreas Kohlbecker

08/26/2019

02:56 PM feature request #8299: add typification column to scientific name and homotypical group in cdm light
I added two columns to homotypical group table: TypeString (for SpecimenTypeDesignations) and TypeCache (for TextualT... Katja Luther
01:46 PM bug #8389: Correct handling of default values with allowOverride=false
Has this been fixed in 5.9 together with #8385. To me it looks like fixed but I did not test systematically.
Pleas...
Andreas Müller
01:41 PM bug #8385: Open issues in DB preferences
~~Generally values recovered by "Restore default" often seem not to be persisted but old values are kept.~~
fixed
Andreas Müller
01:36 PM bug #8385: Open issues in DB preferences
~~Saving of "Publish Flag" does not always work. You may try different states including allow override adn "Restore D... Andreas Müller
01:35 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Andreas Müller wrote:
> > General: When choosing "No - allow override" for all 3 entries th...
Andreas Müller
01:22 PM bug #8385: Open issues in DB preferences
~~Search dialog: "Search also for titlecache ..." -> "... title cache ..."~~
fixed
Andreas Müller
01:20 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> General: When choosing "No - allow override" for all 3 entries the values shown in local pre...
Andreas Müller
01:15 PM bug #8385: Open issues in DB preferences
~~Publish Flage:~~
~~"Not Publish" -> "Don't Publish"~~
~~"Use Default (InheritFromParent)" -> kein Camel Case so...
Andreas Müller
01:10 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Name details view: "Restore Defaults" does not enable "Secundum enabled" and "Secundum Refer...
Andreas Müller
01:08 PM bug #8385: Open issues in DB preferences
~~NDV: "Whole Authorship section" -> "Whole authorship section"~~ Andreas Müller
01:08 PM bug #8385: Open issues in DB preferences
~~NDV: NameCache of the name ... -> "Name cache of the name ..."~~ Andreas Müller
01:07 PM bug #8385: Open issues in DB preferences
~~NDV: "Secundum Reference Details" -> "Secundum reference details"~~ Andreas Müller
01:06 PM bug #8385: Open issues in DB preferences
~~Name details view: "Restore Defaults" does not enable "Secundum enabled" and "Secundum Reference Details"~~
fixed
Andreas Müller
01:02 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> Same for ranks. They are not stored.
Hmm, maybe I made a mistake. This seems to work.
Andreas Müller
12:59 PM bug #8385: Open issues in DB preferences
~~Same for ranks. They are not stored.~~
fixed
Andreas Müller
12:58 PM bug #8385: Open issues in DB preferences
~~Nomenclatural status is not stored. Neither after reopening the pref dialog nor after restarting the TaxEditor the ... Andreas Müller
12:13 PM bug #8385: Open issues in DB preferences
~~General: When choosing "No - allow override" for all 3 entries the values shown in local preferences are "Use Defau... Andreas Müller
10:48 AM bug #8385: Open issues in DB preferences
>similar for BiocaseProvider: io.ABCD.providerList is stored with "Keine Provider verfügbar;" which seems to be incor... Andreas Müller
10:45 AM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> > Biocase Provider for associated DNA should be moved to "Biocase Provider"
> >>this is no...
Andreas Müller
10:38 AM bug #8385: Open issues in DB preferences
>io.ABCD.config is stored in DB with value NULL even if nothing has changed, if this is default value, the default sh... Andreas Müller
10:23 AM bug #8385: Open issues in DB preferences
~~ABCD: Restore defaults does not seem to set allowOverride~~ Andreas Müller
10:21 AM bug #8385: Open issues in DB preferences
Why does the nomenclatural code not provide a default? Is this wanted? Does ABCD not need a nomenclatural code? I rem... Andreas Müller
10:14 AM bug #8385: Open issues in DB preferences
> Biocase Provider for associated DNA should be moved to "Biocase Provider"
>>this is not the same because this pro...
Andreas Müller
10:00 AM bug #8385: Open issues in DB preferences
~~ABCD: Ignore Authorship ... -> Ignore authorship ...~~
fixed
Andreas Müller
09:52 AM bug #8385: Open issues in DB preferences
~~"Show rank in Distribution Editor" should be relabled -> "Show rank column"~~
this is fixed
Andreas Müller
09:05 AM bug #8385: Open issues in DB preferences
~~Name Details View: when selecting "restore defaults" allow override is not set to default~~
this is fixed
Andreas Müller
09:04 AM bug #8385 (Feedback): Open issues in DB preferences
~~Name Details View: if UseDefaults(Disable) is selected the fields are not disabled in the same way as when selectin... Andreas Müller
01:37 PM feature request #8489 (Resolved): Further issues for DB preferences
* ~~Common names vocabulary select list:~~
* ~~has no "allow override" (as not yet present in local preferenc...
Andreas Müller
01:21 PM feature request #8235 (Closed): Create separate menu for term tree editors for each term tree type
Created new ticket for adding characters to feature trees - #8488 Patrick Plitzner
01:20 PM bug #8488 (Closed): Characters can not be added to feature trees
Patrick Plitzner
08:46 AM feature request #8486 (New): Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu
Reviewed the setFlag part and set back to new for main task. Andreas Müller
08:43 AM feature request #8180 (Resolved): Add property term "Presence/Absence" to CDM default terms
Andreas Müller
08:42 AM feature request #8282 (Feedback): Implement placementDoubtful in TaxEditor
A minor issue: can we have the order of the flags in the same order as in the assistent. That makes it more intuitive... Andreas Müller
08:39 AM feature request #8447 (Closed): Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
Andreas Müller

08/23/2019

04:12 PM feature request #8475 (Feedback): Adapt applicable state detail view elements to FeatureState
Patrick Plitzner wrote:
> Andreas Müller wrote:
> > In this case we do not need an "empty" choice for the dropdowns...
Andreas Müller
02:59 PM feature request #8475 (Closed): Adapt applicable state detail view elements to FeatureState
Andreas Müller wrote:
> In this case we do not need an "empty" choice for the dropdowns. A FeatureState always needs...
Patrick Plitzner
10:07 AM feature request #8475: Adapt applicable state detail view elements to FeatureState
In general this ticket can be closed as it works as expected. Andreas Müller
10:06 AM feature request #8475: Adapt applicable state detail view elements to FeatureState
I wonder if we could reduce the availability of "InapplicableIf" and "OnlyApplicableIF" to term nodes of term type "... Andreas Müller
10:02 AM feature request #8475 (Feedback): Adapt applicable state detail view elements to FeatureState
In this case we do not need an "empty" choice for the dropdowns. A FeatureState always needs to have both, feature an... Andreas Müller
04:01 PM feature request #8486: Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu
Can you add the changes to the ticket or is this not yet pushed? Andreas Müller
04:00 PM feature request #8486 (Resolved): Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu
I preliminary give this to me to not forgot reviewing the next function. Disabling already is a good solution though ... Andreas Müller
09:54 AM feature request #8486 (Closed): Indicating doubtful state in navigator and add set-doubtful to Set-Flags menu
Indicate the doubtful state in the taxon navigator somehow. E.g. by symbol "?" that we normally use for doubtful info... Katja Luther
03:34 PM feature request #8282: Implement placementDoubtful in TaxEditor
the setDoubtful menu item is now implemented for the navigator, but it was not possible to set the menu to invisible ... Katja Luther
01:45 PM feature request #8282 (Closed): Implement placementDoubtful in TaxEditor
Andreas Müller
12:24 PM feature request #8282: Implement placementDoubtful in TaxEditor
ok Andreas Müller
11:37 AM feature request #8282: Implement placementDoubtful in TaxEditor
Andreas Müller wrote:
> Andreas Müller wrote:
> > Also we should add the doubtful flag to the "Set flags" method in...
Katja Luther
11:35 AM feature request #8282: Implement placementDoubtful in TaxEditor
Katja Luther wrote:
> the checkbox is moved below the publish checkbox.
works as expected. Ticket can be closed o...
Andreas Müller
11:34 AM feature request #8282 (Feedback): Implement placementDoubtful in TaxEditor
Andreas Müller wrote:
> Also we should add the doubtful flag to the "Set flags" method in the taxon navigator right ...
Andreas Müller
09:52 AM feature request #8282 (Resolved): Implement placementDoubtful in TaxEditor
the checkbox is moved below the publish checkbox. Katja Luther
09:51 AM feature request #8282: Implement placementDoubtful in TaxEditor
Andreas Müller wrote:
> The new field should be close to the taxon node information as it is from taxon node. Curren...
Katja Luther
03:16 PM bug #8482 (Closed): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
The more sophisticated way is to adapt the underlying method to return an EnumSet, not an ordinary Set. With EnumSet ... Andreas Müller
01:12 PM bug #8482 (Feedback): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
The problems obviously is fixed and the implementation looks good. Why did you comment the commit with "workaround"? ... Andreas Kohlbecker
03:11 PM feature request #8235 (Feedback): Create separate menu for term tree editors for each term tree type
Andreas Müller wrote:
> Generally it works and can be closed.
>
> Open issue (new ticket?) is that Characters can...
Andreas Müller
12:06 PM feature request #8235 (Closed): Create separate menu for term tree editors for each term tree type
Adjusted the context menu entries. Closing ticket. Patrick Plitzner
09:50 AM feature request #8235: Create separate menu for term tree editors for each term tree type
Generally it works and can be closed.
Open issue (new ticket?) is that Characters can not be added to Featuretrees...
Andreas Müller
09:49 AM feature request #8235 (Feedback): Create separate menu for term tree editors for each term tree type
Andreas Müller wrote:
> "New" and "Delete" is enough, we do not need "... Term Tree"
This seems not yet implement...
Andreas Müller
02:37 PM feature request #8447 (Resolved): Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
Andreas Müller wrote:
> Andreas Müller wrote:
> > Hybrids are not a set of independent taxa but more a filter on ea...
Katja Luther
11:38 AM feature request #8447 (Feedback): Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
Andreas Müller wrote:
> Hybrids are not a set of independent taxa but more a filter on each group. So we should mayb...
Andreas Müller
09:44 AM feature request #8447 (Resolved): Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
moving synonyms and hybrids is done. Katja Luther
09:42 AM feature request #8447: Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
Andreas Müller wrote:
> "Pro Parte Synonyme" as pro parte is latin and usually in small letters. However, I don't kn...
Katja Luther
01:06 PM task #8437 (Resolved): ITermTreeService provides a list method which supports filtering by TermTree.termType,
my implementation now is generic.
> Also it might be nice to have a little test that it works. Have you tested in ...
Andreas Kohlbecker
10:28 AM task #8437 (Feedback): ITermTreeService provides a list method which supports filtering by TermTree.termType,
Andreas Kohlbecker wrote:
> Agreed ... and implemented in the way you pointed out.
The current implementation is ...
Andreas Müller
10:21 AM task #8437: ITermTreeService provides a list method which supports filtering by TermTree.termType,
To me it looks like commit 1a5b2194 is not related to *this* ticket. Can you please check? Andreas Müller
12:07 PM task #8406 (Closed): specimens and occurrence code cleaning and harmonization
dead code removed.
I think we can close this issue now since all open tasks have been copied to other tickets.
Andreas Kohlbecker
09:04 AM task #8406: specimens and occurrence code cleaning and harmonization
Andreas Kohlbecker wrote:
> thank you for fixing this.
>
> there are two commented code parts in this method:
> ...
Katja Luther
10:34 AM feature request #7450 (Closed): Allow setPublish for subtree to include misapplied names and pro parte synonyms
Moved better reporting to new ticket #8487 and close *this* ticket. Andreas Müller
10:33 AM feature request #8487 (New): Report results of set publish
It should include numbers per each group (taxa, synonyms, MAN, ...)
Also those MAN, ppSyns, shared taxa, which wer...
Andreas Müller
10:09 AM bug #8481 (Rejected): NPE when opening feature tree
I agree. Had a look to the data and for some reason the term with the given id really doesn't exist anymore. Don't kn... Andreas Müller
09:55 AM feature request #8470: Handle username constraints in user and group editing
I will implement this for the next release. Katja Luther
09:31 AM feature request #3472 (Closed): Update name in source data when changing an accepted taxon into a synonym
the new ticket is #8478 and the labels are adapted. Katja Luther

08/21/2019

04:12 PM bug #8481 (Feedback): NPE when opening feature tree
Looking at the stacktrace this seem like corrupted data as the exception happen during TermRelationBase.getTerm().
...
Patrick Plitzner
04:10 PM feature request #8485 (Closed): Add column groups to character matrix
Does not have to be reviewed because still experimental Patrick Plitzner
04:09 PM feature request #8485 (Resolved): Add column groups to character matrix
Applied in changeset commit:taxeditor|c264cd9262db5bb03b83d94858c559cc985b8bc2. Patrick Plitzner
03:09 PM feature request #8485 (Closed): Add column groups to character matrix
Groups should reflect the hierarchy of the character tree. Patrick Plitzner
04:10 PM feature request #8235 (Resolved): Create separate menu for term tree editors for each term tree type
Patrick Plitzner
12:29 PM bug #8484 (New): Exception is swallowed in taxon navigator
In a corrupt database with taxon nodes without classification I got the following exception in the log file.
However...
Andreas Müller
11:49 AM task #8483 (New): Return EnumSets in EnumeratedTermVoc.getGeneralizationOf and similar methods
This may prevent from errors like in #8482 Andreas Müller
11:46 AM bug #8482 (Resolved): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
Applied in changeset commit:cdmlib|244c62c6bee1863dfe79d71e0ecae7bdeb4d06b5. Andreas Müller
11:18 AM bug #8482 (Closed): java.lang.IllegalArgumentException: Collection is empty in DescriptionType.includesType(DescriptionType.java:151)
Can be reproduced by:
http://int.e-taxonomy.eu/cdmserver/integration_palmae/portal/taxon/ce870eca-0422-4a3c-b849-0...
Andreas Kohlbecker
11:09 AM bug #8385 (Resolved): Open issues in DB preferences
please review Katja Luther
09:17 AM feature request #8339: Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
Hallo Andreas,

danke für deine Einschätzung. Da du mich in meiner Auffassung bestätigst, werde ich das "is accept...
Andreas Kohlbecker
09:17 AM feature request #8339: Completely remove the potentially redundant 'acceptedFor' parameter from synonym page
Hallo Andreas,

das war mir völlig unbekannt, dass wir sowas überhaupt haben/hatten. Daher hatte ich das ganze...
Andreas Kohlbecker

08/20/2019

11:51 AM bug #8481: NPE when opening feature tree
I get the same exception when trying to add an InapplicableIf to "Test Feature Tree" -> Citation -> Leaf color -> Ana... Andreas Müller
11:47 AM bug #8481 (Rejected): NPE when opening feature tree
When opening feature tree "Testdasdfa" on rem_conf_am I got
~~~
login : admin
editor version : 5.9.0.20190819225...
Andreas Müller
11:45 AM feature request #8235: Create separate menu for term tree editors for each term tree type
"New" and "Delete" is enough, we do not need "... Term Tree" Andreas Müller
11:43 AM feature request #8235 (Feedback): Create separate menu for term tree editors for each term tree type
Feature Tree Editors still have "New Structure Tree" and "New Property Tree" submenu.
Each Term type should have its...
Andreas Müller

08/19/2019

04:58 PM bug #8465 (Closed): Term nodes order in term trees is ignored in term tree editor
I would rather close this tickets because it was created only to handle the bug. All other issues will be adressed in... Patrick Plitzner
04:55 PM feature request #8235 (Resolved): Create separate menu for term tree editors for each term tree type
Applied in changeset commit:taxeditor|362b3a0c58e4b2b8620477ce38a80e2a3553bd36. Patrick Plitzner
04:15 PM feature request #8480 (Closed): Use DescriptionTypes for matrix descriptions
Patrick Plitzner
04:14 PM feature request #8480 (Resolved): Use DescriptionTypes for matrix descriptions
Applied in changeset commit:cdmlib|0b616910ec8af247ee13843c5058b22ac24efff0. Patrick Plitzner
04:11 PM feature request #8480 (Closed): Use DescriptionTypes for matrix descriptions
Patrick Plitzner
04:15 PM feature request #7957 (Closed): Add types for taxon description (as EnumSet)
Adapted descriptive data set service to use DescriptionType. Tried aggregation and tested display in matrix editor. A... Patrick Plitzner
04:11 PM task #8479 (In Progress): [PESI][FE] Cdm-2-Cdm import for FauEu
Open issues:
* check if uuids are always kept for taxon nodes (sometimes addChild is used which probably creats co...
Andreas Müller
03:21 PM feature request #8475: Adapt applicable state detail view elements to FeatureState
Added applicable detail elements to TermNode details view. Available features are filtered to only contain parent fea... Patrick Plitzner
03:19 PM feature request #8475 (Resolved): Adapt applicable state detail view elements to FeatureState
Patrick Plitzner
02:37 PM bug #8417: LazyInitializationException in TermDTO for media
not important for this release -> move to 5.10 Patrick Plitzner
02:33 PM feature request #8478 (New): Follow up ticket for update empty name in source handling in TaxEditor
We need a final implementation with a new wizard including the question if the name in sources should be taken from t... Katja Luther
01:27 PM feature request #8304: Name page redirects to according taxon depending on query parameter
Hi Andreas, I think we have discussed this issue sometime at phone. Do you remember the results? Are they somewhere i... Andreas Müller
10:16 AM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
Ok, in generall this probably makes sense. Maybe I just wasn't used to it yet.
However, if this is the expected beha...
Andreas Müller
09:40 AM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
Andreas Müller wrote:
> Currently both methods do end in an unexpected state. After running the operation the old ta...
Katja Luther

08/16/2019

10:36 PM bug #8385: Open issues in DB preferences
~~Restore button does not yet work for Distribution Editor status and area selection preferences~~
this is fixed
Andreas Müller
10:33 PM bug #8385: Open issues in DB preferences
~~Distribution editor status selection: changes are not visible in Preferences view after reopening the preferences v... Andreas Müller
10:27 PM bug #8385: Open issues in DB preferences
~~name.nomenclaturalStatus can not be removed by Reset Default~~
this is fixed.
Andreas Müller
10:25 PM bug #8385: Open issues in DB preferences
~~some preferences are not deleted for NameDetailsView => deselect all and reopen preferences => 3 prefs stay selecte... Andreas Müller
10:21 PM bug #8385: Open issues in DB preferences
~~ABCD import is now implemented on both sides, but "allow override" does not yet exist for "ABCD import provider"~~
...
Andreas Müller
10:19 PM bug #8385: Open issues in DB preferences
Andreas Müller wrote:
> When opening Peferences - Distribution Editor for the first time the drop downs for some fie...
Andreas Müller
10:12 PM bug #8385: Open issues in DB preferences
>Name details view can not be set to "default" (always chooses enabled after reopening)
~~Now it always sets it ba...
Andreas Müller
10:09 PM bug #8385 (Feedback): Open issues in DB preferences
~~When opening Peferences - Distribution Editor for the first time the drop downs for some fields were completely emp... Andreas Müller
09:55 PM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
Andreas Müller wrote:
> Please open a new ticket for the final implementation with a new wizard including the questi...
Andreas Müller
09:51 PM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
The labels of the 2 menus should be equal except for the addition about the Name in Source. Is there a reason why you... Andreas Müller
09:44 PM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
Please open a new ticket for the final implementation with a new wizard including the question if the name in sources... Andreas Müller
09:38 PM feature request #3472: Update name in source data when changing an accepted taxon into a synonym
The method with setting the name should be moved down in menu Andreas Müller
09:37 PM feature request #3472 (Feedback): Update name in source data when changing an accepted taxon into a synonym
Currently both methods do end in an unexpected state. After running the operation the old taxon is dirty (and unsaved... Andreas Müller
09:40 AM feature request #3472 (Resolved): Update name in source data when changing an accepted taxon into a synonym
this is implemented now.
The setting of the name in source is configurable, but in editor a new wizard would be ne...
Katja Luther
09:24 PM bug #8422 (Closed): Make PolytomousKeyGenerator work (correctly)
I close this ticket as there is a follow up ticket. Andreas Müller
09:22 PM feature request #8299 (Feedback): add typification column to scientific name and homotypical group in cdm light
Testing is time consuming for me. Please ask Walter if it is as expected. Andreas Müller
09:20 PM feature request #8334 (Closed): Move sources for type designations to details view
Andreas Müller
09:17 PM bug #8444 (Closed): Show warning if misapplied names / pro parte synonyms are used more then once
Hmm, now the warning is also shown if the misapplication is referenced e.g. by an identification key which is not nec... Andreas Müller
09:05 PM feature request #8447: Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
"Pro Parte Synonyme" as pro parte is latin and usually in small letters. However, I don't know if it is maybe better ... Andreas Müller
09:01 PM feature request #8447: Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
I think we may move synonyms below taxa as they are the second biggest group. Misapplications and pro parte synonyms ... Andreas Müller
08:59 PM feature request #8447: Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
Hybrids are not a set of independent taxa but more a filter on each group. So we should maybe move it down (directly ... Andreas Müller
08:57 PM feature request #8447 (Feedback): Adapt setPublishForSubtree to new parameters for pro parte, misapplications and hybrids
If only Misapplications and/or pro parte synonyms are selected the finish button is not enabled but should (at least ... Andreas Müller
08:43 PM feature request #8282: Implement placementDoubtful in TaxEditor
Also we should add the doubtful flag to the "Set flags" method in the taxon navigator right click menu. Andreas Müller
12:24 PM feature request #8282 (Feedback): Implement placementDoubtful in TaxEditor
The new field should be close to the taxon node information as it is from taxon node. Currently it is in the middle o... Andreas Müller
03:22 PM feature request #8477 (Closed): Implement support for TermCollection.allowDuplicates in TaxEditor
Since #6794 it is possible to distinguish term collections which include duplicates (e.g. structure trees which inclu... Andreas Müller
03:09 PM feature request #8476 (Closed): Implement support for TermCollection.isFlat in TaxEditor
Often term collections are meant to be a flat list or set without hierarchical dependencies. For these collections th... Andreas Müller
03:08 PM feature request #8475 (Closed): Adapt applicable state detail view elements to FeatureState
Patrick Plitzner
02:58 PM bug #8465: Term nodes order in term trees is ignored in term tree editor
In general the ordering seems to work now. Andreas Müller
02:56 PM bug #8465 (Feedback): Term nodes order in term trees is ignored in term tree editor
As Term nodes should be not always ordered anymore (TermCollection.orderRelevant flag) we could implement this alread... Andreas Müller
02:45 PM feature request #8474 (Closed): Make TermCollection.orderRelevant usable for TermTrees

Dazu müsste es:
1. ~~editierbar sein~~
2. ~~Der TermTree müsste unterschiedlich sortiert angezeigt werden, je n...
Andreas Müller
01:22 PM bug #8473 (New): Migrate from GrantedAuthoritiesImpl to CdmAuthority and Role
First of all the handling of authorities needs to be migrated and tested to AuthorityBase (by AK). Once this is done ... Andreas Müller
01:14 PM bug #4884 (Closed): Update Reference_AUD.refType to allow NULL
I guess this works. Andreas Müller
12:41 PM feature request #8472 (Closed): Transmission engine for distribution aggregation needs to be adapted to new DescriptionBase.types
Currently it uses marker type "Computed" to mark the descriptions.
... also needs update script for existing descr...
Andreas Müller
12:38 PM feature request #7957: Add types for taxon description (as EnumSet)
This has been implemented now as an EnumSet for better performance.
Please review.
Andreas Müller
10:38 AM feature request #7957 (Resolved): Add types for taxon description (as EnumSet)
Applied in changeset commit:cdmlib|1962891319edeb12380aa69994467f674a96ce96. Andreas Müller
12:35 PM feature request #8471 (Closed): Computed descriptions should be disabled in TaxEditor
Taxon descriptions being computed (DescriptionBase.types contains COMPUTED or AGGREGATED) should be disabled for edit... Andreas Müller
12:16 PM feature request #8398: Add nomenclatural code edition to ruleConsidered
As this was your (phycobank) requirement I give it to you for review. Andreas Müller
12:15 PM feature request #8410: Add nomenclatural code edition to ruleConsidered in TaxEditor
Maybe we can do this in 5.10 latest so it is close to the model change.
I think we should add it to configuration ...
Andreas Müller
12:12 PM feature request #8404 (Closed): Add update step list within updaters
Seems to work as expected and is very nice. Andreas Müller
12:11 PM feature request #8442 (Closed): Add fields to handle external terms to DefinedTermBase or TermBase
So I close this ticket. Andreas Müller
12:10 PM feature request #8454: Only allow certain patterns as username and groupname
This should be fixed. Who ever wants please review. I tested creating a new user and a group in TaxEditor. For both w... Andreas Müller
12:04 PM feature request #8470 (Closed): Handle username constraints in user and group editing
Since #8454 a regex exist for usernames and groupnames.
For new usernames and groups the TaxEditor should validat...
Andreas Müller
11:47 AM feature request #8441: Add FeatureState class
Please review.
Maybe there are issues with orphan removal handling.
Andreas Müller
11:45 AM feature request #8441 (Resolved): Add FeatureState class
This is implemented, old implementation still exists in parallel. Should be removed with next update script.
SDD I...
Andreas Müller
11:41 AM feature request #8469 (In Progress): Open PolytomousKeyGenerator issues
* ~~adapt dependency handling to new FeatureState handling~~
* in general improve the handling of dependencies, mayb...
Andreas Müller
11:35 AM task #8468 (Closed): Remove old InapplicableIf tables
Andreas Müller

08/15/2019

04:09 PM feature request #7597 (Closed): Aggregate and persist descriptions on taxon level
Closing this feature. No review needed as this is still experimental. Follow up ticket #8467 Patrick Plitzner
04:08 PM feature request #8467 (Closed): Save a "snapshot" of the SpecimenDescriptions used for aggregation
When aggregating SpecimenDescriptions to a TaxonDescriptions the SDs used should be cloned and associated as sources ... Patrick Plitzner
03:57 PM feature request #8464: Make AuthorityBases unique
This seems to be more difficult then I thought.
In general hibernate allows the ,uniqueConstraints=@UniqueConstra...
Andreas Müller
02:59 PM feature request #8441 (In Progress): Add FeatureState class
Andreas Müller
02:21 PM bug #8465 (Resolved): Term nodes order in term trees is ignored in term tree editor
Applied in changeset commit:taxeditor|74a9e9d7da34b3e2d6a895a7b091364125c6f648. Patrick Plitzner
12:19 PM bug #8465: Term nodes order in term trees is ignored in term tree editor
So, if the flag is switched on, the tree should be ordered by tree order, otherwise alphabetically (or by any other c... Andreas Müller
12:06 PM bug #8465: Term nodes order in term trees is ignored in term tree editor
Note: The new TermCollection base class has a flag now called "orderRelevant". This should in future decide if the or... Andreas Müller
10:32 AM bug #8465 (Closed): Term nodes order in term trees is ignored in term tree editor
ich hatte gerade einen neuen Feature Term "Chemophenetics" für den Cichorieae Feature Tree geschaffen , den wollte ic... Patrick Plitzner
01:52 PM task #8466 (Closed): Delete FeatureTree tables
FeatureTree has been moved to TermCollection. The old tables have not yet been deleted to have the chance to find pos... Andreas Müller
12:39 PM feature request #8442: Add fields to handle external terms to DefinedTermBase or TermBase
Andreas Müller wrote:
> This should be fixed. Also added new field "importMethod" and extracted all data to an exter...
Patrick Plitzner
09:15 AM feature request #8334 (Resolved): Move sources for type designations to details view
Patrick Plitzner

08/14/2019

11:45 AM feature request #7957 (In Progress): Add types for taxon description (as EnumSet)
Patrick Plitzner
10:59 AM task #7099: Make CdmAuthority a persistable class
forgot to implement uniqueness. Moved to #8464 Andreas Müller
10:41 AM task #7099 (Resolved): Make CdmAuthority a persistable class
This is implemented for now. Old GrantedAuthorities still exist and are in use but we could easily switch to new ones... Andreas Müller
10:56 AM feature request #8464 (New): Make AuthorityBases unique
The old GrantedAuthorityImpl.authority was unique and NotNull. This was forgotten to implement when implementing CdmA... Andreas Müller
10:51 AM feature request #8442 (Resolved): Add fields to handle external terms to DefinedTermBase or TermBase
This should be fixed. Also added new field "importMethod" and extracted all data to an external embeddable class "Ext... Andreas Müller
10:48 AM feature request #3972 (Closed): Strictly validate username to not null and not empty
This should be fixed by fixing #8454 Andreas Müller
10:47 AM feature request #8454 (Resolved): Only allow certain patterns as username and groupname
This should be solved now and seems to work. Still needs testing in TaxEditor and maybe other surroundings. Andreas Müller
10:45 AM bug #8429 (Resolved): Rename DeterminationEvent_Reference.setOfReferences_id
This is fixed now by renaming the parameter in model from setOfReferences to references.
Making it a set of sourc...
Andreas Müller
10:45 AM feature request #8463 (New): Make DeterminationEvent.references sources
Currently the link to Reference but they should link to Source. DeterminationEvent should probably become a Sourceabl... Andreas Müller
 

Also available in: Atom