Project

General

Profile

Activity

From 02/26/2019 to 03/27/2019

03/27/2019

05:59 PM task #7798: [AM, ERS]: Import (freetext) nameInSource correctly
Eckhard noch fragen, was mit den Namen geschehen soll, bei denen LinkedName und FreeTextName nicht übereinstimmen.
D...
Andreas Müller
05:58 PM task #7798: [AM, ERS]: Import (freetext) nameInSource correctly
ERS decided to use synonymie names whereever possible. Equalness of existence of authors is not so important.
With t...
Andreas Müller
05:57 PM bug #8050: Create blocking registrations for un-registered names which are to be used in nomenclatural acts
Solution 1 should also preclude name duplicates. Wolf-Henning Kusber
05:36 PM bug #8050 (In Progress): Create blocking registrations for un-registered names which are to be used in nomenclatural acts
We agreed on solution 1. from above: "*Require the user to add a reference to the name before the popup editor in whi... Andreas Kohlbecker
01:12 PM bug #8050 (Feedback): Create blocking registrations for un-registered names which are to be used in nomenclatural acts
There will be situations in which the existing name will not yet have a nomenclatural reference. Creating a Registrat... Andreas Kohlbecker
05:36 PM feature request #7894 (Resolved): [CHECK] Import sourceNumber as Identifier for references
Andreas Müller
04:32 PM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks
done!
For the rank "unknown rank" only the uninomial field is shown
For the remaining tasks formulated in the d...
Andreas Kohlbecker
04:16 PM bug #7963 (Resolved): TaxonNamePopEditor: name part field visibility not correct for all ranks
Applied in changeset commit:cdm-vaadin|a0643e2c0aa12a7c83f208bf2709dc06a163befb. Andreas Kohlbecker
04:27 PM Revision 712e49c6 (cdm-vaadin): ignoring workbench.xmi
Andreas Kohlbecker
04:24 PM Revision dcf5e676 (cdm-vaadin): fix #7963 trating UNKNOWN Rank class as super-specific
Andreas Kohlbecker
04:18 PM Revision b2261934 (cdm-vaadin): ignoring workbench.xmi
Andreas Kohlbecker
04:16 PM Revision a0643e2c (cdm-vaadin): fix #7963 trating UNKNOWN Rank class as super-specific
Andreas Kohlbecker
03:54 PM bug #8197 (Closed): Deleting Media from Image Gallery View does not make view dirty
works fine Patrick Plitzner
02:45 PM bug #8197 (Resolved): Deleting Media from Image Gallery View does not make view dirty
this should be fixed now. The operation is executed while saving now. Katja Luther
03:47 PM task #7935 (Feedback): Discuss new solution to establish the communication between submitter and curator
Hi Henning,
is there anything left to discuss regarding this issue?
Andreas
Andreas Kohlbecker
03:46 PM Revision 032b62c4 (taxeditor): ref #7428: update all name editors involved when executing subtree operations
Katja Luther
03:45 PM Revision 9e1446d2 (taxeditor): ref #7428: update all name editors involved when executing subtree operations
Katja Luther
03:44 PM feature request #7968 (Closed): ReferenceEditor: optional validation for completenes of Partial values in datePublished
fully implemented but untestable since the system apparently does not allow to use incomplete Partials in the vaadin UI. Andreas Kohlbecker
03:42 PM feature request #7968 (Resolved): ReferenceEditor: optional validation for completenes of Partial values in datePublished
Applied in changeset commit:cdm-vaadin|f8fda7a9f00c1e87430c03d06bbcfcff44aa7ff4. Andreas Kohlbecker
02:56 PM feature request #7968 (In Progress): ReferenceEditor: optional validation for completenes of Partial values in datePublished
Andreas Kohlbecker
03:43 PM Revision 10d072e7 (cdm-vaadin): fix #7968 validators for completeness of Partial and TimePeriod
Andreas Kohlbecker
03:42 PM Revision f8fda7a9 (cdm-vaadin): fix #7968 validators for completeness of Partial and TimePeriod
Andreas Kohlbecker
03:40 PM Revision 981b5cfb (taxeditor): minor
Katja Luther
03:00 PM bug #7833 (Rejected): submitters can access see any registration in any RegistrationWorkingSet
Andreas Kohlbecker
02:40 PM Revision 5e966d50 (taxeditor): ref #8197: fix delete of media in media view
Katja Luther
02:27 PM bug #8206 (New): Editing references with missing update rights should not be possible
Actually it is possible to edit references without the UPDATE right for references. While saving the user gets an exc... Katja Luther
02:17 PM Revision a6edfc5a (cdm-vaadin): ref #8050 fixing bug in reloadRegistrtions() and removing remain from previous conflict
Andreas Kohlbecker
01:47 PM Revision ee57c0d9 (cdm-vaadin): ref #8050 fixing bug in reloadRegistrtions() and removing remain from previous conflict
Andreas Kohlbecker
11:43 AM Revision f1e0b490 (cdmlib): comments and doc for IRegistrationService
Andreas Kohlbecker
11:39 AM Revision 7ebcfd4b (cdm-vaadin): ref #8184 reverting typedesignation status filter back to ListSelect
Andreas Kohlbecker
11:36 AM Revision 8af7fcc2 (cdm-vaadin): ref #8050 creating blocking registrations for exising names which are used in the context of another registration
Andreas Kohlbecker
11:35 AM Revision eee96dac (cdm-vaadin): ref #8050 moving transactional code from RegistrationWorkingsetPresenter to new service class
Andreas Kohlbecker
11:30 AM Revision 4e29c10f (cdm-vaadin): ref #8050 creating blocking registrations for exising names which are used in the context of another registration
Andreas Kohlbecker
09:24 AM bug #5279: Deleting taxon node is slow in some cases
this is the same problem as in #5278, when deleting a node with a lot of siblings the creation of the new sortindex t... Katja Luther

03/26/2019

05:14 PM bug #8050: Create blocking registrations for un-registered names which are to be used in nomenclatural acts
Wenn man versehentlich einen falschen namen z.B. als Basionym auswählt, würde dann für diesen Namen eine Blocking-Reg... Andreas Kohlbecker
05:05 PM Revision 68afc0ec (cdm-vaadin): ref #8050 moving transactional code from RegistrationWorkingsetPresenter to new service class
Andreas Kohlbecker
03:57 PM bug #8149 (Closed): ReferenceEditor: filter inReferences ONLY by applicable reference type suppess Generic and NULL
Henning, says this is tested and works as expected. Andreas Kohlbecker
03:55 PM bug #8194 (Closed): LazyInitializationException (LIE) on deleting the nomenclatural referenz (Section) of a Name
Andreas Kohlbecker
03:54 PM bug #8194: LazyInitializationException (LIE) on deleting the nomenclatural referenz (Section) of a Name
We agreed on :
> 1. hide the delete button in this situation and implement #8204
Warning is sufficient, we don'...
Andreas Kohlbecker
03:53 PM feature request #8204: RegistrationWorkingsetEditor shows list of unused sections and allows for delting them
nice to have Andreas Kohlbecker
03:48 PM bug #4545 (Closed): Implement TeamOrPersonBaseSelectionDialog
The selection dialog works like the other selection dialogs. Institution, as the only sub class of AgentBase that sho... Patrick Plitzner
03:44 PM bug #8191 (Closed): ReferencePopupEditor: When coming from NameEdior editing of the inreference should not be blocked
Andreas Kohlbecker
03:38 PM bug #8197 (Feedback): Deleting Media from Image Gallery View does not make view dirty
Now the name editor is set to dirty but if it is closed without saving the media is removed anyways. So either the me... Patrick Plitzner
08:47 AM bug #8197: Deleting Media from Image Gallery View does not make view dirty
this should be fixed, please review. Katja Luther
03:30 PM bug #8192 (Closed): The curator must be able to unlock a published registration for edition
Andreas Kohlbecker
09:19 AM bug #8115: NPE when moving factual data
this is because the description only contains a not persisted description element and this is not available when the ... Katja Luther

03/25/2019

06:58 PM bug #8192: The curator must be able to unlock a published registration for edition
Checked in Test-System with two names of Nupela, registered 2018-11-02.
TypeSpecimen: unlock and add a type: works...
Wolf-Henning Kusber
02:50 PM bug #8192 (Resolved): The curator must be able to unlock a published registration for edition
done, please review Andreas Kohlbecker
05:46 PM bug #8191: ReferencePopupEditor: When coming from NameEdior editing of the inreference should not be blocked
I was able to include new journal names in Basionym references. I included sections in the name editor and was able t... Wolf-Henning Kusber
02:51 PM bug #8191 (Resolved): ReferencePopupEditor: When coming from NameEdior editing of the inreference should not be blocked
please review Andreas Kohlbecker
05:28 PM bug #8050 (In Progress): Create blocking registrations for un-registered names which are to be used in nomenclatural acts
Andreas Kohlbecker
04:45 PM bug #7962: PopupEditors: *DTO in context 'breadcrumbs' to be transformed into more humane labels
Please review Andreas Kohlbecker
04:42 PM bug #7962 (Resolved): PopupEditors: *DTO in context 'breadcrumbs' to be transformed into more humane labels
Applied in changeset commit:cdm-vaadin|8745f04714df865f1780025b43b24b9eaa5a198a. Andreas Kohlbecker
04:43 PM Revision 89659534 (cdm-vaadin): fix #7962 "New" or "Edit" information and humane lables for DTO editors in context breadcrumbs
Andreas Kohlbecker
04:42 PM Revision 8745f047 (cdm-vaadin): fix #7962 "New" or "Edit" information and humane lables for DTO editors in context breadcrumbs
Andreas Kohlbecker
02:56 PM Revision 34d43087 (cdm-vaadin): ref #8191 intoducing the long awaited EditorFormConfigurator for fine tuning of the inReference button enabled states
Andreas Kohlbecker
02:56 PM Revision cd93f49b (cdm-vaadin): ref #8192 unlock button to allow curator and admin to edit published Registrations
Andreas Kohlbecker
02:48 PM Revision f151a6f9 (cdmlib): ref #8188 adding empty hibernate.properties for main to satisfy PropertiesFactoryBean in production mode
Andreas Kohlbecker
02:17 PM feature request #8033 (Duplicate): Add/Enable absent/present state for every character
duplicates #8178 Patrick Plitzner
02:13 PM Revision 61c21b1e (cdm-vaadin): ref #8188 adding empty hibernate.properties for main to satisfy PropertiesFactoryBean in production mode
Andreas Kohlbecker
01:15 PM Revision a4b97169 (cdm-server): ref #8189 cdm-server stores parameters as initParameter instead as Attribute, this allows to access these via Spring Environment
Andreas Kohlbecker
01:13 PM Revision 6dd0caa2 (cdmlib): ref #8189 better reporting of error conditions in AbstractWebApplicationConfigurer
Andreas Kohlbecker
10:12 AM feature request #8153: Adapt cdmlib to FeatureNode/FeatureTree model changes
By introducing the generics this is probably done. There is still some code which does not use/specify generics but t... Patrick Plitzner

03/23/2019

09:37 AM Revision ae855a23 (cdmlib-apps): Import E+M details notes as name notes
Andreas Müller
12:11 AM Revision febf715a (cdmlib-apps): adapt app-import to new AccountStore package
Andreas Müller

03/22/2019

11:53 PM Revision 2f2c4477 (cdmlib): minor
Andreas Müller
11:53 PM Revision 3bde5f80 (cdmlib): fix bug in term type check
Andreas Müller
11:28 PM Revision 78159090 (cdm-vaadin): ref #8191 intoducing the long awaited EditorFormConfigurator for fine tuning of the inReference button enabled states
Andreas Kohlbecker
11:06 PM Revision 6850fcf9 (cdmlib): fix term type check in FeatureNode
Andreas Müller
10:29 PM Revision fad2732b (cdmlib): Revert "Remove useless check"
This reverts commit 1a4fdfe5c12c655451e25c567f656a8df0f1b9a5. Andreas Müller
09:32 PM Revision 16580b3c (cdm-vaadin): ref #8192 unlock button to allow curator and admin to edit published Registrations
Andreas Kohlbecker
09:31 PM Revision 97c6b732 (cdm-vaadin): ref #8184 reverting typedesignation status filter back to ListSelect
Andreas Kohlbecker
07:58 PM bug #8075 (Resolved): multiple cascade all-delete-orphan exceptions related to DefinedTermBase.representations
Andreas Kohlbecker
07:49 PM bug #8075: multiple cascade all-delete-orphan exceptions related to DefinedTermBase.representations
potentially fixed through the changes made for #8160, #7106 Andreas Kohlbecker
07:57 PM bug #8158 (Resolved): cascade="all-delete-orphan" problem when ....
potentially fixed through the changes made for #8160, #7106 Andreas Kohlbecker
07:56 PM bug #7881 (Resolved): reference selection combobox broken after error in ...
potentially fixed through the changes made for #8160, #7106 Andreas Kohlbecker
07:51 PM bug #8065 (Feedback): HibernateException: corrupt session problem breaks SpecimenTypeDesignationworkingsetEditor type designation table
potentially fixed through the changes made for #8160, #7106 Andreas Kohlbecker
07:36 PM Revision fd6328a5 (cdmlib): minor changes in TermLoader
Andreas Müller
07:21 PM Revision 16ee34cb (cdm-vaadin): fix #8184 using NativeSelect instead of ListSelect to avoid circumvent a bug in the ListSelect which affects the Chrome browser
Andreas Kohlbecker
07:21 PM Revision 68d2ffb7 (cdm-vaadin): fix #8149 inclusion of NULL and Genric ref types optional and fixing bugy refresh
Andreas Kohlbecker
07:20 PM bug #8149: ReferenceEditor: filter inReferences ONLY by applicable reference type suppess Generic and NULL
please review Andreas Kohlbecker
07:18 PM bug #8149 (Resolved): ReferenceEditor: filter inReferences ONLY by applicable reference type suppess Generic and NULL
Applied in changeset commit:cdm-vaadin|27820075a6585b46648a6f1dcd4241a6b45596d8. Andreas Kohlbecker
07:19 PM bug #8184: SpecimenTypedesignationEditor: add new specimen broken Chrome browser
please review with Heba if this still occurs Andreas Kohlbecker
07:18 PM bug #8184 (Resolved): SpecimenTypedesignationEditor: add new specimen broken Chrome browser
Applied in changeset commit:cdm-vaadin|86f09e7b2e34f272b2f4769f5f7fb3729fea7ef7. Andreas Kohlbecker
07:18 PM bug #8184: SpecimenTypedesignationEditor: add new specimen broken Chrome browser
this seems to be a bug in the ListSelect which affects the Chrome browser Andreas Kohlbecker
07:16 PM Revision 86f09e7b (cdm-vaadin): fix #8184 using NativeSelect instead of ListSelect to avoid circumvent a bug in the ListSelect which affects the Chrome browser
Andreas Kohlbecker
06:42 PM Revision 27820075 (cdm-vaadin): fix #8149 inclusion of NULL and Genric ref types optional and fixing bugy refresh
Andreas Kohlbecker
06:28 PM feature request #8180 (In Progress): Add property term "Presence/Absence" to CDM default terms
Andreas Müller
06:28 PM feature request #8153 (Feedback): Adapt cdmlib to FeatureNode/FeatureTree model changes
is this still an open issue? If yes, can you give more inside? Andreas Müller
06:13 PM bug #8183 (In Progress): Make Feature IndividualAssociation a generalization of Specimen and Observation
Andreas Müller
06:07 PM Revision 1064bb88 (cdmlib-apps): ref #7669 latest changes to Greece Willing images import, incl. no barcode import
Andreas Müller
04:35 PM bug #8205 (New): SpecimenTypeDesignationsEditor: First selection of mediaReference gets lost
Permanent bug:
Image Reference is selected for the first time -> selected but not gets lost when clicking in another...
Wolf-Henning Kusber
03:51 PM bug #8194 (Feedback): LazyInitializationException (LIE) on deleting the nomenclatural referenz (Section) of a Name
Even if the LazyInitializationException is avoided deletion of the section is impossible since it is still in use as ... Andreas Kohlbecker
03:38 PM Revision 9817d054 (cdm-vaadin): updating poms for 5.5.4 branch with snapshot versions
jenkins
03:32 PM Revision d8ec06ee (cdm-vaadin): removing useless session flush in CdmStore.delete function
Andreas Kohlbecker
03:32 PM bug #8115: NPE when moving factual data
I just tested it with cdmlib and taxeditor completely up-to-date. I tested on a copy of flora of greece this time to ... Patrick Plitzner
02:06 PM bug #8115: NPE when moving factual data
Did you test with the actual cdmlib version?
cdmlib was not build until this morning.
Katja Luther
01:46 PM bug #8115 (Feedback): NPE when moving factual data
Now saving in step 4 works but the description with the description from which the element was moved away from disapp... Patrick Plitzner
03:31 PM feature request #8204 (New): RegistrationWorkingsetEditor shows list of unused sections and allows for delting them
the RegistrationUI does not allow deleting unused sections. The RegistrationWorkingsetEditor could show the list of u... Andreas Kohlbecker
03:24 PM bug #8203 (New): Adapt specimen page title to record basis
The current specimen page hast "Specimen" written in the title despite the actual record basis
Example: http://por...
Patrick Plitzner
03:15 PM Revision eacea571 (cdmlib): ref #8189 DataSourceConfigurer @Autowiring ConfigFileUtil to init this bean before
Andreas Kohlbecker
02:50 PM bug #8202 (Worksforme): Multiple representations exception when reusing image in image gallery
In Flora of Greece I tried to move an image from taxon Anchusa aegyptiaca to Anchusella variegata.
I did this by fir...
Andreas Müller
02:39 PM task #8201 (In Progress): test all delete functionality in the RegistrationUI
Andreas Kohlbecker
02:35 PM bug #8200 (Closed): Changing title(cache) for factual data set not possible
When trying to change the title of a factual data set in details view the old title is recreated during save.
Corr...
Andreas Müller
02:32 PM bug #8197 (Resolved): Deleting Media from Image Gallery View does not make view dirty
Applied in changeset commit:taxeditor|02bb31eada6b7edfb3c3d155bb13ad967428aa56. Katja Luther
02:22 PM bug #8197 (Closed): Deleting Media from Image Gallery View does not make view dirty
... therefore one may think that the media is deleted but it is not after reload. This is dangerous therefore high pr... Andreas Müller
02:32 PM Revision 02bb31ea (taxeditor): fix #8197: fix make name editor dirty if media is deleted
Katja Luther
02:26 PM feature request #8199 (New): ReferencePage: show the relation of orthographic corrections to the corrected name
in case of an orthographic correction both names which are related this way belong to the same publication.
In the...
Andreas Kohlbecker
02:24 PM bug #8198 (Closed): Deleting an image gallery from image gallery view shows wrong configuration dialog
It shows the same dialog like when deleting media, but the image gallery is something else. Image galleries should no... Andreas Müller
02:16 PM feature request #8196 (Closed): display ortographic corrections in name relations as 'corrected name: <nameCache>'
ortographic corrections are to be displayed as last entries in the name relations:
* corrected name: <nameCache> [...
Andreas Kohlbecker
01:54 PM Revision 3480974e (cdm-vaadin): ref #7356 ignoring selenide tests for now since they conflict with other tests
Andreas Kohlbecker
01:53 PM Revision a630e869 (cdm-vaadin): ref #7356 documentation on setting up the project for selenide tests
Andreas Kohlbecker
01:33 PM feature request #8195 (New): TaxonNamePopupEditor: offer Reference and RuleConsidered fields for replaced synonyms
in contrast to earlier considerations for *Replaced Synonyms* it is also important to enter data into the Reference a... Andreas Kohlbecker
12:58 PM Revision 460fe6fd (cdmlib): ref #8189 DataSourceConfigurer using ConfigFileUtil correctly
Andreas Kohlbecker
11:35 AM Revision ab611430 (taxeditor): ref #8189 organizing imports for ConfigFileUtil
Andreas Kohlbecker
11:26 AM Revision 55c390a0 (taxeditor): ref #8189 adapting taxeditor to changes in CdmUtils and ConfigFileUtil
Andreas Kohlbecker
09:08 AM bug #8190 (Resolved): Default FeatureTree throws exception
I extended the type check to also allow subtypes in the term tree Patrick Plitzner
08:53 AM Revision b7d3a480 (cdmlib): ref #8190 Fix potential NPE
Patrick Plitzner

03/21/2019

07:03 PM bug #8192: The curator must be able to unlock a published registration for edition
use the lock and unlock icons from fontawesome:
https://fontawesome.com/icons/lock-open?style=solid
https://fon...
Andreas Kohlbecker
06:32 PM bug #8192 (Closed): The curator must be able to unlock a published registration for edition
The curator sometimes needs to modify the data for a registration after it has been published.
Currently it is req...
Andreas Kohlbecker
07:01 PM bug #8194: LazyInitializationException (LIE) on deleting the nomenclatural referenz (Section) of a Name
Initializing the authorteam of the inReferences of the references loaded by the combobox should solve the problem. Andreas Kohlbecker
06:59 PM bug #8194 (Closed): LazyInitializationException (LIE) on deleting the nomenclatural referenz (Section) of a Name

Habe die Section des eines Namens die als nomenklatorische Referenz gesetzt war löschen wollen:
http://phycoba...
Andreas Kohlbecker
06:53 PM Revision cf9ba327 (cdmlib): ref #8189 cdmlib-remote.properties as not required property source fixes bug introduced in 9b55e525
Andreas Kohlbecker
06:46 PM feature request #8193 (Closed): TaxonNamePopupEditor: add select form element for Nomenclatural status
Enable to add a nomenclatural status from a subset of status (see TaxEditor).
Exception invalid name in valitation =...
Wolf-Henning Kusber
06:26 PM bug #8191 (Closed): ReferencePopupEditor: When coming from NameEdior editing of the inreference should not be blocked
By now when opening the ReferenceEditor for inReference of a TaxonName the user can not modify or set a new inreferen... Andreas Kohlbecker
06:04 PM Revision 7f0f28bb (cdmlib): upgrading jetty-maven-plugin to 9.4.15.v20190215
Andreas Kohlbecker
04:44 PM Revision 72cbb7ab (cdm-vaadin): ref #7356 foundation for selenide tests implemented
Andreas Kohlbecker
04:32 PM Revision 3870ac74 (cdm-vaadin): ref #7356 adding selenide and spring-boot dependencies
Andreas Kohlbecker
04:30 PM Revision 17f913df (cdmlib): ref #8189 removing unnecessary dependency from cdmlib-commons
Andreas Kohlbecker
04:26 PM Revision 2d4efdc3 (cdm-vaadin): ref #7356 moving VaadinServletConfiguration from web.xml into CdmVaadinConfiguration
Andreas Kohlbecker
04:25 PM bug #8189 (Resolved): Allow configuration of 'user.home' via the spring environment
close issue if the changes are not causing any problems. Andreas Kohlbecker
12:15 PM bug #8189 (Closed): Allow configuration of 'user.home' via the spring environment
By now it is only possible to configure the `${user.home}` via the system properties. That means the only option to s... Andreas Kohlbecker
03:47 PM Revision 8b5bca23 (taxeditor): ref #8115 Use cached feature tree in factual data view context menu
Patrick Plitzner
03:47 PM Revision 1a4fdfe5 (cdmlib): Remove useless check
Patrick Plitzner
03:47 PM Revision 1ebbb842 (cdmlib): ref #8190 Allow sub term types for FeatureNode relations and trees
Patrick Plitzner
03:03 PM bug #8190 (In Progress): Default FeatureTree throws exception
Patrick Plitzner
01:30 PM bug #8190 (Closed): Default FeatureTree throws exception
When there are Characters and Features in the data base and the default feature tree is created it will fetch all of ... Patrick Plitzner
03:02 PM Revision 1b16a0e4 (taxeditor): ref #8058: add common name language preference - continue
Katja Luther
02:56 PM feature request #8058: Further issues for (local) preferences
the common name language preference is added. Katja Luther
02:46 PM Revision 0df7271b (cdmlib): ref #8189 ConfigFileUtil as spring bean in deafult context and tests implemented
Andreas Kohlbecker
02:46 PM Revision 110c97a6 (cdmlib): ref #8189 moving method getFolderSeperator() back to CdmUtils
Andreas Kohlbecker
02:46 PM Revision a23c2a31 (cdmlib): ref #8189 moving ConfigFileUtil and AccountStore to cdmlib-persistence:eu.etaxonomy.cdm.config
Andreas Kohlbecker
02:46 PM Revision 44b37b30 (cdmlib): ref #8189 moving folder funstins from CdmUtils to ConfigFileUtil
Andreas Kohlbecker
02:46 PM Revision 9b55e525 (cdmlib): ref #8189 CdmUtils uses the spring environment to find user.home
Andreas Kohlbecker
02:46 PM Revision cb88358a (cdmlib): ref #7356 upgrading goggle guava to 23.0 to conform to seleninde dependency which is used in cdm-vaadin
Andreas Kohlbecker
02:46 PM Revision 4c54f20c (cdmlib): removing test method
Andreas Kohlbecker
02:46 PM Revision d12f4695 (cdmlib): ref #8188 configurable.xml loads hibernate properties from src/test/resources/hibernate.properties - cdmlib
Andreas Kohlbecker
02:46 PM Revision 28eb7ddd (cdmlib): ref #7356 avoiding spring bean dependency cycle by adding @Lazy
Andreas Kohlbecker
02:46 PM Revision 74547d6a (cdmlib): ref #7356 throwing RuntimeException in case of severe web application misconfiguration instead of just logging
Andreas Kohlbecker
02:43 PM Revision 2de8ed33 (taxeditor): ref #8058: add common name language preference
Katja Luther
02:42 PM Revision d942cf2e (cdmlib): ref #8058: add commonNameLanguage to PreferencePredicate
Katja Luther
01:13 PM Revision 35ff7f48 (cdmlib-apps): db-name change in IAPTActivator
Andreas Kohlbecker
11:43 AM bug #8184: SpecimenTypedesignationEditor: add new specimen broken Chrome browser
Specimen Editor: auch der erste Typus lässt sich nicht speichern (kritisch)
Andreas Kohlbecker
11:34 AM Revision 1b2d19db (cdmlib): ref #6627: add import of taxon interactions to cdmlight - continue
Katja Luther
10:35 AM Revision 1e610f38 (cdmlib): ref #6627: add import of taxon interactions to cdmlight
Katja Luther

03/20/2019

04:58 PM Revision 3c64d726 (taxeditor): Refresh feature and character details view when setting feature supports
Patrick Plitzner
04:45 PM Revision daeb8ba2 (taxeditor): ref #8146 Adapt "add term wizard" to termType restriction
Patrick Plitzner
04:41 PM feature request #7975: Implement a block to display name relations
Validation:
![](picture156-1.png)
Replacement name:
Wie Validation behandeln,
Zudem wird
1. beim Widg...
Andreas Kohlbecker
03:10 PM Revision cab6ecd7 (cdm-vaadin): ref #8188 configurable.xml loads hibernate properties from src/test/resources/hibernate.properties - cdm-vaadin
Andreas Kohlbecker
02:54 PM bug #8188 (In Progress): Allow configuring hibernate properties via properties file
Andreas Kohlbecker
02:54 PM bug #8188 (Closed): Allow configuring hibernate properties via properties file
To allow for more flexible configuration of test environments it would be great if the hibernate properties which are... Andreas Kohlbecker
11:14 AM Revision a1095eff (cdmlib): fix regression in fieldUnitDTO with wrong collector+collectionNr
Katja Luther
11:10 AM feature request #8187 (New): Use Spring Environment instead of custom code in AbstractWebApplicationConfigurer
the method `AbstractWebApplicationConfigurer.findProperty(String property, boolean required)` implements a similar st... Andreas Kohlbecker
09:56 AM Revision 86f28971 (taxeditor): fix #7428: use eventbus for propagating update information
Katja Luther
08:06 AM Revision 903b5970 (taxeditor): Adapt to model change (set termType in constructor)
Patrick Plitzner
08:01 AM Revision 9b4264ec (cdmlib): Set term type in constructor for term and voc DTO
Patrick Plitzner

03/19/2019

07:31 PM feature request #7975: Implement a block to display name relations
Examples correctly in PhycoBank as use case for output improvement:
Example Validation
https://www.phycobank.org...
Wolf-Henning Kusber
02:30 PM feature request #7428: Open issues for updating open data while subtree is updated
please review.
Bulkeditor and nameeditor are updated.
Katja Luther
02:11 PM Revision 630c2c5d (taxeditor): ref #7428: fix selection for updated titlecache
Katja Luther
01:47 PM Revision a3d5eccd (cdmlib-apps): update to GreeceImageActivator
Andreas Müller
01:47 PM Revision d29ad503 (cdmlib-apps): update mysql driver in commented unitils datasource
Andreas Müller
01:47 PM Revision 5ec402ba (cdmlib-apps): adapt GermanSLImporBase inheritance
Andreas Müller
01:36 PM bug #8115 (Resolved): NPE when moving factual data
this problem is fixed. Katja Luther
01:29 PM bug #4545 (Resolved): Implement TeamOrPersonBaseSelectionDialog
please review.
TeamOrPerson is used for example for TaxonNodeAgentRelations or for authors in references
Katja Luther
01:29 PM Revision b7a38212 (taxeditor): ref #4545: reference author is of type teamOrPerson
Katja Luther
01:27 PM Revision 23d182dd (taxeditor): ref #8115: fix move facts when not persisted facts exist
Katja Luther
01:15 PM Revision 4a8227d3 (cdmlib): ref #4545: add getUuidAndAbbrevTitleCache with class parameter
Katja Luther
12:57 PM Revision dfc1e4fa (cdmlib): ref #4545: add getUuidAndAbbrevTitleCache with class parameter
Katja Luther
12:49 PM feature request #8185 (Feedback): Type layout
Hi Andreas, the same kind of formatting has formerly also been requested by Walter.
I consider this a very good so...
Andreas Kohlbecker
12:29 PM Revision 7bea8087 (taxeditor): ref #4545: add TeamOrPersonSelectionDialog
Katja Luther
09:52 AM feature request #8186 (Duplicate): List view order
ordering by registration numbers is hardly possible, see #7978.
Furthermore is this ticket a duplicate of #8157
Andreas Kohlbecker

03/18/2019

06:02 PM feature request #8186 (Duplicate): List view order
List view in Vaadin should be arranged from new (high registration numbers) to old.
Wolf-Henning Kusber
05:51 PM feature request #8185 (Feedback): Type layout
Type (as is):
Holotype: (BM BM123)
should be:
Holotype: BM (BM123)
see for example: https://www.phycobank...
Wolf-Henning Kusber
05:45 PM bug #8184 (Closed): SpecimenTypedesignationEditor: add new specimen broken Chrome browser
In Vaadin, type specimen editor a new line is created when a typ is selected.
This functions in FireFox. This does n...
Wolf-Henning Kusber
05:16 PM bug #8183 (In Progress): Make Feature IndividualAssociation a generalization of Specimen and Observation
until now this has been handled in the static method Feature.INDIVIDUALS_ASSOCIATION() which is not the correct place... Andreas Müller
03:55 PM bug #8115 (Feedback): NPE when moving factual data
This setup now works because we have to save before dragging the abstract to the other description
There is howeve...
Patrick Plitzner
02:30 PM Revision 0ac58cd8 (cdmlib): minor
Andreas Müller
02:30 PM Revision 268e5f20 (cdmlib): cleanup
Andreas Müller
02:07 PM task #7515: TypeDesignationStatusComparator to sort by vocabulary first and then by term order
Andreas Kohlbecker wrote:
> The Taxeditor should be more resilient against unusual data.
>
> 1. Suggestion as d...
Katja Luther
01:33 PM feature request #7433: new service method to get specimen by genetic AccessionNumber
this service method is implemented, but controller method is still missing Katja Luther
01:30 PM feature request #8182 (In Progress): show blast search result
the json result of the blast search should be displayed and the accession number needs to be a link to the correspond... Katja Luther
01:20 PM bug #8148 (Resolved): Login Dialog cuts off information
I put it to resolved to remind me reviewing.
Or are there still open issues?
Andreas Müller
01:04 PM bug #8148: Login Dialog cuts off information
I adapted the exception section and I could not reproduce the cutted advanced section (with the actual nightly). Coul... Katja Luther
12:57 PM Revision 8b0c5128 (taxeditor): delete hibernate.cfg.xml
Katja Luther
12:13 PM Revision 53bd0d7f (taxeditor): ref #8178 Adapt to service layer change
Patrick Plitzner
12:10 PM Revision 472739e6 (taxeditor): ref #8178 Auto-create presence-absence character
Patrick Plitzner
12:02 PM Revision 65b3a18d (taxeditor): ref #8178 Adapt to service layer change
Patrick Plitzner
12:02 PM Revision 7b1abbc3 (taxeditor): Fix term type check for feature drop adapter
Patrick Plitzner
11:55 AM feature request #5890 (New): Implement auto-suggest for data portal
Patrick Plitzner
11:07 AM Revision fe4a6e83 (taxeditor): ref #3836: add the modifier vocabulary to the combobox
Katja Luther
09:39 AM Revision 0a9b7662 (cdmlib): ref #8178 Add vocabulary parameter to create child node service method
Patrick Plitzner

03/15/2019

03:30 PM Revision a296b200 (cdmlib): ref #8169 adding missing @Transactional to VersionableServiceBase.isDeletable()
Andreas Kohlbecker
03:29 PM bug #8169: avoid factory.openSession() in DaoBase
VersionableServiceBase.isDeletable misses the @Transactional(readOnly = true) annotation! Andreas Kohlbecker
03:25 PM bug #8169: avoid factory.openSession() in DaoBase
Here is a case found in the server log (occurred 6x in a couple of hours):
~~~
[phycobank] 2019-03-15 10:27:44,...
Andreas Kohlbecker
01:57 PM Revision 4186a152 (cdm-dataportal): ref #7755: filter import sources for occurrences
Katja Luther
01:13 PM Revision a1ce57ce (cdm-dataportal): ref #7755: rename baseURL for occurrences to occurrence/uuid
Katja Luther
12:02 PM Revision abe0b021 (cdm-dataportal): ref #7755: some order issues in specimen detail page
Katja Luther
11:44 AM feature request #8181 (New): Further features for bulk editors
this is a ticket to collect all wanted features for bulkeditors:
Advanced search or column filter options:
* ...
Katja Luther
10:44 AM feature request #7755: Implement advanced detail page for occurrences
mail from AM:
Hallo Katja,
ich bin im Zuge von FoG über die Specimenseite gestolpert. Sehr schön, dass da jetzt...
Katja Luther
09:21 AM feature request #8180 (Closed): Add property term "Presence/Absence" to CDM default terms
When describing a specimen via Characters (almost) all structures may or may not exist. To be able to describe if a s... Patrick Plitzner
08:35 AM Revision ce7faf74 (cdmlib): ref #8162 update to model cache
Patrick Plitzner
08:18 AM Revision 31e57990 (cdmlib-apps): Adapt imports to tem model changes
Patrick Plitzner

03/14/2019

06:26 PM bug #8179 (New): PopupEditorException
Type name editor, PopupEditorException
when saving a name type of a genus
in Workingset
http://api.phycobank.org...
Wolf-Henning Kusber
04:05 PM Revision 63311bd9 (cdm-vaadin): multiple test datasources for tesing multiple test suites
Andreas Kohlbecker
02:48 PM Revision 7dc9bbbb (taxeditor): ref #3836: add modifier to description elements
Katja Luther
02:12 PM feature request #8178 (Rejected): Auto-create absence/presence character for every structure
Presence/Absence Property (PA)
* Jede Strukture muss in Kombination mit PA-Property einen Character bilden.
* Bei...
Patrick Plitzner
02:04 PM feature request #8121 (In Progress): Allow selecting structural/property modifiers when creating a character
Patrick Plitzner
01:56 PM feature request #6849 (In Progress): [DISCUSS] How to handle "kind of" term creation in TermEditor
Patrick Plitzner
01:37 PM Revision d9f54449 (taxeditor): ref #7428: updateEditors method in AbstractUtility class
Katja Luther
01:07 PM Revision 46567e3a (cdmlib): ref #6413 Throw exception for more than 1 or 0 FieldUnits
Patrick Plitzner
01:05 PM Revision 28716614 (cdmlib): Adapt test to change in clone() method
Patrick Plitzner
12:16 PM Revision f9fbd38a (taxeditor): ref #6413 i18n
Patrick Plitzner
12:11 PM feature request #6413 (Resolved): [DISCUSS] How to create type duplicates (e.g. isotypes) for a taxon name
The first implementation allows selection one of the already existing specimen type designation for creating the dupl... Patrick Plitzner
12:07 PM Revision d436d97b (taxeditor): code cleanup
Patrick Plitzner
12:00 PM Revision 18a3973f (taxeditor): ref #6413 Disable non-editable text fields
Patrick Plitzner
12:00 PM Revision 80a540f2 (taxeditor): ref #6413 Implement type duplication in type detail section
Patrick Plitzner
12:00 PM Revision 0661b3e6 (taxeditor): ref #6413 Add "Clone Type Duplicate" option to name details view
Patrick Plitzner
12:00 PM Revision 899a348b (taxeditor): Fix copy&paste error
Patrick Plitzner
12:00 PM Revision 99366401 (cdmlib): ref #6413 Add service method for duplicating type specimen
Patrick Plitzner
12:00 PM Revision 56b642e9 (cdmlib): Fix clone() method of SpecimenOrObservationBase
Patrick Plitzner

03/13/2019

04:00 PM Revision 123796a3 (taxeditor): ref #7428: move updateViews into AbstractUtility
Katja Luther
12:52 PM feature request #8175: add name facts to cdm light export
the name facts are moved to their own table. Katja Luther
12:51 PM Revision 24b61cf8 (cdmlib): ref #8175: name facts in a separate table
Katja Luther
12:30 PM Revision a3c9dcce (cdm-server): cdmlib-developer.log to be ignored by git
Andreas Kohlbecker
12:29 PM Revision 14a235fc (cdm-server): ref #8173 setting spring.profiles.active in the cdm-sever bootloader if not defined otherwise
Andreas Kohlbecker
12:17 PM Revision 42b67a16 (cdmlib): Revert "ref #8173 removing 'remoting' profile activation from ide launchers"
This reverts commit 027eaf7c3181f62d725e7b5a677284f07cd5b43b. Andreas Kohlbecker
12:16 PM Revision dd0d18ea (cdmlib): Revert "ref #8173 activation of profile remoting in the web.xml"
This reverts commit f2d3f4d37174244ca577203d1228256c6f787a29. Andreas Kohlbecker
10:46 AM Revision 2c44794f (taxeditor): minor
Katja Luther
09:57 AM feature request #7428 (Resolved): Open issues for updating open data while subtree is updated
Applied in changeset commit:taxeditor|4fff2d21dfed4ae1ba6c5106e7d59cdf2e82548c. Katja Luther
09:56 AM Revision 4fff2d21 (taxeditor): fix #7428: ask for saving and update open views for subtree operations
Katja Luther
09:36 AM bug #8176 (Resolved): WeaklyRelatedEntityCombobox is slow
test TaxonNamePopupEditor Genus field, replaced Synonym and Basionym also some ToManyRelatedEntitiesComboboxes and T... Andreas Kohlbecker
09:31 AM Revision aec76ebb (cdm-vaadin): ref #8176 removing workaround with bad performance which was need for broken TaxonNameStringFilterablePagingProvider.idFor()
Andreas Kohlbecker
09:02 AM Revision eb8d2f54 (cdm-vaadin): ref #8176 bugfix in TaxonNameStringFilterablePagingProvider.idFor()
Andreas Kohlbecker

03/12/2019

05:57 PM bug #8176 (In Progress): WeaklyRelatedEntityCombobox is slow
Andreas Kohlbecker
02:15 PM bug #8176 (Closed): WeaklyRelatedEntityCombobox is slow
## on setting values
The WeaklyRelatedEntityCombobox needs to check if the value to set is at all contained in the...
Andreas Kohlbecker
05:57 PM Revision af0633ea (cdm-vaadin): ref #8176 WeaklyRelatedEntityCombobox solving minor performance on setValue
Andreas Kohlbecker
03:48 PM Revision f2d3f4d3 (cdmlib): ref #8173 activation of profile remoting in the web.xml
Andreas Kohlbecker
02:22 PM report #8177 (Worksforme): Discuss: How to add originals of a type specimen
How to store? Wolf-Henning Kusber
01:07 PM bug #6627: Remaining cdm light issues
the name facts are implemented now, see #8175 Katja Luther
01:06 PM feature request #8175: add name facts to cdm light export
please review Katja Luther
01:06 PM feature request #8175 (Resolved): add name facts to cdm light export
Applied in changeset commit:cdmlib|852a1a9e5171370a8e3e6962b21837e38115cf9a. Katja Luther
01:04 PM feature request #8175 (Closed): add name facts to cdm light export
We decided to keep the name facts in cdm, so the name facts should be exported as well Katja Luther
01:06 PM Revision 852a1a9e (cdmlib): fix #8175: name facts should be exported by cdm light export
Katja Luther
12:53 PM bug #8099: Error saving name type designation editor due to problem in poupeditor context
can not reproduce Andreas Kohlbecker
12:52 PM Revision 98db0610 (cdm-vaadin): ref #8132 fixin bug related to transaction rollback in CdmStore
Andreas Kohlbecker
12:03 PM bug #8111: User selection dialog for groups does not filter out existing users
please review Katja Luther
12:02 PM bug #8111 (Resolved): User selection dialog for groups does not filter out existing users
Applied in changeset commit:taxeditor|cbc83794de4303c54b45309ff151c70627e82e1a. Katja Luther
12:02 PM Revision cbc83794 (taxeditor): fix #8111: filter existing users/groups for member/group selection
Katja Luther
11:34 AM bug #8115: NPE when moving factual data
please review Katja Luther
11:33 AM bug #8115: NPE when moving factual data
the problem was the not persisted description, therefore the description needs to be passed to the service method. To... Katja Luther
11:26 AM bug #8115 (Resolved): NPE when moving factual data
Applied in changeset commit:taxeditor|803af83ee2911d193d6a95a3f73dee727ae77d45. Katja Luther
11:23 AM Revision b5a42086 (cdmlib): ref #8115: fix move elements for not persisted target description
Katja Luther
11:23 AM Revision 803af83e (taxeditor): fix #8115: fix move elements to not persisted target description
Katja Luther
10:14 AM Revision 408fe3ed (cdm-vaadin): avoiding LazyInitialitationException
Andreas Kohlbecker
09:31 AM feature request #8136: Implement sources for type designations in TaxEditor
please review Katja Luther
09:30 AM feature request #8136 (Resolved): Implement sources for type designations in TaxEditor
Applied in changeset commit:taxeditor|9f40979f5e0d2fc55100acc5a7fabac00d48ce12. Katja Luther
09:30 AM Revision 9f40979f (taxeditor): fix #8136: update type section when changing type to or from lectotype
Katja Luther
09:09 AM Revision 8f2aad1d (cdm-server): ref #8173 removing 'remoting' profile activation from ide launchers
Andreas Kohlbecker
09:09 AM Revision 027eaf7c (cdmlib): ref #8173 removing 'remoting' profile activation from ide launchers
Andreas Kohlbecker
08:53 AM Revision df841466 (cdm-server): notes on commented settings regarding debugging of leaky db connections
Andreas Kohlbecker
08:36 AM bug #8105: better hotfix branch strategy in git flow to avoid commits in master which are missing in develop
I did a brief research on the topic of hotfix branches:
1. git flow has the concept of ***support branches*** by whi...
Andreas Kohlbecker
08:11 AM task #8130: Check if related feature data is cleared when supported facts type is changed
For nomenclatural code there is a method checkForDeletableParts() where the deletable parts set to null.
But for ...
Katja Luther

03/11/2019

06:10 PM Revision 5261131c (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore - copied from hfx branch
Andreas Kohlbecker
05:18 PM Revision 41cb64c2 (cdm-server): Merge branch 'hotfix/5.5.3'
jenkins
05:18 PM Revision 3a3734fc (cdm-server): jenkins: setting project version to 5.5.3
jenkins
05:14 PM Revision 4b98496f (cdm-webapp): Merge branch 'hotfix/5.5.3'
jenkins
05:14 PM Revision ecfdfc7e (cdm-webapp): jenkins: setting project version to 5.5.3
jenkins
05:07 PM Revision 43faffd3 (cdm-vaadin): Merge branch 'hotfix/5.5.3'
jenkins
05:07 PM Revision 4ee41e42 (cdm-vaadin): jenkins: setting project version to 5.5.3
jenkins
05:05 PM Revision 761ee155 (cdm-server): jenkins bumping cdm-webapp.version to 5.5.3
jenkins
05:04 PM Revision 5d752aea (cdm-server): updating poms for 5.5.3 branch with snapshot versions
jenkins
02:47 PM Revision 23459bd5 (cdmlib): Merge branch 'hotfix/5.5.2'
jenkins
02:47 PM Revision e4b983ac (cdmlib): jenkins: setting project version to 5.5.2
jenkins
02:33 PM bug #8174: First test fails if term data is in loaded DataSet
This is the order how events are handled in unitils:
* [Unitils] beforeTestClass - TestClass1
* [Test] testBefore...
Andreas Müller
02:30 PM bug #8174 (New): First test fails if term data is in loaded DataSet
This is because the unitils/dbunit JpaModul starts the application context only during
~~~ java
beforeTestMethod...
Andreas Müller
02:32 PM Revision c766108e (cdm-webapp): jenkins bumping cdmlib.version to 5.5.2 cdm.vaadin.version to 5.5.3
jenkins
02:32 PM Revision 98dbaebe (cdm-webapp): updating poms for 5.5.3 branch with snapshot versions
jenkins
02:23 PM Revision d201d8e5 (cdm-vaadin): Merge branch 'hotfix/5.5.3' into develop
Andreas Kohlbecker
02:18 PM Revision e98e8737 (cdm-vaadin): Revert "ref #8132 proper transaction rollback in CdmStore" which has been only been cherry-picked to avoid merge problems during the release later on
This reverts commit 278e8f9600956b6e8205337045815a153f0a05ac. Andreas Kohlbecker
02:16 PM Revision 278e8f96 (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore
merging Conflicts in src/main/java/eu/etaxonomy/cdm/service/CdmStore.java Andreas Kohlbecker
02:01 PM Revision 23025c30 (cdm-vaadin): ref #8132 proper transaction rollback in RegistrationWorkingsetPresenter
Andreas Kohlbecker
02:01 PM Revision 9f8b217c (cdm-vaadin): adding c3p0.properties to gitignore
Andreas Kohlbecker
01:53 PM bug #8170: javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
I opened issue #8171 only for fixing the most severe problem quickly by storing the new connection in the cache field... Andreas Kohlbecker
01:41 PM bug #8170 (Feedback): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
Is this still an open issue after #8171 is solved now?
I also do not fully understand the solution. In #8171 you s...
Andreas Müller
01:41 PM bug #8149: ReferenceEditor: filter inReferences ONLY by applicable reference type suppess Generic and NULL
Related problem:
if e.g. "Phytotaxa" is tiped into the dopdown menue field, "Phytotaxa" is not selected, I have to s...
Wolf-Henning Kusber
01:10 PM feature request #6413 (In Progress): [DISCUSS] How to create type duplicates (e.g. isotypes) for a taxon name
Patrick Plitzner
12:59 PM feature request #8173 (In Progress): spring profile remoting enabled by default
Andreas Kohlbecker
12:55 PM feature request #8173 (Resolved): spring profile remoting enabled by default
Applied in changeset commit:cdmlib|5ab0f6455f6cb83bfba0bb5ad6aee6e210d8dd14. Andreas Kohlbecker
12:48 PM feature request #8173 (In Progress): spring profile remoting enabled by default
Andreas Kohlbecker
12:40 PM feature request #8173 (Closed): spring profile remoting enabled by default
the spring profile still needs to be enabled by passing `-Dspring.profiles.active=remoting` to cdm-remote instances.... Andreas Kohlbecker
12:57 PM feature request #8096 (Resolved): Implement CacheUpdater as long running task with correct progress monitoring
please review Katja Luther
12:55 PM Revision 4478751c (taxeditor): ref #8096: set correct task name in progress monitor manager
Katja Luther
12:55 PM Revision 5ab0f645 (cdmlib): fix #8173 spring profile 'remoting' activated by default
Andreas Kohlbecker
12:55 PM Revision 7d340a47 (cdmlib): fix #8171 internally caching new connection in WrappedCdmDataSource to avoid connection leaks
Andreas Kohlbecker
12:55 PM Revision 80595b0d (cdmlib): ref #7106 proper transaction management in turn of solving the problem in CdmRepository.getSession()
Andreas Kohlbecker
12:55 PM Revision 8db30ca4 (cdmlib): log level for cdm caches to WARN to avoid constant noise from the TransientCdmCacher
Andreas Kohlbecker
12:54 PM bug #8171 (Resolved): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource fails to cache the connection which and leaves it unclosed
Applied in changeset commit:cdmlib|ddaf22cfc36cad56b677c8fecd8eb3e83db5cefb. Andreas Kohlbecker
12:53 PM Revision 99583d95 (cdm-vaadin): ref #8132 proper transaction rollback in CdmStore
Andreas Kohlbecker
12:13 PM bug #7874: TeamOrPersonBase entity can become unusable due to replacement of the title caches on using getters
fixed a small bug in updateCaches of Team.java which results in the result was always true. commit:cdmlib|694f0ef28f3... Katja Luther
12:12 PM Revision 694f0ef2 (cdmlib): fix #7874: updateCaches always returns true
Katja Luther
11:50 AM Revision 6f71379a (cdm-vaadin): ref #8132 proper transaction rollback in RegistrationWorkingsetPresenter
Andreas Kohlbecker
08:18 AM Revision 04819529 (cdm-vaadin): adding c3p0.properties to gitignore
Andreas Kohlbecker
08:18 AM Revision 8c1dd527 (cdm-vaadin): setting cdmlib version to 5.5.2-SNAPSHOT
Andreas Kohlbecker

03/08/2019

07:17 PM feature request #8172 (New): Discuss: Cite an image of the holotype
Probem: in Micoalgae, a type specimen can be designated, but nobody knows how the taxon looks like. E.g. Two differen... Wolf-Henning Kusber
05:28 PM Revision e22b441a (cdmlib): log level for cdm caches to WARN to avoid constant noise from the TransientCdmCacher
Andreas Kohlbecker
05:27 PM Revision ddaf22cf (cdmlib): fix #8171 internally caching new connection in WrappedCdmDataSource to avoid connection leaks
Andreas Kohlbecker
05:25 PM Revision eb370441 (cdmlib): updating poms for 5.5.2 branch with snapshot versions
jenkins
05:17 PM bug #8132: phycobank cdm-server instance problems with db connections
Another situation in which a connection is being opened but not properly closed is occurring in the `DataSourceConfig... Andreas Kohlbecker
02:02 PM bug #8132: phycobank cdm-server instance problems with db connections
debugging the cdm-server to find connections that have been opened but which are not being closed properly (DebugC3P0... Andreas Kohlbecker
05:06 PM bug #8171 (Closed): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource fails to cache the connection which and leaves it unclosed
When the existing cached connection in the WrappedCdmDataSource is null a new connection will be created but is not s... Andreas Kohlbecker
04:59 PM bug #8170 (New): javax.sql.DataSource.getConnection() implementation in WrappedCdmDataSource does not conform to the interface
the documentation of `javax.sql.DataSource.getConnection()` reads like *"**Attempts to establish** a connection with ... Andreas Kohlbecker
02:26 PM Revision 5479cc9a (cdm-vaadin): ref #8132 fixing problem of uncommited transaction in RegistrationWorkingsetPresenter
Andreas Kohlbecker
02:24 PM Revision 06cc1a39 (cdm-vaadin): updating poms for 5.5.3 branch with snapshot versions
jenkins
02:21 PM Revision d2accd99 (cdm-vaadin): ref #8132 fixing problem of uncommited transaction in RegistrationWorkingsetPresenter
Andreas Kohlbecker

03/07/2019

04:58 PM Revision 998a72e0 (cdm-vaadin): ref #7106 refactoring CdmStore in turn of changed CdmRepository.getSession()
- CdmStore as Spring bean
- CdmStore managed transactions and sessions properly
Andreas Kohlbecker
03:26 PM bug #8169 (New): avoid factory.openSession() in DaoBase

In DaoBase using `factory.openSession()` is plain wrong, the HibernateTransactionManger should be used instead.
Andreas Kohlbecker
03:24 PM bug #7106 (In Progress): avoid factory.openSession() in CdmRepository
Andreas Kohlbecker
02:17 PM bug #7106: avoid factory.openSession() in CdmRepository
since February 25th there are only occurrences related to this issue in the log which affected the phycobank code.
W...
Andreas Kohlbecker
07:25 AM bug #7106: avoid factory.openSession() in CdmRepository
with the logging of the stacktrace it now becomes clear where the unmanaged sessions are being created:
~~~~
java...
Andreas Kohlbecker
02:57 PM Revision b7647a99 (cdm-vaadin): ref #7106 using new CdmRepository.clearSession() method
Andreas Kohlbecker
02:54 PM Revision 6d6ae033 (cdmlib): ref #7106 logging unintentially creation of unmanaged new session in DaoBase with stacktrace
Andreas Kohlbecker
02:54 PM Revision ff628107 (cdmlib): ref #7106 throwing Exception instead of unintentially creating unmanaged new session
Andreas Kohlbecker
12:37 PM bug #8132: phycobank cdm-server instance problems with db connections
The problem just occurred again. This time no one was using the Taxeditor since the instance has been started.
The...
Andreas Kohlbecker
12:03 PM Revision 93fb962c (cdm-dataportal): fix specimen details page -continue
Katja Luther
11:21 AM task #8168 (New): Check if withdrawing of per entity permission is working correctly for inReferences
Andreas Kohlbecker
11:17 AM bug #8167 (Closed): Permission denied for Submitter when adding section to newly created journal

~~~
[phycobank] 2019-03-07 09:56:41,648 ERROR [qtp1510067370-69] [org.hibernate.internal.SessionImpl] - HHH000346:...
Andreas Kohlbecker
11:15 AM Revision 9214096f (cdm-dataportal): revert last changes
Katja Luther
10:12 AM Revision d2deb7ca (cdmlib): ref #8096: use subprogressmonitor for cache updater
Katja Luther
09:39 AM task #8118: Update MySQL drivers
Andreas Müller wrote:
> Some solution is setting on command line e.g. for Central European time (CET):
>
> mysql>...
Katja Luther
09:25 AM Revision ade2b1f0 (cdm-dataportal): fix css for specimens
Katja Luther
08:33 AM Revision 000aa820 (taxeditor): removed cdm.map.ser from taxeditor.cdmlib resources (cont.)
Andreas Müller

03/06/2019

09:30 PM Revision 8f43de05 (taxeditor): removed cdm.map.ser from taxeditor.cdmlib resources
Andreas Müller
08:57 PM task #8118: Update MySQL drivers
Some solution is setting on command line e.g. for Central European time (CET):
mysql> SET GLOBAL time_zone = '+1:0...
Andreas Müller
08:19 PM task #8118: Update MySQL drivers
Katja, I think you also had the problem localy. What did you do to fix it? Andreas Müller
08:11 PM task #8118: Update MySQL drivers
This is what I currently get when connecting to MySQL on PESIHPC:
~~~
Caused by: com.mysql.cj.exceptions.InvalidC...
Andreas Müller
08:06 PM task #8118: Update MySQL drivers
https://stackoverflow.com/questions/26515700/mysql-jdbc-driver-5-1-33-time-zone-issue Andreas Müller
06:20 PM Revision 3cee4d12 (cdm-server): ref #7729 suppress nasty ehcache OutOfMemory warnings to reduce clutter in the server log
Andreas Kohlbecker
06:07 PM Revision d75c4b91 (cdm-server): ref #8132 c3p0 settings for debugging lost jdbc connections
Andreas Kohlbecker
05:43 PM Revision 568fb7dc (cdmlib): ref #7106 logging stacktrace with 'Opening new session in turn of a HibernateException'
Andreas Kohlbecker
05:24 PM Revision 8d98b642 (cdmlib-apps): E+M specific book recognition?
Andreas Müller
05:20 PM Revision 9945900a (cdmlib-apps): minor
Andreas Müller
05:00 PM bug #7106: avoid factory.openSession() in CdmRepository
In a locally running cdmserver started vi the eclipse launcher *cdm-server - start from war* multiple occurrences can... Andreas Kohlbecker
03:36 PM Revision 74b0ae76 (cdmlib): minor
Andreas Müller
03:34 PM Revision a4649a49 (cdmlib): cleanup
Andreas Müller
03:04 PM Revision 5e339d32 (taxeditor): ref #8044 Add "Move to..." menu to term editor
Patrick Plitzner
02:54 PM Revision b8f1dbe7 (cdmlib): Fix default term move position
Patrick Plitzner
02:53 PM Revision 489f7610 (cdm-dataportal): add class specimen to page to avoid bullets for item list
Katja Luther
02:25 PM Revision 7c9e8720 (taxeditor): ref #8162 move ISourceable to reference package in TaxEditor
Andreas Müller
02:23 PM Revision c5a114a8 (cdm-dataportal): ref #8166 adapting to change in FeatureNode property 'feature' becomes 'term' - 2
Andreas Kohlbecker
02:12 PM Revision 19ff6869 (taxeditor): ref #8162 move FeatureTree and FeatureNode to new term package in TaxEditor
Andreas Müller
02:05 PM Revision 7994816f (cdmlib): set FeatureTest preliminary to ignore
Andreas Müller
01:57 PM Revision b011743c (cdm-dataportal): ref #8166 adapting to change in FeatureNode property 'feature' becomes 'term'
Andreas Kohlbecker
01:56 PM task #8166 (Closed): Adapt dataportal to term structure changes
the dataportal needs to be adapted to the changes applied in the context of #6794 Andreas Kohlbecker
01:24 PM Revision 9ab4e3ab (cdmlib-apps): ref #8162 move FeatureTree and FeatureNode to term package in cdmlib-app
Andreas Müller
01:22 PM Revision de81ab2a (cdmlib-apps): ref #8162 move OriginalSourceXXX to reference package in cdmlib-app
Andreas Müller
01:16 PM Revision b6b3cb35 (cdmlib): ref #8162 move FeatureTree and FeatureNode to term package
Andreas Müller
01:05 PM task #8162: Move term related classes from model.common to model.term
Andreas Müller wrote:
> Other classes to move: Sources und IntextReferences, Rights, IReferencedEntity, ReferencedE...
Andreas Müller
01:03 PM task #8162: Move term related classes from model.common to model.term
Also move FeatureNode and FeatureTree to new term package as they become TermTreeNode and TermTree Andreas Müller
01:02 PM Revision 6ed7a1a7 (taxeditor): ref #8162 move OriginalSourceXXX to reference package
Andreas Müller
12:57 PM Revision 334731bb (cdmlib): ref #8162 missing adaption for moving of OriginalSourceBase
Andreas Müller
12:30 PM Revision 17ff12b9 (cdm-dataportal): Merge tag '5.5.1' into develop
tagging hotfix release 5.5.1 Andreas Kohlbecker
12:30 PM Revision 43bc8f03 (cdm-dataportal): Merge branch 'hotfix/5.5.1'
Andreas Kohlbecker
10:49 AM task #8130: Check if related feature data is cleared when supported facts type is changed
Katja, could you please check how we do these "model validations" in terms of e.g. nomenclatural code changes in Taxo... Andreas Müller
10:14 AM task #8130 (Feedback): Check if related feature data is cleared when supported facts type is changed
Andreas Müller wrote:
> We may want to implement hard or soft validation for this. Maybe also an update script to re...
Patrick Plitzner
10:07 AM task #8130 (In Progress): Check if related feature data is cleared when supported facts type is changed
Patrick Plitzner
10:44 AM feature request #8165 (New): enable logback jmx for cdm-server
having the logback jmx beans enabled would be a great help during debugging of the production server and other system... Andreas Kohlbecker
10:23 AM bug #5632: ClassNotFoundException for org.eclipse.jetty.servlet.listener.ELContextCleaner during taxeditor mvn integration-test
Moving the ticket back to decide what we want to do with it Patrick Plitzner
10:19 AM bug #5632: ClassNotFoundException for org.eclipse.jetty.servlet.listener.ELContextCleaner during taxeditor mvn integration-test
This exception is still thrown when the test is run.
This is the log of the last jenkins run: http://int.e-taxonom...
Patrick Plitzner
10:21 AM Revision 9fc5c5ca (taxeditor): ref #5632 Disable CdmServer test
Patrick Plitzner
09:59 AM Revision b668f047 (taxeditor): ref #5632 Re-enable CdmServer test
Patrick Plitzner
08:51 AM bug #8164 (New): ClassNotFoundException during deserialization for Reference
Andreas K.: "Ich habe in dem Produktions-Server-Log seit Oktober 10x
`org.springframework.web.util.NestedServletEx...
Patrick Plitzner
12:35 AM Revision 113347bb (cdmlib): ref #8162 move OriginalSourceXXX to reference package
Andreas Müller
12:30 AM Revision bd491943 (cdmlib): ref #8162 move OriginalSourceXXX to reference package
Andreas Müller

03/05/2019

05:42 PM Revision 78a42a9b (cdm-dataportal): fix specimen details from compressed table
Katja Luther
05:39 PM task #8162: Move term related classes from model.common to model.term
Andreas Müller wrote:
> we should also adapt persistence layer
done
Andreas Müller
12:43 PM task #8162 (Resolved): Move term related classes from model.common to model.term
Applied in changeset commit:taxeditor|974d02d015234ec80816dfb47eaabde6688c2fa9. Andreas Müller
12:24 PM task #8162 (In Progress): Move term related classes from model.common to model.term
Andreas Müller
12:23 PM task #8162: Move term related classes from model.common to model.term
we should also adapt persistence layer Andreas Müller
12:12 PM task #8162 (Resolved): Move term related classes from model.common to model.term
Applied in changeset commit:taxeditor|b9dc6bb1d38897b06888836dd74d48684f73c5d5. Andreas Müller
10:52 AM task #8162: Move term related classes from model.common to model.term
Other classes to move: Sources und IntextReferences, Rights, IReferencedEntity, ReferencedEntityBase, Language? Andreas Müller
05:37 PM Revision 0698c0be (taxeditor): ref #8162 export persistence.dao.(hibernate.)term
Andreas Müller
05:34 PM Revision 76cfd0f6 (cdmlib): ref #8162 move term related classes from persistence(.dao.)common to .term
Andreas Müller
05:22 PM bug #8132: phycobank cdm-server instance problems with db connections
Results from the server log:
The problem occurred again. The jdbc connection which was being used by the tread `qt...
Andreas Kohlbecker
05:13 PM Revision d91361a3 (taxeditor): minor
Katja Luther
04:58 PM Revision 89c64d84 (cdm-server): Merge branch 'hotfix/5.5.2'
jenkins
04:55 PM Revision 30fc7ac4 (cdmlib): ref #6794 adapt FeatureTreeController property path to new FeatureNode structure
Andreas Müller
04:51 PM Revision e69e90b6 (taxeditor): Remove hard coded port for localhost in login dialog
Patrick Plitzner
04:51 PM Revision 99f7ead3 (cdm-server): fixing project versions
jenkins
04:39 PM Revision 6767f1b1 (cdm-server): jenkins bumping cdm-webapp.version to 5.5.2
jenkins
04:39 PM Revision f6563017 (cdm-server): updating poms for 5.5.2 branch with snapshot versions
jenkins
04:25 PM Revision 94f804c7 (cdmlib-apps): fix merge issue in PlantGlossaryCsvImportState
Andreas Müller
04:19 PM Revision eedc312f (taxeditor): fix #8162 add eu.etaxonomy.cdm.model.term.init to exported packages
Andreas Müller
04:15 PM Revision 6d6e8fae (cdm-webapp): Merge branch 'hotfix/5.5.2'
jenkins
04:15 PM Revision 79f8e358 (cdm-webapp): jenkins: setting project version to 5.5.2
jenkins
04:13 PM Revision 9cd3787a (cdm-vaadin): Merge branch 'hotfix/5.5.2'
jenkins
04:13 PM Revision a74e0d05 (cdm-vaadin): jenkins: setting project version to 5.5.2
jenkins
04:09 PM Revision e29a4a6e (cdm-server): loggin: eu.etaxonomy.cdm.cache.CdmTransientEntityCacher on level WARN
Andreas Kohlbecker
04:07 PM Revision c140ae29 (cdm-webapp): jenkins bumping cdm.vaadin.version to 5.5.2
jenkins
04:07 PM Revision 850c2918 (cdm-webapp): updating poms for 5.5.2 branch with snapshot versions
jenkins
04:05 PM Revision 5976b46d (cdm-vaadin): Merge branch 'hotfix/5.5.2' into develop
Andreas Kohlbecker
03:49 PM Revision 09c85ccb (cdm-vaadin): ref #8160 CdmBeanItemContainerFactory @Transactional only where needed and clearing session before each service call
Andreas Kohlbecker
02:58 PM bug #8107 (Closed): NPE when throwing PopupEditorException in AbstractPopupEditor
issue is not reproducible - closing. Andreas Kohlbecker
02:41 PM Revision 66172879 (cdmlib): ref #8096: termservice adapted
Katja Luther
02:26 PM Revision 0da5fc18 (cdmlib): ref #8096: delete old cache updater and adapt cache updater to moved terms
Katja Luther
01:59 PM Revision 95371079 (cdmlib): ref #8096: move cache updater and service methods return updateResult -continue
Katja Luther
01:58 PM Revision 112ab4f7 (cdmlib): ref #8096: move cache updater and service methods return updateResult
Katja Luther
01:39 PM Revision a2452e25 (taxeditor): minor
Katja Luther
01:38 PM Revision c01a0dfe (taxeditor): ref #8096: restructure repair menu and use longrunningTaskService for repair functionality
Katja Luther
12:43 PM Revision 974d02d0 (taxeditor): fix #8162 add eu.etaxonomy.cdm.model.term to exported packages
Andreas Müller
12:17 PM Revision ad29970c (cdmlib-apps): fix #8162 adapt PlantGlossaryCategoryAsPropertiesImport to new terms package structure
Andreas Müller
12:12 PM Revision b9dc6bb1 (taxeditor): fix #8162 adapt terms to new package structure in TaxEditor
Andreas Müller
11:49 AM feature request #8163 (Rejected): RegistrationService.setStatus() method implemented
This method need to be used by the RegistrationWorkingsetPresenter.saveRegistrationStatusChange() method in cdm-vaadi... Andreas Kohlbecker
11:49 AM Revision c715029f (cdmlib-apps): Merge branch 'master' into feature8162
Conflicts:
app-import/src/main/java/eu/etaxonomy/cdm/io/plantglossary/PlantGlossaryCsvImportState.java
Andreas Müller
11:33 AM Revision abfdb8f6 (cdmlib): ref #8162 update to model cache
Andreas Müller
11:33 AM Revision 58e2f57e (cdmlib): ref #8162 updates to test data in further metadata
Andreas Müller
11:33 AM Revision a4ae2ca1 (cdmlib): ref #8162 updates to hibernate.cfg.xml
Andreas Müller
11:33 AM Revision 482ed9fb (cdmlib): minor changes in CdmModelCacher
Andreas Müller
11:33 AM Revision 1c39686b (cdmlib): ref #8162 adapt cdmlip to new term package structure
Andreas Müller
11:21 AM bug #8161 (Rejected): *FilterablePagingProvider classes as transactional readonly spring beans
the *FilterablePagingProviders only are using service methods which are anyway annotated with `@Transactional(readOnl... Andreas Kohlbecker
11:21 AM bug #7945 (Rejected): TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
the *FilterablePagingProviders only are using service methods which are anyway annotated with `@Transactional(readOnl... Andreas Kohlbecker
11:14 AM bug #8075 (In Progress): multiple cascade all-delete-orphan exceptions related to DefinedTermBase.representations
Andreas Kohlbecker
10:55 AM bug #8158: cascade="all-delete-orphan" problem when ....
potentially duplicate of #8160 Andreas Kohlbecker
10:51 AM Revision c8236d99 (taxeditor): minor
Andreas Müller
12:19 AM Revision 7ae0512d (cdmlib-apps): ref #8162 adapt cdmlip-app to new term package structure
Andreas Müller

03/04/2019

04:45 PM Revision 495f8632 (cdm-vaadin): ref #8162 adapt vaadin to new term package
Andreas Müller
03:36 PM Revision 52aa37ab (cdm-vaadin): ref #8161 TaxonNameStringFilterablePagingProvider as transactional readonly prototype bean
Andreas Kohlbecker
03:33 PM Revision ee6886b5 (cdmlib): ref #6794 deproxy term of feature node
Patrick Plitzner
03:19 PM task #8162 (Closed): Move term related classes from model.common to model.term
This means moving the following model classes:
* DefinedTerm
* DefinedTermBase
* OrderedTerm
* OrderedTermBase
...
Andreas Müller
03:06 PM bug #7881: reference selection combobox broken after error in ...
potentially duplicate of #8161 Andreas Kohlbecker
03:06 PM Revision f8596f2d (taxeditor): ref #8121 Add structural modifier element to character detail element
Patrick Plitzner
03:04 PM bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
potentially duplicate of #8161 Andreas Kohlbecker
03:00 PM bug #8065: HibernateException: corrupt session problem breaks SpecimenTypeDesignationworkingsetEditor type designation table
potentially duplicate of #8160 Andreas Kohlbecker
02:07 PM bug #8160 (Resolved): CdmBeanItemContainerFactory as readonly service bean
Andreas Kohlbecker
12:43 PM bug #8160 (Closed): CdmBeanItemContainerFactory as readonly service bean
Turning the CdmBeanItemContainerFactory into a readonly service bean should solve the cascade="all-delete-orphan" pro... Andreas Kohlbecker
02:05 PM Revision 3506344d (cdm-vaadin): changing oder of resource in pom - only cosmetic
Andreas Kohlbecker
01:53 PM Revision f4f3c705 (cdm-vaadin): ref #8160 CdmBeanItemContainerFactory as service bean to load entities only in readyOnly transactions to avoid unintendet flushing
Andreas Kohlbecker
01:50 PM Revision f4e9f32a (cdmlib): ref #6794 fix termType settings in deleteTerms test and clean it up
Andreas Müller
01:49 PM Revision 277ef650 (cdm-vaadin): updating poms for 5.5.2 branch with snapshot versions
jenkins
01:21 PM Revision 64cf9d1d (cdmlib): ref #6794 fix early setting of termType during term loading
Andreas Müller
01:19 PM Revision 320dfcf7 (cdmlib): fix CategoricalDataTest
Andreas Müller
01:19 PM Revision 12aed930 (cdmlib): cleanup
Andreas Müller
12:47 PM bug #8161 (Rejected): *FilterablePagingProvider classes as transactional readonly spring beans
Turing the TaxonNameStringFilterablePagingProvider into a readonly service bean should solve the cascade="all-delete-... Andreas Kohlbecker
12:18 PM Revision 3d7968a9 (taxeditor): ref #8146 Adapt AvailableFeaturesWizard
- temporary disable usage of facet search Patrick Plitzner
11:58 AM Revision 0e1842fc (taxeditor): ref #8124: rename createTaxonNameDescriptionOperation - continue
Katja Luther
11:55 AM Revision 78f2e016 (taxeditor): ref #8124: rename createTaxonNameDescriptionOperation
Katja Luther
11:52 AM task #4600 (New): Investigate and implement tests for security in cdm-vaadin
Andreas Kohlbecker
11:51 AM task #4600 (In Progress): Investigate and implement tests for security in cdm-vaadin
Andreas Kohlbecker
11:47 AM bug #7879: Book CacheStrategy does not show 'place published', 'publisher', 'editor'
Hi Andreas, I am passing this to you since it is a bug in the cache strategy and closely related to #1866 Andreas Kohlbecker
11:39 AM feature request #8124 (Resolved): Activate Name Facts in Taxeditor
please review Katja Luther
11:38 AM Revision 872fe921 (taxeditor): ref #8124: fix add NameDescription with source
Katja Luther
10:16 AM Revision ae31507c (taxeditor): ref #8146 i18n for term drop adapter
Patrick Plitzner
10:12 AM Revision 9bc62cb0 (taxeditor): ref #8124: add deleteTaxonNameDescription operation
Katja Luther
09:56 AM Revision 80d9861f (taxeditor): ref #8146 Check termType in term drop adapter
Patrick Plitzner
08:51 AM Revision de69ffd8 (taxeditor): ref #8146 Restrict "add term wizard" by termType
Patrick Plitzner
08:49 AM Revision 86dbc0fc (cdmlib): ref #6794 Add termType check to DefinedTermBase and TermVocabulary
Patrick Plitzner
07:42 AM task #8159 (New): Replace LocalSelectionTransfer for DnD operations
Using LocalSelectionTransfer is in most cases too generic. It is better to define an own TransferData and assign the ... Patrick Plitzner

03/01/2019

11:05 PM feature request #6794: Improve term structure
Current idea for a solution:
Collections:
* Common base class TermCollection(Base) for all Vocabularies and Graphs ...
Andreas Müller
10:00 PM Revision 217236bc (cdm-vaadin): adapting test to modified number of TaxonRelationshipTypes
Andreas Kohlbecker
08:29 PM Revision 8a8599be (cdmlib): fixing strange error logging in TestingTermInitializer and throwing RuntineException since error is unrecoverable
Andreas Kohlbecker
08:27 PM Revision f178b3fc (cdmlib): moving kindOfUnitTerms from cdm-vaadin:TermsDataSet-ui-registration-with_auditing_info.xml to edit-test:TermsDataSet-with_auditing_info.xml
Andreas Kohlbecker
08:26 PM Revision a4a47802 (cdm-vaadin): moving kindOfUnitTerms from cdm-vaadin:TermsDataSet-ui-registration-with_auditing_info.xml to edit-test:TermsDataSet-with_auditing_info.xml
Andreas Kohlbecker
04:17 PM Revision c693e3b1 (cdmlib): ref #6794 Add generics to FeatureNode and FeatureTree
Patrick Plitzner
04:17 PM Revision 444b9ebc (cdmlib): minor
Patrick Plitzner
04:17 PM Revision 2fe68f38 (taxeditor): ref #6794 Adapt taxeditor to model changes (feature tree/node generics)
Patrick Plitzner
04:15 PM Revision 1f1ad1bc (taxeditor): Fix potential NPE
Patrick Plitzner
04:05 PM bug #8132: phycobank cdm-server instance problems with db connections
It seems as if this problem is being cased by the CdmFilterablePagingProvider which might open an new Sesscion which ... Andreas Kohlbecker
02:46 PM bug #8132: phycobank cdm-server instance problems with db connections
this here https://stackoverflow.com/questions/34408362/c3p0-connection-pool-gives-connection-timeout-error-with-this-... Andreas Kohlbecker
01:58 PM bug #8132: phycobank cdm-server instance problems with db connections
Andreas Kohlbecker wrote:
> I set `testConnectionsOnCheckIn=true` temporarily via jmx in order to test if this helps...
Andreas Kohlbecker
02:58 PM Revision 0e5f1701 (taxeditor): Set LocalSelectionTransfer selection to null after dragging is finished
Patrick Plitzner
11:13 AM task #615 (Closed): remove suns repository
the repository
~~~xml
<!-- sun repository -->
<repository>
<id>java.net</id>
<url>http:...
Andreas Kohlbecker
11:11 AM task #615 (Resolved): remove suns repository
Applied in changeset commit:cdmlib|d402220f823edfb01ec9385d20117d6afee9a77d. Andreas Kohlbecker
11:11 AM Revision d402220f (cdmlib): fix #615 removing unused sun maven repo
Andreas Kohlbecker
11:08 AM Revision 899c5dee (taxeditor): ref #8146 Check term type compatibility for drag and drop
Patrick Plitzner
10:26 AM Revision ba989ecb (cdmlib): ref #6794 Fix termType comparison
Patrick Plitzner
10:17 AM feature request #8150 (Resolved): Allow editing the representation label of characters in details view
Patrick Plitzner
10:16 AM Revision 99742785 (taxeditor): minor refactoring
Patrick Plitzner
10:16 AM Revision adb4cbcf (taxeditor): ref #8150 Allow editing representation label of characters in details
Patrick Plitzner
10:13 AM Revision b5f4e4d3 (taxeditor): Remove unused methods
Patrick Plitzner
07:17 AM bug #8158 (Closed): cascade="all-delete-orphan" problem when ....
I seem to remember that I did the following:
1. RegistrationWorkingsetEditor at http://api.phycobank.org/phycobank...
Andreas Kohlbecker

02/28/2019

09:54 PM feature request #8157 (New): Registration list view: sort registrations by the same order as in the dataportal
newer registrations should come first.
Oder by created when! (agreed)
Andreas Kohlbecker
09:50 PM feature request #8156: Registration items show type status in bold letters
should be easy to implement, thus i am setting the priority to high Andreas Kohlbecker
09:50 PM feature request #8156 (Closed): Registration items show type status in bold letters
The type status in registration items is not easy to see. Making the status bold would improve the readability. Andreas Kohlbecker
09:47 PM feature request #8155 (Feedback): SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
Andreas Kohlbecker
09:47 PM feature request #8155: SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
For how urgent do you consider this feature, Henning? I guess this situation will occur quite frequently? Andreas Kohlbecker
09:42 PM feature request #8155 (Feedback): SpecimenTypeDesignationEditor: allow choosing the typified name from the homotypical group for specific type status
In case of lecto-, epit- and neo-types the SpecimenTypeDesignationEditor should selecting the typified name from the ... Andreas Kohlbecker
05:30 PM bug #7514: Change direct and inverse symbol for pro parte synonym and misapplied name relationship types.
the test page http://int.e-taxonomy.eu/dataportal/integration/reference/cdm_dataportal/taxon/c6716cee-2039-4ba8-a239-... Andreas Kohlbecker
05:24 PM Revision 2ae1c797 (cdm-dataportal): ref #7514 adapting tests to conform to new misapplied name symbols
Andreas Kohlbecker
04:56 PM Revision f8fea9b6 (cdmlib): Fix potential NPE
Patrick Plitzner
04:55 PM Revision 77aef047 (taxeditor): ref #8146 Restrict character matrix to characters
Patrick Plitzner
04:47 PM Revision 983949ab (cdmlib): ref #8153 Fix feature tree type check for distinct features
Patrick Plitzner
04:36 PM Revision d343a6cf (taxeditor): ref #8146 Adapt feature tree editor and move operation to model change
Patrick Plitzner
04:35 PM Revision 62b71512 (taxeditor): ref #8146 Adapt character matrix to termType model change
Patrick Plitzner
04:12 PM bug #8154 (Worksforme): NameController.doGetTaggedName fails due to [UPDATE] not permitted for 'anonymousUser' on Person
http://160.45.63.173:8081/phycobank/name/a2b01d35-fdcf-43fb-8376-f03f195c6e06/taggedName.json
fails every ~4 times...
Andreas Kohlbecker
04:09 PM Revision cb9ebcd2 (cdmlib): ref #8153 Further adapt cdmlib to model changes
- Adjust feature node service to model changes Patrick Plitzner
03:05 PM bug #8152 (Duplicate): ReferencePopupEditor: inReference field allows to select references with type GEN but field validation fails in this case
Henning: References with type 'Generic' must not be in the list, filter only by matching type
So this is a duplica...
Andreas Kohlbecker
01:05 PM bug #8152 (Duplicate): ReferencePopupEditor: inReference field allows to select references with type GEN but field validation fails in this case
Heba reported an error which was due the Journal "Rickia" having the Referencetype 'Generic'
The reference could b...
Andreas Kohlbecker
01:35 PM Revision cc0fa0be (cdmlib): ref #8153 Adapt cdmlib to model changes
- Add constructor for creating a FeatureNode for a given termType
- Adjust feature node service to model changes
Patrick Plitzner
01:30 PM feature request #8153 (Closed): Adapt cdmlib to FeatureNode/FeatureTree model changes
* Since the introduction of term trees with the last model change (5.6.0) `FeatureNode.getFeature()` is deprecated an... Patrick Plitzner
01:24 PM Revision 8619ed30 (taxeditor): minor
Katja Luther
01:22 PM Revision 3e5f990d (cdmlib): ref #8017 cleanup
Andreas Müller
12:57 PM Revision 5400ca5d (taxeditor): revert changes in NaturalLanguageDetail elements
Katja Luther
12:54 PM Revision aac942e0 (cdmlib): Revert "ref #8124: adapt NaturalLanguageGenerator to usage in nameFacts"
This reverts commit c495b39b090fa3af00d870a8ba8171d7300e66a4. Katja Luther
12:45 PM Revision df6e6291 (taxeditor): minor
Patrick Plitzner
12:45 PM Revision 1c59050a (taxeditor): ref #8146 Restrict tree selection in descriptive data set editor
Patrick Plitzner
12:45 PM Revision 4832aaf7 (taxeditor): ref #8146 Add character voc selection in character editor
Patrick Plitzner
12:45 PM Revision b9492486 (taxeditor): ref #8146 Add termType to feature tree composite and selection dialog
Patrick Plitzner
12:45 PM Revision d4cccf9c (taxeditor): ref #8146 Add termType to vocabulary selection dialog
Patrick Plitzner
12:45 PM Revision 47ce5432 (taxeditor): ref #8146 Fix potential class cast exceptions
- replace deprecated FeatureNode.getFeature() with getTerm() Patrick Plitzner
12:43 PM Revision 2a8f0c28 (cdmlib): ref #8124: add new TaxonNameDescriptionDefaultCacheStrategy
Katja Luther
12:16 PM feature request #4611 (New): I18n for the TaxEditor menu
sorry, was a mistake Andreas Müller
12:12 PM feature request #4611 (Resolved): I18n for the TaxEditor menu
Andreas Müller
12:14 PM feature request #8124: Activate Name Facts in Taxeditor
Katja Luther wrote:
> when activating the name facts for the name displayed in the details view, the details view is...
Katja Luther
11:24 AM feature request #8124: Activate Name Facts in Taxeditor
when activating the name facts for the name displayed in the details view, the details view is the selectionProviding... Katja Luther
12:11 PM Revision b6f51ff3 (taxeditor): ref #8124: activate name facts for name in taxon details view
Katja Luther
11:57 AM bug #7107: "Omit level" (TDWG Level2) in distribution hierarchy should not supress distributions source reference
OK Andreas Kohlbecker
11:52 AM bug #7107 (New): "Omit level" (TDWG Level2) in distribution hierarchy should not supress distributions source reference
Ich glaube nicht, dass das für E+M relevant ist, da wir in E+M ja das E+M Voc verwenden, welches keine Omit levels ha... Andreas Müller
11:37 AM bug #7107 (Feedback): "Omit level" (TDWG Level2) in distribution hierarchy should not supress distributions source reference
Hallo Andreas, ich denke das ist auch für Euro+Med releveant, oder?
Wenn ja, sollten wir das Tag hinzufügen und di...
Andreas Kohlbecker
11:57 AM feature request #4610: [DISCUSS] I18n for the EDIT platform
Please do not move unreviewed tickets to Reviewed milestone Andreas Müller
11:50 AM Revision c495b39b (cdmlib): ref #8124: adapt NaturalLanguageGenerator to usage in nameFacts
Katja Luther
11:05 AM bug #8151 (Resolved): after creating a new synonym and pasting a name string the default string is not removed
the call of placeCursor() caused that the cursor was at the end of the "Klicken, um ..." string. Removing this method... Katja Luther
10:58 AM bug #8151 (Closed): after creating a new synonym and pasting a name string the default string is not removed
mail von S. v. M.:
Beim Reinkopieren eines neuen Synonyms blieb der Text “Klicken, um Namen hinzuzufügen” stehen.
...
Katja Luther
10:53 AM Revision ddc5d7b6 (taxeditor): do not call placecursor after creating new synonym
Katja Luther
10:49 AM Revision 52d76872 (taxeditor): ref #8124: adapt editor to be able to edit NameFacts
Katja Luther
09:18 AM Revision a0275f90 (cdmlib): ref #7514 adapt MAN symbol to portal tests (cont.)
Andreas Müller
09:13 AM Revision feef1ad0 (cdmlib): ref #7514 adapt MAN symbol to portal tests
Andreas Müller
08:07 AM feature request #8146: Adapt taxeditor UI to structure and property term type
Add character to term menu with commit:2c98dda6165033a58c7df8c06b21518d380307b3 Patrick Plitzner
07:39 AM Revision 1b28edc1 (taxeditor): ref #8146 Restrict term tree selection by termType
Patrick Plitzner

02/27/2019

05:03 PM Revision 716825dd (cdm-vaadin): minor
Andreas Müller
05:02 PM Revision 68a8023a (cdm-vaadin): ref #3560
Andreas Müller
04:31 PM Revision 2c98dda6 (cdmlib): ref #6618 , ref #8012, ref #3853 add TermType.Character
Andreas Müller
03:52 PM bug #8132: phycobank cdm-server instance problems with db connections
I set `testConnectionsOnCheckIn=true` temporarily via jmx in order to test if this helps avoiding this connectivity p... Andreas Kohlbecker
03:30 PM feature request #8124: Activate Name Facts in Taxeditor
for the name bulk editor the name facts are activated now.
still missing is the activation if name is selected in ...
Katja Luther
03:24 PM Revision 16aed412 (cdmlib): cleanup and MultilanguageText.add(Language, String) added
Andreas Müller
03:11 PM Revision defd0d5c (taxeditor): ref #8146 Restrict term tree selection by termType
Patrick Plitzner
03:10 PM Revision b6d3c69f (cdmlib): ref #8146 Add service method for UuidAndTitleCache by termType for trees
Patrick Plitzner
02:44 PM Revision df0abd11 (cdmlib): ref #8146 Refactor service method
Patrick Plitzner
02:24 PM feature request #8150 (Closed): Allow editing the representation label of characters in details view
Patrick Plitzner
02:21 PM Revision f34f795b (cdmlib): ref #8146 Adapt getEmptyDefinedTermBase() for new term types
Patrick Plitzner
01:56 PM feature request #8136 (In Progress): Implement sources for type designations in TaxEditor
Katja Luther
01:53 PM Revision 89084783 (taxeditor): ref #8136: add reference part for lectotype
Katja Luther
12:10 PM Revision 87934a59 (taxeditor): ref #8136: move sources to supplemental data
Katja Luther
11:08 AM Revision 741b8c90 (taxeditor): fix test
Katja Luther
10:34 AM bug #8149 (Closed): ReferenceEditor: filter inReferences ONLY by applicable reference type suppess Generic and NULL
In reference type = article
Drop down of Journals should only search for entries = journal (not for all references)
...
Wolf-Henning Kusber
10:19 AM bug #8148 (In Progress): Login Dialog cuts off information
Katja Luther
10:18 AM bug #8148 (Resolved): Login Dialog cuts off information
Applied in changeset commit:taxeditor|a08af9f9d2b8840b48fc63b647aca9ee0a34b68c. Katja Luther
09:38 AM bug #8148 (Closed): Login Dialog cuts off information
In the case of an exception and for the advanced section information is not correctly displayed.
![](picture896-1....
Patrick Plitzner
10:18 AM Revision a08af9f9 (taxeditor): fix #8148: fix login dialog problems
Katja Luther
09:34 AM feature request #8147 (Resolved): Add "plural" to representation detail element
Fixed with commit:taxeditor|754fbf873ca0b63addc6842c089298fff76eb30d Patrick Plitzner
08:44 AM feature request #8147 (Closed): Add "plural" to representation detail element
Patrick Plitzner
09:21 AM Revision 24376297 (taxeditor): ref #8142 code refactoring
Patrick Plitzner
09:18 AM Revision 754fbf87 (taxeditor): ref #8142 Add representation plural to details view
Patrick Plitzner
09:04 AM Revision 46b6729e (cdmlib): ref #8142 Add getter/setter for plural
Patrick Plitzner
08:58 AM Revision 18d5bf2c (taxeditor): ref #8147 minor refactoring
Patrick Plitzner
08:55 AM Revision 8f743056 (taxeditor): ref #8147 code cleanup
Patrick Plitzner
08:49 AM Revision 2a743618 (taxeditor): Revert "temporary ignore test for nightly build"
This reverts commit 7fd8d99d2169cbc2614a4de65b090e77d47e939a. Patrick Plitzner
08:48 AM Revision 7fd8d99d (taxeditor): temporary ignore test for nightly build
Patrick Plitzner
08:37 AM feature request #8146 (Closed): Adapt taxeditor UI to structure and property term type
1. ~~Add term editor menu for each~~
1. ~~Restrict tree selection in CharacterEditor~~
1. ~~Restrict context menu,...
Patrick Plitzner

02/26/2019

07:46 PM Revision 5bc58b89 (cdmlib): removing unused private fiels in H2DatabaseType
Andreas Kohlbecker
04:59 PM Revision 84bbc7d1 (cdmlib): cleanup
Andreas Müller
04:57 PM Revision 1634067b (cdmlib): ref #7514 update misapplied name symbols & add tests
Andreas Müller
04:55 PM feature request #3616: Show DescriptionElementBase.timeperiod in Dataportals
Improvements for formatting copied to #8145 Andreas Müller
02:37 PM feature request #3616: Show DescriptionElementBase.timeperiod in Dataportals
Andreas Müller wrote:
> Generally it looks fine.
>
> Only the formatting maybe needs discussion. It differs from...
Andreas Kohlbecker
02:26 PM feature request #3616 (Feedback): Show DescriptionElementBase.timeperiod in Dataportals
Generally it looks fine.
Only the formatting maybe needs discussion. It differs from the default formatting of ti...
Andreas Müller
01:00 PM feature request #3616 (Resolved): Show DescriptionElementBase.timeperiod in Dataportals
Implemented
please review, for the page used by the integration test, please see : http://int.e-taxonomy.eu/datapo...
Andreas Kohlbecker
03:33 PM Revision f37da5d1 (cdm-dataportal): ref #8011 Adapt to cdmlib model change for Pair in DTOs
Patrick Plitzner
03:31 PM Revision c30d94b9 (cdm-vaadin): removing unused xsd files
Andreas Kohlbecker
03:09 PM feature request #8145 (New): Implement TimePeriod DTO with localized formatting
for details see #3616#note-10 ff.
Once implemented we also need to adapt dataportal code to use the new timeperiod...
Andreas Müller
02:57 PM Revision 5760437b (taxeditor): Merge branch 'develop' into termSearch
Patrick Plitzner
02:57 PM Revision 6f5a0cd4 (cdmlib): Merge branch 'develop' into termSearch
Patrick Plitzner
01:58 PM Revision fd2fae75 (taxeditor): fix test in ProgressMonitorServiceTest, extraUser needs to be in group editor
Katja Luther
01:58 PM Revision d7aa17fe (taxeditor): fix test in ProgressMonitorServiceTest, extraUser needs to be in group editor
Katja Luther
01:42 PM task #7356: setup selenium test suite for cdm-vaadin
Adding master thesis on Vaadin TestBench Andreas Kohlbecker
01:25 PM Revision 1938c553 (cdmlib): updated model cache
Katja Luther
12:12 PM feature request #8144: Check if modifiers and modifyingText is handled correctly for description elements in data portals
since modifiers and modifyingText can not be added to the database easily I need to wait until the issue #3836 is com... Andreas Kohlbecker
12:09 PM Revision 940bbcf2 (cdm-dataportal): ref #3616 implementing tests for DescriptionElementBase.timeperiod
Andreas Kohlbecker
11:54 AM Revision 90425089 (cdm-dataportal): ref #3616 implementing display of DescriptionElementBase.timeperiod
Andreas Kohlbecker
11:53 AM Revision d0e8e73c (cdm-dataportal): ref #3616 fixing multibyte character problem related to time periods
Andreas Kohlbecker
11:33 AM Revision 341ee745 (taxeditor): adadpt editor to changes in TypeDesignationBase
Katja Luther
11:10 AM task #8118: Update MySQL drivers
Andreas Müller wrote:
> Starting with MySQL JDBC Driver 5.1.33 serverTimezone needs to be explicitly defined in conn...
Andreas Kohlbecker
12:32 AM Revision 556e3ea7 (cdmlib): minor
Andreas Müller
12:22 AM Revision 038695b2 (cdmlib): fix some compilation issues with generics
Andreas Müller
12:13 AM Revision a2dba78c (cdmlib): cleanup
Andreas Müller
12:11 AM Revision 2d308550 (cdmlib): cleanup
Andreas Müller
 

Also available in: Atom