EDIT

01/17/2019

11:08 PM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> The automated source attachement often does not work or is at least not shown in the details... Katja Luther

09:35 PM task #7854: Open issues in TaxDistributionEditor

Katja Luther wrote:
> Andreas Müller wrote:
> > Katja Luther wrote:
> > > the selection should work now, I missed ... Katja Luther

02:56 PM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> Katja Luther wrote:
> > the selection should work now, I missed to commit the changes in de... Katja Luther

02:33 PM task #7854: Open issues in TaxDistributionEditor

Katja Luther wrote:
> the selection should work now, I missed to commit the changes in details view.
The detail v... Andreas Müller

02:02 PM task #7854: Open issues in TaxDistributionEditor

Katja Luther wrote:
> How long did you work with the distribution editor when the saving did not work anymore?
I ... Andreas Müller

02:02 PM task #7854 (Feedback): Open issues in TaxDistributionEditor

was the status change on purpose? Andreas Müller

10:59 AM task #7854: Open issues in TaxDistributionEditor

How long did you work with the distribution editor when the saving did not work anymore? Katja Luther

10:51 AM task #7854 (In Progress): Open issues in TaxDistributionEditor

the selection should work now, I missed to commit the changes in details view. Katja Luther

09:59 AM task #7854: Open issues in TaxDistributionEditor

... hmm, maybe this was not the original message after save but a bit later and similar Andreas Müller

09:58 AM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> Critical: saving after multiple changes (maybe even of the same cell) seems to crash the app... Andreas Müller

12:40 AM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> Critical: saving after multiple changes (maybe even of the same cell) seems to crash the app... Andreas Müller

12:38 AM task #7854: Open issues in TaxDistributionEditor

... or move it to the top. Needs to be tested what looks better. Andreas Müller

12:31 AM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> Below the row count (element count) there is a lot of empty space. Can this be reduced?
O... Andreas Müller

12:27 AM task #7854: Open issues in TaxDistributionEditor

Critical: saving after multiple changes (maybe even of the same cell) seems to crash the application (no return from ... Andreas Müller

12:25 AM task #7854: Open issues in TaxDistributionEditor

Andreas Müller wrote:
> The dropbox for states opens on top. This leads to a cut of the list which makes it impossib... Andreas Müller

12:22 AM task #7854: Open issues in TaxDistributionEditor

~~The automated source attachement often does not work or is at least not shown in the details view immediately. The ... Andreas Müller

12:15 AM task #7854: Open issues in TaxDistributionEditor

~~Why did you move the buttons for area selection and source selection to the left. I think they look better on the r... Andreas Müller

12:03 AM task #7854: Open issues in TaxDistributionEditor

Not urgent but todo at some time: try to optimize the column width at start or after area selection. Details may be d... Andreas Müller

12:01 AM task #7854: Open issues in TaxDistributionEditor

~~Below the row count (element count) there is a lot of empty space. Can this be reduced?~~
~~Also if possible cha... Andreas Müller

01:56 PM bug #8000: Type of an invalid designation

See display in the data portal: https://www.phycobank.org/cdm_dataportal/registration/http%253A%252F%252Fphycobank.or... Wolf-Henning Kusber

01:50 PM bug #8000 (Feedback): Type of an invalid designation

The type specimen should be displayed sub the valid name only.
Wrong display in Vaadin (see screenshot).
![](pi... Wolf-Henning Kusber

12:54 PM bug #7849 (Resolved): Improve DB Preferences handling and saving in TaxEditor

Can this be reviewed? Andreas Müller

12:49 PM bug #7880: Implement centralized preference default loading strategy

upps, I just see that this ticket is maybe not about this issue, still search for the correct ticket. Andreas Müller

12:45 PM bug #7880: Implement centralized preference default loading strategy

Andreas Müller wrote:
> In DistrEd when having status defined in DBPrefs without allow override after restart of Tax... Andreas Müller

12:31 PM bug #7880: Implement centralized preference default loading strategy

In DistrEd when having status defined in DBPrefs without allow override after restart of TaxEditor (and CDM Server, r... Andreas Müller

12:42 PM bug #7856: Allow local override for distribution vocabularies

Andreas Müller wrote:
> See #7880#note-8 , local override or preference does not yet work fully correct
this is a... Andreas Müller

12:34 PM bug #7856 (Feedback): Allow local override for distribution vocabularies

Andreas Müller

12:33 PM bug #7856: Allow local override for distribution vocabularies

See #7880#note-8 , local override or preference does not yet work fully correct
Andreas Müller

11:29 AM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

> So what about a dialog saying that login was successful but no rights exist for the given user to use the TaxEditor... Andreas Kohlbecker

09:39 AM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

Andreas Kohlbecker wrote:
> > If I try to login into something where I have absolutely no rights I wouldn't expect t... Andreas Müller

11:29 AM bug #7999 (Closed): Allow override does not work correctly for distribution areas

I tested with an empty databases with no CdmPreferences at all. I would expect that the default is, that I can define... Andreas Müller

10:32 AM bug #7998 (Resolved): Store newly created Characters in selected vocabulary

Applied in changeset commit:taxeditor|6df52dba735b4b44f8f78335644dfc8480292b8c. Patrick Plitzner

10:02 AM bug #7998: Store newly created Characters in selected vocabulary

... but better force the user to choose from an existing (semantically defined) vocabulary if possible Andreas Müller

09:27 AM bug #7998 (Closed): Store newly created Characters in selected vocabulary

Characters, just like Features, should be assigned to a vocabulary Patrick Plitzner

09:47 AM feature request #7912 (Resolved): Enhance checkbox tree viewer

To remind me to review. Andreas Müller

09:40 AM feature request #7972 (Resolved): explicitly allow disallow access to HTTP Invoker endpoints (/remoting/**)

Just to remind me to have look how it is implemented. Andreas Müller

08:20 AM bug #7997 (New): Some editor windows do not open at the expected location

Andreas M:
"wenn ich d&d für Features vom Termeditor zum Feature Tree Editor (FTE) verwende, ordne ich gerne die ... Patrick Plitzner

01/16/2019

11:58 PM task #7854: Open issues in TaxDistributionEditor

~~Horizontal scrollbar should appear only if necessary. This is the case only after resize of the part. Should also b... Andreas Müller

11:53 PM task #7854 (Feedback): Open issues in TaxDistributionEditor

**Critical**: ~~often the selected state is not taken over to the cell or into the details view. It simply looks like... Andreas Müller

11:52 PM task #7854: Open issues in TaxDistributionEditor

~~The dropbox for states has a checkbox. As it is only for selecting a single state this does not make sense as it gi... Andreas Müller

11:48 PM task #7854: Open issues in TaxDistributionEditor

Multiple cell selection in table is currently possible. As there is no function related to this we should remove this... Andreas Müller

11:47 PM task #7854: Open issues in TaxDistributionEditor

In preferences translate possible configuration terms "Show IdInVocabulary", ...
Also remove "Show" from all entr... Andreas Müller

11:28 PM task #7854: Open issues in TaxDistributionEditor

The dropbox for states opens on top. This leads to a cut of the list which makes it impossible to choose from the top... Andreas Müller

03:03 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

> If I try to login into something where I have absolutely no rights I wouldn't expect that the login is still succes... Andreas Kohlbecker

02:56 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

Andreas Kohlbecker wrote:
> , but what if the security configuration changes, are you sure that the role `ROLE_REMOT... Andreas Müller

02:53 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

I do not really care about technical details of the implementation. There are multiple possiblities. E.g. we could ad... Andreas Müller

02:37 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

> So I think the ROLE_REMOTING rights should already be checked during authentication and authentication should not b... Andreas Kohlbecker

02:32 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

How should this be possible?
Successful authentication is the required step for having a "user" in the security co... Andreas Kohlbecker

02:02 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

By the way, currently the login is successful but only then the exception is thrown I guess because I do not have adm... Andreas Müller

01:57 PM feature request #7993: Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

This is urgent and should definetely be done in 5.5 Andreas Müller

02:30 PM feature request #6806: Add context menu to FeatureTreeEditor

Except for the above issues the context menu works fine and looks much better and is more consistent with general Tax... Andreas Müller

02:29 PM feature request #6806: Add context menu to FeatureTreeEditor

Andreas Müller wrote:
> Having a move up/down in right click menu would be a nice nice-to-have as d&d is sometimes a... Andreas Müller

02:25 PM feature request #6806: Add context menu to FeatureTreeEditor

Having a move up/down in right click menu would be a nice nice-to-have as d&d is sometimes a bit cumbersome when movi... Andreas Müller

02:22 PM feature request #6806: Add context menu to FeatureTreeEditor

Feature trees should be ordered alphabetically Andreas Müller

02:20 PM feature request #6806: Add context menu to FeatureTreeEditor

Paste not possbile on feature tree Andreas Müller

02:19 PM feature request #6806: Add context menu to FeatureTreeEditor

Andreas Müller wrote:
> ... Also the label should be updated in Details View after focus is set.
and after changi... Andreas Müller

02:18 PM feature request #6806 (Feedback): Add context menu to FeatureTreeEditor

Andreas Müller

02:18 PM feature request #6806: Add context menu to FeatureTreeEditor

Adding a new feature tree should set the focus to the new tree. Also the label should be updated in Details View afte... Andreas Müller

02:16 PM feature request #6806: Add context menu to FeatureTreeEditor

Export menu is disabled on FeatureNodes Andreas Müller

02:21 PM feature request #5474 (Resolved): TermEditor menu should be more structured

Removed separator Patrick Plitzner

01:36 PM bug #7850 (Duplicate): Further problems with term editor

I think these issues have all been fixed by #7887 so I make this ticket a duplicate of #7887. Please change if I am n... Andreas Müller

01:35 PM bug #7850: Further problems with term editor

Andreas Müller wrote:
> Copy from #7827#note-6: The Termeditor has to be refactored as still all term operation are ... Andreas Müller

01:29 PM bug #7933: Adding a new Term to the "Country" vocabulary leads to corrupt data

Can we handle this special case hardcoded until the terms modul is more elaborated?
E.g. by testing if the vocabul... Andreas Müller

01:25 PM bug #6951 (Closed): Drag and drop does not update term hierarchy in the UI

works as expected in the current version Andreas Müller

11:56 AM feature request #7887: Use DTOs in term editor

… und wenn ich einen Term auf Top Level oberhalb eines Vokabulars versuche zu schieben wird er an die letzte Position... Andreas Müller

11:55 AM feature request #7887 (Feedback): Use DTOs in term editor

Ein Problem ... ist, dass wenn ich ein Area mit mind. 1 Kind habe, und dieses Area dann zu einem Kind von sich selbst... Andreas Müller

08:22 AM feature request #7270 (Rejected): Registration message controller implemented

Using redmine as message hub has been rejected, so this issue is no longer relevant- Andreas Kohlbecker

08:19 AM bug #7995 (Resolved): Registration.registrationDate not set when status is set PUBLISHED

There is now a `updateStatusAndDate(RegistrationStatus status)` method in Registration which can be used if needed. T... Andreas Kohlbecker

01/15/2019

05:54 PM bug #7995: Registration.registrationDate not set when status is set PUBLISHED

Andreas Kohlbecker wrote:
> > So I strongly recommend to implement this on application side
>
> So this means imp... Andreas Müller

05:33 PM bug #7995: Registration.registrationDate not set when status is set PUBLISHED

> So I strongly recommend to implement this on application side
So this means implementing it in `cdm-vaadin` and ... Andreas Kohlbecker

05:10 PM bug #7995 (Feedback): Registration.registrationDate not set when status is set PUBLISHED

This is dangerous behaviour. For phycobank it might be correct as we edit the data within the database. However, for ... Andreas Müller

02:39 PM bug #7995 (Resolved): Registration.registrationDate not set when status is set PUBLISHED

Applied in changeset commit:cdmlib|f33a82a7e547ddcd3b084d7a6c53b3920f6db5fc. Andreas Kohlbecker

02:16 PM bug #7995 (Closed): Registration.registrationDate not set when status is set PUBLISHED

The `Registration.registrationDate` should be set to now when the `status` is set to `PUBLISHED`.
When `status` chan... Andreas Kohlbecker

04:58 PM bug #7994: Implement allowDuplicates for term trees in TaxEditor

This is a feature, not a bug in IMO. At least in additivity we allow these structures explicitly for feature trees re... Andreas Müller

12:46 PM bug #7994 (Duplicate): Implement allowDuplicates for term trees in TaxEditor

when adding a feature to a feature tree it is not checked whether the feature tree already contains this feature. Katja Luther

02:07 PM feature request #7978: registration search result ordered by identifier descending

Descending order is partly solved.
Tested with Search=Planothidium
Descending order for 7874-7845 is correct.
De... Wolf-Henning Kusber

01:14 PM bug #7979: Registration date and time, display

can be reviewed once the test server is up to date
Andreas Kohlbecker

01:13 PM bug #7979 (Resolved): Registration date and time, display

Applied in changeset commit:cdmlib|e6044ca78c8161aa67ec0fa788361a9caa079f2a. Andreas Kohlbecker

01:05 PM bug #7979 (In Progress): Registration date and time, display

This happens always when the `Registration.registrationDate` is `null`. The date should also be null in the json resp... Andreas Kohlbecker

01/14/2019

06:03 PM feature request #7972 (Closed): explicitly allow disallow access to HTTP Invoker endpoints (/remoting/**)

Andreas Kohlbecker

06:03 PM feature request #7972 (Resolved): explicitly allow disallow access to HTTP Invoker endpoints (/remoting/**)

Applied in changeset commit:cdmlib|7f87310a8313162080add7230915ed67c0316615. Andreas Kohlbecker

06:02 PM feature request #7993 (Closed): Display "Access Denied" dialog in case the remoting service responds with status code = 4xx

May duplicate #8042
Now that #7972 is implemented a user lacking the role `ROLE_REMOTING` will not be able to use... Andreas Kohlbecker

05:53 PM bug #4821 (Feedback): Changing order of terms not possible

For ordered terms it seems to work now (though there are other issues but they will be handled in another ticket).
... Andreas Müller

05:52 PM bug #7992 (New): GrantedAuthority selection dialog misses to escape regex syntax characters

dialog/widget crashes with the following filter string:
* any string starting with `*`
* `(` or `)`
* `**` at ... Andreas Kohlbecker

05:44 PM bug #7991 (New): GrantedAuthority selection dialog extremly slow

Selecting a GA in the GrantedAuthority selection sends excessive amount of requests to the server and is thus very ... Andreas Kohlbecker

05:18 PM feature request #5474 (Feedback): TermEditor menu should be more structured

The translation of terms will be part of another ticket, "others" is well translated now.
Can we remove the separa... Andreas Müller

05:01 PM bug #5926 (Closed): Update labels in TermEditor for Vocabularies

Yes this works now as expected. Andreas Müller

04:54 PM feature request #6805: Implement drag and drop from Term Editor (Feature) to FeatureTreeEditor

When first d&d a term from term editor and then d&d it within the tree editor the UI is not updated during the second... Andreas Müller

04:48 PM feature request #6805 (Feedback): Implement drag and drop from Term Editor (Feature) to FeatureTreeEditor

Currently dropping is also allowed for other term types, e.g. NamedArea, but after drop a CCE is thrown. We should al... Andreas Müller

04:44 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

Andreas Müller wrote:
> Moving a feature via d&d does not make the Feature Tree Editor dirty. This is critical.
C... Andreas Müller

04:10 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

Maybe we can implement copy&paste also with short cuts and for "Edit" main menu items. Andreas Müller

04:09 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

Andreas Müller wrote:
> Looks like this is not d&d specific. I get the problem very often when simply clicking on fe... Andreas Müller

04:00 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

~~Paste is missing for trees (works for feature nodes)~~ Andreas Müller

03:27 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

Looks like this is not d&d specific. I get the problem very often when simply clicking on features or trees in the fe... Andreas Müller

03:24 PM feature request #7873: Implement copy&paste for feature nodes in feature tree editor

Trying to drag a feature to become a child of a sibbling feature threw "Widget is disposed" exception.
The feature t... Andreas Müller

03:22 PM feature request #7873 (Feedback): Implement copy&paste for feature nodes in feature tree editor

Moving a feature via d&d does not make the Feature Tree Editor dirty. This is critical. Andreas Müller

04:36 PM bug #7990 (Closed): Moving a feature via d&d does not make the Feature Tree Editor dirty

This is because moving feature currently requires prior save and the move operation is handled server side.
As the... Andreas Müller

04:25 PM feature request #7989 (New): Show feature in feature node details view

and make it selectable, but not editable or deletable Patrick Plitzner

03:33 PM feature request #7977: Registration page layout improved

ready for review Andreas Kohlbecker

03:15 PM feature request #7977 (Resolved): Registration page layout improved

Applied in changeset commit:cdm-dataportal|5446f04755aaa27314b111e9d6dc5c2ccdd89211. Andreas Kohlbecker

02:52 PM feature request #7977 (In Progress): Registration page layout improved

Andreas Kohlbecker

03:16 PM feature request #7914 (Closed): Add ISBN to IProceedings

OK, so I think we can close this ticket. Andreas Müller

01:53 PM feature request #7914 (Resolved): Add ISBN to IProceedings

proceedings details view shows isbn now. Katja Luther

01:17 PM feature request #7914: Add ISBN to IProceedings

Katja Luther wrote:
> the javadoc in IWIthISBN says "allowing an authorship" but it should be "allowing an ISBN", sh... Andreas Müller

03:13 PM bug #7985: Remove Print Series from InProceedings, use "Proceedings"

Andreas Müller wrote:
> Sorry, I forgot to mention, that of course the Proceedings search dialog should only show Pr... Andreas Müller

03:05 PM bug #7985 (Feedback): Remove Print Series from InProceedings, use "Proceedings"

Sorry, I forgot to mention, that of course the Proceedings search dialog should only show Proceedings not All referen... Andreas Müller

01:50 PM bug #7985 (Resolved): Remove Print Series from InProceedings, use "Proceedings"

please review Katja Luther

01:25 PM bug #7985 (Closed): Remove Print Series from InProceedings, use "Proceedings"

and save it as in-reference
copied from #7918: InProceedings - Series: Correct, that this is not needed. Also it i... Andreas Müller

02:59 PM bug #7737 (Feedback): Reference Details view does NOT give a multiple usage warning

This looks better. Only the space between top label and warning is still a bit large. If this can still be reduced it... Andreas Müller

11:24 AM bug #7737 (Resolved): Reference Details view does NOT give a multiple usage warning

Applied in changeset commit:taxeditor|cc1670975fe9c7d911ba8878460a489cbd3c9d10. Katja Luther

11:14 AM bug #7737 (Feedback): Reference Details view does NOT give a multiple usage warning

Andreas Müller

11:14 AM bug #7737: Reference Details view does NOT give a multiple usage warning

This works as expected and can be closed.
Only the layout can be improved. There is too much space between the top l... Andreas Müller

02:10 PM bug #7988 (New): Correct formatting and parsing of Reference.editor

Currently the "editor" field is not really used for parsing and formatting and also in TaxEditor.
Copied form #791... Andreas Müller

02:09 PM task #7987 (New): [DISUCSS] Do we need an editor in Reference linking to TeamOrPersonBase

Advantage correct formatting in deduplication. However, some more complex "editors" will be more difficult to handle.... Andreas Müller

01:48 PM task #7918: Revision of reference type specific properties

Andreas Kohlbecker wrote:
> this should be complete now except of the fact that ISection inherits datePublished from... Andreas Müller

01:45 PM task #7918 (Resolved): Revision of reference type specific properties

Generally this ticket is fixed or open issues are moved to explicit tickets. See my comments on referencing tickets i... Andreas Müller

01:39 PM task #7986 (New): Let eu.etaxonomy.cdm.model.reference.ReferencePropertyDefinitions use Reference interfaces

... to avoid redundant and difficult to maintain code. Only exceptions may be handled manually.
for discussion see... Andreas Müller

01:11 PM task #7984 (New): Remove URI from Reference

leave it only for ref type WebSite and maybe Database and Generic(?).
General links to representations of a refere... Andreas Müller

01:07 PM task #7983 (New): [DISCUSS] Do we need multiple ISBN per reference

... also discuss ISBN for e-pre-publications
copied from #7918 "correct handling of multiple ISBN definetly needs ... Andreas Müller

11:54 AM bug #7877 (Closed): Form elements disappear in reference dialog after changing the reference type

Works as expected Andreas Müller

11:52 AM bug #7913 (Closed): Remove authorship from IJournal and IPrintSeries

works as expected Andreas Müller

11:34 AM bug #7915 (Closed): Remove date published from journals and print series

Works as expected Andreas Müller

11:26 AM feature request #7982 (New): [Rule] Validate correct usage of reference attributes for reference types.

Few rules already exist in ReferenceCheckValidator but there exist much more. Check against Reference interfaces in e... Andreas Müller

11:08 AM feature request #7931 (Closed): add symbol2 to term detailsview

Katja Luther

10:50 AM feature request #7931 (Resolved): add symbol2 to term detailsview

Applied in changeset commit:taxeditor|b5c5ca695d8be72e3d5a8d7238baef51cf006277. Katja Luther

10:43 AM feature request #7931 (Feedback): add symbol2 to term detailsview

can relabel it to "Symbol 2" or "2nd symbol". The current label is a bit long and it is not immediately obvious that ... Andreas Müller

10:48 AM bug #7930 (Closed): Remove DOI from journals, print series and person communications

Works as expected. Andreas Müller

10:42 AM feature request #7981 (Closed): Add configuration UI for matrix description aggregation

Allow configuration for running the aggregation
* ~~Ignore/consider default descriptions, literature and publishe... Patrick Plitzner

10:40 AM feature request #7980 (Closed): Enhance matrix description aggregation

Make aggregation configurable:
- ~~Consider literature values during aggregation~~ #9795
- Consider default val... Patrick Plitzner

01/11/2019

06:08 PM bug #7979: Registration date and time, display

Corrected description: Test and Production portal:
Registration date and registration time displays the system ti... Wolf-Henning Kusber

05:54 PM bug #7979 (Closed): Registration date and time, display

Test porta: Registration date is fine,
but registration time displays the system time of the computer.
Registrat... Wolf-Henning Kusber

03:47 PM feature request #7978: registration search result ordered by identifier descending

please review once the test server is updated Andreas Kohlbecker

03:46 PM feature request #7978 (Resolved): registration search result ordered by identifier descending

Applied in changeset commit:cdmlib|5e1fc3d850d7b149f2c831c4430e15172b3e33e6. Andreas Kohlbecker

03:44 PM feature request #7978: registration search result ordered by identifier descending

this needs to be changed in the remote controller Andreas Kohlbecker

03:09 PM feature request #7978 (In Progress): registration search result ordered by identifier descending

Andreas Kohlbecker

03:08 PM feature request #7978 (Closed): registration search result ordered by identifier descending

The default sort order of the registration search results should be inverted.
Andreas Kohlbecker

03:20 PM bug #7880 (Resolved): Implement centralized preference default loading strategy

Andreas Müller

03:00 PM bug #7880 (Closed): Implement centralized preference default loading strategy

The search option are now all enabled with preferences cleared.
Patrick Plitzner

03:17 PM task #7976: [PESI][ERMS] Erms taxon import

699 accepted taxa (acctaxon = id) do have a parent which is not accepted. 2/3 of the parents has status synonym, 1/3 ... Andreas Müller

09:27 AM task #7976: [PESI][ERMS] Erms taxon import

Errors in Data:
* Name inheritance:
Some (63) children differ in first name part from parent. Sometimes this... Andreas Müller

09:25 AM task #7976: [PESI][ERMS] Erms taxon import

Parents are generally nomenclatural parents not taxonomical parents. There are different parent types (this is not re... Andreas Müller

03:07 PM feature request #7912: Enhance checkbox tree viewer

Katja Luther wrote:
> this seems to work, but the checkboxes are not grayed when a child or some children are select... Patrick Plitzner

03:04 PM feature request #7977 (Closed): Registration page layout improved

The layout of the registration needs to be rendered according to the following scheme:
~~~
if reg has name
pri... Andreas Kohlbecker

01:04 PM feature request #7871 (Resolved): Open character matrix as singleton

Now the data set editor also only opens as singleton Patrick Plitzner

09:04 AM feature request #7802 (Duplicate): Portal-Info when an http-identifier "in preparation" is requested

this is a duplicate of #7927 Andreas Kohlbecker

09:01 AM bug #7564 (Closed): remove Phycobank - Registration data - block and other outdated registration code

completetd Andreas Kohlbecker

08:57 AM bug #7564 (Resolved): remove Phycobank - Registration data - block and other outdated registration code

Applied in changeset commit:cdm-dataportal|59b740d03c738972b33f07b017c6576c03cbd5a3. Andreas Kohlbecker

08:53 AM bug #7564 (In Progress): remove Phycobank - Registration data - block and other outdated registration code

Andreas Kohlbecker

01/10/2019

02:44 PM task #7976 (Closed): [PESI][ERMS] Erms taxon import

Subticket for #1444:
The taxon import in ERMS is the most complex one therefore we open a new ticket for it.
Ki... Andreas Müller

12:59 PM feature request #7947 (Resolved): registration page shows name relations

Wolf-Henning Kusber wrote:
> Check in production and test portal, please try these examples. There is no taxonomic r... Andreas Kohlbecker

12:58 PM feature request #7975 (Closed): Implement a block to display name relations

Currently all name relations are displayed as if they where homonyms (non ... nec ...)
Bei Basionym und replaced s... Andreas Kohlbecker

01/09/2019

05:06 PM feature request #7927 (Closed): Registration not found, Portal handling registrations in preparation

Andreas Kohlbecker

05:05 PM feature request #7927: Registration not found, Portal handling registrations in preparation

Wolf-Henning Kusber wrote:
> All given examples are working well (cross check with Vaadin), but...
>
> If a non e... Andreas Kohlbecker

05:05 PM feature request #7927: Registration not found, Portal handling registrations in preparation

The treatment of not-existing registration numbers is fine with me. The ticket can be closed. Wolf-Henning Kusber

04:53 PM feature request #7927: Registration not found, Portal handling registrations in preparation

All given examples are working well (cross check with Vaadin), but...
If a non existing number is chosen/typed in ... Wolf-Henning Kusber

04:27 PM feature request #7927: Registration not found, Portal handling registrations in preparation

You can use the following URLs for testing:
* http://test.e-taxonomy.eu/dataportal/preview/phycobank/cdm_dataporta... Andreas Kohlbecker

04:38 PM bug #7973 (Duplicate): Pages not shown in portal if no digit?

this is a duplicate of #4644
until this issue is fixed text which starts and ends with brakets can not be used. So... Andreas Kohlbecker

02:51 PM bug #7973 (Duplicate): Pages not shown in portal if no digit?

https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25
example with
Pages not s... Wolf-Henning Kusber

04:34 PM bug #7974 (Closed): Layout for Registration date

done Andreas Kohlbecker

04:33 PM bug #7974 (Resolved): Layout for Registration date

Applied in changeset commit:cdm-dataportal|e35d5a7c85f9bf2c029a33c79df501cdf3a856ab. Andreas Kohlbecker

03:06 PM bug #7974 (Closed): Layout for Registration date

https://www.phycobank.org/cdm_dataportal/reference/400a1bcb-f8c3-43e4-833e-3b8d25a7ed25
Layout for Registration da... Wolf-Henning Kusber

03:43 PM feature request #7903 (Resolved): Add treeIndex with rank to cdm light export

now there is an implementation for creating a sortindex at the end of the export on the basis of a map containing a l... Katja Luther

12:37 PM feature request #7972 (In Progress): explicitly allow disallow access to HTTP Invoker endpoints (/remoting/**)

The edit team agreed that introducing the positive role `ROLE_REMOTING` would be be preferred solution.
The new Ro... Andreas Kohlbecker

10:37 AM feature request #7972 (Resolved): explicitly allow disallow access to HTTP Invoker endpoints (/remoting/**)

Users can always see any data in the Taxeditor, this can be problematic for projects in which private data must not b... Andreas Kohlbecker

12:29 PM bug #7907: Annotations in Reference page do not respect the annotation settings

done! Andreas Kohlbecker

12:29 PM bug #7907 (Resolved): Annotations in Reference page do not respect the annotation settings

Applied in changeset commit:cdm-dataportal|7370f4f72901075e33e80a29d6d079561332b2b3. Andreas Kohlbecker

11:55 AM task #7811 (Resolved): Import higher classifications

Andreas Kohlbecker

10:22 AM bug #7616 (Closed): reference page: show name types

Andreas Kohlbecker

09:48 AM bug #7616: reference page: show name types

Review: issue solved, ticket can be closed. Wolf-Henning Kusber

01/08/2019

07:22 PM task #7811: Import higher classifications

The Excel file is finished for a test import.
May be there are minor issues (duplicates etc.)
The file includes 3... Wolf-Henning Kusber

07:06 PM task #7811: Import higher classifications

related to #7948 Wolf-Henning Kusber

06:05 PM bug #7616: reference page: show name types

issue solved, please review Andreas Kohlbecker

06:03 PM bug #7616 (Resolved): reference page: show name types

Applied in changeset commit:cdm-dataportal|471192e3238b576b994504685df72e8de1e85374. Andreas Kohlbecker

04:40 PM bug #7616 (In Progress): reference page: show name types

Andreas Kohlbecker

04:26 PM feature request #7927: Registration not found, Portal handling registrations in preparation

ready, please review. Andreas Kohlbecker

04:25 PM feature request #7927 (Resolved): Registration not found, Portal handling registrations in preparation

Applied in changeset commit:cdm-dataportal|1e7459da9a060990ee80a817782e997aa410beb8. Andreas Kohlbecker

11:53 AM report #7971: Curator can see preparations in submitter's RegistrationWorkingSets

Curator has to be discret with respect to unpublished data. Wolf-Henning Kusber

10:44 AM report #7971: Curator can see preparations in submitter's RegistrationWorkingSets

For my understanding the curator is only allowed to see registrations, released by any submitter by selecting "curati... Wolf-Henning Kusber

10:40 AM report #7971 (Feedback): Curator can see preparations in submitter's RegistrationWorkingSets

I cant't see why this is an issue. From my understanding curators can always see all registrations Andreas Kohlbecker

10:38 AM report #7971 (Closed): Curator can see preparations in submitter's RegistrationWorkingSets

Curator see/has access to registrations, marked as "ready": fine.
Curator see/has access to registrations, prepared ... Wolf-Henning Kusber

10:38 AM bug #7833 (Closed): submitters can access see any registration in any RegistrationWorkingSet

Andreas Kohlbecker

10:34 AM bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Review: Submitter cannot see entries of other submitters. Security problem solved. Wolf-Henning Kusber

01/07/2019

06:28 PM feature request #7947: registration page shows name relations

Check in production and test portal, please try these examples. There is no taxonomic relation entered.
IAPT-data:... Wolf-Henning Kusber

05:35 PM feature request #7947 (Feedback): registration page shows name relations

this has already been implemented. Are there any issues with the implementations any registrations for which the name... Andreas Kohlbecker

03:39 PM feature request #7793: Master ticket for E+M editor issues

Andreas Müller wrote:
> Change "Use checklist perspective" seems to change local settings. Once this is set to true ... Katja Luther

03:27 PM feature request #7793: Master ticket for E+M editor issues

Andreas Müller wrote:
> >DB preference to make all functionality related to multiple classification and reuse taxon ... Katja Luther

03:09 PM bug #7833 (Resolved): submitters can access see any registration in any RegistrationWorkingSet

Wolf-Henning Kusber wrote:
> Submitter can currently view/update unpublished references and datasets entered by the ... Andreas Kohlbecker

02:41 PM feature request #7914 (Feedback): Add ISBN to IProceedings

the javadoc in IWIthISBN says "allowing an authorship" but it should be "allowing an ISBN", shouldn't it? Katja Luther

02:33 PM feature request #7871 (Feedback): Open character matrix as singleton

this works fine, but maybe we should also do the same for the descriptive data set editor? Katja Luther

02:30 PM feature request #7901 (Closed): Make PreferencePredicates an interface to allow multiple implementations (e.g. for client apps, for grouping, for data type specific instances, etc.)

this works fine and is already used in taxeditor Katja Luther

02:29 PM bug #7939 (Resolved): TaxonNodeDTO need sortIndex of Rank

please review Katja Luther

02:01 PM feature request #7970 (New): Default Feature Tree Preference

The Default Feature Tree Preference page is not really intuitive. If you set the selection to one of the feature tree... Katja Luther

01:41 PM bug #7969 (New): Default Feature Tree created on serverside contains only one featureNode but this is used in a loop

When the taxeditor loads the default feature tree with an uuid but the table is empty or the uuid is the uuid of the ... Katja Luther

12/21/2018

08:27 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Submitter can currently view/update unpublished references and datasets entered by the curator or a. Wolf-Henning Kusber

05:37 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Issue solved, please review. Andreas Kohlbecker

05:37 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Wolf-Henning Kusber wrote:
> Unpublished references must be hidden from the select in the "New Registration" makes s... Andreas Kohlbecker

05:43 PM feature request #7968 (Closed): ReferenceEditor: optional validation for completenes of Partial values in datePublished

As consequence of the way #7833 was solved (see `RegistrationWorkingSetService.checkReferencePublished(Reference refe... Andreas Kohlbecker

10:34 AM task #7964: Name and orthographic variant - were to link types

As a basis for discussion:
A given name must be available (selectable) for new Working sets.
That means: if an in... Wolf-Henning Kusber

08:16 AM task #7967 (New): AnnotationBasedAccessControlBean to implement ViewAccessControl

AnnotationBasedAccessControlBean should implement ViewAccessControl since the view class and its annotations can be a... Andreas Kohlbecker

12/20/2018

04:57 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet

Unpublished references must be hidden from the select in the "New Registration" makes sense.
Question (2): creator =... Wolf-Henning Kusber

04:23 PM bug #7833 (Feedback): submitters can access see any registration in any RegistrationWorkingSet

Hallo Henning,
ich denke dieses Ticket sollten wir unbedingt noch lösen bevor wir externe Submitter zulassen.
A... Andreas Kohlbecker

04:34 PM task #7964: Name and orthographic variant - were to link types

Currently, I can link types to both names (see screen shot, by the way, I put in 1234 as number before the page was u... Wolf-Henning Kusber

04:04 PM task #7964 (Feedback): Name and orthographic variant - were to link types

Andreas Kohlbecker

04:03 PM task #7964: Name and orthographic variant - were to link types

once a name is known to be incorrect (has a name relation to the correcting name) it should no longer possible to
... Andreas Kohlbecker

02:32 PM task #7964 (Feedback): Name and orthographic variant - were to link types

Types can be linked to the corrected name or to the incorrect name (as published).
There are arguments to link a ... Wolf-Henning Kusber

04:25 PM bug #7897 (Duplicate): TeamOrPersonField: BindException: The given field is not part of this FieldBinder

this looks like a duplicate of #7867 Andreas Kohlbecker

04:19 PM bug #7956 (Closed): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

solved Andreas Kohlbecker

04:19 PM bug #7956 (Resolved): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

Applied in changeset commit:cdm-vaadin|6e995b1e3d57b22f0dbd925955d647fea233a985. Andreas Kohlbecker

04:14 PM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

"unranked" is fine as long it points to an uninominal. Wolf-Henning Kusber

03:54 PM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

Why is it "unknown rank" and not "unranked". The other vague rank terms are labled "unranked infraspecific" and "unr... Andreas Kohlbecker

11:31 AM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks

"unknown rank" as uninominal might be important. The others are not in use and not expected to use. Wolf-Henning Kusber

08:25 AM bug #7963 (Feedback): TaxonNamePopEditor: name part field visibility not correct for all ranks

is there a rank which is highly relevant for phycobank for which this issue needs to be fixed immediately? Andreas Kohlbecker

08:24 AM bug #7963 (Closed): TaxonNamePopEditor: name part field visibility not correct for all ranks

[henning]
I checked the complete list. With some ranks (mostly not relevant for PhycoBank, I have problems).
"s... Andreas Kohlbecker

04:11 PM feature request #7966 (Closed): Registration search simplify type select options

The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker

04:11 PM feature request #7965 (Closed): Registration search simplify type select options

The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker

03:45 PM bug #7481 (Resolved): ReferenceEditor: filter inReferences by applicable reference type

Andreas Kohlbecker

03:44 PM bug #7481: ReferenceEditor: filter inReferences by applicable reference type

validator added
ready for reviewing Andreas Kohlbecker

11:01 AM bug #7481: ReferenceEditor: filter inReferences by applicable reference type

Wolf-Henning Kusber wrote:
> Two comments
>
> AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
... Andreas Kohlbecker

10:50 AM bug #7481: ReferenceEditor: filter inReferences by applicable reference type

Two comments
AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
W-H.K.: missing: inProceedings |... Wolf-Henning Kusber

09:30 AM bug #7481 (Feedback): ReferenceEditor: filter inReferences by applicable reference type

Hi Henning, do you agree with the constraints as mentioned in the issue description? Anything missing? Andreas Kohlbecker

03:19 PM bug #7941: Deduplication does not work in new taxon dialog

this should be fixed with the changing the parsing method to the same as in name editor. please review. Katja Luther

03:18 PM bug #7941 (Resolved): Deduplication does not work in new taxon dialog

Applied in changeset commit:taxeditor|2e5addbf1470b86b929e7e4ca4fc0f0eebb291f6. Katja Luther

03:16 PM bug #7940 (Feedback): "New" menu in navigator not available for certain users

I can't reproduce this, did you changed the rights of the user? Katja Luther

02:29 PM feature request #7718 (Closed): New Registration: Exclude irrelevant reference types from list of existing publications

Andreas Kohlbecker

02:13 PM feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications

The reference types Section, PrintSeries and Journal have been excluded from the options. Ticket can be closed. Wolf-Henning Kusber

02:14 PM bug #7950: ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

Solved!
Should be tested in IE / Edge also
Andreas Kohlbecker

02:13 PM bug #7950 (Resolved): ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over

Applied in changeset commit:cdm-vaadin|403a0ebd2e7160ce26171894195e6a362f9048bd. Andreas Kohlbecker

02:06 PM bug #7880 (Resolved): Implement centralized preference default loading strategy

this should be fixed. please review. Katja Luther

12:50 PM bug #7639 (Closed): SpecimenTypeDesignationEditor: Altitude not saved and displayed properly

Andreas Kohlbecker

11:59 AM bug #7639: SpecimenTypeDesignationEditor: Altitude not saved and displayed properly

Altitude
200,5 is given as 200
2.5 or 2,5 is given as 2
Because altitudes can not be that exact this is okay wit... Wolf-Henning Kusber

11:59 AM feature request #7954 (Closed): protected vs. unproteced caches in TaxEditor

Katja Luther

10:18 AM feature request #7954: protected vs. unproteced caches in TaxEditor

The tooltip text for the button explains the functionality exactly for users.
Even though, I saw the German transla... Wolf-Henning Kusber

09:38 AM feature request #7954: protected vs. unproteced caches in TaxEditor

There is a tooltip for the button now. Please have a look if this clearify the usage of the lock.
Katja Luther

09:34 AM feature request #7954 (Resolved): protected vs. unproteced caches in TaxEditor

Applied in changeset commit:taxeditor|c42c4e417e482b08177318c7d155f58c314c8206. Katja Luther

11:58 AM bug #7856 (Resolved): Allow local override for distribution vocabularies

now it is possible to override the available vocabularies for the distribution editor.please review Katja Luther

11:55 AM feature request #7218 (Closed): SpecimenTypedesignationsWorkingsetEditor: support for Reference system

Wolf-Henning Kusber wrote:
> good: WGS84 can be selected.
>
> not so good: other possible systems can not be sele... Andreas Kohlbecker

11:44 AM feature request #7218 (Feedback): SpecimenTypedesignationsWorkingsetEditor: support for Reference system

good: WGS84 can be selected.
not so good: other possible systems can not be selected (I do not need them).
not ... Wolf-Henning Kusber

10:45 AM feature request #7912 (Feedback): Enhance checkbox tree viewer

this seems to work, but the checkboxes are not grayed when a child or some children are selected. Katja Luther

10:35 AM bug #7929 (Closed): after delete of not persisted object in bulkeditor the object is still in bulkeditor list

seems to work Patrick Plitzner

10:23 AM bug #7929 (Resolved): after delete of not persisted object in bulkeditor the object is still in bulkeditor list

Katja Luther

10:23 AM bug #7929: after delete of not persisted object in bulkeditor the object is still in bulkeditor list

please review Katja Luther

10:20 AM bug #7934 (Closed): sometimes the signs for deduplication are not shown

works fine now. Katja Luther

10:16 AM bug #7649 (Closed): Term editor loads/saves extremely slow

this is fixed with #7887 Katja Luther

10:16 AM feature request #7887 (Closed): Use DTOs in term editor

after creating a new namedArea the deletion does not work because it is referenced by its parent. This is fixed with ... Katja Luther

07:57 AM bug #7878 (Closed): Edit CollectionCode not saved

Andreas Kohlbecker

07:56 AM task #7846 (Feedback): PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

DTO is an acronym for Data Transfer Object. The *DTO labels should be transformes into something more user friendly o... Andreas Kohlbecker

07:54 AM bug #7962 (Closed): PopupEditors: *DTO in context 'breadcrumbs' to be transformed into more humane labels

see #7846#note-4 Andreas Kohlbecker

12/19/2018

08:11 PM task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

What is "SpecimenTypeDesignationWorkingSetDTO" DTO? Wolf-Henning Kusber

07:52 PM task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.

Tested for a new infraspecific name with new genus with new reference and new species epithet with new article in new... Wolf-Henning Kusber

08:09 PM bug #7878: Edit CollectionCode not saved

Works.
New feature "is part of" is helfull.
I took an entry "Code only" Edit Instute name "Institute of Botany" a... Wolf-Henning Kusber

07:38 PM bug #7944: TaxonNamePopEditor: name part fields are required

Review:
I agree, that this is needed for data integrity, but I think this will slow down data entry by users and cu... Wolf-Henning Kusber

06:44 PM feature request #7899: enable orthographic name correction in Vaadin

label: what about the following label wording?
header: orthographical variant
above the cache: incorrect name (= ... Wolf-Henning Kusber

05:36 PM feature request #7899: enable orthographic name correction in Vaadin

Comment on #15
according to the latest discussion, which is based on research in the ICBN, we came to the conclusi... Wolf-Henning Kusber

05:10 PM feature request #7899 (Resolved): enable orthographic name correction in Vaadin

please review Andreas Kohlbecker

05:00 PM feature request #7899: enable orthographic name correction in Vaadin

according to the latest discussion, which is based on research in the ICBN, we came to the conclusion that `ORTHOGRAP... Andreas Kohlbecker

03:20 PM feature request #7899 (In Progress): enable orthographic name correction in Vaadin

After a discussion with Andreas Müller, the improved concept from 2018-12-11 has been revised and changed again:
1... Andreas Kohlbecker

06:14 PM task #7935 (In Progress): Discuss new solution to establish the communication between submitter and curator

Andreas Kohlbecker

05:39 PM feature request #7954: protected vs. unproteced caches in TaxEditor

Ich finde Hennings Vorschlag prima, denn wirklich intuitiv verstädlich sind diese Schloß-Icons auch für mich nie gewe... Andreas Kohlbecker

05:08 PM task #7961 (New): Consider removal of the TaxonNamePopupEditorMode ORTHOGRAPHIC_CORRECTION

As of the latest discussion regarding the semantic of `NameRelationshipType.ORTHOGRAPHIC_VARIANT()` (#7899#note-15) i... Andreas Kohlbecker

04:51 PM task #7960 (New): Revision of NameRelationshipTypes

While working on #7899 a discussion on the semantics of the NameRelationshipTypes `ORTHOGRAPHIC_VARIANT` and `MISSPEL... Andreas Kohlbecker

04:45 PM bug #7951 (Closed): Reference Combobox option titles can be too long causing the select box to extend too much

Andreas Kohlbecker

04:32 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much

This obviously comes from the vaadin combobox, the width of the div containing the table is set too wide:
~~~html
... Andreas Kohlbecker

04:22 PM bug #7951 (In Progress): Reference Combobox option titles can be too long causing the select box to extend too much

The data problems pointed out in comment 16 are not really relevant for this issue.
But there is still one situat... Andreas Kohlbecker

04:45 PM bug #7959: LazyCombobox popup over sizing problem

This is most probably a vaadin probelm, either in vaddin itself or in the viritin addon Andreas Kohlbecker

04:43 PM bug #7959 (Rejected): LazyCombobox popup over sizing problem

see #7951#note-18 Andreas Kohlbecker

02:04 PM feature request #7063 (Resolved): Improve the area selection wizard for distribution editor

I think this is solved with #7887.
Now the items in the tree have three states and it is possible to select and de... Katja Luther

12:05 PM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

So this supports my thesis. Andreas Kohlbecker

10:31 AM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

No reload, but open name again to look up if the not displayed data have been databased. Not sure if save or cancle w... Wolf-Henning Kusber

10:25 AM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor

This seems to be an update problem with the workingset. Didi you try a reload of the page after saving the editor, I ... Andreas Kohlbecker