Project

General

Profile

Activity

From 12/10/2018 to 01/08/2019

01/08/2019

07:22 PM task #7811: Import higher classifications
The Excel file is finished for a test import.
May be there are minor issues (duplicates etc.)
The file includes 3...
Wolf-Henning Kusber
07:06 PM task #7811: Import higher classifications
related to #7948 Wolf-Henning Kusber
06:05 PM bug #7616: reference page: show name types
issue solved, please review Andreas Kohlbecker
06:03 PM bug #7616 (Resolved): reference page: show name types
Applied in changeset commit:cdm-dataportal|471192e3238b576b994504685df72e8de1e85374. Andreas Kohlbecker
04:40 PM bug #7616 (In Progress): reference page: show name types
Andreas Kohlbecker
06:03 PM Revision 471192e3 (cdm-dataportal): fix #7616 implementing display of name type designations for the reference page
Andreas Kohlbecker
04:33 PM Revision 274b83d6 (cdmlib-apps): minor typo
Andreas Müller
04:26 PM feature request #7927: Registration not found, Portal handling registrations in preparation
ready, please review. Andreas Kohlbecker
04:25 PM feature request #7927 (Resolved): Registration not found, Portal handling registrations in preparation
Applied in changeset commit:cdm-dataportal|1e7459da9a060990ee80a817782e997aa410beb8. Andreas Kohlbecker
04:25 PM Revision 1e7459da (cdm-dataportal): fix #7927 showing status of not published registrations
Andreas Kohlbecker
04:24 PM Revision ebbad310 (cdmlib): ref #7927 /registration/identifier/**/status web service implemented
Andreas Kohlbecker
11:53 AM report #7971: Curator can see preparations in submitter's RegistrationWorkingSets
Curator has to be discret with respect to unpublished data. Wolf-Henning Kusber
10:44 AM report #7971: Curator can see preparations in submitter's RegistrationWorkingSets
For my understanding the curator is only allowed to see registrations, released by any submitter by selecting "curati... Wolf-Henning Kusber
10:40 AM report #7971 (Feedback): Curator can see preparations in submitter's RegistrationWorkingSets
I cant't see why this is an issue. From my understanding curators can always see all registrations Andreas Kohlbecker
10:38 AM report #7971 (Closed): Curator can see preparations in submitter's RegistrationWorkingSets
Curator see/has access to registrations, marked as "ready": fine.
Curator see/has access to registrations, prepared ...
Wolf-Henning Kusber
10:38 AM bug #7833 (Closed): submitters can access see any registration in any RegistrationWorkingSet
Andreas Kohlbecker
10:34 AM bug #7833: submitters can access see any registration in any RegistrationWorkingSet
Review: Submitter cannot see entries of other submitters. Security problem solved. Wolf-Henning Kusber
09:37 AM Revision 086d2a44 (cdmlib): fix exception if biocase provider is not available
Katja Luther

01/07/2019

06:28 PM feature request #7947: registration page shows name relations
Check in production and test portal, please try these examples. There is no taxonomic relation entered.
IAPT-data:...
Wolf-Henning Kusber
05:35 PM feature request #7947 (Feedback): registration page shows name relations
this has already been implemented. Are there any issues with the implementations any registrations for which the name... Andreas Kohlbecker
05:06 PM Revision 8cba0a5f (cdm-dataportal): ref #7599 updating compose_specimen_table() after renaming of render_cdm_specimenDTO_page()
Andreas Kohlbecker
04:20 PM Revision 34a67c62 (cdm-dataportal): typo in comment
Andreas Kohlbecker
03:39 PM feature request #7793: Master ticket for E+M editor issues
Andreas Müller wrote:
> Change "Use checklist perspective" seems to change local settings. Once this is set to true ...
Katja Luther
03:27 PM feature request #7793: Master ticket for E+M editor issues
Andreas Müller wrote:
> >DB preference to make all functionality related to multiple classification and reuse taxon ...
Katja Luther
03:39 PM Revision 1f351807 (taxeditor): ref #7793: update perspective when changing db
Katja Luther
03:29 PM Revision 332bd217 (taxeditor): ref #7793: remove classification and reuse taxon in new taxon wizard
Katja Luther
03:26 PM Revision 1731b6d1 (taxeditor): ref #7793: remove classification and reuse taxon in new taxon wizard
Katja Luther
03:09 PM bug #7833 (Resolved): submitters can access see any registration in any RegistrationWorkingSet
Wolf-Henning Kusber wrote:
> Submitter can currently view/update unpublished references and datasets entered by the ...
Andreas Kohlbecker
03:07 PM Revision 943dcf96 (cdmlib): ref #7833 adding missing check for anonymous authentication tokens to CdmUserHelper
Andreas Kohlbecker
03:07 PM Revision 51cc6f53 (cdmlib): ref #7833 permission checking in RegistrationWorkingSetService
Andreas Kohlbecker
02:41 PM feature request #7914 (Feedback): Add ISBN to IProceedings
the javadoc in IWIthISBN says "allowing an authorship" but it should be "allowing an ISBN", shouldn't it? Katja Luther
02:33 PM feature request #7871 (Feedback): Open character matrix as singleton
this works fine, but maybe we should also do the same for the descriptive data set editor? Katja Luther
02:30 PM feature request #7901 (Closed): Make PreferencePredicates an interface to allow multiple implementations (e.g. for client apps, for grouping, for data type specific instances, etc.)
this works fine and is already used in taxeditor Katja Luther
02:29 PM bug #7939 (Resolved): TaxonNodeDTO need sortIndex of Rank
please review Katja Luther
02:01 PM feature request #7970 (New): Default Feature Tree Preference
The Default Feature Tree Preference page is not really intuitive. If you set the selection to one of the feature tree... Katja Luther
01:41 PM bug #7969 (New): Default Feature Tree created on serverside contains only one featureNode but this is used in a loop
When the taxeditor loads the default feature tree with an uuid but the table is empty or the uuid is the uuid of the ... Katja Luther
12:12 PM Revision 9e57572e (cdm-vaadin): ref #7833 fixing null-view bug
Andreas Kohlbecker

12/21/2018

08:27 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet
Submitter can currently view/update unpublished references and datasets entered by the curator or a. Wolf-Henning Kusber
05:37 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet
Issue solved, please review. Andreas Kohlbecker
05:37 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet
Wolf-Henning Kusber wrote:
> Unpublished references must be hidden from the select in the "New Registration" makes s...
Andreas Kohlbecker
05:45 PM Revision 68369e5d (cdmlib): ref #7833 another method for UserHelper to scan for permissions
Andreas Kohlbecker
05:43 PM feature request #7968 (Closed): ReferenceEditor: optional validation for completenes of Partial values in datePublished
As consequence of the way #7833 was solved (see `RegistrationWorkingSetService.checkReferencePublished(Reference refe... Andreas Kohlbecker
05:33 PM Revision 99741bc0 (cdm-vaadin): ref #7833 registration start view excludes unpublished references
Andreas Kohlbecker
04:19 PM Revision 35a51c01 (cdm-vaadin): ref #7833 registration start view only shows references for which the user has permissions
Andreas Kohlbecker
04:15 PM Revision d81bb53b (cdm-vaadin): ref #7833 fixing inversly interpreted access denied
Andreas Kohlbecker
12:38 PM Revision b32150b1 (cdm-vaadin): ref #7833 restricting access to RegistrationWorkingsetView:
- AccessRestrictedViewControlBean to evaluate AccessRestrictedView.isAccessDenied()
- refactoring AccessRestricted...
Andreas Kohlbecker
10:34 AM task #7964: Name and orthographic variant - were to link types
As a basis for discussion:
A given name must be available (selectable) for new Working sets.
That means: if an in...
Wolf-Henning Kusber
10:04 AM Revision 581b3ae7 (taxeditor): ref #7589 Removed unnecessary sorting
Patrick Plitzner
10:04 AM Revision 598e33b7 (taxeditor): ref #7580 Add copy&paste configuration (not yet actually working)
Patrick Plitzner
10:04 AM Revision 787a37f1 (taxeditor): code cleanup
Patrick Plitzner
08:19 AM Revision 020445f3 (cdm-vaadin): ref #7967 referencing ticket in comment
Andreas Kohlbecker
08:16 AM task #7967 (New): AnnotationBasedAccessControlBean to implement ViewAccessControl
AnnotationBasedAccessControlBean should implement ViewAccessControl since the view class and its annotations can be a... Andreas Kohlbecker

12/20/2018

04:57 PM bug #7833: submitters can access see any registration in any RegistrationWorkingSet
Unpublished references must be hidden from the select in the "New Registration" makes sense.
Question (2): creator =...
Wolf-Henning Kusber
04:23 PM bug #7833 (Feedback): submitters can access see any registration in any RegistrationWorkingSet
Hallo Henning,
ich denke dieses Ticket sollten wir unbedingt noch lösen bevor wir externe Submitter zulassen.
A...
Andreas Kohlbecker
04:34 PM task #7964: Name and orthographic variant - were to link types
Currently, I can link types to both names (see screen shot, by the way, I put in 1234 as number before the page was u... Wolf-Henning Kusber
04:04 PM task #7964 (Feedback): Name and orthographic variant - were to link types
Andreas Kohlbecker
04:03 PM task #7964: Name and orthographic variant - were to link types
once a name is known to be incorrect (has a name relation to the correcting name) it should no longer possible to
...
Andreas Kohlbecker
02:32 PM task #7964 (Feedback): Name and orthographic variant - were to link types
Types can be linked to the corrected name or to the incorrect name (as published).
There are arguments to link a ...
Wolf-Henning Kusber
04:25 PM bug #7897 (Duplicate): TeamOrPersonField: BindException: The given field is not part of this FieldBinder
this looks like a duplicate of #7867 Andreas Kohlbecker
04:19 PM bug #7956 (Closed): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
solved Andreas Kohlbecker
04:19 PM bug #7956 (Resolved): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
Applied in changeset commit:cdm-vaadin|6e995b1e3d57b22f0dbd925955d647fea233a985. Andreas Kohlbecker
04:19 PM Revision 6e995b1e (cdm-vaadin): fix #7956 adding lost refreshView
Andreas Kohlbecker
04:14 PM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks
"unranked" is fine as long it points to an uninominal. Wolf-Henning Kusber
03:54 PM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks
Why is it "unknown rank" and not "unranked". The other vague rank terms are labled "unranked infraspecific" and "unr... Andreas Kohlbecker
11:31 AM bug #7963: TaxonNamePopEditor: name part field visibility not correct for all ranks
"unknown rank" as uninominal might be important. The others are not in use and not expected to use. Wolf-Henning Kusber
08:25 AM bug #7963 (Feedback): TaxonNamePopEditor: name part field visibility not correct for all ranks
is there a rank which is highly relevant for phycobank for which this issue needs to be fixed immediately? Andreas Kohlbecker
08:24 AM bug #7963 (Closed): TaxonNamePopEditor: name part field visibility not correct for all ranks
[henning]
I checked the complete list. With some ranks (mostly not relevant for PhycoBank, I have problems).
"s...
Andreas Kohlbecker
04:11 PM feature request #7966 (Closed): Registration search simplify type select options
The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker
04:11 PM feature request #7965 (Closed): Registration search simplify type select options
The type select in the search filters should not distinguish name type and specimen types. E.g. the option "Lectotype... Andreas Kohlbecker
03:45 PM bug #7481 (Resolved): ReferenceEditor: filter inReferences by applicable reference type
Andreas Kohlbecker
03:44 PM bug #7481: ReferenceEditor: filter inReferences by applicable reference type
validator added
ready for reviewing
Andreas Kohlbecker
11:01 AM bug #7481: ReferenceEditor: filter inReferences by applicable reference type
Wolf-Henning Kusber wrote:
> Two comments
>
> AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
...
Andreas Kohlbecker
10:50 AM bug #7481: ReferenceEditor: filter inReferences by applicable reference type
Two comments
AK: Section -> Article | Book | Thesis | Patent | Report | Webpage
W-H.K.: missing: inProceedings |...
Wolf-Henning Kusber
09:30 AM bug #7481 (Feedback): ReferenceEditor: filter inReferences by applicable reference type
Hi Henning, do you agree with the constraints as mentioned in the issue description? Anything missing? Andreas Kohlbecker
03:41 PM Revision 5dd877d3 (cdm-vaadin): ref #7481 adding validator for in reference type constraints
Andreas Kohlbecker
03:21 PM Revision 2b73afd3 (taxeditor): ref #7854: minor changes
Katja Luther
03:19 PM bug #7941: Deduplication does not work in new taxon dialog
this should be fixed with the changing the parsing method to the same as in name editor. please review. Katja Luther
03:18 PM bug #7941 (Resolved): Deduplication does not work in new taxon dialog
Applied in changeset commit:taxeditor|2e5addbf1470b86b929e7e4ca4fc0f0eebb291f6. Katja Luther
03:17 PM Revision 2e5addbf (taxeditor): fix #7941: use the same parser method in new taxonnode wizard as in name editor
Katja Luther
03:16 PM bug #7940 (Feedback): "New" menu in navigator not available for certain users
I can't reproduce this, did you changed the rights of the user? Katja Luther
02:29 PM feature request #7718 (Closed): New Registration: Exclude irrelevant reference types from list of existing publications
Andreas Kohlbecker
02:13 PM feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications
The reference types Section, PrintSeries and Journal have been excluded from the options. Ticket can be closed. Wolf-Henning Kusber
02:14 PM bug #7950: ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over
Solved!
Should be tested in IE / Edge also
Andreas Kohlbecker
02:13 PM bug #7950 (Resolved): ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over
Applied in changeset commit:cdm-vaadin|403a0ebd2e7160ce26171894195e6a362f9048bd. Andreas Kohlbecker
02:13 PM Revision 403a0ebd (cdm-vaadin): fix #7950 fixing scss for icon button fields and adding variable for box-shadow-width
Andreas Kohlbecker
02:06 PM bug #7880 (Resolved): Implement centralized preference default loading strategy
this should be fixed. please review. Katja Luther
01:42 PM Revision 46ec4941 (taxeditor): fix navigator order preference page
Katja Luther
01:22 PM Revision fbd932cc (taxeditor): ref #7849: disable apply button until something was changed in preference page
Katja Luther
01:00 PM Revision 9eb3b85d (cdmlib): ref #7481 inReference constraints added as method to ReferenceType - making method static
Andreas Kohlbecker
12:50 PM bug #7639 (Closed): SpecimenTypeDesignationEditor: Altitude not saved and displayed properly
Andreas Kohlbecker
11:59 AM bug #7639: SpecimenTypeDesignationEditor: Altitude not saved and displayed properly
Altitude
200,5 is given as 200
2.5 or 2,5 is given as 2
Because altitudes can not be that exact this is okay wit...
Wolf-Henning Kusber
11:59 AM feature request #7954 (Closed): protected vs. unproteced caches in TaxEditor
Katja Luther
10:18 AM feature request #7954: protected vs. unproteced caches in TaxEditor
The tooltip text for the button explains the functionality exactly for users.
Even though, I saw the German transla...
Wolf-Henning Kusber
09:38 AM feature request #7954: protected vs. unproteced caches in TaxEditor
There is a tooltip for the button now. Please have a look if this clearify the usage of the lock.
Katja Luther
09:34 AM feature request #7954 (Resolved): protected vs. unproteced caches in TaxEditor
Applied in changeset commit:taxeditor|c42c4e417e482b08177318c7d155f58c314c8206. Katja Luther
11:58 AM bug #7856 (Resolved): Allow local override for distribution vocabularies
now it is possible to override the available vocabularies for the distribution editor.please review Katja Luther
11:56 AM Revision 5b9c1d33 (cdm-vaadin): ref #7481 moving inReference constraints to cdmlib-model
Andreas Kohlbecker
11:56 AM Revision 7ffc533f (taxeditor): ref #7856: fix allow override for namedArea vocabulary selection for distributions
Katja Luther
11:55 AM feature request #7218 (Closed): SpecimenTypedesignationsWorkingsetEditor: support for Reference system
Wolf-Henning Kusber wrote:
> good: WGS84 can be selected.
>
> not so good: other possible systems can not be sele...
Andreas Kohlbecker
11:44 AM feature request #7218 (Feedback): SpecimenTypedesignationsWorkingsetEditor: support for Reference system
good: WGS84 can be selected.
not so good: other possible systems can not be selected (I do not need them).
not ...
Wolf-Henning Kusber
11:49 AM Revision bc7a1271 (cdmlib): ref #7481 inReference constraints added as method to ReferenceType
Andreas Kohlbecker
11:21 AM Revision eade8b7d (taxeditor): ref #7856: fix allow override for namedArea vocabulary selection for distributions
Katja Luther
10:45 AM feature request #7912 (Feedback): Enhance checkbox tree viewer
this seems to work, but the checkboxes are not grayed when a child or some children are selected. Katja Luther
10:35 AM bug #7929 (Closed): after delete of not persisted object in bulkeditor the object is still in bulkeditor list
seems to work Patrick Plitzner
10:23 AM bug #7929 (Resolved): after delete of not persisted object in bulkeditor the object is still in bulkeditor list
Katja Luther
10:23 AM bug #7929: after delete of not persisted object in bulkeditor the object is still in bulkeditor list
please review Katja Luther
10:20 AM bug #7934 (Closed): sometimes the signs for deduplication are not shown
works fine now. Katja Luther
10:16 AM bug #7649 (Closed): Term editor loads/saves extremely slow
this is fixed with #7887 Katja Luther
10:16 AM feature request #7887 (Closed): Use DTOs in term editor
after creating a new namedArea the deletion does not work because it is referenced by its parent. This is fixed with ... Katja Luther
10:13 AM Revision c5802825 (cdmlib): ref #7887: fix deletion of terms
Katja Luther
09:38 AM Revision 99e47ce1 (taxeditor): fix #7954: update the english text for cache field tooltip
Katja Luther
09:37 AM Revision 9bbd60ec (cdm-vaadin): ref #7481 inReference options filtered by applicable type
Andreas Kohlbecker
09:33 AM Revision c42c4e41 (taxeditor): fix #7954: add tootltip to cache fields in editor to clearify the meaning of the lock
Katja Luther
07:57 AM bug #7878 (Closed): Edit CollectionCode not saved
Andreas Kohlbecker
07:56 AM task #7846 (Feedback): PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.
DTO is an acronym for Data Transfer Object. The *DTO labels should be transformes into something more user friendly o... Andreas Kohlbecker
07:54 AM bug #7962 (Closed): PopupEditors: *DTO in context 'breadcrumbs' to be transformed into more humane labels
see #7846#note-4 Andreas Kohlbecker

12/19/2018

08:11 PM task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.
What is "SpecimenTypeDesignationWorkingSetDTO" DTO? Wolf-Henning Kusber
07:52 PM task #7846: PopupEditors show editor context information as 'breadcrumbs' in the header or toolbar.
Tested for a new infraspecific name with new genus with new reference and new species epithet with new article in new... Wolf-Henning Kusber
08:09 PM bug #7878: Edit CollectionCode not saved
Works.
New feature "is part of" is helfull.
I took an entry "Code only" Edit Instute name "Institute of Botany" a...
Wolf-Henning Kusber
07:38 PM bug #7944: TaxonNamePopEditor: name part fields are required
Review:
I agree, that this is needed for data integrity, but I think this will slow down data entry by users and cu...
Wolf-Henning Kusber
06:44 PM feature request #7899: enable orthographic name correction in Vaadin
label: what about the following label wording?
header: orthographical variant
above the cache: incorrect name (= ...
Wolf-Henning Kusber
05:36 PM feature request #7899: enable orthographic name correction in Vaadin
Comment on #15
according to the latest discussion, which is based on research in the ICBN, we came to the conclusi...
Wolf-Henning Kusber
05:10 PM feature request #7899 (Resolved): enable orthographic name correction in Vaadin
please review Andreas Kohlbecker
05:00 PM feature request #7899: enable orthographic name correction in Vaadin
according to the latest discussion, which is based on research in the ICBN, we came to the conclusion that `ORTHOGRAP... Andreas Kohlbecker
03:20 PM feature request #7899 (In Progress): enable orthographic name correction in Vaadin
After a discussion with Andreas Müller, the improved concept from 2018-12-11 has been revised and changed again:
1...
Andreas Kohlbecker
06:14 PM task #7935 (In Progress): Discuss new solution to establish the communication between submitter and curator
Andreas Kohlbecker
06:00 PM Revision a58f31a1 (cdm-vaadin): Revert "ref #7899 adding MarkerType 'Incorrect name'"
This reverts commit 068197fd8dc908bd5c05ddd764e78027a564dbec. Andreas Kohlbecker
05:39 PM feature request #7954: protected vs. unproteced caches in TaxEditor
Ich finde Hennings Vorschlag prima, denn wirklich intuitiv verstädlich sind diese Schloß-Icons auch für mich nie gewe... Andreas Kohlbecker
05:13 PM Revision e561ae83 (cdm-vaadin): ref #7961 deprecating TaxonNamePopupEditorMode until decided on removal or not
Andreas Kohlbecker
05:08 PM task #7961 (New): Consider removal of the TaxonNamePopupEditorMode ORTHOGRAPHIC_CORRECTION
As of the latest discussion regarding the semantic of `NameRelationshipType.ORTHOGRAPHIC_VARIANT()` (#7899#note-15) i... Andreas Kohlbecker
04:51 PM task #7960 (New): Revision of NameRelationshipTypes
While working on #7899 a discussion on the semantics of the NameRelationshipTypes `ORTHOGRAPHIC_VARIANT` and `MISSPEL... Andreas Kohlbecker
04:45 PM bug #7951 (Closed): Reference Combobox option titles can be too long causing the select box to extend too much
Andreas Kohlbecker
04:32 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
This obviously comes from the vaadin combobox, the width of the div containing the table is set too wide:
~~~html
...
Andreas Kohlbecker
04:22 PM bug #7951 (In Progress): Reference Combobox option titles can be too long causing the select box to extend too much
The data problems pointed out in comment 16 are not really relevant for this issue.
But there is still one situat...
Andreas Kohlbecker
04:45 PM bug #7959: LazyCombobox popup over sizing problem
This is most probably a vaadin probelm, either in vaddin itself or in the viritin addon Andreas Kohlbecker
04:43 PM bug #7959 (Rejected): LazyCombobox popup over sizing problem
see #7951#note-18 Andreas Kohlbecker
03:23 PM Revision 3bf04fa1 (cdm-vaadin): ref #7899 excluding 'incorrect' names from name comboboxes by fitering by NameRelationshipType
Andreas Kohlbecker
02:04 PM feature request #7063 (Resolved): Improve the area selection wizard for distribution editor
I think this is solved with #7887.
Now the items in the tree have three states and it is possible to select and de...
Katja Luther
01:49 PM Revision 5ab46e89 (taxeditor): ref #7854: show label corresponding to preferences
Katja Luther
01:32 PM Revision ad2e9ab4 (taxeditor): ref #7854: continue session handling in distribution editor
Katja Luther
01:28 PM Revision 3971a637 (cdmlib): ref #7854: adapt DTOs and merge Method for Distributions
Katja Luther
12:32 PM Revision 12cd46ae (taxeditor): ref #7589 Fix order of parent taxon nodes
Patrick Plitzner
12:05 PM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
So this supports my thesis. Andreas Kohlbecker
10:31 AM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
No reload, but open name again to look up if the not displayed data have been databased. Not sure if save or cancle w... Wolf-Henning Kusber
10:25 AM bug #7956: RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
This seems to be an update problem with the workingset. Didi you try a reload of the page after saving the editor, I ... Andreas Kohlbecker

12/18/2018

02:16 PM Revision 328bcdec (taxeditor): Rename utility method
Patrick Plitzner
02:16 PM Revision 076adbba (taxeditor): ref #7589 Check dirty state before executing handler or button actions
Patrick Plitzner
02:16 PM Revision e4f5a8e2 (taxeditor): ref #7589 Only allow one single default taxon description per taxon
Patrick Plitzner
02:16 PM Revision c2dff0ee (cdmlib): ref #7589 Add service method to find taxon description by marker
Patrick Plitzner
01:19 PM task #7854: Open issues in TaxDistributionEditor
the branch is now merged to develop.
There are still some problems with multiple representation exceptions.
Katja Luther
12:56 PM Revision 16833e53 (cdmlib): ref #7854: adapt DTOs
Katja Luther
12:53 PM Revision 0747234f (taxeditor): ref #7854: continue session handling in distribution editor
Katja Luther
11:35 AM Revision 2e385b93 (taxeditor): ref #7854: session handling in distribution editor
Katja Luther
11:18 AM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
Die meisten Unstimmigkeiten kommen durch IAPT-Altdaten und Einträge aus dem ersten Jahr PhycoBank.
Dort wurden Serie...
Wolf-Henning Kusber
08:51 AM bug #7951 (Feedback): Reference Combobox option titles can be too long causing the select box to extend too much
For me it looks like this:
![](picture998-1.png)
![](picture185-1.png)
I think we should discuss these diffe...
Andreas Kohlbecker
09:40 AM Revision 530e4fec (taxeditor): revert changes in CharacterMatrix
Katja Luther
09:38 AM Revision 7bec20de (taxeditor): remove nebula.widget jar
Katja Luther

12/17/2018

05:16 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
"Greuter" Ref. solved. Layout problems not, see #11
A new layout problem occurred: Even if a long title shortened,...
Wolf-Henning Kusber
03:55 PM bug #7951 (Resolved): Reference Combobox option titles can be too long causing the select box to extend too much
The test server was not yet up to date. After the server was buidl freshly I could not reproduce any of the above nam... Andreas Kohlbecker
10:20 AM bug #7951 (In Progress): Reference Combobox option titles can be too long causing the select box to extend too much
2018-12-17 no changes visible for me.
Normally the formatter works well.
Problems with long book titles are not s...
Wolf-Henning Kusber
02:53 PM Revision 576b283c (cdmlib): ref #7854: changes in taxonDistributionDTO
Katja Luther
01:50 PM task #7958 (New): General concept for a flexible and generic entitiy and dto formatter framework in the cdmlib
Currently there are *CacheStrategies*, *Formatter*, *EllypsisFormatter*, *DtoFormatter*, ... all of these could be ha... Andreas Kohlbecker
01:49 PM Revision c5d906bd (taxeditor): ref #7854: implement getRootEnteties for the session view in distributioneditorPart
Katja Luther
01:35 PM Revision 97d21185 (taxeditor): ref #7854: minor changes in session handling
Katja Luther
01:34 PM Revision 278a5e0a (taxeditor): ref #7854 Implement NatTable for distribution editor
Katja Luther
01:18 PM Revision 229e074a (cdmlib): ref #7957 Change marker to avoid "Uses" details view
Patrick Plitzner
01:18 PM Revision 0770bcab (cdmlib): ref #7589 Use TaxonNodeDtos in row wrappers
Patrick Plitzner
01:18 PM Revision 6a6f0c52 (cdmlib): ref #7589 Add service method for description deletion for data sets
Patrick Plitzner
01:18 PM Revision 1b2a87f1 (cdmlib): ref #7589 Remove reference to default taxon desc from row wrapper
Patrick Plitzner
01:16 PM feature request #7957 (Closed): Add types for taxon description (as EnumSet)
When working on the Character Matrix there are 3 types of taxon descriptions:
1. default taxon description
1. tax...
Patrick Plitzner
01:09 PM Revision 8d9c5176 (taxeditor): ref #7589 Move description deletion to service layer
Patrick Plitzner
01:08 PM Revision 1903cf2b (taxeditor): ref #7589 Remove UpdateResult handling from CharacterMatrix
Patrick Plitzner
01:07 PM Revision 11a549d1 (taxeditor): ref #7589 Use TaxonNodeDtos in character matrix
Patrick Plitzner
12:48 PM Revision ba755283 (cdmlib): fix wrong locality text in gatheringDTO
Katja Luther
12:45 PM Revision 8c8c0db0 (taxeditor): merge develop into branch distributionEditorNatTable
Katja Luther
11:51 AM bug #7956 (Closed): RegistrationWorkingsetEditor refresh problem after saving TaxonNameEditor
Reported by Heba (release version):
Working set: http://api.cybertaxonomy.org/phycobank/app/registration#!workings...
Wolf-Henning Kusber
11:50 AM task #7955 (New): Conecept for centralizes init strategies
The same or very similar init strategies are often distributed redundantly in the code base of the cdmlib an dependen... Andreas Kohlbecker
11:10 AM feature request #7954: protected vs. unproteced caches in TaxEditor
![](picture191-1.png)
Hintergrund des Tickets ist, dass ich als User nicht auf unprotected/protected geachtet habe...
Wolf-Henning Kusber
11:07 AM feature request #7954 (Closed): protected vs. unproteced caches in TaxEditor
Problem: erst nach diversen Diskussionen mit Leuten aus dem EDIT-Team (und rumprobieren) habe ich verstanden, wie pro... Wolf-Henning Kusber
10:20 AM Revision 840bfe5f (cdmlib): fix error in geolocation in abcd import
Katja Luther
10:20 AM Revision 2afca98f (cdmlib): ref #7854: add taxon to descriptionDTO
Katja Luther
07:40 AM Revision 7b6b3222 (taxeditor): ref #7589 Remove reference to default taxon desc from row wrapper
Patrick Plitzner
07:38 AM Revision 2c28be6a (taxeditor): ref #7589 Remove UpdateResult handling from CharacterMatrix
Patrick Plitzner

12/14/2018

10:18 PM Revision 775c87a6 (cdm-vaadin): ref #7899 starting 'Incorrect name' editor without mode VALIDATE_AGAINST_HIGHER_NAME_PART and hiding 'Ortographic correction' toggle
Andreas Kohlbecker
09:56 PM Revision 068197fd (cdm-vaadin): ref #7899 adding MarkerType 'Incorrect name'
Andreas Kohlbecker
09:25 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
I improved the label `ReferenceEllypsisFormatter` so that it can deal with any title cache protection. thus the above... Andreas Kohlbecker
11:52 AM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
We should differentiate between atomized data and protected/unprotected caches and bibliographic/nomenclatural refere... Wolf-Henning Kusber
11:27 AM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
The Book "*Greuter, McNeill, Barrie, Burdet, Demoulin, Filg., Nicolson, P.C.Silva, J.E.Skog, Trehane, Turland, D.Hawk... Andreas Kohlbecker
09:21 PM Revision e8b9f0b2 (cdmlib): ref #7951 more complete generic ReferenceEllypsisFormatter
Andreas Kohlbecker
02:42 PM Revision 569b2942 (cdmlib): ref #7951 moving EllypsisFormatter to cdmlib/model/eu.etaxonomy.cdm.format
Andreas Kohlbecker
02:40 PM Revision 0ca40381 (cdm-vaadin): ref #7949renaming ComboboxLabelProvider to EllypsisFormatter and other classes accordingly, abstract base class introduced
Andreas Kohlbecker
02:38 PM Revision 2192ca65 (cdm-vaadin): ref #7949 renaming ComboboxLabelProvider to EllypsisFormatter and other classes accordingly, abstract base class introduced
Andreas Kohlbecker
02:18 PM bug #7953 (Feedback): Book in BookSeries: incomplete titleCache misses series title
Andreas Kohlbecker
02:18 PM bug #7953: Book in BookSeries: incomplete titleCache misses series title
@henning: please complete the "Expected titleCache" in the description Andreas Kohlbecker
02:17 PM bug #7953 (Feedback): Book in BookSeries: incomplete titleCache misses series title
BookSeries:
* titleCache: "Iconographia Diatomologica"
Book in this series:
* title: "Taxonomy - biogeograph...
Andreas Kohlbecker
01:20 PM Revision 343fcdde (taxeditor): ref #7854: adapt to changes in DescriptionDTO
Katja Luther
12:26 PM Revision f5832048 (taxeditor): ref #7854: changes in details view and supplemental data view need to result in dirty state of the distribution editor
Katja Luther
11:34 AM Revision da628899 (taxeditor): ref #7854: add filter column to distribution columns
Katja Luther
11:14 AM feature request #7949 (Closed): New Registration: Reference combobox to offer two search modes
The option captions are changed as wished. Andreas Kohlbecker
11:13 AM Revision e46361bb (cdm-vaadin): ref #7949 changing option captions
Andreas Kohlbecker
10:00 AM Revision 31462908 (taxeditor): minor
Katja Luther

12/13/2018

06:53 PM feature request #7949: New Registration: Reference combobox to offer two search modes
Functionality perfect, this is what we need!
Wording and layout might be improved. "anywhere" has two problems (i)...
Wolf-Henning Kusber
05:51 PM feature request #7949: New Registration: Reference combobox to offer two search modes
done, please review! Andreas Kohlbecker
05:51 PM feature request #7949 (Resolved): New Registration: Reference combobox to offer two search modes
Applied in changeset commit:cdm-vaadin|a7612c19f7272069354d69c68e3385220e6af556. Andreas Kohlbecker
06:42 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
Book title causes problems. Combobox longer than screen. Date not given AND title not shortened. See screen shot:
![...
Wolf-Henning Kusber
05:23 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
Mit der Referenz hatte ich Probleme. Die Wiedergabe des Buches ist ungenügend (siehe Screen shot).
Editor fehlt, "23...
Wolf-Henning Kusber
04:58 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
Ich habe nun noch einen Bug gefixt, es lang nicht an den BookSections sondern eine Stringersetzung hatte Probleme mi... Andreas Kohlbecker
04:53 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
[Henning:]
Überwiegenst hast Du die wichtigsten Keywords rausgefischt, was mir aufgefallen ist, dass das Kürzen ...
Andreas Kohlbecker
03:20 PM bug #7951: Reference Combobox option titles can be too long causing the select box to extend too much
please review Andreas Kohlbecker
03:19 PM bug #7951 (Resolved): Reference Combobox option titles can be too long causing the select box to extend too much
Applied in changeset commit:cdm-vaadin|bf643f223676b7510d21e41dd3760f342696e4a4. Andreas Kohlbecker
05:51 PM Revision a7612c19 (cdm-vaadin): fix #7949 Reference combobox with begins and anywhere search mode
Andreas Kohlbecker
04:48 PM Revision 532d021f (cdm-vaadin): ref #7951 ReferenceLabelProvider: fixing wrong string replacement for more complete ellipsis
Andreas Kohlbecker
03:19 PM Revision bf643f22 (cdm-vaadin): fix #7951 ReferenceLabelProvider to ellipsis the reference labels
Andreas Kohlbecker
02:57 PM task #7854 (In Progress): Open issues in TaxDistributionEditor
in branch distributionEditorNatTable a first implementation of the distribution editor with NAT tables is available.
...
Katja Luther
02:56 PM Revision ea92da24 (cdmlib): fixing wrong boolean operator combination for Restrictions with operator AND_NOT
Andreas Kohlbecker
02:28 PM Revision f32128b6 (taxeditor): ref #7854: add filter to taxon row
Katja Luther
09:48 AM Revision 9245724f (taxeditor): ref #7854: improve removing of distributions in NAT table distribution editor
Katja Luther
09:23 AM Revision b55fd194 (cdmlib): ref #7854: add methods to get DTOs for distribution editor
Katja Luther
09:19 AM Revision 29e1af1d (cdmlib): code cleaning
Katja Luther
09:00 AM Revision ee6e05c9 (cdmlib): adapt propertyPath for occurences in fieldUnitDto
Katja Luther

12/12/2018

02:41 PM Revision 331c7265 (taxeditor): ref #7854: freezing taxon column
Katja Luther
02:30 PM Revision 9d0707c1 (taxeditor): ref #7854: fix reload
Katja Luther
01:55 PM Revision 943e9b24 (taxeditor): ref #7854: show details for distributions and reload after changing the areas in distribution editor
Katja Luther
01:26 PM feature request #7952 (Rejected): Registration page Maps display in PhycoBank portal
In PhycoBank geo references for type localities are given.
In the new portal no maps are displayed.
Example: http...
Wolf-Henning Kusber

12/11/2018

06:07 PM task #7948: Editor for Classification Fragments
After discussions with Andreas & Andreas the Excel form was slightly changed.
Collumn A contains the UUID of the ref...
Wolf-Henning Kusber
04:50 PM task #7948 (Closed): Editor for Classification Fragments
The PhycoBank team agreed not to implement an (Vaadin) editor for classification fragments (= classification in a ref... Wolf-Henning Kusber
05:17 PM bug #7951 (Closed): Reference Combobox option titles can be too long causing the select box to extend too much
to reproduce go to the new registration view, enter "Kusber" in the combobox and use the mouse wheel to scroll the op... Andreas Kohlbecker
05:13 PM feature request #7899: enable orthographic name correction in Vaadin
We discussed the above problems and came to a solution ... issue description updated accordingly Andreas Kohlbecker
11:59 AM feature request #7899: enable orthographic name correction in Vaadin
incorrect uninominals and epithets should only be searchable in the "incorrect name" section. Example is genus=Melose... Wolf-Henning Kusber
10:43 AM feature request #7899: enable orthographic name correction in Vaadin
Applied in changeset commit:cdm-vaadin|61b6ce4e6afcc2de48e66b2f8df68d30c799ca3c. Andreas Kohlbecker
05:01 PM bug #7950: ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over
can not reproduce this issue at the moment. Andreas Kohlbecker
04:54 PM bug #7950 (Closed): ToOneRelatedEntityCombobox: add new button "jumpes" to the right when hovering the mouse over
Andreas Kohlbecker
04:51 PM feature request #7949 (Closed): New Registration: Reference combobox to offer two search modes
by default the search should be done as `BEGINS_WITH` search. The `CONTAINS` search mode should be offered as option Andreas Kohlbecker
02:08 PM feature request #7947 (Closed): registration page shows name relations
Display of name relations in the reference page is urgently required Andreas Kohlbecker
01:15 PM task #7935: Discuss new solution to establish the communication between submitter and curator
We agreed on a pure email solution without any messaging system:
curation@phycobank.org sollte auf eine bgbm inter...
Andreas Kohlbecker
12:04 PM feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications
completed, please review Andreas Kohlbecker
12:03 PM feature request #7718 (Resolved): New Registration: Exclude irrelevant reference types from list of existing publications
Applied in changeset commit:cdm-vaadin|39acd47c396d32b10bdd3791eca10e75104e8fd2. Andreas Kohlbecker
11:54 AM feature request #7718: New Registration: Exclude irrelevant reference types from list of existing publications
The reference types Section, PrintSeries and Journal should be excluded from the options. Andreas Kohlbecker
12:03 PM Revision 39acd47c (cdm-vaadin): fix #7718 excluding irrelavant reference types from combobox in new registration view
Andreas Kohlbecker
11:46 AM bug #7946 (Closed): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener
Andreas Kohlbecker
11:45 AM bug #7946 (Resolved): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener
Applied in changeset commit:cdm-vaadin|c4f3380a5b2c8c725e2d9899b4200edd19213855. Andreas Kohlbecker
11:44 AM bug #7946 (Closed): RegistrationStatusFieldInstantiator must set status value internally before adding the ValueChangedListener
Henning reported the following problem:
Beim Testen von: https://dev.e-taxonomy.eu/redmine/issues/7899

Hängt d...
Andreas Kohlbecker
11:45 AM Revision c4f3380a (cdm-vaadin): fix #7946 setting the status value directly in the RegistrationStatusFieldInstantiator
Andreas Kohlbecker
11:07 AM Revision 48fb701d (taxeditor): ref #7854: correct saving, details view and default source handling
Katja Luther
10:43 AM Revision 61b6ce4e (cdm-vaadin): fix #7899 changing corrected name label to "Incorrect name"
Andreas Kohlbecker

12/10/2018

07:37 PM feature request #7899: enable orthographic name correction in Vaadin
To handle an erroneously spelled genus name, I had to register the uncorrect spelled genus name. A workaround could b... Wolf-Henning Kusber
07:24 PM feature request #7899: enable orthographic name correction in Vaadin
The normal usecase "new epithet incorrectly published" to be corrected according to ICN works well.
But problems a...
Wolf-Henning Kusber
07:05 PM feature request #7899: enable orthographic name correction in Vaadin
Forms and functionality implemented as discussed.
Working with orthographic variants reveals an error in the specifi...
Wolf-Henning Kusber
01:33 PM feature request #7899: enable orthographic name correction in Vaadin
please review once test server is updated. Andreas Kohlbecker
01:26 PM feature request #7899 (Resolved): enable orthographic name correction in Vaadin
Applied in changeset commit:cdm-vaadin|e5237e50ef5bcd241d14a3667ca23ac46aec2b71. Andreas Kohlbecker
07:06 PM feature request #7942: SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation
implemented as discussed, ready for reviewing as soon as the test-server has been rebuild. Andreas Kohlbecker
07:05 PM feature request #7942 (Resolved): SpecimenTypeDesignationEditor: Explanation on why editor can not be saved without type designation
Applied in changeset commit:cdm-vaadin|5003e7af8f925c3c340a8f9c2fdd28ce735a9672. Andreas Kohlbecker
07:04 PM Revision 5003e7af (cdm-vaadin): fix #7942 using required flag and validation to prevent from saving without typedesignations
Andreas Kohlbecker
05:21 PM Revision 5618ca88 (cdmlib): ref #7854: add service method to merge a set of descriptionelements
Katja Luther
05:12 PM Revision 01d7c5e7 (taxeditor): ref #7854: add ComboBox for status selection and merge distributionElements
Katja Luther
03:22 PM bug #7944: TaxonNamePopEditor: name part fields are required
ready for review Andreas Kohlbecker
03:03 PM bug #7944 (Resolved): TaxonNamePopEditor: name part fields are required
Applied in changeset commit:cdm-vaadin|8647ca02a990685e381409ca7b127b438766eeae. Andreas Kohlbecker
08:21 AM bug #7944 (Closed): TaxonNamePopEditor: name part fields are required
Depending on the chosen rank, the name part fields 'Uninomial', 'Specific epithet', ... should be set required in ord... Andreas Kohlbecker
02:59 PM Revision 8647ca02 (cdm-vaadin): fix #7944 TaxonNamePopEditor: name part fields are required
Andreas Kohlbecker
02:49 PM Revision aaa63dad (cdm-vaadin): ref #7899 updating nameRelationField with newly created corrected name
Andreas Kohlbecker
02:43 PM Revision 4bae0768 (cdm-vaadin): ref #7899 validator for orthographic correction
Andreas Kohlbecker
01:55 PM Revision ade5a13e (cdm-vaadin): ref #7899 adding new name as orthographic correction with correct bean instantiator
Andreas Kohlbecker
01:42 PM bug #7945: TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
This error can not be reproduced by saving a variety taxon name with blank genus. So the problem that causes the exce... Andreas Kohlbecker
08:22 AM bug #7945 (Rejected): TaxonNamePopupEditor: missing genus causes exception when updating name parts visibility
Incomplete data (missing genus) can result in exceptions being thrown:
~~~
org.hibernate.HibernateException: A co...
Andreas Kohlbecker
01:24 PM Revision e5237e50 (cdm-vaadin): fix #7899 orthographic variant and corrections implemented in taxon name popup editor
Andreas Kohlbecker
09:39 AM feature request #7575 (Closed): Implement advanced quantitative cell editor
This has already been implemented Patrick Plitzner
09:38 AM feature request #7509 (Closed): Aggregate and persist specimen character data from character matrix
This has already been solved.
Aggregated descriptions are saved in the DescriptiveDataSet and shown in the charact...
Patrick Plitzner
09:32 AM feature request #7362 (Closed): Implement view for Gfbio terminology service
This has already been implemented Patrick Plitzner
09:12 AM Revision 5d42b875 (cdmlib-apps): Add more source information to plant glossary import
Patrick Plitzner
07:30 AM Revision e5d40c14 (cdmlib-apps): Add more source information to plant glossary import
Patrick Plitzner
07:13 AM Revision 3ecd8903 (taxeditor): ref #7923 Disabel details for structure and property viewers
Patrick Plitzner
07:04 AM Revision 5f3b85bc (taxeditor): ref #7923 Add drag listener to structures viewer
Patrick Plitzner
07:00 AM bug #7933 (Feedback): Adding a new Term to the "Country" vocabulary leads to corrupt data
@Andreas: Should it be allowed at all to add a new term to the Country vocabulary?
The problem is in the TermType ...
Patrick Plitzner
 

Also available in: Atom