EDIT

01/08/2018

08:23 PM feature request #7158 (Feedback): Add pro parte misapplied name to the concept relationship types

WGB: >>Außerdem habe ich entdeckt, dass das eine p.p. „Synonym“ in Wirklichkeit als Misapplication genannt wird – kan... Andreas Müller

04:30 PM bug #7154 (Resolved): CdmEntityCache can update cached entities

Applied in changeset commit:cdm-vaadin|2b9b03a1fae11f68da8d2803b8b75b10b0c524d9. Andreas Kohlbecker

02:40 PM bug #7155: VersionableEntity.equals() should take updated timestamp into account

Hi Andreas,
I posted this provoking code as a suggestion and as an entry into the discussion. I never would have c... Andreas Kohlbecker

02:03 PM bug #7155: VersionableEntity.equals() should take updated timestamp into account

Andreas Kohlbecker wrote:
> I changed the method to
>
> ~~~java
>
> /**
> * Is true if UUID created and upd... Andreas Müller

01:50 PM bug #7155: VersionableEntity.equals() should take updated timestamp into account

I do not agree with this solution. The up to now implementation is essential for almost everything we have done until... Andreas Müller

11:24 AM bug #7155 (In Progress): VersionableEntity.equals() should take updated timestamp into account

I changed the method to
~~~java
/**
* Is true if UUID created and updated timestamp are the same for the pas... Andreas Kohlbecker

08:50 AM bug #7155 (Closed): VersionableEntity.equals() should take updated timestamp into account

The `equals()` as implemented in `VersionableEntity` is just a copy of the `equals` in `CdmBase`. It does not impleme... Andreas Kohlbecker

01:23 PM feature request #7063 (In Progress): Improve the area selection wizard for distribution editor

for better usabilty the terms are sorted now Katja Luther

11:03 AM feature request #6485: Implement IntextReferences in TaxEditor

open issues:
- deleting or editing text of inline reference
- editing the text around the inline reference
Katja Luther

11:00 AM feature request #7157 (Rejected): interim solution to mark pro parte synonyms in the dataportal

in case the `proParte` flag of a taxon is set :
"'p.p.' ... einfach hinten an das pp-Synonym dranhängen mit Space ... Andreas Kohlbecker

10:41 AM bug #7156: After deleting factual data all save operations result in DataIntegrityViolationException

The exception appears but the save is successfull. Katja Luther

10:38 AM bug #7156 (Worksforme): After deleting factual data all save operations result in DataIntegrityViolationException

After deleting factual data (the delete was successfull) and adding new factual data and save results in:
~~~
j... Katja Luther

10:32 AM bug #7073 (Closed): add extension to a name does not result in a dirty state

Katja Luther

10:31 AM bug #6627: Remaining cdm light issues

the isProParte flag is added to the synonym table Katja Luther

01/05/2018

02:23 PM bug #7094: Remove empty spaces in nomencl. title of persons

Finally this change was reverted and is only an optional configuration since 4.13 Andreas Müller

01/04/2018

03:24 PM bug #7154 (Closed): CdmEntityCache can update cached entities

The CdmEntityCache implemented with commit:cdm-vaadin|02ec8d6 & commit:cdm-vaadin|5e97d77 is used in the `ToOneRelate... Andreas Kohlbecker

02:57 PM bug #7153 (Closed): Implement possibility to "logout" completely from TaxEditor

... probably this means that the TaxEditor should be forced to forget the password.
The problem is, that uncheck... Andreas Müller

02:44 PM feature request #7152 (New): Make LSID another Alternative Identifier

Currently we handle LSIDs as part of identifiable entities. We may want to handle them as ordinary identifiers, such ... Andreas Müller

11:55 AM feature request #7120 (Closed): implement new buttons for selection dialogs

new buttons are now a little moved to the left. Close this ticket Katja Luther

11:53 AM feature request #7120 (Resolved): implement new buttons for selection dialogs

Applied in changeset commit:taxeditor|7eaf97410b02d0d4c50a26aa79a0b41a4a779edc. Katja Luther

10:28 AM feature request #7121 (Resolved): adapt remaining UuidAndTitleCache methods to use filter

when in voc selection dialog is chosen, the ok button is disabled now Katja Luther

12/22/2017

04:16 PM feature request #7149 (Closed): Collection Editor implemented

complete, only the institute is not editable but this requires another editor. Andreas Kohlbecker

12:38 PM feature request #7149 (Resolved): Collection Editor implemented

Applied in changeset commit:cdm-vaadin|b36e8dd1e6810eb9972eb7a2d0e90e205146cf9c. Andreas Kohlbecker

04:14 PM feature request #7150 (Closed): GrantedAuthorities & PermissionVoter for Cdm Collection type

Andreas Kohlbecker

04:07 PM feature request #7150 (Resolved): GrantedAuthorities & PermissionVoter for Cdm Collection type

Applied in changeset commit:cdm-vaadin|72141255300f274a193cc84bca8eca764e2c5816. Andreas Kohlbecker

11:00 AM feature request #7150 (Closed): GrantedAuthorities & PermissionVoter for Cdm Collection type

**TODO:**
* Implement PermissionVoter
* Add COLLECTION to CdmPermissionClass
* The Authority `COLLECTION[CRE... Andreas Kohlbecker

12:25 PM bug #7151 (Rejected): entities held in CdmCache can not be modified

Example-`SpecimenTypeDesignationWorkingsetPopupEditor`: Editing a Collection already associated with a Specimen via t... Andreas Kohlbecker

12/21/2017

03:23 PM feature request #7149 (Closed): Collection Editor implemented

Andreas Kohlbecker

03:02 PM feature request #6796 (Closed): PersonField: add UI Element to choose from existing Persons

Andreas Kohlbecker

02:07 PM feature request #7148: GrantedAuthorityRevokingRegistrationUpdateLister: delete orphan references to GrantedAuthorityImpl in User and Group

Hallo Andreas und Katja,

ich versuche per hql GrantedAuthorityImpls und die zugehörigen Relationen von User und G... Andreas Kohlbecker

02:05 PM feature request #7148 (Closed): GrantedAuthorityRevokingRegistrationUpdateLister: delete orphan references to GrantedAuthorityImpl in User and Group

The GrantedAuthorityRevokingRegistrationUpdateLister deletes GrantedAuthorityImpl entities but the references to Gran... Andreas Kohlbecker

10:52 AM bug #7147 (New): GrantedAuthorityRevokingDeleteListener implemented

Once a cdm entitiy is deleted the per entity GrantedAuthoritys which have been created for this specific entity must ... Andreas Kohlbecker

10:18 AM bug #7146 (Closed): ClassCastException when clicking on synchronize button

seems good Patrick Plitzner

08:20 AM bug #7146 (Resolved): ClassCastException when clicking on synchronize button

can not reproduce the exception, normally it should not happen, because the canExecute check for the right Class, but... Katja Luther

08:13 AM bug #7146 (Closed): ClassCastException when clicking on synchronize button

I just clicked on l"link with taxon" option and received this error
no taxon was selected or searched
logi... Katja Luther

08:08 AM bug #7145: NPE when trying to move a synonym into another homotypic group

I can not reproduce this error, but keep it if it appears again. Katja Luther

07:59 AM bug #7145 (New): NPE when trying to move a synonym into another homotypic group

NPE when trying to move a synonym into another homotypic group
~~~
login : m.malekmohammadi
editor version : 4.1... Katja Luther

12/19/2017

03:44 PM feature request #7119: implement filter button for selection dialogs

Andreas Müller wrote:
> There is an issue if NO vocabulary is chosen in area search filter. See also https://dev.e-t... Katja Luther

03:18 PM feature request #7119: implement filter button for selection dialogs

Andreas Müller wrote:
> Cancel does not yet work in filter dialog. It works like ok instead.
this is fixed Katja Luther

03:17 PM feature request #7119: implement filter button for selection dialogs

Andreas Müller wrote:
> The filter for areas does not yet correctly remember if "Country" is disabled. Next time whe... Katja Luther

03:17 PM feature request #7119: implement filter button for selection dialogs

Andreas Müller wrote:
> If the search string is still empty, after setting the filter ALL areas are loaded. This is ... Katja Luther

02:39 PM feature request #7119: implement filter button for selection dialogs

There is an issue if NO vocabulary is chosen in area search filter. See also https://dev.e-taxonomy.eu/redmine/issues... Andreas Müller

01:32 PM feature request #7119: implement filter button for selection dialogs

The filter dialog is still missing a title Andreas Müller

01:31 PM feature request #7119: implement filter button for selection dialogs

Cancel does not yet work in filter dialog. It works like ok instead. Andreas Müller

01:29 PM feature request #7119: implement filter button for selection dialogs

If the search string is still empty, after setting the filter ALL areas are loaded. This is unexpected behavior and s... Andreas Müller

01:27 PM feature request #7119 (Feedback): implement filter button for selection dialogs

The filter for areas does not yet correctly remember if "Country" is disabled. Next time when the filter is opened "C... Andreas Müller

02:55 PM bug #6955 (Feedback): NamedAreaSelection Dialog needs to be adapted to filtered getUuidAndTitleCache loading

In case no level exists, it looks like the label includes the class name instead. In case of pure NamedAreas this doe... Andreas Müller

02:53 PM bug #7144 (Closed): Add country as level to all areas of type Country.

Needs update script. Also need to adapt term loader. Andreas Müller

02:40 PM feature request #7118 (Feedback): migrate selection dialogs

Andreas Müller

02:33 PM feature request #7118: migrate selection dialogs

Some minor open issues:
* the search field should start at the same vertical position as the result box.
* the fi... Andreas Müller

02:35 PM feature request #7121: adapt remaining UuidAndTitleCache methods to use filter

When choosing NO vocabulary in area search I get an exception:
~~~
login : admin
editor version : 4.13.0.2017121... Andreas Müller

02:27 PM feature request #7121 (Feedback): adapt remaining UuidAndTitleCache methods to use filter

Andreas Müller

02:27 PM feature request #7121: adapt remaining UuidAndTitleCache methods to use filter

Moving getUuidAndTitleCache (xxx) down to AnnotatableEntityService+Dao to me seems critical.
Annotatable entities ... Andreas Müller

01:22 PM bug #7143 (Closed): Finish not enabled when unprotecting titleCache in new Person dialog

Using the new person dialog, at the beginning the title cache is protected. Therefore entering data e.g. into "family... Andreas Müller

01:16 PM feature request #7120 (Feedback): implement new buttons for selection dialogs

Only open issue from email discussions that I remember is that in terms of 2 "New" buttons it would be nice to have m... Andreas Müller

01:00 PM feature request #7142 (New): Implement person and team filter for agent search dialog

For authors (and maybe others) it is allowed to search for persons or teams in search dialog. We may want to implemen... Andreas Müller

12:56 PM bug #7122 (Closed): titlecache of the taxon is not updated when swap accepted taxon and synonym

Seems to be fixed. Andreas Müller

12:51 PM bug #7141 (Worksforme): Navigator does not update after swap synonym and accepted

When swaping a synonym and an accepted taxon, the label of the accepted taxon in the navigator is not synchronized. Andreas Müller

12:38 PM bug #7123 (Closed): Multiple Represenation Exception in Derivate View and bulk editor

As far as I remember I checked this after email conversation about the ticket. Finally everything was ok so we can cl... Andreas Müller

11:58 AM bug #7125 (Closed): widgetIsDisposed exceptions when clicking in another part

To be honest I do not know how to test this. Generally widget is disposed exceptions appear only rarely in the meanwh... Andreas Müller

11:48 AM bug #7073 (Feedback): add extension to a name does not result in a dirty state

Katja Luther wrote:
> I added another check for disposed control, hopefully this catches the exception. I could not ... Andreas Müller

11:33 AM bug #6728 (Closed): Changing author data when editing a reference does neither update the reference titleCache nor the author label

The above issue works fine. I havn't checked all other places (too many), but I think for now we can close this ticket. Andreas Müller

10:53 AM bug #7069 (Resolved): Delete taxon node should have consistent configuration

Applied in changeset commit:taxeditor|c4f68783f7732707b2741520c9b1b606ccb89b05. Katja Luther

10:37 AM bug #7069 (Feedback): Delete taxon node should have consistent configuration

Generally this is solved. Some minor issues:
1. Deleting a leaf: German label is "Wollen sie die ausgewählten Kno... Andreas Müller

12/18/2017

03:40 PM feature request #7082 (Resolved): Implement integration test for the SpecimenTypeDesignationWorkingsetEditorPresenter

Andreas Kohlbecker

03:33 PM bug #7103 (Resolved): verify, fix, improve SpecimenTypeDesignationWorkingSetServiceImpl delete functions

Andreas Kohlbecker

03:31 PM feature request #7011: Migrate group authority editor

Applied in changeset commit:taxeditor|26bdf4eafda9b87e2209002b4241aeb63271e377. Katja Luther

03:19 PM feature request #7011 (Resolved): Migrate group authority editor

Applied in changeset commit:taxeditor|907fd6ebe4ed659af01f5b1b1a70ad0c41f92046. Katja Luther

02:13 PM feature request #7011: Migrate group authority editor

Andreas Müller wrote:
> Reopening the editor after having it moved results in a grey (empty) editor. After moving it... Katja Luther

03:26 PM bug #6159 (In Progress): improve distribution editor in TaxEditor

Katja Luther

03:20 PM feature request #6932 (Resolved): Migrate bulk editor

the entities are only selected by double click. Katja Luther

02:25 PM feature request #7140 (New): Separate character's/feature's recommendedXXX data by usage for specimen and taxa

We may want separate characters/features in terms of recommendedXXX vocabularies on specimen and taxon level as the t... Patrick Plitzner

01:29 PM bug #7073 (Resolved): add extension to a name does not result in a dirty state

I added another check for disposed control, hopefully this catches the exception. I could not reproduce the exception... Katja Luther

12:55 PM bug #7073: add extension to a name does not result in a dirty state

Also I could not reproduce the "dirty" issue neither in 4.12 nor in 4.13. The details view issue seems to work now bu... Andreas Müller

12:54 PM bug #7073 (Feedback): add extension to a name does not result in a dirty state

when testing I got a recursive (!) widget is disposed exception:
~~~
login : admin
editor version : 4.13.0.20171... Andreas Müller

01:01 PM bug #7068 (Closed): Move factual data to a new taxon should use same classification as default

seems to work Andreas Müller

12:45 PM feature request #7078: sort result in taxon selection dialog

The functionality itself seems to work Andreas Müller

12:45 PM feature request #7078 (Feedback): sort result in taxon selection dialog

The preference should not be on "general" level. We need a subarea for "search dialog" issues.
But we may decide the... Andreas Müller

12:31 PM bug #7126 (Closed): supplemental data view shows the last selected name data when scrolling down in details view

seems to work Andreas Müller

11:55 AM feature request #6909: Migrate taxon navigator

the NPE is fixed now. Katja Luther

11:30 AM feature request #6909: Migrate taxon navigator

Andreas Müller wrote:
> The clone assistent throws an NPE. All the rest works.
>
this works now, but the servic... Katja Luther

11:43 AM feature request #6595 (Resolved): Migrate name editor

Katja Luther

11:22 AM feature request #6595: Migrate name editor

Andreas Müller wrote:
> Patrick Plitzner wrote:
> > Handler was fixed.
>
> In the old taxon, the synonym group i... Katja Luther

11:05 AM feature request #7056 (Resolved): Media View should show Preview

now the smallest part is used and the library function to compute the smallest part. Katja Luther

12/15/2017

01:22 PM feature request #5687 (In Progress): search for alternative identifiers

the first implementation allows in reference selection dialogs to search for identifier. The user can choose by click... Katja Luther

12:35 PM bug #5823 (In Progress): Fehler beim parallel Editieren von Referenzen

mail from Norbert:
Hallo,
nur der Vollständigkeit halber:
der o.g. bug tritt übrigens regelmäßig auch dann auf... Katja Luther

12/14/2017

08:37 PM feature request #6867 (In Progress): explicitely assign and revoke UPDATE & DELETE permission per enitity in the registration workflow

Andreas Kohlbecker

08:33 PM bug #7114 (Closed): DerivedUnitConverter.convertTo() creates duplicate entities

Andreas Kohlbecker

08:33 PM bug #7114 (Resolved): DerivedUnitConverter.convertTo() creates duplicate entities

Applied in changeset commit:cdm-vaadin|417e3cc850893309eb1910d85195f038f8ea4e1b. Andreas Kohlbecker

12/13/2017

05:52 PM feature request #7137 (Closed): Registration Identifier minter implemented

Andreas Kohlbecker

03:23 PM task #7139 (Rejected): consider using spring profiles to enable vaadin UI contexts

Currently enabling of the vaadin UI contexts is managed through the `CdmVaadinConfiguration` class, specifically by c... Andreas Kohlbecker

01:42 PM feature request #6203: Implement unplaced and excluded in dataportal

Katja Luther wrote:
> In the navigator of the editor the nodes are loaded step by step. Therefore it is difficult to... Katja Luther

01:40 PM feature request #6547 (In Progress): Implement excluded and unplaced in taxon navigator

exist an icon we can use for unplaced or excluded taxa?
I implemented the comparator for putting the excluded and u... Katja Luther

12:16 PM bug #7138 (New): unitils.dbunit data set loading does not work for CdmIntegrationTest

when using @DataSource to load a test data set for a test class which extends `CdmIntegrationTest`, the test db is al... Andreas Kohlbecker

11:03 AM bug #6728 (Resolved): Changing author data when editing a reference does neither update the reference titleCache nor the author label

for references it works as well, collection is adapted, Specimen works as expected.
please review. Katja Luther

10:42 AM bug #6728: Changing author data when editing a reference does neither update the reference titleCache nor the author label

For authors it works correctly now.have to check other dialogs Katja Luther

10:37 AM bug #7126: supplemental data view shows the last selected name data when scrolling down in details view

please review Katja Luther

12/12/2017

09:21 PM feature request #7137 (Resolved): Registration Identifier minter implemented

Andreas Kohlbecker

05:06 PM feature request #7137 (Closed): Registration Identifier minter implemented

* RegistrationIdentifierMinter needs access with direct access to the persitence storage in order to verify a new cre... Andreas Kohlbecker

03:53 PM bug #7135 (Resolved): TeamOrPersonField allows selecting from existing Persons and Teams

Applied in changeset commit:cdm-vaadin|19ba900504996441cc185e02162c5191ea35c0c4. Andreas Kohlbecker

02:51 PM bug #7126 (Resolved): supplemental data view shows the last selected name data when scrolling down in details view

Applied in changeset commit:taxeditor|9dfa2a291fee7ed279036443f81f0dccb5aab9f3. Katja Luther

01:48 PM bug #7126: supplemental data view shows the last selected name data when scrolling down in details view

the supplemental data view always show the last selected object, if a person was selected, this is shown. Katja Luther

01:48 PM feature request #7063: Improve the area selection wizard for distribution editor

Katja Luther wrote:
> The area selection wizard works better now then before. Some minor issues:
>
> * Handling o... Katja Luther

12:36 PM bug #7073 (Resolved): add extension to a name does not result in a dirty state

now the details view is not cleared, when clicking on supplemental data part, this seems to fix the missing dirty fla... Katja Luther

10:34 AM bug #6728 (In Progress): Changing author data when editing a reference does neither update the reference titleCache nor the author label

Katja Luther

10:32 AM bug #7129 (Duplicate): after deduplication bulkeditor should load the entities

Katja Luther

10:32 AM bug #7136 (Duplicate): after deduplication of persons the referencing teams still pointing to the deleted persons

Katja Luther

10:29 AM bug #7136 (Resolved): after deduplication of persons the referencing teams still pointing to the deleted persons

please review Katja Luther

09:15 AM bug #7136 (Duplicate): after deduplication of persons the referencing teams still pointing to the deleted persons

Beim Deduplizieren eines Namens „Kusber“, vielleicht vorher nicht gespeichert, vielleicht Duplikate noch in der Anzei... Katja Luther

10:28 AM bug #7069: Delete taxon node should have consistent configuration

please review
Katja Luther

10:26 AM bug #7069 (Resolved): Delete taxon node should have consistent configuration

Applied in changeset commit:taxeditor|af6f13f92959f08e7a970d6476dcef9298f19fa9. Katja Luther

09:25 AM bug #6917 (Worksforme): NPE during delete of author or team in bulk editor

this is fixed. Katja Luther

12/11/2017

03:20 PM bug #7134: Loading/rendering of name editor takes extremely long for taxa with a lot of synonyms

Andreas Müller wrote:
> As far as I know this is more related to the building of the GUIs due to the way how the nam... Patrick Plitzner

11:42 AM bug #7134: Loading/rendering of name editor takes extremely long for taxa with a lot of synonyms

As far as I know this is more related to the building of the GUIs due to the way how the name editor works and is bui... Andreas Müller

10:30 AM bug #7134 (New): Loading/rendering of name editor takes extremely long for taxa with a lot of synonyms

Example taxon in Campanula production: Campanula rotundifolia
As we don't load a lot of data in terms of bytes the... Patrick Plitzner

01:39 PM bug #7068 (Resolved): Move factual data to a new taxon should use same classification as default

Katja Luther

01:24 PM bug #5823 (Resolved): Fehler beim parallel Editieren von Referenzen

with the actual implementation, I could not reproduce this exception anymore. Editing the reference in name editor an... Katja Luther

12:08 PM bug #7127 (Closed): dangling metacharacter exception in selection dialog

confirming this is fixed! Andreas Kohlbecker

09:40 AM bug #7127 (Resolved): dangling metacharacter exception in selection dialog

Katja Luther

09:40 AM bug #7127 (New): dangling metacharacter exception in selection dialog

should be fixed now. please review. Katja Luther

09:39 AM bug #7127 (Resolved): dangling metacharacter exception in selection dialog

Applied in changeset commit:taxeditor|a3870bd6dd1329d7074bc6380df5ee41d549d503. Katja Luther

12:07 PM bug #7128 (Closed): NPE in selection dialog

This is definitely fixed now! Andreas Kohlbecker

11:55 AM bug #7128 (Resolved): NPE in selection dialog

Katja Luther

09:41 AM bug #7128: NPE in selection dialog

should be fixed now, please review Katja Luther

11:55 AM bug #7135 (Closed): TeamOrPersonField allows selecting from existing Persons and Teams

The TeamOrPersonField needs to be extended by select filed which allows choosing from existing Persons or Team:
![... Andreas Kohlbecker