EDIT

bug #9422

Updated by Andreas Müller almost 3 years ago

During startup the following function is called  

 CdmPreferenceCache.getAllTaxEditorDBPreferences by PreferenceUtil.updateDBPreferences. 

 This code loads the terms very unefficiently if terms are explicitly defined in the local or DB preferences by calling 

 ~~~ 
               List<DefinedTermBase> definedTermBases = termService.load(uuidList, null); 
                 List<TermDto> dtos = new ArrayList<>(); 
                 for (DefinedTermBase<?> term: definedTermBases){ 
                     dtos.add(TermDto.fromTerm(term)); 
                 } 
 ~~~ 

 So there is 1 or more webservice sebservice call(s) for EACH term as dtos.add requires lazy loading. 

 A simple solution could be to at least load all DTOs serverside within 1 service call for all termtypes or atleast for each termtype. 

 Another more dangerous solution could be to use property path, but this is error prone if things change or if a term types needs more loading then defined in the property path. 


 An even better solution (maybe for the future/another ticket) could be to load the preferences asynchronously and / or using a persisted cache via ehcache. However, these solutions are more complex. 

 === 

 In general we should find similar such issues e.g. by switching on CachingHttpInvokerProxyFactoryBean.measureDuration (by using VMarg -Dremoting.httpinvoker.measureDuration=true and setting logging to CachingHttpInvokerProxyFactoryBean to info) which shows you each httpinvoker call and its duration. During development this (or a similar functionality should always be used !!). 

 === 

 A last issue:  

 for CdmPreferenceCache.getAllTaxEditorDBPreferences() the code 

 ~~~ 
         PrefKey key = CdmPreference.NewKey(PreferenceSubject.NewTaxEditorInstance(), PreferencePredicate.AvailableDistributionStatus); 

         if (get(key) != null){ 
             if (!PreferencesUtil.getOverrideForPreference(PreferencePredicate.AvailableDistributionStatus.getKey()) || !get(key).isAllowOverride()){ 
                 //get terms for the uuids... and add them to the termManager as preferred terms 
                 ITermService termService = CdmStore.getService(ITermService.class); 
                 List<UUID> uuidList = new ArrayList<>(); 
                 if (get(key).getValue() != null){ 
                     String[] uuidArray =findBestMatching(key).getValue().split(";"); 
                     for (String uuidString:uuidArray){ 
                         try { 
                             uuidList.add(UUID.fromString(uuidString)); 
                         } catch (Exception e) { 
                             logger.warn("Preference loading failed", e); 
                         } 
                     } 
                 } 

                 List<DefinedTermBase> definedTermBases = termService.load(uuidList, null); 
                 List<TermDto> dtos = new ArrayList<>(); 
                 for (DefinedTermBase<?> term: definedTermBases){ 
                     dtos.add(TermDto.fromTerm(term)); 
                 } 
                 CdmStore.getTermManager().setPreferredTermsByType(dtos, TermType.PresenceAbsenceTerm); 
             } 
         } 
 ~~~ 

 is very redundantly used 3x. This should be deduplicated. Such c&p within the same class almost always shows that code deduplication should be applied. We should try to avoid this in future.

Back