bug #9290
Updated by Andreas Kohlbecker over 3 years ago
As shown in the analysis ( attachment:"TaxonName and Typedesignation citations unequal_diff.xlsx" ) using the `Registration.citation` as `citation` for `TypeDesignations` currently causes inconsistencies. In many cases the Name.nomenclaturalReference is a Section of an Article. Due to the mechanism currently implemented the TypeDesignations receive the Article instead, the article which is the in-reference of the section. This could be corrected for all the found inconsistent cases bout would impose a complex management in the UI to adjust the typeDesignation.citation in case the section reference in the name is being changed. It is better to stop using the Registration.citation as citation for TypeDesignations in all type editors since this does not conform to the intended use of the TypeDesignations.citation property. This also involves to hide the citation and ciation detail for all NameTypes which have `NameTypeDesignationStatus.hasDesignationSource() == false` **Update (2020-11-13):** There is a crucial misconception in the `SpecimenTypeDesignationWorkingSetDTO`: The `SpecimenTypeDesignationWorkingsetEditorPresenter.loadBeanById(Object identifier)` receives in the `identifier` object the referenceId from the `RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event)` method where the reference of the RegistrationWorkingset (e.g. Article) is passed to the type designation workingset: ~~~java identifierSet = new TypeDesignationWorkingsetEditorIdSet( event.getRegistrationUuid(), getView().getCitationUuid(), // FIXME This may pass the reference (e.g. Article) from RegistrationWorkingsetView // to the TypeDesignationWorkingset even if the nomenclatural act is a Section !!! --> #9290 typifiedNameUuid ); ~~~ The `SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto)` in erroneously saves the citation with each of the SpecimenTypeDesignations. This is the cause for in inconsistend data which has been shown in the Excel sheet. For a solution to this problem the following is needed: 1. 'SpecimenTypeDesignationWorkingSetServiceImpl.save(SpecimenTypeDesignationWorkingSetDTO<? extends VersionableEntity> dto)': Stop setting the citation before saving. 1. If the citation is somehow really for the workflow and there is no way to chanage this, we should rather pass the registration reference in `RegistrationWorkingsetPresenter.onTypeDesignationWorkingsetAdd(TypeDesignationWorkingsetEditorAction event)` 1. SpecimenTypeDesignationEditor: Add fields for citation and citationDetail --> #9301