Project

General

Profile

task #8414

Updated by Andreas Kohlbecker over 4 years ago

eu.etaxonomy.cdm.remote.controller.OccurrenceController.doGetOccurencesDTO(@PathVariable(value="uuid") UUID uuid, HttpServletRequest request, HttpServletResponse response) throws IOException 

 * rename to *FieldUnitDTO as it returns `FieldUnitDTO`s 

 * `FieldUnitDTOOccurrenceServiceImpl.findFieldUnitDTO(DerivateDTO derivedUnitDTO, Collection<FieldUnitDTO> fieldUnits, HashMap<UUID, DerivateDTO> alreadyCollectedSpecimen)` misses documentation regarding the optional params which are not being used in most cases (fieldUnits, alreadyCollectedSpecimen) 
     * I think this method should be transactional (readonly) 
     * My first impression is that this method should be split in two methods, one method to get the FieldUnitDTO for a given    DerivedUnit (instead of PreservedSpecimenDTO) and another method which does the more fancy stuff. 
     * The method only adds the derived unit which is passed as parameter, what about all other derived units? These seem to be missing! This **needs to be FIXED** 

 * FieldUnitDTO: 
     * has the field    `taxonRelatedDerivedUnits`. What is the purpose of this field? Is this field filed meant to hold derived units associated to taxa via `IndividualsAssociation`s?  

Back