Project

General

Profile

Actions

bug #9965

closed

Newly created derived unit is not shown in selection dialog

Added by Katja Luther almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
New
Assignee:
Category:
taxeditor
Target version:
Start date:
03/07/2022
Due date:
03/29/2022
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:

Description

mail Nadja Korotkova:

ich habe einen kleinen Bug gefunden

Wenn man ein neues Specimen angelegt hat, kann man es nicht direkt auswählen, man muss erst den Punkt am Ende des Eintrags löschen, oder, bei längerem Text einen Teil des Eintrags, und dann erst kann man das Specimen auswählen.


Related issues

Related to EDIT - bug #9978: Change of CacheStrategy from DerivedUnitFacade to DerivedUnitDefaultCacheStrategy results in different caches for MediaSpecimenIn ProgressKatja Luther

Actions
Related to EDIT - feature request #2506: (Type-) Specimens may need statusClosedAndreas Müller

Actions
Related to EDIT - feature request #9939: Implement specimen status in TaxEditorClosedKatja Luther03/11/202203/31/2022

Actions
Actions #1

Updated by Katja Luther almost 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed, the problem comes from the change of the cache strategy of the derived unit to DerivedUnitFacadeDefaultCacheStrategy. Please review.

If everything is ok, i would clean up the code and delete the obsolete code.

Actions #2

Updated by Andreas Müller almost 2 years ago

  • Target version changed from Release 5.45 to Release 5.31
Actions #3

Updated by Andreas Müller almost 2 years ago

  • Due date set to 03/16/2022
  • Start date set to 03/07/2022
  • % Done changed from 0 to 50
Actions #4

Updated by Andreas Müller almost 2 years ago

  • Related to bug #9978: Change of CacheStrategy from DerivedUnitFacade to DerivedUnitDefaultCacheStrategy results in different caches for MediaSpecimen added
Actions #5

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 50 to 60

As discussed, the implementation leads to follow up problems due to implementations in the MediaSpecimenCacheStrategy (see #9978). As fixing this will take more time for now we will revert the changes for this ticket and instead adapt the FacadeCacheStrategies and remove the trailing dots there in the same way as we did in the SpecimenCacheStrategy.

Actions #6

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Resolved
Actions #7

Updated by Andreas Müller almost 2 years ago

  • % Done changed from 60 to 80
Actions #8

Updated by Katja Luther almost 2 years ago

  • Assignee changed from Katja Luther to Andreas Müller

Actually a workaround is implemented with removing the trailing dot in the facade cache strategy, please review for the actual release and the correct implementation will follow with a new ticket or reopening this ticket.

Actions #9

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 80 to 90

This works as expected.

Can you still add the commits from dataportal to the ticket and then close it?

Actions #10

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Closed

Added the dataportal commits, so we can close this ticket

Actions #11

Updated by Andreas Müller almost 2 years ago

  • % Done changed from 90 to 100
Actions #12

Updated by Andreas Müller almost 2 years ago

  • Due date changed from 03/16/2022 to 03/29/2022
  • Status changed from Closed to Feedback
  • % Done changed from 100 to 80

I have to reopen as this does not yet work if the derived unit has stats (not seen, ...). This is new and is not yet impelemented accordingly for the facade.

Actions #13

Updated by Andreas Müller almost 2 years ago

Actions #14

Updated by Katja Luther almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

Andreas Müller wrote in #note-12:

I have to reopen as this does not yet work if the derived unit has stats (not seen, ...). This is new and is not yet impelemented accordingly for the facade.

This should be fixed with the last commit.

Actions #15

Updated by Andreas Müller almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 80 to 100

This works as expected now.

Actions

Also available in: Atom PDF