EDIT

Duplication only happens in UniversalViewer (using the ManifestController.doTaxonMedia()) code. Switching to simple viewer does not show duplicates.

Applied in changeset cdmlib|75539fa3b6e75f1972f2c3e3f90a3b395ea9d356.

The reason for the duplicates was that in TaxonServiceImpl.listMedia() media were not deduplicate if e.g. an image of a MediaSpecimen was also attached via image gallery to an occurrence. This is dirty data but happenes due to a bug in ABCD import.

I added deduplication if duplicated images exist for whatever reason. Additionally I fixed the ABCD bug to avoid such media duplicates in future.

AK can you please review if the result is as expected.

KL can you please review the fix for ABCD.

For de-duplicating the Media in TaxonService.listMedia() I suggest to use a more modern java code style:

taxonMedia = taxonMedia.stream().distinct().collect(Collectors.toList());

this way the CdmUtils.removeIdentical() method can be removed - it is used only once in the library.

Andreas Kohlbecker wrote in #note-7:

For de-duplicating the Media in TaxonService.listMedia() I suggest to use a more modern java code style:

taxonMedia = taxonMedia.stream().distinct().collect(Collectors.toList());

this way the CdmUtils.removeIdentical() method can be removed - it is used only once in the library.

Good point. I adapted the code accordingly. Can you check again and then pass the ticket to KL?

Excellent!

@Katja: I's your turn now.

The ABCD Import code is correct, too. So I think we can close this ticket.