Project

General

Profile

Actions
Copy link

bug #9821

closed

Description sources shown for description elements should not be editable

Added by Andreas Müller over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Highest
Assignee:
Katja Luther
Category:
taxeditor
Target version:
Release 5.28
Start date:
Due date:
% Done:

100%

Estimated time:
Severity:
normal
Found in Version:
Tags:
additivity

Description

Since #7774 sources for descriptions are shown in the details view for description elements.
However, they should not be editable there to avoid misunderstandings. But currently they are.
We should disable them.

Related issues

Related to EDIT - feature request #7774: Show description source for description elementsClosedKatja Luther

Actions
Actions
Copy link
 #1

Updated by Andreas Müller over 2 years ago

Actions
Copy link
 #2

Updated by Katja Luther over 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Katja Luther to Andreas Müller

This should be fixed. Please review.

Actions
Copy link
 #3

Updated by Andreas Müller over 2 years ago

  • Assignee changed from Andreas Müller to Katja Luther
Actions
Copy link
 #4

Updated by Katja Luther over 2 years ago

  • Assignee changed from Katja Luther to Andreas Müller

Tested with Descripta prima Dall. in Descriptive DS test.

Categorical as well as quantitative data worked as expected.

Actions
Copy link
 #5

Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 0 to 30

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

Actions
Copy link
 #6

Updated by Katja Luther over 2 years ago

  • Status changed from Feedback to Resolved

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:

  • Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
  • the source is shown and disabled.
  • but still a problem if the section is collapsed before.
Actions
Copy link
 #7

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.45 to Release 5.28
Actions
Copy link
 #8

Updated by Katja Luther over 2 years ago

  • Status changed from Resolved to In Progress
Actions
Copy link
 #9

Updated by Katja Luther over 2 years ago

Katja Luther wrote:

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:

  • Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
  • the source is shown and disabled.
  • but still a problem if the section is collapsed before.

this should be fixed, now

Actions
Copy link
 #10

Updated by Katja Luther over 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Katja Luther to Andreas Müller
  • Target version changed from Release 5.28 to Release 5.45

Katja Luther wrote:

Katja Luther wrote:

Andreas Müller wrote:

It works for sources loaded during the session but not yet for sources created during the session.

I created a new sources for a description and then went to the description element and could edit the source there. After reopening the taxon it worked as expected.

This was not a problem of a new source, but of more than one source, this problem is fixed.
Tested with nightly:

  • Open Descripta secunda Gall. add a new source to the description "Distributions for Descripta secunda Gall." add a new source and switch to one of the distributions
  • the source is shown and disabled.
  • but still a problem if the section is collapsed before.

this should be fixed, now

tested with nightly and is fixed. please review.

Actions
Copy link
 #11

Updated by Andreas Müller over 2 years ago

  • Target version changed from Release 5.45 to Release 5.28

I guess the change of milestone was accidentally

Actions
Copy link
 #12

Updated by Andreas Müller over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee changed from Andreas Müller to Katja Luther
  • % Done changed from 30 to 100

Works as expected.

Actions
Copy link

Also available in: Atom PDF