Project

General

Profile

feature request #9674

footnote keys for annotations to multilanguageText name descriptions inside brackets

Added by Andreas Kohlbecker 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Highest
Category:
cdm-dataportal
Target version:
Start date:
06/16/2021
Due date:
% Done:

100%

Severity:
normal

Description

Gymnocalycium saglionis (Cels) Britton & Rose, Cactaceae 3: 157. 1922 [Original spelling of epithet should be maintained. ]A

irgendwie fände ich es besser, wenn die Referenz-Fußnote in der eckigen Klammer stehen würde.

http://caryophyllales.org/cactaceae/cdm_dataportal/taxon/73560e8a-aecf-4326-90b2-4ed7bf7ecec2

Was passiert eigentlich, wenn es mehrere Notes gibt? Mehrere eckige Klammern? Wenn da konkateniert würde (was schöner wäre), müsste die Referenz ja in die Klammer.

picture939-1.png View (3.09 KB) Andreas Müller, 06/16/2021 05:03 PM


Related issues

Related to Edit - bug #9709: remove undesired dots from synonymy entries New 07/15/2021

Associated revisions

Revision c4dd76b6 (diff)
Added by Andreas Kohlbecker 4 months ago

fix #9674 footnote keys for annotations to multilanguageText name descriptions inside brackets

Revision e9970345 (diff)
Added by Andreas Kohlbecker 4 months ago

ref #9674 footnote keys for annotations to multilanguageText name descriptions inside brackets - tests adapted

Revision 54127ad4 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #9674 triming description_element->multilanguageText

Revision 591f74e1 (diff)
Added by Andreas Kohlbecker 3 months ago

ref #9674 removing dot

Revision b15c610a (diff)
Added by Andreas Kohlbecker 3 months ago

Revert "ref #9674 removing dot"

This reverts commit 591f74e183942f552e78098a794fc4bd20ba4824.

removing the dot raises 15 errors in the selenium tests, needs discussion!

History

#1 Updated by Andreas Kohlbecker 4 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 50

#2 Updated by Andreas Müller 4 months ago

Aber das original spelling wird hier nicht mit ausgegeben: as „saglione“ – kann man das einstellen? In CDM-light kommt’s wohl raus.

This part of the description does not seem to be handled in this ticket, so maybe we should remove it from the description? Otherwise you find this ticket erronously when searching for original spelling issues.

#3 Updated by Andreas Kohlbecker 4 months ago

  • Description updated (diff)

thanks for that hint.

#4 Updated by Andreas Müller 4 months ago

On the linked site above there is also an unnecessary whitespace before the closing bracket and a full stop after footnote key before "sec." . These should also be removed if not yet done:

#5 Updated by Andreas Kohlbecker 3 months ago

This is the link to the according test-server portal page http://test.e-taxonomy.eu/dataportal/preview/caryophyllales_spp/cdm_dataportal/taxon/73560e8a-aecf-4326-90b2-4ed7bf7ecec2

I removed the space by trimming the description element text.
The dot at the end of the string needs more careful consideration as it seems if this could have been a requirement in some situations. Removing the dot raises 15 errors in the selenium test. The need to release very soon does not allow to care for this now.

The request referenced in comment 2 seems to be misplaced since i can't find this text in the ticket description:

Aber das original spelling wird hier nicht mit ausgegeben: as „saglione“ – kann man das einstellen? In CDM-light kommt’s wohl raus.

So I am closing this issue now, please open a new ticket for the dot-issue if needed.

#6 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 50 to 100

#7 Updated by Andreas Müller 3 months ago

Andreas Kohlbecker wrote:

The request referenced in comment 2 seems to be misplaced since i can't find this text in the ticket description:

It is not misplaced but deleted (by yourself in #note-3 as requested.

#8 Updated by Andreas Müller 3 months ago

  • Status changed from Closed to Feedback
  • % Done changed from 100 to 90

Andreas Kohlbecker wrote:

The dot at the end of the string needs more careful consideration as it seems if this could have been a requirement in some situations. Removing the dot raises 15 errors in the selenium test. The need to release very soon does not allow to care for this now.

Are we talking here about the dot after the end-bracket or before the footnote/at the end of the string. The later should stay, I agree. But I was talking about the dot after the bracket. This is not needed as normally synonymy entries do not end with a dot and also before "sec." you never have a dot.

#9 Updated by Andreas Müller 3 months ago

By the way, the test portal puts the note to the end while on production it is before sec which makes the situation worse and definetely wrong

#10 Updated by Andreas Kohlbecker 3 months ago

  • Related to bug #9709: remove undesired dots from synonymy entries added

#11 Updated by Andreas Kohlbecker 3 months ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

new ticket for this: #9709

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 40 MB)