EDIT

I checked in old databases from 12_2020 (before nomenclatural sources movement) and 04_2021 (before deleting old TaxonName.nomenclaturalCitation_id column).
In none of the databases there was an indication why these records were created. So I deleted them form OriginalSourceBase adn OriginalSourceBase_AUD (for strange reason theses records were created also in AUD while other nom.source records are not audited before the 12_2020 move).

Please review. The page shows no error anymore: http://portal.cybertaxonomy.org/flora-malesiana-prospective/cdm_dataportal/taxon/2debf5ee-cb57-40bc-af89-173d1d17cefe/specimens

However, I still get an empty result for the api query in the description (http://api.cybertaxonomy.org/flora-malesiana-prospective/portal/taxon/2debf5ee-cb57-40bc-af89-173d1d17cefe/rootUnitDTOs.json)

the original exception has disappeared, but now the request portal/taxon/2debf5ee-cb57-40bc-af89-173d1d17cefe/rootUnitDTOs.json

fails with a ClassCastException:

Caused by: java.lang.ClassCastException: ReadablePartial objects must have matching field types
    at org.joda.time.base.AbstractPartial.compareTo(AbstractPartial.java:315)
    at eu.etaxonomy.cdm.api.service.OccurrenceServiceImpl$1.compare(OccurrenceServiceImpl.java:586)
    at eu.etaxonomy.cdm.api.service.OccurrenceServiceImpl$1.compare(OccurrenceServiceImpl.java:1)
    at java.util.TimSort.binarySort(TimSort.java:296)
    at java.util.TimSort.sort(TimSort.java:239)
    at java.util.Arrays.sort(Arrays.java:1512)
    at java.util.ArrayList.sort(ArrayList.java:1454)
    at java.util.Collections.sort(Collections.java:175)
    at eu.etaxonomy.cdm.api.service.OccurrenceServiceImpl.listRootUnitDTOsByAssociatedTaxon(OccurrenceServiceImpl.java:570)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:333)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
    at org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:99)
    at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:283)
    at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:96)
    at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
    at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:213)
    at com.sun.proxy.$Proxy179.listRootUnitDTOsByAssociatedTaxon(Unknown Source)
    at eu.etaxonomy.cdm.remote.controller.TaxonController.doListRooUnitDTOs(TaxonController.java:344)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205)
    at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:133)
    at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:97)
    at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:854)
    at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:765)
    at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
    at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:967)
    at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:901)
    at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970)
    ... 67 more

this should be fixed before releasing

This problem occurs due to using the compareTo method for gatheringEvent.timeperiod.start in the newly updated comparator for listRootUnitDTOsByAssociatedTaxon.
Timeperiod.start is a partial and compareTo therefore must only be used if partial.size() is equal as documented in the javadoc.

In a first step I excluded now all empty timeperiod.start partials from comparison to avoid the above exception which is probably thrown due to a timeperiod using freetext instead of start.
However, further adaptation is needed to allow comparison of partials also for partials only having any of the year, month or day fields set.

This should be fully fixed now. Comparing partials may not throw an exception anymore. Only the order of gathering events with date and without date may have changed so we need to check if all dataportal tests still run.

Generally we order dates with no information to the end (=largest date). This previoursly has been implemented in listRootUnitDTOsByAssociatedTaxon() the other way round as far as I can see.

Please reveiw.

The above request is now ok and does no longer throw an exception.

Sort order deviation in the portal an be neglected for now. We can handle these later if needed.