https://dev.e-taxonomy.eu/redmine/https://dev.e-taxonomy.eu/redmine/redmine/favicon.ico?14691914852021-05-10T14:35:45ZEDIT Project ManagementEDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606372021-05-10T14:35:45ZAndreas Kohlbecker
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-5 priority-11 priority-default closed" href="/redmine/issues/9617">task #9617</a>: Rename ICNB to ICNP</i> added</li></ul> EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606382021-05-10T15:16:56ZAndreas Müller
<ul><li><strong>Target version</strong> changed from <i>Unassigned CDM tickets</i> to <i>Release 5.25</i></li></ul><p>NomenclaturalCodeEdition entry names are pure enum "names" not used for anything else. So we can rename them but there is no big need for this as they should never be shown to the user in anyway. Having all the same prefix has a certain advantage for sorting. Needs discussion.</p>
<p>This differs from NomenclaturalCode, where the abbreviation is also used as a title that is shown to users (but there we only use the current code abbreviation for pratical reasons.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606402021-05-10T15:18:19ZAndreas Müller
<ul><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li></ul> EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606582021-05-11T13:09:55ZAndreas Kohlbecker
<ul><li><strong>File</strong> <a href="/redmine/attachments/2044">picture859-1.png</a> <a class="icon-only icon-download" title="Download" href="/redmine/attachments/download/2044/picture859-1.png">picture859-1.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>NomenclaturalCodeEdition entry names are pure enum "names" not used for anything else. So we can rename them but there is no big need for this as they should never be shown to the user in anyway. Having all the same prefix has a certain advantage for sorting. Needs discussion.</p>
<p>This differs from NomenclaturalCode, where the abbreviation is also used as a title that is shown to users (but there we only use the current code abbreviation for pratical reasons.</p>
</blockquote>
<p>These "practical" reasons lead to impractical result, as shown in this screen shot:</p>
<p><img src="https://dev.e-taxonomy.eu/redmine/attachments/download/2044/picture859-1.png" alt="" /></p>
<p>There are indeed two problems as there is no way to get the correct representation of the code edition from one of both enums.</p>
<ol>
<li>For many current codes the <code>NomenclaturalCodeEdition</code> enum name is the only source for the correct code acronym, like "ICN"</li>
<li>There is no way to get the correct code acronym for historic editions, as these are completely missing in the cdm.</li>
</ol>
<p><strong>Suggestion:</strong> We should extend the <code>NomenclaturalCode</code> by year range dependent representation, an additional <code>getLabel</code> methods would have a second paramter:</p>
<pre><code class="java syntaxhl">
<span class="n">getLabel</span><span class="o">(</span><span class="nc">Integer</span> <span class="n">year</span><span class="o">);</span>
<span class="n">getLabel</span><span class="o">(</span><span class="nc">Language</span> <span class="n">language</span><span class="o">,</span> <span class="nc">Integer</span> <span class="n">year</span><span class="o">);</span>
</code></pre>
<p>that is <code>NomenclaturalCode.ICNAFP.getLabel(2011)</code> would return "ICN", whereas <code>NomenclaturalCode.ICNAFP.getLabel(2005)</code> would return "ICBN"</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606662021-05-11T14:30:17ZAndreas Müller
<ul></ul><p>I was not in cc of this ticket anymore therefore I missed the discussion.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606682021-05-11T14:35:56ZAndreas Müller
<ul><li><strong>File</strong> <a href="/redmine/attachments/2045">picture429-1.png</a> <a class="icon-only icon-download" title="Download" href="/redmine/attachments/download/2045/picture429-1.png">picture429-1.png</a> added</li></ul><p>But I do not understand what we need the abbreviation for. It is really an important information to show the abbreviation of the code? In the TaxEditor we do it the following way: </p>
<p><img src="https://dev.e-taxonomy.eu/redmine/attachments/download/2045/picture429-1.png" alt="" /></p>
<p>which to me seems fully enough.</p>
<p>However, if there is a user requirement to show the historic code abbreviation then we should add it as a parameter in the enum (which is very easy to create, once someone gives me the full list, e.g. for the 1867 code I have no idea what the abbrev is).<br>
To misuse the enum name for this to me does not seem to be the correct way and is against the general CDM philosophy use enum names neither as names nor as labels. </p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606702021-05-11T14:46:46ZAndreas Kohlbecker
<ul><li><strong>Assignee</strong> changed from <i>Andreas Kohlbecker</i> to <i>Andreas Müller</i></li></ul><p>The Taxeditor is not the only UI we have. There is the UI where I took the screenshot from, therefore I don't quite understand your point.</p>
<p>What if this information is to be shown the Data Portal, would you just write "Cambridge 1935" without stating which code this is about? This is for sure not sufficient.</p>
<blockquote>
<p>To misuse the enum name for this to me does not seem to be the correct way and is against the general CDM philosophy use enum names neither as names nor as labels. </p>
</blockquote>
<p>I don't understand why you repeat this point, this is already discussed to an end. I made a specific suggestion how this can be solved? Do you need more details on this? </p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606842021-05-11T16:03:59ZAndreas Müller
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>Assignee</strong> changed from <i>Andreas Müller</i> to <i>Andreas Kohlbecker</i></li></ul><p>You mean the "Suggestion" above?</p>
<p>I do not understand why this needs to be a method for NomenclaturalCode.</p>
<p>Why not simply NomenclaturalCodeEditon.getLabel() . This is what I meant with "if there is a user requirement to show the historic code abbreviation then we should add it as a parameter". I implemented it this way now.</p>
<p>But as I mentioned above I need a full list of all correct abbreviations for all codes. As long as this list does not exist the abbreviations may not be correct.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=606902021-05-11T16:57:48ZAndreas Müller
<ul></ul><blockquote>
<p>What if this information is to be shown the Data Portal, would you just write "Cambridge 1935" without stating which code this is about? This is for sure not sufficient.</p>
</blockquote>
<p>From my experience taxonomist say "Shenshen code" not "ICN 2017 Shenszhen" therefore I didn't expect that the abbreviation is needed. Also not on the data portal. But I might be wrong.<br>
Also in the phycobank editor I can't really see what the advantage is to add the code abbreviation in the drop down label. But this might become clearer with the context which is missing on the screenshot.</p>
<p>Anyways, the problem should be solved now.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607162021-05-12T08:27:20ZAndreas Kohlbecker
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Solution accepted. Ticket can be closed.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607172021-05-12T08:48:07ZAndreas Müller
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>But as I mentioned above I need a full list of all correct abbreviations for all codes. As long as this list does not exist the abbreviations may not be correct.</p>
</blockquote>
<p>This list does not yet exist. Henning, can you provide such a list?</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607192021-05-12T09:04:35ZAndreas Kohlbecker
<ul></ul><p>here is one kind of list <a href="https://www.iapt-taxon.org/historic/index.htm">https://www.iapt-taxon.org/historic/index.htm</a></p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607202021-05-12T09:27:40ZWolf-Henning Kusber
<ul></ul><p>Yes, will do two lissts, (i) a short citation, and (ii) correct citations with help of the literature in our library.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607212021-05-12T09:33:40ZAndreas Kohlbecker
<ul></ul><p>diese Liste dürfte vollständig sein <a href="https://www.iapt-taxon.org/historic/list-of-Codes.htm">https://www.iapt-taxon.org/historic/list-of-Codes.htm</a></p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607222021-05-12T09:40:10ZAndreas Müller
<ul></ul><p>Andreas Kohlbecker wrote:</p>
<blockquote>
<p>diese Liste dürfte vollständig sein <a href="https://www.iapt-taxon.org/historic/list-of-Codes.htm">https://www.iapt-taxon.org/historic/list-of-Codes.htm</a></p>
</blockquote>
<p>The list only includes botanical codes. All other codes are missing.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607242021-05-12T10:11:35ZAndreas Kohlbecker
<ul></ul><p>Isn't this a good start? We can add more lists on demand.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607252021-05-12T10:19:25ZAndreas Müller
<ul></ul><p>Die Liste enthält leider keine Abkürzungen, um die es aber gerade ging. Letztlich kann ich nur raten. War der "Vienna Code" ein Irbn? Es fehlen auch die "Laws" von 1867.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607262021-05-12T10:23:04ZAndreas Müller
<ul></ul><p>Zudem die Frage, wie mit den Langformen umzugehen ist. Bislang hatten wir uns darauf geeinigt, lediglich DOIs oder URLs in die enum mit aufzunehmen. Langformen sind deutlich problematischer wegen dem Formatierungsproblem. Wenn das wirklich notwendig ist, sollten wir daraus ein separates Ticket machen. Dieses Ticket verstehe ich primär als Ticket für Abkürzungen.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607272021-05-12T10:26:29ZWolf-Henning Kusber
<ul></ul><p>Rein inhaltlich. Mindestens für das Projekt PhycoBank benötigen wir den Link zum Vollzitat. Ich gehe davon aus, das defaultmäßig nur das Kurzzitat angezeigt werden soll.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=607422021-05-12T13:16:24ZAndreas Kohlbecker
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Die Liste enthält leider keine Abkürzungen, um die es aber gerade ging. </p>
</blockquote>
<p>Aus einem Chat mit Henning: "<em>Prima, auf der Basis können wir Kurzzitate erstellen. Da müssten Autor jahr, Kurzzitat, z.B. ICBN und Ort der Konferenz und Jahr der Konferenz rein, eventuell kann man da noch kürzen.</em>"<br>
Das ist also in Arbeit.</p>
<blockquote>
<p>Letztlich kann ich nur raten.</p>
</blockquote>
<p>musst du also nich ;-) </p>
<blockquote>
<p>War der "Vienna Code" ein Irbn? </p>
</blockquote>
<p>Hierbei steht "International Rules of Botanical Nomenclature" aslo eher nicht, ob das Akromyn nun IRBN ist wird Henning klären.</p>
<blockquote>
<p>Es fehlen auch die "Laws" von 1867.</p>
</blockquote>
<p>Guter Hinweis und auch ein Task für Henning.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=608962021-05-17T07:52:38ZAndreas Müller
<ul><li><strong>Target version</strong> changed from <i>Release 5.25</i> to <i>Release 5.23</i></li></ul> EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=610222021-05-21T06:01:28ZAndreas Müller
<ul></ul><p>looks like the final list is still missing</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=610252021-05-21T06:55:12ZAndreas Kohlbecker
<ul></ul><p>Andreas Müller wrote:</p>
<blockquote>
<p>Andreas Kohlbecker wrote:</p>
<blockquote>
<p>diese Liste dürfte vollständig sein <a href="https://www.iapt-taxon.org/historic/list-of-Codes.htm">https://www.iapt-taxon.org/historic/list-of-Codes.htm</a></p>
</blockquote>
<p>The list only includes botanical codes. All other codes are missing.</p>
</blockquote>
<p>This ticket is only about the botanical codes.</p>
<p>Please create a new ticket for the full reference list of other codes if needed.</p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=611022021-06-01T09:57:45ZWolf-Henning Kusber
<ul></ul><p>New Ticket: <a class="issue tracker-5 status-5 priority-12 priority-high14 closed" title="feature request: Updated List ICN/ICBN editions (Closed)" href="https://dev.e-taxonomy.eu/redmine/issues/9640">#9640</a></p>
EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=611162021-06-01T13:05:11ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-5 status-5 priority-12 priority-high14 closed" href="/redmine/issues/9640">feature request #9640</a>: Updated List ICN/ICBN editions</i> added</li></ul> EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=644652022-02-11T13:25:45ZAndreas Kohlbecker
<ul><li><strong>Tags</strong> set to <i>phycobank</i></li></ul> EDIT - bug #9618: fix historic NomenclaturalCodeEdition names ICN -> ICBNhttps://dev.e-taxonomy.eu/redmine/issues/9618?journal_id=697912023-06-06T17:47:38ZAndreas Müller
<ul><li><strong>Related to</strong> <i><a class="issue tracker-6 status-5 priority-10 priority-lowest closed" href="/redmine/issues/10302">task #10302</a>: Revise Status section</i> added</li></ul>